)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b6faecc0eedbffb99ba79a17e3b720410e18315c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"miss genericswitch mac address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we miss the genericswitch mac address in config file,"},{"line_number":10,"context_line":"the neutron server won\u0027t find the switch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie014e3dce5f56942202641e123c430dd94e5e4b7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_049c2a5b","line":10,"updated":"2018-01-08 09:07:33.000000000","message":"NOTE: The MAC address isn\u0027t a mandatory option. I always use a hostname, and set local_link_connection/switch_info\u003d\u003chostname\u003e on ironic ports.","commit_id":"03b47c6f26200bd39058ce8669c5953c41284cd7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a31bb689edab713fed7ae43c37beb02d7b14825c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"miss genericswitch mac address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we miss the genericswitch mac address in config file,"},{"line_number":10,"context_line":"the neutron server won\u0027t find the switch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie014e3dce5f56942202641e123c430dd94e5e4b7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_279db0bb","line":10,"updated":"2018-01-08 09:34:33.000000000","message":"Then do we need this change at all? Overall, this patch confuses me. It adds ngs_mac_address to the generic example, but does not add it to any switch-specific example below. Why is that?","commit_id":"03b47c6f26200bd39058ce8669c5953c41284cd7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"20f13a60e91b02476182fd152f3d33c0aaa8840c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"miss genericswitch mac address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we miss the genericswitch mac address in config file,"},{"line_number":10,"context_line":"the neutron server won\u0027t find the switch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie014e3dce5f56942202641e123c430dd94e5e4b7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_aafae5b9","line":10,"in_reply_to":"9f91af0f_072bcc2f","updated":"2018-01-08 10:42:36.000000000","message":"Okay, I agree that\u0027s a useful addition, but I don\u0027t agree with the way it\u0027s done. First, I\u0027d suggest to set it in all examples, if at all. Second, I\u0027d suggest a .. note:: explaining why it\u0027s done and what the alternatives are.","commit_id":"03b47c6f26200bd39058ce8669c5953c41284cd7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9dcb24d93de660aa1956ed826b824e3d974e7fba","unresolved":false,"context_lines":[{"line_number":7,"context_line":"miss genericswitch mac address"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we miss the genericswitch mac address in config file,"},{"line_number":10,"context_line":"the neutron server won\u0027t find the switch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie014e3dce5f56942202641e123c430dd94e5e4b7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_072bcc2f","line":10,"in_reply_to":"9f91af0f_279db0bb","updated":"2018-01-08 09:48:40.000000000","message":"You can use the switch MAC address to identify switches if local_link_connection/switch_info is not set. It needs to be set in local_link_connection/switch_id, which the inspector plugin will do for you. The inspector plugin will not set local_link_connection/switch_info, so I think this change is useful. What would be more useful would be better docs in general for NGS :)","commit_id":"03b47c6f26200bd39058ce8669c5953c41284cd7"}]}