)]}'
{"networking_generic_switch/devices/netmiko_devices/__init__.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"2b99979ecee695ceadc587979977de34aee7b8b0","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    REMOVE_NETWORK_FROM_TRUNK \u003d None"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    SAVE_CONFIGURATION \u003d None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def __init__(self, device_cfg):"},{"line_number":52,"context_line":"        super(NetmikoSwitch, self).__init__(device_cfg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_55689f85","side":"PARENT","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":29},"updated":"2018-03-13 07:20:54.000000000","message":"and leave this in place too :-)","commit_id":"1e64e683cfd88f583597f6301f935c06a04b1ca4"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"95e7b66aa363111e9685ffe9d63209140237e1f4","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        try:"},{"line_number":207,"context_line":"            net_connect.save_config()"},{"line_number":208,"context_line":"        except NotImplementedError:"},{"line_number":209,"context_line":"            LOG.debug(\"Saving config is not supported for %s, all \""},{"line_number":210,"context_line":"                      \"changes will be lost after switch reboot\","},{"line_number":211,"context_line":"                      self.config[\u0027device_type\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_52299598","line":209,"updated":"2018-03-13 07:15:34.000000000","message":"I would also leave the previous code here in the exception handler to have possibility to implement save_config support for switches that might not yet support this in netmiko, so smth like\n\n  try:\n      net_connect.save_config()\n  except NotImplementedError:\n      if self.SAVE_CONFIGURATION:\n          # do smth\n      else:\n          LOG.warning(...)\n\nAlso I\u0027d like to throw a warning log here instead of debug, hinting ops that they might want look into implementing the SAVE_CONFIGURATION for the switch they are using with n-g-s","commit_id":"cb3dd9bed0b1de3b6eb0391533ef3fc1e9630a05"}],"networking_generic_switch/devices/netmiko_devices/arista.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1a9c5de9c7486bbbf458b7e19aab59b3f0e51fc5","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        SAVE_CONFIGURATION \u003d ("},{"line_number":42,"context_line":"            \u0027write memory\u0027,"},{"line_number":43,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_755c087e","side":"PARENT","line":43,"updated":"2018-03-09 10:59:56.000000000","message":"Have you verified that netmiko supports saving config for arista devices so that we don\u0027t regress here?","commit_id":"1e64e683cfd88f583597f6301f935c06a04b1ca4"},{"author":{"_account_id":10453,"name":"octopuszhang","email":"zhangyf@rc.inesa.com","username":"1"},"change_message_id":"1ea5aea2fad98f3e26038adbc82e81db9f8d227c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        SAVE_CONFIGURATION \u003d ("},{"line_number":42,"context_line":"            \u0027write memory\u0027,"},{"line_number":43,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_77d70c25","side":"PARENT","line":43,"in_reply_to":"df7087c5_755c087e","updated":"2018-03-12 03:33:11.000000000","message":"I have no arista devices, but in patch for save_config, maintainer of netmiko said \"I will test on real/virtual devices for all the platforms listed on the README.md as regularly tested. I won\u0027t test on anything else (as I don\u0027t have the device to test against).\" , and arista eos is tagged as regular supported in netmiko\u0027s README.\n\nAlso I spend some hours reading netmiko code and seaching arista documeents, it will do two things when run save_config for arista:\n1.enter config mode\n2.copy running-config startup-config\n\nFor the first step, the save_configuration implement in ngs doesn\u0027t enter enable mode, but ngs\u0027s save_configuration is only called after send_config_set method and they share the same \u0027net_connect\u0027, send_config_set always enter config mode in it.\n\nFor the second step, ngs use \u0027write memory\u0027 while netmiko use \u0027copy running-config startup-config\u0027, I searched the arista documents, I thinks they have the same effect.\n\nSo，logically, it looks good. If you can help test save_config on the hardware, it\u0027s better.","commit_id":"1e64e683cfd88f583597f6301f935c06a04b1ca4"}]}