)]}'
{"networking_generic_switch/devices/netmiko_devices/dell.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"664fcdb5885a79c7f1a898c58cd9e3b06c019d6c","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, device_cfg):"},{"line_number":66,"context_line":"        super(DellPowerConnect, self).__init__(device_cfg)"},{"line_number":67,"context_line":"        port_mode \u003d self.config.get(\u0027ngs_switchport_mode\u0027, \u0027access\u0027)"},{"line_number":68,"context_line":"        switchport_mode \u003d {"},{"line_number":69,"context_line":"            \u0027general\u0027: self._switch_to_general_mode,"},{"line_number":70,"context_line":"            \u0027access\u0027: lambda: ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_74729d14","line":67,"updated":"2018-07-16 10:38:45.000000000","message":"I think this needs to be moved to self.ngs_config - config in self.config will be passed through to netmiko.\n\nYou can add the option to the list in networking_generic_switch/devices/__init__.py, and also set the default there.","commit_id":"12126afb1e83ee9f6fb633e5043ee12c82877f46"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"67883870a829998d566c58890fbdfb9989c551b5","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, device_cfg):"},{"line_number":66,"context_line":"        super(DellPowerConnect, self).__init__(device_cfg)"},{"line_number":67,"context_line":"        port_mode \u003d self.config.get(\u0027ngs_switchport_mode\u0027, \u0027access\u0027)"},{"line_number":68,"context_line":"        switchport_mode \u003d {"},{"line_number":69,"context_line":"            \u0027general\u0027: self._switch_to_general_mode,"},{"line_number":70,"context_line":"            \u0027access\u0027: lambda: ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d20aa0cf","line":67,"in_reply_to":"5f7c97a3_74729d14","updated":"2018-07-16 14:00:42.000000000","message":"should we pollute that dictionary with driver specific details? Maybe we could add a virtual method, get_internal_options, that you can override in the driver?","commit_id":"12126afb1e83ee9f6fb633e5043ee12c82877f46"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"d27af80c8d182128cf954b8fc316af3bd354d28f","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, device_cfg):"},{"line_number":66,"context_line":"        super(DellPowerConnect, self).__init__(device_cfg)"},{"line_number":67,"context_line":"        port_mode \u003d self.config.get(\u0027ngs_switchport_mode\u0027, \u0027access\u0027)"},{"line_number":68,"context_line":"        switchport_mode \u003d {"},{"line_number":69,"context_line":"            \u0027general\u0027: self._switch_to_general_mode,"},{"line_number":70,"context_line":"            \u0027access\u0027: lambda: ()"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b8c7c33d","line":67,"in_reply_to":"5f7c97a3_d20aa0cf","updated":"2018-07-16 14:05:20.000000000","message":"I decided having all the config options in one place was a better solution as conflicts are harder to see if each class maintains it\u0027s own list.","commit_id":"12126afb1e83ee9f6fb633e5043ee12c82877f46"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6c347b1ce6278b5d774dc4deea2c03a5904da34d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                allowed_options\u003dswitchport_mode.keys()"},{"line_number":77,"context_line":"            )"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        switchport_mode.get(port_mode.lower(), on_invalid_switchmode)()"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":82,"context_line":"        \u0027vlan database\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_5eae6580","line":79,"updated":"2018-07-30 10:10:01.000000000","message":"nit: this works but is quite confusing.. I\u0027m pretty sure it could be replaces with \"if\" statements quite easily","commit_id":"e3878ac7e1cac09e98690a5daa7f14979635abe2"}]}