)]}'
{"networking_generic_switch/devices/netmiko_devices/juniper.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"3f42939d130f3df3c3ab681bd90dc0c904190093","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                # Netmiko raises ValueError on commit failure, and appends the"},{"line_number":132,"context_line":"                # CLI output to the exception message. Raise a more specific"},{"line_number":133,"context_line":"                # exception for a locked DB, on which tenacity will retry."},{"line_number":134,"context_line":"                DB_LOCKED_MSG \u003d \"error: configuration database locked\""},{"line_number":135,"context_line":"                if DB_LOCKED_MSG in str(e):"},{"line_number":136,"context_line":"                    raise DBLocked(e)"},{"line_number":137,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4eb4921d","line":134,"updated":"2018-07-27 13:14:48.000000000","message":"nit: more typically, such constants team up at the very beginning of the module or class where it should be easier to spot them","commit_id":"a98cb0daf02d16be26462488c58370b9e19ad32f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f87694f4e60aa21b780fc9d2520dfe78bce8d3d8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                # Netmiko raises ValueError on commit failure, and appends the"},{"line_number":132,"context_line":"                # CLI output to the exception message. Raise a more specific"},{"line_number":133,"context_line":"                # exception for a locked DB, on which tenacity will retry."},{"line_number":134,"context_line":"                DB_LOCKED_MSG \u003d \"error: configuration database locked\""},{"line_number":135,"context_line":"                if DB_LOCKED_MSG in str(e):"},{"line_number":136,"context_line":"                    raise DBLocked(e)"},{"line_number":137,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8ef14ae1","line":134,"in_reply_to":"5f7c97a3_4eb4921d","updated":"2018-07-27 13:19:14.000000000","message":"I agree that\u0027s true for shared constants, but this string is quite specific to this function, and seems out of place at the top of the file to me.","commit_id":"a98cb0daf02d16be26462488c58370b9e19ad32f"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"db49db658c8e8f80b798212867ac068217c7c458","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                # Netmiko raises ValueError on commit failure, and appends the"},{"line_number":132,"context_line":"                # CLI output to the exception message. Raise a more specific"},{"line_number":133,"context_line":"                # exception for a locked DB, on which tenacity will retry."},{"line_number":134,"context_line":"                DB_LOCKED_MSG \u003d \"error: configuration database locked\""},{"line_number":135,"context_line":"                if DB_LOCKED_MSG in str(e):"},{"line_number":136,"context_line":"                    raise DBLocked(e)"},{"line_number":137,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_71e29304","line":134,"in_reply_to":"5f7c97a3_8ef14ae1","updated":"2018-07-27 14:15:39.000000000","message":"[with my Nitpicker Hat is on]\n\nPEP8 [1] does not tell us explicitly how widely constants should be used to justify them locating anywhere, but on the module level...\n\nBut that\u0027s definitely not important, just sharing my take on this. ;-)\n\n1. https://www.python.org/dev/peps/pep-0008/#constants","commit_id":"a98cb0daf02d16be26462488c58370b9e19ad32f"}]}