)]}'
{"networking_generic_switch/devices/netmiko_devices/__init__.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7bdb1faa0880548e9c42040254375af91d268307","unresolved":false,"context_lines":[{"line_number":32,"context_line":"CONF \u003d cfg.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def output_checked(operation):"},{"line_number":36,"context_line":"    \"\"\"Returns a decorator that checks the output of an operation."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    :param operation: Operation being attempted. One of \u0027add network\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2f7379b3","line":35,"updated":"2018-08-21 16:48:26.000000000","message":"nit: I\u0027d call it check_output","commit_id":"e13c4231cbaeca3aeda15b1d7d698b5bba3cfac2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"7bdb1faa0880548e9c42040254375af91d268307","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def decorator(func):"},{"line_number":42,"context_line":"        \"\"\"The real decorator.\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        def wrapper(self, *args, **kwargs):"},{"line_number":45,"context_line":"            \"\"\"Wrapper that checks the output of an operation."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"            :returns: The return value of the wrapped method."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cf69a5be","line":44,"updated":"2018-08-21 16:48:26.000000000","message":"nit: use six.wraps on this function to copy attributes from the wrapped function","commit_id":"e13c4231cbaeca3aeda15b1d7d698b5bba3cfac2"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"c24682a97727bbf81fb0a83f85dd934283ff80f8","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        LOG.debug(output)"},{"line_number":186,"context_line":"        return output"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    @check_output(\u0027add network\u0027)"},{"line_number":189,"context_line":"    def add_network(self, segmentation_id, network_id):"},{"line_number":190,"context_line":"        # NOTE(zhenguo): Remove dashes from uuid as on most devices 32 chars"},{"line_number":191,"context_line":"        # is the max length of vlan name."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_986499e7","line":188,"range":{"start_line":188,"start_character":5,"end_line":188,"end_character":17},"updated":"2018-08-29 16:03:56.000000000","message":"I thought there will be name collision between check output decorator declared outside of the class and instance method with the same name declared inside the class but apparently it\u0027s not the case.","commit_id":"2485e41b7c7be8ae8246c5034f9de9dad034cc3b"}]}
