)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fa210c51002e7ee37bc0ee5f5af9e74fca25e24b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ia8a473c9e0282c5c83f595db6d37b41b52714b55"},{"line_number":21,"context_line":"Story: 1737017"},{"line_number":22,"context_line":"Task: 36731"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_6431b80b","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":11},"updated":"2019-09-20 10:05:49.000000000","message":"Added a new task to cover the generic mechanism. Original task can address Dell Force 10 default change, if we decide to go that route.","commit_id":"461def3e0b5a94bf7dbb6c08a263a4379ac9d2cf"}],"networking_generic_switch/devices/netmiko_devices/__init__.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0cb42a0b63ec47713e4ab610405182ec38b724f6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def add_network(self, segmentation_id, network_id):"},{"line_number":194,"context_line":"        # NOTE(zhenguo): Remove dashes from uuid as on most devices 32 chars"},{"line_number":195,"context_line":"        # is the max length of vlan name."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        network_id \u003d uuid.UUID(network_id).hex"},{"line_number":198,"context_line":"        network_name \u003d self._get_network_name(network_id, segmentation_id)"},{"line_number":199,"context_line":"        # NOTE(mgoddard): Pass network_id and segmentation_id for drivers not"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c6099e95","line":196,"updated":"2019-09-19 17:08:02.000000000","message":"Nit: spacing is different in del_network. I prefer without so the NOTE is immediately next to the code.","commit_id":"c9794a1f6901181f879af9395b1286889d799c6b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b6d3410583969f7ee558e7576041a053ad327d41","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def add_network(self, segmentation_id, network_id):"},{"line_number":194,"context_line":"        # NOTE(zhenguo): Remove dashes from uuid as on most devices 32 chars"},{"line_number":195,"context_line":"        # is the max length of vlan name."},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        network_id \u003d uuid.UUID(network_id).hex"},{"line_number":198,"context_line":"        network_name \u003d self._get_network_name(network_id, segmentation_id)"},{"line_number":199,"context_line":"        # NOTE(mgoddard): Pass network_id and segmentation_id for drivers not"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_24350047","line":196,"in_reply_to":"3fa7e38b_c6099e95","updated":"2019-09-20 09:59:24.000000000","message":"Done","commit_id":"c9794a1f6901181f879af9395b1286889d799c6b"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0cb42a0b63ec47713e4ab610405182ec38b724f6","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            # NOTE(mgoddard): Pass network_id and segmentation_id for drivers"},{"line_number":255,"context_line":"            # not yet using network_name."},{"line_number":256,"context_line":"            network_name \u003d self._get_network_name(ngs_port_default_vlan,"},{"line_number":257,"context_line":"                                                  segmentation_id)"},{"line_number":258,"context_line":"            cmds +\u003d self._format_commands("},{"line_number":259,"context_line":"                self.ADD_NETWORK,"},{"line_number":260,"context_line":"                segmentation_id\u003dngs_port_default_vlan,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_46ccce60","line":257,"range":{"start_line":257,"start_character":50,"end_line":257,"end_character":65},"updated":"2019-09-19 17:08:02.000000000","message":"This doesn\u0027t seem right: this is the segmentation ID of the VLAN from which we just removed the port, not the one of the default VLAN.","commit_id":"c9794a1f6901181f879af9395b1286889d799c6b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b6d3410583969f7ee558e7576041a053ad327d41","unresolved":false,"context_lines":[{"line_number":254,"context_line":"            # NOTE(mgoddard): Pass network_id and segmentation_id for drivers"},{"line_number":255,"context_line":"            # not yet using network_name."},{"line_number":256,"context_line":"            network_name \u003d self._get_network_name(ngs_port_default_vlan,"},{"line_number":257,"context_line":"                                                  segmentation_id)"},{"line_number":258,"context_line":"            cmds +\u003d self._format_commands("},{"line_number":259,"context_line":"                self.ADD_NETWORK,"},{"line_number":260,"context_line":"                segmentation_id\u003dngs_port_default_vlan,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_240e608d","line":257,"range":{"start_line":257,"start_character":50,"end_line":257,"end_character":65},"in_reply_to":"3fa7e38b_46ccce60","updated":"2019-09-20 09:59:24.000000000","message":"You\u0027re right. The formatting below uses the VLAN ID for the network_id, so I\u0027ll do the same.","commit_id":"c9794a1f6901181f879af9395b1286889d799c6b"}],"networking_generic_switch/devices/netmiko_devices/dell.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"0cb42a0b63ec47713e4ab610405182ec38b724f6","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":25,"context_line":"        \u0027interface vlan {segmentation_id}\u0027,"},{"line_number":26,"context_line":"        \u0027name {network_name}\u0027,"},{"line_number":27,"context_line":"        \u0027exit\u0027,"},{"line_number":28,"context_line":"    )"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_66830ace","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":30},"updated":"2019-09-19 17:08:02.000000000","message":"It would be nice if it fixed the bug for Dell Force 10 operators without having to customise their config. Could we override the default of ngs_network_name_format per driver, and have dell.py use:\n\nneutron-{segmentation_id}\n\n(could be a follow-up patch)","commit_id":"c9794a1f6901181f879af9395b1286889d799c6b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b6d3410583969f7ee558e7576041a053ad327d41","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":25,"context_line":"        \u0027interface vlan {segmentation_id}\u0027,"},{"line_number":26,"context_line":"        \u0027name {network_name}\u0027,"},{"line_number":27,"context_line":"        \u0027exit\u0027,"},{"line_number":28,"context_line":"    )"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a44fb0bb","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":30},"in_reply_to":"3fa7e38b_66830ace","updated":"2019-09-20 09:59:24.000000000","message":"That\u0027s true. I\u0027m just not sure about the upgrade path - it would look weird to have mixed name formats.","commit_id":"c9794a1f6901181f879af9395b1286889d799c6b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e39b9f5270e5e2a62079169e11aa7e413dfa509f","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":25,"context_line":"        \u0027interface vlan {segmentation_id}\u0027,"},{"line_number":26,"context_line":"        \u0027name {network_name}\u0027,"},{"line_number":27,"context_line":"        \u0027exit\u0027,"},{"line_number":28,"context_line":"    )"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d7910ef9","line":26,"updated":"2019-12-26 11:40:35.000000000","message":"You could just add a prefix here and avoid a new option","commit_id":"461def3e0b5a94bf7dbb6c08a263a4379ac9d2cf"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0635f50fc58888dbe3bb6cba4a4b02dd218fbc47","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":25,"context_line":"        \u0027interface vlan {segmentation_id}\u0027,"},{"line_number":26,"context_line":"        \u0027name {network_name}\u0027,"},{"line_number":27,"context_line":"        \u0027exit\u0027,"},{"line_number":28,"context_line":"    )"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b5bf98fa","line":26,"in_reply_to":"3fa7e38b_d7910ef9","updated":"2020-01-02 13:02:52.000000000","message":"Some devices have a limit on the name length.","commit_id":"461def3e0b5a94bf7dbb6c08a263a4379ac9d2cf"}]}