)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"abd0e41cf3891365d84b9f5fcef2dfc0d7bf3b7a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"from switches. This is useful when not all switch configuration"},{"line_number":11,"context_line":"is being managed by Networking Generic Switch."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"A similar concenpt is already supported by ansible-networking:"},{"line_number":14,"context_line":"https://opendev.org/x/networking-ansible/src/commit/6f56fd45425141e5435884d2d0cf88ee96a887c6/etc/neutron/plugins/ml2/ml2_conf_ansible.ini.sample"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I271263a349d6cccd0fe9980e10b1b8d5fd86716e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"02eb2194_d7c5b429","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":18},"updated":"2020-11-25 09:02:19.000000000","message":"nit: concept","commit_id":"5b61382d1aabd3de75ada81b5965031de1630c91"}],"doc/source/configuration.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dfab7c9b51ab7f7308dd535ffc7e1b7ccf3a69ff","unresolved":true,"context_lines":[{"line_number":252,"context_line":"way, VLANs are removed when it seems they are no longer required."},{"line_number":253,"context_line":"However, in some cases only a subset of the ports are managed by Neutron."},{"line_number":254,"context_line":"In a similar way, when multiple switches are used, it is very common that"},{"line_number":255,"context_line":"the network administrator restrics the VLANs allowed. In these cases, there"},{"line_number":256,"context_line":"is little utility in adding and removing vlans on the switches. This process"},{"line_number":257,"context_line":"takes time, so not doing this can speed up an number of common operations."},{"line_number":258,"context_line":"A particular case where this can cause problems is when a VLAN used for"}],"source_content_type":"text/x-rst","patch_set":1,"id":"25dfbcbe_7cb0c898","line":255,"range":{"start_line":255,"start_character":26,"end_line":255,"end_character":34},"updated":"2020-11-24 09:42:03.000000000","message":"restricts","commit_id":"5b61382d1aabd3de75ada81b5965031de1630c91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dfab7c9b51ab7f7308dd535ffc7e1b7ccf3a69ff","unresolved":true,"context_lines":[{"line_number":254,"context_line":"In a similar way, when multiple switches are used, it is very common that"},{"line_number":255,"context_line":"the network administrator restrics the VLANs allowed. In these cases, there"},{"line_number":256,"context_line":"is little utility in adding and removing vlans on the switches. This process"},{"line_number":257,"context_line":"takes time, so not doing this can speed up an number of common operations."},{"line_number":258,"context_line":"A particular case where this can cause problems is when a VLAN used for"},{"line_number":259,"context_line":"the switch management interface, or any other port not managed by Neutron,"},{"line_number":260,"context_line":"is removed by this Neutron driver."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a31d5001_82b2fbd6","line":257,"range":{"start_line":257,"start_character":43,"end_line":257,"end_character":45},"updated":"2020-11-24 09:42:03.000000000","message":"a","commit_id":"5b61382d1aabd3de75ada81b5965031de1630c91"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dfab7c9b51ab7f7308dd535ffc7e1b7ccf3a69ff","unresolved":true,"context_lines":[{"line_number":265,"context_line":"networking generic switch adding or removing any VLANs::"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    [genericswitch:device-hostname]"},{"line_number":268,"context_line":"    ngs_manage_vlans \u003d False"}],"source_content_type":"text/x-rst","patch_set":1,"id":"c432b31b_f6dc7714","line":268,"range":{"start_line":268,"start_character":4,"end_line":268,"end_character":28},"updated":"2020-11-24 09:42:03.000000000","message":"I suppose the next request would be \u0027can I do this for specific VLANS?\u0027 Maybe this will cover most cases though.","commit_id":"5b61382d1aabd3de75ada81b5965031de1630c91"}],"networking_generic_switch/devices/netmiko_devices/__init__.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"abd0e41cf3891365d84b9f5fcef2dfc0d7bf3b7a","unresolved":true,"context_lines":[{"line_number":201,"context_line":"    @check_output(\u0027add network\u0027)"},{"line_number":202,"context_line":"    def add_network(self, segmentation_id, network_id):"},{"line_number":203,"context_line":"        if not self._do_vlan_management():"},{"line_number":204,"context_line":"            LOG.info(f\"Skipping add network for {segmentation_id}\")"},{"line_number":205,"context_line":"            return \"\""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        # NOTE(zhenguo): Remove dashes from uuid as on most devices 32 chars"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6c35ecd_cf409806","line":204,"range":{"start_line":204,"start_character":21,"end_line":204,"end_character":66},"updated":"2020-11-25 09:02:19.000000000","message":"any reason to use f-strings here instead of default % formatting style?\nin general logging is optimized for the latter, and it\u0027s better in terms of compatibility","commit_id":"5b61382d1aabd3de75ada81b5965031de1630c91"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"abd0e41cf3891365d84b9f5fcef2dfc0d7bf3b7a","unresolved":true,"context_lines":[{"line_number":223,"context_line":"    @check_output(\u0027delete network\u0027)"},{"line_number":224,"context_line":"    def del_network(self, segmentation_id, network_id):"},{"line_number":225,"context_line":"        if not self._do_vlan_management():"},{"line_number":226,"context_line":"            LOG.info(f\"Skipping delete network for {segmentation_id}\")"},{"line_number":227,"context_line":"            return \"\""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        # NOTE(zhenguo): Remove dashes from uuid as on most devices 32 chars"}],"source_content_type":"text/x-python","patch_set":1,"id":"e4177b49_343ae46a","line":226,"updated":"2020-11-25 09:02:19.000000000","message":"ditto","commit_id":"5b61382d1aabd3de75ada81b5965031de1630c91"}],"releasenotes/notes/manage-vlans-c75e4c2e9b9b3403.yaml":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"abd0e41cf3891365d84b9f5fcef2dfc0d7bf3b7a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added per switch `ngs_manage_vlans` option. It defaults to True, but can"},{"line_number":5,"context_line":"    be set to False so that no VLANs are added or removed on that switch."},{"line_number":6,"context_line":"    This is useful when not all ports on the switch are managed by Neutron."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"171796e1_0ddbf104","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":9},"updated":"2020-11-25 09:02:19.000000000","message":"nit: Adds","commit_id":"5b61382d1aabd3de75ada81b5965031de1630c91"}]}