)]}'
{"id":"openstack%2Fnetworking-generic-switch~847592","triplet_id":"openstack%2Fnetworking-generic-switch~master~If4ca9c58d7f30b40992d0f1aee7e915c6978e0ca","project":"openstack/networking-generic-switch","branch":"master","topic":"g5k_agent_upstream_1","attention_set":{},"removed_from_attention_set":{"34936":{"account":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"last_update":"2023-09-21 04:41:13.000000000","reason":"Change was submitted"},"14826":{"account":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"last_update":"2023-09-15 08:33:56.000000000","reason":"\u003cGERRIT_ACCOUNT_14826\u003e replied on the change","reason_account":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"}}},"hashtags":[],"change_id":"If4ca9c58d7f30b40992d0f1aee7e915c6978e0ca","subject":"Do not make actual device changes in bind_port()","status":"MERGED","created":"2022-06-24 16:03:24.000000000","updated":"2023-09-21 04:43:08.000000000","submitted":"2023-09-21 04:41:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"847592-g5k_agent_upstream_1","meta_rev_id":"c4e371dd38c9154f29e0884b8375ac5724b6b0ac","_number":847592,"virtual_id_number":847592,"owner":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-09-21 04:41:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2023-09-13 23:38:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2023-09-15 08:33:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":2,"date":"2023-09-21 01:15:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":1,"date":"2023-09-15 08:33:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-24 17:41:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-28 08:19:31.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"CC"},{"updated":"2022-06-28 08:19:38.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"state":"REVIEWER"},{"updated":"2023-09-13 23:38:05.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2023-09-21 01:15:38.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"}],"messages":[{"id":"5456c3643787fdb16d27ed8c3dd8d9033a03a8d8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"date":"2022-06-24 16:03:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d7d3259baa4f1a8dedd25efb327184397121ecd4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 17:41:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e6f86564b59d41f1bf8219799847d428 : SUCCESS in 4m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1ffe6b70e0d340b29be7116438408efe : SUCCESS in 5m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/03c428c9edd649c8832c1d4eec6330ee : SUCCESS in 4m 51s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/a5e70918478744cb8bd1bc497ae4814b : SUCCESS in 4m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1a095503f64b41fc98f5d3b450a6a91d : SUCCESS in 4m 42s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/b7a73b12ec764fa88ac36b1ccbf7a0a0 : SUCCESS in 16m 04s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/9faa5a12d6fe4b68aa3aebc80adad503 : SUCCESS in 1h 34m 16s","accounts_in_message":[],"_revision_number":1},{"id":"17e4fd3cb46ceb16e792f4c91308a5a56293b0e7","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-06-28 08:19:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"26eabbd6d3d9da13bcb5ed06e38e96204120f6bf","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-06-28 08:19:38.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"f988232268376cd97a703b255082f80792aa1eda","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2022-06-28 08:19:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"00176cad98bce0ff4cda260fd7378de6d42bc2d8","author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"date":"2022-06-29 16:28:20.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"83260744c25d95b5dcc624e608bc6ef45d6ea1ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"date":"2023-07-04 15:23:11.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"8f8ed26cca391eb5cc0a0959fbee9581e4308db3","author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"date":"2023-07-04 15:28:19.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4f971a4d2b3a21c9bfa133a242b2f8a684796106","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-07-04 17:10:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4a61247603a94389b7bad2e246564383\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/53c26b10f3db40659bc255541cf379fe : SUCCESS in 3m 52s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a5916972034942caa475cf783f607cc9 : SUCCESS in 3m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3ce8204062874510966e9b5cfa097f1c : SUCCESS in 4m 16s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/028179eeda94438fbb390b0e0e658835 : SUCCESS in 4m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/20070a1bf6f84d4b998605f64f0fbd7e : SUCCESS in 6m 47s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/7bb4ff119adb4aa7ae762cf123f6d265 : SUCCESS in 26m 46s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/ee2a5bb79d0d44c49a794c58a303744f : SUCCESS in 1h 39m 22s","accounts_in_message":[],"_revision_number":2},{"id":"fcc68e7807571d7e519906f585b0edd4d005b36c","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2023-09-13 23:38:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a94c832cc875f051be7d47ef318a2a8a8b66952c","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2023-09-15 08:33:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"bb8f0b8fd376922709c7f9d31b27cd6ac4e24433","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-15 08:34:28.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"3b4abb5460b60a680233be47c207d955bc0d184c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-15 10:52:43.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/ffb4c26649d049b9a3ca0d2ce5617c66\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2207440d120a440e88f521ffd3575419 : SUCCESS in 4m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a526f1345e29430481a8e691a550e16a : SUCCESS in 3m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4b7829db75324f089f4a2bb21796862f : SUCCESS in 4m 46s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/867698871e9f4e08a2e6076fcab0b9e3 : SUCCESS in 3m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1ea9d0d9c2ec4a9ebb1eabb261162cfd : SUCCESS in 6m 54s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/6867c9ab7a6e44e3bfc34fc3f7d6dc49 : FAILURE in 24m 39s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/2f428cba14b44ca39bd290a4dead5129 : FAILURE in 2h 13m 09s","accounts_in_message":[],"_revision_number":2},{"id":"2f9894fbb1fe4d5446c4d75e8c8b1d55882c7a6f","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2023-09-21 01:15:38.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b66eec26ba1d258d73cda3990a177dc9c26ecc57","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-21 02:26:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8d3cb3f360654e3da178a1f015c39bca\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6305fc54b2b74b03a8790d4ecedcb5a9 : SUCCESS in 4m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a21941b404fc45888a116f11de5c2aec : SUCCESS in 4m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7097ed8c2c0244a5a701e485da4d17f9 : SUCCESS in 5m 17s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/cd5f8935fa0841aeb4b1f30febbedb59 : SUCCESS in 4m 27s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/fdc4976e56704848a2fa94ccf68838ff : SUCCESS in 4m 16s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b1de4f022431453c96239ff9983026d7 : SUCCESS in 7m 10s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/eee7273e947a43e2bc41c61963951138 : SUCCESS in 25m 58s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/ad8846ddd11a485c923c246e62ae5095 : SUCCESS in 1h 08m 01s","accounts_in_message":[],"_revision_number":2},{"id":"5d0d9257edb2b07c4a1027d2d079dce6042a68c0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-21 02:27:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"20d4667f67afcb5ff94f3c05d22a24e3c51f113c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-21 04:41:13.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fb5349b1b4814a40bde468c4076e9844\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/394fd07fbda54401b6981bb5428412e2 : SUCCESS in 5m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b2cae6db75a54e2fa092538ae8170efd : SUCCESS in 7m 08s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/58c350177f064f34aacb5462fcf7cab1 : SUCCESS in 5m 35s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/f5059c78757b4a50ad611bc936945ab4 : SUCCESS in 6m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/485bd07b3e2b4571a2a72f2e946e357e : SUCCESS in 8m 05s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/fe7a02fb44ab429dbc5704f34b8ee86a : SUCCESS in 16m 01s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/0839e15d8d724ca7a4d787083f20373c : SUCCESS in 1h 14m 12s","accounts_in_message":[],"_revision_number":2},{"id":"36b6b1ea88152c18126ef4bf4d6a6479bc1e6d52","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-21 04:41:13.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"c4e371dd38c9154f29e0884b8375ac5724b6b0ac","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-21 04:43:08.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/32925a0e64064102bb369f6692b9a77e\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6ae6f8ca6184447393788f5d5766f5fa : SUCCESS in 45s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0088fde1debfd80ab2508bfea9f2cff2a1602e80","revisions":{"c225b79af4129bc53d2c98c4bfde3e8236f8e1de":{"kind":"REWORK","_number":1,"created":"2022-06-24 16:03:24.000000000","uploader":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"ref":"refs/changes/92/847592/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-generic-switch","ref":"refs/changes/92/847592/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/92/847592/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/92/847592/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/92/847592/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-generic-switch refs/changes/92/847592/1"}}},"commit":{"parents":[{"commit":"1a31396cb017d31eee3693f279219d695ef78f92","subject":"Merge \"The Python 3.6 and Python 3.7 Support has been dropped since zed\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/1a31396cb017d31eee3693f279219d695ef78f92"}]}],"author":{"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","date":"2022-06-21 15:20:37.000000000","tz":120},"committer":{"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","date":"2022-06-24 16:01:10.000000000","tz":120},"subject":"Do not make actual device changes in bind_port()","message":"Do not make actual device changes in bind_port()\n\nAccording to the bind_port specification (as summed up in its docstring),\nwe should not make any change when bind_port() is called, because binding\nresults might end up not getting committed.\n\nTo satisfy this specification, this patch moves actual device\nreconfiguration to update_port_postcommit().\n\nIn addition, this will likely make it easier to improve performance of\nbulk port creation in the future, see https://bugs.launchpad.net/neutron/+bug/1976270\n\nNote that this change introduces a different retry behaviour when we fail\nto configure a device.  Since bind_port() is retried several times by\nNeutron, we indirectly benefited from these retries, but this is no longer\nthe case.  However, NGS already has an internal retry mechanism for SSH\nconnection errors, which should cover most network-related issues.\n\nTo sum up, errors that are no longer covered by a retry are the ones that\nhappen after we successfully connect to the device.  For instance, the\nswitch port may not exist on the device, or the device could be in an\nunexpected state such as a port being currently part of an unexpected\nVLAN.  This kind of errors are unlikely to be solved by retrying, so the\nnew behaviour should be fine and will even allow to return the error much\nfaster to the end-user.\n\nChange-Id: If4ca9c58d7f30b40992d0f1aee7e915c6978e0ca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/c225b79af4129bc53d2c98c4bfde3e8236f8e1de"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/c225b79af4129bc53d2c98c4bfde3e8236f8e1de"}]},"branch":"refs/heads/master"},"0088fde1debfd80ab2508bfea9f2cff2a1602e80":{"kind":"REWORK","_number":2,"created":"2023-07-04 15:23:11.000000000","uploader":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"ref":"refs/changes/92/847592/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-generic-switch","ref":"refs/changes/92/847592/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/92/847592/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/92/847592/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/92/847592/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-generic-switch refs/changes/92/847592/2"}}},"commit":{"parents":[{"commit":"5246705d24224d9c5cb6d9befd0542162c4ff737","subject":"Bugs are now tracked in launchpad, fix docs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/5246705d24224d9c5cb6d9befd0542162c4ff737"}]}],"author":{"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","date":"2022-06-21 15:20:37.000000000","tz":120},"committer":{"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","date":"2023-07-04 15:20:11.000000000","tz":120},"subject":"Do not make actual device changes in bind_port()","message":"Do not make actual device changes in bind_port()\n\nAccording to the bind_port specification (as summed up in its docstring),\nwe should not make any change when bind_port() is called, because binding\nresults might end up not getting committed.\n\nTo satisfy this specification, this patch moves actual device\nreconfiguration to update_port_postcommit().\n\nThis makes the behaviour symmetrical for port creation (handled in\nupdate_port_postcommit) and port deletion (handled in delete_port_postcommit).\n\nIn addition, this will make it easier to improve performance of port\ncreation, see https://bugs.launchpad.net/networking-generic-switch/+bug/2024385\n\nNote that this change introduces a different retry behaviour when we fail\nto configure a device.  Since bind_port() is retried several times by\nNeutron, we indirectly benefited from these retries, but this is no longer\nthe case.  However, NGS already has an internal retry mechanism for SSH\nconnection errors, which should cover most network-related issues.\n\nTo sum up, errors that are no longer covered by a retry are the ones that\nhappen after we successfully connect to the device.  For instance, the\nswitch port may not exist on the device, or the device could be in an\nunexpected state such as a port being currently part of an unexpected\nVLAN.  This kind of errors are unlikely to be solved by retrying, so the\nnew behaviour should be fine and will even allow to return the error much\nfaster to the end-user.\n\nRelated-Bug: #2024385\n\nChange-Id: If4ca9c58d7f30b40992d0f1aee7e915c6978e0ca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/0088fde1debfd80ab2508bfea9f2cff2a1602e80"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/0088fde1debfd80ab2508bfea9f2cff2a1602e80"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}