)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2b4e088ceb4473624c8f624788dd7a5f9e99a14b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"deae85c1_1355922b","updated":"2022-09-07 21:21:49.000000000","message":"Not familiar enough with this repo to +2, but the change looks good to me.","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b654ae9754da169c218a60269e65e83cae1663ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"47f46e2a_e708cf93","updated":"2022-08-25 18:48:41.000000000","message":"Overall, LGTM. ","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"}],"networking_generic_switch/devices/netmiko_devices/pluribus.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b654ae9754da169c218a60269e65e83cae1663ae","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Pluribus(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan-create id {segmentation_id} scope fabric\\"},{"line_number":21,"context_line":" ports none description {network_name} auto-vxlan\u0027,"},{"line_number":22,"context_line":"    )"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"a3b7ceeb_80f057b3","line":20,"range":{"start_line":20,"start_character":54,"end_line":20,"end_character":55},"updated":"2022-08-25 18:48:41.000000000","message":"fwiw, I\u0027d just let the python string wrapping do it\u0027s thing.\n\n ADD_NETWORK \u003d (\n     \u0027vlan-create id {segmentation_id} scope fabric \u0027\n     \u0027ports none description {network_name} auto-vxlan\u0027\n )","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"},{"author":{"_account_id":26922,"name":"Steven Relf","email":"s.relf@eschercloud.ai","username":"srelf"},"change_message_id":"ae24bcb54d94559889e8e43d19104b153b29d451","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Pluribus(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan-create id {segmentation_id} scope fabric\\"},{"line_number":21,"context_line":" ports none description {network_name} auto-vxlan\u0027,"},{"line_number":22,"context_line":"    )"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"deccaff8_e88769fd","line":20,"range":{"start_line":20,"start_character":54,"end_line":20,"end_character":55},"in_reply_to":"a3b7ceeb_80f057b3","updated":"2022-08-25 19:18:03.000000000","message":"i had an odd probelm with the mocking not linking the python string wrap..","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"},{"author":{"_account_id":26922,"name":"Steven Relf","email":"s.relf@eschercloud.ai","username":"srelf"},"change_message_id":"79142cf579715f846cf6f5f7ccb1d9bf66cc9532","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Pluribus(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan-create id {segmentation_id} scope fabric\\"},{"line_number":21,"context_line":" ports none description {network_name} auto-vxlan\u0027,"},{"line_number":22,"context_line":"    )"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c20a9a4d_27ac9605","line":20,"range":{"start_line":20,"start_character":54,"end_line":20,"end_character":55},"in_reply_to":"d1689029_f543d380","updated":"2022-09-08 15:25:20.000000000","message":"Ack","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"fa4414e5880acc25ad7b7393210e323256a53465","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class Pluribus(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan-create id {segmentation_id} scope fabric\\"},{"line_number":21,"context_line":" ports none description {network_name} auto-vxlan\u0027,"},{"line_number":22,"context_line":"    )"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d1689029_f543d380","line":20,"range":{"start_line":20,"start_character":54,"end_line":20,"end_character":55},"in_reply_to":"deccaff8_e88769fd","updated":"2022-09-02 19:15:56.000000000","message":"Okay!","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f04ae1def4f2f4c06342180d694f9406c801ee99","unresolved":true,"context_lines":[{"line_number":18,"context_line":"class Pluribus(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan-create id {segmentation_id} scope fabric\\"},{"line_number":21,"context_line":" ports none description {network_name} auto-vxlan\u0027,"},{"line_number":22,"context_line":"    )"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    DELETE_NETWORK \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"effde98b_d7517763","line":21,"range":{"start_line":21,"start_character":39,"end_line":21,"end_character":51},"updated":"2022-08-25 18:46:05.000000000","message":"This raises an interest question. are these vxlans, or are they vlan over vxlan? will everyone do it this way?\n\nI wonder if this needs to be configurable... :\\ But I also don\u0027t have enough information on how these switches work.","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"815b2e8e349a4a27220672a8a067547ea5b1ead6","unresolved":true,"context_lines":[{"line_number":18,"context_line":"class Pluribus(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan-create id {segmentation_id} scope fabric\\"},{"line_number":21,"context_line":" ports none description {network_name} auto-vxlan\u0027,"},{"line_number":22,"context_line":"    )"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    DELETE_NETWORK \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"c6085c9c_678dc377","line":21,"range":{"start_line":21,"start_character":39,"end_line":21,"end_character":51},"in_reply_to":"99204622_604025ed","updated":"2022-09-02 19:13:43.000000000","message":"Hmm, Interesting!\n\nWell, I don\u0027t think any other driver handles it in NGS, but other drivers do kind of handle it or submit the change into the overall SDN system. Or you can set it such that the ISL is open to all vlans in some switches. Granted, not all switches support that.\n\nI would honestly just suggest you take the path of east resistance, but also enable it to be disabled. In other words, I would allow for the inter-switch links to be able to be defined, and the driver could update, if enabled to do so. That would help walk the balance of having a fully featured environment versus network admins that don\u0027t want new vlans to appear on interswitch links.","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"},{"author":{"_account_id":26922,"name":"Steven Relf","email":"s.relf@eschercloud.ai","username":"srelf"},"change_message_id":"79142cf579715f846cf6f5f7ccb1d9bf66cc9532","unresolved":false,"context_lines":[{"line_number":18,"context_line":"class Pluribus(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan-create id {segmentation_id} scope fabric\\"},{"line_number":21,"context_line":" ports none description {network_name} auto-vxlan\u0027,"},{"line_number":22,"context_line":"    )"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    DELETE_NETWORK \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"5ead37ab_b97a24b7","line":21,"range":{"start_line":21,"start_character":39,"end_line":21,"end_character":51},"in_reply_to":"c6085c9c_678dc377","updated":"2022-09-08 15:25:20.000000000","message":"So I have decided to manage the ISL links out of band of this driver, as part of a script that creates the external network in openstack. So I am happy this is feature complete for now 😄","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"},{"author":{"_account_id":26922,"name":"Steven Relf","email":"s.relf@eschercloud.ai","username":"srelf"},"change_message_id":"ae24bcb54d94559889e8e43d19104b153b29d451","unresolved":true,"context_lines":[{"line_number":18,"context_line":"class Pluribus(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan-create id {segmentation_id} scope fabric\\"},{"line_number":21,"context_line":" ports none description {network_name} auto-vxlan\u0027,"},{"line_number":22,"context_line":"    )"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    DELETE_NETWORK \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"99204622_604025ed","line":21,"range":{"start_line":21,"start_character":39,"end_line":21,"end_character":51},"in_reply_to":"effde98b_d7517763","updated":"2022-08-25 19:18:03.000000000","message":"So, this is the standard way that the pluribus switches would be configured, the fabric auto configures vxlan tunnels between the switches, and ensures vlans are delivered correctly to each of the leaf switches. I believe this would be the way everyone would use it.\n\nOne issue im still thinking about is how to manage some of the additional vlan trunking and configuration, although im not sure if its out of scope for the generic switch plugin. \n\nFor example, if your running with clustering over l2, the vlan needs to be allowed across the inter-switch link, which as far as i can see, no other driver handles. So should that be handled out of band, with this plugin only taking responsibility for ports managed by neutron?","commit_id":"79fc10465f070d4a35a75246ee1f6423e9064725"}]}