)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e440fd073f735eac3d695495dd82feabee97b8ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e7b5d97_6b63f1f9","updated":"2023-01-04 17:06:21.000000000","message":"Overall looks good, I agree with Mark that this is potentially breaking to third party driver operators who may also import this code. That being said, I think a quick release note is needed, or to not log the device name. That being said, I do like the fact it is logged as it at least gives an indicator of where to look.\n\nThanks!","commit_id":"e89706db2948d171ee76463ced020a2b53a6b7d5"},{"author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"change_message_id":"ec4e83a2eb1257be39edf7a724785f9a72693954","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a6ba864_d1928375","updated":"2023-01-23 15:33:40.000000000","message":"recheck","commit_id":"894b92291a3aaf495ed51ac3b552b7bf99d94074"}],"networking_generic_switch/devices/__init__.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c2bc18fa13f5c5c6dfc67a496516bf865eb1ec70","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            namespace\u003dGENERIC_SWITCH_NAMESPACE,"},{"line_number":53,"context_line":"            name\u003ddevice_type,"},{"line_number":54,"context_line":"            invoke_on_load\u003dTrue,"},{"line_number":55,"context_line":"            invoke_args\u003d(device_cfg, device_name),"},{"line_number":56,"context_line":"            on_load_failure_callback\u003d_load_failure_hook"},{"line_number":57,"context_line":"        )"},{"line_number":58,"context_line":"    except stevedore.exception.NoUniqueMatch as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ddab540_5c26d222","line":55,"range":{"start_line":55,"start_character":37,"end_line":55,"end_character":48},"updated":"2023-01-04 10:06:21.000000000","message":"This could cause problems if someone has implemented an out-of-tree driver. Hopefully easy enough to fix, but needs a release note.","commit_id":"e89706db2948d171ee76463ced020a2b53a6b7d5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e440fd073f735eac3d695495dd82feabee97b8ae","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            namespace\u003dGENERIC_SWITCH_NAMESPACE,"},{"line_number":53,"context_line":"            name\u003ddevice_type,"},{"line_number":54,"context_line":"            invoke_on_load\u003dTrue,"},{"line_number":55,"context_line":"            invoke_args\u003d(device_cfg, device_name),"},{"line_number":56,"context_line":"            on_load_failure_callback\u003d_load_failure_hook"},{"line_number":57,"context_line":"        )"},{"line_number":58,"context_line":"    except stevedore.exception.NoUniqueMatch as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6af3f069_1a6c73fa","line":55,"range":{"start_line":55,"start_character":37,"end_line":55,"end_character":48},"in_reply_to":"1ddab540_5c26d222","updated":"2023-01-04 17:06:21.000000000","message":"+1","commit_id":"e89706db2948d171ee76463ced020a2b53a6b7d5"},{"author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"change_message_id":"9d975422d9a86b40994549fa7e876a057e7124b3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            namespace\u003dGENERIC_SWITCH_NAMESPACE,"},{"line_number":53,"context_line":"            name\u003ddevice_type,"},{"line_number":54,"context_line":"            invoke_on_load\u003dTrue,"},{"line_number":55,"context_line":"            invoke_args\u003d(device_cfg, device_name),"},{"line_number":56,"context_line":"            on_load_failure_callback\u003d_load_failure_hook"},{"line_number":57,"context_line":"        )"},{"line_number":58,"context_line":"    except stevedore.exception.NoUniqueMatch as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"73d96f32_6212dbe8","line":55,"range":{"start_line":55,"start_character":37,"end_line":55,"end_character":48},"in_reply_to":"6af3f069_1a6c73fa","updated":"2023-01-13 12:52:54.000000000","message":"Thanks for the review, I have added a release note under \"upgrade\".","commit_id":"e89706db2948d171ee76463ced020a2b53a6b7d5"}]}