)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aaef3462d10e8d7991c96f96d9458684f14eddee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92a302ad_296023d9","updated":"2023-01-04 16:56:34.000000000","message":"Greetings, I think just one new test is needed since the overall behavior of error handling is different, we should have at least one test to ensure \"it works as we expect\". Otherwise looks good, although I would also argue this is a fix and not a feature. 😊","commit_id":"4e3ba88b1347a8ecade6d650acc70ad16a49af4a"},{"author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"change_message_id":"14be39e7aae487eca3cfba4f879dace0d9550e5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"efd96cb7_bda330fc","in_reply_to":"862d00ed_ac201f8d","updated":"2025-08-21 14:36:51.000000000","message":"This patch fell into the cracks, sorry about that. The good news: since the initial submission, the fix in Netmiko has long been merged and released!\n\nThe patch is now up-to-date with master, there are new tests, and I updated the changelog from \"features\" to \"fixes\".","commit_id":"4e3ba88b1347a8ecade6d650acc70ad16a49af4a"},{"author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"change_message_id":"242cff77a01d2fe7165204bff0e68107aeb63905","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"862d00ed_ac201f8d","in_reply_to":"92a302ad_296023d9","updated":"2023-01-04 18:26:19.000000000","message":"Thanks, I will add a test then. I\u0027m not sure this qualifies as a \"fix\" because so few device drivers implement error checking, and there is also a potential for regression (false positives).\n\nActually, there is an issue I missed: this change exposes a bug in Netmiko, where config saving is broken. The error was silently ignored in NGS up to now, but it will now make port configuration fail. I have submitted a fix for Netmiko: https://github.com/ktbyers/netmiko/pull/3070\n\nI missed this problem before submitting the patch because we carry a local workaround in our NGS deployment. But I believe it is better to integrate the fix in Netmiko, bump it in our requirements, and then merge this.","commit_id":"4e3ba88b1347a8ecade6d650acc70ad16a49af4a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"72fb81ec82451a2e19bd8302f13941fc7416fbbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f73195f1_123a77ed","updated":"2026-02-27 19:19:22.000000000","message":"This will require another job fix to merge first.","commit_id":"119f960f00c7866fafb938742eb9d914cf726972"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5e3f8208ff8ec591d3eb015f0ae76b0e13c8536d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a239687b_8eadc32c","updated":"2026-02-27 23:37:25.000000000","message":"recheck ci job config changed, should be good now.","commit_id":"119f960f00c7866fafb938742eb9d914cf726972"}],"networking_generic_switch/tests/unit/netmiko/test_dell.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9f6889861fda0699a1ec6caf1089d86e26ebab6a","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                         [\u0027interface vlan 33\u0027, \u0027no tagged 3333\u0027, \u0027exit\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class TestNetmikoDellOS10(test_netmiko_base.NetmikoSwitchTestBase):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _make_switch_device(self, extra_cfg\u003d{}):"},{"line_number":133,"context_line":"        device_cfg \u003d {\u0027device_type\u0027: \u0027netmiko_dell_os10\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"640175ad_69d260ee","line":130,"updated":"2023-01-04 09:46:59.000000000","message":"How about some tests for the error pattern?","commit_id":"4e3ba88b1347a8ecade6d650acc70ad16a49af4a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aaef3462d10e8d7991c96f96d9458684f14eddee","unresolved":true,"context_lines":[{"line_number":127,"context_line":"                         [\u0027interface vlan 33\u0027, \u0027no tagged 3333\u0027, \u0027exit\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class TestNetmikoDellOS10(test_netmiko_base.NetmikoSwitchTestBase):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _make_switch_device(self, extra_cfg\u003d{}):"},{"line_number":133,"context_line":"        device_cfg \u003d {\u0027device_type\u0027: \u0027netmiko_dell_os10\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"d19f9948_394fdadd","line":130,"in_reply_to":"640175ad_69d260ee","updated":"2023-01-04 16:56:34.000000000","message":"+1, even just one would make me a little more comfortable since it was not previously populated with a regex.","commit_id":"4e3ba88b1347a8ecade6d650acc70ad16a49af4a"},{"author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"change_message_id":"14be39e7aae487eca3cfba4f879dace0d9550e5a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                         [\u0027interface vlan 33\u0027, \u0027no tagged 3333\u0027, \u0027exit\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class TestNetmikoDellOS10(test_netmiko_base.NetmikoSwitchTestBase):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _make_switch_device(self, extra_cfg\u003d{}):"},{"line_number":133,"context_line":"        device_cfg \u003d {\u0027device_type\u0027: \u0027netmiko_dell_os10\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ddc25fd4_ac58527e","line":130,"in_reply_to":"d19f9948_394fdadd","updated":"2025-08-21 14:36:51.000000000","message":"Test added","commit_id":"4e3ba88b1347a8ecade6d650acc70ad16a49af4a"}],"requirements.txt":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ed295e7d57ec0f9e2fbae91b7f57f9599c80f926","unresolved":true,"context_lines":[{"line_number":4,"context_line":"etcd3gw\u003e\u003d2.1.0 # Apache-2.0"},{"line_number":5,"context_line":"oslo.service[threading]\u003e\u003d4.2.0 # Apache-2.0"},{"line_number":6,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"},{"line_number":7,"context_line":"netmiko\u003e\u003d4.2.0 # MIT"},{"line_number":8,"context_line":"neutron\u003e\u003d13.0.0.0b1 # Apache-2.0"},{"line_number":9,"context_line":"neutron-lib\u003e\u003d1.18.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"7a7ad47e_15953be0","line":7,"updated":"2025-09-26 20:02:53.000000000","message":"nit: you can go all the way to 4.6.0, it\u0027s what\u0027s in upper-constraints","commit_id":"a9e71f23fcb4e1612b4185fe18c8a6fb6755d31c"},{"author":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"change_message_id":"1ab5eb4eb35af3b3c6dfe06c35f10f319ae0fc05","unresolved":false,"context_lines":[{"line_number":4,"context_line":"etcd3gw\u003e\u003d2.1.0 # Apache-2.0"},{"line_number":5,"context_line":"oslo.service[threading]\u003e\u003d4.2.0 # Apache-2.0"},{"line_number":6,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"},{"line_number":7,"context_line":"netmiko\u003e\u003d4.2.0 # MIT"},{"line_number":8,"context_line":"neutron\u003e\u003d13.0.0.0b1 # Apache-2.0"},{"line_number":9,"context_line":"neutron-lib\u003e\u003d1.18.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"d54aea59_556c2a56","line":7,"in_reply_to":"7a7ad47e_15953be0","updated":"2025-09-29 13:09:06.000000000","message":"Not sure if we\u0027re talking about the same thing: this here is a lower constraint i.e. the minimum supported version, while the global upper-constraints is about the maximum supported version, right?\n\nAFAIK, Debian packaging relies on these version constraints, e.g. Debian trixie has netmiko 4.5 and it should be compatible with current NGS.","commit_id":"a9e71f23fcb4e1612b4185fe18c8a6fb6755d31c"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"4685336431d89a35857d93496fd4e7d5192f0973","unresolved":false,"context_lines":[{"line_number":4,"context_line":"etcd3gw\u003e\u003d2.1.0 # Apache-2.0"},{"line_number":5,"context_line":"oslo.service[threading]\u003e\u003d4.2.0 # Apache-2.0"},{"line_number":6,"context_line":"stevedore\u003e\u003d1.20.0 # Apache-2.0"},{"line_number":7,"context_line":"netmiko\u003e\u003d4.2.0 # MIT"},{"line_number":8,"context_line":"neutron\u003e\u003d13.0.0.0b1 # Apache-2.0"},{"line_number":9,"context_line":"neutron-lib\u003e\u003d1.18.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"7430a3e9_92c946ac","line":7,"in_reply_to":"d54aea59_556c2a56","updated":"2025-09-29 15:34:30.000000000","message":"I usually bump to latest() when I bump it unless there\u0027s a good reason otherwise. Sounds like you have a good reason not to!","commit_id":"a9e71f23fcb4e1612b4185fe18c8a6fb6755d31c"}]}