)]}'
{"id":"openstack%2Fnetworking-generic-switch~896112","triplet_id":"openstack%2Fnetworking-generic-switch~stable%2F2023.2~If4ca9c58d7f30b40992d0f1aee7e915c6978e0ca","project":"openstack/networking-generic-switch","branch":"stable/2023.2","topic":"g5k_agent_upstream_1-stable/2023.2","attention_set":{},"removed_from_attention_set":{"10342":{"account":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"last_update":"2024-11-21 17:38:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If4ca9c58d7f30b40992d0f1aee7e915c6978e0ca","subject":"Do not make actual device changes in bind_port()","status":"MERGED","created":"2023-09-21 16:40:16.000000000","updated":"2024-11-21 17:39:26.000000000","submitted":"2024-11-21 17:38:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"896112-g5k_agent_upstream_1-stable/2023.2","cherry_pick_of_change":847592,"cherry_pick_of_patch_set":2,"meta_rev_id":"38b8c50b583c3ab45458492fed4398e728670818","_number":896112,"virtual_id_number":896112,"owner":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-11-21 17:38:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2024-11-18 22:06:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2024-11-06 22:59:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":1,"date":"2024-11-18 22:06:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"}],"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-21 16:40:16.000000000","updated_by":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"reviewer":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"state":"CC"},{"updated":"2023-09-21 17:00:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-21 22:16:38.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"state":"REVIEWER"},{"updated":"2024-11-18 22:06:26.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2024-11-21 14:19:15.000000000","updated_by":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"reviewer":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"state":"CC"}],"messages":[{"id":"5d5706649642a644ae3e5d99163aaf309db52d61","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2023-09-21 16:40:16.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"51725219ad14e5da018c7aac9157041c530a784c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-21 17:00:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3947930265a74ab8a9c2c7dc3a547abf\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6e0b8860983741de842df9655bc97885 : SUCCESS in 4m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/62c9e917cc6a49d18ba0ca32a69007b0 : SUCCESS in 4m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/02682701ed404fad88c1a2b6ff423d28 : SUCCESS in 5m 00s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/1d89d48165c34ec3979169a7a4fa6d8a : SUCCESS in 4m 57s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/ffb13c39d0774056a9ebe0c1755e7396 : SUCCESS in 7m 55s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8525ba933eef4ab09f525b666f634717 : SUCCESS in 9m 44s","accounts_in_message":[],"_revision_number":1},{"id":"61ed93c46b7878c5051c2b1a01e691972841fb6c","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2023-09-21 22:16:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"64c1c5ff56f03ecf887ec0a7b39dda6afccbb35e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"date":"2024-11-06 22:59:47.000000000","message":"Patch Set 2: Patch Set 1 was rebased\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"**changekind:TRIVIAL_REBASE** OR is:MIN\")\n\nOutdated Votes:\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"78bd69985957f82bded26423704f5f9b68469831","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-07 00:24:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/58770215a5e844128368a94d038713cd\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dbf8a03db09b4bdd9c684a961b1af563 : SUCCESS in 4m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/219e6c60647d4b94810f27e6a8ff821e : SUCCESS in 3m 55s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f19a7771cb2a47b5a297931848f657d2 : SUCCESS in 4m 34s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/56499742e6354259ac108d9cbcdbdbfa : SUCCESS in 4m 00s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/15e8c1d192c84b54910952322cae068b : SUCCESS in 4m 09s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9b98ce4e73d74b378cde2deacbb2028d : SUCCESS in 6m 32s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/68cb9c2a8b99499d9920d7071f2af623 : SUCCESS in 12m 46s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/1892c7ebf60047778d8680b665248944 : SUCCESS in 1h 23m 46s","accounts_in_message":[],"_revision_number":2},{"id":"efe2f33e0f130b1bef996f7e78e7e651e4d77277","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2024-11-18 22:06:26.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f6972d33a2530a9d63fc3d0c8ed8b9ba70be923a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-18 22:07:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1412cabd48abe7807b447caae873a4bd21c72439","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-18 22:22:56.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/5dbd1c0afe1a4e6f8f675661f84abfe9\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/424b2e01e88542abbb52aad7dc0c9cf0 : SUCCESS in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/011dc17d140f4bd4842f9a43fae317ac : SUCCESS in 4m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/bd737898e38c4d9ba404130f0716cf6e : SUCCESS in 3m 02s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/7497b848d7fa4ca69bfac8b66419649c : SUCCESS in 4m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/63f1265b61c44f3f8f903280b25de86c : SUCCESS in 3m 59s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/5d111795451c47fc89aa8f1ebc6a88ce : SUCCESS in 14m 55s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/b20ce20ab71d4d6baa82ad87e4c521af : FAILURE in 9m 55s","accounts_in_message":[],"_revision_number":2},{"id":"6232e3ef8570363cbdad998f75489a8ee71a03f1","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2024-11-21 14:19:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"7904b5ec1326d3b878bc1ecf4a3bdf76809291fa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-21 16:01:12.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/72296736734640a7a550054b554c56c2\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/187c82a874794ca596d07bb71ff35921 : SUCCESS in 2m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/72371d1f935d438f9e7baeb324a4f570 : SUCCESS in 2m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2f8044aab82a4b7faa13890d3ff4a2a3 : SUCCESS in 5m 21s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/9260f92bf9d244d5a70ac991eeb2f7b5 : SUCCESS in 3m 04s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/6b23c351652e4f809d8352adc49b8f47 : SUCCESS in 6m 59s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3b81404002f94089a74a69a9f0de73df : SUCCESS in 6m 02s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/1c233a5e251f459686184afd4f788d12 : SUCCESS in 24m 00s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/f465ee7f703740c2bd8678042dc348bf : SUCCESS in 1h 28m 35s","accounts_in_message":[],"_revision_number":2},{"id":"639414f97cc6dface4f36b9a7ef30662eed4149b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-21 16:01:59.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ec938d2a715e745da194ca5f980d366e14b92b3b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-21 17:38:26.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/497abb27d35a430fa02cfedcb6e57eee\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/97ed60c95198442aad97fd2a77f040c1 : SUCCESS in 4m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6cf95a8546d84c9fab41baede37d1b77 : SUCCESS in 2m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b4bfab3d661b4ede9e632b2ea67b6ad9 : SUCCESS in 3m 59s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/5068e6803f0d47e9b252440543db7710 : SUCCESS in 3m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d15e14286eb04b5687866350c1b77e37 : SUCCESS in 4m 07s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/497507b27ea84963a09f3a50c4353f09 : SUCCESS in 15m 35s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/f90904cb1f0c4535beddd81be35efda0 : SUCCESS in 1h 31m 24s","accounts_in_message":[],"_revision_number":2},{"id":"f59465f40fa75e16b83c269553c916aac3660ec9","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-21 17:38:26.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"38b8c50b583c3ab45458492fed4398e728670818","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-21 17:39:26.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/224a7539d2284cf6940c41759e2c2b72\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5423ef06e1684c028012fc0138989230 : SUCCESS in 35s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4d320c5d2622e73fdb4891ce7812f26e9a12a8a4","revisions":{"c573723a4dc1d710514d6f0a48de0039b31891c8":{"kind":"REWORK","_number":1,"created":"2023-09-21 16:40:16.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/12/896112/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-generic-switch","ref":"refs/changes/12/896112/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/12/896112/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/12/896112/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/12/896112/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-generic-switch refs/changes/12/896112/1"}}},"commit":{"parents":[{"commit":"683e1659710ae665fe5f896e193d0fa1b817c51b","subject":"Update TOX_CONSTRAINTS_FILE for stable/2023.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/683e1659710ae665fe5f896e193d0fa1b817c51b"}]}],"author":{"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","date":"2022-06-21 15:20:37.000000000","tz":120},"committer":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2023-09-21 16:40:16.000000000","tz":0},"subject":"Do not make actual device changes in bind_port()","message":"Do not make actual device changes in bind_port()\n\nAccording to the bind_port specification (as summed up in its docstring),\nwe should not make any change when bind_port() is called, because binding\nresults might end up not getting committed.\n\nTo satisfy this specification, this patch moves actual device\nreconfiguration to update_port_postcommit().\n\nThis makes the behaviour symmetrical for port creation (handled in\nupdate_port_postcommit) and port deletion (handled in delete_port_postcommit).\n\nIn addition, this will make it easier to improve performance of port\ncreation, see https://bugs.launchpad.net/networking-generic-switch/+bug/2024385\n\nNote that this change introduces a different retry behaviour when we fail\nto configure a device.  Since bind_port() is retried several times by\nNeutron, we indirectly benefited from these retries, but this is no longer\nthe case.  However, NGS already has an internal retry mechanism for SSH\nconnection errors, which should cover most network-related issues.\n\nTo sum up, errors that are no longer covered by a retry are the ones that\nhappen after we successfully connect to the device.  For instance, the\nswitch port may not exist on the device, or the device could be in an\nunexpected state such as a port being currently part of an unexpected\nVLAN.  This kind of errors are unlikely to be solved by retrying, so the\nnew behaviour should be fine and will even allow to return the error much\nfaster to the end-user.\n\nRelated-Bug: #2024385\nDepends-on: https://review.opendev.org/c/openstack/networking-generic-switch/+/896110\nChange-Id: If4ca9c58d7f30b40992d0f1aee7e915c6978e0ca\n(cherry picked from commit 0088fde1debfd80ab2508bfea9f2cff2a1602e80)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/c573723a4dc1d710514d6f0a48de0039b31891c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/c573723a4dc1d710514d6f0a48de0039b31891c8"}]},"branch":"refs/heads/stable/2023.2"},"4d320c5d2622e73fdb4891ce7812f26e9a12a8a4":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-11-06 22:59:47.000000000","uploader":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"ref":"refs/changes/12/896112/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-generic-switch","ref":"refs/changes/12/896112/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/12/896112/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/12/896112/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/12/896112/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-generic-switch refs/changes/12/896112/2"}}},"commit":{"parents":[{"commit":"b23d0a75ac4594558a7e9775394833436c042d9d","subject":"[CI] Remove not defined job from queue","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/b23d0a75ac4594558a7e9775394833436c042d9d"}]}],"author":{"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","date":"2022-06-21 15:20:37.000000000","tz":120},"committer":{"name":"Jay Faulkner","email":"jay@jvf.cc","date":"2024-11-06 22:59:47.000000000","tz":0},"subject":"Do not make actual device changes in bind_port()","message":"Do not make actual device changes in bind_port()\n\nAccording to the bind_port specification (as summed up in its docstring),\nwe should not make any change when bind_port() is called, because binding\nresults might end up not getting committed.\n\nTo satisfy this specification, this patch moves actual device\nreconfiguration to update_port_postcommit().\n\nThis makes the behaviour symmetrical for port creation (handled in\nupdate_port_postcommit) and port deletion (handled in delete_port_postcommit).\n\nIn addition, this will make it easier to improve performance of port\ncreation, see https://bugs.launchpad.net/networking-generic-switch/+bug/2024385\n\nNote that this change introduces a different retry behaviour when we fail\nto configure a device.  Since bind_port() is retried several times by\nNeutron, we indirectly benefited from these retries, but this is no longer\nthe case.  However, NGS already has an internal retry mechanism for SSH\nconnection errors, which should cover most network-related issues.\n\nTo sum up, errors that are no longer covered by a retry are the ones that\nhappen after we successfully connect to the device.  For instance, the\nswitch port may not exist on the device, or the device could be in an\nunexpected state such as a port being currently part of an unexpected\nVLAN.  This kind of errors are unlikely to be solved by retrying, so the\nnew behaviour should be fine and will even allow to return the error much\nfaster to the end-user.\n\nRelated-Bug: #2024385\nDepends-on: https://review.opendev.org/c/openstack/networking-generic-switch/+/896110\nChange-Id: If4ca9c58d7f30b40992d0f1aee7e915c6978e0ca\n(cherry picked from commit 0088fde1debfd80ab2508bfea9f2cff2a1602e80)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/4d320c5d2622e73fdb4891ce7812f26e9a12a8a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/4d320c5d2622e73fdb4891ce7812f26e9a12a8a4"}]},"branch":"refs/heads/stable/2023.2","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}