)]}'
{"id":"openstack%2Fnetworking-generic-switch~900884","triplet_id":"openstack%2Fnetworking-generic-switch~stable%2F2023.1~I99ea7fcb1f3365c6ecc4c96b6aa8efea3ceb4bf7","project":"openstack/networking-generic-switch","branch":"stable/2023.1","topic":"etcd_batching_save_config-stable/2023.2-stable/2023.1","attention_set":{},"removed_from_attention_set":{"14826":{"account":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"last_update":"2023-12-08 18:48:23.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I99ea7fcb1f3365c6ecc4c96b6aa8efea3ceb4bf7","subject":"Honor ngs_save_configuration setting when using batch commands","status":"MERGED","created":"2023-11-14 11:20:49.000000000","updated":"2023-12-08 18:49:21.000000000","submitted":"2023-12-08 18:48:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"900884-etcd_batching_save_config-stable/2023.2-stable/2023.1","cherry_pick_of_change":896111,"cherry_pick_of_patch_set":1,"meta_rev_id":"750e4a35fd904e61d9a9f9360a808ec6dea805ff","_number":900884,"virtual_id_number":900884,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-12-08 18:48:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2023-11-22 20:14:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":2,"date":"2023-11-15 10:37:07.000000000","_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":1,"date":"2023-11-22 20:14:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"}],"REVIEWER":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-14 11:20:49.000000000","updated_by":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"reviewer":{"_account_id":34936,"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","username":"bjonglez"},"state":"CC"},{"updated":"2023-11-14 13:21:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-22 20:14:38.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"},{"updated":"2023-12-08 14:51:59.000000000","updated_by":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"reviewer":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"state":"CC"}],"messages":[{"id":"afb7161acfa543e594d9a4ad7813ab9ff5adb33b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2023-11-14 11:20:49.000000000","message":"Patch Set 1: Cherry Picked from branch stable/2023.2.","accounts_in_message":[],"_revision_number":1},{"id":"99a6126d1add7ecb3635cd046937845040c52270","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-14 13:21:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6257f27360a64ff5b6aad790cc985d2d\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b9099b27b483468ebd708352ab3e9dd0 : SUCCESS in 4m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cc57051c40184ed9a4711eb4d71a45cb : SUCCESS in 3m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f404d032ace04c6e903071bb24457c50 : SUCCESS in 7m 16s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/68444fcf162d4287844ced08a52a0c09 : SUCCESS in 13m 31s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/5ddbb05a1772432290673a83d8c2aff4 : SUCCESS in 1h 55m 31s","accounts_in_message":[],"_revision_number":1},{"id":"7c915f79403dc6869d81546df16878ad2dde9545","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2023-11-15 10:37:07.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b37ccb2116a8a7ba84fa3ccca32b326fbad25403","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2023-11-22 20:14:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7dc5d67608003ecc573a5c51cfeddf4dfcf75ce6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-22 20:15:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8d2e7d063be7fea7a8a3c62aaf59bf7de99f5007","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-11-22 22:09:28.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/a1e13ef72a174747ab3b7e3add2cf918\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f33d0b44288544cd846242f65f9e2565 : SUCCESS in 4m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9ad1fdc513c6425c9b8215fb6aa224e7 : SUCCESS in 4m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d92bf064720c4fc1b281bf1341ea2609 : SUCCESS in 6m 43s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/bacb21b1659a47a493209aaf4cab6121 : SUCCESS in 24m 19s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/964f291df8114d39a9099cad0c2d7a9e : FAILURE in 1h 49m 08s","accounts_in_message":[],"_revision_number":1},{"id":"150de98dde8e832721962611671c15b8b5f0113a","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2023-12-08 14:51:59.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5343b513471c8dbad82ebc2927b8f5991c8db1a8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-08 16:32:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f5e91ad871914533ac84647f5de62537\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c9d0bbcb655c443cbd135525d0761983 : SUCCESS in 19m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f9797ab05177419589a03e63544f3484 : SUCCESS in 4m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/487bbdfd3d8546d1ac0393a18755565f : SUCCESS in 6m 43s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/df361fb57d1547d1bc71bcbd66c7df36 : SUCCESS in 29m 06s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/7b1c5bcf6bfc491cb7738b986d85d64f : SUCCESS in 1h 34m 56s","accounts_in_message":[],"_revision_number":1},{"id":"622944e4bcbcbeba612d024e41091f917ffff99a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-08 16:32:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ef095330f0f832b1996db8a289b5f849b1b3938f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-08 18:48:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6fc8ce56d9f248b4bcdcc2c49703c19e\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c121d3b9721e4b188e1478dfb1133cbf : SUCCESS in 4m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cb58ff79818149a0b7ce5903d4a8314c : SUCCESS in 5m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a5f0bb6d79e842998741e90c7dd4a6ca : SUCCESS in 8m 38s\n- networking-generic-switch-tempest-dlm https://zuul.opendev.org/t/openstack/build/a9100f8aab2f44acbec94fa2f6d90180 : SUCCESS in 26m 38s\n- ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode https://zuul.opendev.org/t/openstack/build/d6b3f82671514b09bc2f7f299f8d929e : SUCCESS in 2h 10m 36s","accounts_in_message":[],"_revision_number":1},{"id":"201cad747debf8f3bfc269f6e833ba95e38bf8cc","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-08 18:48:23.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"750e4a35fd904e61d9a9f9360a808ec6dea805ff","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-12-08 18:49:21.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3b968af368c74cdfb099df8c70c96aff\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7ba0e1c81ca143918794fe23827ab101 : SUCCESS in 40s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1de4b6ede7d936e025abbba0496432db34010439","revisions":{"1de4b6ede7d936e025abbba0496432db34010439":{"kind":"REWORK","_number":1,"created":"2023-11-14 11:20:49.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/84/900884/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/networking-generic-switch","ref":"refs/changes/84/900884/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/84/900884/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/84/900884/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/networking-generic-switch refs/changes/84/900884/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/networking-generic-switch refs/changes/84/900884/1"}}},"commit":{"parents":[{"commit":"555725b27080cd8f442700e36ab9d9624153e530","subject":"Fix regression plugging 802.3ad port group","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/555725b27080cd8f442700e36ab9d9624153e530"}]}],"author":{"name":"Baptiste Jonglez","email":"baptiste.jonglez@inria.fr","date":"2023-06-05 16:37:36.000000000","tz":120},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2023-11-14 11:20:49.000000000","tz":0},"subject":"Honor ngs_save_configuration setting when using batch commands","message":"Honor ngs_save_configuration setting when using batch commands\n\nSince [1], we have an option to skip saving configuration on the target\ndevices.  The batching implementation merged recently did not take into\naccount this new setting, fix the issue.\n\n[1] https://review.opendev.org/c/openstack/networking-generic-switch/+/868314\n\n\nDepends-on: https://review.opendev.org/c/openstack/networking-generic-switch/+/896110\nChange-Id: I99ea7fcb1f3365c6ecc4c96b6aa8efea3ceb4bf7\n(cherry picked from commit e3554eb0a4b3dcfb2b2539a71aaec7d50c85fdfa)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/1de4b6ede7d936e025abbba0496432db34010439"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/networking-generic-switch/commit/1de4b6ede7d936e025abbba0496432db34010439"}]},"branch":"refs/heads/stable/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}