)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b423ea07a0cbe0d75058a569a9e71dc31b886348","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"85b28ad3_53285384","updated":"2024-08-26 12:51:19.000000000","message":"A rebase will be required, unfortunately. Should be clean.","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"08d173198f0ee7fd4dd0d2fd73b6a39240afe405","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d88ba615_25feb738","updated":"2024-08-23 20:18:53.000000000","message":"I don\u0027t have hardware to confirm that this works, but it looks sane to me.","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"176d628235852e7cdc9290e0d1b3461c9ac68530","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f0635616_8ec7f9c6","updated":"2024-08-26 12:51:37.000000000","message":"Ideally, please add some docs","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"3fdd6ac93d44f6edfc169309bced8104aae5d3ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"710f2fa4_871f433f","updated":"2024-08-26 20:43:33.000000000","message":"Changed the CopyRight \n\nWith regards to the tests as this is a copy of the current tests I should not be the one having to go and change all other tests I think that should be a new submit.","commit_id":"c2f0dcdef8eb508ca2e6cd0bc95b5d0f91450ea7"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"db5cace973d3177b3b2907227eac00397e2337e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a62a8fe5_4dc90d9d","updated":"2024-09-27 08:41:50.000000000","message":"As all other Tests are the same format as my one I will not change it another review should be created to change all others to suite that request.\n\nPlease can then now be pushed through as it follows the standards like for like as the other tests.","commit_id":"73d2d5e13429523999bc5f10ea5d56515e206777"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"6e4536219ec953efe468b1bf8dd46d0b07f5a503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"31169c05_8c0c1945","updated":"2024-09-27 10:10:07.000000000","message":"Added autospec.","commit_id":"64da5413de1004842fd570e41e574c0b8fd5fc8f"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8e9935abc03e687372565c763b8b4704c18877dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5965dbd9_1f5a3f77","updated":"2024-09-30 09:32:52.000000000","message":"\u003e As all other Tests are the same format as my one I will not change it another review should be created to change all others to suite that request.\n\nThis is not a valid reasoning, especially when it comes to rather trivial changes.\n\nAlso, please add the docs.","commit_id":"7317fde1912da83500354f977c529ef1119a8810"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"fc6edf44ea52e5aba1b5004c1db3a3e289088650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a7ca1531_9104abec","in_reply_to":"5965dbd9_1f5a3f77","updated":"2024-09-30 09:38:10.000000000","message":"I don\u0027t understand what you mean by docs?\nPlease could you explain.","commit_id":"7317fde1912da83500354f977c529ef1119a8810"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"eb7d8e1792e7ef9c09e7ed954c7be164b6808fd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ad450574_aaa48486","updated":"2024-09-30 15:51:30.000000000","message":"Please add a docstring for the new class.\n\nIt\u0027d be ideal to have more docs, but looking at https://docs.openstack.org/networking-generic-switch/latest/ we have borderline-nothing for anything at the moment so I\u0027m not sure what specifically to suggest (and don\u0027t hinge my +2 on them being added as a result).","commit_id":"0dac35e579cd479c18934fb4ccd853035698ef97"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3cdf8152c7fa9e69f8038ba5dea938786718ee56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9bedcfd6_a1296c79","updated":"2024-09-30 16:35:06.000000000","message":"FYI some trailing whitespace got added in smc.py; it might fail pep8. I\u0027m OK with the code and won\u0027t -1 for style things -- that is CI\u0027s job.","commit_id":"28a55567cdcef005e077077392b72e90ed1b4d5b"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"1931ab710a75f2971b973483291590de56dcc0d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"01d5c638_9be20908","updated":"2024-10-01 08:26:30.000000000","message":"I\u0027m ok with this, it looks good, thanks for updating the tests\nWe should probably merge this https://review.opendev.org/c/openstack/networking-generic-switch/+/930745 first to avoid conflicts","commit_id":"518742af6bbd9c3eed7804016b3a678141e01fcd"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"5216f7806d9566d4a8436b7e43e46b488fb83a7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ea39be94_fe7dee88","updated":"2024-09-30 16:39:56.000000000","message":"Sorry I fixed the whitespace problem again don\u0027t know anything about pep8 so that\u0027s the best I can do.","commit_id":"518742af6bbd9c3eed7804016b3a678141e01fcd"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"bfd85e09b2b90ab1716cc8142a732adaba4e7ea3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"867b9f41_88fbe468","in_reply_to":"01d5c638_9be20908","updated":"2024-10-01 08:27:02.000000000","message":"or not actually, it doesn\u0027t really matter! :D","commit_id":"518742af6bbd9c3eed7804016b3a678141e01fcd"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"0f17aba366675bf5411d4d6a2d95b488241f9f8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"85e74a55_f8ab7f70","in_reply_to":"ea39be94_fe7dee88","updated":"2024-09-30 16:41:19.000000000","message":"You can run `tox -epep8` from the base of the repo to run that CI job locally to test. \n\nMuch of https://docs.openstack.org/ironic/latest/contributor/dev-quickstart.html#running-unit-tests-locally will apply here.\n\n(although I think you\u0027re fine now)","commit_id":"518742af6bbd9c3eed7804016b3a678141e01fcd"}],"doc/source/configuration.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3cdf8152c7fa9e69f8038ba5dea938786718ee56","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    password \u003d password"},{"line_number":225,"context_line":"    ip \u003d \u003cswitch mgmt ip address\u003e"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"for the Supermicro device::"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    [genericswitch:sw-hostname]"},{"line_number":230,"context_line":"    device_type \u003d netmiko_supermicro_smis"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9ba1e2b0_8b5e6ca4","line":227,"updated":"2024-09-30 16:35:06.000000000","message":"awesome, ty","commit_id":"28a55567cdcef005e077077392b72e90ed1b4d5b"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"5216f7806d9566d4a8436b7e43e46b488fb83a7c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    password \u003d password"},{"line_number":225,"context_line":"    ip \u003d \u003cswitch mgmt ip address\u003e"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"for the Supermicro device::"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    [genericswitch:sw-hostname]"},{"line_number":230,"context_line":"    device_type \u003d netmiko_supermicro_smis"}],"source_content_type":"text/x-rst","patch_set":11,"id":"7d2791ff_ed7ed984","line":227,"in_reply_to":"9ba1e2b0_8b5e6ca4","updated":"2024-09-30 16:39:56.000000000","message":"Done","commit_id":"28a55567cdcef005e077077392b72e90ed1b4d5b"}],"networking_generic_switch/devices/netmiko_devices/smc.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"eb7d8e1792e7ef9c09e7ed954c7be164b6808fd0","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class SupermicroSmis(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan {segmentation_id}\u0027,"},{"line_number":21,"context_line":"        \u0027name {network_name}\u0027,"},{"line_number":22,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":10,"id":"d8fca860_14827f9d","line":19,"updated":"2024-09-30 15:51:30.000000000","message":"Please add a docstring for this class","commit_id":"0dac35e579cd479c18934fb4ccd853035698ef97"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"5216f7806d9566d4a8436b7e43e46b488fb83a7c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class SupermicroSmis(netmiko_devices.NetmikoSwitch):"},{"line_number":19,"context_line":"    ADD_NETWORK \u003d ("},{"line_number":20,"context_line":"        \u0027vlan {segmentation_id}\u0027,"},{"line_number":21,"context_line":"        \u0027name {network_name}\u0027,"},{"line_number":22,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":10,"id":"bde897b7_8f8b2a34","line":19,"in_reply_to":"d8fca860_14827f9d","updated":"2024-09-30 16:39:56.000000000","message":"Done","commit_id":"0dac35e579cd479c18934fb4ccd853035698ef97"}],"networking_generic_switch/tests/unit/netmiko/test_smc.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"176d628235852e7cdc9290e0d1b3461c9ac68530","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"691a5e03_2315d644","line":1,"updated":"2024-08-26 12:51:37.000000000","message":"This copyright does not look correct","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"3fdd6ac93d44f6edfc169309bced8104aae5d3ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Mirantis, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"854ff73d_023e5ad0","line":1,"in_reply_to":"691a5e03_2315d644","updated":"2024-08-26 20:43:33.000000000","message":"Acknowledged","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"176d628235852e7cdc9290e0d1b3461c9ac68530","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        return smc.SupermicroSmis(device_cfg)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_constants(self):"},{"line_number":28,"context_line":"        self.assertIsNone(self.switch.SAVE_CONFIGURATION)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @mock.patch(\u0027networking_generic_switch.devices.netmiko_devices.\u0027"},{"line_number":31,"context_line":"                \u0027NetmikoSwitch.send_commands_to_device\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0fe3a9fa_90860818","line":28,"updated":"2024-08-26 12:51:37.000000000","message":"nit: this does not seem to be a useful test","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"3fdd6ac93d44f6edfc169309bced8104aae5d3ea","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        return smc.SupermicroSmis(device_cfg)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_constants(self):"},{"line_number":28,"context_line":"        self.assertIsNone(self.switch.SAVE_CONFIGURATION)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @mock.patch(\u0027networking_generic_switch.devices.netmiko_devices.\u0027"},{"line_number":31,"context_line":"                \u0027NetmikoSwitch.send_commands_to_device\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b8d25c49_88ed1ae0","line":28,"in_reply_to":"0fe3a9fa_90860818","updated":"2024-08-26 20:43:33.000000000","message":"These tests are a copy of the cisco ios tests and changed to match the SMC I figured if it was good enough for cisco it should be good enough for this as it\u0027s a like for like driver only thing it changes it the save which is controlled in the netmiko driver outside the scope of this.","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"db5cace973d3177b3b2907227eac00397e2337e0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        return smc.SupermicroSmis(device_cfg)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def test_constants(self):"},{"line_number":28,"context_line":"        self.assertIsNone(self.switch.SAVE_CONFIGURATION)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @mock.patch(\u0027networking_generic_switch.devices.netmiko_devices.\u0027"},{"line_number":31,"context_line":"                \u0027NetmikoSwitch.send_commands_to_device\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"75373e40_b74b3a2f","line":28,"in_reply_to":"b8d25c49_88ed1ae0","updated":"2024-09-27 08:41:50.000000000","message":"Acknowledged","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"176d628235852e7cdc9290e0d1b3461c9ac68530","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        self.assertIsNone(self.switch.SAVE_CONFIGURATION)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @mock.patch(\u0027networking_generic_switch.devices.netmiko_devices.\u0027"},{"line_number":31,"context_line":"                \u0027NetmikoSwitch.send_commands_to_device\u0027)"},{"line_number":32,"context_line":"    def test_add_network(self, m_exec):"},{"line_number":33,"context_line":"        self.switch.add_network(33, \u00270ae071f5-5be9-43e4-80ea-e41fefe85b21\u0027)"},{"line_number":34,"context_line":"        m_exec.assert_called_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"41100464_6bee9def","line":31,"updated":"2024-08-26 12:51:37.000000000","message":"I don\u0027t know why the linter job does not complain, but all mocks should be created with autospec\u003dTrue argument.","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"db5cace973d3177b3b2907227eac00397e2337e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.assertIsNone(self.switch.SAVE_CONFIGURATION)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @mock.patch(\u0027networking_generic_switch.devices.netmiko_devices.\u0027"},{"line_number":31,"context_line":"                \u0027NetmikoSwitch.send_commands_to_device\u0027)"},{"line_number":32,"context_line":"    def test_add_network(self, m_exec):"},{"line_number":33,"context_line":"        self.switch.add_network(33, \u00270ae071f5-5be9-43e4-80ea-e41fefe85b21\u0027)"},{"line_number":34,"context_line":"        m_exec.assert_called_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"e553d1cc_ddd123fc","line":31,"in_reply_to":"1f07e757_693ae43e","updated":"2024-09-27 08:41:50.000000000","message":"Acknowledged","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"3fdd6ac93d44f6edfc169309bced8104aae5d3ea","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        self.assertIsNone(self.switch.SAVE_CONFIGURATION)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @mock.patch(\u0027networking_generic_switch.devices.netmiko_devices.\u0027"},{"line_number":31,"context_line":"                \u0027NetmikoSwitch.send_commands_to_device\u0027)"},{"line_number":32,"context_line":"    def test_add_network(self, m_exec):"},{"line_number":33,"context_line":"        self.switch.add_network(33, \u00270ae071f5-5be9-43e4-80ea-e41fefe85b21\u0027)"},{"line_number":34,"context_line":"        m_exec.assert_called_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f07e757_693ae43e","line":31,"in_reply_to":"41100464_6bee9def","updated":"2024-08-26 20:43:33.000000000","message":"These tests are a copy of the cisco ios tests and changed to match the SMC I figured if it was good enough for cisco it should be good enough for this as it\u0027s a like for like driver only thing it changes it the save which is controlled in the netmiko driver outside the scope of this.","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"d0316eaf942f784b0d64db3ec89db51fe4403261","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        self.assertIsNone(self.switch.SAVE_CONFIGURATION)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @mock.patch(\u0027networking_generic_switch.devices.netmiko_devices.\u0027"},{"line_number":31,"context_line":"                \u0027NetmikoSwitch.send_commands_to_device\u0027)"},{"line_number":32,"context_line":"    def test_add_network(self, m_exec):"},{"line_number":33,"context_line":"        self.switch.add_network(33, \u00270ae071f5-5be9-43e4-80ea-e41fefe85b21\u0027)"},{"line_number":34,"context_line":"        m_exec.assert_called_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"eea37de5_4b051af2","line":31,"in_reply_to":"e553d1cc_ddd123fc","updated":"2024-09-27 09:11:50.000000000","message":"we\u0027re not enforcing the check for autospec, yet\nthat doesn\u0027t mean we should accept new tests that are potentially wrong\nplease add autospec\u003dTrue\nthanks","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"6e4536219ec953efe468b1bf8dd46d0b07f5a503","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        self.assertIsNone(self.switch.SAVE_CONFIGURATION)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @mock.patch(\u0027networking_generic_switch.devices.netmiko_devices.\u0027"},{"line_number":31,"context_line":"                \u0027NetmikoSwitch.send_commands_to_device\u0027)"},{"line_number":32,"context_line":"    def test_add_network(self, m_exec):"},{"line_number":33,"context_line":"        self.switch.add_network(33, \u00270ae071f5-5be9-43e4-80ea-e41fefe85b21\u0027)"},{"line_number":34,"context_line":"        m_exec.assert_called_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"1383da7b_772aaf2e","line":31,"in_reply_to":"eea37de5_4b051af2","updated":"2024-09-27 10:10:07.000000000","message":"Acknowledged","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"176d628235852e7cdc9290e0d1b3461c9ac68530","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        cmd_set \u003d self.switch._format_commands("},{"line_number":68,"context_line":"            smc.SupermicroSmis.DELETE_NETWORK,"},{"line_number":69,"context_line":"            segmentation_id\u003d22)"},{"line_number":70,"context_line":"        self.assertEqual(cmd_set, [\u0027no vlan 22\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        cmd_set \u003d self.switch._format_commands("},{"line_number":73,"context_line":"            smc.SupermicroSmis.PLUG_PORT_TO_NETWORK,"}],"source_content_type":"text/x-python","patch_set":4,"id":"057fcf0c_f4e74150","line":70,"updated":"2024-08-26 12:51:37.000000000","message":"nit: each of these should be a separate test","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"3fdd6ac93d44f6edfc169309bced8104aae5d3ea","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        cmd_set \u003d self.switch._format_commands("},{"line_number":68,"context_line":"            smc.SupermicroSmis.DELETE_NETWORK,"},{"line_number":69,"context_line":"            segmentation_id\u003d22)"},{"line_number":70,"context_line":"        self.assertEqual(cmd_set, [\u0027no vlan 22\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        cmd_set \u003d self.switch._format_commands("},{"line_number":73,"context_line":"            smc.SupermicroSmis.PLUG_PORT_TO_NETWORK,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fcea564c_247dff6d","line":70,"in_reply_to":"057fcf0c_f4e74150","updated":"2024-08-26 20:43:33.000000000","message":"These tests are a copy of the cisco ios tests and changed to match the SMC I figured if it was good enough for cisco it should be good enough for this as it\u0027s a like for like driver only thing it changes it the save which is controlled in the netmiko driver outside the scope of this.","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"},{"author":{"_account_id":35976,"name":"Graeme Moss","display_name":"Graeme Moss","email":"graeme.moss@nscale.com","username":"gmoss"},"change_message_id":"db5cace973d3177b3b2907227eac00397e2337e0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        cmd_set \u003d self.switch._format_commands("},{"line_number":68,"context_line":"            smc.SupermicroSmis.DELETE_NETWORK,"},{"line_number":69,"context_line":"            segmentation_id\u003d22)"},{"line_number":70,"context_line":"        self.assertEqual(cmd_set, [\u0027no vlan 22\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        cmd_set \u003d self.switch._format_commands("},{"line_number":73,"context_line":"            smc.SupermicroSmis.PLUG_PORT_TO_NETWORK,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d0073919_0f576e61","line":70,"in_reply_to":"fcea564c_247dff6d","updated":"2024-09-27 08:41:50.000000000","message":"Acknowledged","commit_id":"04b2509371b7f57e1a968c29529b6c641519a293"}]}