)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3db6e6c202f0672a86da373392a6133ce3b8f7c0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds vlan aware VMs support for Cumulus NVUE and DellOS10"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Prod: PRODX-49695"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id8b90b1a4c2dca244d039bbdffd6030ed99cc1af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e5c91437_9971bf3a","line":9,"updated":"2025-02-19 20:25:47.000000000","message":"Please do not include opaque, non-OpenStack identifiers in commits. If this is for some kind of public tracker, it would be borderline-acceptable as a direct link, but this is completely meaningless to most openstackers as-is (including me!).","commit_id":"c893ebadcd6f12fb6c9a79f8c438675d9de86005"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"68287a66d80f83344c259dd377ef738e73b47778","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds vlan aware VMs support for Cumulus NVUE and DellOS10"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Prod: PRODX-49695"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id8b90b1a4c2dca244d039bbdffd6030ed99cc1af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ea2873a0_d8d7a541","line":9,"in_reply_to":"e5c91437_9971bf3a","updated":"2025-03-04 06:05:20.000000000","message":"Sorry, its left by mistake.","commit_id":"c893ebadcd6f12fb6c9a79f8c438675d9de86005"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"5dd66b92d75011d00935ead2828b925c5e8190ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a898846_64692887","updated":"2025-02-07 13:10:57.000000000","message":"I\u0027ve added this separately as I\u0027ve not done any real world testing, but feel free to merge into parent.","commit_id":"9347a02e41316c25d09de004aa0ea22b24fb2ed4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"730e872d2101d4e8d7cc726f125b9136e10e67c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"822e5d2d_2dec30d3","updated":"2025-02-18 12:58:08.000000000","message":"@vsaienko@mirantis.com wouldn\u0027t it be better to incorporate it in the parent patch?","commit_id":"c893ebadcd6f12fb6c9a79f8c438675d9de86005"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3db6e6c202f0672a86da373392a6133ce3b8f7c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a9ac02fb_3af1d9d0","updated":"2025-02-19 20:25:47.000000000","message":"I don\u0027t know the switches well enough to review the content there other than for \"yep, that doesn\u0027t look malicious and is plausibly accurate\". I can provide a +2 if my issue is fixed and there\u0027s nobody in the Ironic core reviewer set who can attest to those commands.","commit_id":"c893ebadcd6f12fb6c9a79f8c438675d9de86005"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e9ef24ac197b335f86d3580a1be202b4e8c66fdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ccb8e3f3_574bb018","updated":"2025-02-18 22:04:47.000000000","message":"recheck","commit_id":"c893ebadcd6f12fb6c9a79f8c438675d9de86005"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"332436a5450b953ecf59cecc6c6247b948cc5314","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63d92a5c_36284a98","updated":"2025-02-18 16:24:16.000000000","message":"recheck unrelated failure","commit_id":"c893ebadcd6f12fb6c9a79f8c438675d9de86005"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"41829560fe38f1e3bb4ae733ec2972f5ffb89736","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9b97d7ed_9290fdba","in_reply_to":"822e5d2d_2dec30d3","updated":"2025-02-18 14:04:38.000000000","message":"you mean in original one? I do not think so, better to split work it will be easier to review and test.","commit_id":"c893ebadcd6f12fb6c9a79f8c438675d9de86005"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"68287a66d80f83344c259dd377ef738e73b47778","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4d67587b_d3bc62f5","in_reply_to":"a9ac02fb_3af1d9d0","updated":"2025-03-04 06:05:20.000000000","message":"I verified it on cumulus. We can drop switches that were not verified or letf them and let users who will try it and face with issues patch code as bugfixes.","commit_id":"c893ebadcd6f12fb6c9a79f8c438675d9de86005"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"68287a66d80f83344c259dd377ef738e73b47778","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6bc51d8e_9c2460a3","updated":"2025-03-04 06:05:20.000000000","message":"recheck","commit_id":"329d13f769671f02b23713cf1d951382c51a8df2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1388d6866f143e2f67c5b4adb292cd1af1e4d17c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"842b8eb5_ba20e712","updated":"2025-03-04 18:53:55.000000000","message":"recheck","commit_id":"329d13f769671f02b23713cf1d951382c51a8df2"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f3fc8897a6fe73db662b0a3836389e6f8cbf4038","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fba52580_a7fc1753","updated":"2025-02-28 10:06:22.000000000","message":"recheck","commit_id":"329d13f769671f02b23713cf1d951382c51a8df2"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"e9ec7a9c535c96cdb0aec757ccf3e1e4ff250390","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a2cc7695_f72e7e97","updated":"2025-03-11 09:03:41.000000000","message":"Is it failing tests because of the removal of the Depends-On: https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/941013 that was on the parent commit?","commit_id":"1b53447e19663d6927b404d961e3c5996d24da85"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"593335e834ee5402d0cb5ed061cfbd3e3d597b11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a09ac6dd_5cac9a86","updated":"2025-03-11 04:51:14.000000000","message":"recheck","commit_id":"1b53447e19663d6927b404d961e3c5996d24da85"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"de2bdcf5f4301bbf309e2985cb89dc5837d4f4c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cb19c8f0_056a40c2","updated":"2025-03-10 18:42:07.000000000","message":"recheck","commit_id":"1b53447e19663d6927b404d961e3c5996d24da85"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ec15b4d56acf4ca23e04e87ef675c7d53aa855bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d083d630_b18b3a22","updated":"2025-03-11 11:41:55.000000000","message":"recheck","commit_id":"1b53447e19663d6927b404d961e3c5996d24da85"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a6ee82098469e668401004313e877ca4a3b02ba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"525ca9bf_d9901374","in_reply_to":"a2cc7695_f72e7e97","updated":"2025-03-11 11:42:15.000000000","message":"no, its failing on completely independent test.","commit_id":"1b53447e19663d6927b404d961e3c5996d24da85"}],"networking_generic_switch/devices/netmiko_devices/cumulus.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c3817b5b4d6936ca36d4339b67d0b7ece12b9680","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    ]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    ADD_NETWORK_TO_TRUNK \u003d ["},{"line_number":125,"context_line":"        \u0027nv unset interface {port} bridge domain br_default access\u0027,"},{"line_number":126,"context_line":"        \u0027nv set interface {port} bridge domain br_default vlan \u0027"},{"line_number":127,"context_line":"        \u0027{segmentation_id}\u0027,"},{"line_number":128,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"73a7d033_7a156935","line":125,"updated":"2025-02-13 10:45:10.000000000","message":"the list of commands here is not actually correct, once trunk is configured there is no way to return back to regular non trunk port, the following commands works for me\n\n```\n    PLUG_PORT_TO_NETWORK \u003d [\n        \u0027nv unset interface {port} bridge domain br_default untagged\u0027,\n        \u0027nv set interface {port} bridge domain br_default access \u0027\n        \u0027{segmentation_id}\u0027,\n    ]\n\n    ADD_NETWORK_TO_TRUNK \u003d [\n        \u0027nv unset interface {port} bridge domain br_default access\u0027,\n        \u0027nv set interface {port} bridge domain br_default vlan \u0027\n        \u0027{segmentation_id}\u0027,\n    ]\n\n    ADD_NETWORK_TO_BOND_TRUNK \u003d [\n        \u0027nv unset interface {bond} bridge domain br_default access\u0027,\n        \u0027nv set interface {bond} bridge domain br_default vlan \u0027\n        \u0027{segmentation_id}\u0027,\n    ]\n\n    REMOVE_NETWORK_FROM_TRUNK \u003d (\n        \u0027nv unset interface {port} bridge domain br_default vlan \u0027\n        \u0027{segmentation_id}\u0027,\n    )\n\n    DELETE_NETWORK_ON_BOND_TRUNK \u003d (\n        \u0027nv unset interface {bond} bridge domain br_default vlan \u0027\n        \u0027{segmentation_id}\u0027,\n    )\n\n    SET_NATIVE_VLAN \u003d [\n        \u0027nv unset interface {port} bridge domain br_default access\u0027,\n        \u0027nv set interface {port} bridge domain br_default untagged \u0027\n        \u0027{segmentation_id}\u0027,\n        \u0027nv set interface {port} bridge domain br_default vlan \u0027\n        \u0027{segmentation_id}\u0027,\n    ]\n\n    SET_NATIVE_VLAN_BOND \u003d [\n        \u0027nv unset interface {bond} bridge domain br_default access\u0027,\n        \u0027nv set interface {bond} bridge domain br_default untagged \u0027\n        \u0027{segmentation_id}\u0027,\n        \u0027nv set interface {bond} bridge domain br_default vlan \u0027\n        \u0027{segmentation_id}\u0027,\n    ]\n\n    DELETE_NATIVE_VLAN \u003d (\n        \u0027nv unset interface {port} bridge domain br_default untagged \u0027\n        \u0027{segmentation_id}\u0027,\n        \u0027nv unset interface {port} bridge domain br_default vlan \u0027\n        \u0027{segmentation_id}\u0027,\n    )\n\n    DELETE_NATIVE_VLAN_BOND \u003d (\n        \u0027nv unset interface {bond} bridge domain br_default untagged \u0027\n        \u0027{segmentation_id}\u0027,\n        \u0027nv unset interface {bond} bridge domain br_default vlan \u0027\n        \u0027{segmentation_id}\u0027,\n    )\n\n    DELETE_PORT \u003d [\n        \u0027nv unset interface {port} bridge domain br_default access\u0027,\n        \u0027nv unset interface {port} bridge domain br_default untagged\u0027,\n        \u0027nv unset interface {port} bridge domain br_default vlan\u0027,\n    ]\n```","commit_id":"38815586193cfd54ecca75ff2d8d54af124b2588"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"422a24ffd4b582ce2e803c455d931d1acf8cf2fc","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    ]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    ADD_NETWORK_TO_TRUNK \u003d ["},{"line_number":125,"context_line":"        \u0027nv unset interface {port} bridge domain br_default access\u0027,"},{"line_number":126,"context_line":"        \u0027nv set interface {port} bridge domain br_default vlan \u0027"},{"line_number":127,"context_line":"        \u0027{segmentation_id}\u0027,"},{"line_number":128,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"a26d482c_844c55ca","line":125,"in_reply_to":"73a7d033_7a156935","updated":"2025-02-18 10:25:53.000000000","message":"Done","commit_id":"38815586193cfd54ecca75ff2d8d54af124b2588"}]}