)]}'
{"networking_generic_switch/batching.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"330224d9b0430f516a1e40783cdde9f20623f284","unresolved":true,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"            if device._get_save_configuration():"},{"line_number":446,"context_line":"                try:"},{"line_number":447,"context_line":"                    device.save_configuration(net_connect)"},{"line_number":448,"context_line":"                except Exception:"},{"line_number":449,"context_line":"                    # Probably not worth failing all batches for this."},{"line_number":450,"context_line":"                    LOG.exception(\"Failed to save configuration\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"097a84fc_4fc33f83","line":447,"updated":"2025-05-29 17:31:55.000000000","message":"I don\u0027t fully understand all the operating modes, but it seems like this is important to not do when we don\u0027t have the lock, right? Can we make more clear why this is OK in the ln 438-442 comments if/when you get this un-wip","commit_id":"74a8f17820d102f4406ee2f389085c4736ff2eba"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0c0d50edac9f4cff4612fa433443820377b950a9","unresolved":true,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"            if device._get_save_configuration():"},{"line_number":446,"context_line":"                try:"},{"line_number":447,"context_line":"                    device.save_configuration(net_connect)"},{"line_number":448,"context_line":"                except Exception:"},{"line_number":449,"context_line":"                    # Probably not worth failing all batches for this."},{"line_number":450,"context_line":"                    LOG.exception(\"Failed to save configuration\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1734aaed_400357d1","line":447,"in_reply_to":"097a84fc_4fc33f83","updated":"2025-08-04 13:36:55.000000000","message":"Sorry, forgot about this patch till I found it on Friday.\n\nYou make a good point, and I didn\u0027t think about it like that. This is probably a bad idea... it certainly needs more thought.\n\nI don\u0027t have enough evidence on exactly the failure mode right now, but it was a guess that we end up with unapplied switch config, because we hit this escape point.\n\nIt seems to be happening more with trunked ports, so there is some interaction I haven\u0027t fully worked out. I hope to get back to this again soon, to better understand the bug.","commit_id":"74a8f17820d102f4406ee2f389085c4736ff2eba"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"3daf5f2d5c608b9ef6c26d94eaefa99f6a44417a","unresolved":true,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"            if device._get_save_configuration():"},{"line_number":446,"context_line":"                try:"},{"line_number":447,"context_line":"                    device.save_configuration(net_connect)"},{"line_number":448,"context_line":"                except Exception:"},{"line_number":449,"context_line":"                    # Probably not worth failing all batches for this."},{"line_number":450,"context_line":"                    LOG.exception(\"Failed to save configuration\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"cead8869_c60a4ac5","line":447,"in_reply_to":"1734aaed_400357d1","updated":"2025-08-14 15:23:37.000000000","message":"There seems to be an opportunity for a slightly larger discussion, more about eventual consistency as well, but that is well beyond this scope.\n\nI guess, it would make sense to try and understand the bug. With that further framing I think I guess I could be okay with this change. To me it actually kind of makes sense, but I\u0027m sort of more curious about the unapplied configuration issues you mentioned. At least, recording the result begins to bring forward clarity.","commit_id":"74a8f17820d102f4406ee2f389085c4736ff2eba"}],"tox.ini":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"330224d9b0430f516a1e40783cdde9f20623f284","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox ]"},{"line_number":2,"context_line":"minversion \u003d 4.4.0"},{"line_number":3,"context_line":"envlist \u003d py3,pep8"},{"line_number":4,"context_line":"ignore_basepython_conflict\u003dtrue"}],"source_content_type":"text/x-properties","patch_set":1,"id":"a0446382_78701277","line":1,"updated":"2025-05-29 17:31:55.000000000","message":"unintentional?","commit_id":"74a8f17820d102f4406ee2f389085c4736ff2eba"}]}