)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"e7bdc89155d87980c3b6e036bf1e1ecdc0ce32bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"49ab6707_bd441198","updated":"2025-08-14 14:04:48.000000000","message":"LGTM, thanks!","commit_id":"da64a2c65dd00e7dd7c806eb3a1a98022916b4e5"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"be1c447bc303bcad830314aab06c8983053df613","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5d491c19_42fe7998","updated":"2025-09-22 15:12:33.000000000","message":"recheck","commit_id":"fa20b9fd22c14afb4ddbc989a5951cc6509835a0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"62384714fc9101bac5d85158deb5b783dc0d2c98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"018b15ca_9766c6cf","updated":"2025-09-03 16:43:33.000000000","message":"recheck updated results needed","commit_id":"fa20b9fd22c14afb4ddbc989a5951cc6509835a0"}],"doc/source/configuration.rst":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"027a1b06b757176660483a8a432ae9e1d9fab9c2","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    device_type \u003d netmiko_cisco_nxos"},{"line_number":70,"context_line":"    ngs_mac_address \u003d \u003cswitch mac address\u003e"},{"line_number":71,"context_line":"    # if security group support is required"},{"line_number":72,"context_line":"    ngs_security_groups_enabled \u003d True"},{"line_number":73,"context_line":"    ip \u003d \u003cswitch mgmt ip address\u003e"},{"line_number":74,"context_line":"    username \u003d admin"},{"line_number":75,"context_line":"    password \u003d password"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fbf73f18_54e6af8a","line":72,"updated":"2025-08-14 18:26:58.000000000","message":"I know there were some concerns about SG performance or rule number limitations on many switches (and I know this is true on some NX-OS devices), should we put a warning here rather than just directing people to enable it if they want SG?","commit_id":"da64a2c65dd00e7dd7c806eb3a1a98022916b4e5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b55fe3b19541a40908d06952fd25404912b25e13","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    device_type \u003d netmiko_cisco_nxos"},{"line_number":70,"context_line":"    ngs_mac_address \u003d \u003cswitch mac address\u003e"},{"line_number":71,"context_line":"    # if security group support is required"},{"line_number":72,"context_line":"    ngs_security_groups_enabled \u003d True"},{"line_number":73,"context_line":"    ip \u003d \u003cswitch mgmt ip address\u003e"},{"line_number":74,"context_line":"    username \u003d admin"},{"line_number":75,"context_line":"    password \u003d password"}],"source_content_type":"text/x-rst","patch_set":4,"id":"665b4f9a_6021b0b9","line":72,"in_reply_to":"6f9085df_4f45fb63","updated":"2025-09-03 16:43:25.000000000","message":"I think a starting point is reasonable, I think we can iterate on it.","commit_id":"da64a2c65dd00e7dd7c806eb3a1a98022916b4e5"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"0d60cad77318936213e28e6be2c85cf5550486f9","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    device_type \u003d netmiko_cisco_nxos"},{"line_number":70,"context_line":"    ngs_mac_address \u003d \u003cswitch mac address\u003e"},{"line_number":71,"context_line":"    # if security group support is required"},{"line_number":72,"context_line":"    ngs_security_groups_enabled \u003d True"},{"line_number":73,"context_line":"    ip \u003d \u003cswitch mgmt ip address\u003e"},{"line_number":74,"context_line":"    username \u003d admin"},{"line_number":75,"context_line":"    password \u003d password"}],"source_content_type":"text/x-rst","patch_set":4,"id":"6f9085df_4f45fb63","line":72,"in_reply_to":"7e5869b2_a52d3fe7","updated":"2025-09-02 21:09:10.000000000","message":"The generated docs now supported a dedicated Security Group Implementation section:\n\nhttps://d95ccd5f08dc5cec97c5-667e59a55d2239af414b0984e42f005a.ssl.cf2.rackcdn.com/openstack/c8d6fbf27beb4dc68f947d66f3b01c61/docs/netmiko-device-commands.html#security-group-implementation\n\nI\u0027d like to strike a balance between not mentioning hardware limitations at all vs having to iterate the limitations of every \"supported\" model. How about I pick one representative model, outline the limitations, and encourage the reader to confirm the limitations of their own hardware meets their needs?","commit_id":"da64a2c65dd00e7dd7c806eb3a1a98022916b4e5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ef299784477c80a4c7adb27490fa0d7a70774eca","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    device_type \u003d netmiko_cisco_nxos"},{"line_number":70,"context_line":"    ngs_mac_address \u003d \u003cswitch mac address\u003e"},{"line_number":71,"context_line":"    # if security group support is required"},{"line_number":72,"context_line":"    ngs_security_groups_enabled \u003d True"},{"line_number":73,"context_line":"    ip \u003d \u003cswitch mgmt ip address\u003e"},{"line_number":74,"context_line":"    username \u003d admin"},{"line_number":75,"context_line":"    password \u003d password"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7e5869b2_a52d3fe7","line":72,"in_reply_to":"fbf73f18_54e6af8a","updated":"2025-09-02 18:58:42.000000000","message":"I think this applies to *every* single switch vendor out there.","commit_id":"da64a2c65dd00e7dd7c806eb3a1a98022916b4e5"}],"releasenotes/notes/nx-os-sg-804cc5831089448a.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"027a1b06b757176660483a8a432ae9e1d9fab9c2","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Only ingress rules allowed"},{"line_number":14,"context_line":"    * Only IPv4 rules are implemented"},{"line_number":15,"context_line":"    * Supports rules for protocols: tcp, udp, icmp"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7e4ecd6c_5dc73644","line":15,"updated":"2025-08-14 18:26:58.000000000","message":"We don\u0027t validate this in code; what happens if someone tries to go past these limits? Hopefully not that it goes outta the ASIC and starts CPU-switching...","commit_id":"da64a2c65dd00e7dd7c806eb3a1a98022916b4e5"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"0d60cad77318936213e28e6be2c85cf5550486f9","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    * Only ingress rules allowed"},{"line_number":14,"context_line":"    * Only IPv4 rules are implemented"},{"line_number":15,"context_line":"    * Supports rules for protocols: tcp, udp, icmp"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c053e38d_10e57ed8","line":15,"in_reply_to":"7e4ecd6c_5dc73644","updated":"2025-09-02 21:09:10.000000000","message":"We do validate rules have only these protocols https://review.opendev.org/c/openstack/networking-generic-switch/+/952314/6/networking_generic_switch/devices/netmiko_devices/cisco.py#200","commit_id":"da64a2c65dd00e7dd7c806eb3a1a98022916b4e5"}]}