)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"change_message_id":"6d1b6284e8866c73f3042852413ef76b07d2c1fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38b754fa_c112cb7a","updated":"2025-08-14 10:24:40.000000000","message":"Thanks for adding proper exception handling and also improving formatting!","commit_id":"6c1abe4b002530aa6cde832777d1760017c92090"}],"doc/source/_exts/netmiko_device_commands.py":[{"author":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"change_message_id":"6d1b6284e8866c73f3042852413ef76b07d2c1fc","unresolved":true,"context_lines":[{"line_number":170,"context_line":"            desc \u003d command_descriptions.get(command_name)"},{"line_number":171,"context_line":"            if not desc:"},{"line_number":172,"context_line":"                # Ignore this undocumented command"},{"line_number":173,"context_line":"                print(f\"Ignoring undocumented command {command_name}\")"},{"line_number":174,"context_line":"                continue"},{"line_number":175,"context_line":"            formatted_output.append(f\"{command_name}:\", \"\")"},{"line_number":176,"context_line":"            formatted_output.append(\"~\" * (len(command_name) + 1), \"\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"26542cb5_81ce4064","line":173,"updated":"2025-08-14 10:24:40.000000000","message":"Would it be better to throw an error here to remind the person adding new commands to document them in the `command_descriptions` dictionary? Otherwise, isn\u0027t there a chance for undocumented parts to build up over time.","commit_id":"6c1abe4b002530aa6cde832777d1760017c92090"},{"author":{"_account_id":37517,"name":"Mithun Krishnan Umesan","display_name":"mumesan","email":"mumesan@redhat.com","username":"mumesan"},"change_message_id":"39160f0c3160483ee2ea11df2614357b0f51602f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            desc \u003d command_descriptions.get(command_name)"},{"line_number":171,"context_line":"            if not desc:"},{"line_number":172,"context_line":"                # Ignore this undocumented command"},{"line_number":173,"context_line":"                print(f\"Ignoring undocumented command {command_name}\")"},{"line_number":174,"context_line":"                continue"},{"line_number":175,"context_line":"            formatted_output.append(f\"{command_name}:\", \"\")"},{"line_number":176,"context_line":"            formatted_output.append(\"~\" * (len(command_name) + 1), \"\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"ad9a7998_0ce81a1b","line":173,"in_reply_to":"2610be22_bb8b03a2","updated":"2025-08-14 14:12:41.000000000","message":"Done","commit_id":"6c1abe4b002530aa6cde832777d1760017c92090"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"abd310cc777727eb749ee75763f8a0c136e717e4","unresolved":true,"context_lines":[{"line_number":170,"context_line":"            desc \u003d command_descriptions.get(command_name)"},{"line_number":171,"context_line":"            if not desc:"},{"line_number":172,"context_line":"                # Ignore this undocumented command"},{"line_number":173,"context_line":"                print(f\"Ignoring undocumented command {command_name}\")"},{"line_number":174,"context_line":"                continue"},{"line_number":175,"context_line":"            formatted_output.append(f\"{command_name}:\", \"\")"},{"line_number":176,"context_line":"            formatted_output.append(\"~\" * (len(command_name) + 1), \"\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"2610be22_bb8b03a2","line":173,"in_reply_to":"26542cb5_81ce4064","updated":"2025-08-14 13:47:50.000000000","message":"Eh, likely better, but at the same time it this is doc generation and most contributors don\u0027t run doc builds/tests before proposing changes nor care about the results. So, I think not doing so makes the wall of burden each contributor to climb a bit less in exchange for the potential risk a maintainer might need to do some cleanup later.  I think its an okay trade-off, personally.","commit_id":"6c1abe4b002530aa6cde832777d1760017c92090"}],"tox.ini":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"abd310cc777727eb749ee75763f8a0c136e717e4","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    -r{toxinidir}/requirements.txt"},{"line_number":51,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":52,"context_line":"commands \u003d"},{"line_number":53,"context_line":"  sphinx-build -E -W -b html doc/source doc/build/html"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"[testenv:pdf-docs]"},{"line_number":56,"context_line":"allowlist_externals \u003d make"}],"source_content_type":"text/x-properties","patch_set":1,"id":"f2c3e577_f8c0b15f","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":17},"updated":"2025-08-14 13:47:50.000000000","message":"I had to look this one up, its \"build with a fresh environment\" ++","commit_id":"6c1abe4b002530aa6cde832777d1760017c92090"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"16c5695b911da966cd922a5c77398ed58ae19005","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    -r{toxinidir}/requirements.txt"},{"line_number":51,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":52,"context_line":"commands \u003d"},{"line_number":53,"context_line":"  sphinx-build -E -W -b html doc/source doc/build/html"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"[testenv:pdf-docs]"},{"line_number":56,"context_line":"allowlist_externals \u003d make"}],"source_content_type":"text/x-properties","patch_set":1,"id":"af8da0b4_fd8b8f16","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":17},"in_reply_to":"59c6785b_a262afbd","updated":"2025-08-14 22:58:23.000000000","message":"I\u0027ve proposed this for ironic https://review.opendev.org/c/openstack/ironic/+/957471","commit_id":"6c1abe4b002530aa6cde832777d1760017c92090"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a3a7681924812cef22cfba0195fec45e6ce10dfb","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    -r{toxinidir}/requirements.txt"},{"line_number":51,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":52,"context_line":"commands \u003d"},{"line_number":53,"context_line":"  sphinx-build -E -W -b html doc/source doc/build/html"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"[testenv:pdf-docs]"},{"line_number":56,"context_line":"allowlist_externals \u003d make"}],"source_content_type":"text/x-properties","patch_set":1,"id":"59c6785b_a262afbd","line":53,"range":{"start_line":53,"start_character":16,"end_line":53,"end_character":17},"in_reply_to":"f2c3e577_f8c0b15f","updated":"2025-08-14 17:55:35.000000000","message":"We should put this *everywhere* we call sphinx-build then, I suspect (not even just in this repo).","commit_id":"6c1abe4b002530aa6cde832777d1760017c92090"}]}