)]}'
{"networking_generic_switch/devices/netmiko_devices/cumulus.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8bdbe15ac76b656649f01f0c242a41ac63061b4e","unresolved":true,"context_lines":[{"line_number":446,"context_line":"        # Step 1: EVPN VNI configuration (distributed EVPN deployments)"},{"line_number":447,"context_line":"        if self.evpn_vni_config:"},{"line_number":448,"context_line":"            if not self.bgp_asn:"},{"line_number":449,"context_line":"                from networking_generic_switch import exceptions as exc"},{"line_number":450,"context_line":"                raise exc.GenericSwitchNetmikoConfigError("},{"line_number":451,"context_line":"                    switch\u003dself.device_name,"},{"line_number":452,"context_line":"                    error\u003d\u0027ngs_bgp_asn configuration parameter is \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"786933c6_6a5bc42d","line":449,"range":{"start_line":449,"start_character":21,"end_line":449,"end_character":46},"updated":"2026-04-17 11:34:21.000000000","message":"unrelated, but seems Claude added the import inline. May want to move it up top if another patch set is proposed.","commit_id":"5532eda4dc026e165acdf226135923474880cde8"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"8bdbe15ac76b656649f01f0c242a41ac63061b4e","unresolved":true,"context_lines":[{"line_number":474,"context_line":"            # Use multicast group for BUM traffic (per-VNI configuration)"},{"line_number":475,"context_line":"            mcast_group \u003d self._get_multicast_group(vni)"},{"line_number":476,"context_line":"            multicast_cmd \u003d ("},{"line_number":477,"context_line":"                f\u0027nv set bridge domain br_default vlan {segmentation_id} \u0027"},{"line_number":478,"context_line":"                f\u0027vni {vni} flooding multicast-group {mcast_group}\u0027)"},{"line_number":479,"context_line":"            cmds.append(multicast_cmd)"},{"line_number":480,"context_line":"        elif self.bum_replication_mode \u003d\u003d \u0027head-end-replication\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a41ff5b_53a1dbdd","line":477,"range":{"start_line":477,"start_character":18,"end_line":477,"end_character":72},"updated":"2026-04-17 11:34:21.000000000","message":"Looking at the doc[1] it has a warning on mixing NVUE commands and Linux commands.\nI think we need to swithc to `nv` only or use `vtysh` only?\n\n\n[1] https://docs.nvidia.com/networking-ethernet-software/cumulus-linux-516/Quick-Start-Guide/","commit_id":"5532eda4dc026e165acdf226135923474880cde8"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d23fd4bebf161d232065aee5990a23c34fb75607","unresolved":true,"context_lines":[{"line_number":475,"context_line":"            mcast_group \u003d self._get_multicast_group(vni)"},{"line_number":476,"context_line":"            multicast_cmd \u003d ("},{"line_number":477,"context_line":"                f\u0027nv set bridge domain br_default vlan {segmentation_id} \u0027"},{"line_number":478,"context_line":"                f\u0027vni {vni} flooding multicast-group {mcast_group}\u0027)"},{"line_number":479,"context_line":"            cmds.append(multicast_cmd)"},{"line_number":480,"context_line":"        elif self.bum_replication_mode \u003d\u003d \u0027head-end-replication\u0027:"},{"line_number":481,"context_line":"            # Use static HER flood list (global configuration)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0d6f9a9b_5e000859","line":478,"updated":"2026-04-02 02:09:21.000000000","message":"If these commands were moved to be class constants they could be auto-documented by the others. Base class could define something like:\nBUM_REPLICATION_INGRESS\nBUM_REPLICATION_HEAD_END\nBUM_REPLICATION_MULTICAST","commit_id":"5532eda4dc026e165acdf226135923474880cde8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8db17dbbde09fc8d22584aedc55c8a0e4ef8d536","unresolved":true,"context_lines":[{"line_number":475,"context_line":"            mcast_group \u003d self._get_multicast_group(vni)"},{"line_number":476,"context_line":"            multicast_cmd \u003d ("},{"line_number":477,"context_line":"                f\u0027nv set bridge domain br_default vlan {segmentation_id} \u0027"},{"line_number":478,"context_line":"                f\u0027vni {vni} flooding multicast-group {mcast_group}\u0027)"},{"line_number":479,"context_line":"            cmds.append(multicast_cmd)"},{"line_number":480,"context_line":"        elif self.bum_replication_mode \u003d\u003d \u0027head-end-replication\u0027:"},{"line_number":481,"context_line":"            # Use static HER flood list (global configuration)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bad6206e_82becd84","line":478,"in_reply_to":"09e35a2a_86f2e02d","updated":"2026-04-16 20:07:16.000000000","message":"Hmm, that is food for thought. I\u0027m wondering if there is is enough similarity modeling wise, given just how different some of these details can be...","commit_id":"5532eda4dc026e165acdf226135923474880cde8"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"55895bde23bbda6a9f2b0a426dc81adb946879e3","unresolved":true,"context_lines":[{"line_number":475,"context_line":"            mcast_group \u003d self._get_multicast_group(vni)"},{"line_number":476,"context_line":"            multicast_cmd \u003d ("},{"line_number":477,"context_line":"                f\u0027nv set bridge domain br_default vlan {segmentation_id} \u0027"},{"line_number":478,"context_line":"                f\u0027vni {vni} flooding multicast-group {mcast_group}\u0027)"},{"line_number":479,"context_line":"            cmds.append(multicast_cmd)"},{"line_number":480,"context_line":"        elif self.bum_replication_mode \u003d\u003d \u0027head-end-replication\u0027:"},{"line_number":481,"context_line":"            # Use static HER flood list (global configuration)"}],"source_content_type":"text/x-python","patch_set":3,"id":"09e35a2a_86f2e02d","line":478,"in_reply_to":"0d6f9a9b_5e000859","updated":"2026-04-14 23:45:08.000000000","message":"Any thoughts on this comment? It would apply to the rest of this series too","commit_id":"5532eda4dc026e165acdf226135923474880cde8"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f9c3acb65b4124d11b21e35033382e08a0070e0b","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            mcast_group \u003d self._get_multicast_group(vni)"},{"line_number":476,"context_line":"            multicast_cmd \u003d ("},{"line_number":477,"context_line":"                f\u0027nv set bridge domain br_default vlan {segmentation_id} \u0027"},{"line_number":478,"context_line":"                f\u0027vni {vni} flooding multicast-group {mcast_group}\u0027)"},{"line_number":479,"context_line":"            cmds.append(multicast_cmd)"},{"line_number":480,"context_line":"        elif self.bum_replication_mode \u003d\u003d \u0027head-end-replication\u0027:"},{"line_number":481,"context_line":"            # Use static HER flood list (global configuration)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2edafad_c2b45a74","line":478,"in_reply_to":"bad6206e_82becd84","updated":"2026-05-07 00:47:11.000000000","message":"Done","commit_id":"5532eda4dc026e165acdf226135923474880cde8"}]}