)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"82761cd186fa6b85fe8afa290d1568bbb72d4474","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ecb317ba_4978b446","updated":"2026-06-09 18:05:53.000000000","message":"This is an incomplete review, but honestly if you just say \"yep I\u0027ve tested this\" it\u0027ll go a long way. Please ensure you respond to comments.\n\nThis was a part of the GR-OSS Group Review.","commit_id":"633d982c4a05973b610921564e58976114ca5870"}],"networking_generic_switch/batching.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"82761cd186fa6b85fe8afa290d1568bbb72d4474","unresolved":true,"context_lines":[{"line_number":122,"context_line":"            try:"},{"line_number":123,"context_line":"                self.coordinator.heartbeat()"},{"line_number":124,"context_line":"            except Exception:"},{"line_number":125,"context_line":"                LOG.warning(\"Coordinator heartbeat failed for %s\","},{"line_number":126,"context_line":"                            self.switch_name, exc_info\u003dTrue)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _stop(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"317196aa_3eb29c43","line":125,"updated":"2026-06-09 18:05:53.000000000","message":"Is this an ERROR level event? Would this indicate that your NGS isn\u0027t operating?","commit_id":"633d982c4a05973b610921564e58976114ca5870"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"82761cd186fa6b85fe8afa290d1568bbb72d4474","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                    self._local_events.pop(item.uuid, None)"},{"line_number":192,"context_line":"                # record_result stores the result before setting the event,"},{"line_number":193,"context_line":"                # so result is guaranteed non-None here."},{"line_number":194,"context_line":"                assert result is not None, ("},{"line_number":195,"context_line":"                    \"event set but no result stored for %s\" % item.uuid)"},{"line_number":196,"context_line":"                if \"result\" in result:"},{"line_number":197,"context_line":"                    return result[\"result\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"b45a5601_2ac5f420","line":194,"updated":"2026-06-09 18:05:53.000000000","message":"Asserts will not fire when PYTHONOPTIMIZE\u003d1 or when python is run with -O. That means I generally try to avoid using them in production code. Please change this code to instead use a standard if statement or other conditional.","commit_id":"633d982c4a05973b610921564e58976114ca5870"}]}