)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ed14e298e0e9a8d0dedb1af0a5192f18ad9c0c70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6cf779e9_730a50a5","updated":"2026-07-09 02:02:20.000000000","message":"recheck node failure","commit_id":"76f37b2b0b16aebf381fecaefa6e34360720d45d"}],"networking_generic_switch/devices/netconf_devices/netconf_switch.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"54ea7c47511800e9efc4346852b2a038c7dca244","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                CONF.ngs_coordination.backend_url,"},{"line_number":102,"context_line":"                (\u0027ngs-\u0027 + device_utils.get_hostname()).encode(\u0027ascii\u0027))"},{"line_number":103,"context_line":"            self.locker.start()"},{"line_number":104,"context_line":"            atexit.register(self.locker.stop)"},{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            LOG.warning("},{"line_number":107,"context_line":"                \"Switch %s: [ngs_coordination] backend_url is not \""}],"source_content_type":"text/x-python","patch_set":11,"id":"7ee727fc_d5a317ba","line":104,"updated":"2026-07-08 13:42:11.000000000","message":"nit: atexit is hard to debug, I\u0027d rather have an explicit shutdown path (if possible, of course)","commit_id":"76f37b2b0b16aebf381fecaefa6e34360720d45d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"54ea7c47511800e9efc4346852b2a038c7dca244","unresolved":false,"context_lines":[{"line_number":261,"context_line":"                    if (self._confirmed_commit"},{"line_number":262,"context_line":"                            and (\u0027:confirmed-commit\u0027 in self.capabilities"},{"line_number":263,"context_line":"                                 or \u0027:confirmed-commit:1.1\u0027"},{"line_number":264,"context_line":"                                 in self.capabilities)):"},{"line_number":265,"context_line":"                        client.commit(confirmed\u003dTrue,"},{"line_number":266,"context_line":"                                      timeout\u003dstr("},{"line_number":267,"context_line":"                                          self._confirmed_commit_timeout))"}],"source_content_type":"text/x-python","patch_set":11,"id":"fedd893d_963d3466","line":264,"updated":"2026-07-08 13:42:11.000000000","message":"nit: could be something like self.has_confirmed_commit","commit_id":"76f37b2b0b16aebf381fecaefa6e34360720d45d"}],"networking_generic_switch/devices/netconf_devices/openconfig.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"54ea7c47511800e9efc4346852b2a038c7dca244","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        elif port_id_re_sub_raw:"},{"line_number":54,"context_line":"            self._port_id_re_sub \u003d json.loads(port_id_re_sub_raw)"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            self._port_id_re_sub \u003d {}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        disabled_raw \u003d self.ngs_config.get("},{"line_number":59,"context_line":"            \u0027ngs_openconfig_disabled_properties\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"503b2d15_2dc7cdb5","line":56,"updated":"2026-07-08 13:42:11.000000000","message":"nit: validate the format of port_id_re_sub. Maybe even compile the pattern here and reuse later?","commit_id":"76f37b2b0b16aebf381fecaefa6e34360720d45d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"54ea7c47511800e9efc4346852b2a038c7dca244","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        segmentation_id \u003d int(segmentation_id)"},{"line_number":100,"context_line":"        net_instances \u003d NetworkInstances()"},{"line_number":101,"context_line":"        net_inst \u003d net_instances.add(self._network_instance)"},{"line_number":102,"context_line":"        _vlan \u003d net_inst.vlans.add(segmentation_id)"},{"line_number":103,"context_line":"        _vlan.config.name \u003d network_name"},{"line_number":104,"context_line":"        _vlan.config.status \u003d oc_constants.VLAN_ACTIVE"},{"line_number":105,"context_line":"        return [net_instances]"}],"source_content_type":"text/x-python","patch_set":11,"id":"6b56c22a_a1152f45","line":102,"updated":"2026-07-08 13:42:11.000000000","message":"nit: it\u0027s a bit unusual to have a local variable start with _","commit_id":"76f37b2b0b16aebf381fecaefa6e34360720d45d"}]}