)]}'
{"networking_hyperv/tests/unit/neutron/agent/test_base.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"94966eb65d550b05d45d865c83a71cf93feb43d9","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self._agent._agent_id \u003d mock.sentinel.agent_id"},{"line_number":47,"context_line":"        self._agent._context \u003d mock.sentinel.admin_context"},{"line_number":48,"context_line":"        self._agent._state_rpc \u003d mock.MagicMock("},{"line_number":49,"context_line":"            autospec\u003dagent_rpc.PluginReportStateAPI)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_set_agent_state(self):"},{"line_number":52,"context_line":"        self._agent._agent_state \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_cb79c82f","line":49,"range":{"start_line":48,"start_character":33,"end_line":49,"end_character":51},"updated":"2018-01-22 16:13:32.000000000","message":"Should we use \"_autospec_classes\"?","commit_id":"daa55970dd81165837bb9835822a30c91a1b016a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"4311cdd659ba614400cb0daecb5267de50ebb6f9","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self._agent._agent_id \u003d mock.sentinel.agent_id"},{"line_number":47,"context_line":"        self._agent._context \u003d mock.sentinel.admin_context"},{"line_number":48,"context_line":"        self._agent._state_rpc \u003d mock.MagicMock("},{"line_number":49,"context_line":"            autospec\u003dagent_rpc.PluginReportStateAPI)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_set_agent_state(self):"},{"line_number":52,"context_line":"        self._agent._agent_state \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_bc9364a3","line":49,"range":{"start_line":48,"start_character":33,"end_line":49,"end_character":51},"in_reply_to":"7f96bb07_cb79c82f","updated":"2018-01-22 17:09:34.000000000","message":"The base agent does not initialize _state_rpc, yet we have a method which relies on it.","commit_id":"daa55970dd81165837bb9835822a30c91a1b016a"}],"networking_hyperv/tests/unit/neutron/agent/test_hyperv_neutron_agent.py":[{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"94966eb65d550b05d45d865c83a71cf93feb43d9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.agent._metricsutils \u003d mock.MagicMock("},{"line_number":75,"context_line":"            autospec\u003dself.agent._metricsutils)"},{"line_number":76,"context_line":"        self.agent._nvgre_ops \u003d mock.MagicMock("},{"line_number":77,"context_line":"            autospec\u003dhyperv_agent.nvgre_ops.HyperVNvgreOps)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.agent._sec_groups_agent \u003d mock.MagicMock("},{"line_number":80,"context_line":"            autospec\u003dhyperv_agent.HyperVSecurityAgent)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_26e8a114","line":77,"range":{"start_line":77,"start_character":21,"end_line":77,"end_character":58},"updated":"2018-01-22 16:13:32.000000000","message":"_autospec_classes? we already have the right classes here, as opposed to os-win, were we cannot access them directly from networking-hyperv.","commit_id":"daa55970dd81165837bb9835822a30c91a1b016a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"4311cdd659ba614400cb0daecb5267de50ebb6f9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.agent._metricsutils \u003d mock.MagicMock("},{"line_number":75,"context_line":"            autospec\u003dself.agent._metricsutils)"},{"line_number":76,"context_line":"        self.agent._nvgre_ops \u003d mock.MagicMock("},{"line_number":77,"context_line":"            autospec\u003dhyperv_agent.nvgre_ops.HyperVNvgreOps)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.agent._sec_groups_agent \u003d mock.MagicMock("},{"line_number":80,"context_line":"            autospec\u003dhyperv_agent.HyperVSecurityAgent)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_3c3bd49c","line":77,"range":{"start_line":77,"start_character":21,"end_line":77,"end_character":58},"in_reply_to":"7f96bb07_26e8a114","updated":"2018-01-22 17:09:34.000000000","message":"_nvgre_ops is initialized during _init_nvgre method, which isn\u0027t called during __init__.\n\nWe might have to do some cleaning in the agents\u0027 constructor. Not really a fan of how they look, tbh.","commit_id":"daa55970dd81165837bb9835822a30c91a1b016a"}]}