)]}'
{"networking_l2gw/cmd/eventlet/__init__.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d0a8a41adcb1e329d3bbe11c465d309b9ec086bb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# global variable. See https://bugs.launchpad.net/bugs/1863021 and"},{"line_number":20,"context_line":"# https://github.com/eventlet/eventlet/issues/592"},{"line_number":21,"context_line":"import __original_module_threading as orig_threading"},{"line_number":22,"context_line":"import threading  # noqa"},{"line_number":23,"context_line":"orig_threading.current_thread.__globals__[\u0027_active\u0027] \u003d threading._active"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_6b55881d","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":24},"updated":"2020-05-05 07:19:50.000000000","message":"hmm, why we need that \"noqa\" statement here? And also in other similar patches I saw \"noqa\" also in the line above. In this one it\u0027s not added. Why it\u0027s like that?","commit_id":"105df7c9da8b92d7a265cc161517aebf4a9365b9"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"fef65fd2be39a2500543b204f7302891cdb483d1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# global variable. See https://bugs.launchpad.net/bugs/1863021 and"},{"line_number":20,"context_line":"# https://github.com/eventlet/eventlet/issues/592"},{"line_number":21,"context_line":"import __original_module_threading as orig_threading"},{"line_number":22,"context_line":"import threading  # noqa"},{"line_number":23,"context_line":"orig_threading.current_thread.__globals__[\u0027_active\u0027] \u003d threading._active"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_0d405407","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":24},"in_reply_to":"1f493fa4_6b55881d","updated":"2020-05-05 13:23:40.000000000","message":"I can try without it and see what pep8 thinks. I don\u0027t want to change the order of this code because I\u0027m not sure if there would be any side-effects if we stray from the issue 592 recommendation.","commit_id":"105df7c9da8b92d7a265cc161517aebf4a9365b9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0fa9b8405ad55cc4710cd261769cae7fc1077dc4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# global variable. See https://bugs.launchpad.net/bugs/1863021 and"},{"line_number":20,"context_line":"# https://github.com/eventlet/eventlet/issues/592"},{"line_number":21,"context_line":"import __original_module_threading as orig_threading"},{"line_number":22,"context_line":"import threading"},{"line_number":23,"context_line":"orig_threading.current_thread.__globals__[\u0027_active\u0027] \u003d threading._active"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_31dc8a17","line":22,"updated":"2020-05-05 14:03:21.000000000","message":"pep8: I100 Import statements are in the wrong order. import threading should be before import __original_module_threading","commit_id":"8c2aa84a853d6b6f5a7cdaba631df3a0ee4471d7"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0fa9b8405ad55cc4710cd261769cae7fc1077dc4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# global variable. See https://bugs.launchpad.net/bugs/1863021 and"},{"line_number":20,"context_line":"# https://github.com/eventlet/eventlet/issues/592"},{"line_number":21,"context_line":"import __original_module_threading as orig_threading"},{"line_number":22,"context_line":"import threading"},{"line_number":23,"context_line":"orig_threading.current_thread.__globals__[\u0027_active\u0027] \u003d threading._active"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_11e18ed1","line":22,"updated":"2020-05-05 14:03:21.000000000","message":"pep8: I201 Missing newline before sections or imports.","commit_id":"8c2aa84a853d6b6f5a7cdaba631df3a0ee4471d7"}]}
