)]}'
{"midonet/neutron/db/gateway_device.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5181b6c557541a85053cb577dbd5b2f12ef53c85","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                                    limit\u003dlimit, marker_obj\u003dmarker_obj,"},{"line_number":482,"context_line":"                                    page_reverse\u003dpage_reverse)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def get_gateway_device_remote_mac_entry(self, context, id,"},{"line_number":485,"context_line":"                                            gateway_device_id, fields\u003dNone):"},{"line_number":486,"context_line":"        rme \u003d self._get_remote_mac_entry(context, id)"},{"line_number":487,"context_line":"        return self._make_remote_mac_dict(rme, fields)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_21340849","line":484,"range":{"start_line":484,"start_character":8,"end_line":484,"end_character":43},"updated":"2017-01-24 23:58:48.000000000","message":"doesn\u0027t this have the same issue?\ni guess _get_remote_mac_entry should have the filter.","commit_id":"edccbd7a89657e08edbe963e86c31d9ac0365913"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bb96e57b3bd2456fd77d92d64695e634879bf3f0","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    def _get_remote_mac_entry(self, context, id):"},{"line_number":214,"context_line":"        try:"},{"line_number":215,"context_line":"            query \u003d self._model_query(context, GatewayRemoteMacTable)"},{"line_number":216,"context_line":"            rmt_db \u003d query.filter(GatewayRemoteMacTable.id \u003d\u003d id).one()"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        except exc.NoResultFound:"},{"line_number":219,"context_line":"            raise gw_device_ext.RemoteMacEntryNotFound(id\u003did)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_b672ec7a","line":216,"range":{"start_line":216,"start_character":0,"end_line":216,"end_character":71},"updated":"2017-01-26 01:28:26.000000000","message":"i prefer to add a check around here instead.","commit_id":"82c40552166aed7284e39480bc7db1fda1866400"}],"midonet/neutron/extensions/gateway_device.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"bb96e57b3bd2456fd77d92d64695e634879bf3f0","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class RemoteMacEntryWrongGatewayDevice(nexception.InvalidInput):"},{"line_number":41,"context_line":"    message \u003d _(\"Remote MAC entry %(id)s does not belong to gateway \""},{"line_number":42,"context_line":"                \"device %(gateway_device_id)s\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ResourceNotFound(nexception.NotFound):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_760fa4e1","line":42,"updated":"2017-01-26 01:28:26.000000000","message":"i\u0027m not sure if we need another exception for this particular case.","commit_id":"82c40552166aed7284e39480bc7db1fda1866400"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a275e885092c30070c1c3825dd0f61c45c5dc3f4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class RemoteMacEntryWrongGatewayDevice(nexception.InvalidInput):"},{"line_number":41,"context_line":"    message \u003d _(\"Remote MAC entry %(id)s does not belong to gateway \""},{"line_number":42,"context_line":"                \"device %(gateway_device_id)s\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ResourceNotFound(nexception.NotFound):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_7b1b6881","line":42,"in_reply_to":"3a461143_02b0d042","updated":"2017-01-31 09:04:07.000000000","message":"i prefer just to use RemoteMacEntryNotFound.\nIMO it\u0027s ok as the entry for the given combination of ids does not exist.","commit_id":"82c40552166aed7284e39480bc7db1fda1866400"},{"author":{"_account_id":8858,"name":"Brandon Berg","email":"bberg@midokura.jp","username":"bberg"},"change_message_id":"0561f082c827c45ac2be7e7ade2c817fa60b13be","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class RemoteMacEntryWrongGatewayDevice(nexception.InvalidInput):"},{"line_number":41,"context_line":"    message \u003d _(\"Remote MAC entry %(id)s does not belong to gateway \""},{"line_number":42,"context_line":"                \"device %(gateway_device_id)s\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ResourceNotFound(nexception.NotFound):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_02b0d042","line":42,"in_reply_to":"3a461143_760fa4e1","updated":"2017-01-26 10:18:02.000000000","message":"What is your preferred alternative? I think it\u0027s more informative if we distinguish between the case where no remote MAC entry with the specified ID exists, and the case where one does exist but does not belong to the specified gateway device.\n\nMaybe we could combine the two messages into something like \"Remote MAC entry %(id)s does not exist or does not belong to gateway device %(gateway_device_id)s.\" We definitely shouldn\u0027t use the RemateMacEntryNotFound in cases where it really does exist.","commit_id":"82c40552166aed7284e39480bc7db1fda1866400"}]}