)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8e3e2e1aeead0b264e844d6fc973e4754d953ebc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use portbindings from neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"trivial change"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I17647e8a671fe7e5c6786647184dcd412938a003"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_af1c4112","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":14},"updated":"2017-04-03 18:11:51.000000000","message":"TrivialFix","commit_id":"35174130035c10f7a6d7b6c36921f2cb718e4891"}],"midonet/neutron/plugin_v2.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4b57364c006fb3368252f2cd940c58176ced20b1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def get_network(self, context, id, fields\u003dNone):"},{"line_number":136,"context_line":"        LOG.debug(\"MidonetPluginV2.get_network called: id\u003d%(id)r\", {\u0027id\u0027: id})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":139,"context_line":"            net \u003d super(MidonetPluginV2, self).get_network(context, id, None)"},{"line_number":140,"context_line":"            self._extend_provider_network_dict(context, net)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_84c88855","line":138,"updated":"2017-04-13 19:05:42.000000000","message":"should be reader, no?","commit_id":"8e0b8e7b4c6ec5c6cb3838978939f730400d523b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c9017f6bc7155642e6e561797e0bbafa75630b5c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def get_network(self, context, id, fields\u003dNone):"},{"line_number":136,"context_line":"        LOG.debug(\"MidonetPluginV2.get_network called: id\u003d%(id)r\", {\u0027id\u0027: id})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":139,"context_line":"            net \u003d super(MidonetPluginV2, self).get_network(context, id, None)"},{"line_number":140,"context_line":"            self._extend_provider_network_dict(context, net)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_1494c18a","line":138,"in_reply_to":"9ff52f3f_84c88855","updated":"2017-04-14 08:27:55.000000000","message":"yes","commit_id":"8e0b8e7b4c6ec5c6cb3838978939f730400d523b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4b57364c006fb3368252f2cd940c58176ced20b1","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        LOG.debug(\"MidonetPluginV2.get_networks called: filters\u003d%(filters)r\","},{"line_number":147,"context_line":"                  {\u0027filters\u0027: filters})"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":150,"context_line":"            nets \u003d super(MidonetPluginV2,"},{"line_number":151,"context_line":"                         self).get_networks(context, filters, None, sorts,"},{"line_number":152,"context_line":"                                            limit, marker, page_reverse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_a4cb8c51","line":149,"updated":"2017-04-13 19:05:42.000000000","message":"why is it writer?","commit_id":"8e0b8e7b4c6ec5c6cb3838978939f730400d523b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"fd69449ca729cc37146e98872179d414201f9ee0","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        LOG.debug(\"MidonetPluginV2.get_networks called: filters\u003d%(filters)r\","},{"line_number":147,"context_line":"                  {\u0027filters\u0027: filters})"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        with db_api.context_manager.writer.using(context):"},{"line_number":150,"context_line":"            nets \u003d super(MidonetPluginV2,"},{"line_number":151,"context_line":"                         self).get_networks(context, filters, None, sorts,"},{"line_number":152,"context_line":"                                            limit, marker, page_reverse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_7e9ad1c5","line":149,"in_reply_to":"9ff52f3f_a4cb8c51","updated":"2017-04-13 19:54:13.000000000","message":"This can be fixed later. A writer can also read so it\u0027s just a theoretical inefficiency sometime in the future.","commit_id":"8e0b8e7b4c6ec5c6cb3838978939f730400d523b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4b57364c006fb3368252f2cd940c58176ced20b1","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        port_data \u003d port[\u0027port\u0027]"},{"line_number":274,"context_line":"        tenant_id \u003d port_data[\u0027tenant_id\u0027]"},{"line_number":275,"context_line":"        self._ensure_default_security_group(context, tenant_id)"},{"line_number":276,"context_line":"        # REVISIT(yamamoto): this nested transaction is a workaround"},{"line_number":277,"context_line":"        # for bug #1490917."},{"line_number":278,"context_line":"        with db_api.autonested_transaction(context.session):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_44f04091","line":275,"updated":"2017-04-13 19:05:42.000000000","message":"That seems fragile (you rely on internal function). Why don\u0027t we just trigger BEFORE_CREATE in the plugin, and allow securitygroups_db to handle the logic for you?","commit_id":"8e0b8e7b4c6ec5c6cb3838978939f730400d523b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c9017f6bc7155642e6e561797e0bbafa75630b5c","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        port_data \u003d port[\u0027port\u0027]"},{"line_number":274,"context_line":"        tenant_id \u003d port_data[\u0027tenant_id\u0027]"},{"line_number":275,"context_line":"        self._ensure_default_security_group(context, tenant_id)"},{"line_number":276,"context_line":"        # REVISIT(yamamoto): this nested transaction is a workaround"},{"line_number":277,"context_line":"        # for bug #1490917."},{"line_number":278,"context_line":"        with db_api.autonested_transaction(context.session):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_54824951","line":275,"in_reply_to":"9ff52f3f_44f04091","updated":"2017-04-14 08:27:55.000000000","message":"despite of _ prefix, _ensure_default_security_group has been used by plugins as an api widely.\nwhile i agree it\u0027s better to make use of callbacks, i wanted to make it minimum in this patch.","commit_id":"8e0b8e7b4c6ec5c6cb3838978939f730400d523b"}]}
