)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4434279f473f818e5bc7abb7a8112513b8856789","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Migration of Firewall Exceptions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron Firewall-as-a-Service exceptions have been"},{"line_number":10,"context_line":"migrated to a separate file. This patch takes care"},{"line_number":11,"context_line":"of the above rehoming in midonet."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: Ie54ac5303020ea1db49ee5c2c6aaab4dd8e4c790"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1f1a1f67_6cbb11e5","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":27},"updated":"2017-07-21 07:30:08.000000000","message":"neutron-lib","commit_id":"07ac2f4ff4ed955397264f35d04631f5b4bfe143"}],"midonet/neutron/db/logging_resource_db.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"769e51e1aef43554355636cafb436509b40703d7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    firewall_id\u003df_log[\u0027firewall_id\u0027])"},{"line_number":104,"context_line":"                context.session.add(f_log_db)"},{"line_number":105,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":106,"context_line":"            raise fw_exc.FirewallNotFound(firewall_id\u003df_log[\u0027firewall_id\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        return self._make_firewall_log_dict(f_log_db)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_09aeee2d","line":106,"range":{"start_line":106,"start_character":25,"end_line":106,"end_character":41},"updated":"2017-06-08 05:02:46.000000000","message":"will this be in neutron-lib eventually?\nif so, it\u0027s better to have a compat definition in neutron-fwaas until the migration is complete.","commit_id":"52fd25c136205cee6514d0ff038e276498b2ad17"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"80973e711c4166aaacd3066ef2641b3df87462c1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    firewall_id\u003df_log[\u0027firewall_id\u0027])"},{"line_number":104,"context_line":"                context.session.add(f_log_db)"},{"line_number":105,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":106,"context_line":"            raise fw_exc.FirewallNotFound(firewall_id\u003df_log[\u0027firewall_id\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        return self._make_firewall_log_dict(f_log_db)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f0e0f27_8605547d","line":106,"range":{"start_line":106,"start_character":25,"end_line":106,"end_character":41},"in_reply_to":"bf091321_04c81353","updated":"2017-06-09 10:09:22.000000000","message":"why not?\nthese exceptions are a part of the definition of the extension, aren\u0027t they?\nthere are precedents.\neg. https://github.com/openstack/neutron-lib/blob/master/neutron_lib/exceptions/l3.py","commit_id":"52fd25c136205cee6514d0ff038e276498b2ad17"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6e633cbfb76a09fdd6193815dc55f5b4fd5f0113","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    firewall_id\u003df_log[\u0027firewall_id\u0027])"},{"line_number":104,"context_line":"                context.session.add(f_log_db)"},{"line_number":105,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":106,"context_line":"            raise fw_exc.FirewallNotFound(firewall_id\u003df_log[\u0027firewall_id\u0027])"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        return self._make_firewall_log_dict(f_log_db)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_04c81353","line":106,"range":{"start_line":106,"start_character":25,"end_line":106,"end_character":41},"in_reply_to":"bf091321_09aeee2d","updated":"2017-06-08 06:08:19.000000000","message":"No, the exception is in neutron-fwaas itself... I will correct the git message","commit_id":"52fd25c136205cee6514d0ff038e276498b2ad17"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"88489cf5d81b10a0dbdc722098218b0f8ca543d2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from midonet.neutron.db import logging_resource_model as model"},{"line_number":17,"context_line":"from midonet.neutron.extensions import logging_resource as log_res_ext"},{"line_number":18,"context_line":"from neutron.db import common_db_mixin"},{"line_number":19,"context_line":"from neutron_fwaas.common import exceptions as fw_exc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_db import exception as db_exc"},{"line_number":22,"context_line":"from oslo_log import helpers as log_helpers"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_51f9217e","line":19,"range":{"start_line":19,"start_character":47,"end_line":19,"end_character":53},"updated":"2017-06-21 10:08:28.000000000","message":"it\u0027s better to have an alias in fwaas repo.\nafter all, exceptions are a part of api.","commit_id":"7a7f4f78470d10860741debf9eca20c223d801b2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e1d31f128130b86814df3c6e5e801a462f149e65","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from midonet.neutron.db import logging_resource_model as model"},{"line_number":17,"context_line":"from midonet.neutron.extensions import logging_resource as log_res_ext"},{"line_number":18,"context_line":"from neutron.db import common_db_mixin"},{"line_number":19,"context_line":"from neutron_fwaas.common import exceptions as fw_exc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_db import exception as db_exc"},{"line_number":22,"context_line":"from oslo_log import helpers as log_helpers"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_b3ae212c","line":19,"range":{"start_line":19,"start_character":47,"end_line":19,"end_character":53},"in_reply_to":"5f201791_51f9217e","updated":"2017-06-22 02:39:17.000000000","message":"Isnt this an alias? I am a bit confused by the term alias , for exceptions","commit_id":"7a7f4f78470d10860741debf9eca20c223d801b2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"762b7ecc1a26eb59cbccdcdbb19cc4b78a3a50a2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from midonet.neutron.db import logging_resource_model as model"},{"line_number":17,"context_line":"from midonet.neutron.extensions import logging_resource as log_res_ext"},{"line_number":18,"context_line":"from neutron.db import common_db_mixin"},{"line_number":19,"context_line":"from neutron_fwaas.common import exceptions as fw_exc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_db import exception as db_exc"},{"line_number":22,"context_line":"from oslo_log import helpers as log_helpers"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_89ac128d","line":19,"range":{"start_line":19,"start_character":47,"end_line":19,"end_character":53},"in_reply_to":"5f201791_b3ae212c","updated":"2017-06-22 04:14:26.000000000","message":"I meant to keep neutron_fwaas.extensions.firewall.FirewallNotFound available.","commit_id":"7a7f4f78470d10860741debf9eca20c223d801b2"}],"midonet/neutron/services/logging_resource/plugin.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"88489cf5d81b10a0dbdc722098218b0f8ca543d2","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def _make_info_for_midonet(self, context, f_log, logging_resource_id):"},{"line_number":170,"context_line":"        f_log_info \u003d f_log.copy()"},{"line_number":171,"context_line":"        # Get firewall and logging resource object for backend."},{"line_number":172,"context_line":"        fw_plugin \u003d directory.get_plugin(\u0027fwaas\u0027)"},{"line_number":173,"context_line":"        f_log_info[\u0027firewall\u0027] \u003d fw_plugin.get_firewall("},{"line_number":174,"context_line":"            context, f_log_info[\u0027firewall_id\u0027], fields\u003d[\u0027id\u0027, \u0027tenant_id\u0027])"},{"line_number":175,"context_line":"        f_log_info[\u0027logging_resource\u0027] \u003d self.get_logging_resource("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_91e699e8","line":172,"range":{"start_line":172,"start_character":42,"end_line":172,"end_character":47},"updated":"2017-06-21 10:08:28.000000000","message":"this seems wrong.","commit_id":"7a7f4f78470d10860741debf9eca20c223d801b2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"42123fa88325373b905c1941414fb6dc5c480e7d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def _make_info_for_midonet(self, context, f_log, logging_resource_id):"},{"line_number":170,"context_line":"        f_log_info \u003d f_log.copy()"},{"line_number":171,"context_line":"        # Get firewall and logging resource object for backend."},{"line_number":172,"context_line":"        fw_plugin \u003d directory.get_plugin(\u0027fwaas\u0027)"},{"line_number":173,"context_line":"        f_log_info[\u0027firewall\u0027] \u003d fw_plugin.get_firewall("},{"line_number":174,"context_line":"            context, f_log_info[\u0027firewall_id\u0027], fields\u003d[\u0027id\u0027, \u0027tenant_id\u0027])"},{"line_number":175,"context_line":"        f_log_info[\u0027logging_resource\u0027] \u003d self.get_logging_resource("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_14600401","line":172,"range":{"start_line":172,"start_character":42,"end_line":172,"end_character":47},"in_reply_to":"5f201791_09e7e2e6","updated":"2017-06-22 18:13:52.000000000","message":"I checked and agree with you. This needs to be FIREWALL as per [1].\n\nBut then my question is how will the get_plugin retrieve the extension? Isnt it using the EXT to SERVICE mapping to retrieve the service plugin?\n\n[1]: https://github.com/openstack/neutron/blob/stable/ocata/neutron/plugins/common/constants.py#L23","commit_id":"7a7f4f78470d10860741debf9eca20c223d801b2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c25bc7878b83a0000344c2515c140e270aa80e70","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def _make_info_for_midonet(self, context, f_log, logging_resource_id):"},{"line_number":170,"context_line":"        f_log_info \u003d f_log.copy()"},{"line_number":171,"context_line":"        # Get firewall and logging resource object for backend."},{"line_number":172,"context_line":"        fw_plugin \u003d directory.get_plugin(\u0027fwaas\u0027)"},{"line_number":173,"context_line":"        f_log_info[\u0027firewall\u0027] \u003d fw_plugin.get_firewall("},{"line_number":174,"context_line":"            context, f_log_info[\u0027firewall_id\u0027], fields\u003d[\u0027id\u0027, \u0027tenant_id\u0027])"},{"line_number":175,"context_line":"        f_log_info[\u0027logging_resource\u0027] \u003d self.get_logging_resource("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_41f46e5b","line":172,"range":{"start_line":172,"start_character":42,"end_line":172,"end_character":47},"in_reply_to":"5f201791_14600401","updated":"2017-06-23 03:56:53.000000000","message":"get_plugin takes a service name. in this case, \"FIREWALL\".","commit_id":"7a7f4f78470d10860741debf9eca20c223d801b2"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"762b7ecc1a26eb59cbccdcdbb19cc4b78a3a50a2","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def _make_info_for_midonet(self, context, f_log, logging_resource_id):"},{"line_number":170,"context_line":"        f_log_info \u003d f_log.copy()"},{"line_number":171,"context_line":"        # Get firewall and logging resource object for backend."},{"line_number":172,"context_line":"        fw_plugin \u003d directory.get_plugin(\u0027fwaas\u0027)"},{"line_number":173,"context_line":"        f_log_info[\u0027firewall\u0027] \u003d fw_plugin.get_firewall("},{"line_number":174,"context_line":"            context, f_log_info[\u0027firewall_id\u0027], fields\u003d[\u0027id\u0027, \u0027tenant_id\u0027])"},{"line_number":175,"context_line":"        f_log_info[\u0027logging_resource\u0027] \u003d self.get_logging_resource("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_09e7e2e6","line":172,"range":{"start_line":172,"start_character":42,"end_line":172,"end_character":47},"in_reply_to":"5f201791_738f69cc","updated":"2017-06-22 04:14:26.000000000","message":"it has always been \"FIREWALL\" as far as i know.\n(well, until the recent change for which i\u0027m proposing a revert)","commit_id":"7a7f4f78470d10860741debf9eca20c223d801b2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d49d488d71dbe8fd8d12f927869d7315420894c0","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    def _make_info_for_midonet(self, context, f_log, logging_resource_id):"},{"line_number":170,"context_line":"        f_log_info \u003d f_log.copy()"},{"line_number":171,"context_line":"        # Get firewall and logging resource object for backend."},{"line_number":172,"context_line":"        fw_plugin \u003d directory.get_plugin(\u0027fwaas\u0027)"},{"line_number":173,"context_line":"        f_log_info[\u0027firewall\u0027] \u003d fw_plugin.get_firewall("},{"line_number":174,"context_line":"            context, f_log_info[\u0027firewall_id\u0027], fields\u003d[\u0027id\u0027, \u0027tenant_id\u0027])"},{"line_number":175,"context_line":"        f_log_info[\u0027logging_resource\u0027] \u003d self.get_logging_resource("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_738f69cc","line":172,"range":{"start_line":172,"start_character":42,"end_line":172,"end_character":47},"in_reply_to":"5f201791_91e699e8","updated":"2017-06-22 02:38:21.000000000","message":"@Yamamoto San:\nThe const.FIREWALL always referred to neutron-lib/constants.\nHowever, when boden committed [1] , the constant\u0027s value changed from \u0027fwaas\u0027 to FIREWALL.\nMidonet always referred to the constant value. And \u0027fwaas\u0027 is how the Extension to Service is mapped so the plugin \u0027FIREWALL\u0027 can be retrieved by \u0027fwaas\u0027.\nLet me know if anything is incorrect?\n\n[1]: https://github.com/openstack/neutron-lib/commit/1331fb208330d1ca385996a716f0bc0c7ad1a07f","commit_id":"7a7f4f78470d10860741debf9eca20c223d801b2"}]}
