)]}'
{"midonet/neutron/tests/tempest/tests/scenario/test_bgp.py":[{"author":{"_account_id":156,"name":"Ryu Ishimoto","email":"ryu@midokura.com","username":"ryu-midokura"},"change_message_id":"6764b5f28e4e00520d0ab1063c65410a42305937","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cls.router \u003d cls.create_router("},{"line_number":114,"context_line":"            data_utils.rand_name(\u0027left-router\u0027),"},{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":117,"context_line":"        cls.network \u003d cls.create_network(network_name\u003d\u0027left-network\u0027)"},{"line_number":118,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network,"},{"line_number":119,"context_line":"                                       name\u003d\u0027left-subnet\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_aa2b6980","line":116,"updated":"2017-06-20 07:24:33.000000000","message":"Should you add project_id\u003d here too?","commit_id":"6693c3306a2fa95e22a116678e24a317de3b4b89"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2f15cee239c7212600b5b87092d7868284df983b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        cls.router \u003d cls.create_router("},{"line_number":114,"context_line":"            data_utils.rand_name(\u0027left-router\u0027),"},{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":117,"context_line":"        cls.network \u003d cls.create_network(network_name\u003d\u0027left-network\u0027)"},{"line_number":118,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network,"},{"line_number":119,"context_line":"                                       name\u003d\u0027left-subnet\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_0a537de4","line":116,"in_reply_to":"7f231b9d_aa2b6980","updated":"2017-06-20 07:30:42.000000000","message":"i don\u0027t think so.\n\non the right side we specify it because we use the admin credential to specify enable_snat.","commit_id":"6693c3306a2fa95e22a116678e24a317de3b4b89"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"2c523e069e76a1b1a50e38e3ea669e38a7d451a7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        cls.create_pingable_secgroup_rule(secgroup_id\u003dcls.secgroup[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # LEFT"},{"line_number":113,"context_line":"        cls.router \u003d cls.create_router("},{"line_number":114,"context_line":"            data_utils.rand_name(\u0027left-router\u0027),"},{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_a2b5c9f0","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":39},"updated":"2017-06-21 07:33:25.000000000","message":"I guess you need to disable snat, otherwise the packets will be natted and the scenario won\u0027t work","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b1c16ef291855e8f73617a6094e1611d2d3734a7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        cls.create_pingable_secgroup_rule(secgroup_id\u003dcls.secgroup[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # LEFT"},{"line_number":113,"context_line":"        cls.router \u003d cls.create_router("},{"line_number":114,"context_line":"            data_utils.rand_name(\u0027left-router\u0027),"},{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_c0c0bd53","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":39},"in_reply_to":"5f201791_a0f26105","updated":"2017-06-21 08:34:12.000000000","message":"right vm uses a private ip. i guess it\u0027s enough to confirm bgp is working.","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"79ccb3be9ca189158cad42648d71e42a39c6fd98","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        cls.create_pingable_secgroup_rule(secgroup_id\u003dcls.secgroup[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # LEFT"},{"line_number":113,"context_line":"        cls.router \u003d cls.create_router("},{"line_number":114,"context_line":"            data_utils.rand_name(\u0027left-router\u0027),"},{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_e55f4be3","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":39},"in_reply_to":"5f201791_a2b5c9f0","updated":"2017-06-21 07:54:04.000000000","message":"it doesn\u0027t matter because the VM has a floating-ip.","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"cf00712c52955a272e3f9c0e596db64a86d03689","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        cls.create_pingable_secgroup_rule(secgroup_id\u003dcls.secgroup[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # LEFT"},{"line_number":113,"context_line":"        cls.router \u003d cls.create_router("},{"line_number":114,"context_line":"            data_utils.rand_name(\u0027left-router\u0027),"},{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_2077713d","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":39},"in_reply_to":"5f201791_c0c0bd53","updated":"2017-06-21 08:35:32.000000000","message":"Done","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"b177c618ea18fc31b3724ea931f4abd39252073d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        cls.create_pingable_secgroup_rule(secgroup_id\u003dcls.secgroup[\u0027id\u0027])"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # LEFT"},{"line_number":113,"context_line":"        cls.router \u003d cls.create_router("},{"line_number":114,"context_line":"            data_utils.rand_name(\u0027left-router\u0027),"},{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_a0f26105","line":113,"range":{"start_line":113,"start_character":0,"end_line":113,"end_character":39},"in_reply_to":"5f201791_e55f4be3","updated":"2017-06-21 08:26:53.000000000","message":"but you need to ping their internal ips in order to check that bgp is sending the internal routes,no?","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"2c523e069e76a1b1a50e38e3ea669e38a7d451a7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":117,"context_line":"        cls.network \u003d cls.create_network(network_name\u003d\u0027left-network\u0027)"},{"line_number":118,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network,"},{"line_number":119,"context_line":"                                       name\u003d\u0027left-subnet\u0027)"},{"line_number":120,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_82e1ad01","line":118,"updated":"2017-06-21 07:33:25.000000000","message":"what ip network is used for left subnet?","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b1c16ef291855e8f73617a6094e1611d2d3734a7","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":117,"context_line":"        cls.network \u003d cls.create_network(network_name\u003d\u0027left-network\u0027)"},{"line_number":118,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network,"},{"line_number":119,"context_line":"                                       name\u003d\u0027left-subnet\u0027)"},{"line_number":120,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_c0a55db7","line":118,"in_reply_to":"5f201791_20e65146","updated":"2017-06-21 08:34:12.000000000","message":"right.  but we don\u0027t have a proper mechanism to allocate a second subnet.","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"79ccb3be9ca189158cad42648d71e42a39c6fd98","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":117,"context_line":"        cls.network \u003d cls.create_network(network_name\u003d\u0027left-network\u0027)"},{"line_number":118,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network,"},{"line_number":119,"context_line":"                                       name\u003d\u0027left-subnet\u0027)"},{"line_number":120,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_855e57e4","line":118,"in_reply_to":"5f201791_82e1ad01","updated":"2017-06-21 07:54:04.000000000","message":"the default provided by neutron tempest config.","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"b177c618ea18fc31b3724ea931f4abd39252073d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":117,"context_line":"        cls.network \u003d cls.create_network(network_name\u003d\u0027left-network\u0027)"},{"line_number":118,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network,"},{"line_number":119,"context_line":"                                       name\u003d\u0027left-subnet\u0027)"},{"line_number":120,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_20e65146","line":118,"in_reply_to":"5f201791_855e57e4","updated":"2017-06-21 08:26:53.000000000","message":"only problem if this network is 10.10.0.0/24 that means that the test is going to fail. should we better to hardcode it?","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"cf00712c52955a272e3f9c0e596db64a86d03689","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":116,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":117,"context_line":"        cls.network \u003d cls.create_network(network_name\u003d\u0027left-network\u0027)"},{"line_number":118,"context_line":"        cls.subnet \u003d cls.create_subnet(cls.network,"},{"line_number":119,"context_line":"                                       name\u003d\u0027left-subnet\u0027)"},{"line_number":120,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_00747534","line":118,"in_reply_to":"5f201791_c0a55db7","updated":"2017-06-21 08:35:32.000000000","message":"Done","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"2c523e069e76a1b1a50e38e3ea669e38a7d451a7","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _setup_bgp(self):"},{"line_number":176,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":177,"context_line":"        subnet_id \u003d self._find_ipv4_subnet(network_id)"},{"line_number":178,"context_line":"        sites \u003d ["},{"line_number":179,"context_line":"            dict(name\u003d\"left\", network\u003dself.network, subnet\u003dself.subnet,"},{"line_number":180,"context_line":"                 router\u003dself.router, local_as\u003d64512),"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_224f79be","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":54},"updated":"2017-06-21 07:33:25.000000000","message":"if the subnet assigned is the same in both sides the test is going to fail","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"79ccb3be9ca189158cad42648d71e42a39c6fd98","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _setup_bgp(self):"},{"line_number":176,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":177,"context_line":"        subnet_id \u003d self._find_ipv4_subnet(network_id)"},{"line_number":178,"context_line":"        sites \u003d ["},{"line_number":179,"context_line":"            dict(name\u003d\"left\", network\u003dself.network, subnet\u003dself.subnet,"},{"line_number":180,"context_line":"                 router\u003dself.router, local_as\u003d64512),"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_45f5dfca","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":54},"in_reply_to":"5f201791_224f79be","updated":"2017-06-21 07:54:04.000000000","message":"this subnet is of the \"public network\" in the figure (see L77)","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"b177c618ea18fc31b3724ea931f4abd39252073d","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _setup_bgp(self):"},{"line_number":176,"context_line":"        network_id \u003d CONF.network.public_network_id"},{"line_number":177,"context_line":"        subnet_id \u003d self._find_ipv4_subnet(network_id)"},{"line_number":178,"context_line":"        sites \u003d ["},{"line_number":179,"context_line":"            dict(name\u003d\"left\", network\u003dself.network, subnet\u003dself.subnet,"},{"line_number":180,"context_line":"                 router\u003dself.router, local_as\u003d64512),"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_00e35535","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":54},"in_reply_to":"5f201791_45f5dfca","updated":"2017-06-21 08:26:53.000000000","message":"Done","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"2c523e069e76a1b1a50e38e3ea669e38a7d451a7","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            right_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":224,"context_line":"            should_succeed\u003dFalse)"},{"line_number":225,"context_line":"        self._setup_bgp()"},{"line_number":226,"context_line":"        self.check_remote_connectivity(ssh_client,"},{"line_number":227,"context_line":"            right_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_e27861f9","line":226,"range":{"start_line":226,"start_character":0,"end_line":226,"end_character":50},"updated":"2017-06-21 07:33:25.000000000","message":"bgp tooks some time to establish the session and propagate the routes, have you taken this into account?","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"79ccb3be9ca189158cad42648d71e42a39c6fd98","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            right_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":224,"context_line":"            should_succeed\u003dFalse)"},{"line_number":225,"context_line":"        self._setup_bgp()"},{"line_number":226,"context_line":"        self.check_remote_connectivity(ssh_client,"},{"line_number":227,"context_line":"            right_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_e5d2ab34","line":226,"range":{"start_line":226,"start_character":0,"end_line":226,"end_character":50},"in_reply_to":"5f201791_e27861f9","updated":"2017-06-21 07:54:04.000000000","message":"check_remote_connectivity has some retry/timeout logic. i guess it\u0027s enough.","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"b177c618ea18fc31b3724ea931f4abd39252073d","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            right_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":224,"context_line":"            should_succeed\u003dFalse)"},{"line_number":225,"context_line":"        self._setup_bgp()"},{"line_number":226,"context_line":"        self.check_remote_connectivity(ssh_client,"},{"line_number":227,"context_line":"            right_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_80d08552","line":226,"range":{"start_line":226,"start_character":0,"end_line":226,"end_character":50},"in_reply_to":"5f201791_e5d2ab34","updated":"2017-06-21 08:26:53.000000000","message":"Done","commit_id":"cb5f75a8a419f455993c1e27ada4c148e0039ff1"}]}
