)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b4497f3990e2c661954df48551497a20712a9919","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch enhances error path of request to opendaylight."},{"line_number":10,"context_line":"- handle timeout gracefully with the assumption that server is too busy"},{"line_number":11,"context_line":"  or network is unstable"},{"line_number":12,"context_line":"- handle 409(conflict) with POST(create) by falling back to PUT(update)"},{"line_number":13,"context_line":"  with the assumption that someone else already created it."},{"line_number":14,"context_line":"- handle 404(not found) with PUT(update) by falling back to POST(create)"},{"line_number":15,"context_line":"- handle 404(not found) with DELETE by ignoring the error as it\u0027s"},{"line_number":16,"context_line":"  already deleted by someone else."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf3e73b7_0763611c","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":72},"updated":"2017-08-07 19:21:26.000000000","message":"Those case also can happen when full sync case.","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b4497f3990e2c661954df48551497a20712a9919","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- handle 409(conflict) with POST(create) by falling back to PUT(update)"},{"line_number":13,"context_line":"  with the assumption that someone else already created it."},{"line_number":14,"context_line":"- handle 404(not found) with PUT(update) by falling back to POST(create)"},{"line_number":15,"context_line":"- handle 404(not found) with DELETE by ignoring the error as it\u0027s"},{"line_number":16,"context_line":"  already deleted by someone else."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I0cbe8a23582204936e87ee9398e5e465feebac85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf3e73b7_278f85cd","line":16,"range":{"start_line":15,"start_character":24,"end_line":16,"end_character":34},"updated":"2017-08-07 19:21:26.000000000","message":"Or in error recovery path of creation, neutron can issue delete without creating resource.","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"00ba13c68e423a1c4a18bc6105c49f9030188efb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  already deleted by someone else."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Manjeet Singh Bhatia \u003cmanjeet.s.bhatia@intel.com\u003e"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I0cbe8a23582204936e87ee9398e5e465feebac85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f436f4f_616bdd84","line":19,"updated":"2017-08-12 01:32:35.000000000","message":"closes-bug\nhttps://bugs.launchpad.net/networking-odl/+bug/1708241","commit_id":"fa36e00fac4b2eac1c46e8fce535634e0d554c85"}],"networking_odl/journal/journal.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"bc4efcdb730f119be0e7c7ba2f43c6f7c5ae2939","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            return False"},{"line_number":194,"context_line":"        except exceptions.Timeout:"},{"line_number":195,"context_line":"            # Don\u0027t raise the retry count, just log an error"},{"line_number":196,"context_line":"            LOG.error(_LE(\"Request timeouted to the Opendaylight Controller\"))"},{"line_number":197,"context_line":"            # Set row back to pending"},{"line_number":198,"context_line":"            db.update_db_row_state(session, row, odl_const.PENDING)"},{"line_number":199,"context_line":"            # Break our of the loop and retry with the next"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_e70dde38","line":196,"range":{"start_line":196,"start_character":35,"end_line":196,"end_character":44},"updated":"2016-06-19 13:08:18.000000000","message":"s/timeouted/timed out/\n\nEven better would be to phrase it like so:\nRequest timed out while trying to reach the Opendaylight Controller\"","commit_id":"cdd80bd99ab25496fb15c9805fbac8d52a857de9"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"bc4efcdb730f119be0e7c7ba2f43c6f7c5ae2939","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            # timer interval"},{"line_number":201,"context_line":"            return False"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        db.update_db_row_state(session, row, odl_const.COMPLETED)"},{"line_number":204,"context_line":"        return True"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    def _handle_http_error(self, method, urlpath, to_send,"},{"line_number":207,"context_line":"                           session, row, http_error):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_3c0c1d42","line":204,"range":{"start_line":203,"start_character":8,"end_line":204,"end_character":19},"updated":"2016-06-19 13:08:18.000000000","message":"It would be simpler if these 2 lines were inside the try and the \"update row\" and \"return False\" rows were here after the block (they would be reached only if the proper exception was caught)","commit_id":"cdd80bd99ab25496fb15c9805fbac8d52a857de9"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"bc4efcdb730f119be0e7c7ba2f43c6f7c5ae2939","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                           session, row, http_error):"},{"line_number":208,"context_line":"        try:"},{"line_number":209,"context_line":"            if method \u003d\u003d \u0027post\u0027:"},{"line_number":210,"context_line":"                if http_error.response.status_code \u003d\u003d status_codes.conflict:"},{"line_number":211,"context_line":"                    method \u003d \u0027put\u0027"},{"line_number":212,"context_line":"                    return self._sendjson(method, urlpath, to_send,"},{"line_number":213,"context_line":"                                          session, row)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_a7991622","line":210,"range":{"start_line":210,"start_character":16,"end_line":210,"end_character":18},"updated":"2016-06-19 13:08:18.000000000","message":"You should use \u0027and\u0027 instead of a nested if","commit_id":"cdd80bd99ab25496fb15c9805fbac8d52a857de9"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"bc4efcdb730f119be0e7c7ba2f43c6f7c5ae2939","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        try:"},{"line_number":209,"context_line":"            if method \u003d\u003d \u0027post\u0027:"},{"line_number":210,"context_line":"                if http_error.response.status_code \u003d\u003d status_codes.conflict:"},{"line_number":211,"context_line":"                    method \u003d \u0027put\u0027"},{"line_number":212,"context_line":"                    return self._sendjson(method, urlpath, to_send,"},{"line_number":213,"context_line":"                                          session, row)"},{"line_number":214,"context_line":"            elif method \u003d\u003d \u0027put\u0027:"},{"line_number":215,"context_line":"                if http_error.response.status_code \u003d\u003d status_codes.not_found:"},{"line_number":216,"context_line":"                    method \u003d \u0027post\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_67a72e50","line":213,"range":{"start_line":211,"start_character":20,"end_line":213,"end_character":55},"updated":"2016-06-19 13:08:18.000000000","message":"Don\u0027t think we should do this since you theoretically might update with stale data..\n\nPerhaps it makes more sense to just pass to completed in this case?","commit_id":"cdd80bd99ab25496fb15c9805fbac8d52a857de9"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"bc4efcdb730f119be0e7c7ba2f43c6f7c5ae2939","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                    return self._sendjson(method, urlpath, to_send,"},{"line_number":213,"context_line":"                                          session, row)"},{"line_number":214,"context_line":"            elif method \u003d\u003d \u0027put\u0027:"},{"line_number":215,"context_line":"                if http_error.response.status_code \u003d\u003d status_codes.not_found:"},{"line_number":216,"context_line":"                    method \u003d \u0027post\u0027"},{"line_number":217,"context_line":"                    return self._sendjson(method, urlpath, to_send,"},{"line_number":218,"context_line":"                                          session, row)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_e7bafe6d","line":215,"range":{"start_line":215,"start_character":16,"end_line":215,"end_character":18},"updated":"2016-06-19 13:08:18.000000000","message":"ditto","commit_id":"cdd80bd99ab25496fb15c9805fbac8d52a857de9"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"bc4efcdb730f119be0e7c7ba2f43c6f7c5ae2939","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                    return self._sendjson(method, urlpath, to_send,"},{"line_number":218,"context_line":"                                          session, row)"},{"line_number":219,"context_line":"            elif method \u003d\u003d \u0027delete\u0027:"},{"line_number":220,"context_line":"                if http_error.response.status_code \u003d\u003d status_codes.not_found:"},{"line_number":221,"context_line":"                    db.update_db_row_state(session, row,"},{"line_number":222,"context_line":"                                           odl_const.COMPLETED)"},{"line_number":223,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_47b0328c","line":220,"range":{"start_line":220,"start_character":16,"end_line":220,"end_character":18},"updated":"2016-06-19 13:08:18.000000000","message":"ditto","commit_id":"cdd80bd99ab25496fb15c9805fbac8d52a857de9"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"bc4efcdb730f119be0e7c7ba2f43c6f7c5ae2939","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                    db.update_db_row_state(session, row,"},{"line_number":222,"context_line":"                                           odl_const.COMPLETED)"},{"line_number":223,"context_line":"        except Exception as e:"},{"line_number":224,"context_line":"            self._log_and_update_retry(session, row, e)"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            self._log_and_update_retry(session, row, http_error)"},{"line_number":227,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_277406ce","line":224,"range":{"start_line":224,"start_character":0,"end_line":224,"end_character":55},"updated":"2016-06-19 13:08:18.000000000","message":"Shouldn\u0027t you be returning False here?","commit_id":"cdd80bd99ab25496fb15c9805fbac8d52a857de9"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"bc4efcdb730f119be0e7c7ba2f43c6f7c5ae2939","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        except Exception as e:"},{"line_number":224,"context_line":"            self._log_and_update_retry(session, row, e)"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            self._log_and_update_retry(session, row, http_error)"},{"line_number":227,"context_line":"        return True"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def _sync_pending_rows(self, session, exit_after_run):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_076d8a04","line":226,"range":{"start_line":226,"start_character":0,"end_line":226,"end_character":64},"updated":"2016-06-19 13:08:18.000000000","message":"Won\u0027t this update row that could\u0027ve been marked as completed as retry?","commit_id":"cdd80bd99ab25496fb15c9805fbac8d52a857de9"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"bc4efcdb730f119be0e7c7ba2f43c6f7c5ae2939","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            method, urlpath, to_send \u003d self._json_data(row)"},{"line_number":260,"context_line":"            try:"},{"line_number":261,"context_line":"                if not self._sendjson(method, urlpath, to_send, session, row):"},{"line_number":262,"context_line":"                    break"},{"line_number":263,"context_line":"            except exceptions.HTTPError as e:"},{"line_number":264,"context_line":"                if not self._handle_http_error(method, urlpath, to_send,"},{"line_number":265,"context_line":"                                               session, row, e):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_a73596f8","line":262,"range":{"start_line":262,"start_character":20,"end_line":262,"end_character":25},"updated":"2016-06-19 13:08:18.000000000","message":"Frankly these \u0027break\u0027s everywhere are quite confusing to follow.\n\nI\u0027d suggest to change the main while loop to loop over a variable called \u0027odl_accessible\u0027 or something similar so that it\u0027s easier to understand the global behavior here.\n\nThis might be a bit unrelated to this specific change but I\u0027ll mention it since you\u0027re adding another \u0027break\u0027..","commit_id":"cdd80bd99ab25496fb15c9805fbac8d52a857de9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b4497f3990e2c661954df48551497a20712a9919","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        session \u003d context.session"},{"line_number":245,"context_line":"        try:"},{"line_number":246,"context_line":"            self._sendjson(method, context, urlpath, to_send, entry)"},{"line_number":247,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":248,"context_line":"            self._handle_http_error(method, urlpath, to_send,"},{"line_number":249,"context_line":"                                    session, entry, e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_2219b378","line":246,"range":{"start_line":246,"start_character":12,"end_line":246,"end_character":68},"updated":"2017-08-07 19:21:26.000000000","message":"return value of _sendjson is ignored.","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ea1f2e23de273c3d7886272349dc99abb6ddde6e","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        session \u003d context.session"},{"line_number":245,"context_line":"        try:"},{"line_number":246,"context_line":"            self._sendjson(method, context, urlpath, to_send, entry)"},{"line_number":247,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":248,"context_line":"            self._handle_http_error(method, urlpath, to_send,"},{"line_number":249,"context_line":"                                    session, entry, e)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_1e572705","line":246,"range":{"start_line":246,"start_character":12,"end_line":246,"end_character":68},"in_reply_to":"bf3e73b7_2219b378","updated":"2017-08-07 21:15:10.000000000","message":"Done","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b4497f3990e2c661954df48551497a20712a9919","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        try:"},{"line_number":246,"context_line":"            self._sendjson(method, context, urlpath, to_send, entry)"},{"line_number":247,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":248,"context_line":"            self._handle_http_error(method, urlpath, to_send,"},{"line_number":249,"context_line":"                                    session, entry, e)"},{"line_number":250,"context_line":"        except Exception as e:"},{"line_number":251,"context_line":"            self._log_and_update_retry(session, entry, e)"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_a2f7e3f5","line":249,"range":{"start_line":248,"start_character":12,"end_line":249,"end_character":54},"updated":"2017-08-07 19:21:26.000000000","message":"this ignores return value.","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ea1f2e23de273c3d7886272349dc99abb6ddde6e","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        try:"},{"line_number":246,"context_line":"            self._sendjson(method, context, urlpath, to_send, entry)"},{"line_number":247,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":248,"context_line":"            self._handle_http_error(method, urlpath, to_send,"},{"line_number":249,"context_line":"                                    session, entry, e)"},{"line_number":250,"context_line":"        except Exception as e:"},{"line_number":251,"context_line":"            self._log_and_update_retry(session, entry, e)"},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_de407f38","line":249,"range":{"start_line":248,"start_character":12,"end_line":249,"end_character":54},"in_reply_to":"bf3e73b7_a2f7e3f5","updated":"2017-08-07 21:15:10.000000000","message":"Done","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b4497f3990e2c661954df48551497a20712a9919","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        session \u003d context.session"},{"line_number":245,"context_line":"        try:"},{"line_number":246,"context_line":"            self._sendjson(method, context, urlpath, to_send, entry)"},{"line_number":247,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":248,"context_line":"            self._handle_http_error(method, urlpath, to_send,"},{"line_number":249,"context_line":"                                    session, entry, e)"},{"line_number":250,"context_line":"        except Exception as e:"},{"line_number":251,"context_line":"            self._log_and_update_retry(session, entry, e)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        return False"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_e203ab0c","line":251,"range":{"start_line":247,"start_character":0,"end_line":251,"end_character":57},"updated":"2017-08-07 19:21:26.000000000","message":"In error case, True should be returned.","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ea1f2e23de273c3d7886272349dc99abb6ddde6e","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        session \u003d context.session"},{"line_number":245,"context_line":"        try:"},{"line_number":246,"context_line":"            self._sendjson(method, context, urlpath, to_send, entry)"},{"line_number":247,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":248,"context_line":"            self._handle_http_error(method, urlpath, to_send,"},{"line_number":249,"context_line":"                                    session, entry, e)"},{"line_number":250,"context_line":"        except Exception as e:"},{"line_number":251,"context_line":"            self._log_and_update_retry(session, entry, e)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        return False"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_be3dbbbc","line":251,"range":{"start_line":247,"start_character":0,"end_line":251,"end_character":57},"in_reply_to":"bf3e73b7_e203ab0c","updated":"2017-08-07 21:15:10.000000000","message":"Done","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b4497f3990e2c661954df48551497a20712a9919","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        return False"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def _log_and_update_retry(self, session, entry, exception_):"},{"line_number":256,"context_line":"        LOG.error(\"Error while processing %(type)s %(operation)s,\""},{"line_number":257,"context_line":"                  \" id %(uuid)s Error: %(error)s\","},{"line_number":258,"context_line":"                  {\u0027type\u0027: entry.object_type,"},{"line_number":259,"context_line":"                   \u0027uuid\u0027: entry.object_uuid,"},{"line_number":260,"context_line":"                   \u0027operation\u0027: entry.operation,"},{"line_number":261,"context_line":"                   \u0027error\u0027: exception_.message})"},{"line_number":262,"context_line":"        db.update_pending_db_row_retry(session, entry,"},{"line_number":263,"context_line":"                                       self._max_retry_count)"},{"line_number":264,"context_line":"        self._retry_sleep()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_a2a923e0","line":261,"range":{"start_line":256,"start_character":0,"end_line":261,"end_character":48},"updated":"2017-08-07 19:21:26.000000000","message":"We\u0027d like to keep same log format as line 261.","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ea1f2e23de273c3d7886272349dc99abb6ddde6e","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        return False"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def _log_and_update_retry(self, session, entry, exception_):"},{"line_number":256,"context_line":"        LOG.error(\"Error while processing %(type)s %(operation)s,\""},{"line_number":257,"context_line":"                  \" id %(uuid)s Error: %(error)s\","},{"line_number":258,"context_line":"                  {\u0027type\u0027: entry.object_type,"},{"line_number":259,"context_line":"                   \u0027uuid\u0027: entry.object_uuid,"},{"line_number":260,"context_line":"                   \u0027operation\u0027: entry.operation,"},{"line_number":261,"context_line":"                   \u0027error\u0027: exception_.message})"},{"line_number":262,"context_line":"        db.update_pending_db_row_retry(session, entry,"},{"line_number":263,"context_line":"                                       self._max_retry_count)"},{"line_number":264,"context_line":"        self._retry_sleep()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_1eccc7ba","line":261,"range":{"start_line":256,"start_character":0,"end_line":261,"end_character":48},"in_reply_to":"bf3e73b7_a2a923e0","updated":"2017-08-07 21:15:10.000000000","message":"Done","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b4497f3990e2c661954df48551497a20712a9919","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            LOG.error(\"Cannot connect to the Opendaylight Controller,\""},{"line_number":281,"context_line":"                      \" will not process additional enteries\")"},{"line_number":282,"context_line":"            self._retry_sleep()"},{"line_number":283,"context_line":"            return True"},{"line_number":284,"context_line":"        except exceptions.Timeout:"},{"line_number":285,"context_line":"            # Don\u0027t raise the retry count, just log an error"},{"line_number":286,"context_line":"            LOG.error(\"Request timed out while trying to reach the \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_82405f37","line":283,"range":{"start_line":283,"start_character":12,"end_line":283,"end_character":23},"updated":"2017-08-07 19:21:26.000000000","message":"This value is ignored by caller","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ea1f2e23de273c3d7886272349dc99abb6ddde6e","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            LOG.error(\"Cannot connect to the Opendaylight Controller,\""},{"line_number":281,"context_line":"                      \" will not process additional enteries\")"},{"line_number":282,"context_line":"            self._retry_sleep()"},{"line_number":283,"context_line":"            return True"},{"line_number":284,"context_line":"        except exceptions.Timeout:"},{"line_number":285,"context_line":"            # Don\u0027t raise the retry count, just log an error"},{"line_number":286,"context_line":"            LOG.error(\"Request timed out while trying to reach the \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf3e73b7_7ee3d334","line":283,"range":{"start_line":283,"start_character":12,"end_line":283,"end_character":23},"in_reply_to":"bf3e73b7_82405f37","updated":"2017-08-07 21:15:10.000000000","message":"Done","commit_id":"355d9623b85329bb84789404a0fc9aaa9072bdd2"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"07f30cd2bfcee504151ac29b61a2bfb4bd1469f3","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                                      session, row)"},{"line_number":305,"context_line":"            elif method \u003d\u003d \u0027delete\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":306,"context_line":"                           status_codes.not_found:"},{"line_number":307,"context_line":"                db.update_db_row_state(session, row,"},{"line_number":308,"context_line":"                                       odl_const.COMPLETED)"},{"line_number":309,"context_line":"        except Exception as e:"},{"line_number":310,"context_line":"            self._log_and_update_retry(session, row, e)"},{"line_number":311,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf3e73b7_7ea8731e","line":308,"range":{"start_line":307,"start_character":0,"end_line":308,"end_character":59},"updated":"2017-08-07 21:45:45.000000000","message":"return True is needed. Otherwise this excecution flow falls to try..else clause.","commit_id":"e1c00209dc3bd7340d08c4207bfa2ab7fbc01485"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a05d2d2fca27dd71d837e17f88fc5e56a9ef2080","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                                      session, row)"},{"line_number":305,"context_line":"            elif method \u003d\u003d \u0027delete\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":306,"context_line":"                           status_codes.not_found:"},{"line_number":307,"context_line":"                db.update_db_row_state(session, row,"},{"line_number":308,"context_line":"                                       odl_const.COMPLETED)"},{"line_number":309,"context_line":"        except Exception as e:"},{"line_number":310,"context_line":"            self._log_and_update_retry(session, row, e)"},{"line_number":311,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf3e73b7_e1cf267d","line":308,"range":{"start_line":307,"start_character":0,"end_line":308,"end_character":59},"in_reply_to":"bf3e73b7_7ea8731e","updated":"2017-08-07 22:06:03.000000000","message":"return True at the end would have worked","commit_id":"e1c00209dc3bd7340d08c4207bfa2ab7fbc01485"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"3e35fb93165462bac2424379c9a5fcd640fa9f78","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                           session, row, http_error):"},{"line_number":294,"context_line":"        try:"},{"line_number":295,"context_line":"            if method \u003d\u003d \u0027post\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":296,"context_line":"               status_codes.conflict:"},{"line_number":297,"context_line":"                    method \u003d \u0027put\u0027"},{"line_number":298,"context_line":"                    return self._sendjson(method, urlpath, to_send,"},{"line_number":299,"context_line":"                                          session, row)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf3e73b7_6428e485","line":296,"range":{"start_line":296,"start_character":0,"end_line":296,"end_character":37},"updated":"2017-08-07 22:36:08.000000000","message":"nitpick: please be consistent with line 301, line 306.","commit_id":"c2ab10aaeed41fa6437cdb12e3499bc1e942ca4c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0678cc8bdd363a2ea28a021a0532eb271517f7e0","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                           session, row, http_error):"},{"line_number":294,"context_line":"        try:"},{"line_number":295,"context_line":"            if method \u003d\u003d \u0027post\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":296,"context_line":"               status_codes.conflict:"},{"line_number":297,"context_line":"                    method \u003d \u0027put\u0027"},{"line_number":298,"context_line":"                    return self._sendjson(method, urlpath, to_send,"},{"line_number":299,"context_line":"                                          session, row)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf3e73b7_443cc092","line":296,"range":{"start_line":296,"start_character":0,"end_line":296,"end_character":37},"in_reply_to":"bf3e73b7_6428e485","updated":"2017-08-07 22:45:02.000000000","message":"Done","commit_id":"c2ab10aaeed41fa6437cdb12e3499bc1e942ca4c"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"3e35fb93165462bac2424379c9a5fcd640fa9f78","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        try:"},{"line_number":295,"context_line":"            if method \u003d\u003d \u0027post\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":296,"context_line":"               status_codes.conflict:"},{"line_number":297,"context_line":"                    method \u003d \u0027put\u0027"},{"line_number":298,"context_line":"                    return self._sendjson(method, urlpath, to_send,"},{"line_number":299,"context_line":"                                          session, row)"},{"line_number":300,"context_line":"            elif method \u003d\u003d \u0027put\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":301,"context_line":"                           status_codes.not_found:"},{"line_number":302,"context_line":"                method \u003d \u0027post\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf3e73b7_040eb833","line":299,"range":{"start_line":297,"start_character":0,"end_line":299,"end_character":55},"updated":"2017-08-07 22:36:08.000000000","message":"nitpick: overindent.","commit_id":"c2ab10aaeed41fa6437cdb12e3499bc1e942ca4c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0678cc8bdd363a2ea28a021a0532eb271517f7e0","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        try:"},{"line_number":295,"context_line":"            if method \u003d\u003d \u0027post\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":296,"context_line":"               status_codes.conflict:"},{"line_number":297,"context_line":"                    method \u003d \u0027put\u0027"},{"line_number":298,"context_line":"                    return self._sendjson(method, urlpath, to_send,"},{"line_number":299,"context_line":"                                          session, row)"},{"line_number":300,"context_line":"            elif method \u003d\u003d \u0027put\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":301,"context_line":"                           status_codes.not_found:"},{"line_number":302,"context_line":"                method \u003d \u0027post\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf3e73b7_6437c4b2","line":299,"range":{"start_line":297,"start_character":0,"end_line":299,"end_character":55},"in_reply_to":"bf3e73b7_040eb833","updated":"2017-08-07 22:45:02.000000000","message":"Done","commit_id":"c2ab10aaeed41fa6437cdb12e3499bc1e942ca4c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"2d138c847be0bc95fedd8e9cd76b5b1f01e995cc","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        try:"},{"line_number":246,"context_line":"            return self._sendjson(method, context, urlpath, to_send, entry)"},{"line_number":247,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":248,"context_line":"            return self._handle_http_error(method, urlpath, to_send,"},{"line_number":249,"context_line":"                                           session, entry, e)"},{"line_number":250,"context_line":"        except Exception as e:"},{"line_number":251,"context_line":"            self._log_and_update_retry(session, entry, e)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_7049a989","line":248,"updated":"2017-08-10 07:23:39.000000000","message":"Can we check for \u0027GET\u0027 method and does not handle it? or we can check at the beginning of _handle_http_erro. later one seems to be better one.","commit_id":"6b2ea81e13acc5593211706f058ceac0214c6be8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"2d138c847be0bc95fedd8e9cd76b5b1f01e995cc","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            return self._sendjson(method, context, urlpath, to_send, entry)"},{"line_number":247,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":248,"context_line":"            return self._handle_http_error(method, urlpath, to_send,"},{"line_number":249,"context_line":"                                           session, entry, e)"},{"line_number":250,"context_line":"        except Exception as e:"},{"line_number":251,"context_line":"            self._log_and_update_retry(session, entry, e)"},{"line_number":252,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_26cc0b60","line":249,"range":{"start_line":249,"start_character":58,"end_line":249,"end_character":61},"updated":"2017-08-10 07:23:39.000000000","message":"I think, we should log here exception explicitly, It does not make much sense to log exception away from where it actually caught.\n\nit will give clear insight that error occurred first time execution then we tried with modification.","commit_id":"6b2ea81e13acc5593211706f058ceac0214c6be8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"2d138c847be0bc95fedd8e9cd76b5b1f01e995cc","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        return False"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _log_and_update_retry(self, session, entry, exception_):"},{"line_number":257,"context_line":"        log_dict \u003d {\u0027op\u0027: entry.operation, \u0027type\u0027: entry.object_type,"},{"line_number":258,"context_line":"                    \u0027id\u0027: entry.object_uuid}"},{"line_number":259,"context_line":"        LOG.error(\"Error while processing %(op)s %(type)s %(id)s\","},{"line_number":260,"context_line":"                  log_dict, exc_info\u003dTrue)"},{"line_number":261,"context_line":"        db.update_pending_db_row_retry(session, entry,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_f0723949","line":258,"range":{"start_line":257,"start_character":0,"end_line":258,"end_character":44},"updated":"2017-08-10 07:23:39.000000000","message":"I think, this part can be moved to a method or reused line 239 by passing argument?","commit_id":"6b2ea81e13acc5593211706f058ceac0214c6be8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"2d138c847be0bc95fedd8e9cd76b5b1f01e995cc","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        except exceptions.ConnectionError:"},{"line_number":277,"context_line":"            # Don\u0027t raise the retry count, just log an error"},{"line_number":278,"context_line":"            db.update_db_row_state(session, entry, odl_const.PENDING)"},{"line_number":279,"context_line":"            LOG.error(\"Cannot connect to the Opendaylight Controller,\""},{"line_number":280,"context_line":"                      \" will not process additional enteries\")"},{"line_number":281,"context_line":"            self._retry_sleep()"},{"line_number":282,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_9c4f8991","line":279,"range":{"start_line":279,"start_character":49,"end_line":279,"end_character":50},"updated":"2017-08-10 07:23:39.000000000","message":"unnecessary change","commit_id":"6b2ea81e13acc5593211706f058ceac0214c6be8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"2d138c847be0bc95fedd8e9cd76b5b1f01e995cc","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            # Don\u0027t raise the retry count, just log an error"},{"line_number":278,"context_line":"            db.update_db_row_state(session, entry, odl_const.PENDING)"},{"line_number":279,"context_line":"            LOG.error(\"Cannot connect to the Opendaylight Controller,\""},{"line_number":280,"context_line":"                      \" will not process additional enteries\")"},{"line_number":281,"context_line":"            self._retry_sleep()"},{"line_number":282,"context_line":"            return True"},{"line_number":283,"context_line":"        except exceptions.Timeout:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_1c7279e4","line":280,"range":{"start_line":280,"start_character":54,"end_line":280,"end_character":56},"updated":"2017-08-10 07:23:39.000000000","message":"unnecessary change.","commit_id":"6b2ea81e13acc5593211706f058ceac0214c6be8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"2d138c847be0bc95fedd8e9cd76b5b1f01e995cc","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    def _handle_http_error(self, method, urlpath, to_send,"},{"line_number":293,"context_line":"                           session, row, http_error):"},{"line_number":294,"context_line":"        try:"},{"line_number":295,"context_line":"            if method \u003d\u003d \u0027post\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":296,"context_line":"               status_codes.conflict:"},{"line_number":297,"context_line":"                method \u003d \u0027put\u0027"},{"line_number":298,"context_line":"                return self._sendjson(method, urlpath, to_send,"},{"line_number":299,"context_line":"                                      session, row)"},{"line_number":300,"context_line":"            elif method \u003d\u003d \u0027put\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":301,"context_line":"                           status_codes.not_found:"},{"line_number":302,"context_line":"                method \u003d \u0027post\u0027"},{"line_number":303,"context_line":"                return self._sendjson(method, urlpath, to_send,"},{"line_number":304,"context_line":"                                      session, row)"},{"line_number":305,"context_line":"            elif method \u003d\u003d \u0027delete\u0027 and http_error.response.status_code \u003d\u003d \\"},{"line_number":306,"context_line":"                           status_codes.not_found:"},{"line_number":307,"context_line":"                db.update_db_row_state(session, row,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_a9d56c45","line":304,"range":{"start_line":295,"start_character":1,"end_line":304,"end_character":51},"updated":"2017-08-10 07:23:39.000000000","message":"Can we something like\n\nif condition:\n  method \u003d \u0027\u0027\nelse if condition:\n  method \u003d \u0027\u0027\n\nreturn self._sendjson()\n\nit will save some duplicate code.","commit_id":"6b2ea81e13acc5593211706f058ceac0214c6be8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"2d138c847be0bc95fedd8e9cd76b5b1f01e995cc","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                           status_codes.not_found:"},{"line_number":307,"context_line":"                db.update_db_row_state(session, row,"},{"line_number":308,"context_line":"                                       odl_const.COMPLETED)"},{"line_number":309,"context_line":"                return True"},{"line_number":310,"context_line":"        except Exception as e:"},{"line_number":311,"context_line":"            self._log_and_update_retry(session, row, e)"},{"line_number":312,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_90b88d76","line":309,"range":{"start_line":309,"start_character":1,"end_line":309,"end_character":27},"updated":"2017-08-10 07:23:39.000000000","message":"It will stop the syncing, do you really mean it?","commit_id":"6b2ea81e13acc5593211706f058ceac0214c6be8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"2d138c847be0bc95fedd8e9cd76b5b1f01e995cc","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        except Exception as e:"},{"line_number":311,"context_line":"            self._log_and_update_retry(session, row, e)"},{"line_number":312,"context_line":"            return False"},{"line_number":313,"context_line":"        else:"},{"line_number":314,"context_line":"            self._log_and_update_retry(session, row, http_error)"},{"line_number":315,"context_line":"            return False"},{"line_number":316,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_0677c704","line":315,"range":{"start_line":313,"start_character":0,"end_line":315,"end_character":24},"updated":"2017-08-10 07:23:39.000000000","message":"if comment on line 249 is followed then it is not needed. if exception has to get there then except and else are doing the same thing with little change can be combined at one place.","commit_id":"6b2ea81e13acc5593211706f058ceac0214c6be8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"2d138c847be0bc95fedd8e9cd76b5b1f01e995cc","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        else:"},{"line_number":314,"context_line":"            self._log_and_update_retry(session, row, http_error)"},{"line_number":315,"context_line":"            return False"},{"line_number":316,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_10813d90","line":316,"range":{"start_line":316,"start_character":0,"end_line":316,"end_character":19},"updated":"2017-08-10 07:23:39.000000000","message":"if any exception occur then Line number 312 handles it and if does not then 315 then how do we arrive here?","commit_id":"6b2ea81e13acc5593211706f058ceac0214c6be8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"54e51c18508f9a97d4634ae3f8bf43daa0231c14","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        except exceptions.Timeout:"},{"line_number":292,"context_line":"            # Don\u0027t raise the retry count, just log an error"},{"line_number":293,"context_line":"            LOG.error(\"Request timed out while trying to reach the \""},{"line_number":294,"context_line":"                      \"Opendaylight Controller\")"},{"line_number":295,"context_line":"            # Set row back to pending"},{"line_number":296,"context_line":"            db.update_db_row_state(session, entry, odl_const.PENDING)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9f436f4f_c124c9b1","line":294,"range":{"start_line":294,"start_character":23,"end_line":294,"end_character":35},"updated":"2017-08-12 01:10:58.000000000","message":"OpenDaylight (capital D)","commit_id":"fa36e00fac4b2eac1c46e8fce535634e0d554c85"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"54e51c18508f9a97d4634ae3f8bf43daa0231c14","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                method \u003d \u0027post\u0027 if method \u003d\u003d \u0027put\u0027 else \u0027put\u0027"},{"line_number":315,"context_line":"                log_dict \u003d self._get_log_dict(row)"},{"line_number":316,"context_line":"                LOG.info(\"Retrying - %(op)s %(type)s %(id)s\", log_dict)"},{"line_number":317,"context_line":"                return self._sendjson(method, urlpath, to_send,"},{"line_number":318,"context_line":"                                      session, row)"},{"line_number":319,"context_line":"        except Exception as e:"},{"line_number":320,"context_line":"            self._log_and_update_retry(session, row, e)"},{"line_number":321,"context_line":"            return False"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        db.update_pending_db_row_retry(session, row,"},{"line_number":324,"context_line":"                                       self._max_retry_count)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f436f4f_e11fcd58","line":321,"range":{"start_line":317,"start_character":0,"end_line":321,"end_character":24},"updated":"2017-08-12 01:10:58.000000000","message":"If this method is organized in this way, try..except block is only for line 317.","commit_id":"fa36e00fac4b2eac1c46e8fce535634e0d554c85"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"9b25166d6a3e6119a7952449f05a31e49d89f37e","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        session \u003d context.session"},{"line_number":249,"context_line":"        try:"},{"line_number":250,"context_line":"            return self._sendjson(method, context, urlpath, to_send, entry)"},{"line_number":251,"context_line":"        except exceptions.HTTPError as e:"},{"line_number":252,"context_line":"            self._log_exception(entry, e)"},{"line_number":253,"context_line":"            return self._handle_http_error(method, urlpath, to_send,"},{"line_number":254,"context_line":"                                           session, entry, e)"},{"line_number":255,"context_line":"        except Exception as e:"},{"line_number":256,"context_line":"            self._log_and_update_retry(session, entry, e)"},{"line_number":257,"context_line":"            return True"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        return False"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_0f11c152","line":257,"range":{"start_line":251,"start_character":8,"end_line":257,"end_character":23},"updated":"2017-08-14 13:33:50.000000000","message":"Why is this separated from the other exception handling? It makes it harder to read and understand what\u0027s going on..","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"9b25166d6a3e6119a7952449f05a31e49d89f37e","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                      \" will not process additional entries\")"},{"line_number":289,"context_line":"            self._retry_sleep()"},{"line_number":290,"context_line":"            return True"},{"line_number":291,"context_line":"        except exceptions.Timeout:"},{"line_number":292,"context_line":"            # Don\u0027t raise the retry count, just log an error"},{"line_number":293,"context_line":"            LOG.error(\"Request timed out while trying to reach the \""},{"line_number":294,"context_line":"                      \"OpenDaylight Controller\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_ef32fdf1","line":291,"range":{"start_line":291,"start_character":0,"end_line":291,"end_character":34},"updated":"2017-08-14 13:33:50.000000000","message":"Seems similar to ConnectionError, why not catch both in the same clause?","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"641e804904428c06c5e62fb63362d1252b09ad38","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                      \" will not process additional entries\")"},{"line_number":289,"context_line":"            self._retry_sleep()"},{"line_number":290,"context_line":"            return True"},{"line_number":291,"context_line":"        except exceptions.Timeout:"},{"line_number":292,"context_line":"            # Don\u0027t raise the retry count, just log an error"},{"line_number":293,"context_line":"            LOG.error(\"Request timed out while trying to reach the \""},{"line_number":294,"context_line":"                      \"OpenDaylight Controller\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_dd748ad1","line":291,"range":{"start_line":291,"start_character":0,"end_line":291,"end_character":34},"in_reply_to":"9f436f4f_ef32fdf1","updated":"2017-08-15 17:12:30.000000000","message":"they need different handling, therefore catch separately.","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"9b25166d6a3e6119a7952449f05a31e49d89f37e","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                                   odl_const.COMPLETED)"},{"line_number":306,"context_line":"            return False"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        if (method \u003d\u003d \u0027post\u0027 and http_error.response.status_code \u003d\u003d"},{"line_number":309,"context_line":"           status_codes.conflict) or (method \u003d\u003d \u0027put\u0027"},{"line_number":310,"context_line":"           and http_error.response.status_code \u003d\u003d status_codes.not_found):"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_2f9925c3","line":308,"range":{"start_line":308,"start_character":33,"end_line":308,"end_character":64},"updated":"2017-08-14 13:33:50.000000000","message":"This can be received as parameter, since that\u0027s the only thin you\u0027re accessing anyway in the \"http_error\" object.","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"641e804904428c06c5e62fb63362d1252b09ad38","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                                   odl_const.COMPLETED)"},{"line_number":306,"context_line":"            return False"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        if (method \u003d\u003d \u0027post\u0027 and http_error.response.status_code \u003d\u003d"},{"line_number":309,"context_line":"           status_codes.conflict) or (method \u003d\u003d \u0027put\u0027"},{"line_number":310,"context_line":"           and http_error.response.status_code \u003d\u003d status_codes.not_found):"},{"line_number":311,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_79d472e9","line":308,"range":{"start_line":308,"start_character":33,"end_line":308,"end_character":64},"in_reply_to":"9f436f4f_2f9925c3","updated":"2017-08-15 17:12:30.000000000","message":"Done","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"9b25166d6a3e6119a7952449f05a31e49d89f37e","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            method \u003d \u0027post\u0027 if method \u003d\u003d \u0027put\u0027 else \u0027put\u0027"},{"line_number":313,"context_line":"            log_dict \u003d self._get_log_dict(row)"},{"line_number":314,"context_line":"            LOG.info(\"Retrying - %(op)s %(type)s %(id)s\", log_dict)"},{"line_number":315,"context_line":"            try:"},{"line_number":316,"context_line":"                return self._sendjson(method, urlpath, to_send,"},{"line_number":317,"context_line":"                                      session, row)"},{"line_number":318,"context_line":"            except Exception as e:"},{"line_number":319,"context_line":"                self._log_and_update_retry(session, row, e)"},{"line_number":320,"context_line":"                return False"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        db.update_pending_db_row_retry(session, row,"},{"line_number":323,"context_line":"                                       self._max_retry_count)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_8feff11c","line":320,"range":{"start_line":314,"start_character":12,"end_line":320,"end_character":28},"updated":"2017-08-14 13:33:50.000000000","message":"This doesn\u0027t seem reliable, wouldn\u0027t it be better to record a new journal entry for the new operation and mark this one as completed?","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"641e804904428c06c5e62fb63362d1252b09ad38","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            method \u003d \u0027post\u0027 if method \u003d\u003d \u0027put\u0027 else \u0027put\u0027"},{"line_number":313,"context_line":"            log_dict \u003d self._get_log_dict(row)"},{"line_number":314,"context_line":"            LOG.info(\"Retrying - %(op)s %(type)s %(id)s\", log_dict)"},{"line_number":315,"context_line":"            try:"},{"line_number":316,"context_line":"                return self._sendjson(method, urlpath, to_send,"},{"line_number":317,"context_line":"                                      session, row)"},{"line_number":318,"context_line":"            except Exception as e:"},{"line_number":319,"context_line":"                self._log_and_update_retry(session, row, e)"},{"line_number":320,"context_line":"                return False"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        db.update_pending_db_row_retry(session, row,"},{"line_number":323,"context_line":"                                       self._max_retry_count)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_d819387a","line":320,"range":{"start_line":314,"start_character":12,"end_line":320,"end_character":28},"in_reply_to":"9f436f4f_8feff11c","updated":"2017-08-15 17:12:30.000000000","message":"If we put them in table again, then \"method\" will be calculated the same way as the first time. But we want different method and handle them differently. May be some more information will be needed to put in database to verify that it is second time.\n\nDO you mean, we change create to update or update to create accordingly?","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e96e364ca7aaa831e7acc431fa6a0bafe9c1f53c","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    def _handle_http_error(self, method, urlpath, to_send,"},{"line_number":302,"context_line":"                           session, row, status_code):"},{"line_number":303,"context_line":"        if method \u003d\u003d \u0027delete\u0027 and status_code \u003d\u003d status_codes.codes.NOT_FOUND:"},{"line_number":304,"context_line":"            db.update_db_row_state(session, row,"},{"line_number":305,"context_line":"                                   odl_const.COMPLETED)"},{"line_number":306,"context_line":"            return False"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        if (method \u003d\u003d \u0027post\u0027 and status_code \u003d\u003d status_codes.codes.CONFLICT) \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_c8332a62","line":305,"range":{"start_line":304,"start_character":12,"end_line":305,"end_character":55},"updated":"2017-08-18 16:40:22.000000000","message":"nit: can fit into single line.","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"75282b437154fab4c1ab560c4a3ed3480ca64d54","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    def _handle_http_error(self, method, urlpath, to_send,"},{"line_number":302,"context_line":"                           session, row, status_code):"},{"line_number":303,"context_line":"        if method \u003d\u003d \u0027delete\u0027 and status_code \u003d\u003d status_codes.codes.NOT_FOUND:"},{"line_number":304,"context_line":"            db.update_db_row_state(session, row,"},{"line_number":305,"context_line":"                                   odl_const.COMPLETED)"},{"line_number":306,"context_line":"            return False"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        if (method \u003d\u003d \u0027post\u0027 and status_code \u003d\u003d status_codes.codes.CONFLICT) \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_01b8d627","line":305,"range":{"start_line":304,"start_character":12,"end_line":305,"end_character":55},"in_reply_to":"9f436f4f_c8332a62","updated":"2017-08-21 06:06:11.000000000","message":"Done","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"6d0750beaca10e90b1f9ad5152db6ef8e0e15214","unresolved":false,"context_lines":[{"line_number":253,"context_line":"            return self._handle_http_error(method, urlpath, to_send,"},{"line_number":254,"context_line":"                                           session, entry,"},{"line_number":255,"context_line":"                                           e.response.status_code)"},{"line_number":256,"context_line":"        except Exception as e:"},{"line_number":257,"context_line":"            self._log_and_update_retry(session, entry, e)"},{"line_number":258,"context_line":"            return True"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7f287b81_34f23808","line":256,"updated":"2017-08-22 09:38:06.000000000","message":"This is a point of difficulty for future debugging. It will catch ALL exceptions and could potentially lead to silent problems. I\u0027m sure there is a discrete list of exceptions that we can expect. Let\u0027s put those instead.","commit_id":"d55e02fac89e262931a599b25b3823ccc61101d2"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"6d0750beaca10e90b1f9ad5152db6ef8e0e15214","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            try:"},{"line_number":315,"context_line":"                return self._sendjson(method, urlpath, to_send,"},{"line_number":316,"context_line":"                                      session, row)"},{"line_number":317,"context_line":"            except Exception as e:"},{"line_number":318,"context_line":"                self._log_and_update_retry(session, row, e)"},{"line_number":319,"context_line":"                return False"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7f287b81_14d05c50","line":317,"range":{"start_line":317,"start_character":12,"end_line":317,"end_character":34},"updated":"2017-08-22 09:38:06.000000000","message":"Same as a L256","commit_id":"d55e02fac89e262931a599b25b3823ccc61101d2"}],"networking_odl/tests/unit/journal/test_journal.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"9b25166d6a3e6119a7952449f05a31e49d89f37e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9f436f4f_cfc3b956","updated":"2017-08-14 13:33:50.000000000","message":"You don\u0027t seem to be covering code such as when you have a post + conflict, or put + not found, the timeout exception, etc. Please add tests for all the logic you\u0027re adding","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"641e804904428c06c5e62fb63362d1252b09ad38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9f436f4f_f9e862b3","in_reply_to":"9f436f4f_cfc3b956","updated":"2017-08-15 17:12:30.000000000","message":"Done","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"9b25166d6a3e6119a7952449f05a31e49d89f37e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_db_row_state\u0027)"},{"line_number":72,"context_line":"    def test_handle_http_error_delete(self, mock_db):"},{"line_number":73,"context_line":"        method \u003d \u0027delete\u0027"},{"line_number":74,"context_line":"        http_error \u003d mock.Mock(response\u003dmock.Mock(status_code\u003d404))"},{"line_number":75,"context_line":"        session \u003d mock.Mock()"},{"line_number":76,"context_line":"        row \u003d mock.Mock()"},{"line_number":77,"context_line":"        resp \u003d self.journal._handle_http_error(method, \u0027test_url\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_cffcd9b6","line":74,"range":{"start_line":74,"start_character":62,"end_line":74,"end_character":65},"updated":"2017-08-14 13:33:50.000000000","message":"Why hard coded values and not the \"constants\" from requests.status_codes? (Same goes for all the tests)","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"9b25166d6a3e6119a7952449f05a31e49d89f37e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"},{"line_number":86,"context_line":"    def test_handle_http_error_post(self, mock_db, mock_send_json):"},{"line_number":87,"context_line":"        method \u003d \u0027post\u0027"},{"line_number":88,"context_line":"        http_error \u003d mock.Mock(response\u003dmock.Mock(status_code\u003d409))"},{"line_number":89,"context_line":"        session \u003d mock.Mock()"},{"line_number":90,"context_line":"        row \u003d mock.Mock()"},{"line_number":91,"context_line":"        resp \u003d self.journal._handle_http_error(method, \u0027test_url\u0027,"},{"line_number":92,"context_line":"                                               \u0027test_to_send\u0027, session,"},{"line_number":93,"context_line":"                                               row, http_error)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        mock_db.assert_called_once_with(session, row, odl_const.COMPLETED)"},{"line_number":96,"context_line":"        self.assertFalse(resp)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_send_json\u0027)"},{"line_number":99,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_2fe805e0","line":96,"range":{"start_line":88,"start_character":8,"end_line":96,"end_character":30},"updated":"2017-08-14 13:33:50.000000000","message":"Seems pretty repetitive in all these tests, should be extracted to a method that accepts as parameters the variables that change (i.e. method).","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"641e804904428c06c5e62fb63362d1252b09ad38","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"},{"line_number":86,"context_line":"    def test_handle_http_error_post(self, mock_db, mock_send_json):"},{"line_number":87,"context_line":"        method \u003d \u0027post\u0027"},{"line_number":88,"context_line":"        http_error \u003d mock.Mock(response\u003dmock.Mock(status_code\u003d409))"},{"line_number":89,"context_line":"        session \u003d mock.Mock()"},{"line_number":90,"context_line":"        row \u003d mock.Mock()"},{"line_number":91,"context_line":"        resp \u003d self.journal._handle_http_error(method, \u0027test_url\u0027,"},{"line_number":92,"context_line":"                                               \u0027test_to_send\u0027, session,"},{"line_number":93,"context_line":"                                               row, http_error)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        mock_db.assert_called_once_with(session, row, odl_const.COMPLETED)"},{"line_number":96,"context_line":"        self.assertFalse(resp)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_send_json\u0027)"},{"line_number":99,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f436f4f_59e08ecd","line":96,"range":{"start_line":88,"start_character":8,"end_line":96,"end_character":30},"in_reply_to":"9f436f4f_2fe805e0","updated":"2017-08-15 17:12:30.000000000","message":"Done","commit_id":"28f5926234a4ecb69e120c5d698c530e4c5495b7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e96e364ca7aaa831e7acc431fa6a0bafe9c1f53c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def test_handle_http_error_delete(self, mock_db):"},{"line_number":83,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":84,"context_line":"            \u0027delete\u0027, \u0027test_url\u0027,"},{"line_number":85,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.NOT_FOUND)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        mock_db.assert_called_once_with(session, row, odl_const.COMPLETED)"},{"line_number":88,"context_line":"        self.assertFalse(resp)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_68ad5e30","line":85,"range":{"start_line":85,"start_character":13,"end_line":85,"end_character":26},"updated":"2017-08-18 16:40:22.000000000","message":"to_send should be the json data, unfortunately there is no test atm which is doing any test, it should be empty {} or dict of fake_data for create or update and in delete case it should be None","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"75282b437154fab4c1ab560c4a3ed3480ca64d54","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def test_handle_http_error_delete(self, mock_db):"},{"line_number":83,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":84,"context_line":"            \u0027delete\u0027, \u0027test_url\u0027,"},{"line_number":85,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.NOT_FOUND)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        mock_db.assert_called_once_with(session, row, odl_const.COMPLETED)"},{"line_number":88,"context_line":"        self.assertFalse(resp)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_a1eb4a10","line":85,"range":{"start_line":85,"start_character":13,"end_line":85,"end_character":26},"in_reply_to":"9f436f4f_68ad5e30","updated":"2017-08-21 06:06:11.000000000","message":"Done","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e96e364ca7aaa831e7acc431fa6a0bafe9c1f53c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def test_handle_http_error_post(self, mock_send_json):"},{"line_number":93,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":94,"context_line":"            \u0027post\u0027, \u0027test_url\u0027,"},{"line_number":95,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.CONFLICT)"},{"line_number":96,"context_line":"        self.assertTrue(resp)"},{"line_number":97,"context_line":"        mock_send_json.assert_called_once_with(\u0027put\u0027, \u0027test_url\u0027,"},{"line_number":98,"context_line":"                                               \u0027test_to_send\u0027, session, row)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_c839eaf2","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":26},"updated":"2017-08-18 16:40:22.000000000","message":"ditto here","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"75282b437154fab4c1ab560c4a3ed3480ca64d54","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def test_handle_http_error_post(self, mock_send_json):"},{"line_number":93,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":94,"context_line":"            \u0027post\u0027, \u0027test_url\u0027,"},{"line_number":95,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.CONFLICT)"},{"line_number":96,"context_line":"        self.assertTrue(resp)"},{"line_number":97,"context_line":"        mock_send_json.assert_called_once_with(\u0027put\u0027, \u0027test_url\u0027,"},{"line_number":98,"context_line":"                                               \u0027test_to_send\u0027, session, row)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_81f28605","line":95,"range":{"start_line":95,"start_character":13,"end_line":95,"end_character":26},"in_reply_to":"9f436f4f_c839eaf2","updated":"2017-08-21 06:06:11.000000000","message":"Done","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e96e364ca7aaa831e7acc431fa6a0bafe9c1f53c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def test_handle_http_error_put(self, mock_send_json):"},{"line_number":102,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":103,"context_line":"            \u0027put\u0027, \u0027test_url\u0027,"},{"line_number":104,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.NOT_FOUND)"},{"line_number":105,"context_line":"        mock_send_json.assert_called_once_with(\u0027post\u0027, \u0027test_url\u0027,"},{"line_number":106,"context_line":"                                               \u0027test_to_send\u0027, session, row)"},{"line_number":107,"context_line":"        self.assertTrue(resp)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_a344891c","line":104,"range":{"start_line":104,"start_character":13,"end_line":104,"end_character":26},"updated":"2017-08-18 16:40:22.000000000","message":"same as L85","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"75282b437154fab4c1ab560c4a3ed3480ca64d54","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def test_handle_http_error_put(self, mock_send_json):"},{"line_number":102,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":103,"context_line":"            \u0027put\u0027, \u0027test_url\u0027,"},{"line_number":104,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.NOT_FOUND)"},{"line_number":105,"context_line":"        mock_send_json.assert_called_once_with(\u0027post\u0027, \u0027test_url\u0027,"},{"line_number":106,"context_line":"                                               \u0027test_to_send\u0027, session, row)"},{"line_number":107,"context_line":"        self.assertTrue(resp)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_41dc9e73","line":104,"range":{"start_line":104,"start_character":13,"end_line":104,"end_character":26},"in_reply_to":"9f436f4f_a344891c","updated":"2017-08-21 06:06:11.000000000","message":"Done","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e96e364ca7aaa831e7acc431fa6a0bafe9c1f53c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                               \u0027test_to_send\u0027, session, row)"},{"line_number":107,"context_line":"        self.assertTrue(resp)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_sendjson\u0027,"},{"line_number":110,"context_line":"                       side_effect\u003dException())"},{"line_number":111,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"},{"line_number":112,"context_line":"    def test_handle_put_error(self, mock_db, mock_sendjson):"},{"line_number":113,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":114,"context_line":"            \u0027put\u0027, \u0027test_url\u0027,"},{"line_number":115,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.NOT_FOUND)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        mock_sendjson.assert_called_once_with(\u0027post\u0027, \u0027test_url\u0027,"},{"line_number":118,"context_line":"                                              \u0027test_to_send\u0027, session, row)"},{"line_number":119,"context_line":"        mock_db.assert_called_once_with(session, row, 5)"},{"line_number":120,"context_line":"        self.assertFalse(resp)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_sendjson\u0027)"},{"line_number":123,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_a32b692e","line":120,"range":{"start_line":109,"start_character":4,"end_line":120,"end_character":30},"updated":"2017-08-18 16:40:22.000000000","message":"this test again tests the test case on L100, I guess that redundant test can be removed.","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"75282b437154fab4c1ab560c4a3ed3480ca64d54","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                                               \u0027test_to_send\u0027, session, row)"},{"line_number":107,"context_line":"        self.assertTrue(resp)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_sendjson\u0027,"},{"line_number":110,"context_line":"                       side_effect\u003dException())"},{"line_number":111,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"},{"line_number":112,"context_line":"    def test_handle_put_error(self, mock_db, mock_sendjson):"},{"line_number":113,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":114,"context_line":"            \u0027put\u0027, \u0027test_url\u0027,"},{"line_number":115,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.NOT_FOUND)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        mock_sendjson.assert_called_once_with(\u0027post\u0027, \u0027test_url\u0027,"},{"line_number":118,"context_line":"                                              \u0027test_to_send\u0027, session, row)"},{"line_number":119,"context_line":"        mock_db.assert_called_once_with(session, row, 5)"},{"line_number":120,"context_line":"        self.assertFalse(resp)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_sendjson\u0027)"},{"line_number":123,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_218f5a2f","line":120,"range":{"start_line":109,"start_character":4,"end_line":120,"end_character":30},"in_reply_to":"9f436f4f_a32b692e","updated":"2017-08-21 06:06:11.000000000","message":"There is difference, L100 does not fail during _sendjson but this test raises exception and check return value also differ in both the case.","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e96e364ca7aaa831e7acc431fa6a0bafe9c1f53c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        mock_db.assert_called_once_with(session, row, 5)"},{"line_number":120,"context_line":"        self.assertFalse(resp)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_sendjson\u0027)"},{"line_number":123,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"},{"line_number":124,"context_line":"    def test_handle_http_error_no_delete_code_match(self, mock_db,"},{"line_number":125,"context_line":"                                                    mock_send_json):"},{"line_number":126,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":127,"context_line":"            \u0027delete\u0027, \u0027test_url\u0027,"},{"line_number":128,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.CONFLICT)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        mock_db.assert_called_once_with(session, row, 5)"},{"line_number":131,"context_line":"        self.assertFalse(resp)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_sendjson\u0027)"},{"line_number":134,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_631d810e","line":131,"range":{"start_line":122,"start_character":4,"end_line":131,"end_character":30},"updated":"2017-08-18 16:40:22.000000000","message":"what is the use of mock_send_json in this ?","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"75282b437154fab4c1ab560c4a3ed3480ca64d54","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        mock_db.assert_called_once_with(session, row, 5)"},{"line_number":120,"context_line":"        self.assertFalse(resp)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_sendjson\u0027)"},{"line_number":123,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"},{"line_number":124,"context_line":"    def test_handle_http_error_no_delete_code_match(self, mock_db,"},{"line_number":125,"context_line":"                                                    mock_send_json):"},{"line_number":126,"context_line":"        resp, session, row \u003d self._test_handle_http_error("},{"line_number":127,"context_line":"            \u0027delete\u0027, \u0027test_url\u0027,"},{"line_number":128,"context_line":"            \u0027test_to_send\u0027, requests.status_codes.codes.CONFLICT)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        mock_db.assert_called_once_with(session, row, 5)"},{"line_number":131,"context_line":"        self.assertFalse(resp)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_sendjson\u0027)"},{"line_number":134,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_019e9662","line":131,"range":{"start_line":122,"start_character":4,"end_line":131,"end_character":30},"in_reply_to":"9f436f4f_631d810e","updated":"2017-08-21 06:06:11.000000000","message":"Added the check.","commit_id":"334a99ee4ac1126ab7745876f2706fbeee9bc3ed"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"6d0750beaca10e90b1f9ad5152db6ef8e0e15214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7f287b81_348238ca","updated":"2017-08-22 09:38:06.000000000","message":"Missing tests for the logging functions. Trivial to add checks with assertLogs","commit_id":"d55e02fac89e262931a599b25b3823ccc61101d2"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"6d0750beaca10e90b1f9ad5152db6ef8e0e15214","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.assertTrue(resp)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @mock.patch.object(journal.OpenDaylightJournalThread, \u0027_sendjson\u0027,"},{"line_number":110,"context_line":"                       side_effect\u003dException())"},{"line_number":111,"context_line":"    @mock.patch(\u0027networking_odl.db.db.update_pending_db_row_retry\u0027)"},{"line_number":112,"context_line":"    def test_handle_put_error(self, mock_db, mock_sendjson):"},{"line_number":113,"context_line":"        resp, session, row \u003d self._test_handle_http_error("}],"source_content_type":"text/x-python","patch_set":15,"id":"7f287b81_54e144d0","line":110,"range":{"start_line":110,"start_character":35,"end_line":110,"end_character":46},"updated":"2017-08-22 09:38:06.000000000","message":"Related to the comments on journal.py","commit_id":"d55e02fac89e262931a599b25b3823ccc61101d2"}]}
