)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"13bc2e320f5c546fc4168635a635df5d7159f26b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1a1ced50_89d1195a","line":16,"updated":"2017-03-20 16:26:16.000000000","message":"closes-bug: #1633239","commit_id":"00b92d9d0184fefedddd56e78fb1313c1ddd292a"}],"networking_odl/tests/fullstack/machine.py":[{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"822c20785fa95bd401959fc2eb9bff39410093f3","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _create_ovs_vif_port(self, instance_id):"},{"line_number":96,"context_line":"        return utils.execute([\u0027ovs-vsctl\u0027, \u0027add-port\u0027, self.bridge,"},{"line_number":97,"context_line":"                              self.tap_id, \u0027--\u0027, \u0027set\u0027,"},{"line_number":98,"context_line":"                              \u0027Interface\u0027, self.tap_id,"},{"line_number":99,"context_line":"                              \u0027external-ids:iface-id\u003d%s\u0027 % self.port_id,"},{"line_number":100,"context_line":"                              \u0027external-ids:iface-status\u003dactive\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_4461a1a7","line":97,"range":{"start_line":97,"start_character":35,"end_line":97,"end_character":41},"updated":"2016-12-21 02:01:00.000000000","message":"since we are inserting an \"internal\" type of device not \"tap\" device, it would be better to call it \"interface\" or in short \"ifce\" or something like that to void possible confusion.","commit_id":"963aae8ab38e42ff8983779174570cda95debe08"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e133e604fe97a699150f633530c76677bb0782e4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class FakeMachineException(Exception):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    message \u003d _(\u0027Fail to establish fakeMachine %(namespace)s\u0027)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da4df55a_1523a2be","line":21,"range":{"start_line":21,"start_character":27,"end_line":21,"end_character":37},"updated":"2016-12-22 19:55:15.000000000","message":"NeutronException","commit_id":"82c91311c93c997888643e8db1eaac9bc623b9af"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"df98aa55b91bfac5d40b868aa063ec41ca9c3fdd","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def ip_cidr(self):"},{"line_number":77,"context_line":"        return self.port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027] + \u0027/24\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def set_mac_address(self):"},{"line_number":80,"context_line":"        utils.execute([\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, self.interface_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_a7d9bd85","line":77,"updated":"2017-03-08 08:29:38.000000000","message":"How about deducing the ip_cidr from ip and subnet? This hardcoding assumes the netmask is 24.","commit_id":"00b92d9d0184fefedddd56e78fb1313c1ddd292a"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"33ccbdef3ec14a1f634ec30818cba786787d7b1b","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def ip_cidr(self):"},{"line_number":77,"context_line":"        return self.port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027] + \u0027/24\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def set_mac_address(self):"},{"line_number":80,"context_line":"        utils.execute([\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, self.interface_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_75d766ed","line":77,"in_reply_to":"9a30ddce_27ba2dc1","updated":"2017-03-08 11:53:37.000000000","message":"I mean we can get the cidr information from the subnet you just created. And compose it with IP address you can get something like 192.168.1.1/24. Hardcoding the netmask to 24 will cause problems when someone else writes a test case later on and sets the netmask to something different than 24.","commit_id":"00b92d9d0184fefedddd56e78fb1313c1ddd292a"},{"author":{"_account_id":23972,"name":"yaxuanwang","email":"yaxuan.wang@intel.com","username":"yaxuanwang"},"change_message_id":"b07528d30628e155260d62149ada01b155bdc12d","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def ip_cidr(self):"},{"line_number":77,"context_line":"        return self.port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027] + \u0027/24\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def set_mac_address(self):"},{"line_number":80,"context_line":"        utils.execute([\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, self.interface_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_27ba2dc1","line":77,"in_reply_to":"9a30ddce_a7d9bd85","updated":"2017-03-08 08:41:39.000000000","message":"Then how could we execute \u0027ip address add ip_cidr dev dev_id\u0027 to set ip address of ports in namespace?","commit_id":"00b92d9d0184fefedddd56e78fb1313c1ddd292a"}],"networking_odl/tests/fullstack/test_mech_driver.py":[{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"822c20785fa95bd401959fc2eb9bff39410093f3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                              \u0027external-ids:vm-uuid\u003d%s\u0027 % instance_id,"},{"line_number":56,"context_line":"                              \u0027type\u003dtap\u0027], run_as_root\u003dTrue)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _new_update_requests(self, host_id, port_id):"},{"line_number":59,"context_line":"        data \u003d {\u0027port\u0027: {\u0027binding:host_id\u0027: host_id}}"},{"line_number":60,"context_line":"        req \u003d self.new_update_request(\u0027ports\u0027, data, port_id)"},{"line_number":61,"context_line":"        resp \u003d self.deserialize(self.fmt, req.get_response(self.api))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_24ff4502","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":28},"updated":"2016-12-21 02:01:00.000000000","message":"nit: s/requests/request/ should use singleton, after all we are sending only one request","commit_id":"963aae8ab38e42ff8983779174570cda95debe08"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"822c20785fa95bd401959fc2eb9bff39410093f3","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_requests(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"},{"line_number":104,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":105,"context_line":"        vm1.set_address()"},{"line_number":106,"context_line":"        mac \u003d vm1.mac_address"},{"line_number":107,"context_line":"        self.assertTrue(self._check_flow_existance(mac))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_4477e19e","line":104,"updated":"2016-12-21 02:01:00.000000000","message":"this assertion should be before L103","commit_id":"963aae8ab38e42ff8983779174570cda95debe08"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"822c20785fa95bd401959fc2eb9bff39410093f3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.2/24\u0027, port))"},{"line_number":113,"context_line":"        vif_type \u003d self._new_update_requests(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":114,"context_line":"        vm2._create_ovs_vif_port(uuidutils.generate_uuid())"},{"line_number":115,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":116,"context_line":"        vm2.set_address()"},{"line_number":117,"context_line":"        mac \u003d vm2.mac_address"},{"line_number":118,"context_line":"        self.assertTrue(self._check_flow_existance(mac))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_2482e552","line":115,"updated":"2016-12-21 02:01:00.000000000","message":"ditto","commit_id":"963aae8ab38e42ff8983779174570cda95debe08"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1f9e8d89815bf8d6fca6f56b1a0c61561a395b7b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_7a6248da","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"updated":"2016-12-21 23:06:41.000000000","message":"Is it difficult/troublesome to deduce value from port?","commit_id":"f87b28951a37fcde5a564d8df935c77297972c79"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"e59c73552628a79ece3c692236c981d61377dae9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_fb860ab8","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"updated":"2017-01-03 06:44:30.000000000","message":"Yaxuan, as Isaku already pointed out in a previous patchset, can we get the IP address out of the port that we just created? Instead of assigning a new one?","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8a48ee22ff4f5aeb0f8038b29547d8a80834334d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_8835b847","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"9a30ddce_5f1d660e","updated":"2017-03-07 23:05:39.000000000","message":"I wondered where this ip address came and I\u0027m wondering why this tests success without port_security_disabled\u003dtrue.\n_create_port accepts explicit ip address as fixed_ip.\nHow about explicitly specifying ip address?","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"c0b9bf7add816961d4e2698bb5f30f18ffbf9400","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_8378362d","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"9a30ddce_8835b847","updated":"2017-03-08 02:14:11.000000000","message":"Super class:\nhttps://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/test_plugin.py#L123\n\nSuper super class:\nhttps://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_db_base_plugin_v2.py#L105\n\nThe no valid extension manager is passed in super class setup, I guess port_security is not functional.","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"f9b12395e8934db5a460681849293947bd83b6db","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_5f1d660e","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"9a30ddce_e69e9b06","updated":"2017-03-07 05:13:13.000000000","message":"This is a test case to verify the flow table (L2) is correctly populated. Whether the L3 address is managed by neutron or by VM itself is irrelevant.","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":23972,"name":"yaxuanwang","email":"yaxuan.wang@intel.com","username":"yaxuanwang"},"change_message_id":"00a3f64a579ce913bff08b84ba2acaeddda69468","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_b44b5486","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"ba2be162_3f6038a5","updated":"2017-03-03 07:47:42.000000000","message":"Hi Isaku,\n\nSorry for the delay. I have carefully read relative codes of _create_port in test_db_base_plugin_v2 and printed out all information of the ports. In our case, there isn\u0027t any existing ip address information bound to ports, because they are created without subnet specified. For Rajiv\u0027s example, when creating the port, a subnet is defined first as argument, whose cidr is 10.0.0.0/24 by default. Thus, unless specify subnet when creating port, maybe we cannot get its cidr in this way.","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"bb31cf60c9d6712b23ebc16ad8cd01a5859311af","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_64d2185e","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"ba2be162_3f6038a5","updated":"2017-03-03 00:50:43.000000000","message":"I am not sure. The network is created without subnet which is allowed nowadays.\nIt was a shock to me in that in my mind I thought this patch had already been merged a while ago. I must have had been time traveling ...\nI will ping Yaxuan to revisit.","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"935d918003d4b2ee201b02c068f9a76cad3bb685","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_e69e9b06","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"ba2be162_629b9e66","updated":"2017-03-07 03:29:38.000000000","message":"I mean, \"is it necessary to fetch IP from created port, if it is not necessary then we can accept current approach. because subnets are being created?\".\n\nIsaku,\n\nWhat is your opinion on it?","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"c1982d1d82b5e77cb5113e275f563c633cdb4202","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_629b9e66","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"ba2be162_97181277","updated":"2017-03-06 01:07:21.000000000","message":"yes, the IP is required since we are doing VMs pinging each other.","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":23972,"name":"yaxuanwang","email":"yaxuan.wang@intel.com","username":"yaxuanwang"},"change_message_id":"00a3f64a579ce913bff08b84ba2acaeddda69468","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_9449f0b9","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"ba2be162_d322c800","updated":"2017-03-03 07:47:42.000000000","message":"Hi Rajiv,\n\nThanks for your comment. I have carefully read relative codes of _create_port in test_db_base_plugin_v2 and printed out all information of the ports. In our case, there isn\u0027t any existing ip address information bound to ports, because they are created without subnet specified. For your example, when creating the port, a subnet is defined first as argument, whose cidr is 10.0.0.0/24 by default. Thus, unless specify subnet when creating port, maybe we cannot get its cidr in this way.","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5b25c6e9a5f0b752e9b705d63a5519284f101cb7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_3f6038a5","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"ba2be162_d322c800","updated":"2017-03-02 18:41:51.000000000","message":"port -\u003e fixed_ips -\u003e subnet -\u003e cidr?","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"5937f87fca3e5761da9411c5aa2bce4417589524","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_97181277","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"ba5201f7_ec7600d6","updated":"2017-03-03 08:42:03.000000000","message":"Hi Rui,\n\nIs IP address from the port is really required for this test? i mean, is it really required to fetch ip like that, i think current way is ok because no subnet is being created(as per comment).","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":23972,"name":"yaxuanwang","email":"yaxuan.wang@intel.com","username":"yaxuanwang"},"change_message_id":"00a3f64a579ce913bff08b84ba2acaeddda69468","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_ec7600d6","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"ba5201f7_fb860ab8","updated":"2017-03-03 07:47:42.000000000","message":"Hi Rui,\n\nSorry for the delay. But I have checked the port created by _create_port, there isn\u0027t any existing ip address information bound to it. Also, similar test cases in Neutron set up ip for subnet manually as well. Thus, probably setting ip here should be easier.","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"747cef404e2e7c8a64a87c0aedd501df5731c3b6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        port \u003d self._create_port(self.fmt, net_id)"},{"line_number":99,"context_line":"        port \u003d self.deserialize(self.fmt, port)"},{"line_number":100,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":101,"context_line":"            \u0027br-int\u0027, \u0027192.168.1.1/24\u0027, port))"},{"line_number":102,"context_line":"        vif_type \u003d self._new_update_request(host_id, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":103,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":104,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_d322c800","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":37},"in_reply_to":"ba5201f7_fb860ab8","updated":"2017-03-02 14:18:08.000000000","message":"Hi Rui,\n\nWe can get IP of the port from port as done here https://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_db_base_plugin_v2.py#L1979. but i don\u0027t know how to get netmask. Do you have any idea?","commit_id":"1b1850afa4815d82d5792b62e9319ed4697f2a0b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ebd9261867510923a97f2402998e28d9abef6584","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        fixed_ips1 \u003d [{\u0027ip_address\u0027: \u0027192.168.1.1\u0027}]"},{"line_number":102,"context_line":"        port1 \u003d self._create_port(self.fmt,"},{"line_number":103,"context_line":"                                  net_id,"},{"line_number":104,"context_line":"                                  fixed_ips\u003dfixed_ips1)"},{"line_number":105,"context_line":"        port1 \u003d self.deserialize(self.fmt, port1)"},{"line_number":106,"context_line":"        vm1 \u003d self.useFixture(machine.FakeMachine("},{"line_number":107,"context_line":"            \u0027br-int\u0027, port1))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_0b928157","line":104,"range":{"start_line":104,"start_character":34,"end_line":104,"end_character":54},"updated":"2017-03-08 16:56:12.000000000","message":"Oh now subnet is created so we know it\u0027s ip address ranges and netasmk.\nSo we don\u0027t have to pass fix-ip to _create_port.","commit_id":"00b92d9d0184fefedddd56e78fb1313c1ddd292a"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ebd9261867510923a97f2402998e28d9abef6584","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027br-int\u0027, port1))"},{"line_number":108,"context_line":"        vif_type \u003d self._new_update_request(host_id, port1[\u0027port\u0027][\u0027id\u0027])"},{"line_number":109,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":110,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"},{"line_number":111,"context_line":"        vm1.set_address()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        fixed_ips2 \u003d [{\u0027ip_address\u0027: \u0027192.168.1.2\u0027}]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_8b62f1ab","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":32},"updated":"2017-03-08 16:56:12.000000000","message":"This only add a port name to br-int in ovsdb.\nIt doesn\u0027t create any actual network interface in linux kernel. we need to create veth pair and connect one peer to br-int and other peer to namespace.\nThis logic would go into fakevm.","commit_id":"00b92d9d0184fefedddd56e78fb1313c1ddd292a"},{"author":{"_account_id":23972,"name":"yaxuanwang","email":"yaxuan.wang@intel.com","username":"yaxuanwang"},"change_message_id":"d89828c364f8a62ceb11da3bbd928302036a2c26","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027br-int\u0027, port1))"},{"line_number":108,"context_line":"        vif_type \u003d self._new_update_request(host_id, port1[\u0027port\u0027][\u0027id\u0027])"},{"line_number":109,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":110,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"},{"line_number":111,"context_line":"        vm1.set_address()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        fixed_ips2 \u003d [{\u0027ip_address\u0027: \u0027192.168.1.2\u0027}]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_fb7bbbf2","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":32},"in_reply_to":"9a30ddce_8b62f1ab","updated":"2017-03-13 03:24:46.000000000","message":"After the execution of \"ovs-vsctl add-port br-int tapXXX..\" in _create_ovs_vif_port, the tap device named tapXXX will be created in linux kernel, which can be listed by \"ip link list\". At first, we tried to use a veth pair to connect br-int and namespace and it worked. Later we found that by specifying tap type\u003dinternal, we could also get two namespaces ping each other, which is also done in this function.","commit_id":"00b92d9d0184fefedddd56e78fb1313c1ddd292a"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f818e0ab6c13a7515549ac37dec1abe313bc3739","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027br-int\u0027, port1))"},{"line_number":108,"context_line":"        vif_type \u003d self._new_update_request(host_id, port1[\u0027port\u0027][\u0027id\u0027])"},{"line_number":109,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":110,"context_line":"        vm1._create_ovs_vif_port(uuidutils.generate_uuid())"},{"line_number":111,"context_line":"        vm1.set_address()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        fixed_ips2 \u003d [{\u0027ip_address\u0027: \u0027192.168.1.2\u0027}]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a1ff146_2bbb0b74","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":32},"in_reply_to":"9a30ddce_fb7bbbf2","updated":"2017-03-15 00:50:07.000000000","message":"Oh, you\u0027re right. ovs create internal vport inside kernel.\nI scratch that.","commit_id":"00b92d9d0184fefedddd56e78fb1313c1ddd292a"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ebd9261867510923a97f2402998e28d9abef6584","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            \u0027br-int\u0027, port2))"},{"line_number":120,"context_line":"        vif_type \u003d self._new_update_request(host_id, port2[\u0027port\u0027][\u0027id\u0027])"},{"line_number":121,"context_line":"        self.assertEqual(\u0027ovs\u0027, vif_type)"},{"line_number":122,"context_line":"        vm2._create_ovs_vif_port(uuidutils.generate_uuid())"},{"line_number":123,"context_line":"        vm2.set_address()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        # Step3: test ping"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_8bd75122","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":32},"updated":"2017-03-08 16:56:12.000000000","message":"ditto.","commit_id":"00b92d9d0184fefedddd56e78fb1313c1ddd292a"}]}
