)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"beae2add176b40331dc6144d6fc06cf58ccbdf5c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"OVN Driver: https://review.openstack.org/gitweb?p\u003dopenstack/networking-ovn.git;a\u003dblob;f\u003dnetworking_ovn/ml2/trunk_driver.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2656ea175174239b0f70d8daa36896c9e9c9cd5a"},{"line_number":19,"context_line":"Signed-off-by: Vishal Thapar \u003cvishal.thapar@ericsson.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a3c09a3_c58fceca","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":57},"updated":"2017-01-18 23:40:57.000000000","message":"Please drop sob because openstack doesn\u0027t adopt it.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":16,"context_line":"OVN Driver: https://review.openstack.org/gitweb?p\u003dopenstack/networking-ovn.git;a\u003dblob;f\u003dnetworking_ovn/ml2/trunk_driver.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2656ea175174239b0f70d8daa36896c9e9c9cd5a"},{"line_number":19,"context_line":"Signed-off-by: Vishal Thapar \u003cvishal.thapar@ericsson.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a3c09a3_e224c0b3","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":57},"updated":"2017-01-18 23:40:38.000000000","message":"Please drop sob because openstack doesn\u0027t adopt it.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":16,"context_line":"OVN Driver: https://review.openstack.org/gitweb?p\u003dopenstack/networking-ovn.git;a\u003dblob;f\u003dnetworking_ovn/ml2/trunk_driver.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2656ea175174239b0f70d8daa36896c9e9c9cd5a"},{"line_number":19,"context_line":"Signed-off-by: Vishal Thapar \u003cvishal.thapar@ericsson.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a3905b3_aa03760e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":57},"in_reply_to":"7a3c09a3_c58fceca","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3020a7f00229a7059a43b102f2d60c96d60547a5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"OVN Driver: https://review.openstack.org/gitweb?p\u003dopenstack/networking-ovn.git;a\u003dblob;f\u003dnetworking_ovn/ml2/trunk_driver.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2656ea175174239b0f70d8daa36896c9e9c9cd5a"},{"line_number":19,"context_line":"Signed-off-by: Vishal Thapar \u003cvishal.thapar@ericsson.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a3c09a3_f0b9eacc","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":57},"in_reply_to":"7a3c09a3_c58fceca","updated":"2017-01-19 00:24:51.000000000","message":"Will do. ODL habit carried over.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a3c09a3_c25ee411","line":20,"updated":"2017-01-18 23:40:38.000000000","message":"please use tags, closes-bug and implements.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"beae2add176b40331dc6144d6fc06cf58ccbdf5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a3c09a3_e5ba0a71","line":20,"updated":"2017-01-18 23:40:57.000000000","message":"please use tags, closes-bug and implements.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5a3905b3_c5fef504","line":20,"in_reply_to":"7a3c09a3_e5ba0a71","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3020a7f00229a7059a43b102f2d60c96d60547a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a3c09a3_30b452d0","line":20,"in_reply_to":"7a3c09a3_e5ba0a71","updated":"2017-01-19 00:24:51.000000000","message":"So just bug and bp tags and add all references to bp?","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a4f820c4d104216cb160bb9d81e04e022fa0adcf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds the v1 and v2 drivers for Vlan Aware VMs [TrunkPorts]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1656902"},{"line_number":12,"context_line":"Implements: blueprint vlan-aware-vm-support-opendaylight"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2656ea175174239b0f70d8daa36896c9e9c9cd5a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a3905b3_a5fed735","line":12,"range":{"start_line":12,"start_character":56,"end_line":12,"end_character":56},"updated":"2017-01-21 02:57:51.000000000","message":"Please keep the links to API.","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"cb384c6da13558a89326aa598f8a2e51ee591108","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This adds the v1 and v2 drivers for Vlan Aware VMs [TrunkPorts]"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1656902"},{"line_number":12,"context_line":"Implements: blueprint vlan-aware-vm-support-opendaylight"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2656ea175174239b0f70d8daa36896c9e9c9cd5a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a3905b3_46d7f84a","line":12,"range":{"start_line":12,"start_character":56,"end_line":12,"end_character":56},"in_reply_to":"5a3905b3_a5fed735","updated":"2017-01-21 08:39:30.000000000","message":"Done","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"}],"devstack/README.rst":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a4f820c4d104216cb160bb9d81e04e022fa0adcf","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        \u003e cat local.conf"},{"line_number":129,"context_line":"        [[local|localrc]]"},{"line_number":130,"context_line":"        ODL_LEGACY_NETVIRT_CONNTRACK\u003dTrue"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"14. Note: Enable Vlan Aware VMs (Trunk) with OpenDaylight Backend"},{"line_number":133,"context_line":"    enable the trunk service plugin by adding trunk to service_plugins::"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a3905b3_65714fe0","line":131,"updated":"2017-01-21 02:57:51.000000000","message":"also please release notes please.\nhttp://docs.openstack.org/developer/reno/usage.html","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"cb384c6da13558a89326aa598f8a2e51ee591108","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        \u003e cat local.conf"},{"line_number":129,"context_line":"        [[local|localrc]]"},{"line_number":130,"context_line":"        ODL_LEGACY_NETVIRT_CONNTRACK\u003dTrue"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"14. Note: Enable Vlan Aware VMs (Trunk) with OpenDaylight Backend"},{"line_number":133,"context_line":"    enable the trunk service plugin by adding trunk to service_plugins::"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a3905b3_c695a887","line":131,"in_reply_to":"5a3905b3_65714fe0","updated":"2017-01-21 08:39:30.000000000","message":"Done","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"87f90c615404f945b804161d974382497fcc2070","unresolved":false,"context_lines":[{"line_number":82,"context_line":"11. Note: Enable Quality Of Service (QoS) with OpenDaylight Backend"},{"line_number":83,"context_line":"    enable the qos service plugin by adding qos to service_plugins::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"      \u003e in /etc/neutron/neutron.conf"},{"line_number":86,"context_line":"      service_plugins \u003d qos, odl-router"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    enable notification driver in neutron.conf::"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a3905b3_f714c2e9","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":39},"updated":"2017-01-24 01:02:04.000000000","message":"can neutron_service_plugin_class_add be used?","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d179587feba5d6946a4c2656e9e44094daca2601","unresolved":false,"context_lines":[{"line_number":82,"context_line":"11. Note: Enable Quality Of Service (QoS) with OpenDaylight Backend"},{"line_number":83,"context_line":"    enable the qos service plugin by adding qos to service_plugins::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"      \u003e in /etc/neutron/neutron.conf"},{"line_number":86,"context_line":"      service_plugins \u003d qos, odl-router"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    enable notification driver in neutron.conf::"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a3905b3_052f4fa1","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":39},"in_reply_to":"5a3905b3_f714c2e9","updated":"2017-01-24 05:42:21.000000000","message":"For QoS yes, probably makes sense to have ODL_QOS\u003dTrue and it sets both these parameters.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"87f90c615404f945b804161d974382497fcc2070","unresolved":false,"context_lines":[{"line_number":132,"context_line":"14. Note: Enable Vlan Aware VMs (Trunk) with OpenDaylight Backend"},{"line_number":133,"context_line":"    enable the trunk service plugin by adding trunk to service_plugins::"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      \u003e in /etc/neutron/neutron.conf"},{"line_number":136,"context_line":"      service_plugins \u003d trunk, odl-router"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    V1 or V2 version of trunk driver will be determined by which version"},{"line_number":139,"context_line":"    of ML2 mechanism driver is configured, no extra configuration required."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a3905b3_7728d233","line":136,"range":{"start_line":135,"start_character":0,"end_line":136,"end_character":41},"updated":"2017-01-24 01:02:04.000000000","message":"Can neutron_service_plugin_class_add be used?","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d179587feba5d6946a4c2656e9e44094daca2601","unresolved":false,"context_lines":[{"line_number":132,"context_line":"14. Note: Enable Vlan Aware VMs (Trunk) with OpenDaylight Backend"},{"line_number":133,"context_line":"    enable the trunk service plugin by adding trunk to service_plugins::"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"      \u003e in /etc/neutron/neutron.conf"},{"line_number":136,"context_line":"      service_plugins \u003d trunk, odl-router"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    V1 or V2 version of trunk driver will be determined by which version"},{"line_number":139,"context_line":"    of ML2 mechanism driver is configured, no extra configuration required."}],"source_content_type":"text/x-rst","patch_set":14,"id":"5a3905b3_853a5fe5","line":136,"range":{"start_line":135,"start_character":0,"end_line":136,"end_character":41},"in_reply_to":"5a3905b3_7728d233","updated":"2017-01-24 05:42:21.000000000","message":"Q_SERVICE_PLUGIN_CLASSES\u003dtrunk works fine enough. This way we don\u0027t need an extra ODL_TRUNK flag either. For trunks we have no explicit service provider/driver configuration, so this should be good enough?","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"}],"networking_odl/common/client.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        \"\"\"Wrapper method for sendjson()\"\"\""},{"line_number":108,"context_line":"        obj_id \u003d data[\u0027id\u0027]"},{"line_number":109,"context_line":"        base_path \u003d object_type + \u0027s\u0027"},{"line_number":110,"context_line":"        if service_type is not None:"},{"line_number":111,"context_line":"            base_path \u003d service_type + \u0027/\u0027 + base_path"},{"line_number":112,"context_line":"        if operation \u003d\u003d odl_const.ODL_DELETE:"},{"line_number":113,"context_line":"            urlpath \u003d base_path + \u0027/\u0027 + obj_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_452afe2d","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":35},"updated":"2017-01-18 23:40:38.000000000","message":"Why is this needed?\ntrunkv2 driver passes \"trunk\"","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3020a7f00229a7059a43b102f2d60c96d60547a5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        \"\"\"Wrapper method for sendjson()\"\"\""},{"line_number":108,"context_line":"        obj_id \u003d data[\u0027id\u0027]"},{"line_number":109,"context_line":"        base_path \u003d object_type + \u0027s\u0027"},{"line_number":110,"context_line":"        if service_type is not None:"},{"line_number":111,"context_line":"            base_path \u003d service_type + \u0027/\u0027 + base_path"},{"line_number":112,"context_line":"        if operation \u003d\u003d odl_const.ODL_DELETE:"},{"line_number":113,"context_line":"            urlpath \u003d base_path + \u0027/\u0027 + obj_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_f061eaa9","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":35},"in_reply_to":"7a3c09a3_452afe2d","updated":"2017-01-19 00:24:51.000000000","message":"This is used by SFC. service_type is \u0027sfc\u0027 so it comes as \u0027sfc/flow-classifiers\u0027 etc. If I use trunk as service type it will be \u0027trunk/trunks/uuid/\u0027","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"}],"networking_odl/journal/dependency_validations.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    return True"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def validate_port_operation(session, row):"},{"line_number":92,"context_line":"    \"\"\"Validate port operation based on dependencies."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    Validate port operation depending on whether it\u0027s dependencies"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_25d092c9","line":91,"range":{"start_line":91,"start_character":4,"end_line":91,"end_character":27},"updated":"2017-01-18 23:40:38.000000000","message":"port operation has dependency on trunk.\nIs it difficult to detect this reasonably?","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3020a7f00229a7059a43b102f2d60c96d60547a5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    return True"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def validate_port_operation(session, row):"},{"line_number":92,"context_line":"    \"\"\"Validate port operation based on dependencies."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    Validate port operation depending on whether it\u0027s dependencies"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_108116fc","line":91,"range":{"start_line":91,"start_character":4,"end_line":91,"end_character":27},"in_reply_to":"7a3c09a3_25d092c9","updated":"2017-01-19 00:24:51.000000000","message":"will have to make a db query on all pending_or_processing trunks and then cycle through to find if any has this port as port_id.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # Check for pending or processing parent port operations"},{"line_number":225,"context_line":"        if db.check_for_pending_or_processing_ops("},{"line_number":226,"context_line":"                session, pport_id, seqnum\u003drow.seqnum):"},{"line_number":227,"context_line":"            return False"},{"line_number":228,"context_line":"    elif (row.operation \u003d\u003d odl_const.ODL_UPDATE):"},{"line_number":229,"context_line":"        # Update means sub_port add/delete"},{"line_number":230,"context_line":"        if not _is_valid_update_operation(session, row):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_c5734e14","line":227,"updated":"2017-01-18 23:40:38.000000000","message":"subport is also needs to be checked.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # Check for pending or processing parent port operations"},{"line_number":225,"context_line":"        if db.check_for_pending_or_processing_ops("},{"line_number":226,"context_line":"                session, pport_id, seqnum\u003drow.seqnum):"},{"line_number":227,"context_line":"            return False"},{"line_number":228,"context_line":"    elif (row.operation \u003d\u003d odl_const.ODL_UPDATE):"},{"line_number":229,"context_line":"        # Update means sub_port add/delete"},{"line_number":230,"context_line":"        if not _is_valid_update_operation(session, row):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_fbfd526f","line":227,"in_reply_to":"7a3c09a3_c5734e14","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3020a7f00229a7059a43b102f2d60c96d60547a5","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # Check for pending or processing parent port operations"},{"line_number":225,"context_line":"        if db.check_for_pending_or_processing_ops("},{"line_number":226,"context_line":"                session, pport_id, seqnum\u003drow.seqnum):"},{"line_number":227,"context_line":"            return False"},{"line_number":228,"context_line":"    elif (row.operation \u003d\u003d odl_const.ODL_UPDATE):"},{"line_number":229,"context_line":"        # Update means sub_port add/delete"},{"line_number":230,"context_line":"        if not _is_valid_update_operation(session, row):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_b0eda2f1","line":227,"in_reply_to":"7a3c09a3_c5734e14","updated":"2017-01-19 00:24:51.000000000","message":"will do. didn\u0027t realize subport can be configured at trunk creation itself.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            return False"},{"line_number":232,"context_line":"        \"\"\" check for pending or processing child port operations"},{"line_number":233,"context_line":"            this may have performance issues"},{"line_number":234,"context_line":"        \"\"\""},{"line_number":235,"context_line":"        for cport_id in [subport[\u0027port_id\u0027] for"},{"line_number":236,"context_line":"                         subport in row.data[\"sub_ports\"]]:"},{"line_number":237,"context_line":"            if db.check_for_pending_or_processing_ops(session,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_05647647","line":234,"updated":"2017-01-18 23:40:38.000000000","message":"primary port is also needs to be checked.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            return False"},{"line_number":232,"context_line":"        \"\"\" check for pending or processing child port operations"},{"line_number":233,"context_line":"            this may have performance issues"},{"line_number":234,"context_line":"        \"\"\""},{"line_number":235,"context_line":"        for cport_id in [subport[\u0027port_id\u0027] for"},{"line_number":236,"context_line":"                         subport in row.data[\"sub_ports\"]]:"},{"line_number":237,"context_line":"            if db.check_for_pending_or_processing_ops(session,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_3bf8ba7c","line":234,"in_reply_to":"7a3c09a3_05647647","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"87f90c615404f945b804161d974382497fcc2070","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    Validate port operation depending on whether it\u0027s dependencies"},{"line_number":95,"context_line":"    are still in \u0027pending\u0027 or \u0027processing\u0027 state. e.g."},{"line_number":96,"context_line":"    \"\"\""},{"line_number":97,"context_line":"    if row.operation in (odl_const.ODL_CREATE, odl_const.ODL_UPDATE):"},{"line_number":98,"context_line":"        network_id \u003d row.data[\u0027network_id\u0027]"},{"line_number":99,"context_line":"        # Check for pending or processing network operations"},{"line_number":100,"context_line":"        ops \u003d db.check_for_pending_or_processing_ops("}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_37a72abe","line":97,"range":{"start_line":97,"start_character":25,"end_line":97,"end_character":67},"updated":"2017-01-24 01:02:04.000000000","message":"if this port is associated with trunk, we need to wait for it.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"c8f3fb2ae34bcc2ea5ef1e448ec697ce7a01cb46","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    Validate port operation depending on whether it\u0027s dependencies"},{"line_number":95,"context_line":"    are still in \u0027pending\u0027 or \u0027processing\u0027 state. e.g."},{"line_number":96,"context_line":"    \"\"\""},{"line_number":97,"context_line":"    if row.operation in (odl_const.ODL_CREATE, odl_const.ODL_UPDATE):"},{"line_number":98,"context_line":"        network_id \u003d row.data[\u0027network_id\u0027]"},{"line_number":99,"context_line":"        # Check for pending or processing network operations"},{"line_number":100,"context_line":"        ops \u003d db.check_for_pending_or_processing_ops("}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_579ddbba","line":97,"range":{"start_line":97,"start_character":25,"end_line":97,"end_character":67},"in_reply_to":"3a461143_5c818dc2","updated":"2017-01-28 12:32:24.000000000","message":"Done. Added TODO","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d179587feba5d6946a4c2656e9e44094daca2601","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    Validate port operation depending on whether it\u0027s dependencies"},{"line_number":95,"context_line":"    are still in \u0027pending\u0027 or \u0027processing\u0027 state. e.g."},{"line_number":96,"context_line":"    \"\"\""},{"line_number":97,"context_line":"    if row.operation in (odl_const.ODL_CREATE, odl_const.ODL_UPDATE):"},{"line_number":98,"context_line":"        network_id \u003d row.data[\u0027network_id\u0027]"},{"line_number":99,"context_line":"        # Check for pending or processing network operations"},{"line_number":100,"context_line":"        ops \u003d db.check_for_pending_or_processing_ops("}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_45bf9760","line":97,"range":{"start_line":97,"start_character":25,"end_line":97,"end_character":67},"in_reply_to":"5a3905b3_37a72abe","updated":"2017-01-24 05:42:21.000000000","message":"Port is parent of trunk, so it will not have dependency on trunk, just as we don\u0027t wait for subnet on network or subnet on port create/update. Only dependency is port to be created before trunk is created and that is already covered in trunk creation. test validations cover these scenarios.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a123f0bd60b157d1c1b4695eae7bfd1a74d3882d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    Validate port operation depending on whether it\u0027s dependencies"},{"line_number":95,"context_line":"    are still in \u0027pending\u0027 or \u0027processing\u0027 state. e.g."},{"line_number":96,"context_line":"    \"\"\""},{"line_number":97,"context_line":"    if row.operation in (odl_const.ODL_CREATE, odl_const.ODL_UPDATE):"},{"line_number":98,"context_line":"        network_id \u003d row.data[\u0027network_id\u0027]"},{"line_number":99,"context_line":"        # Check for pending or processing network operations"},{"line_number":100,"context_line":"        ops \u003d db.check_for_pending_or_processing_ops("}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_5c818dc2","line":97,"range":{"start_line":97,"start_character":25,"end_line":97,"end_character":67},"in_reply_to":"5a3905b3_45bf9760","updated":"2017-01-27 21:23:04.000000000","message":"For example, what about the following scenario\ntrunk update: admin_state_up\u003ddown\nport update: admin_state_up\u003dup\n\nIn this casen we don\u0027t want portupdate is processed before trunk update.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"87f90c615404f945b804161d974382497fcc2070","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            session, row.object_uuid, operation\u003d[odl_const.ODL_UPDATE,"},{"line_number":247,"context_line":"                                                 odl_const.ODL_CREATE]):"},{"line_number":248,"context_line":"            return False"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    return True"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"_VALIDATION_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_f799227a","line":249,"updated":"2017-01-24 01:02:04.000000000","message":"in delete case, there is a dependency on port/subport too.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"c8f3fb2ae34bcc2ea5ef1e448ec697ce7a01cb46","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            session, row.object_uuid, operation\u003d[odl_const.ODL_UPDATE,"},{"line_number":247,"context_line":"                                                 odl_const.ODL_CREATE]):"},{"line_number":248,"context_line":"            return False"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    return True"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"_VALIDATION_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_77a2d7fe","line":249,"in_reply_to":"3a461143_fc723910","updated":"2017-01-28 12:32:24.000000000","message":"Done","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a123f0bd60b157d1c1b4695eae7bfd1a74d3882d","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            session, row.object_uuid, operation\u003d[odl_const.ODL_UPDATE,"},{"line_number":247,"context_line":"                                                 odl_const.ODL_CREATE]):"},{"line_number":248,"context_line":"            return False"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    return True"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"_VALIDATION_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_fc723910","line":249,"in_reply_to":"5a3905b3_0593cffa","updated":"2017-01-27 21:23:04.000000000","message":"Oh got it. Can you please add some comment on it.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d179587feba5d6946a4c2656e9e44094daca2601","unresolved":false,"context_lines":[{"line_number":246,"context_line":"            session, row.object_uuid, operation\u003d[odl_const.ODL_UPDATE,"},{"line_number":247,"context_line":"                                                 odl_const.ODL_CREATE]):"},{"line_number":248,"context_line":"            return False"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    return True"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"_VALIDATION_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_0593cffa","line":249,"in_reply_to":"5a3905b3_f799227a","updated":"2017-01-24 05:42:21.000000000","message":"subport delete is trunk update so already covered. trunk delete can happen even if there is pending port CRUD, trunk delete just means disassociation. Again, similar to port delete where we don\u0027t check for pending subnet or network deletes.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"9ec0fd85f2f58700a4ab6b87ab50d571dc4cb138","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    \"\"\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    if row.operation in (odl_const.ODL_CREATE, odl_const.ODL_UPDATE):"},{"line_number":211,"context_line":"        if (row.operation \u003d\u003d odl_const.ODL_UPDATE):"},{"line_number":212,"context_line":"            # Update means sub_port add/delete. Any other Trunk updates"},{"line_number":213,"context_line":"            # are currently not supported."},{"line_number":214,"context_line":"            if not _is_valid_update_operation(session, row):"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_18eab60f","line":211,"range":{"start_line":211,"start_character":11,"end_line":211,"end_character":12},"updated":"2017-02-07 00:40:35.000000000","message":"nit: paren isn\u0027t needed.","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b94206685549ae3b781e8182c12ee04b35b37dcf","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    \"\"\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    if row.operation in (odl_const.ODL_CREATE, odl_const.ODL_UPDATE):"},{"line_number":211,"context_line":"        if (row.operation \u003d\u003d odl_const.ODL_UPDATE):"},{"line_number":212,"context_line":"            # Update means sub_port add/delete. Any other Trunk updates"},{"line_number":213,"context_line":"            # are currently not supported."},{"line_number":214,"context_line":"            if not _is_valid_update_operation(session, row):"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_db302804","line":211,"range":{"start_line":211,"start_character":11,"end_line":211,"end_character":12},"in_reply_to":"1a430d35_18eab60f","updated":"2017-02-07 01:44:21.000000000","message":"Done","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"49b8f857f51071f1bbc354001be4dc9664a65cc0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            odl_const.ODL_ROUTER),"},{"line_number":129,"context_line":"    odl_const.ODL_SUBNET: (odl_const.ODL_PORT,),"},{"line_number":130,"context_line":"    odl_const.ODL_ROUTER: (odl_const.ODL_PORT, odl_const.ODL_FLOATINGIP),"},{"line_number":131,"context_line":"    odl_const.ODL_PORT: (odl_const.ODL_TRUNK),"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"1a430d35_ca4a0b26","line":131,"range":{"start_line":131,"start_character":44,"end_line":131,"end_character":45},"updated":"2017-02-07 07:57:05.000000000","message":"\",\" (comma) is need to make this tuple.\nSee line 129.","commit_id":"0348570f0c2d81536397999f0e7b1773ed52da93"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"aa22c28c07fa3f8e7de9143a9ee305f6b5d245d8","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            odl_const.ODL_ROUTER),"},{"line_number":129,"context_line":"    odl_const.ODL_SUBNET: (odl_const.ODL_PORT,),"},{"line_number":130,"context_line":"    odl_const.ODL_ROUTER: (odl_const.ODL_PORT, odl_const.ODL_FLOATINGIP),"},{"line_number":131,"context_line":"    odl_const.ODL_PORT: (odl_const.ODL_TRUNK),"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"1a430d35_cacdab86","line":131,"range":{"start_line":131,"start_character":44,"end_line":131,"end_character":45},"in_reply_to":"1a430d35_ca4a0b26","updated":"2017-02-07 08:05:51.000000000","message":"Done. I wasn\u0027t sure of it and asked of it in Mike\u0027s review. But it passed units and functional both, how come?","commit_id":"0348570f0c2d81536397999f0e7b1773ed52da93"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"14d8f55f0793eabc0f61c461cda6dcca9062ccc4","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            odl_const.ODL_ROUTER),"},{"line_number":129,"context_line":"    odl_const.ODL_SUBNET: (odl_const.ODL_PORT,),"},{"line_number":130,"context_line":"    odl_const.ODL_ROUTER: (odl_const.ODL_PORT, odl_const.ODL_FLOATINGIP),"},{"line_number":131,"context_line":"    odl_const.ODL_PORT: (odl_const.ODL_TRUNK),"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"1a430d35_0df983c7","line":131,"range":{"start_line":131,"start_character":44,"end_line":131,"end_character":45},"in_reply_to":"1a430d35_cacdab86","updated":"2017-02-07 12:18:56.000000000","message":"There\u0027s no unit tests to cover this but its a good idea to add such a test to the port tests.\n\nFunctional tests test sync with ODL so they wouldn\u0027t cover such a case either..","commit_id":"0348570f0c2d81536397999f0e7b1773ed52da93"}],"networking_odl/tests/functional/test_trunk_drivers.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"562f53e0adfb1b51c4dec9fde0b9e1f63843d01e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    self.context, trunk[\u0027trunk\u0027][\u0027id\u0027],"},{"line_number":40,"context_line":"                    {\u0027sub_ports\u0027: [subport]})"},{"line_number":41,"context_line":"                response \u003d self.get_odl_resource(odl_const.ODL_TRUNK,"},{"line_number":42,"context_line":"                                                 {\u0027trunk\u0027: trunk_obj})"},{"line_number":43,"context_line":"                self.assertEqual(response[\u0027trunk\u0027][\u0027sub_ports\u0027][0][\u0027port_id\u0027],"},{"line_number":44,"context_line":"                                 subport[\u0027port_id\u0027])"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_4378ef2b","line":42,"range":{"start_line":42,"start_character":49,"end_line":42,"end_character":69},"updated":"2017-02-06 16:03:34.000000000","message":"Can\u0027t you send trunk here?","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"ca93dd6f3acf7494d6415fee372ec15927359dd5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    self.context, trunk[\u0027trunk\u0027][\u0027id\u0027],"},{"line_number":40,"context_line":"                    {\u0027sub_ports\u0027: [subport]})"},{"line_number":41,"context_line":"                response \u003d self.get_odl_resource(odl_const.ODL_TRUNK,"},{"line_number":42,"context_line":"                                                 {\u0027trunk\u0027: trunk_obj})"},{"line_number":43,"context_line":"                self.assertEqual(response[\u0027trunk\u0027][\u0027sub_ports\u0027][0][\u0027port_id\u0027],"},{"line_number":44,"context_line":"                                 subport[\u0027port_id\u0027])"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_9045b171","line":42,"range":{"start_line":42,"start_character":49,"end_line":42,"end_character":69},"in_reply_to":"1a430d35_4378ef2b","updated":"2017-02-06 16:40:13.000000000","message":"1) Either I missed changing it when I refactored before pushing, or 2) it was because trunk didn\u0027t have appended subports. Probably 1), in which case will reuse. If not it means 2).","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"f5119a526a60eee33df96224fe41031ae07c2fab","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    self.context, trunk[\u0027trunk\u0027][\u0027id\u0027],"},{"line_number":40,"context_line":"                    {\u0027sub_ports\u0027: [subport]})"},{"line_number":41,"context_line":"                response \u003d self.get_odl_resource(odl_const.ODL_TRUNK,"},{"line_number":42,"context_line":"                                                 {\u0027trunk\u0027: trunk_obj})"},{"line_number":43,"context_line":"                self.assertEqual(response[\u0027trunk\u0027][\u0027sub_ports\u0027][0][\u0027port_id\u0027],"},{"line_number":44,"context_line":"                                 subport[\u0027port_id\u0027])"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_c8cdc55e","line":42,"range":{"start_line":42,"start_character":49,"end_line":42,"end_character":69},"in_reply_to":"1a430d35_9045b171","updated":"2017-02-06 21:39:38.000000000","message":"It was 2), trunk is the non updated trunk that we passed to plugin, trunk_obj is returned object with subport updates, so can\u0027t use trunk here.","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"562f53e0adfb1b51c4dec9fde0b9e1f63843d01e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def test_subport_delete(self):"},{"line_number":47,"context_line":"        with self.subport() as subport:"},{"line_number":48,"context_line":"            with self.trunk([subport]) as trunk:"},{"line_number":49,"context_line":"                trunk_obj \u003d self.trunk_plugin.remove_subports("},{"line_number":50,"context_line":"                    self.context, trunk[\u0027trunk\u0027][\u0027id\u0027],"},{"line_number":51,"context_line":"                    {\u0027sub_ports\u0027: [subport]})"},{"line_number":52,"context_line":"                response \u003d self.get_odl_resource(odl_const.ODL_TRUNK,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_43caaf6f","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":62},"updated":"2017-02-06 16:03:34.000000000","message":"I\u0027d add a get \u0026 assert before the removal to see that the subport is there","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"f5119a526a60eee33df96224fe41031ae07c2fab","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def test_subport_delete(self):"},{"line_number":47,"context_line":"        with self.subport() as subport:"},{"line_number":48,"context_line":"            with self.trunk([subport]) as trunk:"},{"line_number":49,"context_line":"                trunk_obj \u003d self.trunk_plugin.remove_subports("},{"line_number":50,"context_line":"                    self.context, trunk[\u0027trunk\u0027][\u0027id\u0027],"},{"line_number":51,"context_line":"                    {\u0027sub_ports\u0027: [subport]})"},{"line_number":52,"context_line":"                response \u003d self.get_odl_resource(odl_const.ODL_TRUNK,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_08efcdb0","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":62},"in_reply_to":"1a430d35_3055dd1c","updated":"2017-02-06 21:39:38.000000000","message":"Done","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"ca93dd6f3acf7494d6415fee372ec15927359dd5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def test_subport_delete(self):"},{"line_number":47,"context_line":"        with self.subport() as subport:"},{"line_number":48,"context_line":"            with self.trunk([subport]) as trunk:"},{"line_number":49,"context_line":"                trunk_obj \u003d self.trunk_plugin.remove_subports("},{"line_number":50,"context_line":"                    self.context, trunk[\u0027trunk\u0027][\u0027id\u0027],"},{"line_number":51,"context_line":"                    {\u0027sub_ports\u0027: [subport]})"},{"line_number":52,"context_line":"                response \u003d self.get_odl_resource(odl_const.ODL_TRUNK,"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_3055dd1c","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":62},"in_reply_to":"1a430d35_43caaf6f","updated":"2017-02-06 16:40:13.000000000","message":"Good point. will do.","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"562f53e0adfb1b51c4dec9fde0b9e1f63843d01e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            yield subport"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class TestTrunkV2Driver(base.V2DriverAdjustment, _TrunkDriverTest,"},{"line_number":86,"context_line":"                        test_plugin.Ml2PluginV2TestCase):"},{"line_number":87,"context_line":"    _mechanism_drivers \u003d [\u0027opendaylight_v2\u0027]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_016fba2b","line":85,"range":{"start_line":85,"start_character":6,"end_line":85,"end_character":23},"updated":"2017-02-06 16:03:34.000000000","message":"You should add V1 driver tests also","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"ca93dd6f3acf7494d6415fee372ec15927359dd5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            yield subport"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class TestTrunkV2Driver(base.V2DriverAdjustment, _TrunkDriverTest,"},{"line_number":86,"context_line":"                        test_plugin.Ml2PluginV2TestCase):"},{"line_number":87,"context_line":"    _mechanism_drivers \u003d [\u0027opendaylight_v2\u0027]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_701cc577","line":85,"range":{"start_line":85,"start_character":6,"end_line":85,"end_character":23},"in_reply_to":"1a430d35_016fba2b","updated":"2017-02-06 16:40:13.000000000","message":"will do. but would you consider the must have or can they come in once this is merged? I\u0027d like to prioritize getting other v2 drivers ready if possible.","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"f5119a526a60eee33df96224fe41031ae07c2fab","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            yield subport"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class TestTrunkV2Driver(base.V2DriverAdjustment, _TrunkDriverTest,"},{"line_number":86,"context_line":"                        test_plugin.Ml2PluginV2TestCase):"},{"line_number":87,"context_line":"    _mechanism_drivers \u003d [\u0027opendaylight_v2\u0027]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_482f15f6","line":85,"range":{"start_line":85,"start_character":6,"end_line":85,"end_character":23},"in_reply_to":"1a430d35_469633f1","updated":"2017-02-06 21:39:38.000000000","message":"Done. Forgot how simple it was :)","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"24664287ab759351ef784bf193e5dad7b63b3a72","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            yield subport"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class TestTrunkV2Driver(base.V2DriverAdjustment, _TrunkDriverTest,"},{"line_number":86,"context_line":"                        test_plugin.Ml2PluginV2TestCase):"},{"line_number":87,"context_line":"    _mechanism_drivers \u003d [\u0027opendaylight_v2\u0027]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_469633f1","line":85,"range":{"start_line":85,"start_character":6,"end_line":85,"end_character":23},"in_reply_to":"1a430d35_701cc577","updated":"2017-02-06 17:07:57.000000000","message":"Not a must have but OTOH it should be just a few LOC if you look at how its done in existing tests.\n\nI won\u0027t block this patch merely on this if you can\u0027t get it to work right now.","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"9ec0fd85f2f58700a4ab6b87ab50d571dc4cb138","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                                 {\u0027trunk\u0027: trunk_obj})"},{"line_number":43,"context_line":"                self.assertEqual(response[\u0027trunk\u0027][\u0027sub_ports\u0027][0][\u0027port_id\u0027],"},{"line_number":44,"context_line":"                                 subport[\u0027port_id\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_subport_delete(self):"},{"line_number":47,"context_line":"        with self.subport() as subport:"},{"line_number":48,"context_line":"            with self.trunk([subport]) as trunk:"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_f8c08a2c","line":45,"updated":"2017-02-07 00:40:35.000000000","message":"test_trunk_update() is necessary.","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"}],"networking_odl/tests/unit/journal/test_dependency_validations.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"fbd7ca0cf604ee7595d17a9c843cc643a7bdd0b4","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    )"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def get_data(res_type, op):"},{"line_number":250,"context_line":"    if res_type \u003d\u003d const.ODL_PORT:"},{"line_number":251,"context_line":"        return port_data"},{"line_number":252,"context_line":"    if res_type \u003d\u003d const.ODL_TRUNK:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_7cb741d8","line":249,"range":{"start_line":249,"start_character":4,"end_line":249,"end_character":12},"updated":"2017-02-06 16:14:30.000000000","message":"Probably should be named _trunk_data?","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"f5119a526a60eee33df96224fe41031ae07c2fab","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    )"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def get_data(res_type, op):"},{"line_number":250,"context_line":"    if res_type \u003d\u003d const.ODL_PORT:"},{"line_number":251,"context_line":"        return port_data"},{"line_number":252,"context_line":"    if res_type \u003d\u003d const.ODL_TRUNK:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_287ac9f1","line":249,"range":{"start_line":249,"start_character":4,"end_line":249,"end_character":12},"in_reply_to":"1a430d35_06318b05","updated":"2017-02-06 21:39:38.000000000","message":"Done, but used trunk_data instead of _trunk_data, similar to other methods.","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"24664287ab759351ef784bf193e5dad7b63b3a72","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    )"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def get_data(res_type, op):"},{"line_number":250,"context_line":"    if res_type \u003d\u003d const.ODL_PORT:"},{"line_number":251,"context_line":"        return port_data"},{"line_number":252,"context_line":"    if res_type \u003d\u003d const.ODL_TRUNK:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_06318b05","line":249,"range":{"start_line":249,"start_character":4,"end_line":249,"end_character":12},"in_reply_to":"1a430d35_13646be2","updated":"2017-02-06 17:07:57.000000000","message":"I think for now better make it specific to this driver and if another driver can reuse it then refactor it there.\n\nNot critical though we can always rename this later on if we see it doesn\u0027t fit so I won\u0027t block the patch just for this.","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"ca93dd6f3acf7494d6415fee372ec15927359dd5","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    )"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def get_data(res_type, op):"},{"line_number":250,"context_line":"    if res_type \u003d\u003d const.ODL_PORT:"},{"line_number":251,"context_line":"        return port_data"},{"line_number":252,"context_line":"    if res_type \u003d\u003d const.ODL_TRUNK:"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_13646be2","line":249,"range":{"start_line":249,"start_character":4,"end_line":249,"end_character":12},"in_reply_to":"1a430d35_7cb741d8","updated":"2017-02-06 16:40:13.000000000","message":"yeah, but was thinking about making this a common one that will be reused for, say, l2gw, bgpvpn etc. This will make it easier to reuse fields like port_id, network_id etc. Thoughts? Am okay either ways.","commit_id":"3fe8cced6544a5fd0633a50c0ca2a3fa5dbe7fd8"}],"networking_odl/tests/unit/trunk/test_trunk_driver_v1.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def setUp(self):"},{"line_number":54,"context_line":"        self.useFixture(odl_base.OpenDaylightRestClientFixture())"},{"line_number":55,"context_line":"        super(TestTrunkHandler, self).setUp()"},{"line_number":56,"context_line":"        self.context \u003d mock.Mock()"},{"line_number":57,"context_line":"        self.plugin_driver \u003d mock.Mock()"},{"line_number":58,"context_line":"        self.handler \u003d (trunk_driver."},{"line_number":59,"context_line":"                        OpenDaylightTrunkHandlerV1(self.plugin_driver))"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_653e1a2b","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":40},"updated":"2017-01-18 23:40:38.000000000","message":"they aren\u0027t needed.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def setUp(self):"},{"line_number":54,"context_line":"        self.useFixture(odl_base.OpenDaylightRestClientFixture())"},{"line_number":55,"context_line":"        super(TestTrunkHandler, self).setUp()"},{"line_number":56,"context_line":"        self.context \u003d mock.Mock()"},{"line_number":57,"context_line":"        self.plugin_driver \u003d mock.Mock()"},{"line_number":58,"context_line":"        self.handler \u003d (trunk_driver."},{"line_number":59,"context_line":"                        OpenDaylightTrunkHandlerV1(self.plugin_driver))"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_453a05cf","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":40},"in_reply_to":"7a3c09a3_653e1a2b","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                        OpenDaylightTrunkHandlerV1(self.plugin_driver))"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _fake_trunk_event_payload(self):"},{"line_number":62,"context_line":"        payload \u003d mock.Mock()"},{"line_number":63,"context_line":"        payload.current_trunk \u003d mock.Mock()"},{"line_number":64,"context_line":"        payload.current_trunk.id \u003d \u0027fake_id\u0027"},{"line_number":65,"context_line":"        payload.current_trunk.status \u003d trunk_consts.DOWN_STATUS"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_a54802ce","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":29},"updated":"2017-01-18 23:40:38.000000000","message":"TrunkPayload can be used.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                        OpenDaylightTrunkHandlerV1(self.plugin_driver))"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _fake_trunk_event_payload(self):"},{"line_number":62,"context_line":"        payload \u003d mock.Mock()"},{"line_number":63,"context_line":"        payload.current_trunk \u003d mock.Mock()"},{"line_number":64,"context_line":"        payload.current_trunk.id \u003d \u0027fake_id\u0027"},{"line_number":65,"context_line":"        payload.current_trunk.status \u003d trunk_consts.DOWN_STATUS"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_8534edde","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":29},"in_reply_to":"7a3c09a3_a54802ce","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        cfg.CONF.set_override(\u0027core_plugin\u0027, \u0027some_plugin\u0027)"},{"line_number":116,"context_line":"        self.assertFalse(driver.is_loaded)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_register(self):"},{"line_number":119,"context_line":"        driver \u003d trunk_driver.OpenDaylightTrunkDriverV1.create()"},{"line_number":120,"context_line":"        with mock.patch.object(registry, \u0027subscribe\u0027) as mock_subscribe:"},{"line_number":121,"context_line":"            driver.register(mock.ANY, mock.ANY, mock.Mock())"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_86007eac","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":21},"updated":"2017-01-26 09:29:26.000000000","message":"I don\u0027t believe this test has any value, should be handled as part of func testing..","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1884c1bec6f7e845520689bf6065d91263c7a627","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        cfg.CONF.set_override(\u0027core_plugin\u0027, \u0027some_plugin\u0027)"},{"line_number":116,"context_line":"        self.assertFalse(driver.is_loaded)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_register(self):"},{"line_number":119,"context_line":"        driver \u003d trunk_driver.OpenDaylightTrunkDriverV1.create()"},{"line_number":120,"context_line":"        with mock.patch.object(registry, \u0027subscribe\u0027) as mock_subscribe:"},{"line_number":121,"context_line":"            driver.register(mock.ANY, mock.ANY, mock.Mock())"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_4c2102b4","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":21},"in_reply_to":"3a461143_86007eac","updated":"2017-01-27 04:22:10.000000000","message":"Carried over from reference driver. will remove this.","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"}],"networking_odl/tests/unit/trunk/test_trunk_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def setUp(self):"},{"line_number":58,"context_line":"        super(TestTrunkHandler, self).setUp()"},{"line_number":59,"context_line":"        self.db_session \u003d neutron_db_api.get_session()"},{"line_number":60,"context_line":"        self.plugin_driver \u003d mock.Mock()"},{"line_number":61,"context_line":"        self.handler \u003d (trunk_driver."},{"line_number":62,"context_line":"                        OpenDaylightTrunkHandlerV2(self.plugin_driver))"},{"line_number":63,"context_line":"        self.mock_sync_thread \u003d mock.patch.object("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_0509d6dd","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":40},"updated":"2017-01-18 23:40:38.000000000","message":"we don\u0027t need this because it\u0027s not used anywhere.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def setUp(self):"},{"line_number":58,"context_line":"        super(TestTrunkHandler, self).setUp()"},{"line_number":59,"context_line":"        self.db_session \u003d neutron_db_api.get_session()"},{"line_number":60,"context_line":"        self.plugin_driver \u003d mock.Mock()"},{"line_number":61,"context_line":"        self.handler \u003d (trunk_driver."},{"line_number":62,"context_line":"                        OpenDaylightTrunkHandlerV2(self.plugin_driver))"},{"line_number":63,"context_line":"        self.mock_sync_thread \u003d mock.patch.object("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_c57355b3","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":40},"in_reply_to":"7a3c09a3_0509d6dd","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        return context"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _fake_trunk_event_payload(self):"},{"line_number":73,"context_line":"        payload \u003d mock.Mock()"},{"line_number":74,"context_line":"        payload.trunk_id \u003d \u0027fake_id\u0027"},{"line_number":75,"context_line":"        payload.context \u003d self._get_mock_context()"},{"line_number":76,"context_line":"        payload.current_trunk \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_45b4bed0","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":29},"updated":"2017-01-18 23:40:38.000000000","message":"neutron.services.trunk.callback.TrunkPayload can be used. no need to use mock.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        return context"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _fake_trunk_event_payload(self):"},{"line_number":73,"context_line":"        payload \u003d mock.Mock()"},{"line_number":74,"context_line":"        payload.trunk_id \u003d \u0027fake_id\u0027"},{"line_number":75,"context_line":"        payload.context \u003d self._get_mock_context()"},{"line_number":76,"context_line":"        payload.current_trunk \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_656541e0","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":29},"in_reply_to":"7a3c09a3_45b4bed0","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.assertEqual(None, row)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_trunk_events(self):"},{"line_number":109,"context_line":"        for event in (events.PRECOMMIT_CREATE, events.AFTER_CREATE,"},{"line_number":110,"context_line":"                      events.PRECOMMIT_DELETE, events.AFTER_DELETE):"},{"line_number":111,"context_line":"            self._test_event(trunk_consts.TRUNK, event)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_subport_events(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_c5ed0ef1","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":68},"updated":"2017-01-18 23:40:38.000000000","message":"testscenario can be used.\nfor example, please refer to ml2/test_mechanism_odl_v2.py","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.assertEqual(None, row)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_trunk_events(self):"},{"line_number":109,"context_line":"        for event in (events.PRECOMMIT_CREATE, events.AFTER_CREATE,"},{"line_number":110,"context_line":"                      events.PRECOMMIT_DELETE, events.AFTER_DELETE):"},{"line_number":111,"context_line":"            self._test_event(trunk_consts.TRUNK, event)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_subport_events(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_bb302a09","line":110,"range":{"start_line":109,"start_character":0,"end_line":110,"end_character":68},"in_reply_to":"7a3c09a3_c5ed0ef1","updated":"2017-01-19 09:44:16.000000000","message":"Took a look but didn\u0027t understand it well, need to spend some more time to understand it. Will do it later if okay with you? Subsequent patch?","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"87f90c615404f945b804161d974382497fcc2070","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.db_session \u003d neutron_db_api.get_session()"},{"line_number":61,"context_line":"        self.handler \u003d (trunk_driver."},{"line_number":62,"context_line":"                        OpenDaylightTrunkHandlerV2())"},{"line_number":63,"context_line":"        self.thread \u003d journal.OpendaylightJournalThread()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_mock_context(self):"},{"line_number":66,"context_line":"        context \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_37d64a4f","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":57},"updated":"2017-01-24 01:02:04.000000000","message":"creating journal thread causes non-determinism.\nPlease don\u0027t create and call run_sync_thread directly.\nPlease refer to test_mechanism_odl_v2.py or test_odl_l3.py.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d179587feba5d6946a4c2656e9e44094daca2601","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.db_session \u003d neutron_db_api.get_session()"},{"line_number":61,"context_line":"        self.handler \u003d (trunk_driver."},{"line_number":62,"context_line":"                        OpenDaylightTrunkHandlerV2())"},{"line_number":63,"context_line":"        self.thread \u003d journal.OpendaylightJournalThread()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_mock_context(self):"},{"line_number":66,"context_line":"        context \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_a514bb4c","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":57},"in_reply_to":"5a3905b3_37d64a4f","updated":"2017-01-24 05:42:21.000000000","message":"Cool, wanted to ask about it as it was causing issues with coverage. will do.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"eb3d412e87e724ee1eaed6158090f5e375d830f9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.db_session \u003d neutron_db_api.get_session()"},{"line_number":61,"context_line":"        self.handler \u003d (trunk_driver."},{"line_number":62,"context_line":"                        OpenDaylightTrunkHandlerV2())"},{"line_number":63,"context_line":"        self.thread \u003d journal.OpendaylightJournalThread()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_mock_context(self):"},{"line_number":66,"context_line":"        context \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a3905b3_a23f48b2","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":57},"in_reply_to":"5a3905b3_37d64a4f","updated":"2017-01-24 09:09:59.000000000","message":"sync_thread is already mocked in OpenDaylightConfigBase. Shouldn\u0027t that be enough?","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a123f0bd60b157d1c1b4695eae7bfd1a74d3882d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.db_session \u003d neutron_db_api.get_session()"},{"line_number":61,"context_line":"        self.handler \u003d (trunk_driver."},{"line_number":62,"context_line":"                        OpenDaylightTrunkHandlerV2())"},{"line_number":63,"context_line":"        self.thread \u003d journal.OpendaylightJournalThread()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _get_mock_context(self):"},{"line_number":66,"context_line":"        context \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":14,"id":"3a461143_9c56955a","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":57},"in_reply_to":"5a3905b3_a23f48b2","updated":"2017-01-27 21:23:04.000000000","message":"Oh I missed that.","commit_id":"35cb1e20ab2e199e9938ecf5222d9f0b9b7195d6"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        cfg.CONF.set_override(\u0027core_plugin\u0027, \u0027some_plugin\u0027)"},{"line_number":132,"context_line":"        self.assertFalse(driver.is_loaded)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_register(self):"},{"line_number":135,"context_line":"        driver \u003d trunk_driver.OpenDaylightTrunkDriverV2.create()"},{"line_number":136,"context_line":"        with mock.patch.object(registry, \u0027subscribe\u0027) as mock_subscribe:"},{"line_number":137,"context_line":"            driver.register(mock.ANY, mock.ANY, mock.Mock())"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_c1da4978","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":21},"updated":"2017-01-26 09:29:26.000000000","message":"Same as for the v1 driver","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"}],"networking_odl/trunk/trunk_driver_v1.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class OpenDaylightTrunkHandlerV1(object):"},{"line_number":50,"context_line":"    def __init__(self, plugin_driver):"},{"line_number":51,"context_line":"        self.plugin_driver \u003d plugin_driver"},{"line_number":52,"context_line":"        self.client \u003d odl_client.OpenDaylightRestClient.create_client()"},{"line_number":53,"context_line":"        LOG.info(_LI(\u0027initialized trunk driver for OpendayLight\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_02a54cb4","line":50,"range":{"start_line":50,"start_character":23,"end_line":50,"end_character":36},"updated":"2017-01-18 23:40:38.000000000","message":"I don\u0027t see plugin_driver used. So we can drop plugin_driver.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class OpenDaylightTrunkHandlerV1(object):"},{"line_number":50,"context_line":"    def __init__(self, plugin_driver):"},{"line_number":51,"context_line":"        self.plugin_driver \u003d plugin_driver"},{"line_number":52,"context_line":"        self.client \u003d odl_client.OpenDaylightRestClient.create_client()"},{"line_number":53,"context_line":"        LOG.info(_LI(\u0027initialized trunk driver for OpendayLight\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_db1c167a","line":50,"range":{"start_line":50,"start_character":23,"end_line":50,"end_character":36},"in_reply_to":"7a3c09a3_02a54cb4","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            registry.subscribe(self._handler.subport_event,"},{"line_number":109,"context_line":"                               t_consts.SUBPORTS,"},{"line_number":110,"context_line":"                               event)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @classmethod"},{"line_number":113,"context_line":"    def create(cls, plugin_driver):"},{"line_number":114,"context_line":"        cls.plugin_driver \u003d plugin_driver"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_c21c24c4","line":111,"updated":"2017-01-18 23:40:38.000000000","message":"trunk_update_postcommit needs to be connected to AFTER_UPDATE event.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3020a7f00229a7059a43b102f2d60c96d60547a5","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            registry.subscribe(self._handler.subport_event,"},{"line_number":109,"context_line":"                               t_consts.SUBPORTS,"},{"line_number":110,"context_line":"                               event)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @classmethod"},{"line_number":113,"context_line":"    def create(cls, plugin_driver):"},{"line_number":114,"context_line":"        cls.plugin_driver \u003d plugin_driver"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_6b36ebe8","line":111,"in_reply_to":"7a3c09a3_c21c24c4","updated":"2017-01-19 00:24:51.000000000","message":"There are no updates on trunk. API only supports add/delete on trunks and subports. only updates that come are subport add/delete. subports can\u0027t be modified either. I added event for trunk updates also, ended up getting duplicate events for subports as well as when we set status. I felt it would add unnecessary overhead. Can consider if run into any scenario where trunk can be updated? probably state but we\u0027re the ones who set it.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a4f820c4d104216cb160bb9d81e04e022fa0adcf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from networking_odl._i18n import _LI"},{"line_number":29,"context_line":"from networking_odl.common import client as odl_client"},{"line_number":30,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SUPPORTED_INTERFACES \u003d ("},{"line_number":33,"context_line":"    portbindings.VIF_TYPE_OVS,"},{"line_number":34,"context_line":"    portbindings.VIF_TYPE_VHOST_USER,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_a55a574e","line":31,"updated":"2017-01-21 02:57:51.000000000","message":"pep8: two blank lines.","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"cb384c6da13558a89326aa598f8a2e51ee591108","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from networking_odl._i18n import _LI"},{"line_number":29,"context_line":"from networking_odl.common import client as odl_client"},{"line_number":30,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SUPPORTED_INTERFACES \u003d ("},{"line_number":33,"context_line":"    portbindings.VIF_TYPE_OVS,"},{"line_number":34,"context_line":"    portbindings.VIF_TYPE_VHOST_USER,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_068c107e","line":31,"in_reply_to":"5a3905b3_a55a574e","updated":"2017-01-21 08:39:30.000000000","message":"Done","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a4f820c4d104216cb160bb9d81e04e022fa0adcf","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":56,"context_line":"        trunk_dict \u003d trunk.to_dict()"},{"line_number":57,"context_line":"        try:"},{"line_number":58,"context_line":"            self.client.send_request(odl_const.ODL_CREATE, None,"},{"line_number":59,"context_line":"                                     odl_const.ODL_TRUNK, trunk_dict)"},{"line_number":60,"context_line":"        except Exception:"},{"line_number":61,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_253587f6","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":36},"updated":"2017-01-21 02:57:51.000000000","message":"Please use sendjson.","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"cb384c6da13558a89326aa598f8a2e51ee591108","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":56,"context_line":"        trunk_dict \u003d trunk.to_dict()"},{"line_number":57,"context_line":"        try:"},{"line_number":58,"context_line":"            self.client.send_request(odl_const.ODL_CREATE, None,"},{"line_number":59,"context_line":"                                     odl_const.ODL_TRUNK, trunk_dict)"},{"line_number":60,"context_line":"        except Exception:"},{"line_number":61,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_26ebcc14","line":58,"range":{"start_line":58,"start_character":24,"end_line":58,"end_character":36},"in_reply_to":"5a3905b3_253587f6","updated":"2017-01-21 08:39:30.000000000","message":"Done","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a4f820c4d104216cb160bb9d81e04e022fa0adcf","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def trunk_delete_postcommit(self, trunk):"},{"line_number":65,"context_line":"        trunk_dict \u003d trunk.to_dict()"},{"line_number":66,"context_line":"        self.client.send_request(odl_const.ODL_DELETE, None,"},{"line_number":67,"context_line":"                                 odl_const.ODL_TRUNK, trunk_dict)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def trunk_update_postcommit(self, original, updated):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_453c53e2","line":66,"range":{"start_line":66,"start_character":20,"end_line":66,"end_character":32},"updated":"2017-01-21 02:57:51.000000000","message":"please use try_delete()","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"cb384c6da13558a89326aa598f8a2e51ee591108","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def trunk_delete_postcommit(self, trunk):"},{"line_number":65,"context_line":"        trunk_dict \u003d trunk.to_dict()"},{"line_number":66,"context_line":"        self.client.send_request(odl_const.ODL_DELETE, None,"},{"line_number":67,"context_line":"                                 odl_const.ODL_TRUNK, trunk_dict)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def trunk_update_postcommit(self, original, updated):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_46f0d8fe","line":66,"range":{"start_line":66,"start_character":20,"end_line":66,"end_character":32},"in_reply_to":"5a3905b3_453c53e2","updated":"2017-01-21 08:39:30.000000000","message":"Done","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a4f820c4d104216cb160bb9d81e04e022fa0adcf","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                               event)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def create(cls, plugin_driver):"},{"line_number":113,"context_line":"        cls.plugin_driver \u003d plugin_driver"},{"line_number":114,"context_line":"        return cls(odl_const.ODL_ML2_MECH_DRIVER_V1,"},{"line_number":115,"context_line":"                   SUPPORTED_INTERFACES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_a52177b6","line":112,"range":{"start_line":112,"start_character":20,"end_line":112,"end_character":33},"updated":"2017-01-21 02:57:51.000000000","message":"this isn\u0027t necessary.","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"cb384c6da13558a89326aa598f8a2e51ee591108","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                               event)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def create(cls, plugin_driver):"},{"line_number":113,"context_line":"        cls.plugin_driver \u003d plugin_driver"},{"line_number":114,"context_line":"        return cls(odl_const.ODL_ML2_MECH_DRIVER_V1,"},{"line_number":115,"context_line":"                   SUPPORTED_INTERFACES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_86f640f7","line":112,"range":{"start_line":112,"start_character":20,"end_line":112,"end_character":33},"in_reply_to":"5a3905b3_a52177b6","updated":"2017-01-21 08:39:30.000000000","message":"Done","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a4f820c4d104216cb160bb9d81e04e022fa0adcf","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def create(cls, plugin_driver):"},{"line_number":113,"context_line":"        cls.plugin_driver \u003d plugin_driver"},{"line_number":114,"context_line":"        return cls(odl_const.ODL_ML2_MECH_DRIVER_V1,"},{"line_number":115,"context_line":"                   SUPPORTED_INTERFACES,"},{"line_number":116,"context_line":"                   SUPPORTED_SEGMENTATION_TYPES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_c5304304","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":25},"updated":"2017-01-21 02:57:51.000000000","message":"this isn\u0027t used.","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"cb384c6da13558a89326aa598f8a2e51ee591108","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def create(cls, plugin_driver):"},{"line_number":113,"context_line":"        cls.plugin_driver \u003d plugin_driver"},{"line_number":114,"context_line":"        return cls(odl_const.ODL_ML2_MECH_DRIVER_V1,"},{"line_number":115,"context_line":"                   SUPPORTED_INTERFACES,"},{"line_number":116,"context_line":"                   SUPPORTED_SEGMENTATION_TYPES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_a6dfbc67","line":113,"range":{"start_line":113,"start_character":12,"end_line":113,"end_character":25},"in_reply_to":"5a3905b3_c5304304","updated":"2017-01-21 08:39:30.000000000","message":"Done","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"# from oslo_log import helpers as log_helpers"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":"from oslo_utils import excutils"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_4ffcf13e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":45},"updated":"2017-01-26 09:29:26.000000000","message":"nit: delete this line","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1884c1bec6f7e845520689bf6065d91263c7a627","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"# from oslo_log import helpers as log_helpers"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":"from oslo_utils import excutils"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_ec12ae61","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":45},"in_reply_to":"3a461143_4ffcf13e","updated":"2017-01-27 04:22:10.000000000","message":"Done","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            self.client.sendjson(\u0027put\u0027, url,"},{"line_number":76,"context_line":"                                 {odl_const.ODL_TRUNK: trunk_dict})"},{"line_number":77,"context_line":"        except Exception:"},{"line_number":78,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":79,"context_line":"                updated.update(status\u003dt_consts.DEGRADED_STATUS)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def trunk_event(self, resource, event, trunk_plugin, payload):"},{"line_number":82,"context_line":"        if event \u003d\u003d events.AFTER_CREATE:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_e6c942ae","line":79,"range":{"start_line":78,"start_character":12,"end_line":79,"end_character":63},"updated":"2017-01-26 09:29:26.000000000","message":"How do you plan to achieve this behavior with V2 type driver?","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"42e683edc475f3943d1188e56e97edd6c576fa95","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            self.client.sendjson(\u0027put\u0027, url,"},{"line_number":76,"context_line":"                                 {odl_const.ODL_TRUNK: trunk_dict})"},{"line_number":77,"context_line":"        except Exception:"},{"line_number":78,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":79,"context_line":"                updated.update(status\u003dt_consts.DEGRADED_STATUS)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def trunk_event(self, resource, event, trunk_plugin, payload):"},{"line_number":82,"context_line":"        if event \u003d\u003d events.AFTER_CREATE:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_dc565d29","line":79,"range":{"start_line":78,"start_character":12,"end_line":79,"end_character":63},"in_reply_to":"3a461143_8719037c","updated":"2017-01-27 21:31:33.000000000","message":"Right now websocket patch is WIP.\nhttps://review.openstack.org/#/c/421127/\n\nWith the patch and following patches, ODL will be able to notify networking-odl on state change on neutron resource.\nIt\u0027ll be addressed in Pike cycle.","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"117a03c4259a546e401f92360db12ca3796f795d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            self.client.sendjson(\u0027put\u0027, url,"},{"line_number":76,"context_line":"                                 {odl_const.ODL_TRUNK: trunk_dict})"},{"line_number":77,"context_line":"        except Exception:"},{"line_number":78,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":79,"context_line":"                updated.update(status\u003dt_consts.DEGRADED_STATUS)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def trunk_event(self, resource, event, trunk_plugin, payload):"},{"line_number":82,"context_line":"        if event \u003d\u003d events.AFTER_CREATE:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_37b5af30","line":79,"range":{"start_line":78,"start_character":12,"end_line":79,"end_character":63},"in_reply_to":"3a461143_dc565d29","updated":"2017-01-28 12:32:41.000000000","message":"Done. Added TODO for this in v2 as not sure we\u0027re going to support v1 in longer term.","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1884c1bec6f7e845520689bf6065d91263c7a627","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            self.client.sendjson(\u0027put\u0027, url,"},{"line_number":76,"context_line":"                                 {odl_const.ODL_TRUNK: trunk_dict})"},{"line_number":77,"context_line":"        except Exception:"},{"line_number":78,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":79,"context_line":"                updated.update(status\u003dt_consts.DEGRADED_STATUS)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def trunk_event(self, resource, event, trunk_plugin, payload):"},{"line_number":82,"context_line":"        if event \u003d\u003d events.AFTER_CREATE:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_8719037c","line":79,"range":{"start_line":78,"start_character":12,"end_line":79,"end_character":63},"in_reply_to":"3a461143_e6c942ae","updated":"2017-01-27 04:22:10.000000000","message":"That is tricky part and I brought it up in ODL meeting. Ideally, it should be set based on if ODL was able to process it without errors or not, which can be best achieved once we have callback from ODL. Other option could be to set it to BUILDING as long as it is still pending and when it is done callback neutron to update status. Not sure how either of them can be achieved and would appreciate inputs on this. Currently going with ACTIVE on postcommit in v2. Something to improve upon in future. Should I add a TODO in v2 for this?","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"9ec0fd85f2f58700a4ab6b87ab50d571dc4cb138","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        url \u003d odl_const.ODL_TRUNKS + \u0027/\u0027 + trunk_dict[\u0027id\u0027]"},{"line_number":58,"context_line":"        self.client.try_delete(url)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def trunk_update_postcommit(self, original, updated):"},{"line_number":61,"context_line":"        updated.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":62,"context_line":"        trunk_dict \u003d updated.to_dict()"},{"line_number":63,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_1838f69f","line":60,"range":{"start_line":60,"start_character":38,"end_line":60,"end_character":47},"updated":"2017-02-07 00:40:35.000000000","message":"This argument isn\u0027t used.","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b94206685549ae3b781e8182c12ee04b35b37dcf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        url \u003d odl_const.ODL_TRUNKS + \u0027/\u0027 + trunk_dict[\u0027id\u0027]"},{"line_number":58,"context_line":"        self.client.try_delete(url)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def trunk_update_postcommit(self, original, updated):"},{"line_number":61,"context_line":"        updated.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":62,"context_line":"        trunk_dict \u003d updated.to_dict()"},{"line_number":63,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_b6f533cc","line":60,"range":{"start_line":60,"start_character":38,"end_line":60,"end_character":47},"in_reply_to":"1a430d35_1838f69f","updated":"2017-02-07 01:44:21.000000000","message":"Done","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"}],"networking_odl/trunk/trunk_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.services.trunk.drivers import base as trunk_base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from networking_odl._i18n import _LI"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from networking_odl.common import config as odl_conf"},{"line_number":30,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_a55482ca","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":0},"updated":"2017-01-18 23:40:38.000000000","message":"nitpick: pep8. no blank line.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.services.trunk.drivers import base as trunk_base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from networking_odl._i18n import _LI"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from networking_odl.common import config as odl_conf"},{"line_number":30,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_a5b6493b","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":0},"in_reply_to":"7a3c09a3_a55482ca","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from networking_odl.common import config as odl_conf"},{"line_number":30,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from networking_odl.journal import journal"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_INTERFACES \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_2557b2cb","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":0},"updated":"2017-01-18 23:40:38.000000000","message":"nitpick: pep8. no blank line.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from networking_odl.common import config as odl_conf"},{"line_number":30,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from networking_odl.journal import journal"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_INTERFACES \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_e5869164","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":0},"in_reply_to":"7a3c09a3_2557b2cb","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from networking_odl.journal import journal"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_INTERFACES \u003d ("},{"line_number":35,"context_line":"    portbindings.VIF_TYPE_OVS,"},{"line_number":36,"context_line":"    portbindings.VIF_TYPE_VHOST_USER,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_6571ba77","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":0},"updated":"2017-01-18 23:40:38.000000000","message":"nitpick:pep8. two blank lines.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from networking_odl.journal import journal"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"SUPPORTED_INTERFACES \u003d ("},{"line_number":35,"context_line":"    portbindings.VIF_TYPE_OVS,"},{"line_number":36,"context_line":"    portbindings.VIF_TYPE_VHOST_USER,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_2581794b","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":0},"in_reply_to":"7a3c09a3_6571ba77","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class OpenDaylightTrunkHandlerV2(object):"},{"line_number":47,"context_line":"    def __init__(self, plugin_driver):"},{"line_number":48,"context_line":"        self.plugin_driver \u003d plugin_driver"},{"line_number":49,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":50,"context_line":"        self.journal \u003d journal.OpendaylightJournalThread()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_6253706d","line":47,"range":{"start_line":47,"start_character":23,"end_line":47,"end_character":36},"updated":"2017-01-18 23:40:38.000000000","message":"plugin_driver isn\u0027t used.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"39d3900c8888f582c90ef2a8d70b67a3308b9b44","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class OpenDaylightTrunkHandlerV2(object):"},{"line_number":47,"context_line":"    def __init__(self, plugin_driver):"},{"line_number":48,"context_line":"        self.plugin_driver \u003d plugin_driver"},{"line_number":49,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":50,"context_line":"        self.journal \u003d journal.OpendaylightJournalThread()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_db25f5ae","line":47,"range":{"start_line":47,"start_character":23,"end_line":47,"end_character":36},"in_reply_to":"7a3c09a3_6253706d","updated":"2017-01-19 09:44:16.000000000","message":"Done","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def _postcommit(self):"},{"line_number":73,"context_line":"        self.journal.set_sync_event()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def trunk_event(self, resource, event, trunk_plugin, payload):"},{"line_number":76,"context_line":"        if event \u003d\u003d events.PRECOMMIT_CREATE:"},{"line_number":77,"context_line":"            self.trunk_create_precommit(payload.context,"},{"line_number":78,"context_line":"                                        payload.trunk_id,"},{"line_number":79,"context_line":"                                        payload.current_trunk.to_dict())"},{"line_number":80,"context_line":"        elif event \u003d\u003d events.PRECOMMIT_DELETE:"},{"line_number":81,"context_line":"            self.trunk_delete_precommit(payload.context,"},{"line_number":82,"context_line":"                                        payload.trunk_id)"},{"line_number":83,"context_line":"        elif event \u003d\u003d events.AFTER_CREATE:"},{"line_number":84,"context_line":"            payload.current_trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":85,"context_line":"            self._postcommit()"},{"line_number":86,"context_line":"        else:"},{"line_number":87,"context_line":"            self._postcommit()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def subport_event(self, resource, event, trunk_plugin, payload):"},{"line_number":90,"context_line":"        if event in (events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE):"},{"line_number":91,"context_line":"            payload.current_trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":92,"context_line":"            self.trunk_update_precommit(payload.context,"},{"line_number":93,"context_line":"                                        payload.trunk_id,"},{"line_number":94,"context_line":"                                        payload.original_trunk.to_dict(),"},{"line_number":95,"context_line":"                                        payload.current_trunk.to_dict())"},{"line_number":96,"context_line":"        else:"},{"line_number":97,"context_line":"            payload.current_trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":98,"context_line":"            self._postcommit()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class OpenDaylightTrunkDriverV2(trunk_base.DriverBase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_e5e76a44","line":98,"range":{"start_line":75,"start_character":0,"end_line":98,"end_character":30},"updated":"2017-01-18 23:40:38.000000000","message":"Although it\u0027s a matter of balance, we can define handler for each event instead of if...elif.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3020a7f00229a7059a43b102f2d60c96d60547a5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def _postcommit(self):"},{"line_number":73,"context_line":"        self.journal.set_sync_event()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def trunk_event(self, resource, event, trunk_plugin, payload):"},{"line_number":76,"context_line":"        if event \u003d\u003d events.PRECOMMIT_CREATE:"},{"line_number":77,"context_line":"            self.trunk_create_precommit(payload.context,"},{"line_number":78,"context_line":"                                        payload.trunk_id,"},{"line_number":79,"context_line":"                                        payload.current_trunk.to_dict())"},{"line_number":80,"context_line":"        elif event \u003d\u003d events.PRECOMMIT_DELETE:"},{"line_number":81,"context_line":"            self.trunk_delete_precommit(payload.context,"},{"line_number":82,"context_line":"                                        payload.trunk_id)"},{"line_number":83,"context_line":"        elif event \u003d\u003d events.AFTER_CREATE:"},{"line_number":84,"context_line":"            payload.current_trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":85,"context_line":"            self._postcommit()"},{"line_number":86,"context_line":"        else:"},{"line_number":87,"context_line":"            self._postcommit()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def subport_event(self, resource, event, trunk_plugin, payload):"},{"line_number":90,"context_line":"        if event in (events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE):"},{"line_number":91,"context_line":"            payload.current_trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":92,"context_line":"            self.trunk_update_precommit(payload.context,"},{"line_number":93,"context_line":"                                        payload.trunk_id,"},{"line_number":94,"context_line":"                                        payload.original_trunk.to_dict(),"},{"line_number":95,"context_line":"                                        payload.current_trunk.to_dict())"},{"line_number":96,"context_line":"        else:"},{"line_number":97,"context_line":"            payload.current_trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":98,"context_line":"            self._postcommit()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class OpenDaylightTrunkDriverV2(trunk_base.DriverBase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_0b6d67cc","line":98,"range":{"start_line":75,"start_character":0,"end_line":98,"end_character":30},"in_reply_to":"7a3c09a3_e5e76a44","updated":"2017-01-19 00:24:51.000000000","message":"Either could work. if you prefer individual event, will make the change.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f7c79ac72172c254d534baf06aed242f3845235","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            registry.subscribe(self._handler.subport_event,"},{"line_number":120,"context_line":"                               t_consts.SUBPORTS,"},{"line_number":121,"context_line":"                               event)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @classmethod"},{"line_number":124,"context_line":"    def create(cls, plugin_driver):"},{"line_number":125,"context_line":"        cls.plugin_driver \u003d plugin_driver"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_62da90eb","line":122,"updated":"2017-01-18 23:40:38.000000000","message":"PRECOMMIT_UPDATE needs to be connected to update_trunk().\nPOSTCOMMIT needs to be handled here too.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3020a7f00229a7059a43b102f2d60c96d60547a5","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            registry.subscribe(self._handler.subport_event,"},{"line_number":120,"context_line":"                               t_consts.SUBPORTS,"},{"line_number":121,"context_line":"                               event)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @classmethod"},{"line_number":124,"context_line":"    def create(cls, plugin_driver):"},{"line_number":125,"context_line":"        cls.plugin_driver \u003d plugin_driver"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_cb999fd2","line":122,"in_reply_to":"7a3c09a3_62da90eb","updated":"2017-01-19 00:24:51.000000000","message":"Same reply as v1. There is no POSTCOMMIT, only AFTER, unless I looked at wrong place.","commit_id":"9c1090c07e0ae27c8fa196f89335a761b56107a0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a4f820c4d104216cb160bb9d81e04e022fa0adcf","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def create(cls, plugin_driver):"},{"line_number":126,"context_line":"        cls.plugin_driver \u003d plugin_driver"},{"line_number":127,"context_line":"        return cls(odl_const.ODL_ML2_MECH_DRIVER_V2,"},{"line_number":128,"context_line":"                   SUPPORTED_INTERFACES,"},{"line_number":129,"context_line":"                   SUPPORTED_SEGMENTATION_TYPES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_a508972e","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":25},"updated":"2017-01-21 02:57:51.000000000","message":"this isn\u0027t used.","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"cb384c6da13558a89326aa598f8a2e51ee591108","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @classmethod"},{"line_number":125,"context_line":"    def create(cls, plugin_driver):"},{"line_number":126,"context_line":"        cls.plugin_driver \u003d plugin_driver"},{"line_number":127,"context_line":"        return cls(odl_const.ODL_ML2_MECH_DRIVER_V2,"},{"line_number":128,"context_line":"                   SUPPORTED_INTERFACES,"},{"line_number":129,"context_line":"                   SUPPORTED_SEGMENTATION_TYPES,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_06e33034","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":25},"in_reply_to":"5a3905b3_a508972e","updated":"2017-01-21 08:39:30.000000000","message":"Done","commit_id":"86b42f18a10e04a865e62fe9fe23953e6679cd79"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"# from oslo_log import helpers as log_helpers"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.callbacks import events"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_b23bf89b","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":45},"updated":"2017-01-26 09:29:26.000000000","message":"nit: delete this line","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1884c1bec6f7e845520689bf6065d91263c7a627","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"# from oslo_log import helpers as log_helpers"},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.callbacks import events"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_c7294b8b","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":45},"in_reply_to":"3a461143_b23bf89b","updated":"2017-01-27 04:22:10.000000000","message":"Done","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from networking_odl.journal import journal"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"SUPPORTED_INTERFACES \u003d ("},{"line_number":34,"context_line":"    portbindings.VIF_TYPE_OVS,"},{"line_number":35,"context_line":"    portbindings.VIF_TYPE_VHOST_USER,"},{"line_number":36,"context_line":")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"SUPPORTED_SEGMENTATION_TYPES \u003d ("},{"line_number":39,"context_line":"    t_consts.VLAN,"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_fb3f1bd4","line":40,"range":{"start_line":33,"start_character":0,"end_line":40,"end_character":1},"updated":"2017-01-26 09:29:26.000000000","message":"This is also defined in V1 driver, you can import from there or use a common place to define this instead of copying","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1884c1bec6f7e845520689bf6065d91263c7a627","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from networking_odl.journal import journal"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"SUPPORTED_INTERFACES \u003d ("},{"line_number":34,"context_line":"    portbindings.VIF_TYPE_OVS,"},{"line_number":35,"context_line":"    portbindings.VIF_TYPE_VHOST_USER,"},{"line_number":36,"context_line":")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"SUPPORTED_SEGMENTATION_TYPES \u003d ("},{"line_number":39,"context_line":"    t_consts.VLAN,"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_e720079e","line":40,"range":{"start_line":33,"start_character":0,"end_line":40,"end_character":1},"in_reply_to":"3a461143_fb3f1bd4","updated":"2017-01-27 04:22:10.000000000","message":"Done","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        LOG.info(_LI(\u0027initialized trunk driver for OpendayLight\u0027))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _record_in_journal(context, object_type, data_id, operation, data):"},{"line_number":53,"context_line":"        journal.record(context, context, object_type,"},{"line_number":54,"context_line":"                       data_id, operation, data)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_7200b0ab","line":52,"range":{"start_line":52,"start_character":49,"end_line":52,"end_character":53},"updated":"2017-01-26 09:29:26.000000000","message":"s/data/trunk","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1884c1bec6f7e845520689bf6065d91263c7a627","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        LOG.info(_LI(\u0027initialized trunk driver for OpendayLight\u0027))"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _record_in_journal(context, object_type, data_id, operation, data):"},{"line_number":53,"context_line":"        journal.record(context, context, object_type,"},{"line_number":54,"context_line":"                       data_id, operation, data)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_072433ad","line":52,"range":{"start_line":52,"start_character":49,"end_line":52,"end_character":53},"in_reply_to":"3a461143_7200b0ab","updated":"2017-01-27 04:22:10.000000000","message":"Done","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _record_in_journal(context, object_type, data_id, operation, data):"},{"line_number":53,"context_line":"        journal.record(context, context, object_type,"},{"line_number":54,"context_line":"                       data_id, operation, data)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def trunk_create_precommit(self, context, trunk_id, data):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_f2e10000","line":53,"range":{"start_line":53,"start_character":41,"end_line":53,"end_character":52},"updated":"2017-01-26 09:29:26.000000000","message":"This should be a constant, odl_const.ODL_TRUNK","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1884c1bec6f7e845520689bf6065d91263c7a627","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @staticmethod"},{"line_number":52,"context_line":"    def _record_in_journal(context, object_type, data_id, operation, data):"},{"line_number":53,"context_line":"        journal.record(context, context, object_type,"},{"line_number":54,"context_line":"                       data_id, operation, data)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def trunk_create_precommit(self, context, trunk_id, data):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_273befd2","line":53,"range":{"start_line":53,"start_character":41,"end_line":53,"end_character":52},"in_reply_to":"3a461143_f2e10000","updated":"2017-01-27 04:22:10.000000000","message":"Good point. Done.","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def _postcommit(self):"},{"line_number":74,"context_line":"        self.journal.set_sync_event()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def trunk_event(self, resource, event, trunk_plugin, payload):"},{"line_number":77,"context_line":"        if event \u003d\u003d events.PRECOMMIT_CREATE:"},{"line_number":78,"context_line":"            self.trunk_create_precommit(payload.context,"},{"line_number":79,"context_line":"                                        payload.trunk_id,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_32f54883","line":76,"range":{"start_line":76,"start_character":7,"end_line":76,"end_character":19},"updated":"2017-01-26 09:29:26.000000000","message":"What\u0027s the necessity of this method? You should register the methods directly.","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1884c1bec6f7e845520689bf6065d91263c7a627","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def _postcommit(self):"},{"line_number":74,"context_line":"        self.journal.set_sync_event()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def trunk_event(self, resource, event, trunk_plugin, payload):"},{"line_number":77,"context_line":"        if event \u003d\u003d events.PRECOMMIT_CREATE:"},{"line_number":78,"context_line":"            self.trunk_create_precommit(payload.context,"},{"line_number":79,"context_line":"                                        payload.trunk_id,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_a74d1f74","line":76,"range":{"start_line":76,"start_character":7,"end_line":76,"end_character":19},"in_reply_to":"3a461143_32f54883","updated":"2017-01-27 04:22:10.000000000","message":"Another artifact of reference driver. Was in two minds on which approach to use and opted to go with this one for now and let reviewers help with proper one. Will change to direct registration.","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"2df7c8c7062b037cbd8acb77a89e6d30fd30bf8d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            self._postcommit()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def subport_event(self, resource, event, trunk_plugin, payload):"},{"line_number":91,"context_line":"        if event in (events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE):"},{"line_number":92,"context_line":"            payload.current_trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":93,"context_line":"            self.trunk_update_precommit(payload.context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_c0626ead","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":21},"updated":"2017-01-26 09:29:26.000000000","message":"Same question here","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1884c1bec6f7e845520689bf6065d91263c7a627","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            self._postcommit()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def subport_event(self, resource, event, trunk_plugin, payload):"},{"line_number":91,"context_line":"        if event in (events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE):"},{"line_number":92,"context_line":"            payload.current_trunk.update(status\u003dt_consts.ACTIVE_STATUS)"},{"line_number":93,"context_line":"            self.trunk_update_precommit(payload.context,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_c7506b0d","line":90,"range":{"start_line":90,"start_character":8,"end_line":90,"end_character":21},"in_reply_to":"3a461143_c0626ead","updated":"2017-01-27 04:22:10.000000000","message":"same as above. Done.","commit_id":"2f110f64616839fb1dab305a097c84ec259e3d53"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"4e47008f0e71dad2a37587318463ef72e9e6cdf8","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def trunk_create_precommit(self, resource, event, trunk_plugin, payload):"},{"line_number":46,"context_line":"        data \u003d payload.current_trunk.to_dict()"},{"line_number":47,"context_line":"        data[\u0027status\u0027] \u003d t_consts.ACTIVE_STATUS"},{"line_number":48,"context_line":"        self._record_in_journal(payload.context, payload.trunk_id,"},{"line_number":49,"context_line":"                                odl_const.ODL_CREATE, data)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3a461143_7ff63bfa","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":47},"updated":"2017-01-27 21:41:01.000000000","message":"Can you please add TODO comment for future work?\n\nI guess ODL netvirt side doesn\u0027t support admin_state_up yet, so it\u0027s okay to ignore admin_state_up. But can you please add some comment?","commit_id":"562796e189120d4e0fffb1046f94d500b2173df9"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"216f904b7fb18637b72f4d567149bd8f0ab41b24","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def trunk_create_precommit(self, resource, event, trunk_plugin, payload):"},{"line_number":46,"context_line":"        data \u003d payload.current_trunk.to_dict()"},{"line_number":47,"context_line":"        data[\u0027status\u0027] \u003d t_consts.ACTIVE_STATUS"},{"line_number":48,"context_line":"        self._record_in_journal(payload.context, payload.trunk_id,"},{"line_number":49,"context_line":"                                odl_const.ODL_CREATE, data)"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3a461143_977ae375","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":47},"in_reply_to":"3a461143_7ff63bfa","updated":"2017-01-28 12:33:01.000000000","message":"Done","commit_id":"562796e189120d4e0fffb1046f94d500b2173df9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"9ec0fd85f2f58700a4ab6b87ab50d571dc4cb138","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        registry.subscribe(self._handler.trunk_delete_precommit,"},{"line_number":97,"context_line":"                           t_consts.TRUNK, events.PRECOMMIT_DELETE)"},{"line_number":98,"context_line":"        registry.subscribe(self._handler.trunk_delete_postcommit,"},{"line_number":99,"context_line":"                           t_consts.TRUNK, events.AFTER_DELETE)"},{"line_number":100,"context_line":"        for event in (events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE):"},{"line_number":101,"context_line":"            registry.subscribe(self._handler.trunk_update_precommit,"},{"line_number":102,"context_line":"                               t_consts.SUBPORTS, event)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_98214650","line":99,"updated":"2017-02-07 00:40:35.000000000","message":"t_consts.TRUNK, events.PRECOMMIT/AFTER_UPDATE is needed as admin_state_up can be changed by update trunk.","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b94206685549ae3b781e8182c12ee04b35b37dcf","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        registry.subscribe(self._handler.trunk_delete_precommit,"},{"line_number":97,"context_line":"                           t_consts.TRUNK, events.PRECOMMIT_DELETE)"},{"line_number":98,"context_line":"        registry.subscribe(self._handler.trunk_delete_postcommit,"},{"line_number":99,"context_line":"                           t_consts.TRUNK, events.AFTER_DELETE)"},{"line_number":100,"context_line":"        for event in (events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE):"},{"line_number":101,"context_line":"            registry.subscribe(self._handler.trunk_update_precommit,"},{"line_number":102,"context_line":"                               t_consts.SUBPORTS, event)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_5b3c38e2","line":99,"in_reply_to":"1a430d35_98214650","updated":"2017-02-07 01:44:21.000000000","message":"Done","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"9ec0fd85f2f58700a4ab6b87ab50d571dc4cb138","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        registry.subscribe(self._handler.trunk_delete_postcommit,"},{"line_number":99,"context_line":"                           t_consts.TRUNK, events.AFTER_DELETE)"},{"line_number":100,"context_line":"        for event in (events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE):"},{"line_number":101,"context_line":"            registry.subscribe(self._handler.trunk_update_precommit,"},{"line_number":102,"context_line":"                               t_consts.SUBPORTS, event)"},{"line_number":103,"context_line":"        for event in (events.AFTER_CREATE, events.AFTER_DELETE):"},{"line_number":104,"context_line":"            registry.subscribe(self._handler.trunk_update_postcommit,"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_98e866e4","line":101,"range":{"start_line":101,"start_character":45,"end_line":101,"end_character":50},"updated":"2017-02-07 00:40:35.000000000","message":"subport?","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b94206685549ae3b781e8182c12ee04b35b37dcf","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        registry.subscribe(self._handler.trunk_delete_postcommit,"},{"line_number":99,"context_line":"                           t_consts.TRUNK, events.AFTER_DELETE)"},{"line_number":100,"context_line":"        for event in (events.PRECOMMIT_CREATE, events.PRECOMMIT_DELETE):"},{"line_number":101,"context_line":"            registry.subscribe(self._handler.trunk_update_precommit,"},{"line_number":102,"context_line":"                               t_consts.SUBPORTS, event)"},{"line_number":103,"context_line":"        for event in (events.AFTER_CREATE, events.AFTER_DELETE):"},{"line_number":104,"context_line":"            registry.subscribe(self._handler.trunk_update_postcommit,"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_1b32b010","line":101,"range":{"start_line":101,"start_character":45,"end_line":101,"end_character":50},"in_reply_to":"1a430d35_98e866e4","updated":"2017-02-07 01:44:21.000000000","message":"No, sub port add/delete is handled as trunk_update.","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"9ec0fd85f2f58700a4ab6b87ab50d571dc4cb138","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            registry.subscribe(self._handler.trunk_update_precommit,"},{"line_number":102,"context_line":"                               t_consts.SUBPORTS, event)"},{"line_number":103,"context_line":"        for event in (events.AFTER_CREATE, events.AFTER_DELETE):"},{"line_number":104,"context_line":"            registry.subscribe(self._handler.trunk_update_postcommit,"},{"line_number":105,"context_line":"                               t_consts.SUBPORTS, event)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_b8e36204","line":104,"range":{"start_line":104,"start_character":44,"end_line":104,"end_character":50},"updated":"2017-02-07 00:40:35.000000000","message":"subport?","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b94206685549ae3b781e8182c12ee04b35b37dcf","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            registry.subscribe(self._handler.trunk_update_precommit,"},{"line_number":102,"context_line":"                               t_consts.SUBPORTS, event)"},{"line_number":103,"context_line":"        for event in (events.AFTER_CREATE, events.AFTER_DELETE):"},{"line_number":104,"context_line":"            registry.subscribe(self._handler.trunk_update_postcommit,"},{"line_number":105,"context_line":"                               t_consts.SUBPORTS, event)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":23,"id":"1a430d35_3b35acf6","line":104,"range":{"start_line":104,"start_character":44,"end_line":104,"end_character":50},"in_reply_to":"1a430d35_b8e36204","updated":"2017-02-07 01:44:21.000000000","message":"same as above.","commit_id":"0d4a807326d8f1ea02e5d96ef406f814f95347e4"}]}
