)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6817501307d9023670ca65afe62d0da5c0567292","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It will be deprecated in next Openstack Pike release,"},{"line_number":16,"context_line":"as default will be version 2 driver for all services"},{"line_number":17,"context_line":"by that release for OpenDaylight deployments."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1656903"},{"line_number":20,"context_line":"Partial-Bug: #1632117"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"1a430d35_7dab15d7","line":17,"updated":"2017-02-09 20:09:04.000000000","message":"Can you pleas mention that full funcitonal test will come as followup patch?\nAnd networking-bgpvpn has tempest test cases. we\u0027d like to run those too.","commit_id":"52d0d3ed244de8014d6b4277f8a12ab924b22135"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3c914990521d24e9fdf9db3f94ccf8187ca95cff","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"It will be deprecated in next Openstack Pike release,"},{"line_number":16,"context_line":"as default will be version 2 driver for all services"},{"line_number":17,"context_line":"by that release for OpenDaylight deployments."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1656903"},{"line_number":20,"context_line":"Partial-Bug: #1632117"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"fa31d9ce_ad9f29b3","line":17,"in_reply_to":"1a430d35_7dab15d7","updated":"2017-02-09 20:55:37.000000000","message":"Done","commit_id":"52d0d3ed244de8014d6b4277f8a12ab924b22135"}],"devstack/README.rst":[{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"cf1f2a0edc19987ef15d33b15d70f79eeb0fdfbc","unresolved":false,"context_lines":[{"line_number":132,"context_line":"15. Enabling BGPVPN with OpenDaylight Backend using the Version 2 OpenDaylight"},{"line_number":133,"context_line":"Driver for BGPVPN:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"- First make sure networking-bgpvpn package is installed in all the"},{"line_number":136,"context_line":"  Openstack Controllers."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- Then Configure the following into the [service_providers] section"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a461143_6b64e121","line":135,"updated":"2017-01-27 08:12:42.000000000","message":"This description is more for actual deployments and should be in user doc. Devstack readme should focus on local.conf settings. This should be something like:\n[[local|localrc]]\nenable_plugin networking-bgpvpn https://git.openstack.org/openstack/networking-bgpvpn.git\nenable_plugin networking-odl http://git.openstack.org/openstack/networking-odl\n\n[[post-config|$NETWORKING_BGPVPN_CONF]]\n[service_providers]\nservice_provider\u003dBGPVPN:OpenDaylight:networking_odl.bgpvpn.odl_v2.OpenDaylightBgpvpnDriver:default\n\nOr even better, there should be ODL_BGPVPN\u003dTrue and devstack scripts should take care of rest.","commit_id":"c319012fe537e3c1c3d627257dae09942d26fa4a"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"55a92cc7deb108bbd3560b2e6ab2e8356d1e279f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"15. Enabling BGPVPN with OpenDaylight Backend using the Version 2 OpenDaylight"},{"line_number":133,"context_line":"Driver for BGPVPN:"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"- First make sure networking-bgpvpn package is installed in all the"},{"line_number":136,"context_line":"  Openstack Controllers."},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- Then Configure the following into the [service_providers] section"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a461143_ef431211","line":135,"in_reply_to":"3a461143_6b64e121","updated":"2017-01-31 10:39:41.000000000","message":"Done","commit_id":"c319012fe537e3c1c3d627257dae09942d26fa4a"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6817501307d9023670ca65afe62d0da5c0567292","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"enable_plugin networking-bgpvpn https://git.openstack.org/openstack/networking-bgpvpn.git"},{"line_number":148,"context_line":"enable_plugin networking-odl https://git.openstack.org/openstack/networking-odl.git"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"[[post-config | $NETWORKING_BGPVPN_CONF]]"},{"line_number":151,"context_line":"[service_providers]"},{"line_number":152,"context_line":"service_provider\u003dBGPVPN:OpenDaylight.networking_odl.bgpvpn.odl_v2.OpenDaylightBgpvpnDriver:default"}],"source_content_type":"text/x-rst","patch_set":27,"id":"1a430d35_fdd3855d","line":149,"updated":"2017-02-09 20:09:04.000000000","message":"Doesn\u0027t bgpvpn service need to be enabled?\nlooking at networking-bgpvpn/devstack, it seems like no need.\nBut I\u0027d like to ask it just in case.","commit_id":"52d0d3ed244de8014d6b4277f8a12ab924b22135"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3c914990521d24e9fdf9db3f94ccf8187ca95cff","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"enable_plugin networking-bgpvpn https://git.openstack.org/openstack/networking-bgpvpn.git"},{"line_number":148,"context_line":"enable_plugin networking-odl https://git.openstack.org/openstack/networking-odl.git"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"[[post-config | $NETWORKING_BGPVPN_CONF]]"},{"line_number":151,"context_line":"[service_providers]"},{"line_number":152,"context_line":"service_provider\u003dBGPVPN:OpenDaylight.networking_odl.bgpvpn.odl_v2.OpenDaylightBgpvpnDriver:default"}],"source_content_type":"text/x-rst","patch_set":27,"id":"fa31d9ce_0aa3bb9f","line":149,"in_reply_to":"1a430d35_fdd3855d","updated":"2017-02-09 20:55:37.000000000","message":"No, it doesn\u0027t. However, I was thinking if it would be better to have something like \u0027ODL_SERVICES\u003dqos,sfc,l2gateway,bgpvpn,trunk\u0027 with v1/v2 pick based off mech driver. It will simplify configuration to great extent. Probably a follow up patch. Thoughts?","commit_id":"52d0d3ed244de8014d6b4277f8a12ab924b22135"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3505941573ce25861844d4ca8c827fb679db2e70","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Include the following lines in your localrc (or local.conf)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"enable_plugin networking-bgpvpn https://git.openstack.org/openstack/networking-bgpvpn.git"},{"line_number":170,"context_line":"enable_plugin networking-odl https://git.openstack.org/openstack/networking-odl.git"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"[[post-config | $NETWORKING_BGPVPN_CONF]]"},{"line_number":173,"context_line":"[service_providers]"}],"source_content_type":"text/x-rst","patch_set":50,"id":"fa31d9ce_3044b319","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":83},"updated":"2017-02-15 00:26:41.000000000","message":"This should be done always while enabling networking-odl, not sure if this is right place because this not specific to this case, In general this is needed to networking-odl driver.","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"001ca8a04c122cdf24a30d9ee9c038e108208525","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Include the following lines in your localrc (or local.conf)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"enable_plugin networking-bgpvpn https://git.openstack.org/openstack/networking-bgpvpn.git"},{"line_number":170,"context_line":"enable_plugin networking-odl https://git.openstack.org/openstack/networking-odl.git"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"[[post-config | $NETWORKING_BGPVPN_CONF]]"},{"line_number":173,"context_line":"[service_providers]"}],"source_content_type":"text/x-rst","patch_set":50,"id":"fa31d9ce_c5d394d3","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":83},"in_reply_to":"fa31d9ce_3044b319","updated":"2017-02-15 02:33:27.000000000","message":"dropped this line.","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a1c69b378325214daeed5b59a3244d605dd4df04","unresolved":false,"context_lines":[{"line_number":169,"context_line":"enable_plugin networking-bgpvpn https://git.openstack.org/openstack/networking-bgpvpn.git"},{"line_number":170,"context_line":"enable_plugin networking-odl https://git.openstack.org/openstack/networking-odl.git"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"[[post-config | $NETWORKING_BGPVPN_CONF]]"},{"line_number":173,"context_line":"[service_providers]"},{"line_number":174,"context_line":"service_provider\u003dBGPVPN:OpenDaylight.networking_odl.bgpvpn.odl_v2.OpenDaylightBgpvpnDriver:default"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":50,"id":"fa31d9ce_ff0bced3","line":172,"range":{"start_line":172,"start_character":13,"end_line":172,"end_character":16},"updated":"2017-02-14 23:18:25.000000000","message":"does this actually work?  it\u0027s unusual to have spaces here.","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"001ca8a04c122cdf24a30d9ee9c038e108208525","unresolved":false,"context_lines":[{"line_number":169,"context_line":"enable_plugin networking-bgpvpn https://git.openstack.org/openstack/networking-bgpvpn.git"},{"line_number":170,"context_line":"enable_plugin networking-odl https://git.openstack.org/openstack/networking-odl.git"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"[[post-config | $NETWORKING_BGPVPN_CONF]]"},{"line_number":173,"context_line":"[service_providers]"},{"line_number":174,"context_line":"service_provider\u003dBGPVPN:OpenDaylight.networking_odl.bgpvpn.odl_v2.OpenDaylightBgpvpnDriver:default"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":50,"id":"fa31d9ce_e5ded8db","line":172,"range":{"start_line":172,"start_character":13,"end_line":172,"end_character":16},"in_reply_to":"fa31d9ce_ff0bced3","updated":"2017-02-15 02:33:27.000000000","message":"Done","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"}],"networking_odl/bgpvpn/odl_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a670cb37f26f5c08bf456718cc044c25bc157208","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @staticmethod"},{"line_number":48,"context_line":"    def _record_in_journal(context, object_type, operation, resource_id,"},{"line_number":49,"context_line":"                           resource\u003dNone):"},{"line_number":50,"context_line":"        if resource_id is None:"},{"line_number":51,"context_line":"            pass"},{"line_number":52,"context_line":"        LOG.info(_LI(\"ODL BGPVPN: Precommit Recording Data %(resource_id)s\""},{"line_number":53,"context_line":"                 \" %(resource)s\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_388e372e","line":50,"range":{"start_line":50,"start_character":11,"end_line":50,"end_character":30},"updated":"2017-01-24 02:42:40.000000000","message":"When is resource_id None?","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a670cb37f26f5c08bf456718cc044c25bc157208","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def _record_in_journal(context, object_type, operation, resource_id,"},{"line_number":49,"context_line":"                           resource\u003dNone):"},{"line_number":50,"context_line":"        if resource_id is None:"},{"line_number":51,"context_line":"            pass"},{"line_number":52,"context_line":"        LOG.info(_LI(\"ODL BGPVPN: Precommit Recording Data %(resource_id)s\""},{"line_number":53,"context_line":"                 \" %(resource)s\"),"},{"line_number":54,"context_line":"                 {\u0027resource_id\u0027: resource_id, \u0027resource_data\u0027: resource})"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_588143fa","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":16},"updated":"2017-01-24 02:42:40.000000000","message":"return?","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"9c4ac6ce2b254ede5c8390a7195b4637524baa71","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def _record_in_journal(context, object_type, operation, resource_id,"},{"line_number":49,"context_line":"                           resource\u003dNone):"},{"line_number":50,"context_line":"        if resource_id is None:"},{"line_number":51,"context_line":"            pass"},{"line_number":52,"context_line":"        LOG.info(_LI(\"ODL BGPVPN: Precommit Recording Data %(resource_id)s\""},{"line_number":53,"context_line":"                 \" %(resource)s\"),"},{"line_number":54,"context_line":"                 {\u0027resource_id\u0027: resource_id, \u0027resource_data\u0027: resource})"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_ef75c2ca","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":16},"in_reply_to":"5a3905b3_588143fa","updated":"2017-01-24 04:26:25.000000000","message":"i will remove this bunch.","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a670cb37f26f5c08bf456718cc044c25bc157208","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        journal.record(context, None, object_type,"},{"line_number":56,"context_line":"                       resource_id, operation, resource)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _scrub_rd_list(self, bgpvpn):"},{"line_number":59,"context_line":"        if len(bgpvpn[\u0027route_distinguishers\u0027]) \u003e 1:"},{"line_number":60,"context_line":"            bgpvpn[\u0027route_distinguishers\u0027] \u003d bgpvpn[\u0027route_distinguishers\u0027][0]"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_f8be6fac","line":58,"updated":"2017-01-24 02:42:40.000000000","message":"From curiosity: why is this needed?","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"9c4ac6ce2b254ede5c8390a7195b4637524baa71","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        journal.record(context, None, object_type,"},{"line_number":56,"context_line":"                       resource_id, operation, resource)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _scrub_rd_list(self, bgpvpn):"},{"line_number":59,"context_line":"        if len(bgpvpn[\u0027route_distinguishers\u0027]) \u003e 1:"},{"line_number":60,"context_line":"            bgpvpn[\u0027route_distinguishers\u0027] \u003d bgpvpn[\u0027route_distinguishers\u0027][0]"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_8f6c3e09","line":58,"in_reply_to":"5a3905b3_f8be6fac","updated":"2017-01-24 04:26:25.000000000","message":"In ODL Controller we support only one RD per BGPVPN.\n\nHowever, Openstack BGPVPN API supports multiple RDs per BGPVPN.\n\nIn order to bridge that gap, we always select only 0th RD from the openstack input and ship it to ODL.","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a670cb37f26f5c08bf456718cc044c25bc157208","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _scrub_rd_list(self, bgpvpn):"},{"line_number":59,"context_line":"        if len(bgpvpn[\u0027route_distinguishers\u0027]) \u003e 1:"},{"line_number":60,"context_line":"            bgpvpn[\u0027route_distinguishers\u0027] \u003d bgpvpn[\u0027route_distinguishers\u0027][0]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":63,"context_line":"        LOG.info(_LI(\"ODL: Precommit Create BGPVPN %(bgpvpn)s\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_3831d75a","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":78},"updated":"2017-01-24 02:42:40.000000000","message":"Is it okay to modify the dict?","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"9c4ac6ce2b254ede5c8390a7195b4637524baa71","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _scrub_rd_list(self, bgpvpn):"},{"line_number":59,"context_line":"        if len(bgpvpn[\u0027route_distinguishers\u0027]) \u003e 1:"},{"line_number":60,"context_line":"            bgpvpn[\u0027route_distinguishers\u0027] \u003d bgpvpn[\u0027route_distinguishers\u0027][0]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":63,"context_line":"        LOG.info(_LI(\"ODL: Precommit Create BGPVPN %(bgpvpn)s\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_cf7ac6bc","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":78},"in_reply_to":"5a3905b3_3831d75a","updated":"2017-01-24 04:26:25.000000000","message":"We have to modify this dict before supplying to ODL and so we are using the same dict to be sent to ODL to be recorded in the journal for consistency.","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"09e55c6c3d5b665928424fe57fe62c5cd761b5e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3a461143_b5cdf486","updated":"2017-01-30 17:25:32.000000000","message":"I think one LOG.info in _record_in_journal method is enough \ndoing Logging inside every precommit is excessive and shouldn\u0027t be done. but it is acceptable if other reviewers are okay with it","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"55a7dadd7cd828820aee5c3db31e6b25ba8e9a7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"3a461143_9466214f","in_reply_to":"3a461143_b5cdf486","updated":"2017-01-31 10:39:13.000000000","message":"Done","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"09e55c6c3d5b665928424fe57fe62c5cd761b5e2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"cfg.CONF.import_group(\u0027ml2_odl\u0027, \u0027networking_odl.common.config\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":"OPENDAYLIGHT_BGPVPN_DRIVER_NAME \u003d \u0027OpenDaylight\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class OpenDaylightBgpvpnDriver(driver_api.BGPVPNDriver):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_f5c3fc54","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":48},"updated":"2017-01-30 17:25:32.000000000","message":"this should go in constants","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"55a7dadd7cd828820aee5c3db31e6b25ba8e9a7e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"cfg.CONF.import_group(\u0027ml2_odl\u0027, \u0027networking_odl.common.config\u0027)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":"OPENDAYLIGHT_BGPVPN_DRIVER_NAME \u003d \u0027OpenDaylight\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class OpenDaylightBgpvpnDriver(driver_api.BGPVPNDriver):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_11c3238a","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":48},"in_reply_to":"3a461143_f5c3fc54","updated":"2017-01-31 10:39:13.000000000","message":"Done","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"09e55c6c3d5b665928424fe57fe62c5cd761b5e2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                       resource_id, operation, resource)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _scrub_rd_list(self, bgpvpn):"},{"line_number":57,"context_line":"        if len(bgpvpn[\u0027route_distinguishers\u0027]) \u003e 1:"},{"line_number":58,"context_line":"            bgpvpn[\u0027route_distinguishers\u0027] \u003d bgpvpn[\u0027route_distinguishers\u0027][0]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def create_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":61,"context_line":"        LOG.info(_LI(\"ODL: Precommit Create BGPVPN %(bgpvpn)s\"),"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_f544dcb7","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":78},"updated":"2017-01-30 17:25:32.000000000","message":"this deserves a at least an comment, that explains why first entry from list will be chosen as bgpvpn[\u0027route_distinguishers\u0027] when there are more than 1","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"55a7dadd7cd828820aee5c3db31e6b25ba8e9a7e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                       resource_id, operation, resource)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _scrub_rd_list(self, bgpvpn):"},{"line_number":57,"context_line":"        if len(bgpvpn[\u0027route_distinguishers\u0027]) \u003e 1:"},{"line_number":58,"context_line":"            bgpvpn[\u0027route_distinguishers\u0027] \u003d bgpvpn[\u0027route_distinguishers\u0027][0]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def create_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":61,"context_line":"        LOG.info(_LI(\"ODL: Precommit Create BGPVPN %(bgpvpn)s\"),"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_9431c15c","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":78},"in_reply_to":"3a461143_f544dcb7","updated":"2017-01-31 10:39:13.000000000","message":"Done","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.service_plugin \u003d service_plugin"},{"line_number":44,"context_line":"        self.journal \u003d journal.OpendaylightJournalThread()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"},{"line_number":47,"context_line":"    def _record_in_journal(context, object_type, operation, resource_id,"},{"line_number":48,"context_line":"                           resource\u003dNone):"},{"line_number":49,"context_line":"        LOG.debug(\"ODL BGPVPN: Precommit Recording Data %(resource_id)s\""},{"line_number":50,"context_line":"                  \" %(resource)s\","},{"line_number":51,"context_line":"                  {\u0027resource_id\u0027: resource_id, \u0027resource_data\u0027: resource})"},{"line_number":52,"context_line":"        journal.record(context, None, object_type,"},{"line_number":53,"context_line":"                       resource_id, operation, resource)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _scrub_rd_list(self, bgpvpn):"},{"line_number":56,"context_line":"        # Note: OpenDaylight Controller BGPVPN implementation supports only"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_5e37614c","line":53,"range":{"start_line":46,"start_character":4,"end_line":53,"end_character":56},"updated":"2017-01-31 18:43:03.000000000","message":"this method isn\u0027t doing anything extra or special just an another jump statement, if log for each precommit can be handled via decorators then, journal.record can be directly called inside precommit instead of having this helper method.","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            bgpvpn[\u0027route_distinguishers\u0027] \u003d bgpvpn[\u0027route_distinguishers\u0027][0]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":63,"context_line":"        LOG.debug(\"ODL: Precommit Create BGPVPN %(bgpvpn)s\","},{"line_number":64,"context_line":"                  {\u0027bgpvpn\u0027: bgpvpn})"},{"line_number":65,"context_line":"        self._scrub_rd_list(bgpvpn)"},{"line_number":66,"context_line":"        self._record_in_journal("},{"line_number":67,"context_line":"            context, odl_const.ODL_BGPVPN,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_1ebcf9b9","line":64,"range":{"start_line":63,"start_character":7,"end_line":64,"end_character":37},"updated":"2017-01-31 18:43:03.000000000","message":"for each method a decorator can be used instead,\n@log_helpers.log_method_call","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        LOG.debug(\"ODL: Precommit Create BGPVPN %(bgpvpn)s\","},{"line_number":64,"context_line":"                  {\u0027bgpvpn\u0027: bgpvpn})"},{"line_number":65,"context_line":"        self._scrub_rd_list(bgpvpn)"},{"line_number":66,"context_line":"        self._record_in_journal("},{"line_number":67,"context_line":"            context, odl_const.ODL_BGPVPN,"},{"line_number":68,"context_line":"            odl_const.ODL_CREATE,"},{"line_number":69,"context_line":"            bgpvpn[\u0027id\u0027],"},{"line_number":70,"context_line":"            bgpvpn)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def update_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":73,"context_line":"        LOG.debug(\"ODL: Precommit Update BGPVPN %(bgpvpn)s\","}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_7e05fd43","line":70,"range":{"start_line":66,"start_character":8,"end_line":70,"end_character":19},"updated":"2017-01-31 18:43:03.000000000","message":"the extra function _record_in_journal call is making it complex for no reason, journal.record can be directly called here.","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            bgpvpn)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def update_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":73,"context_line":"        LOG.debug(\"ODL: Precommit Update BGPVPN %(bgpvpn)s\","},{"line_number":74,"context_line":"                  {\u0027bgpvpn\u0027: bgpvpn})"},{"line_number":75,"context_line":"        self._scrub_rd_list(bgpvpn)"},{"line_number":76,"context_line":"        self._record_in_journal("},{"line_number":77,"context_line":"            context, odl_const.ODL_BGPVPN,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_de4351ad","line":74,"range":{"start_line":73,"start_character":8,"end_line":74,"end_character":37},"updated":"2017-01-31 18:43:03.000000000","message":"same as L64","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        LOG.debug(\"ODL: Precommit Update BGPVPN %(bgpvpn)s\","},{"line_number":74,"context_line":"                  {\u0027bgpvpn\u0027: bgpvpn})"},{"line_number":75,"context_line":"        self._scrub_rd_list(bgpvpn)"},{"line_number":76,"context_line":"        self._record_in_journal("},{"line_number":77,"context_line":"            context, odl_const.ODL_BGPVPN,"},{"line_number":78,"context_line":"            odl_const.ODL_UPDATE,"},{"line_number":79,"context_line":"            bgpvpn[\u0027id\u0027],"},{"line_number":80,"context_line":"            bgpvpn)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def delete_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":83,"context_line":"        LOG.debug(\"ODL: Precommit Delete BGPVPN %(bgpvpn)s\","}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_befbe545","line":80,"range":{"start_line":76,"start_character":7,"end_line":80,"end_character":19},"updated":"2017-01-31 18:43:03.000000000","message":"same as L70","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            bgpvpn)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def delete_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":83,"context_line":"        LOG.debug(\"ODL: Precommit Delete BGPVPN %(bgpvpn)s\","},{"line_number":84,"context_line":"                  {\u0027bgpvpn\u0027: bgpvpn})"},{"line_number":85,"context_line":"        self._record_in_journal("},{"line_number":86,"context_line":"            context, odl_const.ODL_BGPVPN,"},{"line_number":87,"context_line":"            odl_const.ODL_DELETE, bgpvpn[\u0027id\u0027], bgpvpn)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_1e1879d2","line":84,"range":{"start_line":83,"start_character":8,"end_line":84,"end_character":37},"updated":"2017-01-31 18:43:03.000000000","message":"same as L64","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def delete_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":83,"context_line":"        LOG.debug(\"ODL: Precommit Delete BGPVPN %(bgpvpn)s\","},{"line_number":84,"context_line":"                  {\u0027bgpvpn\u0027: bgpvpn})"},{"line_number":85,"context_line":"        self._record_in_journal("},{"line_number":86,"context_line":"            context, odl_const.ODL_BGPVPN,"},{"line_number":87,"context_line":"            odl_const.ODL_DELETE, bgpvpn[\u0027id\u0027], bgpvpn)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def create_net_assoc_precomit(self, context, net_assoc):"},{"line_number":90,"context_line":"        bgpvpns \u003d self.bgpvpn_db.find_bgpvpns_for_network("}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_5ea12145","line":87,"range":{"start_line":85,"start_character":8,"end_line":87,"end_character":55},"updated":"2017-01-31 18:43:03.000000000","message":"same as L70","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                driver\u003d\"OpenDaylight V2\","},{"line_number":95,"context_line":"                network\u003dnet_assoc[\u0027network_id\u0027],"},{"line_number":96,"context_line":"                bgpvpn\u003dbgpvpns[0][\u0027id\u0027])"},{"line_number":97,"context_line":"        LOG.debug(\"ODL: Precommit Assoc Networks to BGPVPN %(net_assoc)s\","},{"line_number":98,"context_line":"                  {\u0027net_assoc\u0027: net_assoc})"},{"line_number":99,"context_line":"        self._record_in_journal("},{"line_number":100,"context_line":"            context, odl_const.ODL_BGPVPN_NETWORK_ASSOCIATION,"},{"line_number":101,"context_line":"            odl_const.ODL_CREATE,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_9e24690d","line":98,"range":{"start_line":97,"start_character":7,"end_line":98,"end_character":43},"updated":"2017-01-31 18:43:03.000000000","message":"same as L64","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                bgpvpn\u003dbgpvpns[0][\u0027id\u0027])"},{"line_number":97,"context_line":"        LOG.debug(\"ODL: Precommit Assoc Networks to BGPVPN %(net_assoc)s\","},{"line_number":98,"context_line":"                  {\u0027net_assoc\u0027: net_assoc})"},{"line_number":99,"context_line":"        self._record_in_journal("},{"line_number":100,"context_line":"            context, odl_const.ODL_BGPVPN_NETWORK_ASSOCIATION,"},{"line_number":101,"context_line":"            odl_const.ODL_CREATE,"},{"line_number":102,"context_line":"            net_assoc)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def delete_net_assoc_precommit(self, context, net_assoc):"},{"line_number":105,"context_line":"        LOG.debug(\"ODL: Precommit Delete Assoc Networks to BGPVPN\""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_1ec239e9","line":102,"range":{"start_line":99,"start_character":8,"end_line":102,"end_character":22},"updated":"2017-01-31 18:43:03.000000000","message":"same as L70","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            net_assoc)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def delete_net_assoc_precommit(self, context, net_assoc):"},{"line_number":105,"context_line":"        LOG.debug(\"ODL: Precommit Delete Assoc Networks to BGPVPN\""},{"line_number":106,"context_line":"                  \" %(net_assoc)s\", {\u0027net_assoc\u0027: net_assoc})"},{"line_number":107,"context_line":"        # TODO(vthapar) decorate data with parent ids"},{"line_number":108,"context_line":"        self._record_in_journal("},{"line_number":109,"context_line":"            context, odl_const.ODL_BGPVPN_NETWORK_ASSOCIATION,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_7e709d0b","line":106,"range":{"start_line":105,"start_character":7,"end_line":106,"end_character":61},"updated":"2017-01-31 18:43:03.000000000","message":"same as L64","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        LOG.debug(\"ODL: Precommit Delete Assoc Networks to BGPVPN\""},{"line_number":106,"context_line":"                  \" %(net_assoc)s\", {\u0027net_assoc\u0027: net_assoc})"},{"line_number":107,"context_line":"        # TODO(vthapar) decorate data with parent ids"},{"line_number":108,"context_line":"        self._record_in_journal("},{"line_number":109,"context_line":"            context, odl_const.ODL_BGPVPN_NETWORK_ASSOCIATION,"},{"line_number":110,"context_line":"            odl_const.ODL_DELETE, net_assoc[\u0027id\u0027],"},{"line_number":111,"context_line":"            net_assoc)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def create_router_assoc_precommit(self, context, router_assoc):"},{"line_number":114,"context_line":"        associated_routers \u003d self.get_router_assocs(context,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_7eb33d98","line":111,"range":{"start_line":108,"start_character":8,"end_line":111,"end_character":21},"updated":"2017-01-31 18:43:03.000000000","message":"same as L70","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            if(router_assoc[\"router_id\"] !\u003d assoc_router[\"router_id\"]):"},{"line_number":118,"context_line":"                raise bgpvpn_ext.BGPVPNMultipleRouterAssocNotSupported("},{"line_number":119,"context_line":"                    driver\u003d\"OpenDaylight V2\")"},{"line_number":120,"context_line":"        LOG.debug(\"ODL: Precommit Assoc Routers to BGPVPN\""},{"line_number":121,"context_line":"                  \" %(router_assoc)s\", {\u0027router_assoc\u0027: router_assoc})"},{"line_number":122,"context_line":"        self._record_in_journal("},{"line_number":123,"context_line":"            context, odl_const.ODL_BGPVPN_ROUTER_ASSOCIATION,"},{"line_number":124,"context_line":"            odl_const.ODL_CREATE,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_fe62cd3c","line":121,"range":{"start_line":120,"start_character":8,"end_line":121,"end_character":70},"updated":"2017-01-31 18:43:03.000000000","message":"same as L64","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                    driver\u003d\"OpenDaylight V2\")"},{"line_number":120,"context_line":"        LOG.debug(\"ODL: Precommit Assoc Routers to BGPVPN\""},{"line_number":121,"context_line":"                  \" %(router_assoc)s\", {\u0027router_assoc\u0027: router_assoc})"},{"line_number":122,"context_line":"        self._record_in_journal("},{"line_number":123,"context_line":"            context, odl_const.ODL_BGPVPN_ROUTER_ASSOCIATION,"},{"line_number":124,"context_line":"            odl_const.ODL_CREATE,"},{"line_number":125,"context_line":"            router_assoc)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def delete_router_assoc_precommit(self, context, router_assoc):"},{"line_number":128,"context_line":"        LOG.debug(\"ODL: Precommit Delete Assoc Routers to BGPVPN\""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_9eae292c","line":125,"range":{"start_line":122,"start_character":9,"end_line":125,"end_character":25},"updated":"2017-01-31 18:43:03.000000000","message":"same as L70","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            router_assoc)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def delete_router_assoc_precommit(self, context, router_assoc):"},{"line_number":128,"context_line":"        LOG.debug(\"ODL: Precommit Delete Assoc Routers to BGPVPN\""},{"line_number":129,"context_line":"                  \" %(router_assoc)s\", {\u0027router_assoc\u0027: router_assoc})"},{"line_number":130,"context_line":"        # TODO(vthapar) decorate data with parent ids"},{"line_number":131,"context_line":"        self._record_in_journal("},{"line_number":132,"context_line":"            context, odl_const.ODL_BGPVPN_ROUTER_ASSOCIATION,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_be4da5c5","line":129,"range":{"start_line":128,"start_character":8,"end_line":129,"end_character":70},"updated":"2017-01-31 18:43:03.000000000","message":"same as L64","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ecfb59783c5b88071845d093c188300fd366ed3c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        LOG.debug(\"ODL: Precommit Delete Assoc Routers to BGPVPN\""},{"line_number":129,"context_line":"                  \" %(router_assoc)s\", {\u0027router_assoc\u0027: router_assoc})"},{"line_number":130,"context_line":"        # TODO(vthapar) decorate data with parent ids"},{"line_number":131,"context_line":"        self._record_in_journal("},{"line_number":132,"context_line":"            context, odl_const.ODL_BGPVPN_ROUTER_ASSOCIATION,"},{"line_number":133,"context_line":"            odl_const.ODL_DELETE, router_assoc[\u0027id\u0027],"},{"line_number":134,"context_line":"            router_assoc)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _postcommit(self, context):"},{"line_number":137,"context_line":"        self.journal.set_sync_event()"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a461143_bea92526","line":134,"range":{"start_line":131,"start_character":8,"end_line":134,"end_character":25},"updated":"2017-01-31 18:43:03.000000000","message":"same as L70","commit_id":"7d296bbaa18d3add6224940b8504eacc6822a4a2"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"3d63fe327a70633da3372840a5e7ca4b5cb0555a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            odl_const.ODL_DELETE, router_assoc[\u0027id\u0027],"},{"line_number":134,"context_line":"            router_assoc)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def _postcommit(self, context):"},{"line_number":137,"context_line":"        self.journal.set_sync_event()"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a430d35_96c5978f","line":136,"range":{"start_line":136,"start_character":26,"end_line":136,"end_character":33},"updated":"2017-02-07 01:39:56.000000000","message":"context isn\u0027t used.","commit_id":"6e79c508b2f6542992af030123260770ae34433a"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6817501307d9023670ca65afe62d0da5c0567292","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from networking_bgpvpn.neutron.db import bgpvpn_db"},{"line_number":22,"context_line":"from networking_bgpvpn.neutron.extensions import bgpvpn as bgpvpn_ext"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from networking_bgpvpn.neutron.services.service_drivers import driver_api"},{"line_number":25,"context_line":"from networking_odl._i18n import _LI"},{"line_number":26,"context_line":"from networking_odl.common import constants as odl_const"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a430d35_fda465ba","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":0},"updated":"2017-02-09 20:09:04.000000000","message":"pep8: unnecessary blank line.","commit_id":"52d0d3ed244de8014d6b4277f8a12ab924b22135"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"3c914990521d24e9fdf9db3f94ccf8187ca95cff","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from networking_bgpvpn.neutron.db import bgpvpn_db"},{"line_number":22,"context_line":"from networking_bgpvpn.neutron.extensions import bgpvpn as bgpvpn_ext"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from networking_bgpvpn.neutron.services.service_drivers import driver_api"},{"line_number":25,"context_line":"from networking_odl._i18n import _LI"},{"line_number":26,"context_line":"from networking_odl.common import constants as odl_const"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa31d9ce_6db6113f","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":0},"in_reply_to":"1a430d35_fda465ba","updated":"2017-02-09 20:55:37.000000000","message":"Done","commit_id":"52d0d3ed244de8014d6b4277f8a12ab924b22135"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d2fa2ec7c2056bc824103e8e3e4f8b8665396adb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.service_plugin \u003d service_plugin"},{"line_number":46,"context_line":"        self.journal \u003d journal.OpendaylightJournalThread()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @log_helpers.log_method_call"},{"line_number":49,"context_line":"    def create_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_f3e80919","line":48,"updated":"2017-02-10 11:05:34.000000000","message":"might as well remove the logs too if we\u0027re not doing anything.","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"0948326a245ca101b18bc1c7794f1201cf3d7502","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.service_plugin \u003d service_plugin"},{"line_number":46,"context_line":"        self.journal \u003d journal.OpendaylightJournalThread()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @log_helpers.log_method_call"},{"line_number":49,"context_line":"    def create_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_84106150","line":48,"in_reply_to":"fa31d9ce_f3e80919","updated":"2017-02-10 11:52:58.000000000","message":"Done","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d2fa2ec7c2056bc824103e8e3e4f8b8665396adb","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @log_helpers.log_method_call"},{"line_number":95,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":96,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":98,"context_line":"        self._postcommit()"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_73afb9e3","line":96,"updated":"2017-02-10 11:05:34.000000000","message":"Why not record in precommit for bgpvpn CRUDS? Association ones I understand, we may not have updated bgpvpn to send across, but why this for all?","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d47c84431b383ccbf543c7b7d5c0489d30285d0c","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @log_helpers.log_method_call"},{"line_number":95,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":96,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":98,"context_line":"        self._postcommit()"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_ed728448","line":96,"in_reply_to":"fa31d9ce_0d9c38bf","updated":"2017-02-13 18:57:54.000000000","message":"I don\u0027t think there\u0027s any issue, I think vivek just picked to do in postcommit coz he wasn\u0027t sure why we need to do in precommit. From your explanation it looks like record should be in precommit, right? I can make the change when doing rebase, but may take some time testing as units will need to be modified.","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"984f2ffd1b73e8a2f469c962ed511ab6575772ad","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @log_helpers.log_method_call"},{"line_number":95,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":96,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":98,"context_line":"        self._postcommit()"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_e603e2b6","line":96,"in_reply_to":"fa31d9ce_690c2843","updated":"2017-02-10 12:15:50.000000000","message":"It is the pattern being followed in all of v2, but if I had to guess I\u0027d say it allows dependencies to be handled in right order. Probably helps when running openstack in cluster setup.","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"0948326a245ca101b18bc1c7794f1201cf3d7502","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @log_helpers.log_method_call"},{"line_number":95,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":96,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":98,"context_line":"        self._postcommit()"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_690c2843","line":96,"in_reply_to":"fa31d9ce_73afb9e3","updated":"2017-02-10 11:52:58.000000000","message":"I am not sure what kind of benefit comes in if I record in pre-commit.  Until post-commit succeeds, we don\u0027t do anything with the record per se.","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"546df19d35530e13ad9d1b3701e3db2a5e5f4975","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @log_helpers.log_method_call"},{"line_number":95,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":96,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":98,"context_line":"        self._postcommit()"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_0d9c38bf","line":96,"in_reply_to":"fa31d9ce_a6f80a7e","updated":"2017-02-13 18:47:35.000000000","message":"No. It\u0027s not safe to record in postcommit because it\u0027s outside of db transaction in question.\nSo what\u0027s the issue with those precommit?","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"45f9f8419a919bb2c2c803632b12aed177fe7520","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @log_helpers.log_method_call"},{"line_number":95,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":96,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":98,"context_line":"        self._postcommit()"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_a6f80a7e","line":96,"in_reply_to":"fa31d9ce_e603e2b6","updated":"2017-02-10 12:19:52.000000000","message":"Oho, this is because of timestamp based management with journal records.\n\nIn that case, i would safely retain all of the resource here either totally inside precommit (or) totally inside postcommit.\n\nprecommit doesn\u0027t work with bgpvpn update/router-assoc/net-assoc.  \n\nSo I guess we would be safe to retain everything in postcocmmit only.  Feel free to lemme know if you think otherwise.","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"394de42becd292d7895afca3e3c949f0e43e8961","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @log_helpers.log_method_call"},{"line_number":95,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":96,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":98,"context_line":"        self._postcommit()"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_46dfdf0c","line":96,"in_reply_to":"fa31d9ce_ed728448","updated":"2017-02-14 04:39:51.000000000","message":"Isaku,\n\nPrecommit did not have the data in the format we require to be pushed to the journal.\n\nWhereas postcommit already had the data in the format we needed for the journal.  So we went ahead and used postcommit.\n\nSince you need to record the journal inside the DB Transaction, we will move this content to precommit with appropriate changes.","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d2fa2ec7c2056bc824103e8e3e4f8b8665396adb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":96,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":98,"context_line":"        self._postcommit()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @log_helpers.log_method_call"},{"line_number":101,"context_line":"    def delete_bgpvpn_postcommit(self, context, bgpvpn):"}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_7396d995","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":26},"updated":"2017-02-10 11:05:34.000000000","message":"might as well remove this and use set_sync_event() directly.","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"0948326a245ca101b18bc1c7794f1201cf3d7502","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":96,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":98,"context_line":"        self._postcommit()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @log_helpers.log_method_call"},{"line_number":101,"context_line":"    def delete_bgpvpn_postcommit(self, context, bgpvpn):"}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_89addc33","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":26},"in_reply_to":"fa31d9ce_7396d995","updated":"2017-02-10 11:52:58.000000000","message":"Done","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"d2fa2ec7c2056bc824103e8e3e4f8b8665396adb","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    @log_helpers.log_method_call"},{"line_number":101,"context_line":"    def delete_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":102,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":103,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_DELETE, bgpvpn)"},{"line_number":104,"context_line":"        self._postcommit()"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_ee9adec4","line":103,"range":{"start_line":103,"start_character":59,"end_line":103,"end_character":65},"updated":"2017-02-10 11:05:34.000000000","message":"for delete data needs to be list of network and router ids it is currently associated with. though I think all associates need to be pre-deleted so should be fine. can just pass [] instead of bgpvpn, will optimize delete dependency check.","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"0948326a245ca101b18bc1c7794f1201cf3d7502","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    @log_helpers.log_method_call"},{"line_number":101,"context_line":"    def delete_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":102,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":103,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_DELETE, bgpvpn)"},{"line_number":104,"context_line":"        self._postcommit()"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":30,"id":"fa31d9ce_c903540e","line":103,"range":{"start_line":103,"start_character":59,"end_line":103,"end_character":65},"in_reply_to":"fa31d9ce_ee9adec4","updated":"2017-02-10 11:52:58.000000000","message":"Done","commit_id":"1813ecc95ca23469414f2e0f2667be755d6b688c"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ba359753ff50a5746c51755d28222d0071045951","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @log_helpers.log_method_call"},{"line_number":87,"context_line":"    def create_bgpvpn_postcommit(self, context, bgpvpn):"},{"line_number":88,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":89,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":90,"context_line":"        self.journal.set_sync_event()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":34,"id":"fa31d9ce_328cfb34","line":89,"range":{"start_line":88,"start_character":0,"end_line":89,"end_character":66},"updated":"2017-02-13 19:12:59.000000000","message":"all journal.record should be done in precommit.\nNot by postcommit.","commit_id":"9ae355cdbe05b8a16052aa7510ddf6cb604b0011"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"7503c300af408064539539374783d5e9ddacf084","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.service_plugin \u003d service_plugin"},{"line_number":46,"context_line":"        self.journal \u003d journal.OpendaylightJournalThread()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def create_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":49,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":50,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":51,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":35,"id":"fa31d9ce_4b2d2afd","line":48,"updated":"2017-02-14 04:05:54.000000000","message":"@log_helpers.log_method_call for consistency.\nsame below.","commit_id":"b1af44d5831803b727173e21ef4a12dded596d4a"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"e6dfcab35f454ca0d75ea15a419ef1bcbe5ec6a4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.service_plugin \u003d service_plugin"},{"line_number":46,"context_line":"        self.journal \u003d journal.OpendaylightJournalThread()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def create_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":49,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":50,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_CREATE, bgpvpn)"},{"line_number":51,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":35,"id":"fa31d9ce_064a4755","line":48,"in_reply_to":"fa31d9ce_4b2d2afd","updated":"2017-02-14 04:21:14.000000000","message":"Done","commit_id":"b1af44d5831803b727173e21ef4a12dded596d4a"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"7503c300af408064539539374783d5e9ddacf084","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                \u0027networks\u0027: [net_assoc[\u0027network_id\u0027]],"},{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        if len(bgpvpns) \u003e 1:"},{"line_number":72,"context_line":"            raise bgpvpn_ext.BGPVPNNetworkAssocExistsAnotherBgpvpn("},{"line_number":73,"context_line":"                driver\u003d\"OpenDaylight V2\","},{"line_number":74,"context_line":"                network\u003dnet_assoc[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":35,"id":"fa31d9ce_8b33a261","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":28},"updated":"2017-02-14 04:05:54.000000000","message":"Please add comment per Manjeet comment.","commit_id":"b1af44d5831803b727173e21ef4a12dded596d4a"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"e6dfcab35f454ca0d75ea15a419ef1bcbe5ec6a4","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                \u0027networks\u0027: [net_assoc[\u0027network_id\u0027]],"},{"line_number":69,"context_line":"            },"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        if len(bgpvpns) \u003e 1:"},{"line_number":72,"context_line":"            raise bgpvpn_ext.BGPVPNNetworkAssocExistsAnotherBgpvpn("},{"line_number":73,"context_line":"                driver\u003d\"OpenDaylight V2\","},{"line_number":74,"context_line":"                network\u003dnet_assoc[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":35,"id":"fa31d9ce_26474b4c","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":28},"in_reply_to":"fa31d9ce_8b33a261","updated":"2017-02-14 04:21:14.000000000","message":"Done","commit_id":"b1af44d5831803b727173e21ef4a12dded596d4a"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6273bd2a8e827a31b0e88f3da6e05577cd1bc645","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                driver\u003d\"OpenDaylight V2\","},{"line_number":75,"context_line":"                network\u003dnet_assoc[\u0027network_id\u0027],"},{"line_number":76,"context_line":"                bgpvpn\u003dbgpvpns[0][\u0027id\u0027])"},{"line_number":77,"context_line":"        bgpvpn \u003d bgpvpns[0]"},{"line_number":78,"context_line":"        if bgpvpn[\u0027network_id\u0027] is None:"},{"line_number":79,"context_line":"            bgpvpn[\u0027network_id\u0027] \u003d []"},{"line_number":80,"context_line":"        bgpvpn[\u0027network_id\u0027].append(net_assoc[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_86db974e","line":77,"updated":"2017-02-14 04:38:33.000000000","message":"what  if for some reason there is no bgpvpn at all with that network_id?\n\nbetter to \nbgpvpn \u003d bgpvpns.get(0)\nif bgpvpn:\n\notherwise better to do:\nbgpvpn \u003d self.get_bgpvpn(net_assoc[bgpvpn_id])\nif bgpvn:\n  then ...","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"c48848ac61aea3399770d32a0cf300db17ba8a61","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                driver\u003d\"OpenDaylight V2\","},{"line_number":75,"context_line":"                network\u003dnet_assoc[\u0027network_id\u0027],"},{"line_number":76,"context_line":"                bgpvpn\u003dbgpvpns[0][\u0027id\u0027])"},{"line_number":77,"context_line":"        bgpvpn \u003d bgpvpns[0]"},{"line_number":78,"context_line":"        if bgpvpn[\u0027network_id\u0027] is None:"},{"line_number":79,"context_line":"            bgpvpn[\u0027network_id\u0027] \u003d []"},{"line_number":80,"context_line":"        bgpvpn[\u0027network_id\u0027].append(net_assoc[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_4606ff86","line":77,"in_reply_to":"fa31d9ce_86db974e","updated":"2017-02-14 05:37:35.000000000","message":"If bgpvpn exists we already got it in get_bgpvpns, want to avoid making another dbquery for data we already have. will go with bgpvpn\u003dbgpvpns.get(0) But is it possible to get association without a bgpvpn with same netid? I expect plugin to throw exception for it.","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6273bd2a8e827a31b0e88f3da6e05577cd1bc645","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                network\u003dnet_assoc[\u0027network_id\u0027],"},{"line_number":76,"context_line":"                bgpvpn\u003dbgpvpns[0][\u0027id\u0027])"},{"line_number":77,"context_line":"        bgpvpn \u003d bgpvpns[0]"},{"line_number":78,"context_line":"        if bgpvpn[\u0027network_id\u0027] is None:"},{"line_number":79,"context_line":"            bgpvpn[\u0027network_id\u0027] \u003d []"},{"line_number":80,"context_line":"        bgpvpn[\u0027network_id\u0027].append(net_assoc[\u0027network_id\u0027])"},{"line_number":81,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_66c14354","line":78,"updated":"2017-02-14 04:38:33.000000000","message":"if not bgpvpn[\u0027network_id\u0027] would be better.","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"c48848ac61aea3399770d32a0cf300db17ba8a61","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                network\u003dnet_assoc[\u0027network_id\u0027],"},{"line_number":76,"context_line":"                bgpvpn\u003dbgpvpns[0][\u0027id\u0027])"},{"line_number":77,"context_line":"        bgpvpn \u003d bgpvpns[0]"},{"line_number":78,"context_line":"        if bgpvpn[\u0027network_id\u0027] is None:"},{"line_number":79,"context_line":"            bgpvpn[\u0027network_id\u0027] \u003d []"},{"line_number":80,"context_line":"        bgpvpn[\u0027network_id\u0027].append(net_assoc[\u0027network_id\u0027])"},{"line_number":81,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_28dab917","line":78,"in_reply_to":"fa31d9ce_66c14354","updated":"2017-02-14 05:37:35.000000000","message":"Done","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6273bd2a8e827a31b0e88f3da6e05577cd1bc645","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def delete_net_assoc_precommit(self, context, net_assoc):"},{"line_number":85,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, net_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":86,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":87,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_c6d02f22","line":85,"updated":"2017-02-14 04:38:33.000000000","message":"if bgpvpn:\n\nSimilalry, you have to remove the network from that bgpvpn returned and only then ship the UPDATE here with that dict.","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"c48848ac61aea3399770d32a0cf300db17ba8a61","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def delete_net_assoc_precommit(self, context, net_assoc):"},{"line_number":85,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, net_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":86,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":87,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_68067187","line":85,"in_reply_to":"fa31d9ce_c6d02f22","updated":"2017-02-14 05:37:35.000000000","message":"Done","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6273bd2a8e827a31b0e88f3da6e05577cd1bc645","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if(router_assoc[\"router_id\"] !\u003d assoc_router[\"router_id\"]):"},{"line_number":95,"context_line":"                raise bgpvpn_ext.BGPVPNMultipleRouterAssocNotSupported("},{"line_number":96,"context_line":"                    driver\u003d\"OpenDaylight V2\")"},{"line_number":97,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, router_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":98,"context_line":"        if bgpvpn[\u0027router_id\u0027] is None:"},{"line_number":99,"context_line":"            bgpvpn[\u0027router_id\u0027] \u003d []"},{"line_number":100,"context_line":"        bgpvpn[\u0027router_id\u0027].append(router_assoc[\u0027router_id\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_e6945344","line":97,"updated":"2017-02-14 04:38:33.000000000","message":"this pattern you can for for net_assoc_precommit also.","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"c48848ac61aea3399770d32a0cf300db17ba8a61","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            if(router_assoc[\"router_id\"] !\u003d assoc_router[\"router_id\"]):"},{"line_number":95,"context_line":"                raise bgpvpn_ext.BGPVPNMultipleRouterAssocNotSupported("},{"line_number":96,"context_line":"                    driver\u003d\"OpenDaylight V2\")"},{"line_number":97,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, router_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":98,"context_line":"        if bgpvpn[\u0027router_id\u0027] is None:"},{"line_number":99,"context_line":"            bgpvpn[\u0027router_id\u0027] \u003d []"},{"line_number":100,"context_line":"        bgpvpn[\u0027router_id\u0027].append(router_assoc[\u0027router_id\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_a8fce972","line":97,"in_reply_to":"fa31d9ce_e6945344","updated":"2017-02-14 05:37:35.000000000","message":"Done","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6273bd2a8e827a31b0e88f3da6e05577cd1bc645","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                raise bgpvpn_ext.BGPVPNMultipleRouterAssocNotSupported("},{"line_number":96,"context_line":"                    driver\u003d\"OpenDaylight V2\")"},{"line_number":97,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, router_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":98,"context_line":"        if bgpvpn[\u0027router_id\u0027] is None:"},{"line_number":99,"context_line":"            bgpvpn[\u0027router_id\u0027] \u003d []"},{"line_number":100,"context_line":"        bgpvpn[\u0027router_id\u0027].append(router_assoc[\u0027router_id\u0027])"},{"line_number":101,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_668f832a","line":98,"updated":"2017-02-14 04:38:33.000000000","message":"if not bgpvpn[\u0027router_id\u0027]:","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"c48848ac61aea3399770d32a0cf300db17ba8a61","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                raise bgpvpn_ext.BGPVPNMultipleRouterAssocNotSupported("},{"line_number":96,"context_line":"                    driver\u003d\"OpenDaylight V2\")"},{"line_number":97,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, router_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":98,"context_line":"        if bgpvpn[\u0027router_id\u0027] is None:"},{"line_number":99,"context_line":"            bgpvpn[\u0027router_id\u0027] \u003d []"},{"line_number":100,"context_line":"        bgpvpn[\u0027router_id\u0027].append(router_assoc[\u0027router_id\u0027])"},{"line_number":101,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_c8011d6c","line":98,"in_reply_to":"fa31d9ce_668f832a","updated":"2017-02-14 05:37:35.000000000","message":"Done","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6273bd2a8e827a31b0e88f3da6e05577cd1bc645","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def delete_router_assoc_precommit(self, context, router_assoc):"},{"line_number":105,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, router_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":106,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":107,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _postcommit(self, context):"},{"line_number":110,"context_line":"        self.journal.set_sync_event()"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_c67e6f18","line":107,"updated":"2017-02-14 04:38:33.000000000","message":"you have to remove the router_id from the router-list of bgpvpn, before firing the UPDATE here.","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"c48848ac61aea3399770d32a0cf300db17ba8a61","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def delete_router_assoc_precommit(self, context, router_assoc):"},{"line_number":105,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, router_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":106,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":107,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _postcommit(self, context):"},{"line_number":110,"context_line":"        self.journal.set_sync_event()"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_08f8957a","line":107,"in_reply_to":"fa31d9ce_c67e6f18","updated":"2017-02-14 05:37:35.000000000","message":"Done","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6273bd2a8e827a31b0e88f3da6e05577cd1bc645","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":107,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _postcommit(self, context):"},{"line_number":110,"context_line":"        self.journal.set_sync_event()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_a6297b39","line":109,"updated":"2017-02-14 04:38:33.000000000","message":"context not required.","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"c48848ac61aea3399770d32a0cf300db17ba8a61","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":107,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _postcommit(self, context):"},{"line_number":110,"context_line":"        self.journal.set_sync_event()"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa31d9ce_28f1d995","line":109,"in_reply_to":"fa31d9ce_a6297b39","updated":"2017-02-14 05:37:35.000000000","message":"Done","commit_id":"ec14133d02174884cdcae57011e8aeb4da3c4a78"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"aad6fb48ea1939cd34c3a4e5b726b32b64ae2773","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                driver\u003d\"OpenDaylight V2\","},{"line_number":75,"context_line":"                network\u003dnet_assoc[\u0027network_id\u0027],"},{"line_number":76,"context_line":"                bgpvpn\u003dbgpvpns[0][\u0027id\u0027])"},{"line_number":77,"context_line":"        elif len(bgpvpns) \u003d\u003d 0:"},{"line_number":78,"context_line":"            return"},{"line_number":79,"context_line":"        bgpvpn \u003d bgpvpns[0]"},{"line_number":80,"context_line":"        if not bgpvpn[\u0027networks\u0027]:"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa31d9ce_489b6d72","line":77,"updated":"2017-02-14 05:31:39.000000000","message":"if there is no bgpvpns with that network, then this is the first bgpvpn with this network and you MUST proceed to make use of this call to store into the journal :)\n\nYou can code this area similar to create_router_assoc_precommit.","commit_id":"67ab38de89222a061127390f333ecb2e4d1d160c"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"bee8a68245294ba2b5ac858d4485ffe8c0668b37","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                driver\u003d\"OpenDaylight V2\","},{"line_number":75,"context_line":"                network\u003dnet_assoc[\u0027network_id\u0027],"},{"line_number":76,"context_line":"                bgpvpn\u003dbgpvpns[0][\u0027id\u0027])"},{"line_number":77,"context_line":"        elif len(bgpvpns) \u003d\u003d 0:"},{"line_number":78,"context_line":"            return"},{"line_number":79,"context_line":"        bgpvpn \u003d bgpvpns[0]"},{"line_number":80,"context_line":"        if not bgpvpn[\u0027networks\u0027]:"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa31d9ce_68df510d","line":77,"in_reply_to":"fa31d9ce_489b6d72","updated":"2017-02-14 05:38:12.000000000","message":"Done","commit_id":"67ab38de89222a061127390f333ecb2e4d1d160c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"580eaf4a36dd7973b13348cee15ce1e6e7926bab","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        elif len(bgpvpns) \u003d\u003d 0:"},{"line_number":78,"context_line":"            bgpvpn \u003d self.get_bgpvpn(context, net_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            bgpvpn \u003d bgpvpns[0]"},{"line_number":81,"context_line":"        if not bgpvpn[\u0027networks\u0027]:"},{"line_number":82,"context_line":"            bgpvpn[\u0027networks\u0027] \u003d []"},{"line_number":83,"context_line":"        bgpvpn[\u0027networks\u0027].append(net_assoc[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":38,"id":"fa31d9ce_8ba2bffb","line":80,"updated":"2017-02-14 05:58:05.000000000","message":"if you already got a bgpvpn for the input network from your query, and if the same network is being added isn\u0027t it an error.  \n\nFurther how do we know that the bgpvpn returned by the get_bgpvpns() query L65 is the same bgpvpn to which this network is intended to be added.\n\nI believe the best is to directly do a get_bgpvpn() , i.e., make L78 common and use that bgpvpn to update the network list below.","commit_id":"9fd631b46fec5ee409241b35cbef13ae9680a47c"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"8241c83ee8430a5b2d32bc2f051427c1d1b1fae8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        elif len(bgpvpns) \u003d\u003d 0:"},{"line_number":78,"context_line":"            bgpvpn \u003d self.get_bgpvpn(context, net_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            bgpvpn \u003d bgpvpns[0]"},{"line_number":81,"context_line":"        if not bgpvpn[\u0027networks\u0027]:"},{"line_number":82,"context_line":"            bgpvpn[\u0027networks\u0027] \u003d []"},{"line_number":83,"context_line":"        bgpvpn[\u0027networks\u0027].append(net_assoc[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":38,"id":"fa31d9ce_cb44b71c","line":80,"in_reply_to":"fa31d9ce_8ba2bffb","updated":"2017-02-14 06:05:53.000000000","message":"When this is called, will get_bgpvpns have this bgpvpn included or not? Your first and second comment are incompatible. Either get_bgpvpns will include current assoction, or it will not. If it includes, then self.get_bgpvpn is not needed. If it doesn\u0027t, then len(bgpvpns) \u003e 0 should be the check. If bgpvps[0] is different and I use get_bgpvpn() we\u0027ll end up with 2 bgpvpns having this network.","commit_id":"9fd631b46fec5ee409241b35cbef13ae9680a47c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"50a7a528482dfba149ee9b6a68706fb271efed45","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        elif len(bgpvpns) \u003d\u003d 0:"},{"line_number":78,"context_line":"            bgpvpn \u003d self.get_bgpvpn(context, net_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            bgpvpn \u003d bgpvpns[0]"},{"line_number":81,"context_line":"        if not bgpvpn[\u0027networks\u0027]:"},{"line_number":82,"context_line":"            bgpvpn[\u0027networks\u0027] \u003d []"},{"line_number":83,"context_line":"        bgpvpn[\u0027networks\u0027].append(net_assoc[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":38,"id":"fa31d9ce_8e7bad8b","line":80,"in_reply_to":"fa31d9ce_abb4e381","updated":"2017-02-14 06:35:36.000000000","message":"As we discussed should be checking\n\nlen(bgpvpns) \u003e 0 in L72.","commit_id":"9fd631b46fec5ee409241b35cbef13ae9680a47c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"54e9335a1132d9e58a3a5369918042401cd33b1c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        elif len(bgpvpns) \u003d\u003d 0:"},{"line_number":78,"context_line":"            bgpvpn \u003d self.get_bgpvpn(context, net_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            bgpvpn \u003d bgpvpns[0]"},{"line_number":81,"context_line":"        if not bgpvpn[\u0027networks\u0027]:"},{"line_number":82,"context_line":"            bgpvpn[\u0027networks\u0027] \u003d []"},{"line_number":83,"context_line":"        bgpvpn[\u0027networks\u0027].append(net_assoc[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":38,"id":"fa31d9ce_ebddfbe0","line":80,"in_reply_to":"fa31d9ce_cb44b71c","updated":"2017-02-14 06:23:06.000000000","message":"get_bgpvpns will NOT list you the bgpvpn , if this is the first network on that bgpvpn.","commit_id":"9fd631b46fec5ee409241b35cbef13ae9680a47c"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"40a0d2e279bfe20b33bc72cd40a55a5d12a4c4d8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        elif len(bgpvpns) \u003d\u003d 0:"},{"line_number":78,"context_line":"            bgpvpn \u003d self.get_bgpvpn(context, net_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":79,"context_line":"        else:"},{"line_number":80,"context_line":"            bgpvpn \u003d bgpvpns[0]"},{"line_number":81,"context_line":"        if not bgpvpn[\u0027networks\u0027]:"},{"line_number":82,"context_line":"            bgpvpn[\u0027networks\u0027] \u003d []"},{"line_number":83,"context_line":"        bgpvpn[\u0027networks\u0027].append(net_assoc[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":38,"id":"fa31d9ce_abb4e381","line":80,"in_reply_to":"fa31d9ce_ebddfbe0","updated":"2017-02-14 06:26:27.000000000","message":"get_bgpvpns is getting BGPVPNs that are already using this network. If other bgpvpn is using this network, len(bgpvpns) will be 1. In that case if I use get_bgppvn() and this network to current one, we will end up with two bgppvns associated with this network which will end up overriding the if check above.","commit_id":"9fd631b46fec5ee409241b35cbef13ae9680a47c"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e9c45bc987b4f072497b822cf58d85fcad422f3c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        for assoc_router in associated_routers:"},{"line_number":96,"context_line":"            if(router_assoc[\"router_id\"] !\u003d assoc_router[\"router_id\"]):"},{"line_number":97,"context_line":"                raise bgpvpn_ext.BGPVPNMultipleRouterAssocNotSupported("},{"line_number":98,"context_line":"                    driver\u003d\"OpenDaylight V2\")"},{"line_number":99,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, router_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":100,"context_line":"        if not bgpvpn[\u0027routers\u0027]:"},{"line_number":101,"context_line":"            bgpvpn[\u0027routers\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_31c78465","line":98,"updated":"2017-02-14 07:41:25.000000000","message":"It would be good to add the validation that a router cannot be part of two bgpvpns.  I understand this is absent in the v1 driver, but would be good to have it in both.","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"18c6812854be6597be8071a23b8345c935acdee7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        for assoc_router in associated_routers:"},{"line_number":96,"context_line":"            if(router_assoc[\"router_id\"] !\u003d assoc_router[\"router_id\"]):"},{"line_number":97,"context_line":"                raise bgpvpn_ext.BGPVPNMultipleRouterAssocNotSupported("},{"line_number":98,"context_line":"                    driver\u003d\"OpenDaylight V2\")"},{"line_number":99,"context_line":"        bgpvpn \u003d self.get_bgpvpn(context, router_assoc[\u0027bgpvpn_id\u0027])"},{"line_number":100,"context_line":"        if not bgpvpn[\u0027routers\u0027]:"},{"line_number":101,"context_line":"            bgpvpn[\u0027routers\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_1cb8d729","line":98,"in_reply_to":"fa31d9ce_31c78465","updated":"2017-02-14 07:52:21.000000000","message":"Since it is absent in v1 driver it can break deployments which are already using it. Can add it later as fix if needed.","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a1c69b378325214daeed5b59a3244d605dd4df04","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @log_helpers.log_method_call"},{"line_number":42,"context_line":"    def __init__(self, service_plugin, validator\u003dNone):"},{"line_number":43,"context_line":"        LOG.info(_LI(\"Initializing OpenDaylight BGPVPN v2 driver\"))"},{"line_number":44,"context_line":"        super(OpenDaylightBgpvpnDriver, self).__init__(service_plugin)"},{"line_number":45,"context_line":"        self.service_plugin \u003d service_plugin"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_5fd05a1f","line":42,"range":{"start_line":42,"start_character":37,"end_line":42,"end_character":53},"updated":"2017-02-14 23:18:25.000000000","message":"is this necessary? the base class doesn\u0027t seem to have this argument.","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"001ca8a04c122cdf24a30d9ee9c038e108208525","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @log_helpers.log_method_call"},{"line_number":42,"context_line":"    def __init__(self, service_plugin, validator\u003dNone):"},{"line_number":43,"context_line":"        LOG.info(_LI(\"Initializing OpenDaylight BGPVPN v2 driver\"))"},{"line_number":44,"context_line":"        super(OpenDaylightBgpvpnDriver, self).__init__(service_plugin)"},{"line_number":45,"context_line":"        self.service_plugin \u003d service_plugin"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_85c27ce7","line":42,"range":{"start_line":42,"start_character":37,"end_line":42,"end_character":53},"in_reply_to":"fa31d9ce_5fd05a1f","updated":"2017-02-15 02:33:27.000000000","message":"Done","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a1c69b378325214daeed5b59a3244d605dd4df04","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def __init__(self, service_plugin, validator\u003dNone):"},{"line_number":43,"context_line":"        LOG.info(_LI(\"Initializing OpenDaylight BGPVPN v2 driver\"))"},{"line_number":44,"context_line":"        super(OpenDaylightBgpvpnDriver, self).__init__(service_plugin)"},{"line_number":45,"context_line":"        self.service_plugin \u003d service_plugin"},{"line_number":46,"context_line":"        self.journal \u003d journal.OpendaylightJournalThread()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_bfc31656","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":44},"updated":"2017-02-14 23:18:25.000000000","message":"unnecessary","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"001ca8a04c122cdf24a30d9ee9c038e108208525","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def __init__(self, service_plugin, validator\u003dNone):"},{"line_number":43,"context_line":"        LOG.info(_LI(\"Initializing OpenDaylight BGPVPN v2 driver\"))"},{"line_number":44,"context_line":"        super(OpenDaylightBgpvpnDriver, self).__init__(service_plugin)"},{"line_number":45,"context_line":"        self.service_plugin \u003d service_plugin"},{"line_number":46,"context_line":"        self.journal \u003d journal.OpendaylightJournalThread()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_e5b33896","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":44},"in_reply_to":"fa31d9ce_bfc31656","updated":"2017-02-15 02:33:27.000000000","message":"Done","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a1c69b378325214daeed5b59a3244d605dd4df04","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":56,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":59,"context_line":"        pass"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_df328a0f","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":31},"updated":"2017-02-14 23:18:25.000000000","message":"why to have no-op method no one uses?","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"001ca8a04c122cdf24a30d9ee9c038e108208525","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        journal.record(context, None, odl_const.ODL_BGPVPN,"},{"line_number":56,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete_bgpvpn_precommit(self, context, bgpvpn):"},{"line_number":59,"context_line":"        pass"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @log_helpers.log_method_call"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_654d8899","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":31},"in_reply_to":"fa31d9ce_df328a0f","updated":"2017-02-15 02:33:27.000000000","message":"Keep delete_xxx_precommit for future TODO.\nat the moment, bgpvpn driver interface doesn\u0027t define delete_xxx_precommit interface.\nIt needs to be fixed in Pike.","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"}],"networking_odl/journal/dependency_validations.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a670cb37f26f5c08bf456718cc044c25bc157208","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    return True"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"def validate_bgpvpn(session, row):"},{"line_number":227,"context_line":"    \"\"\"Validate bgpvpn operation based on dependencies."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    Validate bgpvpn operation depending on whether it\u0027s"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_b824e70c","line":226,"updated":"2017-01-24 02:42:40.000000000","message":"Although I haven\u0027t checked bgpvpn api, it seems like more dependency check is needed.","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"9c4ac6ce2b254ede5c8390a7195b4637524baa71","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    return True"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"def validate_bgpvpn(session, row):"},{"line_number":227,"context_line":"    \"\"\"Validate bgpvpn operation based on dependencies."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    Validate bgpvpn operation depending on whether it\u0027s"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_af3d7ade","line":226,"in_reply_to":"5a3905b3_b824e70c","updated":"2017-01-24 04:26:25.000000000","message":"Nope.. BGPVPN creation uses all new parameters except Tenant-ID which is required from Openstack.","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"def _generate_bgpvpn_deps(row):"},{"line_number":119,"context_line":"    object_ids \u003d []"},{"line_number":120,"context_line":"    print \u0027HAHAHAHAHA\u0027, row.data"},{"line_number":121,"context_line":"    bgpvpn_id \u003d row.data.get(\u0027id\u0027)"},{"line_number":122,"context_line":"    if bgpvpn_id is not None:"},{"line_number":123,"context_line":"        object_ids.append(bgpvpn_id)"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_60a0b2f5","line":120,"updated":"2017-02-10 14:27:49.000000000","message":"we can remove this one :)","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b1200e162e35cba0f0b957dc86f47714eff70f3b","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"def _generate_bgpvpn_deps(row):"},{"line_number":119,"context_line":"    object_ids \u003d []"},{"line_number":120,"context_line":"    print \u0027HAHAHAHAHA\u0027, row.data"},{"line_number":121,"context_line":"    bgpvpn_id \u003d row.data.get(\u0027id\u0027)"},{"line_number":122,"context_line":"    if bgpvpn_id is not None:"},{"line_number":123,"context_line":"        object_ids.append(bgpvpn_id)"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_a0cf0aaf","line":120,"in_reply_to":"fa31d9ce_60a0b2f5","updated":"2017-02-10 14:33:34.000000000","message":"Oh yeah, missed this in cleanup.","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    if bgpvpn_id is not None:"},{"line_number":123,"context_line":"        object_ids.append(bgpvpn_id)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    network_id \u003d row.data.get(\u0027networks\u0027)"},{"line_number":126,"context_line":"    if network_id is not None:"},{"line_number":127,"context_line":"        object_ids.extend(network_id)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_a0aaaad2","line":125,"updated":"2017-02-10 14:27:49.000000000","message":"good catch","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    if network_id is not None:"},{"line_number":127,"context_line":"        object_ids.extend(network_id)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    router_id \u003d row.data.get(\u0027routers\u0027)"},{"line_number":130,"context_line":"    if router_id is not None:"},{"line_number":131,"context_line":"        object_ids.extend(router_id)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_00ba9623","line":129,"updated":"2017-02-10 14:27:49.000000000","message":"good catch :)","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e9c45bc987b4f072497b822cf58d85fcad422f3c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"def _generate_bgpvpn_deps(row):"},{"line_number":132,"context_line":"    object_ids \u003d []"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    network_id \u003d row.data.get(\u0027networks\u0027)"},{"line_number":135,"context_line":"    if network_id is not None:"},{"line_number":136,"context_line":"        object_ids.extend(network_id)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_d1eaa8ab","line":134,"updated":"2017-02-14 07:41:25.000000000","message":"network_ids as you will get a list of networks from the journal row.","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"18c6812854be6597be8071a23b8345c935acdee7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"def _generate_bgpvpn_deps(row):"},{"line_number":132,"context_line":"    object_ids \u003d []"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    network_id \u003d row.data.get(\u0027networks\u0027)"},{"line_number":135,"context_line":"    if network_id is not None:"},{"line_number":136,"context_line":"        object_ids.extend(network_id)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_fc406336","line":134,"in_reply_to":"fa31d9ce_d1eaa8ab","updated":"2017-02-14 07:52:21.000000000","message":"spelling nitpick, can address later. actual usage is like a list.","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e9c45bc987b4f072497b822cf58d85fcad422f3c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if network_id is not None:"},{"line_number":136,"context_line":"        object_ids.extend(network_id)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    router_id \u003d row.data.get(\u0027routers\u0027)"},{"line_number":139,"context_line":"    if router_id is not None:"},{"line_number":140,"context_line":"        object_ids.extend(router_id)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_31da2418","line":138,"updated":"2017-02-14 07:41:25.000000000","message":"router_ids,  as these will be a list of routers, though it will have only one router in the list due to our implementation :)","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"18c6812854be6597be8071a23b8345c935acdee7","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    if network_id is not None:"},{"line_number":136,"context_line":"        object_ids.extend(network_id)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    router_id \u003d row.data.get(\u0027routers\u0027)"},{"line_number":139,"context_line":"    if router_id is not None:"},{"line_number":140,"context_line":"        object_ids.extend(router_id)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_3c475b4c","line":138,"in_reply_to":"fa31d9ce_31da2418","updated":"2017-02-14 07:52:21.000000000","message":"same as above","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"}],"networking_odl/tests/unit/bgpvpn/test_odl_v2.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"09e55c6c3d5b665928424fe57fe62c5cd761b5e2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            self.assertEqual(object_type, row[\u0027object_type\u0027])"},{"line_number":79,"context_line":"            self.assertEqual(data[\u0027id\u0027], row[\u0027object_uuid\u0027])"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            self.assertEqual(None, row)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_create_bgpvpn(self):"},{"line_number":84,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_d8ef17e7","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":39},"updated":"2017-01-30 17:25:32.000000000","message":"this + processing or completed rows can also be fetched and it can be asserted if after postcommit is called is the row getting into those states or not","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"55a7dadd7cd828820aee5c3db31e6b25ba8e9a7e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            self.assertEqual(object_type, row[\u0027object_type\u0027])"},{"line_number":79,"context_line":"            self.assertEqual(data[\u0027id\u0027], row[\u0027object_uuid\u0027])"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            self.assertEqual(None, row)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_create_bgpvpn(self):"},{"line_number":84,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a461143_2f951a86","line":81,"range":{"start_line":81,"start_character":12,"end_line":81,"end_character":39},"in_reply_to":"3a461143_d8ef17e7","updated":"2017-01-31 10:39:13.000000000","message":"This needs support method to get all completed rows to be introduced inside db.py... Let me see if I can do so in next couple of PSes.","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ba359753ff50a5746c51755d28222d0071045951","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def test_create_bgpvpn(self):"},{"line_number":80,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"},{"line_number":81,"context_line":"        self.driver.create_bgpvpn_precommit(self.context, fake_data)"},{"line_number":82,"context_line":"        self.driver.create_bgpvpn_postcommit(self.context, fake_data)"},{"line_number":83,"context_line":"        self._assert_op(odl_const.ODL_CREATE, odl_const.ODL_BGPVPN,"},{"line_number":84,"context_line":"                        fake_data)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"fa31d9ce_124b7788","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":69},"updated":"2017-02-13 19:12:59.000000000","message":"postcommit should not be needed.","commit_id":"9ae355cdbe05b8a16052aa7510ddf6cb604b0011"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"7503c300af408064539539374783d5e9ddacf084","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.driver.create_bgpvpn_precommit(self.context, fake_data)"},{"line_number":85,"context_line":"        self._assert_op(odl_const.ODL_CREATE, odl_const.ODL_BGPVPN,"},{"line_number":86,"context_line":"                        fake_data)"},{"line_number":87,"context_line":"        self.driver.create_bgpvpn_postcommit(self.context, fake_data)"},{"line_number":88,"context_line":"        self._assert_op(odl_const.ODL_CREATE, odl_const.ODL_BGPVPN,"},{"line_number":89,"context_line":"                        fake_data, False)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"fa31d9ce_0b76d205","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":69},"updated":"2017-02-14 04:05:54.000000000","message":"postcommit doesn\u0027t call journal thread.\nand thread.start is mocked. journal sync method needs to be called.","commit_id":"b1af44d5831803b727173e21ef4a12dded596d4a"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"e6dfcab35f454ca0d75ea15a419ef1bcbe5ec6a4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.driver.create_bgpvpn_precommit(self.context, fake_data)"},{"line_number":85,"context_line":"        self._assert_op(odl_const.ODL_CREATE, odl_const.ODL_BGPVPN,"},{"line_number":86,"context_line":"                        fake_data)"},{"line_number":87,"context_line":"        self.driver.create_bgpvpn_postcommit(self.context, fake_data)"},{"line_number":88,"context_line":"        self._assert_op(odl_const.ODL_CREATE, odl_const.ODL_BGPVPN,"},{"line_number":89,"context_line":"                        fake_data, False)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"fa31d9ce_46eb5f13","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":69},"in_reply_to":"fa31d9ce_0b76d205","updated":"2017-02-14 04:21:14.000000000","message":"Could you clarify? in all other drivers also we\u0027re not calling journal sync. Won\u0027t have tests failed if it were needed?","commit_id":"b1af44d5831803b727173e21ef4a12dded596d4a"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e9c45bc987b4f072497b822cf58d85fcad422f3c","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_delete_router_assoc(self):"},{"line_number":128,"context_line":"        fake_rtr_assoc_data \u003d self._get_fake_router_assoc()"},{"line_number":129,"context_line":"        fake_bgpvpn_data \u003d self._get_fake_bgpvpn(router\u003dTrue)"},{"line_number":130,"context_line":"        with mock.patch.object(self.driver, \u0027get_bgpvpn\u0027,"},{"line_number":131,"context_line":"                               return_value\u003dfake_bgpvpn_data):"},{"line_number":132,"context_line":"            self.driver.delete_router_assoc_precommit(self.context,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_51731815","line":129,"updated":"2017-02-14 07:41:25.000000000","message":"router\u003dFalse here","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"18c6812854be6597be8071a23b8345c935acdee7","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def test_delete_router_assoc(self):"},{"line_number":128,"context_line":"        fake_rtr_assoc_data \u003d self._get_fake_router_assoc()"},{"line_number":129,"context_line":"        fake_bgpvpn_data \u003d self._get_fake_bgpvpn(router\u003dTrue)"},{"line_number":130,"context_line":"        with mock.patch.object(self.driver, \u0027get_bgpvpn\u0027,"},{"line_number":131,"context_line":"                               return_value\u003dfake_bgpvpn_data):"},{"line_number":132,"context_line":"            self.driver.delete_router_assoc_precommit(self.context,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_7c06331e","line":129,"in_reply_to":"fa31d9ce_51731815","updated":"2017-02-14 07:52:21.000000000","message":"we\u0027re using the same data for precommit and post both. we can do these enhancements later.","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e9c45bc987b4f072497b822cf58d85fcad422f3c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                                                      fake_rtr_assoc_data)"},{"line_number":134,"context_line":"            self._assert_op(odl_const.ODL_UPDATE,"},{"line_number":135,"context_line":"                            odl_const.ODL_BGPVPN,"},{"line_number":136,"context_line":"                            fake_bgpvpn_data)"},{"line_number":137,"context_line":"            self.driver.delete_router_assoc_postcommit(self.context,"},{"line_number":138,"context_line":"                                                       fake_rtr_assoc_data)"},{"line_number":139,"context_line":"            self._assert_op(odl_const.ODL_UPDATE,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_7162dc3f","line":136,"updated":"2017-02-14 07:41:25.000000000","message":"when this Op is called the data pushed will NOT have the router-id.","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"18c6812854be6597be8071a23b8345c935acdee7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                                                      fake_rtr_assoc_data)"},{"line_number":134,"context_line":"            self._assert_op(odl_const.ODL_UPDATE,"},{"line_number":135,"context_line":"                            odl_const.ODL_BGPVPN,"},{"line_number":136,"context_line":"                            fake_bgpvpn_data)"},{"line_number":137,"context_line":"            self.driver.delete_router_assoc_postcommit(self.context,"},{"line_number":138,"context_line":"                                                       fake_rtr_assoc_data)"},{"line_number":139,"context_line":"            self._assert_op(odl_const.ODL_UPDATE,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_3c191b7a","line":136,"in_reply_to":"fa31d9ce_7162dc3f","updated":"2017-02-14 07:52:21.000000000","message":"currently we\u0027re not checking these additional data. can enhance tests later.","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e9c45bc987b4f072497b822cf58d85fcad422f3c","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def test_create_net_assoc(self):"},{"line_number":144,"context_line":"        fake_net_assoc_data \u003d self._get_fake_net_assoc()"},{"line_number":145,"context_line":"        fake_net_upd_bgpvpn_data \u003d self._get_fake_bgpvpn(net\u003dFalse)"},{"line_number":146,"context_line":"        # todo(vivekanandan) add check for case when assoc already exists"},{"line_number":147,"context_line":"        with mock.patch.object(self.driver, \u0027get_bgpvpn\u0027,"},{"line_number":148,"context_line":"                               return_value\u003dfake_net_upd_bgpvpn_data), \\"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_91ce702c","line":145,"updated":"2017-02-14 07:41:25.000000000","message":"net\u003dTrue here","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"18c6812854be6597be8071a23b8345c935acdee7","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def test_create_net_assoc(self):"},{"line_number":144,"context_line":"        fake_net_assoc_data \u003d self._get_fake_net_assoc()"},{"line_number":145,"context_line":"        fake_net_upd_bgpvpn_data \u003d self._get_fake_bgpvpn(net\u003dFalse)"},{"line_number":146,"context_line":"        # todo(vivekanandan) add check for case when assoc already exists"},{"line_number":147,"context_line":"        with mock.patch.object(self.driver, \u0027get_bgpvpn\u0027,"},{"line_number":148,"context_line":"                               return_value\u003dfake_net_upd_bgpvpn_data), \\"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_7c2d5394","line":145,"in_reply_to":"fa31d9ce_91ce702c","updated":"2017-02-14 07:52:21.000000000","message":"same as above.","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e9c45bc987b4f072497b822cf58d85fcad422f3c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                                   fake_net_assoc_data)"},{"line_number":153,"context_line":"            self._assert_op(odl_const.ODL_UPDATE,"},{"line_number":154,"context_line":"                            odl_const.ODL_BGPVPN,"},{"line_number":155,"context_line":"                            fake_net_upd_bgpvpn_data)"},{"line_number":156,"context_line":"            self.driver.create_net_assoc_postcommit(self.context,"},{"line_number":157,"context_line":"                                                    fake_net_assoc_data)"},{"line_number":158,"context_line":"            self._assert_op(odl_const.ODL_UPDATE,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_31e4e4aa","line":155,"updated":"2017-02-14 07:41:25.000000000","message":"data available in journal after precommit will have networks filled inside this bgpvpn and that is why net\u003dTrue is required in L145.","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"18c6812854be6597be8071a23b8345c935acdee7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                                   fake_net_assoc_data)"},{"line_number":153,"context_line":"            self._assert_op(odl_const.ODL_UPDATE,"},{"line_number":154,"context_line":"                            odl_const.ODL_BGPVPN,"},{"line_number":155,"context_line":"                            fake_net_upd_bgpvpn_data)"},{"line_number":156,"context_line":"            self.driver.create_net_assoc_postcommit(self.context,"},{"line_number":157,"context_line":"                                                    fake_net_assoc_data)"},{"line_number":158,"context_line":"            self._assert_op(odl_const.ODL_UPDATE,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_9c1e875d","line":155,"in_reply_to":"fa31d9ce_31e4e4aa","updated":"2017-02-14 07:52:21.000000000","message":"same as above","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e9c45bc987b4f072497b822cf58d85fcad422f3c","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_delete_net_assoc(self):"},{"line_number":163,"context_line":"        fake_net_assoc_data \u003d self._get_fake_net_assoc()"},{"line_number":164,"context_line":"        fake_bgpvpn_data \u003d self._get_fake_bgpvpn(net\u003dTrue)"},{"line_number":165,"context_line":"        with mock.patch.object(self.driver, \u0027get_bgpvpn\u0027,"},{"line_number":166,"context_line":"                               return_value\u003dfake_bgpvpn_data):"},{"line_number":167,"context_line":"            self.driver.delete_net_assoc_precommit(self.context,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_91f59058","line":164,"updated":"2017-02-14 07:41:25.000000000","message":"net\u003dFalse here?","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"18c6812854be6597be8071a23b8345c935acdee7","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_delete_net_assoc(self):"},{"line_number":163,"context_line":"        fake_net_assoc_data \u003d self._get_fake_net_assoc()"},{"line_number":164,"context_line":"        fake_bgpvpn_data \u003d self._get_fake_bgpvpn(net\u003dTrue)"},{"line_number":165,"context_line":"        with mock.patch.object(self.driver, \u0027get_bgpvpn\u0027,"},{"line_number":166,"context_line":"                               return_value\u003dfake_bgpvpn_data):"},{"line_number":167,"context_line":"            self.driver.delete_net_assoc_precommit(self.context,"}],"source_content_type":"text/x-python","patch_set":40,"id":"fa31d9ce_bc234ba6","line":164,"in_reply_to":"fa31d9ce_91f59058","updated":"2017-02-14 07:52:21.000000000","message":"same as above","commit_id":"67e1ae6a063775f5904ef54f3ca2d58cba187343"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a1c69b378325214daeed5b59a3244d605dd4df04","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.driver.update_bgpvpn_precommit(self.context, fake_data)"},{"line_number":96,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                        fake_data)"},{"line_number":98,"context_line":"        self.thread.run_sync_thread(exit_after_run\u003dTrue)"},{"line_number":99,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":100,"context_line":"                        fake_data, False)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_delete_bgpvpn(self):"},{"line_number":103,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_dabb78e3","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":41},"updated":"2017-02-14 23:18:25.000000000","message":"i\u0027m not sure what this is trying to test.\nit\u0027s just to see if the journal thread crashes?","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"001ca8a04c122cdf24a30d9ee9c038e108208525","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.driver.update_bgpvpn_precommit(self.context, fake_data)"},{"line_number":96,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":97,"context_line":"                        fake_data)"},{"line_number":98,"context_line":"        self.thread.run_sync_thread(exit_after_run\u003dTrue)"},{"line_number":99,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":100,"context_line":"                        fake_data, False)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_delete_bgpvpn(self):"},{"line_number":103,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_e528989c","line":100,"range":{"start_line":98,"start_character":0,"end_line":100,"end_character":41},"in_reply_to":"fa31d9ce_dabb78e3","updated":"2017-02-15 02:33:27.000000000","message":"Yes, it tests if journal thread build url/data  and dependency validator is called without crash.","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"}],"networking_odl/tests/unit/journal/test_dependency_validations.py":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        return \u0027NET_ID\u0027"},{"line_number":309,"context_line":"    if res_type \u003d\u003d const.ODL_ROUTER:"},{"line_number":310,"context_line":"        return {\u0027id\u0027: \u0027ROUTER_ID\u0027,"},{"line_number":311,"context_line":"                \u0027gw_port_id\u0027: \u0027GW_PORT_ID\u0027}"},{"line_number":312,"context_line":"    if res_type \u003d\u003d const.ODL_BGPVPN:"},{"line_number":313,"context_line":"        if op \u003d\u003d const.ODL_DELETE:"},{"line_number":314,"context_line":"            return {\u0027NET_ID\u0027, \u0027ROUTER_ID\u0027}"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_60799293","line":311,"updated":"2017-02-10 14:27:49.000000000","message":"why would we need gw_port_id here?","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b1200e162e35cba0f0b957dc86f47714eff70f3b","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        return \u0027NET_ID\u0027"},{"line_number":309,"context_line":"    if res_type \u003d\u003d const.ODL_ROUTER:"},{"line_number":310,"context_line":"        return {\u0027id\u0027: \u0027ROUTER_ID\u0027,"},{"line_number":311,"context_line":"                \u0027gw_port_id\u0027: \u0027GW_PORT_ID\u0027}"},{"line_number":312,"context_line":"    if res_type \u003d\u003d const.ODL_BGPVPN:"},{"line_number":313,"context_line":"        if op \u003d\u003d const.ODL_DELETE:"},{"line_number":314,"context_line":"            return {\u0027NET_ID\u0027, \u0027ROUTER_ID\u0027}"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_603c3294","line":311,"in_reply_to":"fa31d9ce_60799293","updated":"2017-02-10 14:33:34.000000000","message":"router dependency check looks for this field, if not given throws exception.","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"# TODO(vthapar): Refactor *_dep into a common method"},{"line_number":323,"context_line":"def bgpvpn_dep(first_type, second_type, first_op, second_op, result,"},{"line_number":324,"context_line":"               sub_port\u003dFalse):"},{"line_number":325,"context_line":"    if first_type \u003d\u003d second_type:"},{"line_number":326,"context_line":"        expected \u003d {\u0027fail\u0027: (True, False), \u0027pass\u0027: (True, True)}"},{"line_number":327,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_35319e0c","line":324,"updated":"2017-02-10 14:27:49.000000000","message":"sub_port is never used.","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b1200e162e35cba0f0b957dc86f47714eff70f3b","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"# TODO(vthapar): Refactor *_dep into a common method"},{"line_number":323,"context_line":"def bgpvpn_dep(first_type, second_type, first_op, second_op, result,"},{"line_number":324,"context_line":"               sub_port\u003dFalse):"},{"line_number":325,"context_line":"    if first_type \u003d\u003d second_type:"},{"line_number":326,"context_line":"        expected \u003d {\u0027fail\u0027: (True, False), \u0027pass\u0027: (True, True)}"},{"line_number":327,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_005616d2","line":324,"in_reply_to":"fa31d9ce_35319e0c","updated":"2017-02-10 14:33:34.000000000","message":"was looking to make this common for all resources, gave up but didn\u0027t clean up.","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    scenarios \u003d ("},{"line_number":346,"context_line":"        (\"bgpvpn_create_depends_on_older_network_create\","},{"line_number":347,"context_line":"         bgpvpn_dep(const.ODL_NETWORK, const.ODL_BGPVPN,"},{"line_number":348,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027fail\u0027)),"},{"line_number":349,"context_line":"        (\"bgpvpn_create_doesnt_depend_on_newer_network_create\","},{"line_number":350,"context_line":"         bgpvpn_dep(const.ODL_BGPVPN, const.ODL_NETWORK,"},{"line_number":351,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_750cf694","line":348,"updated":"2017-02-10 14:27:49.000000000","message":"creation of a bgpvpn does not rely on a network to be pre-available.","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b1200e162e35cba0f0b957dc86f47714eff70f3b","unresolved":false,"context_lines":[{"line_number":345,"context_line":"    scenarios \u003d ("},{"line_number":346,"context_line":"        (\"bgpvpn_create_depends_on_older_network_create\","},{"line_number":347,"context_line":"         bgpvpn_dep(const.ODL_NETWORK, const.ODL_BGPVPN,"},{"line_number":348,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027fail\u0027)),"},{"line_number":349,"context_line":"        (\"bgpvpn_create_doesnt_depend_on_newer_network_create\","},{"line_number":350,"context_line":"         bgpvpn_dep(const.ODL_BGPVPN, const.ODL_NETWORK,"},{"line_number":351,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_a0146af5","line":348,"in_reply_to":"fa31d9ce_750cf694","updated":"2017-02-10 14:33:34.000000000","message":"yeah, but the bgpvpn object we give has network and routerids. idea being if it is present then it should depend else not. Other option is to not have router and network ids when creating, I can tweak it.","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027fail\u0027)),"},{"line_number":349,"context_line":"        (\"bgpvpn_create_doesnt_depend_on_newer_network_create\","},{"line_number":350,"context_line":"         bgpvpn_dep(const.ODL_BGPVPN, const.ODL_NETWORK,"},{"line_number":351,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"},{"line_number":352,"context_line":"        (\"bgpvpn_create_depends_on_older_router_create\","},{"line_number":353,"context_line":"         bgpvpn_dep(const.ODL_ROUTER, const.ODL_BGPVPN,"},{"line_number":354,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027fail\u0027)),"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_d5ada232","line":351,"updated":"2017-02-10 14:27:49.000000000","message":"since the previous comment is relevant, this validation becomes irrelevant.","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"},{"line_number":352,"context_line":"        (\"bgpvpn_create_depends_on_older_router_create\","},{"line_number":353,"context_line":"         bgpvpn_dep(const.ODL_ROUTER, const.ODL_BGPVPN,"},{"line_number":354,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027fail\u0027)),"},{"line_number":355,"context_line":"        (\"bgpvpn_create_doesnt_depend_on_newer_ROUTER_create\","},{"line_number":356,"context_line":"         bgpvpn_dep(const.ODL_BGPVPN, const.ODL_ROUTER,"},{"line_number":357,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_154c9ac6","line":354,"updated":"2017-02-10 14:27:49.000000000","message":"ditto comment.","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027fail\u0027)),"},{"line_number":355,"context_line":"        (\"bgpvpn_create_doesnt_depend_on_newer_ROUTER_create\","},{"line_number":356,"context_line":"         bgpvpn_dep(const.ODL_BGPVPN, const.ODL_ROUTER,"},{"line_number":357,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"},{"line_number":358,"context_line":"        (\"bgpvpn_update_depends_on_older_bgpvpn_create\","},{"line_number":359,"context_line":"         bgpvpn_dep(const.ODL_BGPVPN, const.ODL_BGPVPN,"},{"line_number":360,"context_line":"                    const.ODL_CREATE, const.ODL_UPDATE, \u0027fail\u0027, True)),"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_756dd603","line":357,"updated":"2017-02-10 14:27:49.000000000","message":"since bgpvpn creation does not mandate a router to be present, this validation becomes irrelevant.","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"6fa1df9f413ff47395b4eab2b1ee50bf7a3c068a","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"},{"line_number":358,"context_line":"        (\"bgpvpn_update_depends_on_older_bgpvpn_create\","},{"line_number":359,"context_line":"         bgpvpn_dep(const.ODL_BGPVPN, const.ODL_BGPVPN,"},{"line_number":360,"context_line":"                    const.ODL_CREATE, const.ODL_UPDATE, \u0027fail\u0027, True)),"},{"line_number":361,"context_line":"        (\"bgpvpn_update_depends_on_older_network_create\","},{"line_number":362,"context_line":"         bgpvpn_dep(const.ODL_NETWORK, const.ODL_BGPVPN,"},{"line_number":363,"context_line":"                    const.ODL_CREATE, const.ODL_UPDATE, \u0027fail\u0027, True)),"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_3518be84","line":360,"updated":"2017-02-10 14:27:49.000000000","message":"sub_port is never used.. why to pass True here..","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"b1200e162e35cba0f0b957dc86f47714eff70f3b","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"},{"line_number":358,"context_line":"        (\"bgpvpn_update_depends_on_older_bgpvpn_create\","},{"line_number":359,"context_line":"         bgpvpn_dep(const.ODL_BGPVPN, const.ODL_BGPVPN,"},{"line_number":360,"context_line":"                    const.ODL_CREATE, const.ODL_UPDATE, \u0027fail\u0027, True)),"},{"line_number":361,"context_line":"        (\"bgpvpn_update_depends_on_older_network_create\","},{"line_number":362,"context_line":"         bgpvpn_dep(const.ODL_NETWORK, const.ODL_BGPVPN,"},{"line_number":363,"context_line":"                    const.ODL_CREATE, const.ODL_UPDATE, \u0027fail\u0027, True)),"}],"source_content_type":"text/x-python","patch_set":32,"id":"fa31d9ce_402c8e4a","line":360,"in_reply_to":"fa31d9ce_3518be84","updated":"2017-02-10 14:33:34.000000000","message":"missed cleanup again :)","commit_id":"e99858faf75a0f44add5b6e80468aad19028389f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"60fd873ceb676793d395cab1c88feb9856e99696","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        (\"bgpvpn_create_doesnt_depend_on_older_router_create\","},{"line_number":357,"context_line":"         bgpvpn_dep(const.ODL_ROUTER, const.ODL_BGPVPN,"},{"line_number":358,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"},{"line_number":359,"context_line":"        (\"bgpvpn_create_doesnt_depend_on_newer_ROUTER_create\","},{"line_number":360,"context_line":"         bgpvpn_dep(const.ODL_BGPVPN, const.ODL_ROUTER,"},{"line_number":361,"context_line":"                    const.ODL_CREATE, const.ODL_CREATE, \u0027pass\u0027)),"},{"line_number":362,"context_line":"        (\"bgpvpn_update_depends_on_older_bgpvpn_create\","}],"source_content_type":"text/x-python","patch_set":33,"id":"fa31d9ce_01b7f539","line":359,"updated":"2017-02-10 16:39:42.000000000","message":"ROUTER to router","commit_id":"72c3154a6a960856274be0270daf16af44f6554a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3505941573ce25861844d4ca8c827fb679db2e70","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"# TODO(vthapar): Refactor *_data into common method"},{"line_number":306,"context_line":"def bgpvpn_data(res_type, op):"},{"line_number":307,"context_line":"    if res_type \u003d\u003d const.ODL_NETWORK:"},{"line_number":308,"context_line":"        return \u0027NET_ID\u0027"},{"line_number":309,"context_line":"    if res_type \u003d\u003d const.ODL_ROUTER:"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_b08b4367","line":306,"range":{"start_line":306,"start_character":0,"end_line":306,"end_character":30},"updated":"2017-02-15 00:26:41.000000000","message":"I\u0027d recommend doing it this patch itself. just append ifs in get_data and it will prevent redundant code as well.\n\ndata should be dictionary otherwise it will end up in issues if there is any real dependency, in case of network i see data is string and in all other cases which is dict, so far we have not encountered a issue because net operation is parent and wasn\u0027t dependent  but while adding qos dependency i see problems with network data being string. I have fixed in QoS driver patch which is dependent on this patch","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"001ca8a04c122cdf24a30d9ee9c038e108208525","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"# TODO(vthapar): Refactor *_data into common method"},{"line_number":306,"context_line":"def bgpvpn_data(res_type, op):"},{"line_number":307,"context_line":"    if res_type \u003d\u003d const.ODL_NETWORK:"},{"line_number":308,"context_line":"        return \u0027NET_ID\u0027"},{"line_number":309,"context_line":"    if res_type \u003d\u003d const.ODL_ROUTER:"}],"source_content_type":"text/x-python","patch_set":50,"id":"fa31d9ce_851efc6d","line":306,"range":{"start_line":306,"start_character":0,"end_line":306,"end_character":30},"in_reply_to":"fa31d9ce_b08b4367","updated":"2017-02-15 02:33:27.000000000","message":"fixed by https://review.openstack.org/#/q/status:open+project:openstack/networking-odl+branch:master+topic:test-dependency-fixup","commit_id":"67a6263b3d93a6fa7aa9e1ccc554c98df7d2f2b0"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"48d9835106129312952b6d9b95dbe4400e88a46c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    elif res_type \u003d\u003d const.ODL_BGPVPN:"},{"line_number":76,"context_line":"        routers \u003d []"},{"line_number":77,"context_line":"        networks \u003d []"},{"line_number":78,"context_line":"        if operation \u003d\u003d const.ODL_DELETE:"},{"line_number":79,"context_line":"            return [_NET_ID, _ROUTER_ID]"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            if operation \u003d\u003d const.ODL_UPDATE:"},{"line_number":82,"context_line":"                routers \u003d [_ROUTER_ID]"},{"line_number":83,"context_line":"                networks \u003d [_NET_ID]"}],"source_content_type":"text/x-python","patch_set":54,"id":"fa31d9ce_7c07e181","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":13},"updated":"2017-02-15 05:48:16.000000000","message":"i guess it\u0027s cleaner to have a flag to control whether to have references, rather than changing the behaviour on operation.  but i don\u0027t insist.","commit_id":"3eb77f90a188ba0a72137b842c8c1760f99ef6b3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a6138f089dc67393244df2d3cb6db6dca9eb240c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    elif res_type \u003d\u003d const.ODL_BGPVPN:"},{"line_number":76,"context_line":"        routers \u003d []"},{"line_number":77,"context_line":"        networks \u003d []"},{"line_number":78,"context_line":"        if operation \u003d\u003d const.ODL_DELETE:"},{"line_number":79,"context_line":"            return [_NET_ID, _ROUTER_ID]"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            if operation \u003d\u003d const.ODL_UPDATE:"},{"line_number":82,"context_line":"                routers \u003d [_ROUTER_ID]"},{"line_number":83,"context_line":"                networks \u003d [_NET_ID]"}],"source_content_type":"text/x-python","patch_set":54,"id":"fa31d9ce_b76c1209","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":13},"in_reply_to":"fa31d9ce_772ffa3e","updated":"2017-02-15 06:44:43.000000000","message":"oops, i put the comment on a wrong place.\ni meant on L81-83.","commit_id":"3eb77f90a188ba0a72137b842c8c1760f99ef6b3"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"40bf600e77f5aa3072b5af4d989bef0f7a6b9e92","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    elif res_type \u003d\u003d const.ODL_BGPVPN:"},{"line_number":76,"context_line":"        routers \u003d []"},{"line_number":77,"context_line":"        networks \u003d []"},{"line_number":78,"context_line":"        if operation \u003d\u003d const.ODL_DELETE:"},{"line_number":79,"context_line":"            return [_NET_ID, _ROUTER_ID]"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            if operation \u003d\u003d const.ODL_UPDATE:"},{"line_number":82,"context_line":"                routers \u003d [_ROUTER_ID]"},{"line_number":83,"context_line":"                networks \u003d [_NET_ID]"}],"source_content_type":"text/x-python","patch_set":54,"id":"fa31d9ce_772ffa3e","line":80,"range":{"start_line":78,"start_character":0,"end_line":80,"end_character":13},"in_reply_to":"fa31d9ce_7c07e181","updated":"2017-02-15 06:23:09.000000000","message":"FOr now I\u0027ll keep this. Please see line 81.","commit_id":"3eb77f90a188ba0a72137b842c8c1760f99ef6b3"}],"releasenotes/notes/bgpvpn-driver-v2-36c0772d510587f4.yaml":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a670cb37f26f5c08bf456718cc044c25bc157208","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    BGPVPN Version 2 Driver for OpenDaylight. "},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    A new version of BGPVPN driver that integrate OpenStack Neutron"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5a3905b3_b2f7a8d1","line":3,"range":{"start_line":3,"start_character":45,"end_line":3,"end_character":46},"updated":"2017-01-24 02:42:40.000000000","message":"nit. trailing space.","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"9c4ac6ce2b254ede5c8390a7195b4637524baa71","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    BGPVPN Version 2 Driver for OpenDaylight. "},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    A new version of BGPVPN driver that integrate OpenStack Neutron"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5a3905b3_ef2302bb","line":3,"range":{"start_line":3,"start_character":45,"end_line":3,"end_character":46},"in_reply_to":"5a3905b3_b2f7a8d1","updated":"2017-01-24 04:26:25.000000000","message":"Done","commit_id":"6ec704046498f245257b54b3149a427f02465294"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"09e55c6c3d5b665928424fe57fe62c5cd761b5e2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    A new version of BGPVPN driver that integrate OpenStack Neutron"},{"line_number":7,"context_line":"    BGPVPN API with OpenDaylight backend. It supports CRUD operations"},{"line_number":8,"context_line":"    for BGPVPN and enables networks and routers to be associated to"},{"line_number":9,"context_line":"    such BGPVPNs. This driver uses journalling mechanism, unlike v1 driver,"},{"line_number":10,"context_line":"    which will first log the operation in journal table before execution."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a461143_18919f47","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":46},"updated":"2017-01-30 17:25:32.000000000","message":"journaling","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"55a7dadd7cd828820aee5c3db31e6b25ba8e9a7e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    A new version of BGPVPN driver that integrate OpenStack Neutron"},{"line_number":7,"context_line":"    BGPVPN API with OpenDaylight backend. It supports CRUD operations"},{"line_number":8,"context_line":"    for BGPVPN and enables networks and routers to be associated to"},{"line_number":9,"context_line":"    such BGPVPNs. This driver uses journalling mechanism, unlike v1 driver,"},{"line_number":10,"context_line":"    which will first log the operation in journal table before execution."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3a461143_34fc8d3d","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":46},"in_reply_to":"3a461143_18919f47","updated":"2017-01-31 10:39:13.000000000","message":"Done","commit_id":"270bcbc541002d75705f862302cdf798ddf3e658"}]}
