)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"574b2ed1e3d388ece2de4cc809d654a75e1c54a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Manjeet Singh Bhatia \u003cmanjeet.s.bhatia@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-24 16:03:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove deprecation warnings"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes the use of get_session() api"},{"line_number":10,"context_line":"from neutron/db in networking-odl. it is deprecated"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da36d5c6_345d7947","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":27},"updated":"2017-02-24 16:14:12.000000000","message":"better to say \"adapt to new db api\" or something along line","commit_id":"4766e8b60e02b0271b24be8f1ce3c08a46604da2"}],"networking_odl/l3/l3_odl_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"48efe29cd35b6d8ffaf4a3830588994980865d46","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @journal.call_thread_on_end"},{"line_number":67,"context_line":"    def create_router(self, context, router):"},{"line_number":68,"context_line":"        session \u003d db_api.get_reader_session()"},{"line_number":69,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":70,"context_line":"            router_dict \u003d super("},{"line_number":71,"context_line":"                OpenDaylightL3RouterPlugin, self).create_router(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_17af9e2a","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":45},"updated":"2017-02-15 06:44:23.000000000","message":"Hmm, although this has been already broken, this breaks more...\nIn semantics, the following transaction updates db.","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"258f6079d74c78a5c9aee82b7b3b097b13629745","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @journal.call_thread_on_end"},{"line_number":67,"context_line":"    def create_router(self, context, router):"},{"line_number":68,"context_line":"        session \u003d db_api.get_reader_session()"},{"line_number":69,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":70,"context_line":"            router_dict \u003d super("},{"line_number":71,"context_line":"                OpenDaylightL3RouterPlugin, self).create_router(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_17da3ee8","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":45},"updated":"2017-02-15 06:42:44.000000000","message":"i don\u0027t understand what this session is for.\nmaybe we should just use context.session?","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"75fcf2b31f61399618b39c8ffc2bcb25a029ad2b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @journal.call_thread_on_end"},{"line_number":67,"context_line":"    def create_router(self, context, router):"},{"line_number":68,"context_line":"        session \u003d db_api.get_reader_session()"},{"line_number":69,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":70,"context_line":"            router_dict \u003d super("},{"line_number":71,"context_line":"                OpenDaylightL3RouterPlugin, self).create_router(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_d746e679","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":45},"in_reply_to":"fa31d9ce_17af9e2a","updated":"2017-02-15 06:45:56.000000000","message":"This isn\u0027t used.\nthe correct one is session \u003d context.session.\nBut it\u0027s broken and not fixed yet.\n\nhttps://bugs.launchpad.net/networking-odl/+bug/1611533","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f78e3d4ffe6fcab2e86e07adb03cc2f3d29fe88","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @journal.call_thread_on_end"},{"line_number":67,"context_line":"    def create_router(self, context, router):"},{"line_number":68,"context_line":"        session \u003d db_api.get_reader_session()"},{"line_number":69,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":70,"context_line":"            router_dict \u003d super("},{"line_number":71,"context_line":"                OpenDaylightL3RouterPlugin, self).create_router(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_1724fec2","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":45},"in_reply_to":"fa31d9ce_d746e679","updated":"2017-02-15 06:47:02.000000000","message":"https://bugs.launchpad.net/networking-odl/+bug/1614775","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"574b2ed1e3d388ece2de4cc809d654a75e1c54a3","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @journal.call_thread_on_end"},{"line_number":67,"context_line":"    def create_router(self, context, router):"},{"line_number":68,"context_line":"        session \u003d db_api.get_reader_session()"},{"line_number":69,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":70,"context_line":"            router_dict \u003d super("},{"line_number":71,"context_line":"                OpenDaylightL3RouterPlugin, self).create_router(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_b46969fb","line":68,"updated":"2017-02-24 16:14:12.000000000","message":"should rebase on Ic32a094af2dbfe3fd9b898ba371997a0bf1043e1","commit_id":"4766e8b60e02b0271b24be8f1ce3c08a46604da2"}],"networking_odl/tests/unit/l2gateway/test_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"48efe29cd35b6d8ffaf4a3830588994980865d46","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return fake_l2_gateway_connection"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _assert_op(self, operation, object_type, data, precommit\u003dTrue):"},{"line_number":87,"context_line":"        row \u003d db.get_oldest_pending_db_row_with_lock(self.db_session)"},{"line_number":88,"context_line":"        if precommit:"},{"line_number":89,"context_line":"            self.assertEqual(operation, row[\u0027operation\u0027])"},{"line_number":90,"context_line":"            self.assertEqual(object_type, row[\u0027object_type\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_b70b327c","line":87,"range":{"start_line":87,"start_character":43,"end_line":87,"end_character":51},"updated":"2017-02-15 06:44:23.000000000","message":"This update the row: status pending -\u003e processing.","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"}],"networking_odl/tests/unit/l3/test_l3_odl_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"48efe29cd35b6d8ffaf4a3830588994980865d46","unresolved":false,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        # Create dependency db row and mark as \u0027processing\u0027 so it won\u0027t"},{"line_number":319,"context_line":"        # be processed by the journal thread."},{"line_number":320,"context_line":"        db.create_pending_row(self.db_session, dep_object,"},{"line_number":321,"context_line":"                              dep_id, dep_operation, dep_context)"},{"line_number":322,"context_line":"        row \u003d db.get_all_db_rows_by_state(self.db_session, odl_const.PENDING)"},{"line_number":323,"context_line":"        db.update_db_row_state(self.db_session, row[0], odl_const.PROCESSING)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_f7704a0d","line":320,"range":{"start_line":320,"start_character":11,"end_line":320,"end_character":29},"updated":"2017-02-15 06:44:23.000000000","message":"This writes to db.","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"}],"networking_odl/tests/unit/ml2/test_mechanism_odl_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"48efe29cd35b6d8ffaf4a3830588994980865d46","unresolved":false,"context_lines":[{"line_number":619,"context_line":"        first_row \u003d rows[0]"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"        # change the state to processing"},{"line_number":622,"context_line":"        db.update_db_row_state(self.db_session, first_row,"},{"line_number":623,"context_line":"                               odl_const.PROCESSING)"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"        # create 1 more operation to trigger the sync thread"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_f7576a55","line":622,"range":{"start_line":622,"start_character":11,"end_line":622,"end_character":30},"updated":"2017-02-15 06:44:23.000000000","message":"this writes to db.","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"}],"networking_odl/tests/unit/sfc/flowclassifier/test_sfc_flowclassifier_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"48efe29cd35b6d8ffaf4a3830588994980865d46","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _test_event(self, operation, timing):"},{"line_number":52,"context_line":"        self._call_operation_object(operation, timing)"},{"line_number":53,"context_line":"        row \u003d db.get_oldest_pending_db_row_with_lock(self.db_session)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        if timing \u003d\u003d \u0027precommit\u0027:"},{"line_number":56,"context_line":"            self.assertEqual(operation, row[\u0027operation\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_37e582a7","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":52},"updated":"2017-02-15 06:44:23.000000000","message":"this updates db.","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"}],"networking_odl/tests/unit/sfc/test_sfc_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"48efe29cd35b6d8ffaf4a3830588994980865d46","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def _test_event(self, operation, timing, resource_str, object_type):"},{"line_number":75,"context_line":"        context \u003d self._get_mock_operation_context(object_type)"},{"line_number":76,"context_line":"        self._call_operation_object(operation, timing, resource_str, context)"},{"line_number":77,"context_line":"        row \u003d db.get_oldest_pending_db_row_with_lock(self.db_session)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if timing \u003d\u003d \u0027precommit\u0027:"},{"line_number":80,"context_line":"            self.assertEqual(operation, row[\u0027operation\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_37fca23d","line":77,"range":{"start_line":77,"start_character":17,"end_line":77,"end_character":52},"updated":"2017-02-15 06:44:23.000000000","message":"this updates db","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"}],"networking_odl/tests/unit/trunk/test_trunk_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"48efe29cd35b6d8ffaf4a3830588994980865d46","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def _test_event(self, operation, timing):"},{"line_number":81,"context_line":"        self._call_operation_object(operation, timing)"},{"line_number":82,"context_line":"        fake_payload \u003d self._fake_trunk_payload()"},{"line_number":83,"context_line":"        row \u003d db.get_oldest_pending_db_row_with_lock(self.db_session)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if timing \u003d\u003d \u0027precommit\u0027:"},{"line_number":86,"context_line":"            self.assertEqual(operation, row[\u0027operation\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_b79ed204","line":83,"range":{"start_line":83,"start_character":14,"end_line":83,"end_character":52},"updated":"2017-02-15 06:44:23.000000000","message":"This updates db.","commit_id":"4df12fa4bd6ff8f92e117d4502bd737756e06690"}]}
