)]}'
{"networking_odl/cmd/set_ovs_hostconfigs.py":[{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"1e8e6d8068d7ca5d2c3db8ded58c60aef75fb0cc","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                \"vhostuser_mode\": conf.vhostuser_mode,"},{"line_number":354,"context_line":"                \"vhostuser_socket\": os.path.join("},{"line_number":355,"context_line":"                    conf.vhostuser_socket_dir,"},{"line_number":356,"context_line":"                    \u0027$PORT_ID\u0027)}"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"def setup_conf(args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_d76d7405","line":356,"range":{"start_line":356,"start_character":20,"end_line":356,"end_character":30},"updated":"2017-03-02 04:10:29.000000000","message":"This could be something like:\n(conf.vhostuser_port_prefix + \u0027$PORT_ID\u0027)[:14]\nThat way we retain the full uuid in PORT_ID and socket_name uses prefix+port_id trimmed to 14. No other changes needed. Other option would be to let this be way it is and trim the vhostuser_socket in pseudo_agent_binding._substitute_hconfig_tmpl after we create hconfig, or in bindport after we get hconfig. That would help in cases where user sets hostconfig manually instead of using this script.","commit_id":"5b281f9221fe43e4178802fae17ed180b876ae8b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"81d631ca7c03e9e019ebc67e93d58b2006510d24","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                \"vhostuser_mode\": conf.vhostuser_mode,"},{"line_number":354,"context_line":"                \"vhostuser_socket\": os.path.join("},{"line_number":355,"context_line":"                    conf.vhostuser_socket_dir,"},{"line_number":356,"context_line":"                    \u0027$PORT_ID\u0027)}"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"def setup_conf(args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_ed019db0","line":356,"range":{"start_line":356,"start_character":20,"end_line":356,"end_character":30},"in_reply_to":"ba2be162_d76d7405","updated":"2017-03-02 18:21:44.000000000","message":"Unfortunately string.Template doesn\u0027t have such capability.\nOther your proposal requires logic specific to vhostuser in port binding code. which we\u0027d like to avoid.\n\n(the use of port_prefix is compromise.)","commit_id":"5b281f9221fe43e4178802fae17ed180b876ae8b"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"45205b5c794966c20c5172d0da902b9d3cb3da64","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                \"vhostuser_mode\": conf.vhostuser_mode,"},{"line_number":354,"context_line":"                \"vhostuser_socket\": os.path.join("},{"line_number":355,"context_line":"                    conf.vhostuser_socket_dir,"},{"line_number":356,"context_line":"                    \u0027$PORT_ID\u0027)}"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"def setup_conf(args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_43113903","line":356,"range":{"start_line":356,"start_character":20,"end_line":356,"end_character":30},"in_reply_to":"ba2be162_ed019db0","updated":"2017-03-06 06:55:39.000000000","message":"okay. looking at code doesn\u0027t look like PORT_ID is used anywhere else, so we can go with this for now and if come up with a use case that requires full PORT_ID, we can revisit this.","commit_id":"5b281f9221fe43e4178802fae17ed180b876ae8b"}],"networking_odl/ml2/pseudo_agentdb_binding.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"4d9b6550182756479eaabeb516fa18872a3277a7","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        port_id \u003d port_context.current[\u0027id\u0027]"},{"line_number":188,"context_line":"        subs_ids \u003d {"},{"line_number":189,"context_line":"            # $IDENTIFER string substitution in hostconfigs JSON string"},{"line_number":190,"context_line":"            \u0027PORT_ID\u0027: port_id[:(14 - len(port_prefix))],"},{"line_number":191,"context_line":"        }"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        # Substitute identifiers and Convert JSON string to dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_d66e5ac8","line":190,"range":{"start_line":190,"start_character":32,"end_line":190,"end_character":54},"updated":"2017-03-02 01:47:54.000000000","message":"max(0, 14 - len)","commit_id":"5b281f9221fe43e4178802fae17ed180b876ae8b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ebe3b44acb78eba4b550ce5b93e7d5c73ebf54d6","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        try:"},{"line_number":188,"context_line":"            confs \u003d hconfig[\u0027configurations\u0027][\u0027supported_vnic_types\u0027]"},{"line_number":189,"context_line":"            for conf in confs:"},{"line_number":190,"context_line":"                port_prefix \u003d  conf[\u0027vif_details\u0027][\u0027port_prefix\u0027]"},{"line_number":191,"context_line":"                subs_ids \u003d {"},{"line_number":192,"context_line":"                    # $IDENTIFER string substitution in hostconfigs JSON string"},{"line_number":193,"context_line":"                    \u0027PORT_ID\u0027: port_id[:(14 - len(port_prefix))],"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a25e98e_d2787192","line":190,"range":{"start_line":190,"start_character":50,"end_line":190,"end_character":65},"updated":"2017-03-14 00:48:35.000000000","message":"in case of non vhostuser, port_prefix isn\u0027t defined.\nWe don\u0027t want to skip that case.","commit_id":"060c58bf68da578f2f8e13afc9dbf96363adf3b3"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ebe3b44acb78eba4b550ce5b93e7d5c73ebf54d6","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                port_prefix \u003d  conf[\u0027vif_details\u0027][\u0027port_prefix\u0027]"},{"line_number":191,"context_line":"                subs_ids \u003d {"},{"line_number":192,"context_line":"                    # $IDENTIFER string substitution in hostconfigs JSON string"},{"line_number":193,"context_line":"                    \u0027PORT_ID\u0027: port_id[:(14 - len(port_prefix))],"},{"line_number":194,"context_line":"                }"},{"line_number":195,"context_line":"                # Substitute identifiers and Convert JSON string to dict"},{"line_number":196,"context_line":"                hconfig_conf_json \u003d Template("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a25e98e_f2564d05","line":193,"range":{"start_line":193,"start_character":20,"end_line":193,"end_character":65},"updated":"2017-03-14 00:48:35.000000000","message":"According to set_ovs_hostconfig, port_prefix needs to be prepended, doesn\u0027t it?\nAt least the change to set_ovs_hostconfig and here need to be cosistent.","commit_id":"060c58bf68da578f2f8e13afc9dbf96363adf3b3"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ebe3b44acb78eba4b550ce5b93e7d5c73ebf54d6","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                port_prefix \u003d  conf[\u0027vif_details\u0027][\u0027port_prefix\u0027]"},{"line_number":191,"context_line":"                subs_ids \u003d {"},{"line_number":192,"context_line":"                    # $IDENTIFER string substitution in hostconfigs JSON string"},{"line_number":193,"context_line":"                    \u0027PORT_ID\u0027: port_id[:(14 - len(port_prefix))],"},{"line_number":194,"context_line":"                }"},{"line_number":195,"context_line":"                # Substitute identifiers and Convert JSON string to dict"},{"line_number":196,"context_line":"                hconfig_conf_json \u003d Template("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a25e98e_523e41b9","line":193,"range":{"start_line":193,"start_character":40,"end_line":193,"end_character":62},"updated":"2017-03-14 00:48:35.000000000","message":"max(0, 14 - len())\npython slice with negative value has other meaning.","commit_id":"060c58bf68da578f2f8e13afc9dbf96363adf3b3"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ebe3b44acb78eba4b550ce5b93e7d5c73ebf54d6","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                    jsonutils.dumps(conf[\u0027vif_details\u0027]))"},{"line_number":198,"context_line":"                substituted_str \u003d hconfig_conf_json.safe_substitute(subs_ids)"},{"line_number":199,"context_line":"                conf[\u0027vif_details\u0027] \u003d jsonutils.loads(substituted_str)"},{"line_number":200,"context_line":"        except KeyError:"},{"line_number":201,"context_line":"            LOG.error(_LE(\"got invalid hostconfigs configuration\"),"},{"line_number":202,"context_line":"                      exc_info\u003dTrue)"},{"line_number":203,"context_line":"        return hconfig"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a25e98e_1273e9b2","line":200,"range":{"start_line":200,"start_character":8,"end_line":200,"end_character":24},"updated":"2017-03-14 00:48:35.000000000","message":"This should be avoided.","commit_id":"060c58bf68da578f2f8e13afc9dbf96363adf3b3"}]}
