)]}'
{"networking_odl/common/client.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2c353506ea191a7c66a0fe3cfe95d4df2a6e38e9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.url \u003d url"},{"line_number":62,"context_line":"        cls \u003d self.__class__"},{"line_number":63,"context_line":"        if \u0027_session\u0027 not in cls.__dict__:"},{"line_number":64,"context_line":"            session \u003d requests.sessions.Session()"},{"line_number":65,"context_line":"            session.auth \u003d (username, password)"},{"line_number":66,"context_line":"            session.params[\u0027timeout\u0027]\u003dtimeout"},{"line_number":67,"context_line":"            cls._session \u003d session"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_0a6b22b8","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":49},"updated":"2017-03-03 03:39:26.000000000","message":"can be changed to\n\n  cls._session \u003d session \u003d requests.sessions.Session()\n\nin Line#64","commit_id":"a15cd4f03bae23edb8fd3da5d778a157935baf00"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"b1c3732d3964d59fe7d5041ebda18895283c4061","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def __init__(self, url, username, password, timeout):"},{"line_number":60,"context_line":"        super(OpenDaylightRestClient, self).__init__()"},{"line_number":61,"context_line":"        self.url \u003d url"},{"line_number":62,"context_line":"        cls \u003d self.__class__"},{"line_number":63,"context_line":"        if \u0027_session\u0027 not in cls.__dict__:"},{"line_number":64,"context_line":"            session \u003d requests.sessions.Session()"},{"line_number":65,"context_line":"            session.auth \u003d (username, password)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_514e583b","line":62,"updated":"2017-03-06 11:07:53.000000000","message":"I am not sure, it is a good idea. Because if someone inherits this class then that class will have _session attribute.(it might not ever get inherited). But I think, session is more closely related with OpendaylightRestClient. I will prefer Mike idea given.","commit_id":"164d4c754bb9fca2cb38aba952497022b1101bc6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d699bf40586269e8297a781c781c10513f9334e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if \u0027_session\u0027 not in cls.__dict__:"},{"line_number":64,"context_line":"            session \u003d requests.sessions.Session()"},{"line_number":65,"context_line":"            session.auth \u003d (username, password)"},{"line_number":66,"context_line":"            session.params[\u0027timeout\u0027] \u003d timeout"},{"line_number":67,"context_line":"            cls._session \u003d session"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_36804b8b","line":66,"range":{"start_line":66,"start_character":20,"end_line":66,"end_character":26},"updated":"2017-03-03 07:28:05.000000000","message":"isn\u0027t this about query parameters?","commit_id":"164d4c754bb9fca2cb38aba952497022b1101bc6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"563cf6be545a168f865be40419bd21a99c752949","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if \u0027_session\u0027 not in cls.__dict__:"},{"line_number":64,"context_line":"            session \u003d requests.sessions.Session()"},{"line_number":65,"context_line":"            session.auth \u003d (username, password)"},{"line_number":66,"context_line":"            session.params[\u0027timeout\u0027] \u003d timeout"},{"line_number":67,"context_line":"            cls._session \u003d session"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_4dfb69c1","line":66,"range":{"start_line":66,"start_character":20,"end_line":66,"end_character":26},"in_reply_to":"ba2be162_36804b8b","updated":"2017-03-10 03:34:37.000000000","message":"Done","commit_id":"164d4c754bb9fca2cb38aba952497022b1101bc6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d699bf40586269e8297a781c781c10513f9334e","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @property"},{"line_number":70,"context_line":"    def session(self):"},{"line_number":71,"context_line":"        return self.__class__._session"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_resource(self, resource_type, resource_id):"},{"line_number":74,"context_line":"        response \u003d self.get(utils.make_url_object(resource_type) + \u0027/\u0027 +"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_f4230c56","line":71,"updated":"2017-03-03 07:28:05.000000000","message":"does this mean to share a session object among threads?\ni wonder if it\u0027s a safe thing to do.\nhttps://github.com/kennethreitz/requests/issues/1871","commit_id":"164d4c754bb9fca2cb38aba952497022b1101bc6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"563cf6be545a168f865be40419bd21a99c752949","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @property"},{"line_number":70,"context_line":"    def session(self):"},{"line_number":71,"context_line":"        return self.__class__._session"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_resource(self, resource_type, resource_id):"},{"line_number":74,"context_line":"        response \u003d self.get(utils.make_url_object(resource_type) + \u0027/\u0027 +"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_0d0df1e7","line":71,"in_reply_to":"ba2be162_111f805b","updated":"2017-03-10 03:34:37.000000000","message":"Done","commit_id":"164d4c754bb9fca2cb38aba952497022b1101bc6"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"b1c3732d3964d59fe7d5041ebda18895283c4061","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @property"},{"line_number":70,"context_line":"    def session(self):"},{"line_number":71,"context_line":"        return self.__class__._session"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_resource(self, resource_type, resource_id):"},{"line_number":74,"context_line":"        response \u003d self.get(utils.make_url_object(resource_type) + \u0027/\u0027 +"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_111f805b","line":71,"in_reply_to":"ba2be162_92b38709","updated":"2017-03-06 11:07:53.000000000","message":"+1 to Mike.","commit_id":"164d4c754bb9fca2cb38aba952497022b1101bc6"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"7195d6fa03c7bcee8fb51df455c1c887762da45d","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    @property"},{"line_number":70,"context_line":"    def session(self):"},{"line_number":71,"context_line":"        return self.__class__._session"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_resource(self, resource_type, resource_id):"},{"line_number":74,"context_line":"        response \u003d self.get(utils.make_url_object(resource_type) + \u0027/\u0027 +"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_92b38709","line":71,"in_reply_to":"ba2be162_f4230c56","updated":"2017-03-05 08:28:26.000000000","message":"Generally seems like a bad idea, why not keep session per instance of the client?","commit_id":"164d4c754bb9fca2cb38aba952497022b1101bc6"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"550bf8c7e99c911f3435eefcfc1d93a4feebf542","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        super(OpenDaylightRestClient, self).__init__()"},{"line_number":61,"context_line":"        self.url \u003d url"},{"line_number":62,"context_line":"        self.timeout \u003d timeout"},{"line_number":63,"context_line":"        self.session \u003d requests.sessions.Session()"},{"line_number":64,"context_line":"        self.session.auth \u003d (username, password)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_resource(self, resource_type, resource_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a22e58a_bcee67ea","line":63,"range":{"start_line":63,"start_character":23,"end_line":63,"end_character":40},"updated":"2017-03-14 13:44:32.000000000","message":"nit: Isn\u0027t it python standard to import this, ie:\nfrom requests import sessions\n\nRather than using the module to get to another module in it?","commit_id":"04c3ca342dc2c4e2972f8e170248cbc4b9d2d96f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"9b39c369d853f78f1eefe745d03ee0a0dbf9b755","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        super(OpenDaylightRestClient, self).__init__()"},{"line_number":61,"context_line":"        self.url \u003d url"},{"line_number":62,"context_line":"        self.timeout \u003d timeout"},{"line_number":63,"context_line":"        self.session \u003d requests.sessions.Session()"},{"line_number":64,"context_line":"        self.session.auth \u003d (username, password)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def get_resource(self, resource_type, resource_id):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a1ff146_e052eddc","line":63,"range":{"start_line":63,"start_character":23,"end_line":63,"end_character":40},"in_reply_to":"5a22e58a_bcee67ea","updated":"2017-03-15 01:45:49.000000000","message":"sessions is a module.","commit_id":"04c3ca342dc2c4e2972f8e170248cbc4b9d2d96f"}],"networking_odl/tests/unit/ml2/test_networking_topology.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"550bf8c7e99c911f3435eefcfc1d93a4feebf542","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            timeout\u003dtimeout or self.given_timeout)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def test_constructor(self):"},{"line_number":400,"context_line":"        if \u0027_session\u0027 in network_topology.NetworkTopologyClient.__dict__:"},{"line_number":401,"context_line":"            del network_topology.NetworkTopologyClient._session"},{"line_number":402,"context_line":"        # When client is created"},{"line_number":403,"context_line":"        rest_client \u003d network_topology.NetworkTopologyClient("},{"line_number":404,"context_line":"            url\u003dself.given_url_with_port,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a22e58a_9cc8cb76","line":401,"range":{"start_line":400,"start_character":8,"end_line":401,"end_character":63},"updated":"2017-03-14 13:44:32.000000000","message":"Seems to be left over?","commit_id":"04c3ca342dc2c4e2972f8e170248cbc4b9d2d96f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"9b39c369d853f78f1eefe745d03ee0a0dbf9b755","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            timeout\u003dtimeout or self.given_timeout)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def test_constructor(self):"},{"line_number":400,"context_line":"        if \u0027_session\u0027 in network_topology.NetworkTopologyClient.__dict__:"},{"line_number":401,"context_line":"            del network_topology.NetworkTopologyClient._session"},{"line_number":402,"context_line":"        # When client is created"},{"line_number":403,"context_line":"        rest_client \u003d network_topology.NetworkTopologyClient("},{"line_number":404,"context_line":"            url\u003dself.given_url_with_port,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a1ff146_4041010b","line":401,"range":{"start_line":400,"start_character":8,"end_line":401,"end_character":63},"in_reply_to":"5a22e58a_9cc8cb76","updated":"2017-03-15 01:45:49.000000000","message":"Done","commit_id":"04c3ca342dc2c4e2972f8e170248cbc4b9d2d96f"}]}
