)]}'
{"networking_odl/common/constants.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fece10ac9cf695a8ac4bfca964b247814a75ded4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# dict to store url mappings"},{"line_number":82,"context_line":"RESOURCE_MAP \u003d {ODL_QOS_POLICY: ODL_QOS_POLICIES}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_376462e4","line":82,"range":{"start_line":82,"start_character":9,"end_line":82,"end_character":12},"updated":"2017-03-06 17:31:35.000000000","message":"For consistency with Neutron, MAP -\u003e MAPPINGS.\nPersonally, I\u0027m fine with either RESOURCE or PLURAL.","commit_id":"65def88949c8fc5a71884f0b53814a2e9eaa1758"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1314826e353fdb2c94ba12b7803efd26a4b658aa","unresolved":false,"context_lines":[{"line_number":79,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# dict to store url mappings"},{"line_number":82,"context_line":"RESOURCE_MAP \u003d {ODL_QOS_POLICY: ODL_QOS_POLICIES}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_11c3ee8b","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":12},"updated":"2017-03-06 17:07:29.000000000","message":"there is resource map for every resource like port and network etc, so consider renaming it to RESOURCE_PLURAL_MAP ?","commit_id":"65def88949c8fc5a71884f0b53814a2e9eaa1758"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"279560b16583cfac72552af08cd249c9b10ee5a8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# dict to store url mappings"},{"line_number":82,"context_line":"RESOURCE_MAP \u003d {ODL_QOS_POLICY: ODL_QOS_POLICIES}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_d110765c","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":12},"in_reply_to":"ba2be162_11c3ee8b","updated":"2017-03-06 17:13:27.000000000","message":"I feel we shouldn\u0027t restrict it to plural form. This map represents a mapping between openstack resource and odl resource. Any url which deviates from neutronify(object_type + \u0027s\u0027) should be filled in this map.","commit_id":"65def88949c8fc5a71884f0b53814a2e9eaa1758"},{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"884a44559a55ff2d8eb3631a0fd4d82b9bd5ea2d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# dict to store url mappings"},{"line_number":82,"context_line":"RESOURCE_MAP \u003d {ODL_QOS_POLICY: ODL_QOS_POLICIES}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_d7b22606","line":82,"range":{"start_line":82,"start_character":9,"end_line":82,"end_character":12},"in_reply_to":"ba2be162_376462e4","updated":"2017-03-06 18:20:27.000000000","message":"+1 for RESOURCE_URL_MAP.","commit_id":"65def88949c8fc5a71884f0b53814a2e9eaa1758"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"27add0ce7011b353f265e590dc569088ca479d2d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# dict to store url mappings"},{"line_number":82,"context_line":"RESOURCE_MAP \u003d {ODL_QOS_POLICY: ODL_QOS_POLICIES}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_894b30b0","line":82,"range":{"start_line":82,"start_character":9,"end_line":82,"end_character":12},"in_reply_to":"ba2be162_376462e4","updated":"2017-03-07 04:00:14.000000000","message":"Done","commit_id":"65def88949c8fc5a71884f0b53814a2e9eaa1758"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2fbf88bbda1b2c1d95ad6703c085a842720450a1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# dict to store url mappings"},{"line_number":82,"context_line":"RESOURCE_MAP \u003d {ODL_QOS_POLICY: ODL_QOS_POLICIES}"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_fc70f1de","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":12},"in_reply_to":"ba2be162_d110765c","updated":"2017-03-06 17:24:43.000000000","message":"not RESOURCE_PLURAL_MAP it can be RESOURCE_URL_MAP etc, something like that, the reason why I am saying is there is RESOURCE_MAP in neutron for every resource like port and network etc.","commit_id":"65def88949c8fc5a71884f0b53814a2e9eaa1758"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"27add0ce7011b353f265e590dc569088ca479d2d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# dict to store url mappings"},{"line_number":82,"context_line":"RESOURCE_MAP \u003d {ODL_QOS_POLICY: ODL_QOS_POLICIES}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_694efcc2","line":82,"range":{"start_line":82,"start_character":9,"end_line":82,"end_character":12},"in_reply_to":"ba2be162_d7b22606","updated":"2017-03-07 04:00:14.000000000","message":"Done","commit_id":"65def88949c8fc5a71884f0b53814a2e9eaa1758"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"27add0ce7011b353f265e590dc569088ca479d2d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# dict to store url mappings"},{"line_number":82,"context_line":"RESOURCE_MAP \u003d {ODL_QOS_POLICY: ODL_QOS_POLICIES}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_a9c63414","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":12},"in_reply_to":"ba2be162_fc70f1de","updated":"2017-03-07 04:00:14.000000000","message":"Done","commit_id":"65def88949c8fc5a71884f0b53814a2e9eaa1758"}],"networking_odl/common/utils.py":[{"author":{"_account_id":11347,"name":"Rui Zang","email":"rui.zang@yandex.com","username":"rzang"},"change_message_id":"ec4a2daa3d6c35b929c355565343207dc93fa862","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def make_url_object(object_type):"},{"line_number":65,"context_line":"    if object_type[-2:] not in [\u0027ay\u0027, \u0027ey\u0027, \u0027iy\u0027, \u0027oy\u0027, \u0027uy\u0027]:"},{"line_number":66,"context_line":"        obj_pl \u003d neutronify(object_type[:-1] + \u0027ies\u0027)"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        obj_pl \u003d neutronify(object_type + \u0027s\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_74047c17","line":65,"updated":"2017-03-03 07:50:19.000000000","message":"network -\u003e networies?","commit_id":"f09f783dbf732b16da25ed56cdef82fa16cc03f4"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"d00e9476a27b9a3a16d68d7761aa9931b0393c57","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def make_url_object(object_type):"},{"line_number":65,"context_line":"    if object_type[-2:] not in [\u0027ay\u0027, \u0027ey\u0027, \u0027iy\u0027, \u0027oy\u0027, \u0027uy\u0027]:"},{"line_number":66,"context_line":"        obj_pl \u003d neutronify(object_type[:-1] + \u0027ies\u0027)"},{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        obj_pl \u003d neutronify(object_type + \u0027s\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_fdadaf84","line":65,"in_reply_to":"ba2be162_74047c17","updated":"2017-03-03 09:10:35.000000000","message":"Thank you. Sorry for the bad code. Fixed it in next patch set.","commit_id":"f09f783dbf732b16da25ed56cdef82fa16cc03f4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"76329efb8ec5fae5413cd70d517f067524a7b091","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def make_url_object(object_type):"},{"line_number":65,"context_line":"    if (object_type[-1:] \u003d\u003d \u0027y\u0027 and"},{"line_number":66,"context_line":"            object_type[-2:-1] not in [\u0027a\u0027, \u0027e\u0027, \u0027i\u0027, \u0027o\u0027, \u0027u\u0027]):"},{"line_number":67,"context_line":"        obj_pl \u003d neutronify(object_type[:-1] + \u0027ies\u0027)"},{"line_number":68,"context_line":"    else:"},{"line_number":69,"context_line":"        obj_pl \u003d neutronify(object_type + \u0027s\u0027)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_c99d8367","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":53},"updated":"2017-03-03 14:40:01.000000000","message":"What about creating a mapping dictionary like Neutron extension?","commit_id":"62d162e87f8e2e680722625ff8decb34cc9cb40f"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"8728c08b82b39c6346366eb171e28b39be9d6186","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def make_url_object(object_type):"},{"line_number":65,"context_line":"    if (object_type[-1:] \u003d\u003d \u0027y\u0027 and"},{"line_number":66,"context_line":"            object_type[-2:-1] not in [\u0027a\u0027, \u0027e\u0027, \u0027i\u0027, \u0027o\u0027, \u0027u\u0027]):"},{"line_number":67,"context_line":"        obj_pl \u003d neutronify(object_type[:-1] + \u0027ies\u0027)"},{"line_number":68,"context_line":"    else:"},{"line_number":69,"context_line":"        obj_pl \u003d neutronify(object_type + \u0027s\u0027)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_126237d8","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":53},"in_reply_to":"ba2be162_1b2a5d90","updated":"2017-03-05 07:29:15.000000000","message":"Default should be +\u0027s\u0027 unless an eplicit mapping exists.\n\nAlso please add unit tests.","commit_id":"62d162e87f8e2e680722625ff8decb34cc9cb40f"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"bdebf74bf4b639f2d7fd96b5b651079aa2a77490","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def make_url_object(object_type):"},{"line_number":65,"context_line":"    if (object_type[-1:] \u003d\u003d \u0027y\u0027 and"},{"line_number":66,"context_line":"            object_type[-2:-1] not in [\u0027a\u0027, \u0027e\u0027, \u0027i\u0027, \u0027o\u0027, \u0027u\u0027]):"},{"line_number":67,"context_line":"        obj_pl \u003d neutronify(object_type[:-1] + \u0027ies\u0027)"},{"line_number":68,"context_line":"    else:"},{"line_number":69,"context_line":"        obj_pl \u003d neutronify(object_type + \u0027s\u0027)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_1b2a5d90","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":53},"in_reply_to":"ba2be162_3b565dce","updated":"2017-03-04 10:35:22.000000000","message":"How about adding mapping only for cases which differ from neutronify(object_type + \u0027s\u0027).","commit_id":"62d162e87f8e2e680722625ff8decb34cc9cb40f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"eefb9aab0c598f8e3c335d53f67262ab2552cf69","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def make_url_object(object_type):"},{"line_number":65,"context_line":"    if (object_type[-1:] \u003d\u003d \u0027y\u0027 and"},{"line_number":66,"context_line":"            object_type[-2:-1] not in [\u0027a\u0027, \u0027e\u0027, \u0027i\u0027, \u0027o\u0027, \u0027u\u0027]):"},{"line_number":67,"context_line":"        obj_pl \u003d neutronify(object_type[:-1] + \u0027ies\u0027)"},{"line_number":68,"context_line":"    else:"},{"line_number":69,"context_line":"        obj_pl \u003d neutronify(object_type + \u0027s\u0027)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_3b565dce","line":67,"range":{"start_line":65,"start_character":0,"end_line":67,"end_character":53},"in_reply_to":"ba2be162_c99d8367","updated":"2017-03-03 16:31:04.000000000","message":"yea having one to one mapping is would be definitely better and less error prone. this + there should be unit test added as well to cover this case","commit_id":"62d162e87f8e2e680722625ff8decb34cc9cb40f"}],"networking_odl/tests/unit/common/test_utils.py":[{"author":{"_account_id":18429,"name":"Vishal Thapar","email":"vthapar@redhat.com","username":"thapar"},"change_message_id":"884a44559a55ff2d8eb3631a0fd4d82b9bd5ea2d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.assertEqual(\u0027qos/policies\u0027, url_object)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_make_url_object_conversion(self):"},{"line_number":39,"context_line":"        self.assertEqual(\u0027networks\u0027, utils.make_url_object(\u0027network\u0027))"},{"line_number":40,"context_line":"        self.assertEqual(\u0027l2-gateways\u0027, utils.make_url_object(\u0027l2_gateway\u0027))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_5d02d7b5","line":39,"updated":"2017-03-06 18:20:27.000000000","message":"ideally I\u0027d like this written in such a way that it tests for every resource by picking it from constants.py, but that won\u0027t be possible without duplicating them in this file or by refactoring lots of code.","commit_id":"65def88949c8fc5a71884f0b53814a2e9eaa1758"}]}