)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"219452d5031e787d329f7a6391a07b0eca2dc7ab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update sample conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The same conf file we have is outdated and"},{"line_number":10,"context_line":"for v1 mechanism only. This patch updates the"},{"line_number":11,"context_line":"sample conf with v2 drivers."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffe62b97_38557651","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":13},"updated":"2017-03-24 03:36:16.000000000","message":"correct it.","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"219452d5031e787d329f7a6391a07b0eca2dc7ab","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update sample conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The same conf file we have is outdated and"},{"line_number":10,"context_line":"for v1 mechanism only. This patch updates the"},{"line_number":11,"context_line":"sample conf with v2 drivers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6fff71ba14d0ff50311c73c9d9b89d281fed08e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffe62b97_d84b2aae","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":17},"updated":"2017-03-24 03:36:16.000000000","message":"\u0027driver\u0027 missing.","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"}],"devstack/local.conf.example":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"024e1ddad5f620d024d3ffeb30aa24bfb8d2e75f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This will fetch the latest ODL snapshot"},{"line_number":3,"context_line":"ODL_RELEASE\u003dlatest-snapshot"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Set here which driver, v1 or v2 driver"},{"line_number":6,"context_line":"# by default it is v2"},{"line_number":7,"context_line":"#ODL_V2DRIVER\u003dFalse"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Set here which port binding controller by default it is psuedo-port-binding-controller."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_bfe107d3","line":6,"range":{"start_line":5,"start_character":2,"end_line":6,"end_character":21},"updated":"2017-03-14 09:21:19.000000000","message":"nit: I\u0027d phrase it as \"V2 Driver is the default, uncomment to use the V1 driver instead\"","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This will fetch the latest ODL snapshot"},{"line_number":3,"context_line":"ODL_RELEASE\u003dlatest-snapshot"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Set here which driver, v1 or v2 driver"},{"line_number":6,"context_line":"# by default it is v2"},{"line_number":7,"context_line":"#ODL_V2DRIVER\u003dFalse"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Set here which port binding controller by default it is psuedo-port-binding-controller."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_1cb05bdd","line":6,"range":{"start_line":5,"start_character":2,"end_line":6,"end_character":21},"in_reply_to":"5a22e58a_bfe107d3","updated":"2017-03-15 00:15:52.000000000","message":"Done","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"024e1ddad5f620d024d3ffeb30aa24bfb8d2e75f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#ODL_PORT_BINDING_CONTROLLER\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Set here which ODL openstack service provider to us"},{"line_number":14,"context_line":"ODL_NETVIRT_KARAF_FEATURE\u003dodl-neutron-service,odl-restconf-all,odl-aaa-authn,odl-dlux-core,odl-mdsal-apidocs,odl-netvirt-openstack,odl-neutron-logger"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Switch to using the ODL\u0027s L3 implementation"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_9ae8d918","line":13,"range":{"start_line":13,"start_character":51,"end_line":13,"end_character":53},"updated":"2017-03-14 09:21:19.000000000","message":"nit:use","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#ODL_PORT_BINDING_CONTROLLER\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Set here which ODL openstack service provider to us"},{"line_number":14,"context_line":"ODL_NETVIRT_KARAF_FEATURE\u003dodl-neutron-service,odl-restconf-all,odl-aaa-authn,odl-dlux-core,odl-mdsal-apidocs,odl-netvirt-openstack,odl-neutron-logger"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Switch to using the ODL\u0027s L3 implementation"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_5ccad350","line":13,"range":{"start_line":13,"start_character":51,"end_line":13,"end_character":53},"in_reply_to":"5a22e58a_9ae8d918","updated":"2017-03-15 00:15:52.000000000","message":"Done","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"024e1ddad5f620d024d3ffeb30aa24bfb8d2e75f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Set here which ODL openstack service provider to us"},{"line_number":14,"context_line":"ODL_NETVIRT_KARAF_FEATURE\u003dodl-neutron-service,odl-restconf-all,odl-aaa-authn,odl-dlux-core,odl-mdsal-apidocs,odl-netvirt-openstack,odl-neutron-logger"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Switch to using the ODL\u0027s L3 implementation"},{"line_number":17,"context_line":"ODL_L3\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_5a5581c4","line":14,"range":{"start_line":14,"start_character":109,"end_line":14,"end_character":149},"updated":"2017-03-14 09:21:19.000000000","message":"These are the core ones (well logger is just helpful not really core), should the others be mentioned explicitly? They\u0027re either pulled in as dependencies or it should be clear what\u0027s the value from installing those features.","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Set here which ODL openstack service provider to us"},{"line_number":14,"context_line":"ODL_NETVIRT_KARAF_FEATURE\u003dodl-neutron-service,odl-restconf-all,odl-aaa-authn,odl-dlux-core,odl-mdsal-apidocs,odl-netvirt-openstack,odl-neutron-logger"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Switch to using the ODL\u0027s L3 implementation"},{"line_number":17,"context_line":"ODL_L3\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_25141af4","line":14,"range":{"start_line":14,"start_character":109,"end_line":14,"end_character":149},"in_reply_to":"5a22e58a_5a5581c4","updated":"2017-03-15 00:15:52.000000000","message":"Done","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"024e1ddad5f620d024d3ffeb30aa24bfb8d2e75f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"ODL_L3\u003dTrue"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Set Host IP here."},{"line_number":20,"context_line":"HOST_IP\u003dip route get 8.8.8.8 | awk \u0027{print $NF; exit}\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# public network connectivity"},{"line_number":23,"context_line":"Q_USE_PUBLIC_VETH\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_3acb6574","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":54},"updated":"2017-03-14 09:21:19.000000000","message":"Nice way but this defaults to the externally reachable network while one might want to use an internal network.\nPerhaps this can be a hist in the comment?\n\nAlso if you put it like this and someone doesn\u0027t change this line and use as is would this work?\nI think this wouldn\u0027t unless it was something like:\nHOST_IP\u003d$(ip route get 8.8.8.8 | awk \u0027{print $NF; exit}\u0027)\n\nBut I might be wrong about this..","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":17,"context_line":"ODL_L3\u003dTrue"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Set Host IP here."},{"line_number":20,"context_line":"HOST_IP\u003dip route get 8.8.8.8 | awk \u0027{print $NF; exit}\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# public network connectivity"},{"line_number":23,"context_line":"Q_USE_PUBLIC_VETH\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_bc7e67ac","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":54},"in_reply_to":"5a22e58a_3acb6574","updated":"2017-03-15 00:15:52.000000000","message":"I can still use this and leave a comment if one wishes to use some other network","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"40f8cd878dd8649581bb4d65af4c5ffce026b4c0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ODL_NETVIRT_DEBUG_LOGS\u003dTrue"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Q_USE_DEBUG_COMMAND\u003dTrue"},{"line_number":32,"context_line":"NETWORK_GATEWAY\u003d10.1.0.1"},{"line_number":33,"context_line":"DEST\u003d/opt/stack/"},{"line_number":34,"context_line":"# move DATA_DIR outside of DEST to keep DEST a bit cleaner"},{"line_number":35,"context_line":"DATA_DIR\u003d/opt/stack/data"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_9f5d2bef","line":32,"updated":"2017-03-14 09:03:03.000000000","message":"Please describe this parameter as well, because this way a user will be able to customized his/her environment.","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"024e1ddad5f620d024d3ffeb30aa24bfb8d2e75f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ODL_NETVIRT_DEBUG_LOGS\u003dTrue"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Q_USE_DEBUG_COMMAND\u003dTrue"},{"line_number":32,"context_line":"NETWORK_GATEWAY\u003d10.1.0.1"},{"line_number":33,"context_line":"DEST\u003d/opt/stack/"},{"line_number":34,"context_line":"# move DATA_DIR outside of DEST to keep DEST a bit cleaner"},{"line_number":35,"context_line":"DATA_DIR\u003d/opt/stack/data"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_7ad87d1e","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":24},"updated":"2017-03-14 09:21:19.000000000","message":"Seems this wouldn\u0027t work","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":29,"context_line":"ODL_NETVIRT_DEBUG_LOGS\u003dTrue"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Q_USE_DEBUG_COMMAND\u003dTrue"},{"line_number":32,"context_line":"NETWORK_GATEWAY\u003d10.1.0.1"},{"line_number":33,"context_line":"DEST\u003d/opt/stack/"},{"line_number":34,"context_line":"# move DATA_DIR outside of DEST to keep DEST a bit cleaner"},{"line_number":35,"context_line":"DATA_DIR\u003d/opt/stack/data"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_bfc1f930","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":24},"in_reply_to":"5a22e58a_7ad87d1e","updated":"2017-03-15 00:15:52.000000000","message":"Done","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"024e1ddad5f620d024d3ffeb30aa24bfb8d2e75f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEST\u003d/opt/stack/"},{"line_number":34,"context_line":"# move DATA_DIR outside of DEST to keep DEST a bit cleaner"},{"line_number":35,"context_line":"DATA_DIR\u003d/opt/stack/data"},{"line_number":36,"context_line":"ACTIVE_TIMEOUT\u003d90"},{"line_number":37,"context_line":"BOOT_TIMEOUT\u003d90"},{"line_number":38,"context_line":"ASSOCIATE_TIMEOUT\u003d60"},{"line_number":39,"context_line":"TERMINATE_TIMEOUT\u003d60"},{"line_number":40,"context_line":"MYSQL_PASSWORD\u003dsecretmysql"},{"line_number":41,"context_line":"DATABASE_PASSWORD\u003dsecretdatabase"},{"line_number":42,"context_line":"RABBIT_PASSWORD\u003dsecretrabbit"},{"line_number":43,"context_line":"ADMIN_PASSWORD\u003dsecretadmin"},{"line_number":44,"context_line":"SERVICE_PASSWORD\u003dsecretservice"},{"line_number":45,"context_line":"SERVICE_TOKEN\u003d111222333444"},{"line_number":46,"context_line":"SWIFT_HASH\u003d1234123412341234"},{"line_number":47,"context_line":"ROOTSLEEP\u003d0"},{"line_number":48,"context_line":"# ERROR_ON_CLONE should never be set to FALSE in gate jobs."},{"line_number":49,"context_line":"# Setting up git trees must be done by zuul"},{"line_number":50,"context_line":"# because it needs specific git references directly from gerrit"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_5ae581a6","line":47,"range":{"start_line":36,"start_character":0,"end_line":47,"end_character":11},"updated":"2017-03-14 09:21:19.000000000","message":"This looks like it was taken from something very specific, most local.conf wouldn\u0027t need this and for passwords usually what\u0027s used is:\n\nADMIN_PASSWORD\u003dpassword\nMYSQL_PASSWORD\u003d${ADMIN_PASSWORD}\nRABBIT_PASSWORD\u003d${ADMIN_PASSWORD}\nSERVICE_PASSWORD\u003d${ADMIN_PASSWORD}\nSERVICE_TOKEN\u003dsupersecrettoken","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEST\u003d/opt/stack/"},{"line_number":34,"context_line":"# move DATA_DIR outside of DEST to keep DEST a bit cleaner"},{"line_number":35,"context_line":"DATA_DIR\u003d/opt/stack/data"},{"line_number":36,"context_line":"ACTIVE_TIMEOUT\u003d90"},{"line_number":37,"context_line":"BOOT_TIMEOUT\u003d90"},{"line_number":38,"context_line":"ASSOCIATE_TIMEOUT\u003d60"},{"line_number":39,"context_line":"TERMINATE_TIMEOUT\u003d60"},{"line_number":40,"context_line":"MYSQL_PASSWORD\u003dsecretmysql"},{"line_number":41,"context_line":"DATABASE_PASSWORD\u003dsecretdatabase"},{"line_number":42,"context_line":"RABBIT_PASSWORD\u003dsecretrabbit"},{"line_number":43,"context_line":"ADMIN_PASSWORD\u003dsecretadmin"},{"line_number":44,"context_line":"SERVICE_PASSWORD\u003dsecretservice"},{"line_number":45,"context_line":"SERVICE_TOKEN\u003d111222333444"},{"line_number":46,"context_line":"SWIFT_HASH\u003d1234123412341234"},{"line_number":47,"context_line":"ROOTSLEEP\u003d0"},{"line_number":48,"context_line":"# ERROR_ON_CLONE should never be set to FALSE in gate jobs."},{"line_number":49,"context_line":"# Setting up git trees must be done by zuul"},{"line_number":50,"context_line":"# because it needs specific git references directly from gerrit"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_9f4b5d59","line":47,"range":{"start_line":36,"start_character":0,"end_line":47,"end_character":11},"in_reply_to":"5a22e58a_5ae581a6","updated":"2017-03-15 00:15:52.000000000","message":"Done","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"024e1ddad5f620d024d3ffeb30aa24bfb8d2e75f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"SERVICE_TOKEN\u003d111222333444"},{"line_number":46,"context_line":"SWIFT_HASH\u003d1234123412341234"},{"line_number":47,"context_line":"ROOTSLEEP\u003d0"},{"line_number":48,"context_line":"# ERROR_ON_CLONE should never be set to FALSE in gate jobs."},{"line_number":49,"context_line":"# Setting up git trees must be done by zuul"},{"line_number":50,"context_line":"# because it needs specific git references directly from gerrit"},{"line_number":51,"context_line":"# to correctly do testing. Otherwise you are not testing"},{"line_number":52,"context_line":"# the code you have posted for review."},{"line_number":53,"context_line":"ENABLED_SERVICES\u003dc-api,c-bak,c-sch,c-vol,cinder,dstat,g-api,g-reg,key,mysql,n-api,n-cond,n-cpu,n-crt,n-obj,n-sch,q-dhcp,q-meta,q-svc,quantum,rabbit,tempest"},{"line_number":54,"context_line":"ENABLED_SERVICES+\u003d,placement-api,placement-client"},{"line_number":55,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_bae115d3","line":52,"range":{"start_line":48,"start_character":0,"end_line":52,"end_character":38},"updated":"2017-03-14 09:21:19.000000000","message":"Doesn\u0027t seem related","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":45,"context_line":"SERVICE_TOKEN\u003d111222333444"},{"line_number":46,"context_line":"SWIFT_HASH\u003d1234123412341234"},{"line_number":47,"context_line":"ROOTSLEEP\u003d0"},{"line_number":48,"context_line":"# ERROR_ON_CLONE should never be set to FALSE in gate jobs."},{"line_number":49,"context_line":"# Setting up git trees must be done by zuul"},{"line_number":50,"context_line":"# because it needs specific git references directly from gerrit"},{"line_number":51,"context_line":"# to correctly do testing. Otherwise you are not testing"},{"line_number":52,"context_line":"# the code you have posted for review."},{"line_number":53,"context_line":"ENABLED_SERVICES\u003dc-api,c-bak,c-sch,c-vol,cinder,dstat,g-api,g-reg,key,mysql,n-api,n-cond,n-cpu,n-crt,n-obj,n-sch,q-dhcp,q-meta,q-svc,quantum,rabbit,tempest"},{"line_number":54,"context_line":"ENABLED_SERVICES+\u003d,placement-api,placement-client"},{"line_number":55,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_fc353ff7","line":52,"range":{"start_line":48,"start_character":0,"end_line":52,"end_character":38},"in_reply_to":"5a22e58a_bae115d3","updated":"2017-03-15 00:15:52.000000000","message":"Done","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"40f8cd878dd8649581bb4d65af4c5ffce026b4c0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# because it needs specific git references directly from gerrit"},{"line_number":51,"context_line":"# to correctly do testing. Otherwise you are not testing"},{"line_number":52,"context_line":"# the code you have posted for review."},{"line_number":53,"context_line":"ENABLED_SERVICES\u003dc-api,c-bak,c-sch,c-vol,cinder,dstat,g-api,g-reg,key,mysql,n-api,n-cond,n-cpu,n-crt,n-obj,n-sch,q-dhcp,q-meta,q-svc,quantum,rabbit,tempest"},{"line_number":54,"context_line":"ENABLED_SERVICES+\u003d,placement-api,placement-client"},{"line_number":55,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"},{"line_number":56,"context_line":"# Screen console logs will capture service logs."},{"line_number":57,"context_line":"SYSLOG\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_3f235707","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":49},"updated":"2017-03-14 09:03:03.000000000","message":"If possible and does not affect development of networking-odl then we can disable cinder related services.\n\nIs there any placement specific requirement for networking-odl. If no then we can keep development environment as light as possible.","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"ff31b0f0386779731fc96929a8e21555a1b7d3a0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# because it needs specific git references directly from gerrit"},{"line_number":51,"context_line":"# to correctly do testing. Otherwise you are not testing"},{"line_number":52,"context_line":"# the code you have posted for review."},{"line_number":53,"context_line":"ENABLED_SERVICES\u003dc-api,c-bak,c-sch,c-vol,cinder,dstat,g-api,g-reg,key,mysql,n-api,n-cond,n-cpu,n-crt,n-obj,n-sch,q-dhcp,q-meta,q-svc,quantum,rabbit,tempest"},{"line_number":54,"context_line":"ENABLED_SERVICES+\u003d,placement-api,placement-client"},{"line_number":55,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"},{"line_number":56,"context_line":"# Screen console logs will capture service logs."},{"line_number":57,"context_line":"SYSLOG\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_f9eb9fae","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":49},"updated":"2017-03-14 08:30:05.000000000","message":"why not using the disable_service and enable_service? \nIn this case you not enabling vnc, why?","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b57a6b2e589ae1fee0cef846f51f93d8bcab38c7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# because it needs specific git references directly from gerrit"},{"line_number":51,"context_line":"# to correctly do testing. Otherwise you are not testing"},{"line_number":52,"context_line":"# the code you have posted for review."},{"line_number":53,"context_line":"ENABLED_SERVICES\u003dc-api,c-bak,c-sch,c-vol,cinder,dstat,g-api,g-reg,key,mysql,n-api,n-cond,n-cpu,n-crt,n-obj,n-sch,q-dhcp,q-meta,q-svc,quantum,rabbit,tempest"},{"line_number":54,"context_line":"ENABLED_SERVICES+\u003d,placement-api,placement-client"},{"line_number":55,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"},{"line_number":56,"context_line":"# Screen console logs will capture service logs."},{"line_number":57,"context_line":"SYSLOG\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_3d442e73","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":49},"in_reply_to":"3a1ff146_ffed3126","updated":"2017-03-15 01:32:32.000000000","message":"Instread of directly setting ENABLED_SERVICE, we can\ndisable_all_service\nenable_service xxx.","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# because it needs specific git references directly from gerrit"},{"line_number":51,"context_line":"# to correctly do testing. Otherwise you are not testing"},{"line_number":52,"context_line":"# the code you have posted for review."},{"line_number":53,"context_line":"ENABLED_SERVICES\u003dc-api,c-bak,c-sch,c-vol,cinder,dstat,g-api,g-reg,key,mysql,n-api,n-cond,n-cpu,n-crt,n-obj,n-sch,q-dhcp,q-meta,q-svc,quantum,rabbit,tempest"},{"line_number":54,"context_line":"ENABLED_SERVICES+\u003d,placement-api,placement-client"},{"line_number":55,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"},{"line_number":56,"context_line":"# Screen console logs will capture service logs."},{"line_number":57,"context_line":"SYSLOG\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_ffed3126","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":49},"in_reply_to":"5a22e58a_3f235707","updated":"2017-03-15 00:15:52.000000000","message":"I\u0027ll keep all but leave a note if someone wants to disable then it can be done.","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# because it needs specific git references directly from gerrit"},{"line_number":51,"context_line":"# to correctly do testing. Otherwise you are not testing"},{"line_number":52,"context_line":"# the code you have posted for review."},{"line_number":53,"context_line":"ENABLED_SERVICES\u003dc-api,c-bak,c-sch,c-vol,cinder,dstat,g-api,g-reg,key,mysql,n-api,n-cond,n-cpu,n-crt,n-obj,n-sch,q-dhcp,q-meta,q-svc,quantum,rabbit,tempest"},{"line_number":54,"context_line":"ENABLED_SERVICES+\u003d,placement-api,placement-client"},{"line_number":55,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"},{"line_number":56,"context_line":"# Screen console logs will capture service logs."},{"line_number":57,"context_line":"SYSLOG\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_5faf25e3","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":49},"in_reply_to":"5a22e58a_f9eb9fae","updated":"2017-03-15 00:15:52.000000000","message":"i\u0027ll change it to enable_service, but is there any difference b/w functionality of both ?","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"40f8cd878dd8649581bb4d65af4c5ffce026b4c0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"FLOATING_RANGE\u003d172.24.5.0/24"},{"line_number":63,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d172.24.5.1"},{"line_number":64,"context_line":"FIXED_NETWORK_SIZE\u003d4096"},{"line_number":65,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":66,"context_line":"SWIFT_REPLICAS\u003d1"},{"line_number":67,"context_line":"LOG_COLOR\u003dFalse"},{"line_number":68,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_3f519763","line":65,"updated":"2017-03-14 09:03:03.000000000","message":"Isn\u0027t it default value?","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"40f8cd878dd8649581bb4d65af4c5ffce026b4c0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d172.24.5.1"},{"line_number":64,"context_line":"FIXED_NETWORK_SIZE\u003d4096"},{"line_number":65,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":66,"context_line":"SWIFT_REPLICAS\u003d1"},{"line_number":67,"context_line":"LOG_COLOR\u003dFalse"},{"line_number":68,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":69,"context_line":"UNDO_REQUIREMENTS\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_bf990722","line":66,"updated":"2017-03-14 09:03:03.000000000","message":"It seems like this is parameter for swift. If it is so, is swift enabled in this configuration file. If it is enabled then i think we don\u0027t require swift for development, we can disable it. If swift is not enabled then is this parameter being used anywhere?","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":63,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d172.24.5.1"},{"line_number":64,"context_line":"FIXED_NETWORK_SIZE\u003d4096"},{"line_number":65,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":66,"context_line":"SWIFT_REPLICAS\u003d1"},{"line_number":67,"context_line":"LOG_COLOR\u003dFalse"},{"line_number":68,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":69,"context_line":"UNDO_REQUIREMENTS\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_3fec29c7","line":66,"in_reply_to":"5a22e58a_bf990722","updated":"2017-03-15 00:15:52.000000000","message":"Done","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"40f8cd878dd8649581bb4d65af4c5ffce026b4c0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":70,"context_line":"CINDER_PERIODIC_INTERVAL\u003d10"},{"line_number":71,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":72,"context_line":"CEILOMETER_BACKEND\u003dmysql"},{"line_number":73,"context_line":"LIBS_FROM_GIT\u003d"},{"line_number":74,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":75,"context_line":"# set this until all testing platforms have libvirt \u003e\u003d 1.2.11"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_df3a43e7","line":72,"updated":"2017-03-14 09:03:03.000000000","message":"Is ceilometer enabled in this environment, if it is enabled and not required for networking-odl then we should disable it otherwise remove this entry.","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"96f115ac8b8704776d19216bd8eda597e90038ea","unresolved":false,"context_lines":[{"line_number":69,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":70,"context_line":"CINDER_PERIODIC_INTERVAL\u003d10"},{"line_number":71,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":72,"context_line":"CEILOMETER_BACKEND\u003dmysql"},{"line_number":73,"context_line":"LIBS_FROM_GIT\u003d"},{"line_number":74,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":75,"context_line":"# set this until all testing platforms have libvirt \u003e\u003d 1.2.11"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a1ff146_1fe76de5","line":72,"in_reply_to":"5a22e58a_df3a43e7","updated":"2017-03-15 00:15:52.000000000","message":"Done","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"ff31b0f0386779731fc96929a8e21555a1b7d3a0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"VOLUME_BACKING_FILE_SIZE\u003d24G"},{"line_number":82,"context_line":"TEMPEST_HTTP_IMAGE\u003dhttp://git.openstack.org/static/openstack.png"},{"line_number":83,"context_line":"FORCE_CONFIG_DRIVE\u003dFalse"},{"line_number":84,"context_line":"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a22e58a_39f53783","line":84,"updated":"2017-03-14 08:30:05.000000000","message":"can you add example of VLAN/Vxlan network type configuration?","commit_id":"1d8cf0e86e6df96894a0a2dbc8419aa95abe3ef0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e78be654082b9e356528d731e01bf3276889c268","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Enable debug logs for odl ovsdb"},{"line_number":36,"context_line":"ODL_NETVIRT_DEBUG_LOGS\u003dTrue"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Q_USE_DEBUG_COMMAND\u003dTrue"},{"line_number":39,"context_line":"DEST\u003d/opt/stack/"},{"line_number":40,"context_line":"# move DATA_DIR outside of DEST to keep DEST a bit cleaner"},{"line_number":41,"context_line":"DATA_DIR\u003d/opt/stack/data"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1a1ced50_d810995c","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":24},"updated":"2017-03-23 17:49:11.000000000","message":"It is an config why would someone grep it in code?\nI believe I can comment it out since it is enabled by default, I think it is for using --debug in cli","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# Enable debug logs for odl ovsdb"},{"line_number":36,"context_line":"ODL_NETVIRT_DEBUG_LOGS\u003dTrue"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Q_USE_DEBUG_COMMAND\u003dTrue"},{"line_number":39,"context_line":"DEST\u003d/opt/stack/"},{"line_number":40,"context_line":"# move DATA_DIR outside of DEST to keep DEST a bit cleaner"},{"line_number":41,"context_line":"DATA_DIR\u003d/opt/stack/data"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_16ccaf34","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":19},"updated":"2017-03-15 03:15:59.000000000","message":"What is this option being used for? I grep it in code, but i could not find anywhere in devstack.","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"enable_service n-cond"},{"line_number":56,"context_line":"enable_service n-cpu"},{"line_number":57,"context_line":"enable_service n-crt"},{"line_number":58,"context_line":"enable_service n-obj"},{"line_number":59,"context_line":"enable_service n-sch"},{"line_number":60,"context_line":"enable_service q-dhcp"},{"line_number":61,"context_line":"enable_service q-meta"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_f6a0f3a7","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":20},"updated":"2017-03-15 03:15:59.000000000","message":"What is this line for?","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"enable_service g-reg"},{"line_number":52,"context_line":"enable_service key"},{"line_number":53,"context_line":"enable_service mysql"},{"line_number":54,"context_line":"enable_service n-api"},{"line_number":55,"context_line":"enable_service n-cond"},{"line_number":56,"context_line":"enable_service n-cpu"},{"line_number":57,"context_line":"enable_service n-crt"},{"line_number":58,"context_line":"enable_service n-obj"},{"line_number":59,"context_line":"enable_service n-sch"},{"line_number":60,"context_line":"enable_service q-dhcp"},{"line_number":61,"context_line":"enable_service q-meta"},{"line_number":62,"context_line":"enable_service q-svc"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_56e2a704","line":59,"range":{"start_line":54,"start_character":0,"end_line":59,"end_character":20},"updated":"2017-03-15 03:15:59.000000000","message":"Can we make logical grouping of the components for example https://docs.openstack.org/developer/devstack/configuration.html#heat done here\n\nenable_service heat h-api h-api-cfn h-api-cw h-eng\n\nrather then separating them in different line.\n\nMake this change for all the services.","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"enable_service n-sch"},{"line_number":60,"context_line":"enable_service q-dhcp"},{"line_number":61,"context_line":"enable_service q-meta"},{"line_number":62,"context_line":"enable_service q-svc"},{"line_number":63,"context_line":"enable_service quantum"},{"line_number":64,"context_line":"enable_service rabbit"},{"line_number":65,"context_line":"enable_service tempest"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_d6ef77ae","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":20},"updated":"2017-03-15 03:15:59.000000000","message":"is it being used anywhere in the tests etc.? If not being used, we can remove it.","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"enable_service quantum"},{"line_number":64,"context_line":"enable_service rabbit"},{"line_number":65,"context_line":"enable_service tempest"},{"line_number":66,"context_line":"enable_service placement-api"},{"line_number":67,"context_line":"enable_service placement-client"},{"line_number":68,"context_line":"enable_service n-novnc"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# These can be enabled if storage is needed to do"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_5687070f","line":67,"range":{"start_line":66,"start_character":0,"end_line":67,"end_character":31},"updated":"2017-03-15 03:15:59.000000000","message":"Is there any specific test cases for them or requirement for networking-odl or they affect networking odl in any way?","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e78be654082b9e356528d731e01bf3276889c268","unresolved":false,"context_lines":[{"line_number":63,"context_line":"enable_service quantum"},{"line_number":64,"context_line":"enable_service rabbit"},{"line_number":65,"context_line":"enable_service tempest"},{"line_number":66,"context_line":"enable_service placement-api"},{"line_number":67,"context_line":"enable_service placement-client"},{"line_number":68,"context_line":"enable_service n-novnc"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# These can be enabled if storage is needed to do"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1a1ced50_6c61aad3","line":67,"range":{"start_line":66,"start_character":0,"end_line":67,"end_character":31},"in_reply_to":"3a1ff146_5687070f","updated":"2017-03-23 17:49:11.000000000","message":"nova requires this anyway","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"enable_service tempest"},{"line_number":66,"context_line":"enable_service placement-api"},{"line_number":67,"context_line":"enable_service placement-client"},{"line_number":68,"context_line":"enable_service n-novnc"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# These can be enabled if storage is needed to do"},{"line_number":71,"context_line":"# any feature or testing for integration"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_b6491bd3","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":22},"updated":"2017-03-15 03:15:59.000000000","message":"May be it can be moved with n-nova option.","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# These can be enabled if storage is needed to do"},{"line_number":71,"context_line":"# any feature or testing for integration"},{"line_number":72,"context_line":"disable_service c-api"},{"line_number":73,"context_line":"disable_service c-vol"},{"line_number":74,"context_line":"disable_service c-sch"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"},{"line_number":77,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_d6aa1770","line":74,"range":{"start_line":72,"start_character":0,"end_line":74,"end_character":21},"updated":"2017-03-15 03:15:59.000000000","message":"same as above","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e78be654082b9e356528d731e01bf3276889c268","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# These can be enabled if storage is needed to do"},{"line_number":71,"context_line":"# any feature or testing for integration"},{"line_number":72,"context_line":"disable_service c-api"},{"line_number":73,"context_line":"disable_service c-vol"},{"line_number":74,"context_line":"disable_service c-sch"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"},{"line_number":77,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1a1ced50_6c544aca","line":74,"range":{"start_line":72,"start_character":0,"end_line":74,"end_character":21},"in_reply_to":"3a1ff146_d6aa1770","updated":"2017-03-23 17:49:11.000000000","message":"it is already grouped what else can be done ?","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"disable_service c-vol"},{"line_number":74,"context_line":"disable_service c-sch"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Screen console logs will capture service logs."},{"line_number":79,"context_line":"SYSLOG\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_f6039374","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":54},"updated":"2017-03-15 03:15:59.000000000","message":"Can you please provide comment for all these parameters what are they being used for.\n\nI checked euca in devstack, it is being mentioned in HACKING.rst not in code, i am not sure how it will affect.\n\nThe same goes to client-env, it is the script name in the devstack.","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e78be654082b9e356528d731e01bf3276889c268","unresolved":false,"context_lines":[{"line_number":73,"context_line":"disable_service c-vol"},{"line_number":74,"context_line":"disable_service c-sch"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"SKIP_EXERCISES\u003dboot_from_volume,bundle,client-env,euca"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Screen console logs will capture service logs."},{"line_number":79,"context_line":"SYSLOG\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1a1ced50_6c19aa22","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":54},"in_reply_to":"3a1ff146_f6039374","updated":"2017-03-23 17:49:11.000000000","message":"skipping some tasks based on what is not enabled.","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"FIXED_NETWORK_SIZE\u003d4096"},{"line_number":87,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":88,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":89,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":90,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":91,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":92,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_f6ed538f","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":17},"updated":"2017-03-15 03:15:59.000000000","message":"grep does not return anything in devstack. Can you check it once again?","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e78be654082b9e356528d731e01bf3276889c268","unresolved":false,"context_lines":[{"line_number":86,"context_line":"FIXED_NETWORK_SIZE\u003d4096"},{"line_number":87,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":88,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":89,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":90,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":91,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":92,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1a1ced50_cca45ebb","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":17},"in_reply_to":"3a1ff146_f6ed538f","updated":"2017-03-23 17:49:11.000000000","message":"these are bash variable why would grep will find these ? these may be used by services or anything else. I carried over some from previous conf","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"7e2cce845e9bb9517b166288887fa89235f2470e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":88,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":89,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":90,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":91,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":92,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":93,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3a1ff146_b6fcbb3f","line":90,"range":{"start_line":90,"start_character":7,"end_line":90,"end_character":18},"updated":"2017-03-15 03:15:59.000000000","message":"Grep for this also does not return anything, can you please confirm it?","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e78be654082b9e356528d731e01bf3276889c268","unresolved":false,"context_lines":[{"line_number":87,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":88,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":89,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":90,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":91,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":92,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":93,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1a1ced50_8c9b4672","line":90,"range":{"start_line":90,"start_character":7,"end_line":90,"end_character":18},"in_reply_to":"3a1ff146_b6fcbb3f","updated":"2017-03-23 17:49:11.000000000","message":"this is env variable may be used in env","commit_id":"289970fe6b0769852af6e4242da19dc507e43237"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"219452d5031e787d329f7a6391a07b0eca2dc7ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[local|localrc]]"},{"line_number":2,"context_line":"# This will fetch the latest ODL snapshot"},{"line_number":3,"context_line":"ODL_RELEASE\u003dlatest-snapshot"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Default is V2 driver, uncomment below line to use V1"},{"line_number":6,"context_line":"#ODL_V2DRIVER\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ffe62b97_9d3594fa","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":27},"updated":"2017-03-24 03:36:16.000000000","message":"I think by default latest version taken, we don\u0027t have to provide it here.","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"07bd2beb63d0e35aa660e12eef5562d747a2f1ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[local|localrc]]"},{"line_number":2,"context_line":"# This will fetch the latest ODL snapshot"},{"line_number":3,"context_line":"ODL_RELEASE\u003dlatest-snapshot"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Default is V2 driver, uncomment below line to use V1"},{"line_number":6,"context_line":"#ODL_V2DRIVER\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ffe62b97_7b03dc43","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":27},"in_reply_to":"ffe62b97_9d3594fa","updated":"2017-03-30 21:53:24.000000000","message":"having it does not hurt either, developers can use others as well.","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"219452d5031e787d329f7a6391a07b0eca2dc7ab","unresolved":false,"context_lines":[{"line_number":84,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d172.24.5.1"},{"line_number":85,"context_line":"FIXED_NETWORK_SIZE\u003d4096"},{"line_number":86,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":87,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":88,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":89,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":90,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":91,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ffe62b97_585b9a2d","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":23},"updated":"2017-03-24 03:36:16.000000000","message":"Can you please describe, what is the impact of this parameter? Which service uses it? If possible some reference of bug or how it helps.","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"07bd2beb63d0e35aa660e12eef5562d747a2f1ed","unresolved":false,"context_lines":[{"line_number":84,"context_line":"PUBLIC_NETWORK_GATEWAY\u003d172.24.5.1"},{"line_number":85,"context_line":"FIXED_NETWORK_SIZE\u003d4096"},{"line_number":86,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":87,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":88,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":89,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":90,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":91,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"dfeb2761_bb550720","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":23},"in_reply_to":"ffe62b97_585b9a2d","updated":"2017-03-30 21:53:24.000000000","message":"there is comment on top of it, I think it is used in gating jobs not needed here","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"219452d5031e787d329f7a6391a07b0eca2dc7ab","unresolved":false,"context_lines":[{"line_number":86,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":87,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":88,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":89,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":90,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":91,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":92,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ffe62b97_58139a0e","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":23},"updated":"2017-03-24 03:36:16.000000000","message":"I checked official document, they assign it\u0027s value 1 not true. here is the doc https://docs.openstack.org/newton/install-guide-debconf/keystone-install.html. I think, it\u0027s meaning. However at some of the location it is set to true, so let\u0027s stick to official guide and use it accordingly.","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"07bd2beb63d0e35aa660e12eef5562d747a2f1ed","unresolved":false,"context_lines":[{"line_number":86,"context_line":"VIRT_DRIVER\u003dlibvirt"},{"line_number":87,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":88,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":89,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":90,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":91,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":92,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"dfeb2761_9b30030a","line":89,"range":{"start_line":89,"start_character":0,"end_line":89,"end_character":23},"in_reply_to":"ffe62b97_58139a0e","updated":"2017-03-30 21:53:24.000000000","message":"Done","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"219452d5031e787d329f7a6391a07b0eca2dc7ab","unresolved":false,"context_lines":[{"line_number":87,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":88,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":89,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":90,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":91,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# set this until all testing platforms have libvirt \u003e\u003d 1.2.11"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ffe62b97_58eb9aaf","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":15},"updated":"2017-03-24 03:36:16.000000000","message":"Remove it if not required.","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"07bd2beb63d0e35aa660e12eef5562d747a2f1ed","unresolved":false,"context_lines":[{"line_number":87,"context_line":"# Don\u0027t reset the requirements.txt files after g-r updates"},{"line_number":88,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":89,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":90,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":91,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# set this until all testing platforms have libvirt \u003e\u003d 1.2.11"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ffe62b97_bbb72487","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":15},"in_reply_to":"ffe62b97_58eb9aaf","updated":"2017-03-30 21:53:24.000000000","message":"i\u0027d keep it, if someone wants to explicitly clone some repos from git which are not cloned by default,","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"219452d5031e787d329f7a6391a07b0eca2dc7ab","unresolved":false,"context_lines":[{"line_number":88,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":89,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":90,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":91,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# set this until all testing platforms have libvirt \u003e\u003d 1.2.11"},{"line_number":94,"context_line":"# see bug #1501558"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ffe62b97_38cb3654","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":27},"updated":"2017-03-24 03:36:16.000000000","message":"Can you please describe, where it will be used and if possibly some reference?","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"07bd2beb63d0e35aa660e12eef5562d747a2f1ed","unresolved":false,"context_lines":[{"line_number":88,"context_line":"UNDO_REQUIREMENTS\u003dFalse"},{"line_number":89,"context_line":"export OS_NO_CACHE\u003dTrue"},{"line_number":90,"context_line":"#LIBS_FROM_GIT\u003d"},{"line_number":91,"context_line":"DATABASE_QUERY_LOGGING\u003dTrue"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# set this until all testing platforms have libvirt \u003e\u003d 1.2.11"},{"line_number":94,"context_line":"# see bug #1501558"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"dfeb2761_7b665f54","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":27},"in_reply_to":"ffe62b97_38cb3654","updated":"2017-03-30 21:53:24.000000000","message":"it will enable Mysql query logging and add logs to /var/log based on dsitro, we do lots of db operations so it is always good to log","commit_id":"3498f5ca707131d3a236579a38314ac726c701ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2503ba34a22554248090b7ae105b82444f9b58a5","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Set here which ODL openstack service provider to use"},{"line_number":13,"context_line":"# These are core ODL features"},{"line_number":14,"context_line":"ODL_NETVIRT_KARAF_FEATURE\u003dodl-neutron-service,odl-restconf-all,odl-aaa-authn,odl-dlux-core,odl-mdsal-apidocs"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# odl-netvirt-openstack is used for new netvirt"},{"line_number":17,"context_line":"ODL_NETVIRT_KARAF_FEATURE+\u003dodl-netvirt-openstack"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"bff0334d_8c7a0486","line":14,"range":{"start_line":14,"start_character":104,"end_line":14,"end_character":108},"updated":"2017-04-05 17:49:57.000000000","message":"need to separated by comma, otherwise issues for installation and bringing up odl server","commit_id":"8a78d8e134bc5d1730218275f003c516fda937a7"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"58764ec3a2b8e2366300f33564180590c224eb67","unresolved":false,"context_lines":[{"line_number":97,"context_line":"# see bug #1501558"},{"line_number":98,"context_line":"EBTABLES_RACE_FIX\u003dTrue"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"TEMPEST_HTTP_IMAGE\u003dhttp://git.openstack.org/static/openstack.png"},{"line_number":101,"context_line":"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"bff0334d_292dfc94","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":61},"updated":"2017-04-06 16:13:53.000000000","message":"Is this really needed?\nIf no, can we drop this to keep this minimum?","commit_id":"ddc4aa4130437122c142426270bffbe57cd1d4f0"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2ba3d46f15ca2442c51c619629fe5261349df3f1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"# see bug #1501558"},{"line_number":98,"context_line":"EBTABLES_RACE_FIX\u003dTrue"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"TEMPEST_HTTP_IMAGE\u003dhttp://git.openstack.org/static/openstack.png"},{"line_number":101,"context_line":"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"bff0334d_5f746e35","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":61},"in_reply_to":"bff0334d_292dfc94","updated":"2017-04-06 17:17:09.000000000","message":"Done","commit_id":"ddc4aa4130437122c142426270bffbe57cd1d4f0"}]}
