)]}'
{"devstack/functions":[{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"bd962aa2a6ad912543df4c0fbdcb09875169fea6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if [ \"$os_VENDOR\" \u003d \"Fedora\" ]; then"},{"line_number":36,"context_line":"            result\u003d`xpath -e \"$XPATH\" $MAVENMETAFILE 2\u003e/dev/null`"},{"line_number":37,"context_line":"        else"},{"line_number":38,"context_line":"            # RHEL and CentOS"},{"line_number":39,"context_line":"            result\u003d`xpath $MAVENMETAFILE \"$XPATH\" 2\u003e/dev/null`"},{"line_number":40,"context_line":"        fi"},{"line_number":41,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a1ff146_01afd694","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":29},"updated":"2017-03-16 04:22:43.000000000","message":"There are other variations as well https://github.com/openstack-dev/devstack/blob/master/functions-common#L443.","commit_id":"7b142aee27249f5aff7a6724d72d893907bfd287"},{"author":{"_account_id":20638,"name":"Frederick F. Kautz IV","email":"fkautz@redhat.com","username":"fkautz"},"change_message_id":"05658b91013f851cba86d8f267243118717e1e16","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        if [ \"$os_VENDOR\" \u003d \"Fedora\" ]; then"},{"line_number":36,"context_line":"            result\u003d`xpath -e \"$XPATH\" $MAVENMETAFILE 2\u003e/dev/null`"},{"line_number":37,"context_line":"        else"},{"line_number":38,"context_line":"            # RHEL and CentOS"},{"line_number":39,"context_line":"            result\u003d`xpath $MAVENMETAFILE \"$XPATH\" 2\u003e/dev/null`"},{"line_number":40,"context_line":"        fi"},{"line_number":41,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a1ced50_3b735db3","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":29},"in_reply_to":"3a1ff146_01afd694","updated":"2017-03-17 01:57:35.000000000","message":"I\u0027ve removed the comment.","commit_id":"7b142aee27249f5aff7a6724d72d893907bfd287"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"30c383d81c25391fdafbc239090076a4c32746b5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            result\u003d`xpath -e \"$XPATH\" $MAVENMETAFILE 2\u003e/dev/null`"},{"line_number":37,"context_line":"        else"},{"line_number":38,"context_line":"            # RHEL and CentOS"},{"line_number":39,"context_line":"            result\u003d`xpath $MAVENMETAFILE \"$XPATH\" 2\u003e/dev/null`"},{"line_number":40,"context_line":"        fi"},{"line_number":41,"context_line":"    else"},{"line_number":42,"context_line":"        yum_install perl-XML-XPath \u003e/dev/null"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a1ff146_0200bb00","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":62},"updated":"2017-03-16 00:28:06.000000000","message":"This is as same as line 43.\nSo can you please delete line 41-43?","commit_id":"7b142aee27249f5aff7a6724d72d893907bfd287"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"bd962aa2a6ad912543df4c0fbdcb09875169fea6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            result\u003d`xpath -e \"$XPATH\" $MAVENMETAFILE 2\u003e/dev/null`"},{"line_number":37,"context_line":"        else"},{"line_number":38,"context_line":"            # RHEL and CentOS"},{"line_number":39,"context_line":"            result\u003d`xpath $MAVENMETAFILE \"$XPATH\" 2\u003e/dev/null`"},{"line_number":40,"context_line":"        fi"},{"line_number":41,"context_line":"    else"},{"line_number":42,"context_line":"        yum_install perl-XML-XPath \u003e/dev/null"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a1ff146_21a4d2a4","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":62},"in_reply_to":"3a1ff146_0200bb00","updated":"2017-03-16 04:22:43.000000000","message":"Are not these changes intended for other type of OS, For example https://github.com/openstack-dev/devstack/blob/master/functions-common#L453. If we delete else part it will not be executed for them. If they are intended for them as well then i think we can do it following way\n\n  if is_ubuntu; then\n        install_package libxml-xpath-perl \u003e/dev/null\n        result\u003d`xpath -e \"$XPATH\" $MAVENMETAFILE 2\u003e/dev/null`\n  elif [ \"$os_VENDOR\" \u003d \"Fedora\" ]; then\n# It should handle only fedora, i suppose.\n        yum_install perl-XML-XPath \u003e/dev/null        \n        result\u003d`xpath -e \"$XPATH\" $MAVENMETAFILE 2\u003e/dev/null`\n        /null`\n  else\n# this else will handle rest of them.\n        yum_install perl-XML-XPath \u003e/dev/null\n        result\u003d`xpath $MAVENMETAFILE \"$XPATH\" 2\u003e/dev/null`\n  fi","commit_id":"7b142aee27249f5aff7a6724d72d893907bfd287"},{"author":{"_account_id":20638,"name":"Frederick F. Kautz IV","email":"fkautz@redhat.com","username":"fkautz"},"change_message_id":"05658b91013f851cba86d8f267243118717e1e16","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            result\u003d`xpath -e \"$XPATH\" $MAVENMETAFILE 2\u003e/dev/null`"},{"line_number":37,"context_line":"        else"},{"line_number":38,"context_line":"            # RHEL and CentOS"},{"line_number":39,"context_line":"            result\u003d`xpath $MAVENMETAFILE \"$XPATH\" 2\u003e/dev/null`"},{"line_number":40,"context_line":"        fi"},{"line_number":41,"context_line":"    else"},{"line_number":42,"context_line":"        yum_install perl-XML-XPath \u003e/dev/null"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a1ced50_db9a49c5","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":62},"in_reply_to":"3a1ff146_21a4d2a4","updated":"2017-03-17 01:57:35.000000000","message":"Done. I\u0027ve reverted back to the original and the modified is_fedora to [ \"$os_VENDOR\" \u003d \"Fedora\" ].","commit_id":"7b142aee27249f5aff7a6724d72d893907bfd287"}]}