)]}'
{"devstack/README.rst":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"49b77a81f8e36614c22c320a37c00cff173603e2","unresolved":false,"context_lines":[{"line_number":191,"context_line":"      [[local|localrc]]"},{"line_number":192,"context_line":"      ODL_DHCP_SERVICE\u003dTrue"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"18. To enable ODL with OVS hardware Offload support"},{"line_number":195,"context_line":"    please use::"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"      [[local|localrc]]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f287b81_985fdae4","line":194,"range":{"start_line":194,"start_character":4,"end_line":194,"end_character":51},"updated":"2017-08-22 14:05:53.000000000","message":"Please mention about the version requirements.\nkernel, ovs, odl.","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"c86b6e606b6100322aecde2e6b66f2629d4d65cd","unresolved":false,"context_lines":[{"line_number":191,"context_line":"      [[local|localrc]]"},{"line_number":192,"context_line":"      ODL_DHCP_SERVICE\u003dTrue"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"18. To enable ODL with OVS hardware Offload support"},{"line_number":195,"context_line":"    please use::"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"      [[local|localrc]]"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f287b81_957d4a1e","line":194,"range":{"start_line":194,"start_character":4,"end_line":194,"end_character":51},"in_reply_to":"7f287b81_985fdae4","updated":"2017-08-23 11:58:47.000000000","message":"Done","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"}],"doc/source/contributor/hostconfig.rst":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"49b77a81f8e36614c22c320a37c00cff173603e2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"OVS SR-IOV Hardware Offload configuration example::"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"   {“supported_vnic_types”: [{"},{"line_number":75,"context_line":"            “vnic_type”: “normal”,"},{"line_number":76,"context_line":"            “vif_type”: “ovs”,"},{"line_number":77,"context_line":"            “vif_details”: “{}”,"},{"line_number":78,"context_line":"            “vnic_type”: “direct”,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f287b81_b869768c","line":75,"range":{"start_line":75,"start_character":13,"end_line":75,"end_character":34},"updated":"2017-08-22 14:05:53.000000000","message":"there are two vnic_type.\ncopy-and-paste bug.","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"c86b6e606b6100322aecde2e6b66f2629d4d65cd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"OVS SR-IOV Hardware Offload configuration example::"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"   {“supported_vnic_types”: [{"},{"line_number":75,"context_line":"            “vnic_type”: “normal”,"},{"line_number":76,"context_line":"            “vif_type”: “ovs”,"},{"line_number":77,"context_line":"            “vif_details”: “{}”,"},{"line_number":78,"context_line":"            “vnic_type”: “direct”,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f287b81_5577e23b","line":75,"range":{"start_line":75,"start_character":13,"end_line":75,"end_character":34},"in_reply_to":"7f287b81_b869768c","updated":"2017-08-23 11:58:47.000000000","message":"Done","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"49b77a81f8e36614c22c320a37c00cff173603e2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            “vif_type”: “ovs”,"},{"line_number":77,"context_line":"            “vif_details”: “{}”,"},{"line_number":78,"context_line":"            “vnic_type”: “direct”,"},{"line_number":79,"context_line":"            “vif_type”: “ovs”,"},{"line_number":80,"context_line":"            “vif_details”: “{}”"},{"line_number":81,"context_line":"        }]"},{"line_number":82,"context_line":"        “allowed_network_types”: [\"local\", \"gre\", \"vlan\", \"vxlan\"]”,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f287b81_98047ac8","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":30},"updated":"2017-08-22 14:05:53.000000000","message":"here.","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"c86b6e606b6100322aecde2e6b66f2629d4d65cd","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            “vif_type”: “ovs”,"},{"line_number":77,"context_line":"            “vif_details”: “{}”,"},{"line_number":78,"context_line":"            “vnic_type”: “direct”,"},{"line_number":79,"context_line":"            “vif_type”: “ovs”,"},{"line_number":80,"context_line":"            “vif_details”: “{}”"},{"line_number":81,"context_line":"        }]"},{"line_number":82,"context_line":"        “allowed_network_types”: [\"local\", \"gre\", \"vlan\", \"vxlan\"]”,"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f287b81_35745635","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":30},"in_reply_to":"7f287b81_98047ac8","updated":"2017-08-23 11:58:47.000000000","message":"Done","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"}],"networking_odl/cmd/set_ovs_hostconfigs.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6b50a38eb09e6bf163e4865866348788589e216a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                    \"vif_details\": vif_details,"},{"line_number":293,"context_line":"                    \"vif_type\": vif_type,"},{"line_number":294,"context_line":"                    \"vnic_type\": \"normal\","},{"line_number":295,"context_line":"                },"},{"line_number":296,"context_line":"                {"},{"line_number":297,"context_line":"                    \"vif_details\": vif_details,"},{"line_number":298,"context_line":"                    \"vif_type\": \u0027ovs_acceleration\u0027,"},{"line_number":299,"context_line":"                    \"vnic_type\": \"direct\","},{"line_number":300,"context_line":"                }"},{"line_number":301,"context_line":"            ]"},{"line_number":302,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_b9c86356","line":299,"range":{"start_line":295,"start_character":0,"end_line":299,"end_character":42},"updated":"2017-03-23 04:56:46.000000000","message":"Please don\u0027t enable unconditionally.\nautomatically detect it\u0027s available on this host or add command line option to enable it explicitly.\nPlease refer to dpdk case.","commit_id":"f9535ab84ee5f1c32a40b615b77ea49cd077f13f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d430925b2d5a96b69539a02a8288a79101dab6aa","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            ]"},{"line_number":294,"context_line":"        }"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":"    if vif_type \u003d\u003d \u0027ovs\u0027:"},{"line_number":297,"context_line":"        direct_vnic \u003d {"},{"line_number":298,"context_line":"            \"vif_details\": vif_details,"},{"line_number":299,"context_line":"            \"vif_type\": vif_type,"},{"line_number":300,"context_line":"            \"vnic_type\": \"direct\","},{"line_number":301,"context_line":"        }"},{"line_number":302,"context_line":"        host_config[\"ODL L2\"][\"supported_vnic_types\"].append(direct_vnic)"},{"line_number":303,"context_line":"    return host_config"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_8374f79a","line":302,"range":{"start_line":296,"start_character":0,"end_line":302,"end_character":73},"updated":"2017-08-08 19:44:12.000000000","message":"This needs to be configurable.","commit_id":"86740f89a13eccd3f2cf4b0859b969487d2e3e54"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"487e2ab9272b5354695d3b44a116ee00cb3a0a7e","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            ]"},{"line_number":294,"context_line":"        }"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":"    if vif_type \u003d\u003d \u0027ovs\u0027:"},{"line_number":297,"context_line":"        direct_vnic \u003d {"},{"line_number":298,"context_line":"            \"vif_details\": vif_details,"},{"line_number":299,"context_line":"            \"vif_type\": vif_type,"},{"line_number":300,"context_line":"            \"vnic_type\": \"direct\","},{"line_number":301,"context_line":"        }"},{"line_number":302,"context_line":"        host_config[\"ODL L2\"][\"supported_vnic_types\"].append(direct_vnic)"},{"line_number":303,"context_line":"    return host_config"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_e8edce25","line":302,"range":{"start_line":296,"start_character":0,"end_line":302,"end_character":73},"in_reply_to":"9f436f4f_34da1517","updated":"2017-08-09 08:59:47.000000000","message":"hostconfig declares what capability the host has.\nWe can\u0027t say every node has SR-IOV offloading.\nIt\u0027s quite up to node hardware configuration and it\u0027s what cloud admin determins.","commit_id":"86740f89a13eccd3f2cf4b0859b969487d2e3e54"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"2bf8979b280664b08775473fd5a032ee5eb21f67","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            ]"},{"line_number":294,"context_line":"        }"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":"    if vif_type \u003d\u003d \u0027ovs\u0027:"},{"line_number":297,"context_line":"        direct_vnic \u003d {"},{"line_number":298,"context_line":"            \"vif_details\": vif_details,"},{"line_number":299,"context_line":"            \"vif_type\": vif_type,"},{"line_number":300,"context_line":"            \"vnic_type\": \"direct\","},{"line_number":301,"context_line":"        }"},{"line_number":302,"context_line":"        host_config[\"ODL L2\"][\"supported_vnic_types\"].append(direct_vnic)"},{"line_number":303,"context_line":"    return host_config"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_34da1517","line":302,"range":{"start_line":296,"start_character":0,"end_line":302,"end_character":73},"in_reply_to":"9f436f4f_8374f79a","updated":"2017-08-09 06:37:37.000000000","message":"the ovs hardware offload is not like DPDK which another datapath. In this case the solution is to try to offload if we can otherwise we default to the kernel path.\nSo I am not sure the config option is needed. Also we want that nova will be aware of the capability of the NIC to select the correct host see more details here https://review.openstack.org/#/c/398265/34/releasenotes/notes/sriov-ovs-offload-1c3fe79e847f8c8f.yaml","commit_id":"86740f89a13eccd3f2cf4b0859b969487d2e3e54"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"21a533a6fad39b0ea6017d8a51b7fd8419fec3ef","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            ]"},{"line_number":294,"context_line":"        }"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":"    if vif_type \u003d\u003d \u0027ovs\u0027:"},{"line_number":297,"context_line":"        direct_vnic \u003d {"},{"line_number":298,"context_line":"            \"vif_details\": vif_details,"},{"line_number":299,"context_line":"            \"vif_type\": vif_type,"},{"line_number":300,"context_line":"            \"vnic_type\": \"direct\","},{"line_number":301,"context_line":"        }"},{"line_number":302,"context_line":"        host_config[\"ODL L2\"][\"supported_vnic_types\"].append(direct_vnic)"},{"line_number":303,"context_line":"    return host_config"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_d7973e90","line":302,"range":{"start_line":296,"start_character":0,"end_line":302,"end_character":73},"in_reply_to":"9f436f4f_c021beb6","updated":"2017-08-09 14:57:49.000000000","message":"Yes.\nAgain hostconfig describes the capability of the host.","commit_id":"86740f89a13eccd3f2cf4b0859b969487d2e3e54"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"235aa8302af724cf4b735ccb439b175e9d31ef29","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            ]"},{"line_number":294,"context_line":"        }"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":"    if vif_type \u003d\u003d \u0027ovs\u0027:"},{"line_number":297,"context_line":"        direct_vnic \u003d {"},{"line_number":298,"context_line":"            \"vif_details\": vif_details,"},{"line_number":299,"context_line":"            \"vif_type\": vif_type,"},{"line_number":300,"context_line":"            \"vnic_type\": \"direct\","},{"line_number":301,"context_line":"        }"},{"line_number":302,"context_line":"        host_config[\"ODL L2\"][\"supported_vnic_types\"].append(direct_vnic)"},{"line_number":303,"context_line":"    return host_config"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_52d35c39","line":302,"range":{"start_line":296,"start_character":0,"end_line":302,"end_character":73},"in_reply_to":"9f436f4f_d7973e90","updated":"2017-08-09 15:34:30.000000000","message":"Ok","commit_id":"86740f89a13eccd3f2cf4b0859b969487d2e3e54"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"3b709d148448cb3248470dc9617b9deca1965841","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            ]"},{"line_number":294,"context_line":"        }"},{"line_number":295,"context_line":"    }"},{"line_number":296,"context_line":"    if vif_type \u003d\u003d \u0027ovs\u0027:"},{"line_number":297,"context_line":"        direct_vnic \u003d {"},{"line_number":298,"context_line":"            \"vif_details\": vif_details,"},{"line_number":299,"context_line":"            \"vif_type\": vif_type,"},{"line_number":300,"context_line":"            \"vnic_type\": \"direct\","},{"line_number":301,"context_line":"        }"},{"line_number":302,"context_line":"        host_config[\"ODL L2\"][\"supported_vnic_types\"].append(direct_vnic)"},{"line_number":303,"context_line":"    return host_config"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_c021beb6","line":302,"range":{"start_line":296,"start_character":0,"end_line":302,"end_character":73},"in_reply_to":"9f436f4f_e8edce25","updated":"2017-08-09 12:31:33.000000000","message":"usually nova-compute should tell it to the nova-scheduler. This look like a hack for DPDK. is not it?\nlet assume the nova-compute can do that and the nova-scheduler will select compute node with SR-IOV offloading. Do we still need a config option?","commit_id":"86740f89a13eccd3f2cf4b0859b969487d2e3e54"}],"networking_odl/ml2/pseudo_agentdb_binding.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"6b50a38eb09e6bf163e4865866348788589e216a","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                LOG.debug(\"Binding vnic:\u0027%s\u0027 to vif:\u0027%s\u0027\", vnic_type, vif_type)"},{"line_number":256,"context_line":"                break"},{"line_number":257,"context_line":"        else:"},{"line_number":258,"context_line":"            vif_type \u003d portbindings.VIF_TYPE_OVS  # default: OVS"},{"line_number":259,"context_line":"            LOG.warning(_LW(\"No supported vif type found for host %s!, \""},{"line_number":260,"context_line":"                            \"defaulting to OVS\"), port_context.host)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        vif_details \u003d conf.get(\u0027vif_details\u0027, {})"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_b9f6a38c","line":260,"range":{"start_line":258,"start_character":0,"end_line":260,"end_character":68},"updated":"2017-03-23 04:56:46.000000000","message":"In the case of VNIC_DIRECT, error should be raised.","commit_id":"f9535ab84ee5f1c32a40b615b77ea49cd077f13f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cfaf9675b13182a9e5a4be35fd629f8a614d3055","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        # in this case ODL hostconfigs has the vif_type to bind for vnic_type"},{"line_number":288,"context_line":"        vnic_type \u003d port_context.current.get(portbindings.VNIC_TYPE)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        if (vnic_type !\u003d portbindings.VNIC_NORMAL or"},{"line_number":291,"context_line":"                vnic_type !\u003d portbindings.VNIC_DIRECT):"},{"line_number":292,"context_line":"            LOG.error(\"Binding failed: unsupported VNIC %s\", vnic_type)"},{"line_number":293,"context_line":"            return False"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_3f460bc2","line":291,"range":{"start_line":290,"start_character":12,"end_line":291,"end_character":53},"updated":"2017-05-22 14:47:11.000000000","message":"it might be nicer to simply say \nif vnic_type not in (portbindings.VNIC_NORMAL,\n                     portbindings.VNIC_DIRECT):","commit_id":"97f87e54be8deb3c6073b3cda583f541d76c5df4"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"3077883f5f56c48e32be3d65d5ab86e8f63f3a1c","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        # in this case ODL hostconfigs has the vif_type to bind for vnic_type"},{"line_number":288,"context_line":"        vnic_type \u003d port_context.current.get(portbindings.VNIC_TYPE)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        if (vnic_type !\u003d portbindings.VNIC_NORMAL or"},{"line_number":291,"context_line":"                vnic_type !\u003d portbindings.VNIC_DIRECT):"},{"line_number":292,"context_line":"            LOG.error(\"Binding failed: unsupported VNIC %s\", vnic_type)"},{"line_number":293,"context_line":"            return False"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_624f356b","line":291,"range":{"start_line":290,"start_character":12,"end_line":291,"end_character":53},"in_reply_to":"ff0f0b1f_3f460bc2","updated":"2017-05-23 00:07:38.000000000","message":"The logic was wrong it should have been and :)\nanyway I change it to your way","commit_id":"97f87e54be8deb3c6073b3cda583f541d76c5df4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3d5e5ec3831aee921596a4da160023eaba81bce","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        # in this case ODL hostconfigs has the vif_type to bind for vnic_type"},{"line_number":288,"context_line":"        vnic_type \u003d port_context.current.get(portbindings.VNIC_TYPE)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        if (vnic_type !\u003d portbindings.VNIC_NORMAL or"},{"line_number":291,"context_line":"                vnic_type !\u003d portbindings.VNIC_DIRECT):"},{"line_number":292,"context_line":"            LOG.error(\"Binding failed: unsupported VNIC %s\", vnic_type)"},{"line_number":293,"context_line":"            return False"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_2db5a27e","line":291,"range":{"start_line":290,"start_character":12,"end_line":291,"end_character":53},"in_reply_to":"ff0f0b1f_624f356b","updated":"2017-05-23 11:12:48.000000000","message":"oh ya your right it should have been and.\nthe reason i suggest testing as a list is it will proably be extended in the future and adding another element to a list is cleaner then additional conjunctions.","commit_id":"97f87e54be8deb3c6073b3cda583f541d76c5df4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"49b77a81f8e36614c22c320a37c00cff173603e2","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        # in this case ODL hostconfigs has the vif_type to bind for vnic_type"},{"line_number":355,"context_line":"        vnic_type \u003d port_context.current.get(portbindings.VNIC_TYPE)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        if (vnic_type not in supported_vnic_types):"},{"line_number":358,"context_line":"            LOG.error(\"Binding failed: unsupported VNIC %s\", vnic_type)"},{"line_number":359,"context_line":"            return False"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        vif_details \u003d None"},{"line_number":362,"context_line":"        for conf in confs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_f81dbe0f","line":359,"range":{"start_line":357,"start_character":0,"end_line":359,"end_character":24},"updated":"2017-08-22 14:05:53.000000000","message":"Please see consolidate this check with line 369-371.","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"c86b6e606b6100322aecde2e6b66f2629d4d65cd","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        # in this case ODL hostconfigs has the vif_type to bind for vnic_type"},{"line_number":355,"context_line":"        vnic_type \u003d port_context.current.get(portbindings.VNIC_TYPE)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        if (vnic_type not in supported_vnic_types):"},{"line_number":358,"context_line":"            LOG.error(\"Binding failed: unsupported VNIC %s\", vnic_type)"},{"line_number":359,"context_line":"            return False"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        vif_details \u003d None"},{"line_number":362,"context_line":"        for conf in confs:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_158f1a24","line":359,"range":{"start_line":357,"start_character":0,"end_line":359,"end_character":24},"in_reply_to":"7f287b81_f81dbe0f","updated":"2017-08-23 11:58:47.000000000","message":"Done","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"49b77a81f8e36614c22c320a37c00cff173603e2","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                vif_details \u003d conf.get(\u0027vif_details\u0027, {})"},{"line_number":367,"context_line":"                break"},{"line_number":368,"context_line":"        else:"},{"line_number":369,"context_line":"            vif_type \u003d portbindings.VIF_TYPE_OVS  # default: OVS"},{"line_number":370,"context_line":"            LOG.warning(\"No supported vif type found for host %s!, \""},{"line_number":371,"context_line":"                        \"defaulting to OVS\", port_context.host)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        if not vif_details:  # empty vif_details could be trouble, warn."},{"line_number":374,"context_line":"            LOG.warning(\"hostconfig:vif_details was empty!\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_58e612eb","line":371,"range":{"start_line":369,"start_character":0,"end_line":371,"end_character":63},"updated":"2017-08-22 14:05:53.000000000","message":"there is no matching entry.\nwe should return False and log it.","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"},{"author":{"_account_id":21683,"name":"edan david","email":"edand@mellanox.com","username":"edand"},"change_message_id":"c86b6e606b6100322aecde2e6b66f2629d4d65cd","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                vif_details \u003d conf.get(\u0027vif_details\u0027, {})"},{"line_number":367,"context_line":"                break"},{"line_number":368,"context_line":"        else:"},{"line_number":369,"context_line":"            vif_type \u003d portbindings.VIF_TYPE_OVS  # default: OVS"},{"line_number":370,"context_line":"            LOG.warning(\"No supported vif type found for host %s!, \""},{"line_number":371,"context_line":"                        \"defaulting to OVS\", port_context.host)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        if not vif_details:  # empty vif_details could be trouble, warn."},{"line_number":374,"context_line":"            LOG.warning(\"hostconfig:vif_details was empty!\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_f5936e4e","line":371,"range":{"start_line":369,"start_character":0,"end_line":371,"end_character":63},"in_reply_to":"7f287b81_58e612eb","updated":"2017-08-23 11:58:47.000000000","message":"Done","commit_id":"637a0ac663a25a0c406e2304beca2925d72c05f9"}]}
