)]}'
{"networking_odl/journal/dependency_validations.py":[{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"3ab5e1dfd3cfaaaaca4549f0af6675dfbdf6d6b5","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    odl_const.ODL_NETWORK: _generate_network_deps,"},{"line_number":187,"context_line":"    odl_const.ODL_SUBNET: _generate_subnet_deps,"},{"line_number":188,"context_line":"    odl_const.ODL_PORT: _generate_port_deps,"},{"line_number":189,"context_line":"    # TODO(yamahata): dependency between SG and PORT"},{"line_number":190,"context_line":"    odl_const.ODL_SG_RULE: _generate_sg_rule_deps,"},{"line_number":191,"context_line":"    odl_const.ODL_ROUTER: _generate_router_deps,"},{"line_number":192,"context_line":"    odl_const.ODL_FLOATINGIP: _generate_floatingip_deps,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_4f9fe25e","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":52},"updated":"2017-04-04 09:26:14.000000000","message":"I would like a recursive approach to find chain of dependencies, We can not go on looking for dependencies and adding on special cases for each of them.\n\nDo you think, we should take such an approach? if yes, i would like to submit a patch for it.","commit_id":"6b812d49d0b95183c74ecc088380570c25f807de"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"23a497baed043ae0beae904ef516665b5b331fea","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    return data.get(\u0027qos_policy_id\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _generate_sg_rule_deps(row):"},{"line_number":100,"context_line":"    return row.data[\u0027security_group_id\u0027]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_b634b5fc","line":99,"range":{"start_line":99,"start_character":27,"end_line":99,"end_character":32},"updated":"2017-04-18 07:15:44.000000000","message":"use data here instead of row, just to be consistent with other functions.","commit_id":"eb11cd69fcb70c129e4e1676385b02ee515927ae"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"23a497baed043ae0beae904ef516665b5b331fea","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _generate_sg_rule_deps(row):"},{"line_number":100,"context_line":"    return row.data[\u0027security_group_id\u0027]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def _generate_router_deps(data):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_d67621a5","line":100,"updated":"2017-04-18 07:15:44.000000000","message":"Now data is being passed not row. Check _generate_network_deps function.","commit_id":"eb11cd69fcb70c129e4e1676385b02ee515927ae"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0ee5446c364a1ce92c9246395373f14aa2708942","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                           odl_const.ODL_BGPVPN),"},{"line_number":210,"context_line":"    odl_const.ODL_PORT: (odl_const.ODL_TRUNK,),"},{"line_number":211,"context_line":"    # TODO(yamahata): dependency between SG and PORT"},{"line_number":212,"context_line":"    odl_const.ODL_SG: (odl_const.ODL_SG_RULE,),"},{"line_number":213,"context_line":"    odl_const.ODL_L2GATEWAY: (odl_const.ODL_L2GATEWAY_CONNECTION,),"},{"line_number":214,"context_line":"    odl_const.ODL_SFC_FLOW_CLASSIFIER: (odl_const.ODL_SFC_PORT_CHAIN,),"},{"line_number":215,"context_line":"    odl_const.ODL_SFC_PORT_PAIR: (odl_const.ODL_SFC_PORT_PAIR_GROUP,),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_33918848","line":212,"range":{"start_line":212,"start_character":4,"end_line":212,"end_character":47},"updated":"2017-05-10 23:01:13.000000000","message":"when we delete sg, sgrules are auto deleted, why is this even needed ? when we delete SG what will be parent here ?? \n\nhttps://github.com/openstack/networking-odl/blob/master/networking_odl/journal/dependency_validations.py#L54 I guess reverse order make more sense .","commit_id":"31a926d85b54bd3aadc23b126a66e94b25bafc58"}],"networking_odl/ml2/mech_driver_v2.py":[{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"0e422cfe3a0625215657d60f784590a54eab32e5","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            # sg deletion has dependency on sgrule"},{"line_number":225,"context_line":"            core_plugin \u003d directory.get_plugin()"},{"line_number":226,"context_line":"            sgrule \u003d core_plugin._get_security_group_rule(context, res_id)"},{"line_number":227,"context_line":"            resource_dict \u003d [sgrule.security_gruop_id]"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        object_uuid \u003d (resource_dict.get(\u0027id\u0027)"},{"line_number":230,"context_line":"                       if operation \u003d\u003d \u0027create\u0027 else res_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_27a7d5bf","line":227,"range":{"start_line":227,"start_character":37,"end_line":227,"end_character":53},"updated":"2017-03-29 07:55:37.000000000","message":"I think, spelling mistake.","commit_id":"9c2b14a39b16c56b94697cc9c1458068141b8b07"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c43440a03d7e6b2ba286c1ba8c1980ff420c136b","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            # sg deletion has dependency on sgrule"},{"line_number":225,"context_line":"            core_plugin \u003d directory.get_plugin()"},{"line_number":226,"context_line":"            sgrule \u003d core_plugin._get_security_group_rule(context, res_id)"},{"line_number":227,"context_line":"            resource_dict \u003d [sgrule.security_gruop_id]"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        object_uuid \u003d (resource_dict.get(\u0027id\u0027)"},{"line_number":230,"context_line":"                       if operation \u003d\u003d \u0027create\u0027 else res_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_34c5818f","line":227,"range":{"start_line":227,"start_character":37,"end_line":227,"end_character":53},"in_reply_to":"ffe62b97_27a7d5bf","updated":"2017-03-31 01:08:06.000000000","message":"Done","commit_id":"9c2b14a39b16c56b94697cc9c1458068141b8b07"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"3ab5e1dfd3cfaaaaca4549f0af6675dfbdf6d6b5","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            # sg deletion has dependency on sgrule"},{"line_number":225,"context_line":"            core_plugin \u003d directory.get_plugin()"},{"line_number":226,"context_line":"            sgrule \u003d core_plugin._get_security_group_rule(context, res_id)"},{"line_number":227,"context_line":"            resource_dict \u003d [sgrule.security_group_id]"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        object_uuid \u003d (resource_dict.get(\u0027id\u0027)"},{"line_number":230,"context_line":"                       if operation \u003d\u003d \u0027create\u0027 else res_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_fdd55544","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":54},"updated":"2017-04-04 09:26:14.000000000","message":"isn\u0027t it dictionary, because in L229 you will be accessing information using \u0027id\u0027? I did not go much deeper but i think, test cases should have identified it may be test case for this branch should exist.","commit_id":"6b812d49d0b95183c74ecc088380570c25f807de"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"84b85bab99eb85e4717403b2ffb1a1d71577656e","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            resource_dict \u003d tmp_dict"},{"line_number":234,"context_line":"        elif (object_type \u003d\u003d odl_const.ODL_SG_RULE and"},{"line_number":235,"context_line":"              operation \u003d\u003d odl_const.ODL_DELETE):"},{"line_number":236,"context_line":"            # NOTE(yamahata): bug work around"},{"line_number":237,"context_line":"            # precommit_delete doesn\u0027t pass its data."},{"line_number":238,"context_line":"            # sg deletion has dependency on sgrule"},{"line_number":239,"context_line":"            core_plugin \u003d directory.get_plugin()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_d231545c","line":236,"range":{"start_line":236,"start_character":30,"end_line":236,"end_character":33},"updated":"2017-05-10 05:24:32.000000000","message":"do you have a bug reference?","commit_id":"4706efa77eb5107258e8b718d39383f4c3aad568"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e8b0b6852fa44b660e0e5f15d199808642b724ca","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            resource_dict \u003d tmp_dict"},{"line_number":234,"context_line":"        elif (object_type \u003d\u003d odl_const.ODL_SG_RULE and"},{"line_number":235,"context_line":"              operation \u003d\u003d odl_const.ODL_DELETE):"},{"line_number":236,"context_line":"            # NOTE(yamahata): bug work around"},{"line_number":237,"context_line":"            # precommit_delete doesn\u0027t pass its data."},{"line_number":238,"context_line":"            # sg deletion has dependency on sgrule"},{"line_number":239,"context_line":"            core_plugin \u003d directory.get_plugin()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_1e1b3bd0","line":236,"range":{"start_line":236,"start_character":30,"end_line":236,"end_character":33},"in_reply_to":"3f044301_d231545c","updated":"2017-05-10 16:02:56.000000000","message":"it is not actually a bug it is the way precommit_delete is it just does not pass the data along with call. i\u0027ll rephrase it","commit_id":"4706efa77eb5107258e8b718d39383f4c3aad568"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"84b85bab99eb85e4717403b2ffb1a1d71577656e","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            # sg deletion has dependency on sgrule"},{"line_number":239,"context_line":"            core_plugin \u003d directory.get_plugin()"},{"line_number":240,"context_line":"            sgrule \u003d core_plugin._get_security_group_rule(context, res_id)"},{"line_number":241,"context_line":"            resource_dict \u003d [sgrule.security_group_id]"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        object_uuid \u003d (resource_dict.get(\u0027id\u0027)"},{"line_number":244,"context_line":"                       if operation \u003d\u003d \u0027create\u0027 else res_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_52266417","line":241,"range":{"start_line":241,"start_character":12,"end_line":241,"end_character":25},"updated":"2017-05-10 05:24:32.000000000","message":"this is supposed to be a dict-like, isn\u0027t it?","commit_id":"4706efa77eb5107258e8b718d39383f4c3aad568"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e8b0b6852fa44b660e0e5f15d199808642b724ca","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            # sg deletion has dependency on sgrule"},{"line_number":239,"context_line":"            core_plugin \u003d directory.get_plugin()"},{"line_number":240,"context_line":"            sgrule \u003d core_plugin._get_security_group_rule(context, res_id)"},{"line_number":241,"context_line":"            resource_dict \u003d [sgrule.security_group_id]"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        object_uuid \u003d (resource_dict.get(\u0027id\u0027)"},{"line_number":244,"context_line":"                       if operation \u003d\u003d \u0027create\u0027 else res_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_be29e7e6","line":241,"range":{"start_line":241,"start_character":12,"end_line":241,"end_character":25},"in_reply_to":"3f044301_52266417","updated":"2017-05-10 16:02:56.000000000","message":"Done","commit_id":"4706efa77eb5107258e8b718d39383f4c3aad568"}]}
