)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"88e4d6bb98e503e7b149db0d43d96d34aee09ffb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the broken unit test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"One of test for testing sqllite backend is broken,"},{"line_number":10,"context_line":"because the query is being filtered on datetime type"},{"line_number":11,"context_line":"of field which may be handled differently on the backend,"},{"line_number":12,"context_line":"this patch will replace the filter with primary key field"},{"line_number":13,"context_line":"and then check the timestamp of created resource"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ic95bfd4068a8b4654a90bc046444517f739ef019"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfeb2761_a1469520","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":48},"updated":"2017-04-03 19:44:41.000000000","message":"Could you split this sentence? It\u0027s very long and hard to follow.","commit_id":"2bbdc5545cae3f1c9e752458531a68078f7428a6"}],"networking_odl/tests/unit/db/test_sqlite.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"88e4d6bb98e503e7b149db0d43d96d34aee09ffb","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_equal_created_at(self):"},{"line_number":41,"context_line":"        row \u003d self._create_row()"},{"line_number":42,"context_line":"        # NOTE(manjeets) as seqnum is primary so there would be"},{"line_number":43,"context_line":"        # exactly one row created. since filter by created_at may"},{"line_number":44,"context_line":"        # not work because how datetime type handle by backend."},{"line_number":45,"context_line":"        query \u003d self.db_session.query(models.OpendaylightJournal)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_618d2d7a","line":42,"range":{"start_line":42,"start_character":38,"end_line":42,"end_character":45},"updated":"2017-04-03 19:44:41.000000000","message":"Do you mean \u0027primary key\u0027?","commit_id":"2bbdc5545cae3f1c9e752458531a68078f7428a6"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"88e4d6bb98e503e7b149db0d43d96d34aee09ffb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def test_equal_created_at(self):"},{"line_number":41,"context_line":"        row \u003d self._create_row()"},{"line_number":42,"context_line":"        # NOTE(manjeets) as seqnum is primary so there would be"},{"line_number":43,"context_line":"        # exactly one row created. since filter by created_at may"},{"line_number":44,"context_line":"        # not work because how datetime type handle by backend."},{"line_number":45,"context_line":"        query \u003d self.db_session.query(models.OpendaylightJournal)"},{"line_number":46,"context_line":"        got \u003d query.filter_by(seqnum\u003drow.seqnum).first()"},{"line_number":47,"context_line":"        self.assertEqual(row.created_at, got.created_at)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_4138e99e","line":44,"range":{"start_line":43,"start_character":35,"end_line":44,"end_character":63},"updated":"2017-04-03 19:44:41.000000000","message":"I don\u0027t understand what are you trying to describe here. Could you rephrase it a little bit?","commit_id":"2bbdc5545cae3f1c9e752458531a68078f7428a6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8bb5674bf1cee26995fe85b6391aa5e9b60a3a63","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_equal_created_at(self):"},{"line_number":41,"context_line":"        row \u003d self._create_row()"},{"line_number":42,"context_line":"        # NOTE(manjeets) as seqnum is primary so there would be"},{"line_number":43,"context_line":"        # exactly one row created. since filter by created_at may"},{"line_number":44,"context_line":"        # not work because how datetime type handle by backend."},{"line_number":45,"context_line":"        query \u003d self.db_session.query(models.OpendaylightJournal)"},{"line_number":46,"context_line":"        got \u003d query.filter_by(seqnum\u003drow.seqnum).first()"},{"line_number":47,"context_line":"        self.assertEqual(row.created_at, got.created_at)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_de173851","line":44,"range":{"start_line":42,"start_character":0,"end_line":44,"end_character":63},"updated":"2017-04-03 19:32:50.000000000","message":"You can add another test case for this purose.\nIt\u0027s sqlalchemy bug which was already fixed in git repo. new release is on the way.","commit_id":"2bbdc5545cae3f1c9e752458531a68078f7428a6"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"80356de72d222155289161db8b02baed68b5ab50","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # NOTE(manjeets) as seqnum is primary key so there would be"},{"line_number":49,"context_line":"        # exactly one row created."},{"line_number":50,"context_line":"        query \u003d self.db_session.query(models.OpendaylightJournal)"},{"line_number":51,"context_line":"        got \u003d query.filter_by(seqnum\u003drow.seqnum).first()"},{"line_number":52,"context_line":"        self.assertEqual(row, got)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_compare_created_at(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_0c67ad27","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":56},"updated":"2017-04-04 05:03:49.000000000","message":"Your method also seems to be ok. But i think one() http://docs.sqlalchemy.org/en/latest/orm/query.html#sqlalchemy.orm.query.Query.one is made for exactly this kind of query. Can you please consider this as well?","commit_id":"7db9487d4c4eb41829cc645d991190d6b3c1660b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"96a15fb75c101cc1871f73f4bcd69e907843a78a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # NOTE(manjeets) as seqnum is primary key so there would be"},{"line_number":49,"context_line":"        # exactly one row created."},{"line_number":50,"context_line":"        query \u003d self.db_session.query(models.OpendaylightJournal)"},{"line_number":51,"context_line":"        got \u003d query.filter_by(seqnum\u003drow.seqnum).first()"},{"line_number":52,"context_line":"        self.assertEqual(row, got)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_compare_created_at(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_ddda7e49","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":56},"in_reply_to":"dfeb2761_0c67ad27","updated":"2017-04-04 15:22:13.000000000","message":"+1","commit_id":"7db9487d4c4eb41829cc645d991190d6b3c1660b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ef72a88207c12bbeaa0a47d775b668c1ae49ea9f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # NOTE(manjeets) as seqnum is primary key so there would be"},{"line_number":49,"context_line":"        # exactly one row created."},{"line_number":50,"context_line":"        query \u003d self.db_session.query(models.OpendaylightJournal)"},{"line_number":51,"context_line":"        got \u003d query.filter_by(seqnum\u003drow.seqnum).first()"},{"line_number":52,"context_line":"        self.assertEqual(row, got)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_compare_created_at(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_08177453","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":56},"in_reply_to":"dfeb2761_0c67ad27","updated":"2017-04-04 23:24:26.000000000","message":"Done","commit_id":"7db9487d4c4eb41829cc645d991190d6b3c1660b"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"80356de72d222155289161db8b02baed68b5ab50","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # exactly one row created."},{"line_number":50,"context_line":"        query \u003d self.db_session.query(models.OpendaylightJournal)"},{"line_number":51,"context_line":"        got \u003d query.filter_by(seqnum\u003drow.seqnum).first()"},{"line_number":52,"context_line":"        self.assertEqual(row, got)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_compare_created_at(self):"},{"line_number":55,"context_line":"        row \u003d self._create_row()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_9713ca5c","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":34},"updated":"2017-04-04 05:03:49.000000000","message":"I think, here you are checking equality of object. I think, better way is to compare contents of the rows not the complete object.","commit_id":"7db9487d4c4eb41829cc645d991190d6b3c1660b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"96a15fb75c101cc1871f73f4bcd69e907843a78a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # exactly one row created."},{"line_number":50,"context_line":"        query \u003d self.db_session.query(models.OpendaylightJournal)"},{"line_number":51,"context_line":"        got \u003d query.filter_by(seqnum\u003drow.seqnum).first()"},{"line_number":52,"context_line":"        self.assertEqual(row, got)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_compare_created_at(self):"},{"line_number":55,"context_line":"        row \u003d self._create_row()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_bd11fa06","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":34},"in_reply_to":"dfeb2761_9713ca5c","updated":"2017-04-04 15:22:13.000000000","message":"I believe, Manjeet was comparing created_at values in previous patch.","commit_id":"7db9487d4c4eb41829cc645d991190d6b3c1660b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ef72a88207c12bbeaa0a47d775b668c1ae49ea9f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # exactly one row created."},{"line_number":50,"context_line":"        query \u003d self.db_session.query(models.OpendaylightJournal)"},{"line_number":51,"context_line":"        got \u003d query.filter_by(seqnum\u003drow.seqnum).first()"},{"line_number":52,"context_line":"        self.assertEqual(row, got)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_compare_created_at(self):"},{"line_number":55,"context_line":"        row \u003d self._create_row()"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_cb118654","line":52,"range":{"start_line":52,"start_character":0,"end_line":52,"end_character":34},"in_reply_to":"dfeb2761_bd11fa06","updated":"2017-04-04 23:24:26.000000000","message":"i prefer comparing entire object since created_at is used as a filter in different test case. this is a separate test case now.","commit_id":"7db9487d4c4eb41829cc645d991190d6b3c1660b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"8dd81874204905c96719d0454fd94bc3a545c72e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            models.OpendaylightJournal.created_at \u003d\u003d row.created_at).all()"},{"line_number":44,"context_line":"        self.assertEqual(1, len(got))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_get_single_row(self):"},{"line_number":47,"context_line":"        row \u003d self._create_row()"},{"line_number":48,"context_line":"        # NOTE(manjeets) as seqnum is primary key so there would be"},{"line_number":49,"context_line":"        # exactly one row created."}],"source_content_type":"text/x-python","patch_set":3,"id":"bff0334d_d82a03e6","line":46,"updated":"2017-04-05 19:37:52.000000000","message":"Name of test is incorrect. According to commit message, idea is not to get single row, but to get a row, based on PK.","commit_id":"3123d99500941eb7c6b2f601dbb22485bd7b925b"}]}