)]}'
{"networking_odl/tests/unit/bgpvpn/test_odl_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1a98f0c363cd0627a34d7b726a5ca29406fe5cfe","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_create_bgpvpn(self):"},{"line_number":86,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"},{"line_number":87,"context_line":"        self.driver.create_bgpvpn_precommit(self.context, fake_data)"},{"line_number":88,"context_line":"        self._assert_op(odl_const.ODL_CREATE, odl_const.ODL_BGPVPN,"},{"line_number":89,"context_line":"                        fake_data)"},{"line_number":90,"context_line":"        self.thread.run_sync_thread(exit_after_run\u003dTrue)"},{"line_number":91,"context_line":"        self._assert_op(odl_const.ODL_CREATE, odl_const.ODL_BGPVPN,"},{"line_number":92,"context_line":"                        fake_data, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_bf51c6db","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":34},"updated":"2017-04-28 00:32:04.000000000","message":"This case is okay with the modification line 74.","commit_id":"b761d61a6bccf502d1f528d8f38bb0a96edd1394"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1a98f0c363cd0627a34d7b726a5ca29406fe5cfe","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        self.driver.create_bgpvpn_precommit(self.context, fake_data)"},{"line_number":88,"context_line":"        self._assert_op(odl_const.ODL_CREATE, odl_const.ODL_BGPVPN,"},{"line_number":89,"context_line":"                        fake_data)"},{"line_number":90,"context_line":"        self.thread.run_sync_thread(exit_after_run\u003dTrue)"},{"line_number":91,"context_line":"        self._assert_op(odl_const.ODL_CREATE, odl_const.ODL_BGPVPN,"},{"line_number":92,"context_line":"                        fake_data, False)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_update_bgpvpn(self):"},{"line_number":95,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_3f57f6cc","line":92,"range":{"start_line":90,"start_character":0,"end_line":92,"end_character":41},"updated":"2017-04-28 00:32:04.000000000","message":"However in this case, extra flush is executed after run_sync_thread.\nPlease avoid this.","commit_id":"b761d61a6bccf502d1f528d8f38bb0a96edd1394"}],"networking_odl/tests/unit/l2gateway/test_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1a98f0c363cd0627a34d7b726a5ca29406fe5cfe","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return fake_l2_gateway_connection"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _assert_op(self, operation, object_type, data, precommit\u003dTrue):"},{"line_number":87,"context_line":"        self.context.flush()"},{"line_number":88,"context_line":"        row \u003d db.get_oldest_pending_db_row_with_lock(self.db_session)"},{"line_number":89,"context_line":"        if precommit:"},{"line_number":90,"context_line":"            self.assertEqual(operation, row[\u0027operation\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_9f672ab8","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":28},"updated":"2017-04-28 00:32:04.000000000","message":"flush should be called only for precommit case.","commit_id":"b761d61a6bccf502d1f528d8f38bb0a96edd1394"}],"networking_odl/tests/unit/sfc/test_sfc_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1a98f0c363cd0627a34d7b726a5ca29406fe5cfe","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def _test_event(self, operation, timing, resource_str, object_type):"},{"line_number":75,"context_line":"        context \u003d self._get_mock_operation_context(object_type)"},{"line_number":76,"context_line":"        self._call_operation_object(operation, timing, resource_str, context)"},{"line_number":77,"context_line":"        self.db_session.flush()"},{"line_number":78,"context_line":"        row \u003d db.get_oldest_pending_db_row_with_lock(self.db_session)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if timing \u003d\u003d \u0027precommit\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_bfff86a9","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":31},"updated":"2017-04-28 00:32:04.000000000","message":"Please don\u0027t unconditionally flush for both precommit and postcommit.","commit_id":"b761d61a6bccf502d1f528d8f38bb0a96edd1394"}],"networking_odl/tests/unit/trunk/test_trunk_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1a98f0c363cd0627a34d7b726a5ca29406fe5cfe","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _test_event(self, operation, timing):"},{"line_number":81,"context_line":"        self._call_operation_object(operation, timing)"},{"line_number":82,"context_line":"        self.db_session.flush()"},{"line_number":83,"context_line":"        fake_payload \u003d self._fake_trunk_payload()"},{"line_number":84,"context_line":"        row \u003d db.get_oldest_pending_db_row_with_lock(self.db_session)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_7f2fbe3e","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":31},"updated":"2017-04-28 00:32:04.000000000","message":"same here.","commit_id":"b761d61a6bccf502d1f528d8f38bb0a96edd1394"}]}
