)]}'
{"networking_odl/db/db.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":106,"context_line":"def create_pending_row_periodic_task(session, operation, task):"},{"line_number":107,"context_line":"    row \u003d models.OpendaylightMaintenance(state\u003dodl_const.PENDING,"},{"line_number":108,"context_line":"                                         processing_operation\u003doperation,"},{"line_number":109,"context_line":"                                         task\u003dtask,"},{"line_number":110,"context_line":"                                         lock_updated\u003dfunc.now())"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    session.add(row)"},{"line_number":113,"context_line":"    # Keep session flush for unit tests. NOOP for L2/L3 events since calls are"},{"line_number":114,"context_line":"    # made inside database session transaction with subtransactions\u003dTrue."},{"line_number":115,"context_line":"    session.flush()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_395c0d7d","line":115,"range":{"start_line":106,"start_character":0,"end_line":115,"end_character":19},"updated":"2017-05-17 01:57:02.000000000","message":"the row can already exists. such case needs to be handled.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"20150a778b56bd0e5cb1da47e594d61311539641","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":106,"context_line":"def create_pending_row_periodic_task(session, operation, task):"},{"line_number":107,"context_line":"    row \u003d models.OpendaylightMaintenance(state\u003dodl_const.PENDING,"},{"line_number":108,"context_line":"                                         processing_operation\u003doperation,"},{"line_number":109,"context_line":"                                         task\u003dtask,"},{"line_number":110,"context_line":"                                         lock_updated\u003dfunc.now())"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    session.add(row)"},{"line_number":113,"context_line":"    # Keep session flush for unit tests. NOOP for L2/L3 events since calls are"},{"line_number":114,"context_line":"    # made inside database session transaction with subtransactions\u003dTrue."},{"line_number":115,"context_line":"    session.flush()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_7f4dd570","line":115,"range":{"start_line":106,"start_character":0,"end_line":115,"end_character":19},"in_reply_to":"1f013ff3_395c0d7d","updated":"2017-05-18 05:49:21.000000000","message":"It has been taken care of during registration for maintenance. https://review.openstack.org/#/c/459970/6/networking_odl/journal/periodic_task.py, Line 95.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a4ea2b9c0b004514c90e026f3c25d2d50a2d8416","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":106,"context_line":"def create_pending_row_periodic_task(session, operation, task):"},{"line_number":107,"context_line":"    row \u003d models.OpendaylightMaintenance(state\u003dodl_const.PENDING,"},{"line_number":108,"context_line":"                                         processing_operation\u003doperation,"},{"line_number":109,"context_line":"                                         task\u003dtask,"},{"line_number":110,"context_line":"                                         lock_updated\u003dfunc.now())"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    session.add(row)"},{"line_number":113,"context_line":"    # Keep session flush for unit tests. NOOP for L2/L3 events since calls are"},{"line_number":114,"context_line":"    # made inside database session transaction with subtransactions\u003dTrue."},{"line_number":115,"context_line":"    session.flush()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_e2d5dee6","line":115,"range":{"start_line":106,"start_character":0,"end_line":115,"end_character":19},"in_reply_to":"1f013ff3_7f4dd570","updated":"2017-05-19 01:29:01.000000000","message":"So what?\nthe usage is different. don\u0027t blindly copy it.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"aadcaeb305e17f30ec5d0ba79b8c0096d376845b","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":106,"context_line":"def create_pending_row_periodic_task(session, operation, task):"},{"line_number":107,"context_line":"    row \u003d models.OpendaylightMaintenance(state\u003dodl_const.PENDING,"},{"line_number":108,"context_line":"                                         processing_operation\u003doperation,"},{"line_number":109,"context_line":"                                         task\u003dtask,"},{"line_number":110,"context_line":"                                         lock_updated\u003dfunc.now())"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    session.add(row)"},{"line_number":113,"context_line":"    # Keep session flush for unit tests. NOOP for L2/L3 events since calls are"},{"line_number":114,"context_line":"    # made inside database session transaction with subtransactions\u003dTrue."},{"line_number":115,"context_line":"    session.flush()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_021d67bc","line":115,"range":{"start_line":106,"start_character":0,"end_line":115,"end_character":19},"in_reply_to":"ff0f0b1f_e2d5dee6","updated":"2017-05-19 09:46:41.000000000","message":"Done","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d09eb2b2be274b870dcfb07cfde7987b21c62e22","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":107,"context_line":"def create_pending_row_periodic_task(session, task):"},{"line_number":108,"context_line":"    row \u003d models.OpendaylightMaintenance(state\u003dodl_const.PENDING,"},{"line_number":109,"context_line":"                                         processing_operation\u003dNone,"},{"line_number":110,"context_line":"                                         task\u003dtask,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_96617908","line":107,"range":{"start_line":107,"start_character":4,"end_line":107,"end_character":36},"updated":"2017-05-22 20:42:17.000000000","message":"This method name is not correct. please invent another one.\ne.g. create_if_not_exist.","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"3ce89653867cb7ca966cb6aef0a2fd66aff945a9","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":107,"context_line":"def create_pending_row_periodic_task(session, task):"},{"line_number":108,"context_line":"    row \u003d models.OpendaylightMaintenance(state\u003dodl_const.PENDING,"},{"line_number":109,"context_line":"                                         processing_operation\u003dNone,"},{"line_number":110,"context_line":"                                         task\u003dtask,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_c4b04946","line":107,"range":{"start_line":107,"start_character":4,"end_line":107,"end_character":36},"in_reply_to":"ff0f0b1f_96617908","updated":"2017-05-23 08:59:59.000000000","message":"Done","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d09eb2b2be274b870dcfb07cfde7987b21c62e22","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":107,"context_line":"def create_pending_row_periodic_task(session, task):"},{"line_number":108,"context_line":"    row \u003d models.OpendaylightMaintenance(state\u003dodl_const.PENDING,"},{"line_number":109,"context_line":"                                         processing_operation\u003dNone,"},{"line_number":110,"context_line":"                                         task\u003dtask,"},{"line_number":111,"context_line":"                                         lock_updated\u003dfunc.now())"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    session.add(row)"},{"line_number":114,"context_line":"    try:"},{"line_number":115,"context_line":"        session.flush()"},{"line_number":116,"context_line":"    except exception.DBDuplicateEntry:"},{"line_number":117,"context_line":"        pass"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_367bcdbe","line":117,"range":{"start_line":107,"start_character":0,"end_line":117,"end_character":12},"updated":"2017-05-22 20:42:17.000000000","message":"don\u0027t scatter code. please gather methods in meaning.\n\nput this method around line 171-208.","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"3ce89653867cb7ca966cb6aef0a2fd66aff945a9","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":107,"context_line":"def create_pending_row_periodic_task(session, task):"},{"line_number":108,"context_line":"    row \u003d models.OpendaylightMaintenance(state\u003dodl_const.PENDING,"},{"line_number":109,"context_line":"                                         processing_operation\u003dNone,"},{"line_number":110,"context_line":"                                         task\u003dtask,"},{"line_number":111,"context_line":"                                         lock_updated\u003dfunc.now())"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    session.add(row)"},{"line_number":114,"context_line":"    try:"},{"line_number":115,"context_line":"        session.flush()"},{"line_number":116,"context_line":"    except exception.DBDuplicateEntry:"},{"line_number":117,"context_line":"        pass"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_84b6d13d","line":117,"range":{"start_line":107,"start_character":0,"end_line":117,"end_character":12},"in_reply_to":"ff0f0b1f_367bcdbe","updated":"2017-05-23 08:59:59.000000000","message":"Done","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"}],"networking_odl/db/migration/alembic_migrations/versions/ocata/contract/eab5ef5b07f3_add_task_column_in_opendaylight_.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d09eb2b2be274b870dcfb07cfde7987b21c62e22","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.execute(\u0027DELETE FROM opendaylight_maintenance\u0027)"},{"line_number":34,"context_line":"    op.add_column(\u0027opendaylight_maintenance\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027task\u0027, sa.String(70)))"},{"line_number":36,"context_line":"    op.create_unique_constraint(\u0027unique_task\u0027,"},{"line_number":37,"context_line":"                                \u0027opendaylight_maintenance\u0027,"},{"line_number":38,"context_line":"                                [\u0027task\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_766b851d","line":35,"range":{"start_line":35,"start_character":49,"end_line":35,"end_character":51},"updated":"2017-05-22 20:42:17.000000000","message":"Can\u0027t we add unique\u003dTrue instead of line 36?","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"3ce89653867cb7ca966cb6aef0a2fd66aff945a9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.execute(\u0027DELETE FROM opendaylight_maintenance\u0027)"},{"line_number":34,"context_line":"    op.add_column(\u0027opendaylight_maintenance\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027task\u0027, sa.String(70)))"},{"line_number":36,"context_line":"    op.create_unique_constraint(\u0027unique_task\u0027,"},{"line_number":37,"context_line":"                                \u0027opendaylight_maintenance\u0027,"},{"line_number":38,"context_line":"                                [\u0027task\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_248b856e","line":35,"range":{"start_line":35,"start_character":49,"end_line":35,"end_character":51},"in_reply_to":"ff0f0b1f_766b851d","updated":"2017-05-23 08:59:59.000000000","message":"No, it is not allowed here.","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8a2526a5f0d1beb3ca7a08a46102dec4e4c22544","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.execute(\u0027DELETE FROM opendaylight_maintenance\u0027)"},{"line_number":34,"context_line":"    op.add_column(\u0027opendaylight_maintenance\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027task\u0027, sa.String(70)))"},{"line_number":36,"context_line":"    op.create_unique_constraint(\u0027unique_task\u0027,"},{"line_number":37,"context_line":"                                \u0027opendaylight_maintenance\u0027,"},{"line_number":38,"context_line":"                                [\u0027task\u0027])"},{"line_number":39,"context_line":"    op.rename_table(\u0027opendaylight_maintenance\u0027, \u0027opendaylight_periodic_task\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_522f3c87","line":39,"range":{"start_line":33,"start_character":0,"end_line":39,"end_character":77},"updated":"2017-05-23 23:09:29.000000000","message":"can we just create a new table with the name of periodic_task and then drop maintenance table?\nIf so, creating table can be expand.\nin contract, we can just drop the table without deleting rows.","commit_id":"15319fa7fb2c12e86baae9195ff5a2b1d2942795"}],"networking_odl/db/migration/alembic_migrations/versions/ocata/contract/eccd865b7d3a_drop_opendaylight_maintenance_table.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"c7a4f6131fc8df2054d59e3c8cc652809bfa2eb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"bf091321_b4562b06","updated":"2017-06-12 11:41:12.000000000","message":"This is on \"Ocata\" branching but we\u0027re in Pike already","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"}],"networking_odl/db/migration/alembic_migrations/versions/ocata/expand/eab5ef5b07f3_add_task_column_in_opendaylight_.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027opendaylight_maintenance\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027task\u0027, sa.String(70)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def downgrade():"},{"line_number":38,"context_line":"    op.drop_column(\u0027opendaylight_maintenance\u0027, \u0027task\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_39008d67","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":54},"updated":"2017-05-17 01:57:02.000000000","message":"downgrade is not needed.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"20150a778b56bd0e5cb1da47e594d61311539641","unresolved":false,"context_lines":[{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027opendaylight_maintenance\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027task\u0027, sa.String(70)))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def downgrade():"},{"line_number":38,"context_line":"    op.drop_column(\u0027opendaylight_maintenance\u0027, \u0027task\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_9f454146","line":38,"range":{"start_line":35,"start_character":0,"end_line":38,"end_character":54},"in_reply_to":"1f013ff3_39008d67","updated":"2017-05-18 05:49:21.000000000","message":"Done","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f9b280e3242f58887912e99719383fca7beec7b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 \u003cPUT YOUR NAME/COMPANY HERE\u003e"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_02c69249","line":1,"range":{"start_line":1,"start_character":17,"end_line":1,"end_character":45},"updated":"2017-05-19 01:30:53.000000000","message":"update this.","commit_id":"acec513382cd7e0edaf8eab901518d2557116bf3"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f9b280e3242f58887912e99719383fca7beec7b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.execute(\u0027DELETE FROM opendaylight_maintenance\u0027)"},{"line_number":34,"context_line":"    op.add_column(\u0027opendaylight_maintenance\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027task\u0027, sa.String(70)))"},{"line_number":36,"context_line":"    op.create_unique_constraint(\u0027task_and_phase\u0027,"},{"line_number":37,"context_line":"                                \u0027opendaylight_maintenance\u0027,"},{"line_number":38,"context_line":"                                [\u0027processing_operation\u0027, \u0027task\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_62b54ecd","line":38,"range":{"start_line":33,"start_character":0,"end_line":38,"end_character":65},"updated":"2017-05-19 01:30:53.000000000","message":"This operation isn\u0027t expand. but contract.","commit_id":"acec513382cd7e0edaf8eab901518d2557116bf3"}],"networking_odl/db/models.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    state \u003d sa.Column(sa.Enum(odl_const.PENDING, odl_const.PROCESSING),"},{"line_number":49,"context_line":"                      nullable\u003dFalse)"},{"line_number":50,"context_line":"    processing_operation \u003d sa.Column(sa.String(70))"},{"line_number":51,"context_line":"    task \u003d sa.Column(sa.String(70))"},{"line_number":52,"context_line":"    lock_updated \u003d sa.Column(sa.TIMESTAMP, nullable\u003dFalse,"},{"line_number":53,"context_line":"                             server_default\u003dsa.func.now(),"},{"line_number":54,"context_line":"                             onupdate\u003dsa.func.now())"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_f96c6537","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":35},"updated":"2017-05-17 01:57:02.000000000","message":"this can have unique constraint.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"aadcaeb305e17f30ec5d0ba79b8c0096d376845b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    state \u003d sa.Column(sa.Enum(odl_const.PENDING, odl_const.PROCESSING),"},{"line_number":49,"context_line":"                      nullable\u003dFalse)"},{"line_number":50,"context_line":"    processing_operation \u003d sa.Column(sa.String(70))"},{"line_number":51,"context_line":"    task \u003d sa.Column(sa.String(70))"},{"line_number":52,"context_line":"    lock_updated \u003d sa.Column(sa.TIMESTAMP, nullable\u003dFalse,"},{"line_number":53,"context_line":"                             server_default\u003dsa.func.now(),"},{"line_number":54,"context_line":"                             onupdate\u003dsa.func.now())"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_6228a3e1","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":35},"in_reply_to":"1f013ff3_f96c6537","updated":"2017-05-19 09:46:41.000000000","message":"Done","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5f9b280e3242f58887912e99719383fca7beec7b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    lock_updated \u003d sa.Column(sa.TIMESTAMP, nullable\u003dFalse,"},{"line_number":53,"context_line":"                             server_default\u003dsa.func.now(),"},{"line_number":54,"context_line":"                             onupdate\u003dsa.func.now())"},{"line_number":55,"context_line":"    __table_args__ \u003d (sa.UniqueConstraint(task, processing_operation,"},{"line_number":56,"context_line":"                      name\u003d\u0027task_and_phase\u0027), model_base.BASEV2.__table_args__)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_e2eefeb2","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":79},"updated":"2017-05-19 01:30:53.000000000","message":"No. simply task is unique.","commit_id":"acec513382cd7e0edaf8eab901518d2557116bf3"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"400991d140b60297325cc647585eb003ddf14e76","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    lock_updated \u003d sa.Column(sa.TIMESTAMP, nullable\u003dFalse,"},{"line_number":53,"context_line":"                             server_default\u003dsa.func.now(),"},{"line_number":54,"context_line":"                             onupdate\u003dsa.func.now())"},{"line_number":55,"context_line":"    __table_args__ \u003d (sa.UniqueConstraint(task, processing_operation,"},{"line_number":56,"context_line":"                      name\u003d\u0027task_and_phase\u0027), model_base.BASEV2.__table_args__)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_6256635f","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":79},"in_reply_to":"ff0f0b1f_e2eefeb2","updated":"2017-05-19 09:46:26.000000000","message":"Done","commit_id":"acec513382cd7e0edaf8eab901518d2557116bf3"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d09eb2b2be274b870dcfb07cfde7987b21c62e22","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                             onupdate\u003dsa.func.now())"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class OpendaylightMaintenance(model_base.BASEV2, model_base.HasId):"},{"line_number":46,"context_line":"    __tablename__ \u003d \u0027opendaylight_maintenance\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    state \u003d sa.Column(sa.Enum(odl_const.PENDING, odl_const.PROCESSING),"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_9872c77a","line":45,"range":{"start_line":45,"start_character":18,"end_line":45,"end_character":29},"updated":"2017-05-22 20:42:17.000000000","message":"PeriodicTask?\nYou renamed maintenance -\u003e periodic task other places.\nPlease be consistent.\nPersonally I\u0027m fine with either way, maintenance or peridic.\nBut I\u0027d like to have consistency.","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"}],"networking_odl/journal/maintenance.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class MaintenanceThread(periodic_task.PeriodicTask):"},{"line_number":21,"context_line":"    task_name \u003d \u0027maintenance\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_39eacd74","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":29},"updated":"2017-05-17 01:57:02.000000000","message":"This can be passed as argument to the constructor of super class.\nThen we don\u0027t have to create a class for per task.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"51b8723c6568b9763543ab88c0825eb2aba57dbf","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class MaintenanceThread(periodic_task.PeriodicTask):"},{"line_number":21,"context_line":"    task_name \u003d \u0027maintenance\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_02ad7287","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":29},"in_reply_to":"1f013ff3_2e9840be","updated":"2017-05-19 01:26:35.000000000","message":"I don\u0027t see benefit to do it with another followup patch.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"20150a778b56bd0e5cb1da47e594d61311539641","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class MaintenanceThread(periodic_task.PeriodicTask):"},{"line_number":21,"context_line":"    task_name \u003d \u0027maintenance\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_2e9840be","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":29},"in_reply_to":"1f013ff3_39eacd74","updated":"2017-05-18 05:49:21.000000000","message":"yes, it can be. I am planning to do it in separate patch, it will become complex in this patch. Because renaming has to be done at lot of places therefore reviewing will become difficult.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"aadcaeb305e17f30ec5d0ba79b8c0096d376845b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class MaintenanceThread(periodic_task.PeriodicTask):"},{"line_number":21,"context_line":"    task_name \u003d \u0027maintenance\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_dfc74c12","line":21,"range":{"start_line":21,"start_character":4,"end_line":21,"end_character":29},"in_reply_to":"ff0f0b1f_02ad7287","updated":"2017-05-19 09:46:41.000000000","message":"Done","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"c7a4f6131fc8df2054d59e3c8cc652809bfa2eb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"bf091321_d4a51fb7","updated":"2017-06-12 11:41:12.000000000","message":"Why was this file deleted?\n\nWe now lost all git history tracking.\n\nWhy wasn\u0027t \u0027git mv\u0027 used?","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"}],"networking_odl/journal/periodic_task.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class PeriodicTask(object):"},{"line_number":29,"context_line":"    def __init__(self):"},{"line_number":30,"context_line":"        self.timer \u003d loopingcall.FixedIntervalLoopingCall(self.execute_ops)"},{"line_number":31,"context_line":"        self.maintenance_interval \u003d cfg.CONF.ml2_odl.maintenance_interval"},{"line_number":32,"context_line":"        self.maintenance_ops \u003d dict()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_f93ea527","line":31,"range":{"start_line":31,"start_character":36,"end_line":31,"end_character":73},"updated":"2017-05-17 01:57:02.000000000","message":"This should be per task basis.\nadd argument, interval, to __init__().","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"20150a778b56bd0e5cb1da47e594d61311539641","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class PeriodicTask(object):"},{"line_number":29,"context_line":"    def __init__(self):"},{"line_number":30,"context_line":"        self.timer \u003d loopingcall.FixedIntervalLoopingCall(self.execute_ops)"},{"line_number":31,"context_line":"        self.maintenance_interval \u003d cfg.CONF.ml2_odl.maintenance_interval"},{"line_number":32,"context_line":"        self.maintenance_ops \u003d dict()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def start(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_dfe189fe","line":31,"range":{"start_line":31,"start_character":36,"end_line":31,"end_character":73},"in_reply_to":"1f013ff3_f93ea527","updated":"2017-05-18 05:49:21.000000000","message":"Done","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def execute_ops(self):"},{"line_number":63,"context_line":"        LOG.info(\"Starting periodic task.\")"},{"line_number":64,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":65,"context_line":"        for task, phases in self.maintenance_ops.items():"},{"line_number":66,"context_line":"            for phase in phases:"},{"line_number":67,"context_line":"                try:"},{"line_number":68,"context_line":"                    if not db.lock_periodic_phase(session,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_d983e9a8","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":57},"updated":"2017-05-17 01:57:02.000000000","message":"just use list. so this outer loop isn\u0027t needed.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"51b8723c6568b9763543ab88c0825eb2aba57dbf","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def execute_ops(self):"},{"line_number":63,"context_line":"        LOG.info(\"Starting periodic task.\")"},{"line_number":64,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":65,"context_line":"        for task, phases in self.maintenance_ops.items():"},{"line_number":66,"context_line":"            for phase in phases:"},{"line_number":67,"context_line":"                try:"},{"line_number":68,"context_line":"                    if not db.lock_periodic_phase(session,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_2279962e","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":57},"in_reply_to":"1f013ff3_7f2ef543","updated":"2017-05-19 01:26:35.000000000","message":"task name is associated to instance. not class.\nsimply self.task_name is the one.\nsingle instance doesn\u0027t have multiple task name.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"20150a778b56bd0e5cb1da47e594d61311539641","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    def execute_ops(self):"},{"line_number":63,"context_line":"        LOG.info(\"Starting periodic task.\")"},{"line_number":64,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":65,"context_line":"        for task, phases in self.maintenance_ops.items():"},{"line_number":66,"context_line":"            for phase in phases:"},{"line_number":67,"context_line":"                try:"},{"line_number":68,"context_line":"                    if not db.lock_periodic_phase(session,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_7f2ef543","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":57},"in_reply_to":"1f013ff3_d983e9a8","updated":"2017-05-18 05:49:21.000000000","message":"Hi Isaku,\n\nWe will have to keep task information somewhere so that we can apply lock on a phase of a task. Either we can do this or while registering we register as a tuple (task_name, method). I think, implemented approach will be better. I have used following\n\n{\n  \u0027task1\u0027: {\u0027phase1\u0027, \u0027phase2\u0027},\n  \u0027task2\u0027: {\u0027phase1\u0027, \u0027phase3\u0027}\n}\n\nfor phases set has been used, just in case a task gets registered twice, it will make sure that they are unique.\n\nI think, it does not add any overhead, however if you think, it is better to do other way around then let me know.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        :param f: Function to call when the thread runs. The function will"},{"line_number":86,"context_line":"        receive a DB session to use for DB operations."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        task \u003d self.task_name"},{"line_number":89,"context_line":"        if task not in self.maintenance_ops:"},{"line_number":90,"context_line":"            self.maintenance_ops[task] \u003d set([f])"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_79f05568","line":88,"range":{"start_line":88,"start_character":20,"end_line":88,"end_character":29},"updated":"2017-05-17 01:57:02.000000000","message":"This can be passed as argument to constructor.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"20150a778b56bd0e5cb1da47e594d61311539641","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        :param f: Function to call when the thread runs. The function will"},{"line_number":86,"context_line":"        receive a DB session to use for DB operations."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        task \u003d self.task_name"},{"line_number":89,"context_line":"        if task not in self.maintenance_ops:"},{"line_number":90,"context_line":"            self.maintenance_ops[task] \u003d set([f])"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_1fe011fa","line":88,"range":{"start_line":88,"start_character":20,"end_line":88,"end_character":29},"in_reply_to":"1f013ff3_79f05568","updated":"2017-05-18 05:49:21.000000000","message":"Will be doing in next patch.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        task \u003d self.task_name"},{"line_number":89,"context_line":"        if task not in self.maintenance_ops:"},{"line_number":90,"context_line":"            self.maintenance_ops[task] \u003d set([f])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.maintenance_ops[task].add(f)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_19a2714c","line":90,"range":{"start_line":90,"start_character":32,"end_line":90,"end_character":39},"updated":"2017-05-17 01:57:02.000000000","message":"why dict?\nself.task_name is fixed. just list works.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"20150a778b56bd0e5cb1da47e594d61311539641","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        task \u003d self.task_name"},{"line_number":89,"context_line":"        if task not in self.maintenance_ops:"},{"line_number":90,"context_line":"            self.maintenance_ops[task] \u003d set([f])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.maintenance_ops[task].add(f)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_8e92b44a","line":90,"range":{"start_line":90,"start_character":32,"end_line":90,"end_character":39},"in_reply_to":"1f013ff3_19a2714c","updated":"2017-05-18 05:49:21.000000000","message":"reason explained in previous comments.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.maintenance_ops[task].add(f)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":95,"context_line":"        if not len(db.get_db_rows_by_phase_task(session, f.__name__, task)):"},{"line_number":96,"context_line":"            db.create_pending_row_periodic_task(session, f.__name__, task)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_d9fe4937","line":96,"range":{"start_line":94,"start_character":0,"end_line":96,"end_character":74},"updated":"2017-05-17 01:57:02.000000000","message":"This is racy. add uniq constraint and catch violation.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"20150a778b56bd0e5cb1da47e594d61311539641","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.maintenance_ops[task].add(f)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":95,"context_line":"        if not len(db.get_db_rows_by_phase_task(session, f.__name__, task)):"},{"line_number":96,"context_line":"            db.create_pending_row_periodic_task(session, f.__name__, task)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_6e99a86c","line":96,"range":{"start_line":94,"start_character":0,"end_line":96,"end_character":74},"in_reply_to":"1f013ff3_d9fe4937","updated":"2017-05-18 05:49:21.000000000","message":"Done","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d09eb2b2be274b870dcfb07cfde7987b21c62e22","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.timer \u003d loopingcall.FixedIntervalLoopingCall(self.execute_ops)"},{"line_number":30,"context_line":"        self.interval \u003d interval"},{"line_number":31,"context_line":"        self.task \u003d task"},{"line_number":32,"context_line":"        self.phases \u003d set()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def start(self):"},{"line_number":35,"context_line":"        self.timer.start(self.interval, stop_on_exception\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_78b6d340","line":32,"range":{"start_line":32,"start_character":22,"end_line":32,"end_character":27},"updated":"2017-05-22 20:42:17.000000000","message":"Let\u0027s keep this a list for determinism.","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"3ce89653867cb7ca966cb6aef0a2fd66aff945a9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        self.timer \u003d loopingcall.FixedIntervalLoopingCall(self.execute_ops)"},{"line_number":30,"context_line":"        self.interval \u003d interval"},{"line_number":31,"context_line":"        self.task \u003d task"},{"line_number":32,"context_line":"        self.phases \u003d set()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def start(self):"},{"line_number":35,"context_line":"        self.timer.start(self.interval, stop_on_exception\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_648cdd7e","line":32,"range":{"start_line":32,"start_character":22,"end_line":32,"end_character":27},"in_reply_to":"ff0f0b1f_78b6d340","updated":"2017-05-23 08:59:59.000000000","message":"Done","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8a2526a5f0d1beb3ca7a08a46102dec4e4c22544","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            # some tests call this cleanup without calling start"},{"line_number":45,"context_line":"            pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _execute_op(self, operation, task, session):"},{"line_number":48,"context_line":"        op_details \u003d operation.__name__"},{"line_number":49,"context_line":"        if operation.__doc__:"},{"line_number":50,"context_line":"            op_details +\u003d \" (%s)\" % operation.func_doc"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_5244dc46","line":47,"range":{"start_line":47,"start_character":37,"end_line":47,"end_character":41},"updated":"2017-05-23 23:09:29.000000000","message":"This argument isn\u0027t necessary as it\u0027s self.task.","commit_id":"15319fa7fb2c12e86baae9195ff5a2b1d2942795"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8a2526a5f0d1beb3ca7a08a46102dec4e4c22544","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        try:"},{"line_number":53,"context_line":"            LOG.info(\"Starting %s phase of periodic task %s.\","},{"line_number":54,"context_line":"                     op_details, task)"},{"line_number":55,"context_line":"            db.update_periodic_task(session, task\u003dtask, operation\u003doperation)"},{"line_number":56,"context_line":"            operation(session\u003dsession)"},{"line_number":57,"context_line":"            LOG.info(\"Finished %s phase of %s task.\", op_details, task)"},{"line_number":58,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_d2710caa","line":55,"range":{"start_line":55,"start_character":50,"end_line":55,"end_character":54},"updated":"2017-05-23 23:09:29.000000000","message":"self.task","commit_id":"15319fa7fb2c12e86baae9195ff5a2b1d2942795"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"c7a4f6131fc8df2054d59e3c8cc652809bfa2eb7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            LOG.exception(\"Failed during periodic task operation %s.\","},{"line_number":61,"context_line":"                          op_details)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def execute_ops(self):"},{"line_number":64,"context_line":"        LOG.info(\"Starting periodic task.\")"},{"line_number":65,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":66,"context_line":"        for phase in self.phases:"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf091321_34f0dbc9","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":19},"updated":"2017-06-12 11:41:12.000000000","message":"Generally now each thread will attempt each task \u003e\u003d 1 times so if two processes run with some time between them they will both process all tasks even if they were just processed.\n\nThis seems logically flawed to me since we don\u0027t want to stress the system with these periodic tasks..","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"4f34f911a1c3b4fa12f2ebc2f5332b6ea87ed1d6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            LOG.exception(\"Failed during periodic task operation %s.\","},{"line_number":61,"context_line":"                          op_details)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def execute_ops(self):"},{"line_number":64,"context_line":"        LOG.info(\"Starting periodic task.\")"},{"line_number":65,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":66,"context_line":"        for phase in self.phases:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f231b9d_b99809c0","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":19},"in_reply_to":"7f231b9d_062574c2","updated":"2017-06-14 05:38:51.000000000","message":"I understand, you mean, when worker1 process finishes, worker2 or other process on different machine starts periodic tasks.","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"f6edf6eacf14f3a60f9ee242d0a196e9b7d7a0c3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            LOG.exception(\"Failed during periodic task operation %s.\","},{"line_number":61,"context_line":"                          op_details)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def execute_ops(self):"},{"line_number":64,"context_line":"        LOG.info(\"Starting periodic task.\")"},{"line_number":65,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":66,"context_line":"        for phase in self.phases:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f231b9d_062574c2","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":19},"in_reply_to":"bf091321_34f0dbc9","updated":"2017-06-13 12:56:19.000000000","message":"I want to understand this scenario, so that i can take care in the next patch.\n\nMy understanding is, each object will have its own looping call. Intersection of phases for the same task among different objects is going to be null. Therefore a phase in a task will be executed once and after the given interval it will be executed again. They will not be executed back to back.","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"c7a4f6131fc8df2054d59e3c8cc652809bfa2eb7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def execute_ops(self):"},{"line_number":64,"context_line":"        LOG.info(\"Starting periodic task.\")"},{"line_number":65,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":66,"context_line":"        for phase in self.phases:"},{"line_number":67,"context_line":"            try:"},{"line_number":68,"context_line":"                if not db.lock_periodic_task(session, self.task):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"                    LOG.info((\"Periodic task already running, moving to \""},{"line_number":71,"context_line":"                              \" next operation.\"))"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf091321_d49f5fb2","line":68,"range":{"start_line":66,"start_character":8,"end_line":68,"end_character":65},"updated":"2017-06-12 11:41:12.000000000","message":"This locks per phase? Why?\n\nI\u0027d expect for a single \"Task\" the phases will be in some order for a reason or could have some dependency between them and thus not have reason to execute in parallel..","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"f6edf6eacf14f3a60f9ee242d0a196e9b7d7a0c3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def execute_ops(self):"},{"line_number":64,"context_line":"        LOG.info(\"Starting periodic task.\")"},{"line_number":65,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":66,"context_line":"        for phase in self.phases:"},{"line_number":67,"context_line":"            try:"},{"line_number":68,"context_line":"                if not db.lock_periodic_task(session, self.task):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"                    LOG.info((\"Periodic task already running, moving to \""},{"line_number":71,"context_line":"                              \" next operation.\"))"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f231b9d_612bf281","line":68,"range":{"start_line":66,"start_character":8,"end_line":68,"end_character":65},"in_reply_to":"bf091321_d49f5fb2","updated":"2017-06-13 12:56:19.000000000","message":"Currently, Is there any dependencies among phases? If there is any please let me know, i will find out other details myself.\n\nI think, locking per task can be applied and current implementation can be improved, as you pointed out.","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"c7a4f6131fc8df2054d59e3c8cc652809bfa2eb7","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"                    LOG.info((\"Periodic task already running, moving to \""},{"line_number":71,"context_line":"                              \" next operation.\"))"},{"line_number":72,"context_line":"                    continue"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"                self._execute_op(phase, session)"},{"line_number":75,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf091321_3107cd1f","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":28},"updated":"2017-06-12 11:41:12.000000000","message":"This would still cause \"unlock\" to occur..","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"f6edf6eacf14f3a60f9ee242d0a196e9b7d7a0c3","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"                    LOG.info((\"Periodic task already running, moving to \""},{"line_number":71,"context_line":"                              \" next operation.\"))"},{"line_number":72,"context_line":"                    continue"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"                self._execute_op(phase, session)"},{"line_number":75,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f231b9d_e6671851","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":28},"in_reply_to":"bf091321_3107cd1f","updated":"2017-06-13 12:56:19.000000000","message":"Yes, agree","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"c7a4f6131fc8df2054d59e3c8cc652809bfa2eb7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        self.phases.append(f)"},{"line_number":87,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":88,"context_line":"        db.create_task_if_not_registered(session, self.task)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf091321_34357bdb","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":60},"updated":"2017-06-12 11:41:12.000000000","message":"This will happen on each init of the process?","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"f6edf6eacf14f3a60f9ee242d0a196e9b7d7a0c3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        \"\"\""},{"line_number":86,"context_line":"        self.phases.append(f)"},{"line_number":87,"context_line":"        session \u003d neutron_db_api.get_writer_session()"},{"line_number":88,"context_line":"        db.create_task_if_not_registered(session, self.task)"}],"source_content_type":"text/x-python","patch_set":15,"id":"7f231b9d_066d7431","line":88,"range":{"start_line":88,"start_character":8,"end_line":88,"end_character":60},"in_reply_to":"bf091321_34357bdb","updated":"2017-06-13 12:56:19.000000000","message":"Whenever anyone wants to register for a periodic task then it will be done. Database takes care of duplicate entries.","commit_id":"e8bc268b6a8ababa5d4bb0f3eda3884233d5bf9c"}],"networking_odl/tests/unit/db/test_db.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d09eb2b2be274b870dcfb07cfde7987b21c62e22","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def _test_maintenance_lock_unlock(self, db_func, existing_state,"},{"line_number":205,"context_line":"                                      expected_state, expected_result):"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        row \u003d models.OpendaylightMaintenance(id\u003d\u0027test\u0027,"},{"line_number":208,"context_line":"                                             state\u003dexisting_state,"},{"line_number":209,"context_line":"                                             task\u003d\u0027test_task\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_78bdb300","line":206,"updated":"2017-05-22 20:42:17.000000000","message":"unnecessary change.","commit_id":"ef3af00fd9e0e105ec4cfe7f6f8bed56d5da901c"}],"networking_odl/tests/unit/ml2/test_networking_topology.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"93531d866afa86df29ebc5bad63750a20e2b322a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TestNetworkTopologyManager(base.DietTestCase,"},{"line_number":43,"context_line":"                                 test_base_db.ODLBaseDbTestCase):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # pylint: disable\u003dprotected-access"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_79be1566","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":65},"updated":"2017-05-17 01:57:02.000000000","message":"Why is this change needed?","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"aadcaeb305e17f30ec5d0ba79b8c0096d376845b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TestNetworkTopologyManager(base.DietTestCase,"},{"line_number":43,"context_line":"                                 test_base_db.ODLBaseDbTestCase):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # pylint: disable\u003dprotected-access"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_a2359b48","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":65},"in_reply_to":"1f013ff3_79be1566","updated":"2017-05-19 09:46:41.000000000","message":"https://github.com/openstack/networking-odl/blob/master/networking_odl/tests/unit/ml2/test_networking_topology.py#L229 \nIt initializes the ml2 driver, which register for the the periodic tasks. During registering database row is being created. Therefor it is required.","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ebaeb73ce8715faa636b841793e16cdfdf3ca2b0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TestNetworkTopologyManager(base.DietTestCase,"},{"line_number":43,"context_line":"                                 test_base_db.ODLBaseDbTestCase):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # pylint: disable\u003dprotected-access"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ff0f0b1f_cc0bdd21","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":65},"in_reply_to":"ff0f0b1f_a2359b48","updated":"2017-05-22 20:40:59.000000000","message":"I got it. You\u0027re right.\n\nIs this fix unrelated to this patch itself?\nShouldn\u0027t the fix be independent patch?","commit_id":"a2169a9bad23d9aa2156534534a28cc4d11e1ed8"}]}
