)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"d9aca6741e032e137e0d6949404713782d4aec23","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"journal: teach odl_sync_event multi threading"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"journal set_event should be aware of multi threading, i.e."},{"line_number":10,"context_line":"there can be many journal syncer threads."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9e9b0854374766b6d80ed685152743b9aa81cece"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df140735_f304bd80","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":41},"updated":"2017-06-07 09:13:42.000000000","message":"Not sure what you mean, did you actually observe a bug here?\n\nFrom what I saw https://docs.python.org/2/library/threading.html#event-objects is already multi-thread aware so why are you replacing it with something more complicated?","commit_id":"1108384d23594db786caa152b201dca18bc28951"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"3953f0ae2933a1aa9af1de696682e7d5cb210d00","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"journal: teach odl_sync_event multi threading"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"journal set_event should be aware of multi threading, i.e."},{"line_number":10,"context_line":"there can be many journal syncer threads."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9e9b0854374766b6d80ed685152743b9aa81cece"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f201791_c746337d","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":41},"in_reply_to":"df140735_f304bd80","updated":"2017-06-24 00:49:22.000000000","message":"This patch ins\u0027t for bug fix, but optimization.\nUpdated the commit message.","commit_id":"1108384d23594db786caa152b201dca18bc28951"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cee4d8cc023a4bca033ab0f275abb1ce6168ccfc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There can be multiple instances of OpendaylightJournalThread."},{"line_number":10,"context_line":"So allow set_sync_event method to wake up any one of thread."},{"line_number":11,"context_line":"Since only also single timer is needed. consolidate timer"},{"line_number":12,"context_line":"into single timer in order to avoid unnecessarily load rdbms."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9e9b0854374766b6d80ed685152743b9aa81cece"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ff346bd7_cad54be7","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":15},"updated":"2017-07-25 00:59:36.000000000","message":"?","commit_id":"3e05e2d147fd01628f9e06e2c11e488d22718d3d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e0c8f590e1fffa0e13448c4e7412290f3492ecf8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There can be multiple instances of OpendaylightJournalThread."},{"line_number":10,"context_line":"So allow set_sync_event method to wake up any one of thread."},{"line_number":11,"context_line":"Since only also single timer is needed. consolidate timer"},{"line_number":12,"context_line":"into single timer in order to avoid unnecessarily load rdbms."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9e9b0854374766b6d80ed685152743b9aa81cece"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ff346bd7_15047d49","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":15},"in_reply_to":"ff346bd7_cad54be7","updated":"2017-07-25 15:08:10.000000000","message":"Done","commit_id":"3e05e2d147fd01628f9e06e2c11e488d22718d3d"}],"networking_odl/tests/base.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"d9aca6741e032e137e0d6949404713782d4aec23","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        super(OpenDaylightRestClientGlobalFixture, self)._setUp()"},{"line_number":58,"context_line":"        mock.patch.object(self._global_client, \u0027get_client\u0027).start()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class OpenDaylightJournalThreadFixture(fixtures.Fixture):"},{"line_number":62,"context_line":"    def _setUp(self):"},{"line_number":63,"context_line":"        super(OpenDaylightJournalThreadFixture, self)._setUp()"},{"line_number":64,"context_line":"        mock.patch.object(journal.OpendaylightJournalThread,"},{"line_number":65,"context_line":"                          \u0027start_odl_sync_thread\u0027).start()"},{"line_number":66,"context_line":"        mock.patch.object(journal.OpendaylightSyncEvent,"},{"line_number":67,"context_line":"                          \u0027_start_sync_timer\u0027).start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_5390094f","line":65,"range":{"start_line":60,"start_character":0,"end_line":65,"end_character":48},"updated":"2017-06-07 09:13:42.000000000","message":"The bulk of this change (and related changes in tests) aren\u0027t really tied to the change you\u0027re doing, please split it up and send as preliminary change to to the chain of changes.","commit_id":"1108384d23594db786caa152b201dca18bc28951"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"3953f0ae2933a1aa9af1de696682e7d5cb210d00","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        super(OpenDaylightRestClientGlobalFixture, self)._setUp()"},{"line_number":58,"context_line":"        mock.patch.object(self._global_client, \u0027get_client\u0027).start()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class OpenDaylightJournalThreadFixture(fixtures.Fixture):"},{"line_number":62,"context_line":"    def _setUp(self):"},{"line_number":63,"context_line":"        super(OpenDaylightJournalThreadFixture, self)._setUp()"},{"line_number":64,"context_line":"        mock.patch.object(journal.OpendaylightJournalThread,"},{"line_number":65,"context_line":"                          \u0027start_odl_sync_thread\u0027).start()"},{"line_number":66,"context_line":"        mock.patch.object(journal.OpendaylightSyncEvent,"},{"line_number":67,"context_line":"                          \u0027_start_sync_timer\u0027).start()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f201791_87771bd5","line":65,"range":{"start_line":60,"start_character":0,"end_line":65,"end_character":48},"in_reply_to":"df140735_5390094f","updated":"2017-06-24 00:49:22.000000000","message":"Done","commit_id":"1108384d23594db786caa152b201dca18bc28951"}]}
