)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"45f095d0ddca4b9786d9a59c4f3b6e29427d600b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug: #1689990"},{"line_number":10,"context_line":"Change-Id: I5b8d2086dc6a1c6f014d6b8fc7230f0588f7bb19"},{"line_number":11,"context_line":"Signed-off-by: Guoshuai Li \u003cligs@dtdream.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff0f0b1f_4b112cac","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":13},"updated":"2017-05-19 19:05:09.000000000","message":"co-author-by","commit_id":"fa7a673d9ae64e0c0dc47331f5370c730b01c521"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b469fe8ec4ce0160d3fdc61673fe856b0956f336","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-bug: #1689990"},{"line_number":10,"context_line":"Change-Id: I5b8d2086dc6a1c6f014d6b8fc7230f0588f7bb19"},{"line_number":11,"context_line":"Signed-off-by: Guoshuai Li \u003cligs@dtdream.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff0f0b1f_6109af2a","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":13},"in_reply_to":"ff0f0b1f_4b112cac","updated":"2017-05-19 19:29:52.000000000","message":"he is original author, so not needed","commit_id":"fa7a673d9ae64e0c0dc47331f5370c730b01c521"}],"networking_odl/l3/l3_odl.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7bfaa2ce84770fbbc2a361365a494ef521e1a6c7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            disassociate_floatingips(context, port_id, do_notify)"},{"line_number":146,"context_line":"        for fip_dict in fip_dicts:"},{"line_number":147,"context_line":"            fip_dict[\u0027status\u0027] \u003d q_const.FLOATINGIP_STATUS_DOWN"},{"line_number":148,"context_line":"            fip_dict.pop(\u0027port_id\u0027)"},{"line_number":149,"context_line":"            fip_dict.pop(\u0027fixed_ip_address\u0027)"},{"line_number":150,"context_line":"            fip_dict.pop(\u0027router_id\u0027)"},{"line_number":151,"context_line":"            url \u003d FLOATINGIPS + \"/\" + fip_dict[\u0027id\u0027]"},{"line_number":152,"context_line":"            self.client.sendjson(\u0027put\u0027, url, {FLOATINGIPS[:-1]: fip_dict})"},{"line_number":153,"context_line":"        return router_ids"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_edf3789d","line":150,"range":{"start_line":148,"start_character":11,"end_line":150,"end_character":37},"updated":"2017-05-19 18:26:41.000000000","message":"nit: I guess these could be set to None ? instead to removing the keys from dictionary ?","commit_id":"d3ab2cd1009307c87135ea4441070dcbd2ac4ff4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"45f095d0ddca4b9786d9a59c4f3b6e29427d600b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            disassociate_floatingips(context, port_id, do_notify)"},{"line_number":146,"context_line":"        for fip_dict in fip_dicts:"},{"line_number":147,"context_line":"            fip_dict[\u0027status\u0027] \u003d q_const.FLOATINGIP_STATUS_DOWN"},{"line_number":148,"context_line":"            fip_dict.pop(\u0027port_id\u0027)"},{"line_number":149,"context_line":"            fip_dict.pop(\u0027fixed_ip_address\u0027)"},{"line_number":150,"context_line":"            fip_dict.pop(\u0027router_id\u0027)"},{"line_number":151,"context_line":"            url \u003d FLOATINGIPS + \"/\" + fip_dict[\u0027id\u0027]"},{"line_number":152,"context_line":"            self.client.sendjson(\u0027put\u0027, url, {FLOATINGIPS[:-1]: fip_dict})"},{"line_number":153,"context_line":"        return router_ids"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_c65e5111","line":150,"range":{"start_line":148,"start_character":0,"end_line":150,"end_character":36},"updated":"2017-05-19 19:05:09.000000000","message":"Please introduce FloatingIpFilter to do this.\nand use _filter_unmapped_null.","commit_id":"fa7a673d9ae64e0c0dc47331f5370c730b01c521"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f9f1606f27f975738398e317b5c0ca43ffc67616","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def disassociate_floatingips(self, context, port_id, do_notify\u003dTrue):"},{"line_number":145,"context_line":"        fip_dicts \u003d self.get_floatingips(context,"},{"line_number":146,"context_line":"                                         filters\u003d{\u0027port_id\u0027: [port_id]})"},{"line_number":147,"context_line":"        router_ids \u003d super(OpenDaylightL3RouterPlugin, self).\\"},{"line_number":148,"context_line":"            disassociate_floatingips(context, port_id, do_notify)"},{"line_number":149,"context_line":"        for fip_dict in fip_dicts:"},{"line_number":150,"context_line":"            fip_dict \u003d self.get_floatingip(context, fip_dict[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_70f6e565","line":147,"range":{"start_line":147,"start_character":61,"end_line":147,"end_character":62},"updated":"2017-08-03 21:31:11.000000000","message":"Please don\u0027t use backslash to continue line.","commit_id":"6114f831f504b4575d3b03d8a9df9cc22d1ac213"}],"networking_odl/l3/l3_odl_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1c71ece8f567886b241382a60e7770567d49d43b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    @journal.call_thread_on_end"},{"line_number":143,"context_line":"    def disassociate_floatingips(self, context, port_id, do_notify\u003dTrue):"},{"line_number":144,"context_line":"        session \u003d db_api.get_session()"},{"line_number":145,"context_line":"        fip_dicts \u003d self.get_floatingips(context.elevated(),"},{"line_number":146,"context_line":"                                         filters\u003d{\u0027port_id\u0027: [port_id]})"},{"line_number":147,"context_line":"        router_ids \u003d super(OpenDaylightL3RouterPlugin, self).\\"},{"line_number":148,"context_line":"            disassociate_floatingips(context, port_id, do_notify)"},{"line_number":149,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":150,"context_line":"            for fip_dict in fip_dicts:"},{"line_number":151,"context_line":"                self.update_floatingip_status("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_d053656a","line":148,"range":{"start_line":145,"start_character":0,"end_line":148,"end_character":65},"updated":"2017-05-11 20:16:31.000000000","message":"This should be in the same transaction of line 149.","commit_id":"026e7e4ecab4cddfa3355f092ad3ebffe373a90e"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"823aba86442c41d7d54ec15f9b977144ca534962","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    @journal.call_thread_on_end"},{"line_number":143,"context_line":"    def disassociate_floatingips(self, context, port_id, do_notify\u003dTrue):"},{"line_number":144,"context_line":"        session \u003d db_api.get_session()"},{"line_number":145,"context_line":"        fip_dicts \u003d self.get_floatingips(context.elevated(),"},{"line_number":146,"context_line":"                                         filters\u003d{\u0027port_id\u0027: [port_id]})"},{"line_number":147,"context_line":"        router_ids \u003d super(OpenDaylightL3RouterPlugin, self).\\"},{"line_number":148,"context_line":"            disassociate_floatingips(context, port_id, do_notify)"},{"line_number":149,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":150,"context_line":"            for fip_dict in fip_dicts:"},{"line_number":151,"context_line":"                self.update_floatingip_status("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_9cb29648","line":148,"range":{"start_line":145,"start_character":0,"end_line":148,"end_character":65},"in_reply_to":"3f044301_d053656a","updated":"2017-05-12 02:47:45.000000000","message":"Sorry, I fix it. Done.","commit_id":"026e7e4ecab4cddfa3355f092ad3ebffe373a90e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1c71ece8f567886b241382a60e7770567d49d43b","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            disassociate_floatingips(context, port_id, do_notify)"},{"line_number":149,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":150,"context_line":"            for fip_dict in fip_dicts:"},{"line_number":151,"context_line":"                self.update_floatingip_status("},{"line_number":152,"context_line":"                    context, fip_dict[\u0027id\u0027], q_const.FLOATINGIP_STATUS_DOWN)"},{"line_number":153,"context_line":"                fip_dict[\u0027status\u0027] \u003d q_const.FLOATINGIP_STATUS_DOWN"},{"line_number":154,"context_line":"                fip_dict.pop(\u0027port_id\u0027)"},{"line_number":155,"context_line":"                fip_dict.pop(\u0027fixed_ip_address\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_309cc90c","line":152,"range":{"start_line":151,"start_character":0,"end_line":152,"end_character":76},"updated":"2017-05-11 20:16:31.000000000","message":"Doesn\u0027t super class do this?\nHmm, l3_db.py doesn\u0027t. we should fix it l3_db.py.","commit_id":"026e7e4ecab4cddfa3355f092ad3ebffe373a90e"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"dc5d1d4f97e0558e5fc57ed0cac7dba8b753a6f1","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            disassociate_floatingips(context, port_id, do_notify)"},{"line_number":149,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":150,"context_line":"            for fip_dict in fip_dicts:"},{"line_number":151,"context_line":"                self.update_floatingip_status("},{"line_number":152,"context_line":"                    context, fip_dict[\u0027id\u0027], q_const.FLOATINGIP_STATUS_DOWN)"},{"line_number":153,"context_line":"                fip_dict[\u0027status\u0027] \u003d q_const.FLOATINGIP_STATUS_DOWN"},{"line_number":154,"context_line":"                fip_dict.pop(\u0027port_id\u0027)"},{"line_number":155,"context_line":"                fip_dict.pop(\u0027fixed_ip_address\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_1ce9e6b5","line":152,"range":{"start_line":151,"start_character":0,"end_line":152,"end_character":76},"in_reply_to":"3f044301_309cc90c","updated":"2017-05-12 03:19:12.000000000","message":"Is it better to keep same logic with update_floatingip? \nUpdate status all in odl or all in super class.","commit_id":"026e7e4ecab4cddfa3355f092ad3ebffe373a90e"},{"author":{"_account_id":24438,"name":"Guoshuai Li","email":"liguoshuai1989@gmail.com","username":"Guoshuai"},"change_message_id":"823aba86442c41d7d54ec15f9b977144ca534962","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            disassociate_floatingips(context, port_id, do_notify)"},{"line_number":149,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":150,"context_line":"            for fip_dict in fip_dicts:"},{"line_number":151,"context_line":"                self.update_floatingip_status("},{"line_number":152,"context_line":"                    context, fip_dict[\u0027id\u0027], q_const.FLOATINGIP_STATUS_DOWN)"},{"line_number":153,"context_line":"                fip_dict[\u0027status\u0027] \u003d q_const.FLOATINGIP_STATUS_DOWN"},{"line_number":154,"context_line":"                fip_dict.pop(\u0027port_id\u0027)"},{"line_number":155,"context_line":"                fip_dict.pop(\u0027fixed_ip_address\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_fcf99ac7","line":152,"range":{"start_line":151,"start_character":0,"end_line":152,"end_character":76},"in_reply_to":"3f044301_309cc90c","updated":"2017-05-12 02:47:45.000000000","message":"super class not do this.\nThis is a public action, and may super class to do it.","commit_id":"026e7e4ecab4cddfa3355f092ad3ebffe373a90e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"45f095d0ddca4b9786d9a59c4f3b6e29427d600b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"                disassociate_floatingips(context, port_id, do_notify)"},{"line_number":150,"context_line":"            for fip_dict in fip_dicts:"},{"line_number":151,"context_line":"                fip_dict[\u0027status\u0027] \u003d q_const.FLOATINGIP_STATUS_DOWN"},{"line_number":152,"context_line":"                fip_dict.pop(\u0027port_id\u0027)"},{"line_number":153,"context_line":"                fip_dict.pop(\u0027fixed_ip_address\u0027)"},{"line_number":154,"context_line":"                fip_dict.pop(\u0027router_id\u0027)"},{"line_number":155,"context_line":"                journal.record(context, odl_const.ODL_FLOATINGIP,"},{"line_number":156,"context_line":"                               fip_dict[\u0027id\u0027], odl_const.ODL_UPDATE, fip_dict)"},{"line_number":157,"context_line":"        return router_ids"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_0637a9e5","line":154,"range":{"start_line":152,"start_character":0,"end_line":154,"end_character":41},"updated":"2017-05-19 19:05:09.000000000","message":"They are all None, so it isn\u0027t necessary to pop them.\nI suppose it\u0027s for bug work around.\nCan you do this by networking_odl.commo.filters?\nadd filter for fip with _filter_numapped_null of them.","commit_id":"fa7a673d9ae64e0c0dc47331f5370c730b01c521"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"e73eb4fe8753a8c244f9f7df61e9497cb5ab9e2b","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                fip_dict[\u0027status\u0027] \u003d q_const.FLOATINGIP_STATUS_DOWN"},{"line_number":156,"context_line":"                self.update_floatingip_status(context, fip_dict[\u0027id\u0027],"},{"line_number":157,"context_line":"                                              fip_dict[\u0027status\u0027])"},{"line_number":158,"context_line":"                odl_filters._filter_unmapped_null("},{"line_number":159,"context_line":"                    fip_dict, [\u0027port_id\u0027, \u0027fixed_ip_address\u0027, \u0027router_id\u0027])"},{"line_number":160,"context_line":"                journal.record(context, odl_const.ODL_FLOATINGIP,"},{"line_number":161,"context_line":"                               fip_dict[\u0027id\u0027], odl_const.ODL_UPDATE, fip_dict)"},{"line_number":162,"context_line":"        return router_ids"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_94d06b21","line":159,"range":{"start_line":158,"start_character":0,"end_line":159,"end_character":75},"updated":"2017-06-01 14:20:43.000000000","message":"Please update common/filter.py\nadd a method fiilter for floatingip and _FILTER_MAP","commit_id":"a27e4da74539658af6f9182e819bfb57b528b19d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8aaa2f7c4e6d665a41bfb6fc9011d0010d8b70f0","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                fip_dict[\u0027status\u0027] \u003d q_const.FLOATINGIP_STATUS_DOWN"},{"line_number":164,"context_line":"                self.update_floatingip_status(context, fip_dict[\u0027id\u0027],"},{"line_number":165,"context_line":"                                              fip_dict[\u0027status\u0027])"},{"line_number":166,"context_line":"                odl_filters._filter_unmapped_null("},{"line_number":167,"context_line":"                    fip_dict, [\u0027port_id\u0027, \u0027fixed_ip_address\u0027, \u0027router_id\u0027])"},{"line_number":168,"context_line":"                journal.record(context, odl_const.ODL_FLOATINGIP,"},{"line_number":169,"context_line":"                               fip_dict[\u0027id\u0027], odl_const.ODL_UPDATE, fip_dict)"},{"line_number":170,"context_line":"        return router_ids"}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_fa6c6609","line":167,"range":{"start_line":166,"start_character":0,"end_line":167,"end_character":75},"updated":"2017-07-31 22:44:08.000000000","message":"Please update common/filters.py\nthat\u0027s the pattern of v2 driver.","commit_id":"2d33430d97ca36e1364a4944f7448ff0a65e7329"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f9f1606f27f975738398e317b5c0ca43ffc67616","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":156,"context_line":"            fip_dicts \u003d self.get_floatingips(context,"},{"line_number":157,"context_line":"                                             filters\u003d{\u0027port_id\u0027: [port_id]})"},{"line_number":158,"context_line":"            router_ids \u003d super(OpenDaylightL3RouterPlugin, self).\\"},{"line_number":159,"context_line":"                disassociate_floatingips(context, port_id, do_notify)"},{"line_number":160,"context_line":"            for fip_dict in fip_dicts:"},{"line_number":161,"context_line":"                fip_dict \u003d self.get_floatingip(context, fip_dict[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"df3967d1_d0fa3141","line":158,"range":{"start_line":158,"start_character":65,"end_line":158,"end_character":66},"updated":"2017-08-03 21:31:11.000000000","message":"Please don\u0027t use backslash to continue line.","commit_id":"6114f831f504b4575d3b03d8a9df9cc22d1ac213"}]}
