)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"28ed72080c3c382afb1979b47540abf1f596c339","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron-port-dhcp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Interim solution proposed for DHCP proxy service handling"},{"line_number":10,"context_line":"being addresed in ODL. The proposal here deals with"},{"line_number":11,"context_line":"allocating a per subnet neutron port for DHCP request handling"},{"line_number":12,"context_line":"to be serviced by ODL DHCPManager."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_06b74088","line":9,"updated":"2017-06-05 06:15:22.000000000","message":"remove the keyword Interim here..\n\nThis patch implements a dhcp-proxy-service within the networking-odl v2 driver framework.  At the core of this patch is the business logic to create DHCP Neutron ports specifically for use by OpenDaylight\u0027s DHCP Service (these DHCP Neutron ports will be different from DHCP ports allocated by stock Neutron-DHCP-Agent). \n\nAs a result this patch enables OpenDaylight Controller deployments to provide DHCP services using the DHCP Neutron Ports handcrafted by this patch.\n\nThe detailed Openstack Spec is here:\n\u003cgive review link to openstack spec\u003e\n\nThe OpenDaylight-side controller patch that depends on this patch is here:\n\u003cgive the opendaylight patch link here\u003e","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0bea87de4c284095e0ec518ae698018eaa700567","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-09 18:33:21 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron-port-dhcp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements a dhcp-proxy-service within the networking-odl v2"},{"line_number":10,"context_line":"driver framework.  At the core of this patch is the business logic to"},{"line_number":11,"context_line":"create DHCP Neutron ports specifically for use by OpenDaylight\u0027s DHCP"},{"line_number":12,"context_line":"Service (these DHCP Neutron ports will be different from DHCP ports"},{"line_number":13,"context_line":"allocated by stock Neutron-DHCP-Agent)."},{"line_number":14,"context_line":"As a result this patch enables OpenDaylight Controller deployments to"},{"line_number":15,"context_line":"provide DHCP services using the DHCP Neutron Ports handcrafted by this"},{"line_number":16,"context_line":"patch."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The detailed Openstack Spec is here:"},{"line_number":19,"context_line":"https://git.opendaylight.org/gerrit/#/c/52298/"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The OpenDaylight-side controller patch that depends on this patch is"},{"line_number":22,"context_line":"here:"},{"line_number":23,"context_line":"https://git.opendaylight.org/gerrit/#/c/56875/"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id12c86b0a7d5b42395058c7c37bf91bc8205016a"},{"line_number":26,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_24f51e84","line":23,"range":{"start_line":7,"start_character":0,"end_line":23,"end_character":46},"updated":"2017-06-12 23:44:21.000000000","message":"this need to link the bp from launchpad? I suppose its been created, if not then need to create a bp ticket over https://blueprints.launchpad.net/networking-odl, I\u0027d like to follow the openstack way of implementing new features","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":25550,"name":"Achuth","email":"achuth.maniyedath@gmail.com","username":"achuthm"},"change_message_id":"9ee8a116873b7144a056882ed837180c0b4005f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-09 18:33:21 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron-port-dhcp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements a dhcp-proxy-service within the networking-odl v2"},{"line_number":10,"context_line":"driver framework.  At the core of this patch is the business logic to"},{"line_number":11,"context_line":"create DHCP Neutron ports specifically for use by OpenDaylight\u0027s DHCP"},{"line_number":12,"context_line":"Service (these DHCP Neutron ports will be different from DHCP ports"},{"line_number":13,"context_line":"allocated by stock Neutron-DHCP-Agent)."},{"line_number":14,"context_line":"As a result this patch enables OpenDaylight Controller deployments to"},{"line_number":15,"context_line":"provide DHCP services using the DHCP Neutron Ports handcrafted by this"},{"line_number":16,"context_line":"patch."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The detailed Openstack Spec is here:"},{"line_number":19,"context_line":"https://git.opendaylight.org/gerrit/#/c/52298/"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The OpenDaylight-side controller patch that depends on this patch is"},{"line_number":22,"context_line":"here:"},{"line_number":23,"context_line":"https://git.opendaylight.org/gerrit/#/c/56875/"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id12c86b0a7d5b42395058c7c37bf91bc8205016a"},{"line_number":26,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_2ffe0e37","line":23,"range":{"start_line":7,"start_character":0,"end_line":23,"end_character":46},"in_reply_to":"7f231b9d_24f51e84","updated":"2017-06-13 08:48:32.000000000","message":"BP created here, https://blueprints.launchpad.net/networking-odl/+spec/neutron-port-dhcp","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0bea87de4c284095e0ec518ae698018eaa700567","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id12c86b0a7d5b42395058c7c37bf91bc8205016a"},{"line_number":26,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":27,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":28,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":29,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_24c75e48","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":62},"updated":"2017-06-12 23:44:21.000000000","message":"once is enough, remove other 3","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"0947c66221df4d3cb7c647e45721e6afb224aa1a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Id12c86b0a7d5b42395058c7c37bf91bc8205016a"},{"line_number":26,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":27,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":28,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":29,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7f231b9d_2a1ddc65","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":62},"in_reply_to":"7f231b9d_24c75e48","updated":"2017-06-13 11:58:40.000000000","message":"Done","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BP reference:"},{"line_number":19,"context_line":"https://blueprints.launchpad.net/networking-odl/+spec/neutron-port-dhcp"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The detailed Openstack Spec is here:"},{"line_number":22,"context_line":"https://git.opendaylight.org/gerrit/#/c/52298/"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7f231b9d_033de38d","line":20,"updated":"2017-06-16 23:51:40.000000000","message":"Please add\nImplements: blueprint tag\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":26,"context_line":"https://git.opendaylight.org/gerrit/#/c/56875/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Id12c86b0a7d5b42395058c7c37bf91bc8205016a"},{"line_number":29,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"7f231b9d_c3cdabb7","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":62},"updated":"2017-06-16 23:51:40.000000000","message":"openstack doesn\u0027t adapt s-o-b. so please drop this line.","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2017-05-18 01:12:53 +0530"},{"line_number":4,"context_line":"Commit:     karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-06 11:50:41 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron-port-dhcp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements a dhcp-proxy-service within the networking-odl v2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f1d235d_8d7eb2e1","line":6,"updated":"2017-07-06 23:02:10.000000000","message":"Please add release notes and documentation.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2017-05-18 01:12:53 +0530"},{"line_number":4,"context_line":"Commit:     karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-06 11:50:41 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron-port-dhcp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements a dhcp-proxy-service within the networking-odl v2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f1d235d_83cf73af","line":6,"in_reply_to":"3f1d235d_8d7eb2e1","updated":"2017-07-08 19:55:00.000000000","message":"Will add in next patch","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":26,"context_line":"https://git.opendaylight.org/gerrit/#/c/56875/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Id12c86b0a7d5b42395058c7c37bf91bc8205016a"},{"line_number":29,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f1d235d_0d250209","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":62},"updated":"2017-07-06 23:02:10.000000000","message":"Please drop this line as openstack doesn\u0027t adopt s-o-b.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":26,"context_line":"https://git.opendaylight.org/gerrit/#/c/56875/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Id12c86b0a7d5b42395058c7c37bf91bc8205016a"},{"line_number":29,"context_line":"Signed-off-by: karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"3f1d235d_c33a0b97","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":62},"in_reply_to":"3f1d235d_0d250209","updated":"2017-07-08 19:55:00.000000000","message":"Done","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8df3abfd881a52bfe15f55c16abac0a3279b70e4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"patch."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BP reference:"},{"line_number":19,"context_line":"https://blueprints.launchpad.net/networking-odl/+spec/neutron-port-dhcp"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The detailed Openstack Spec is here:"},{"line_number":22,"context_line":"https://git.opendaylight.org/gerrit/#/c/52298/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"1f1a1f67_df69c18b","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":71},"updated":"2017-07-12 18:43:42.000000000","message":"you don\u0027t need to put entire link of BP here, OpenStack commit message has some guidelines [1]. can be referred.\n\njust need to add Implements: blueprint neutron-port-dhcp\n\n[1]. https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":16,"context_line":"patch."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"BP reference:"},{"line_number":19,"context_line":"https://blueprints.launchpad.net/networking-odl/+spec/neutron-port-dhcp"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The detailed Openstack Spec is here:"},{"line_number":22,"context_line":"https://git.opendaylight.org/gerrit/#/c/52298/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"1f1a1f67_aef25805","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":71},"in_reply_to":"1f1a1f67_df69c18b","updated":"2017-07-13 07:17:54.000000000","message":"OK, Thanks for sharing the link will update Commit message accordingly in PS","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-20 01:26:57 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron-port-dhcp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements a dhcp-proxy-service within the networking-odl v2"},{"line_number":10,"context_line":"driver framework.  At the core of this patch is the business logic to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1f1a1f67_0f4a4f7f","line":7,"updated":"2017-07-21 09:09:45.000000000","message":"Enabling support for DHCP Service on OpenDaylight Controller","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     karthik.prasad \u003ckarthik.p@altencalsoftlabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-20 01:26:57 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron-port-dhcp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements a dhcp-proxy-service within the networking-odl v2"},{"line_number":10,"context_line":"driver framework.  At the core of this patch is the business logic to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1f1a1f67_f85a3728","line":7,"in_reply_to":"1f1a1f67_0f4a4f7f","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":7,"context_line":"neutron-port-dhcp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements a dhcp-proxy-service within the networking-odl v2"},{"line_number":10,"context_line":"driver framework.  At the core of this patch is the business logic to"},{"line_number":11,"context_line":"create DHCP Neutron ports specifically for use by OpenDaylight\u0027s DHCP"},{"line_number":12,"context_line":"Service (these DHCP Neutron ports will be different from DHCP ports"},{"line_number":13,"context_line":"allocated by stock Neutron-DHCP-Agent)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1f1a1f67_f2113855","line":10,"updated":"2017-07-21 09:09:45.000000000","message":"This is an enhancement to the existing ODL ML2 Driver, wherein it will create Neutron Ports that are of \u0027dhcp\u0027 device_owner, and such ports would be used by OpenDaylight Controller to provide DHCP Service.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"neutron-port-dhcp"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements a dhcp-proxy-service within the networking-odl v2"},{"line_number":10,"context_line":"driver framework.  At the core of this patch is the business logic to"},{"line_number":11,"context_line":"create DHCP Neutron ports specifically for use by OpenDaylight\u0027s DHCP"},{"line_number":12,"context_line":"Service (these DHCP Neutron ports will be different from DHCP ports"},{"line_number":13,"context_line":"allocated by stock Neutron-DHCP-Agent)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1f1a1f67_b83cbfbf","line":10,"in_reply_to":"1f1a1f67_f2113855","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":10,"context_line":"driver framework.  At the core of this patch is the business logic to"},{"line_number":11,"context_line":"create DHCP Neutron ports specifically for use by OpenDaylight\u0027s DHCP"},{"line_number":12,"context_line":"Service (these DHCP Neutron ports will be different from DHCP ports"},{"line_number":13,"context_line":"allocated by stock Neutron-DHCP-Agent)."},{"line_number":14,"context_line":"As a result this patch enables OpenDaylight Controller deployments to"},{"line_number":15,"context_line":"provide DHCP services using the DHCP Neutron Ports handcrafted by this"},{"line_number":16,"context_line":"patch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1f1a1f67_12827450","line":13,"updated":"2017-07-21 09:09:45.000000000","message":"the Neutron Ports created for each subnet here are for specific use only by the OpenDaylight Controller DHCP service.  Running stock DHCP Service of Openstack will continue to be supported with OpenDaylight deployments, but neutron dhcp ports used by that stock DHCP Service are different and will continue to be owned and used by the stock DHCP service.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"driver framework.  At the core of this patch is the business logic to"},{"line_number":11,"context_line":"create DHCP Neutron ports specifically for use by OpenDaylight\u0027s DHCP"},{"line_number":12,"context_line":"Service (these DHCP Neutron ports will be different from DHCP ports"},{"line_number":13,"context_line":"allocated by stock Neutron-DHCP-Agent)."},{"line_number":14,"context_line":"As a result this patch enables OpenDaylight Controller deployments to"},{"line_number":15,"context_line":"provide DHCP services using the DHCP Neutron Ports handcrafted by this"},{"line_number":16,"context_line":"patch."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1f1a1f67_387aef87","line":13,"in_reply_to":"1f1a1f67_12827450","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":13,"context_line":"allocated by stock Neutron-DHCP-Agent)."},{"line_number":14,"context_line":"As a result this patch enables OpenDaylight Controller deployments to"},{"line_number":15,"context_line":"provide DHCP services using the DHCP Neutron Ports handcrafted by this"},{"line_number":16,"context_line":"patch."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: neutron-port-dhcp"},{"line_number":19,"context_line":"Change-Id: Id12c86b0a7d5b42395058c7c37bf91bc8205016a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1f1a1f67_1226f4b8","line":16,"updated":"2017-07-21 09:09:45.000000000","message":"the second para can be removed.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"allocated by stock Neutron-DHCP-Agent)."},{"line_number":14,"context_line":"As a result this patch enables OpenDaylight Controller deployments to"},{"line_number":15,"context_line":"provide DHCP services using the DHCP Neutron Ports handcrafted by this"},{"line_number":16,"context_line":"patch."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: neutron-port-dhcp"},{"line_number":19,"context_line":"Change-Id: Id12c86b0a7d5b42395058c7c37bf91bc8205016a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"1f1a1f67_b865dfe3","line":16,"in_reply_to":"1f1a1f67_1226f4b8","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"}],"doc/source/install/installation.rst":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9481f7a601aabaeaec3485770692f9a79910bc84","unresolved":false,"context_lines":[{"line_number":174,"context_line":"     networking-odl driver can supply special neutron ports of \u0027dhcp\u0027 type to"},{"line_number":175,"context_line":"     OpenDaylight Controller for its use in providing DHCP Service, otherwise"},{"line_number":176,"context_line":"     by  default flags are set to False if OpenDaylight based DHCP Service is"},{"line_number":177,"context_line":"     not used. Refer `Netvirt DHCP Service Spec \u003chttp://docs.opendaylight.org/"},{"line_number":178,"context_line":"     en/latest/submodules/netvirt/docs/specs/"},{"line_number":179,"context_line":"     neutron-port-for-dhcp-service.html\u003e`_ for more info."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"     .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":40,"id":"ff346bd7_fab55dce","line":178,"range":{"start_line":177,"start_character":47,"end_line":178,"end_character":45},"updated":"2017-07-25 20:44:12.000000000","message":"this link may not work properly, I\u0027d keep it in single line","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"f13ceae746c917a8b12dee4684745f268b7cbe78","unresolved":false,"context_lines":[{"line_number":174,"context_line":"     networking-odl driver can supply special neutron ports of \u0027dhcp\u0027 type to"},{"line_number":175,"context_line":"     OpenDaylight Controller for its use in providing DHCP Service, otherwise"},{"line_number":176,"context_line":"     by  default flags are set to False if OpenDaylight based DHCP Service is"},{"line_number":177,"context_line":"     not used. Refer `Netvirt DHCP Service Spec \u003chttp://docs.opendaylight.org/"},{"line_number":178,"context_line":"     en/latest/submodules/netvirt/docs/specs/"},{"line_number":179,"context_line":"     neutron-port-for-dhcp-service.html\u003e`_ for more info."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"     .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":40,"id":"ff346bd7_d7282435","line":178,"range":{"start_line":177,"start_character":47,"end_line":178,"end_character":45},"in_reply_to":"ff346bd7_3bd64751","updated":"2017-07-26 06:00:24.000000000","message":"Better to restatte above as:\n\nIf we need OpenDaylight Controller to provide DHCP Service to tenants in an OpenDaylight-enabled cloud, we need to set \u0027enable_dhcp_service\u003dTrue\u0027 under the [ml2_odl] section of /etc/neutron/plugins/ml2/ml2_conf.ini.\n\nBy doing so, the ODL Driver would create \u0027dhcp\u0027 type Neutron Ports for use by the OpenDaylight Controller\u0027s DHCP Service module (which is within the NetVirt project of OpenDaylight controller).\n\nIn addition to doing so, we need to set \u0027controller-dhcp-enabled \u003d True\u0027 within the OpenDaylight Controller\u0027s dhcp service configuration file i.e., netvirt-dhcpservice-config.xml.\n\nOpenDaylight Documentation Link: \u003cgive link\u003e","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ee16d3ada694188950161cd1147d2e7fe1807de4","unresolved":false,"context_lines":[{"line_number":174,"context_line":"     networking-odl driver can supply special neutron ports of \u0027dhcp\u0027 type to"},{"line_number":175,"context_line":"     OpenDaylight Controller for its use in providing DHCP Service, otherwise"},{"line_number":176,"context_line":"     by  default flags are set to False if OpenDaylight based DHCP Service is"},{"line_number":177,"context_line":"     not used. Refer `Netvirt DHCP Service Spec \u003chttp://docs.opendaylight.org/"},{"line_number":178,"context_line":"     en/latest/submodules/netvirt/docs/specs/"},{"line_number":179,"context_line":"     neutron-port-for-dhcp-service.html\u003e`_ for more info."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"     .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":40,"id":"ff346bd7_f1e9ed19","line":178,"range":{"start_line":177,"start_character":47,"end_line":178,"end_character":45},"in_reply_to":"ff346bd7_d7282435","updated":"2017-07-26 10:15:29.000000000","message":"Done","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"     networking-odl driver can supply special neutron ports of \u0027dhcp\u0027 type to"},{"line_number":175,"context_line":"     OpenDaylight Controller for its use in providing DHCP Service, otherwise"},{"line_number":176,"context_line":"     by  default flags are set to False if OpenDaylight based DHCP Service is"},{"line_number":177,"context_line":"     not used. Refer `Netvirt DHCP Service Spec \u003chttp://docs.opendaylight.org/"},{"line_number":178,"context_line":"     en/latest/submodules/netvirt/docs/specs/"},{"line_number":179,"context_line":"     neutron-port-for-dhcp-service.html\u003e`_ for more info."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"     .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":40,"id":"ff346bd7_3bd64751","line":178,"range":{"start_line":177,"start_character":47,"end_line":178,"end_character":45},"in_reply_to":"ff346bd7_fab55dce","updated":"2017-07-25 21:20:12.000000000","message":"Thought there was 80 character limit imposed, moving to single line similar #50","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a0e5370ad678152638a99f6db7a26ab44e9721ff","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        url \u003d http://\u003cODL_IP_ADDRESS\u003e:\u003cODL_PORT\u003e/controller/nb/v2/neutron"},{"line_number":168,"context_line":"        port_binding_controller \u003d pseudo-agentdb-binding"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"   * Optionally, If we need OpenDaylight Controller to provide DHCP Service to"},{"line_number":171,"context_line":"     tenants in an OpenDaylight-enabled cloud, we need to set"},{"line_number":172,"context_line":"     ``enable_dhcp_service\u003dTrue`` under the ``[ml2_odl]`` section of"},{"line_number":173,"context_line":"     ``/etc/neutron/plugins/ml2/ml2_conf.ini``. By doing so, the ODL Driver"},{"line_number":174,"context_line":"     would create ``dhcp`` type Neutron Ports for use by the OpenDaylight"}],"source_content_type":"text/x-rst","patch_set":44,"id":"ff346bd7_1c97ddee","line":171,"range":{"start_line":170,"start_character":76,"end_line":171,"end_character":12},"updated":"2017-07-26 16:34:53.000000000","message":"I\u0027d suggest not to use tenant here, as it is deprecated with keystone we, I think it\u0027ll be okay to remove to tenants from phrase","commit_id":"c467e9879d777c71e0c39bc557b3852de351e982"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"6d002b892f5c5981d6e92cacc7c078fe5079a246","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        url \u003d http://\u003cODL_IP_ADDRESS\u003e:\u003cODL_PORT\u003e/controller/nb/v2/neutron"},{"line_number":168,"context_line":"        port_binding_controller \u003d pseudo-agentdb-binding"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"   * Optionally, If we need OpenDaylight Controller to provide DHCP Service to"},{"line_number":171,"context_line":"     tenants in an OpenDaylight-enabled cloud, we need to set"},{"line_number":172,"context_line":"     ``enable_dhcp_service\u003dTrue`` under the ``[ml2_odl]`` section of"},{"line_number":173,"context_line":"     ``/etc/neutron/plugins/ml2/ml2_conf.ini``. By doing so, the ODL Driver"},{"line_number":174,"context_line":"     would create ``dhcp`` type Neutron Ports for use by the OpenDaylight"}],"source_content_type":"text/x-rst","patch_set":44,"id":"ff346bd7_ee11f45e","line":171,"range":{"start_line":170,"start_character":76,"end_line":171,"end_character":12},"in_reply_to":"ff346bd7_1c97ddee","updated":"2017-07-26 20:17:34.000000000","message":"keystone v3","commit_id":"c467e9879d777c71e0c39bc557b3852de351e982"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a0e5370ad678152638a99f6db7a26ab44e9721ff","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        url \u003d http://\u003cODL_IP_ADDRESS\u003e:\u003cODL_PORT\u003e/controller/nb/v2/neutron"},{"line_number":168,"context_line":"        port_binding_controller \u003d pseudo-agentdb-binding"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"   * Optionally, If we need OpenDaylight Controller to provide DHCP Service to"},{"line_number":171,"context_line":"     tenants in an OpenDaylight-enabled cloud, we need to set"},{"line_number":172,"context_line":"     ``enable_dhcp_service\u003dTrue`` under the ``[ml2_odl]`` section of"},{"line_number":173,"context_line":"     ``/etc/neutron/plugins/ml2/ml2_conf.ini``. By doing so, the ODL Driver"},{"line_number":174,"context_line":"     would create ``dhcp`` type Neutron Ports for use by the OpenDaylight"},{"line_number":175,"context_line":"     Controller\u0027s DHCP Service module (which is within the NetVirt project of"},{"line_number":176,"context_line":"     OpenDaylight controller). In addition to doing so, we need to set"},{"line_number":177,"context_line":"     ``controller-dhcp-enabled \u003d True`` within the OpenDaylight Controller\u0027s"},{"line_number":178,"context_line":"     dhcp service configuration file i.e., ``netvirt-dhcpservice-config.xml``."},{"line_number":179,"context_line":"     `OpenDaylight Spec Documentation Link: \u003chttp://docs.opendaylight.org/en/latest/submodules/netvirt/docs/specs/neutron-port-for-dhcp-service.html\u003e`_."},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"     .. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":44,"id":"ff346bd7_b7a7ca0b","line":178,"range":{"start_line":170,"start_character":6,"end_line":178,"end_character":78},"updated":"2017-07-26 16:34:53.000000000","message":"how about making it more simple,\n\n`Optionally, To enable ODL DHCP service in an ODL enabled cloud, set `enable_dhcp_service\u003dTrue` under the `[ml2_odl]` section of `/etc/neutron/plugins/ml2/ml2_conf.ini`. It will enable ODL DHCP driver and create neutron dhcp ports for use by ODL to provide the DHCP service. In addition to doing so, set `controller-dhcp-enabled \u003d True` within the ODL Controller\u0027s dhcp service configuration file i.e., ``netvirt-dhcpservice-config.xml``","commit_id":"c467e9879d777c71e0c39bc557b3852de351e982"}],"doc/source/installation.rst":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"   * Optionally, to allocate a neutron port for each subnet to service DHCP"},{"line_number":171,"context_line":"     requests within OpendDaylight controller DHCP service set"},{"line_number":172,"context_line":"     ``enable_dhcp_port \u003d True`` in ``ml2_odl`` section."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"     .. code-block:: ini"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":34,"id":"1f1a1f67_d69d4258","line":172,"range":{"start_line":172,"start_character":56,"end_line":172,"end_character":56},"updated":"2017-07-20 04:44:00.000000000","message":"Please refer to review comment on the previous patch.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        [ml2_odl]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        ..."},{"line_number":179,"context_line":"        enable_dhcp_port \u003d True"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Compute/network nodes"},{"line_number":182,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":34,"id":"1f1a1f67_12b6f4da","line":179,"updated":"2017-07-21 09:09:45.000000000","message":"please fix the content here according to comments in config.py file and commit message","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        [ml2_odl]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        ..."},{"line_number":179,"context_line":"        enable_dhcp_port \u003d True"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"Compute/network nodes"},{"line_number":182,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":34,"id":"1f1a1f67_b8aa7fcf","line":179,"in_reply_to":"1f1a1f67_12b6f4da","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"9c25c9ba35bf528d05e73e1a17ac6cdf722d8b65","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"   * Optionally, for networking-odl driver to supply special neutron ports of"},{"line_number":171,"context_line":"     \u0027dhcp\u0027 type to OpenDaylight Controller for its use in providing DHCP"},{"line_number":172,"context_line":"     Service set ``enable_dhcp_service \u003d True`` in ``ml2_odl`` section."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"     .. code-block:: ini"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":36,"id":"ff346bd7_c291c054","line":172,"updated":"2017-07-24 16:12:02.000000000","message":"Let the first statement be:\nIf we want to configure ODL Controller to provide DHCP Service, we need to set enable_dhcp_service to True.\n\n, and then the above can be next statement.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"   * Optionally, for networking-odl driver to supply special neutron ports of"},{"line_number":171,"context_line":"     \u0027dhcp\u0027 type to OpenDaylight Controller for its use in providing DHCP"},{"line_number":172,"context_line":"     Service set ``enable_dhcp_service \u003d True`` in ``ml2_odl`` section."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"     .. code-block:: ini"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-rst","patch_set":36,"id":"ff346bd7_10b272e7","line":172,"in_reply_to":"ff346bd7_c291c054","updated":"2017-07-24 17:39:45.000000000","message":"+1.\n\nCan you please include pointers to the ODL dhcp server features?\nAlso please include when to enable/disable this option.\nThe description only tells the existence of the option.\nThis option makes sense only with ODL netvirt dhcp server. \n\nWith this description, it\u0027s quite difficult for cloud admin or developer to understand when to enable/disable this feature.\nFor example,\nIf you setup ODL netvirt dhcp option with the configuation file xxxx/option xxx\u003dxxx, set this option to True. for details, see the link of xxx.\nOtherwise or by default, set this option to False.\n\nSimilar to the releasenotes.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"}],"networking_odl/common/config.py":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d_(\"Poll interval in seconds for getting ODL hostconfig\")),"},{"line_number":60,"context_line":"    cfg.BoolOpt(\u0027enable_websocket_pseudo_agentdb\u0027, default\u003dFalse,"},{"line_number":61,"context_line":"                help\u003d_(\u0027Enable websocket for pseudo-agent-port-binding.\u0027)),"},{"line_number":62,"context_line":"    cfg.BoolOpt(\u0027enable_netvirt_port\u0027, default\u003dFalse,"},{"line_number":63,"context_line":"                help\u003d_(\u0027On True creates netvirt port when subnet is created\u0027)),        "},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_0eb3a0ea","line":62,"updated":"2017-06-06 17:09:42.000000000","message":"better to name this as enable_dhcp_proxy with default as False.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.BoolOpt(\u0027enable_websocket_pseudo_agentdb\u0027, default\u003dFalse,"},{"line_number":61,"context_line":"                help\u003d_(\u0027Enable websocket for pseudo-agent-port-binding.\u0027)),"},{"line_number":62,"context_line":"    cfg.BoolOpt(\u0027enable_netvirt_port\u0027, default\u003dFalse,"},{"line_number":63,"context_line":"                help\u003d_(\u0027On True creates netvirt port when subnet is created\u0027)),        "},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"cfg.CONF.register_opts(odl_opts, \"ml2_odl\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_8ebe90ab","line":63,"updated":"2017-06-06 17:09:42.000000000","message":"On True, runs a dhcp proxy service that manages custom DHCP ports for consumption by ODL, for each dhcp-enabled-subnet.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               help\u003d_(\"Poll interval in seconds for getting ODL hostconfig\")),"},{"line_number":60,"context_line":"    cfg.BoolOpt(\u0027enable_websocket_pseudo_agentdb\u0027, default\u003dFalse,"},{"line_number":61,"context_line":"                help\u003d_(\u0027Enable websocket for pseudo-agent-port-binding.\u0027)),"},{"line_number":62,"context_line":"    cfg.BoolOpt(\u0027enable_dhcp_proxy\u0027, default\u003dFalse,"},{"line_number":63,"context_line":"                help\u003d_(\"On True, runs a dhcp proxy service that manages custom\""},{"line_number":64,"context_line":"                       \" DHCP ports for consumption by ODL, for each \""},{"line_number":65,"context_line":"                       \"dhcp-enabled-subnet.\")),"},{"line_number":66,"context_line":"]"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"cfg.CONF.register_opts(odl_opts, \"ml2_odl\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_8348d32c","line":65,"range":{"start_line":62,"start_character":0,"end_line":65,"end_character":48},"updated":"2017-06-16 23:51:40.000000000","message":"This is user visible change, please add release notes and update documentation.","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                help\u003d\u0027A list of features supported by ODL\u0027),"},{"line_number":67,"context_line":"    cfg.BoolOpt(\u0027enable_dhcp_port\u0027, default\u003dFalse,"},{"line_number":68,"context_line":"                help\u003d_(\"On True, runs a dhcp proxy service that manages custom\""},{"line_number":69,"context_line":"                       \" DHCP ports for consumption by ODL, for each \""},{"line_number":70,"context_line":"                       \"dhcp-enabled-subnet.\"))"},{"line_number":71,"context_line":"]"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_bf478e4c","line":69,"range":{"start_line":69,"start_character":55,"end_line":69,"end_character":58},"updated":"2017-07-18 04:46:18.000000000","message":"Can you please revise wording?\nespecially what feature of ODL will be used.\nOtherwise people will be confused if this should be enabled or not.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                      \" fetch\")),"},{"line_number":65,"context_line":"    cfg.ListOpt(\u0027odl_features\u0027, item_type\u003dstr,"},{"line_number":66,"context_line":"                help\u003d\u0027A list of features supported by ODL\u0027),"},{"line_number":67,"context_line":"    cfg.BoolOpt(\u0027enable_dhcp_port\u0027, default\u003dFalse,"},{"line_number":68,"context_line":"                help\u003d_(\"Enable to allocate a neutron port for each subnet, to\""},{"line_number":69,"context_line":"                       \" service DHCP requests within OpendDaylight controller\""},{"line_number":70,"context_line":"                       \" DHCP service.\"))"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_56bb72c3","line":67,"range":{"start_line":67,"start_character":17,"end_line":67,"end_character":33},"updated":"2017-07-20 04:44:00.000000000","message":"Please see comment on the previous patch.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                      \" fetch\")),"},{"line_number":65,"context_line":"    cfg.ListOpt(\u0027odl_features\u0027, item_type\u003dstr,"},{"line_number":66,"context_line":"                help\u003d\u0027A list of features supported by ODL\u0027),"},{"line_number":67,"context_line":"    cfg.BoolOpt(\u0027enable_dhcp_port\u0027, default\u003dFalse,"},{"line_number":68,"context_line":"                help\u003d_(\"Enable to allocate a neutron port for each subnet, to\""},{"line_number":69,"context_line":"                       \" service DHCP requests within OpendDaylight controller\""},{"line_number":70,"context_line":"                       \" DHCP service.\"))"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_d21d1c10","line":67,"range":{"start_line":67,"start_character":17,"end_line":67,"end_character":33},"in_reply_to":"1f1a1f67_56bb72c3","updated":"2017-07-21 09:09:45.000000000","message":"would \u0027enable_dhcp_service\u0027 be a better config parameter name? \nActually we need this set to True whenever DHCP Service is enabled inside Opendaylight Controller.\n\nWhen deployers use stock DHCP with OpenDaylight, this flag can continue to be defaulted to False.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.ListOpt(\u0027odl_features\u0027, item_type\u003dstr,"},{"line_number":66,"context_line":"                help\u003d\u0027A list of features supported by ODL\u0027),"},{"line_number":67,"context_line":"    cfg.BoolOpt(\u0027enable_dhcp_port\u0027, default\u003dFalse,"},{"line_number":68,"context_line":"                help\u003d_(\"Enable to allocate a neutron port for each subnet, to\""},{"line_number":69,"context_line":"                       \" service DHCP requests within OpendDaylight controller\""},{"line_number":70,"context_line":"                       \" DHCP service.\"))"},{"line_number":71,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_12ba74dd","line":68,"updated":"2017-07-21 09:09:45.000000000","message":"Enables the networking-odl driver to supply special neutron ports of \u0027dhcp\u0027 type to OpenDaylight Controller for its use in providing DHCP Service.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.ListOpt(\u0027odl_features\u0027, item_type\u003dstr,"},{"line_number":66,"context_line":"                help\u003d\u0027A list of features supported by ODL\u0027),"},{"line_number":67,"context_line":"    cfg.BoolOpt(\u0027enable_dhcp_port\u0027, default\u003dFalse,"},{"line_number":68,"context_line":"                help\u003d_(\"Enable to allocate a neutron port for each subnet, to\""},{"line_number":69,"context_line":"                       \" service DHCP requests within OpendDaylight controller\""},{"line_number":70,"context_line":"                       \" DHCP service.\"))"},{"line_number":71,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_78bbc70d","line":68,"in_reply_to":"1f1a1f67_12ba74dd","updated":"2017-07-21 09:52:28.000000000","message":"OK, This sounds good.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"}],"networking_odl/common/constants.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":82,"context_line":"PENDING \u003d \u0027pending\u0027"},{"line_number":83,"context_line":"PROCESSING \u003d \u0027processing\u0027"},{"line_number":84,"context_line":"FAILED \u003d \u0027failed\u0027"},{"line_number":85,"context_line":"BEFORE_COMPLETE \u003d \u0027before_complete\u0027"},{"line_number":86,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# dict to store url mappings"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_3f6dbecb","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":35},"updated":"2017-07-18 04:46:18.000000000","message":"This should not be here because BEFORE_COMPLETE is event for callbacks. On the other hand line 82-86 is journal entry status.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":82,"context_line":"PENDING \u003d \u0027pending\u0027"},{"line_number":83,"context_line":"PROCESSING \u003d \u0027processing\u0027"},{"line_number":84,"context_line":"FAILED \u003d \u0027failed\u0027"},{"line_number":85,"context_line":"BEFORE_COMPLETE \u003d \u0027before_complete\u0027"},{"line_number":86,"context_line":"COMPLETED \u003d \u0027completed\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# dict to store url mappings"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_b58fafcb","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":35},"in_reply_to":"1f1a1f67_3f6dbecb","updated":"2017-07-18 15:46:56.000000000","message":"Done","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"}],"networking_odl/common/journal_callback.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"1e39ffd3e79c10a4b71872f16d27ec5bd65cb2d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3f1d235d_3da128f9","updated":"2017-07-06 09:37:34.000000000","message":"Why do you need this as decorator? Seems like an unnecessary complication.\n\nThese can simply be functions you call to.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3f1d235d_b152dc33","in_reply_to":"3f1d235d_103995d5","updated":"2017-07-08 19:55:00.000000000","message":"Sure","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"319330939826b6d22e32db84f443234b18254534","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3f1d235d_8a4d823f","in_reply_to":"3f1d235d_3da128f9","updated":"2017-07-06 16:25:09.000000000","message":"Can you please elaborate a bit.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3f1d235d_103995d5","in_reply_to":"3f1d235d_8a4d823f","updated":"2017-07-06 23:02:10.000000000","message":"I\u0027ve thought just registry.callback will do.\ne.g. registory.notify(resource.JOURNAL, event.BEFORE_COMPLETE, journal, session\u003dsession, row\u003drow)","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            if row:"},{"line_number":31,"context_line":"                method_name \u003d row.operation + \u0027_\u0027 + row.object_type"},{"line_number":32,"context_line":"                try:"},{"line_number":33,"context_line":"                    for i in range(2):"},{"line_number":34,"context_line":"                        if call_subscriber(args[0], r, method_name, row):"},{"line_number":35,"context_line":"                            return result"},{"line_number":36,"context_line":"                except AttributeError:"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_507f0d65","line":33,"range":{"start_line":33,"start_character":29,"end_line":33,"end_character":37},"updated":"2017-07-06 23:02:10.000000000","message":"why loop twice?\nIs there any special meaning?","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            if row:"},{"line_number":31,"context_line":"                method_name \u003d row.operation + \u0027_\u0027 + row.object_type"},{"line_number":32,"context_line":"                try:"},{"line_number":33,"context_line":"                    for i in range(2):"},{"line_number":34,"context_line":"                        if call_subscriber(args[0], r, method_name, row):"},{"line_number":35,"context_line":"                            return result"},{"line_number":36,"context_line":"                except AttributeError:"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_11107056","line":33,"range":{"start_line":33,"start_character":29,"end_line":33,"end_character":37},"in_reply_to":"3f1d235d_507f0d65","updated":"2017-07-08 19:55:00.000000000","message":"Retry if there are any errors. prevent error being thrown to Journal sync","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"}],"networking_odl/db/db.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"1e39ffd3e79c10a4b71872f16d27ec5bd65cb2d5","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":107,"context_line":"@journal_callback.journal_callback"},{"line_number":108,"context_line":"def update_db_row_state(session, row, state):"},{"line_number":109,"context_line":"    row.state \u003d state"},{"line_number":110,"context_line":"    session.merge(row)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_fd585031","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":34},"updated":"2017-07-06 09:37:34.000000000","message":"This doesn\u0027t belong in the DB layer..","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":107,"context_line":"@journal_callback.journal_callback"},{"line_number":108,"context_line":"def update_db_row_state(session, row, state):"},{"line_number":109,"context_line":"    row.state \u003d state"},{"line_number":110,"context_line":"    session.merge(row)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_fc382bd3","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":34},"in_reply_to":"3f1d235d_eda9a623","updated":"2017-07-08 19:55:00.000000000","message":"Ok. sure, thought it will be easy to refactor rather than add callbacks in multiple places in Journal, once RPC is in place.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"@oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES)"},{"line_number":107,"context_line":"@journal_callback.journal_callback"},{"line_number":108,"context_line":"def update_db_row_state(session, row, state):"},{"line_number":109,"context_line":"    row.state \u003d state"},{"line_number":110,"context_line":"    session.merge(row)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_eda9a623","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":34},"in_reply_to":"3f1d235d_fd585031","updated":"2017-07-06 23:02:10.000000000","message":"+1.\nwe can directly insert hooks into OpendaylightJournalThread.sync_pending_entries().","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"}],"networking_odl/dhcp/odl_dhcp_driver.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c3a7a333cc9f64b3977acc072af2b380f117347","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class OdlDhcpDriver(object):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @staticmethod"},{"line_number":35,"context_line":"    def create():"},{"line_number":36,"context_line":"        return OdlDhcpDriver()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def create_dhcp_port(self, context):"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_d45088d7","line":36,"range":{"start_line":34,"start_character":0,"end_line":36,"end_character":30},"updated":"2017-07-12 17:19:55.000000000","message":"This isn\u0027t used.","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8df3abfd881a52bfe15f55c16abac0a3279b70e4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027]:"},{"line_number":41,"context_line":"            LOG.debug(\"Creating DHCP Proxy port for subnet %s of network %s\","},{"line_number":42,"context_line":"                      context.current[\u0027network_id\u0027], context.current[\u0027id\u0027])"},{"line_number":43,"context_line":"            port_id \u003d self._get_port_id(context)"},{"line_number":44,"context_line":"            if not port_id:"},{"line_number":45,"context_line":"                port \u003d self._make_dhcp_port_dict(context)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_1f5cd949","line":42,"range":{"start_line":42,"start_character":22,"end_line":42,"end_character":74},"updated":"2017-07-12 18:43:42.000000000","message":"this should be swapped ?","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027]:"},{"line_number":41,"context_line":"            LOG.debug(\"Creating DHCP Proxy port for subnet %s of network %s\","},{"line_number":42,"context_line":"                      context.current[\u0027network_id\u0027], context.current[\u0027id\u0027])"},{"line_number":43,"context_line":"            port_id \u003d self._get_port_id(context)"},{"line_number":44,"context_line":"            if not port_id:"},{"line_number":45,"context_line":"                port \u003d self._make_dhcp_port_dict(context)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_eed17059","line":42,"range":{"start_line":42,"start_character":22,"end_line":42,"end_character":74},"in_reply_to":"1f1a1f67_1f5cd949","updated":"2017-07-13 07:17:54.000000000","message":"Oops","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c3a7a333cc9f64b3977acc072af2b380f117347","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                              context._plugin_context,"},{"line_number":61,"context_line":"                              port_id)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        port_id \u003d self._get_port_id(context)"},{"line_number":66,"context_line":"        if port_id:"},{"line_number":67,"context_line":"            self._delete_port(context._plugin,"},{"line_number":68,"context_line":"                              context._plugin_context,"},{"line_number":69,"context_line":"                              port_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _make_dhcp_port_dict(self, context):"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_d4b40838","line":69,"range":{"start_line":63,"start_character":0,"end_line":69,"end_character":38},"updated":"2017-07-12 17:19:55.000000000","message":"I don\u0027t see any caller.","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                              context._plugin_context,"},{"line_number":61,"context_line":"                              port_id)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        port_id \u003d self._get_port_id(context)"},{"line_number":66,"context_line":"        if port_id:"},{"line_number":67,"context_line":"            self._delete_port(context._plugin,"},{"line_number":68,"context_line":"                              context._plugin_context,"},{"line_number":69,"context_line":"                              port_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _make_dhcp_port_dict(self, context):"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_6ea2009d","line":69,"range":{"start_line":63,"start_character":0,"end_line":69,"end_character":38},"in_reply_to":"1f1a1f67_d4b40838","updated":"2017-07-13 07:17:54.000000000","message":"We might need this PS along with ODL changes for ML2 V1 driver, Hence retaining the common code in this class for seamless transition","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8df3abfd881a52bfe15f55c16abac0a3279b70e4","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    else:"},{"line_number":104,"context_line":"                        ctxt.reraise \u003d True"},{"line_number":105,"context_line":"                if ctxt.reraise:"},{"line_number":106,"context_line":"                    # net_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":107,"context_line":"                    LOG.warning(\"DHCP Proxy Port creation failed %s\", e)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @db_api.retry_db_errors"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_9a88f771","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":57},"updated":"2017-07-12 18:43:42.000000000","message":"remove this comment","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    else:"},{"line_number":104,"context_line":"                        ctxt.reraise \u003d True"},{"line_number":105,"context_line":"                if ctxt.reraise:"},{"line_number":106,"context_line":"                    # net_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":107,"context_line":"                    LOG.warning(\"DHCP Proxy Port creation failed %s\", e)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @db_api.retry_db_errors"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_ce3b549a","line":106,"range":{"start_line":106,"start_character":20,"end_line":106,"end_character":57},"in_reply_to":"1f1a1f67_9a88f771","updated":"2017-07-13 07:17:54.000000000","message":"OK","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8df3abfd881a52bfe15f55c16abac0a3279b70e4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        subnet_id \u003d context.current[\u0027id\u0027]"},{"line_number":115,"context_line":"        device_id \u003d DEVICE_ID + \u0027-\u0027 + subnet_id"},{"line_number":116,"context_line":"        LOG.debug(\"Retrieving DHCP proxy port for subnet %s\", subnet_id)"},{"line_number":117,"context_line":"        port \u003d plugin_context.session.query("},{"line_number":118,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":119,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":120,"context_line":"        if port:"},{"line_number":121,"context_line":"            return port[0]"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_fa76cb3e","line":119,"range":{"start_line":117,"start_character":8,"end_line":119,"end_character":56},"updated":"2017-07-12 18:43:42.000000000","message":"I\u0027d recommend to use get_port_id from plugin if you can and not use do dierct query here.","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        subnet_id \u003d context.current[\u0027id\u0027]"},{"line_number":115,"context_line":"        device_id \u003d DEVICE_ID + \u0027-\u0027 + subnet_id"},{"line_number":116,"context_line":"        LOG.debug(\"Retrieving DHCP proxy port for subnet %s\", subnet_id)"},{"line_number":117,"context_line":"        port \u003d plugin_context.session.query("},{"line_number":118,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":119,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":120,"context_line":"        if port:"},{"line_number":121,"context_line":"            return port[0]"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_208f67cd","line":119,"range":{"start_line":117,"start_character":8,"end_line":119,"end_character":56},"in_reply_to":"1f1a1f67_fa76cb3e","updated":"2017-07-13 07:17:54.000000000","message":"There is no direct way to get port Id, closest API is get_ports_from_devices but it specifically checks device_id either is for VM/router interface or deviceId is UUID, ours is neither of them","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8df3abfd881a52bfe15f55c16abac0a3279b70e4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":119,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":120,"context_line":"        if port:"},{"line_number":121,"context_line":"            return port[0]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @db_api.retry_db_errors"},{"line_number":124,"context_line":"    def _delete_port(self, plugin, context, port_id):"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_bad29333","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":26},"updated":"2017-07-12 18:43:42.000000000","message":"are you sure one_or_none will return a list of one query object ? I doubt that, according to def it returns atmost one query obj or None","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":119,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":120,"context_line":"        if port:"},{"line_number":121,"context_line":"            return port[0]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @db_api.retry_db_errors"},{"line_number":124,"context_line":"    def _delete_port(self, plugin, context, port_id):"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_83b1a592","line":121,"range":{"start_line":121,"start_character":12,"end_line":121,"end_character":26},"in_reply_to":"1f1a1f67_bad29333","updated":"2017-07-13 07:17:54.000000000","message":"Output of the query is (u\u002787405c76-34f1-416b-bd25-2c9b850ea8c6\u0027,)","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                self._create_port("},{"line_number":44,"context_line":"                    context._plugin, context._plugin_context, port)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# NOTE: validating  based on value change of enable_dhcp instead"},{"line_number":47,"context_line":"# validating on port_id presence of port by locking the session, this"},{"line_number":48,"context_line":"# will enable user to reissue the same command in case of failure."},{"line_number":49,"context_line":"    def update_dhcp_port(self, context):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_9fb97216","line":46,"range":{"start_line":46,"start_character":2,"end_line":46,"end_character":7},"updated":"2017-07-18 04:46:18.000000000","message":"NOTE(your name/handle):","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                self._create_port("},{"line_number":44,"context_line":"                    context._plugin, context._plugin_context, port)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# NOTE: validating  based on value change of enable_dhcp instead"},{"line_number":47,"context_line":"# validating on port_id presence of port by locking the session, this"},{"line_number":48,"context_line":"# will enable user to reissue the same command in case of failure."},{"line_number":49,"context_line":"    def update_dhcp_port(self, context):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        port_id \u003d self._get_port_id(context)"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_7f38d69e","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":65},"updated":"2017-07-18 04:46:18.000000000","message":"Indent to right.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                              context._plugin_context,"},{"line_number":58,"context_line":"                              port_id)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        port_id \u003d self._get_port_id(context)"},{"line_number":63,"context_line":"        if port_id:"},{"line_number":64,"context_line":"            self._delete_port(context._plugin,"},{"line_number":65,"context_line":"                              context._plugin_context,"},{"line_number":66,"context_line":"                              port_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _make_dhcp_port_dict(self, context):"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_ff74e669","line":66,"range":{"start_line":60,"start_character":0,"end_line":66,"end_character":38},"updated":"2017-07-18 04:46:18.000000000","message":"Where is this used?","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"78a0a3b7c20438652784433336c24ff96ad575e5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                              context._plugin_context,"},{"line_number":58,"context_line":"                              port_id)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        port_id \u003d self._get_port_id(context)"},{"line_number":63,"context_line":"        if port_id:"},{"line_number":64,"context_line":"            self._delete_port(context._plugin,"},{"line_number":65,"context_line":"                              context._plugin_context,"},{"line_number":66,"context_line":"                              port_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _make_dhcp_port_dict(self, context):"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_a679a1c8","line":66,"range":{"start_line":60,"start_character":0,"end_line":66,"end_character":38},"in_reply_to":"1f1a1f67_99daad48","updated":"2017-07-19 04:49:13.000000000","message":"only bug fixes are accepted to the stable branches.\nanyway please don\u0027t bring backport debt to master branch,\nclean up the patch. drop unused ones and sort out class hiarachy.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                              context._plugin_context,"},{"line_number":58,"context_line":"                              port_id)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        port_id \u003d self._get_port_id(context)"},{"line_number":63,"context_line":"        if port_id:"},{"line_number":64,"context_line":"            self._delete_port(context._plugin,"},{"line_number":65,"context_line":"                              context._plugin_context,"},{"line_number":66,"context_line":"                              port_id)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _make_dhcp_port_dict(self, context):"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_99daad48","line":66,"range":{"start_line":60,"start_character":0,"end_line":66,"end_character":38},"in_reply_to":"1f1a1f67_ff74e669","updated":"2017-07-18 15:46:56.000000000","message":"We wanted this feature to be supported for Mitaka, hence we are using odl_dhcp_driver.py directly in mitaka as mitaka does not support journal. we are not using it in v2 since subnet context would not be available in journal callback.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"1f1a1f67_3697d63d","updated":"2017-07-20 04:44:00.000000000","message":"Maybe we can put two classes into single file.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"1f1a1f67_3dbc21ba","in_reply_to":"1f1a1f67_3697d63d","updated":"2017-07-21 09:09:45.000000000","message":"Isaku,\n\nwe are reusing the non-journal callback file that driver_base for downstream patching. \n\nSo we kindly request your help to retain these as two different files, wherein this file will serve the journal callback and it will use base-class for managing the ports with Neutron DB.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron_lib.plugins import directory"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from networking_odl.common import constants"},{"line_number":24,"context_line":"from networking_odl.dhcp import odl_dhcp_driver_base as dhcp_driver"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo_log import log as logging"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_bd3711e4","line":24,"updated":"2017-07-21 09:09:45.000000000","message":"as driver_base","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron_lib.plugins import directory"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from networking_odl.common import constants"},{"line_number":24,"context_line":"from networking_odl.dhcp import odl_dhcp_driver_base as dhcp_driver"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo_log import log as logging"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_986c639d","line":24,"in_reply_to":"1f1a1f67_bd3711e4","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@registry.has_registry_receivers"},{"line_number":32,"context_line":"class OdlDhcpDriver(dhcp_driver.OdlDhcpDriverBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @registry.receives(constants.ODL_SUBNET, [constants.BEFORE_COMPLETE])"},{"line_number":35,"context_line":"    def handle_subnet_event(self, resource, event, trigger, operation\u003dNone,"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_7d3179ec","line":32,"updated":"2017-07-21 09:09:45.000000000","message":"(driver_base.OdlDhcpDriverBase)","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@registry.has_registry_receivers"},{"line_number":32,"context_line":"class OdlDhcpDriver(dhcp_driver.OdlDhcpDriverBase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @registry.receives(constants.ODL_SUBNET, [constants.BEFORE_COMPLETE])"},{"line_number":35,"context_line":"    def handle_subnet_event(self, resource, event, trigger, operation\u003dNone,"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_58048bc6","line":32,"in_reply_to":"1f1a1f67_7d3179ec","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            with db_api.autonested_transaction(session):"},{"line_number":64,"context_line":"                context \u003d self._get_subnet_context(row.data[\u0027network_id\u0027],"},{"line_number":65,"context_line":"                                                   row.data[\u0027id\u0027])"},{"line_number":66,"context_line":"                self.update_dhcp_port(context)"},{"line_number":67,"context_line":"        except Exception as e:"},{"line_number":68,"context_line":"            LOG.error(\"Error while processing update subnet %s\", e)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_7dbbb90d","line":66,"updated":"2017-07-21 09:09:45.000000000","message":"should invoke as create_or_delete_dhcp_port(context)","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            with db_api.autonested_transaction(session):"},{"line_number":64,"context_line":"                context \u003d self._get_subnet_context(row.data[\u0027network_id\u0027],"},{"line_number":65,"context_line":"                                                   row.data[\u0027id\u0027])"},{"line_number":66,"context_line":"                self.update_dhcp_port(context)"},{"line_number":67,"context_line":"        except Exception as e:"},{"line_number":68,"context_line":"            LOG.error(\"Error while processing update subnet %s\", e)"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_3832efa8","line":66,"in_reply_to":"1f1a1f67_7dbbb90d","updated":"2017-07-21 09:52:28.000000000","message":"OK.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"3cbc08c6a81ac69fe319996d6de6480e4ee16d09","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return driver_context.SubnetContext(plugin, context,"},{"line_number":76,"context_line":"                                            subnet, network)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_port(self, session, row):"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            device_id \u003d row.data[\u0027device_id\u0027]"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_3e32d7a8","line":78,"updated":"2017-07-21 10:21:33.000000000","message":"where is this method invoked?","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"603b41926f03828f1236630c13383d3222171cf3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        return driver_context.SubnetContext(plugin, context,"},{"line_number":76,"context_line":"                                            subnet, network)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _update_port(self, session, row):"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        try:"},{"line_number":81,"context_line":"            device_id \u003d row.data[\u0027device_id\u0027]"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_5ea0f3a5","line":78,"in_reply_to":"1f1a1f67_3e32d7a8","updated":"2017-07-21 12:30:04.000000000","message":"#47","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            device_id \u003d row.data[\u0027device_id\u0027]"},{"line_number":82,"context_line":"            fixed_ips \u003d row.data[\u0027fixed_ips\u0027]"},{"line_number":83,"context_line":"            if (device_id and device_id.startswith(dhcp_driver.DEVICE_ID) and"},{"line_number":84,"context_line":"                    not fixed_ips):"},{"line_number":85,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":86,"context_line":"                    plugin \u003d directory.get_plugin()"},{"line_number":87,"context_line":"                    context \u003d neutron_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_dd208d4c","line":84,"updated":"2017-07-21 09:09:45.000000000","message":"can you please let me know what this use-case handles?","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"3cbc08c6a81ac69fe319996d6de6480e4ee16d09","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            device_id \u003d row.data[\u0027device_id\u0027]"},{"line_number":82,"context_line":"            fixed_ips \u003d row.data[\u0027fixed_ips\u0027]"},{"line_number":83,"context_line":"            if (device_id and device_id.startswith(dhcp_driver.DEVICE_ID) and"},{"line_number":84,"context_line":"                    not fixed_ips):"},{"line_number":85,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":86,"context_line":"                    plugin \u003d directory.get_plugin()"},{"line_number":87,"context_line":"                    context \u003d neutron_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_be1dc710","line":84,"in_reply_to":"1f1a1f67_1813b368","updated":"2017-07-21 10:21:33.000000000","message":"what if the port has two subnets one Ipv4 and one IPv6 and only the IPv4 subnet is deleted?","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"603b41926f03828f1236630c13383d3222171cf3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            device_id \u003d row.data[\u0027device_id\u0027]"},{"line_number":82,"context_line":"            fixed_ips \u003d row.data[\u0027fixed_ips\u0027]"},{"line_number":83,"context_line":"            if (device_id and device_id.startswith(dhcp_driver.DEVICE_ID) and"},{"line_number":84,"context_line":"                    not fixed_ips):"},{"line_number":85,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":86,"context_line":"                    plugin \u003d directory.get_plugin()"},{"line_number":87,"context_line":"                    context \u003d neutron_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_f5e0fdfc","line":84,"in_reply_to":"1f1a1f67_be1dc710","updated":"2017-07-21 12:30:04.000000000","message":"Only VM Ports can have both IPv4 and IPv6 fixed_ips right. a subnet cannot be created with both IPv4 and IPv6 right, hence subnet created with IPv4 will have dhcp port with IPv4 as the only fixed_ips field.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            device_id \u003d row.data[\u0027device_id\u0027]"},{"line_number":82,"context_line":"            fixed_ips \u003d row.data[\u0027fixed_ips\u0027]"},{"line_number":83,"context_line":"            if (device_id and device_id.startswith(dhcp_driver.DEVICE_ID) and"},{"line_number":84,"context_line":"                    not fixed_ips):"},{"line_number":85,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":86,"context_line":"                    plugin \u003d directory.get_plugin()"},{"line_number":87,"context_line":"                    context \u003d neutron_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_1813b368","line":84,"in_reply_to":"1f1a1f67_dd208d4c","updated":"2017-07-21 09:52:28.000000000","message":"We are handling subnet delete using port update. In case of subnet delete,  dhcp ports are de-allocated first and then subnet delete is triggered. By the time we receive subnet delete in #74 we would not get subnet_context if handled by subnet delete event.  We can still handle it, without subnet_context. But thought its better as we would be handling comparatively bit early.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"08d19aaf683591acd5288f8a2bfdb07c5b84665c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            device_id \u003d row.data[\u0027device_id\u0027]"},{"line_number":82,"context_line":"            fixed_ips \u003d row.data[\u0027fixed_ips\u0027]"},{"line_number":83,"context_line":"            if (device_id and device_id.startswith(dhcp_driver.DEVICE_ID) and"},{"line_number":84,"context_line":"                    not fixed_ips):"},{"line_number":85,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":86,"context_line":"                    plugin \u003d directory.get_plugin()"},{"line_number":87,"context_line":"                    context \u003d neutron_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_8134ebdf","line":84,"in_reply_to":"1f1a1f67_f5e0fdfc","updated":"2017-07-21 13:42:46.000000000","message":"Is there a location where we are checking if the Port resource we try to service in #47 is a DHCP Port only.  I see that the above check tries to see if OpenDaylight owns it, but it would be better to additionally check if its a DHCP Port too !","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if (operation \u003d\u003d constants.ODL_CREATE or"},{"line_number":39,"context_line":"                operation \u003d\u003d constants.ODL_UPDATE):"},{"line_number":40,"context_line":"            try:"},{"line_number":41,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":42,"context_line":"                    context \u003d self._get_subnet_context(row.data[\u0027network_id\u0027],"},{"line_number":43,"context_line":"                                                       row.data[\u0027id\u0027])"},{"line_number":44,"context_line":"                    self.create_or_delete_dhcp_port(context)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_8b4ab352","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":60},"updated":"2017-07-24 17:39:45.000000000","message":"This isn\u0027t needed as OdlDhcpDriverBase.create_or_delete_dhcp_port creates top level plugin method.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"92d20db64afb3a20f215fb207b32e0978e8943a2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if (operation \u003d\u003d constants.ODL_CREATE or"},{"line_number":39,"context_line":"                operation \u003d\u003d constants.ODL_UPDATE):"},{"line_number":40,"context_line":"            try:"},{"line_number":41,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":42,"context_line":"                    context \u003d self._get_subnet_context(row.data[\u0027network_id\u0027],"},{"line_number":43,"context_line":"                                                       row.data[\u0027id\u0027])"},{"line_number":44,"context_line":"                    self.create_or_delete_dhcp_port(context)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_98542f23","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":60},"in_reply_to":"ff346bd7_8b4ab352","updated":"2017-07-25 13:51:51.000000000","message":"OK, Removing in next patch, but curious to know, how can plugin wraps \u0027get_port_id\u0027 and \u0027create/delete port\u0027 into single transaction?","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if operation \u003d\u003d constants.ODL_UPDATE:"},{"line_number":54,"context_line":"            try:"},{"line_number":55,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":56,"context_line":"                    self._delete_if_dhcp_port(session, row)"},{"line_number":57,"context_line":"            except Exception as e:"},{"line_number":58,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_f0180e82","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":60},"updated":"2017-07-24 17:39:45.000000000","message":"_delete_if_dhcp_port handles session itself.\nthis isn\u0027t needed.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"92d20db64afb3a20f215fb207b32e0978e8943a2","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        if operation \u003d\u003d constants.ODL_UPDATE:"},{"line_number":54,"context_line":"            try:"},{"line_number":55,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":56,"context_line":"                    self._delete_if_dhcp_port(session, row)"},{"line_number":57,"context_line":"            except Exception as e:"},{"line_number":58,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_f8245bc8","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":60},"in_reply_to":"ff346bd7_f0180e82","updated":"2017-07-25 13:51:51.000000000","message":"OK","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _get_subnet_context(self, network_id, subnet_id):"},{"line_number":61,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":62,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":63,"context_line":"        network \u003d plugin.get_network(context, network_id)"},{"line_number":64,"context_line":"        subnet \u003d plugin.get_subnet(context, subnet_id)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_cb3b1bcf","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":53},"updated":"2017-07-24 17:39:45.000000000","message":"This creates new db session. You\u0027re mixing two db sessions.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"92d20db64afb3a20f215fb207b32e0978e8943a2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _get_subnet_context(self, network_id, subnet_id):"},{"line_number":61,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":62,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":63,"context_line":"        network \u003d plugin.get_network(context, network_id)"},{"line_number":64,"context_line":"        subnet \u003d plugin.get_subnet(context, subnet_id)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_d81f576e","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":53},"in_reply_to":"ff346bd7_cb3b1bcf","updated":"2017-07-25 13:51:51.000000000","message":"Removing in next patch.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            if (device_owner and device_owner \u003d\u003d n_const.DEVICE_OWNER_DHCP and"},{"line_number":76,"context_line":"                    device_id and"},{"line_number":77,"context_line":"                    device_id.startswith(device_id_type) and not fixed_ips):"},{"line_number":78,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":79,"context_line":"                    plugin \u003d directory.get_plugin()"},{"line_number":80,"context_line":"                    context \u003d neutron_context.get_admin_context()"},{"line_number":81,"context_line":"                    self._delete_port(plugin, context, row.data[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_f0eece86","line":78,"range":{"start_line":78,"start_character":16,"end_line":78,"end_character":60},"updated":"2017-07-24 17:39:45.000000000","message":"Since self._delete_port calls plugin top level method, we shouldn\u0027t start transaction.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"92d20db64afb3a20f215fb207b32e0978e8943a2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            if (device_owner and device_owner \u003d\u003d n_const.DEVICE_OWNER_DHCP and"},{"line_number":76,"context_line":"                    device_id and"},{"line_number":77,"context_line":"                    device_id.startswith(device_id_type) and not fixed_ips):"},{"line_number":78,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":79,"context_line":"                    plugin \u003d directory.get_plugin()"},{"line_number":80,"context_line":"                    context \u003d neutron_context.get_admin_context()"},{"line_number":81,"context_line":"                    self._delete_port(plugin, context, row.data[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_b82ed3a2","line":78,"range":{"start_line":78,"start_character":16,"end_line":78,"end_character":60},"in_reply_to":"ff346bd7_f0eece86","updated":"2017-07-25 13:51:51.000000000","message":"Removing in next patch","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    device_id.startswith(device_id_type) and not fixed_ips):"},{"line_number":78,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":79,"context_line":"                    plugin \u003d directory.get_plugin()"},{"line_number":80,"context_line":"                    context \u003d neutron_context.get_admin_context()"},{"line_number":81,"context_line":"                    self._delete_port(plugin, context, row.data[\u0027id\u0027])"},{"line_number":82,"context_line":"        except Exception as e:"},{"line_number":83,"context_line":"            LOG.error(\"Error while processing update port %s\", e)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_f03feed3","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":65},"updated":"2017-07-24 17:39:45.000000000","message":"this creates new session. So you\u0027re mixing two db sessions.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"92d20db64afb3a20f215fb207b32e0978e8943a2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    device_id.startswith(device_id_type) and not fixed_ips):"},{"line_number":78,"context_line":"                with db_api.autonested_transaction(session):"},{"line_number":79,"context_line":"                    plugin \u003d directory.get_plugin()"},{"line_number":80,"context_line":"                    context \u003d neutron_context.get_admin_context()"},{"line_number":81,"context_line":"                    self._delete_port(plugin, context, row.data[\u0027id\u0027])"},{"line_number":82,"context_line":"        except Exception as e:"},{"line_number":83,"context_line":"            LOG.error(\"Error while processing update port %s\", e)"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_781aab7d","line":80,"range":{"start_line":80,"start_character":20,"end_line":80,"end_character":65},"in_reply_to":"ff346bd7_f03feed3","updated":"2017-07-25 13:51:51.000000000","message":"Thanks for the Journal Patch, had noticed this, was thinking the same. rather than creating the new session, was not sure to change journal file.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5e54af561383686ad5a0cd1c4dfd0c1f48e07f9d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if operation \u003d\u003d constants.ODL_UPDATE:"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                if context is None:"},{"line_number":55,"context_line":"                    context \u003d neutron_context.get_admin_context()"},{"line_number":56,"context_line":"                self._delete_if_dhcp_port(context, row)"},{"line_number":57,"context_line":"            except Exception as e:"},{"line_number":58,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_8e061a86","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":65},"updated":"2017-07-25 16:44:20.000000000","message":"Since context is always passed, please remove it.\n(or assert context is not None)","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"e99cda76c59d2a90340728d9556a5289ca3d4a33","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if operation \u003d\u003d constants.ODL_UPDATE:"},{"line_number":53,"context_line":"            try:"},{"line_number":54,"context_line":"                if context is None:"},{"line_number":55,"context_line":"                    context \u003d neutron_context.get_admin_context()"},{"line_number":56,"context_line":"                self._delete_if_dhcp_port(context, row)"},{"line_number":57,"context_line":"            except Exception as e:"},{"line_number":58,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_a6d6a2c2","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":65},"in_reply_to":"ff346bd7_8e061a86","updated":"2017-07-25 19:04:34.000000000","message":"Done","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5e54af561383686ad5a0cd1c4dfd0c1f48e07f9d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                if context is None:"},{"line_number":55,"context_line":"                    context \u003d neutron_context.get_admin_context()"},{"line_number":56,"context_line":"                self._delete_if_dhcp_port(context, row)"},{"line_number":57,"context_line":"            except Exception as e:"},{"line_number":58,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _get_subnet_context(self, context, network_id, subnet_id):"},{"line_number":61,"context_line":"        if context is None:"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_e9f360e6","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":69},"updated":"2017-07-25 16:44:20.000000000","message":"both line 57 and line 81 catch exception.\nWe don\u0027t need both. Only one of them is needed.","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"e99cda76c59d2a90340728d9556a5289ca3d4a33","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                if context is None:"},{"line_number":55,"context_line":"                    context \u003d neutron_context.get_admin_context()"},{"line_number":56,"context_line":"                self._delete_if_dhcp_port(context, row)"},{"line_number":57,"context_line":"            except Exception as e:"},{"line_number":58,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _get_subnet_context(self, context, network_id, subnet_id):"},{"line_number":61,"context_line":"        if context is None:"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_66f9da4b","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":69},"in_reply_to":"ff346bd7_e9f360e6","updated":"2017-07-25 19:04:34.000000000","message":"Removed duplicate #81","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9481f7a601aabaeaec3485770692f9a79910bc84","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                                       row.data[\u0027id\u0027])"},{"line_number":40,"context_line":"                self.create_or_delete_dhcp_port(subnet_ctxt)"},{"line_number":41,"context_line":"            except Exception as e:"},{"line_number":42,"context_line":"                LOG.error(\"Error while processing %s subnet %s\", operation, e)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.BEFORE_COMPLETE])"},{"line_number":45,"context_line":"    def handle_port_update_event(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_3af4055b","line":42,"range":{"start_line":42,"start_character":26,"end_line":42,"end_character":77},"updated":"2017-07-25 20:44:12.000000000","message":"there can be two error cases here, one where it fails at _get_subnet_context which is less likely to happen, second case while create_or_delete_dhcp_port, so would be better to use more precisely `Error while requesting Dhcp port for subnet %s, e`,  fine with one you have too, no action required if you chose to stick with that.","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ee16d3ada694188950161cd1147d2e7fe1807de4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                                       row.data[\u0027id\u0027])"},{"line_number":40,"context_line":"                self.create_or_delete_dhcp_port(subnet_ctxt)"},{"line_number":41,"context_line":"            except Exception as e:"},{"line_number":42,"context_line":"                LOG.error(\"Error while processing %s subnet %s\", operation, e)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.BEFORE_COMPLETE])"},{"line_number":45,"context_line":"    def handle_port_update_event(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_b1cc85bc","line":42,"range":{"start_line":42,"start_character":26,"end_line":42,"end_character":77},"in_reply_to":"ff346bd7_17a22caf","updated":"2017-07-26 10:15:29.000000000","message":"Done","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                                       row.data[\u0027id\u0027])"},{"line_number":40,"context_line":"                self.create_or_delete_dhcp_port(subnet_ctxt)"},{"line_number":41,"context_line":"            except Exception as e:"},{"line_number":42,"context_line":"                LOG.error(\"Error while processing %s subnet %s\", operation, e)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.BEFORE_COMPLETE])"},{"line_number":45,"context_line":"    def handle_port_update_event(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_a0e562aa","line":42,"range":{"start_line":42,"start_character":26,"end_line":42,"end_character":77},"in_reply_to":"ff346bd7_3af4055b","updated":"2017-07-25 21:20:12.000000000","message":"OK, Will change as suggested","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"f13ceae746c917a8b12dee4684745f268b7cbe78","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                                       row.data[\u0027id\u0027])"},{"line_number":40,"context_line":"                self.create_or_delete_dhcp_port(subnet_ctxt)"},{"line_number":41,"context_line":"            except Exception as e:"},{"line_number":42,"context_line":"                LOG.error(\"Error while processing %s subnet %s\", operation, e)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.BEFORE_COMPLETE])"},{"line_number":45,"context_line":"    def handle_port_update_event(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_17a22caf","line":42,"range":{"start_line":42,"start_character":26,"end_line":42,"end_character":77},"in_reply_to":"ff346bd7_a0e562aa","updated":"2017-07-26 06:00:24.000000000","message":"print the subnet Id","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9481f7a601aabaeaec3485770692f9a79910bc84","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                LOG.error(\"Error while processing %s subnet %s\", operation, e)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.BEFORE_COMPLETE])"},{"line_number":45,"context_line":"    def handle_port_update_event(self, resource, event, trigger,"},{"line_number":46,"context_line":"                                 context\u003dNone, operation\u003dNone,"},{"line_number":47,"context_line":"                                 row\u003dNone, **kwargs):"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_5abfc960","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":26},"updated":"2017-07-25 20:44:12.000000000","message":"this sound like a delete event ? what is getting updated ?","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                LOG.error(\"Error while processing %s subnet %s\", operation, e)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.BEFORE_COMPLETE])"},{"line_number":45,"context_line":"    def handle_port_update_event(self, resource, event, trigger,"},{"line_number":46,"context_line":"                                 context\u003dNone, operation\u003dNone,"},{"line_number":47,"context_line":"                                 row\u003dNone, **kwargs):"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_80f93e4e","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":26},"in_reply_to":"ff346bd7_5abfc960","updated":"2017-07-25 21:20:12.000000000","message":"Here we receive port update event, on receiving port update, if its subnet de-allocation we are deleting the port.","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"f13ceae746c917a8b12dee4684745f268b7cbe78","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            try:"},{"line_number":51,"context_line":"                self._delete_if_dhcp_port(context, row)"},{"line_number":52,"context_line":"            except Exception as e:"},{"line_number":53,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _get_subnet_context(self, context, network_id, subnet_id):"},{"line_number":56,"context_line":"        plugin \u003d directory.get_plugin()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_178b4c1f","line":53,"updated":"2017-07-26 06:00:24.000000000","message":"print the port-id and subnet-id","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ee16d3ada694188950161cd1147d2e7fe1807de4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            try:"},{"line_number":51,"context_line":"                self._delete_if_dhcp_port(context, row)"},{"line_number":52,"context_line":"            except Exception as e:"},{"line_number":53,"context_line":"                LOG.error(\"Error while processing update port %s\", e)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _get_subnet_context(self, context, network_id, subnet_id):"},{"line_number":56,"context_line":"        plugin \u003d directory.get_plugin()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_d16389b0","line":53,"in_reply_to":"ff346bd7_178b4c1f","updated":"2017-07-26 10:15:29.000000000","message":"Done","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"}],"networking_odl/dhcp/odl_dhcp_driver_base.py":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":"DEVICE_ID \u003d \u0027OpenDaylight\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class OdlDhcpDriverBase(object):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_b22d00aa","line":26,"updated":"2017-07-21 09:09:45.000000000","message":"DEVICE_ID_OPENDAYLIGHT","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":"DEVICE_ID \u003d \u0027OpenDaylight\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class OdlDhcpDriverBase(object):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_63755c98","line":26,"in_reply_to":"1f1a1f67_b22d00aa","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # of enable_dhcp instead validating on port_id presence in DB by locking"},{"line_number":45,"context_line":"    # the session, this will enable user to reissue the same command in case of"},{"line_number":46,"context_line":"    # failure."},{"line_number":47,"context_line":"    def update_dhcp_port(self, context):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        port_id \u003d self._get_port_id(context)"},{"line_number":50,"context_line":"        if not port_id and context.current[\u0027enable_dhcp\u0027]:"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_f275b8cd","line":47,"updated":"2017-07-21 09:09:45.000000000","message":"this method name is incorrect.  An update subnet is trigger for invoking this method.  \n\nYou can have one method create_or_delete_dhcp_port() and call that uniformly from everywhere.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # of enable_dhcp instead validating on port_id presence in DB by locking"},{"line_number":45,"context_line":"    # the session, this will enable user to reissue the same command in case of"},{"line_number":46,"context_line":"    # failure."},{"line_number":47,"context_line":"    def update_dhcp_port(self, context):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        port_id \u003d self._get_port_id(context)"},{"line_number":50,"context_line":"        if not port_id and context.current[\u0027enable_dhcp\u0027]:"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_a3b7f43a","line":47,"in_reply_to":"1f1a1f67_f275b8cd","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                              context._plugin_context,"},{"line_number":56,"context_line":"                              port_id)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        port_id \u003d self._get_port_id(context)"},{"line_number":61,"context_line":"        if port_id:"},{"line_number":62,"context_line":"            self._delete_port(context._plugin,"},{"line_number":63,"context_line":"                              context._plugin_context,"},{"line_number":64,"context_line":"                              port_id)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def _make_dhcp_port_dict(self, context):"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_36b0f6dd","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":38},"updated":"2017-07-20 04:44:00.000000000","message":"Please drop unused method.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        return {\u0027port\u0027: port_dict}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @db_api.retry_db_errors"},{"line_number":80,"context_line":"    def _create_port(self, plugin, context, port):"},{"line_number":81,"context_line":"        p_utils.create_port(plugin, context, port)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @db_api.retry_db_errors"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_5250ec32","line":80,"updated":"2017-07-21 09:09:45.000000000","message":"as said earlier, i see this method is redundant.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        return {\u0027port\u0027: port_dict}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @db_api.retry_db_errors"},{"line_number":80,"context_line":"    def _create_port(self, plugin, context, port):"},{"line_number":81,"context_line":"        p_utils.create_port(plugin, context, port)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @db_api.retry_db_errors"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_43edc023","line":80,"in_reply_to":"1f1a1f67_5250ec32","updated":"2017-07-21 09:52:28.000000000","message":"Will remove","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        p_utils.create_port(plugin, context, port)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @db_api.retry_db_errors"},{"line_number":84,"context_line":"    def _get_port_id(self, context):"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        plugin_context \u003d context._plugin_context"},{"line_number":87,"context_line":"        network_id \u003d context._subnet[\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_724be886","line":84,"updated":"2017-07-21 09:09:45.000000000","message":"get_dhcp_port_if_exists()","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        p_utils.create_port(plugin, context, port)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @db_api.retry_db_errors"},{"line_number":84,"context_line":"    def _get_port_id(self, context):"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        plugin_context \u003d context._plugin_context"},{"line_number":87,"context_line":"        network_id \u003d context._subnet[\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_a3901497","line":84,"in_reply_to":"1f1a1f67_724be886","updated":"2017-07-21 09:52:28.000000000","message":"OK","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5e54af561383686ad5a0cd1c4dfd0c1f48e07f9d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # port_id presence in DB by locking the session, this will enable user to"},{"line_number":34,"context_line":"    # reissue the same command in case of failure."},{"line_number":35,"context_line":"    @db_api.retry_db_errors"},{"line_number":36,"context_line":"    def create_or_delete_dhcp_port(self, context):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        port_id \u003d self.get_dhcp_port_if_exists(context)"},{"line_number":39,"context_line":"        plugin \u003d context._plugin"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_2e860edd","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":48},"updated":"2017-07-25 16:44:20.000000000","message":"Here we receive subnet context.\nCan you please rename context to subnet_ctxt or something.\nso that we know it\u0027s not port context or something else.\nWe have many context for different meanings. :-(","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"e99cda76c59d2a90340728d9556a5289ca3d4a33","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # port_id presence in DB by locking the session, this will enable user to"},{"line_number":34,"context_line":"    # reissue the same command in case of failure."},{"line_number":35,"context_line":"    @db_api.retry_db_errors"},{"line_number":36,"context_line":"    def create_or_delete_dhcp_port(self, context):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        port_id \u003d self.get_dhcp_port_if_exists(context)"},{"line_number":39,"context_line":"        plugin \u003d context._plugin"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_668e7ad1","line":36,"range":{"start_line":36,"start_character":41,"end_line":36,"end_character":48},"in_reply_to":"ff346bd7_2e860edd","updated":"2017-07-25 19:04:34.000000000","message":"Done","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5e54af561383686ad5a0cd1c4dfd0c1f48e07f9d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        LOG.debug(\"Deleting ODL DHCP port with id %s\", port_id)"},{"line_number":52,"context_line":"        plugin.delete_port(context, port_id)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _make_dhcp_port_dict(self, context):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        port_dict \u003d dict("},{"line_number":57,"context_line":"            name\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_ee67e650","line":54,"range":{"start_line":54,"start_character":35,"end_line":54,"end_character":42},"updated":"2017-07-25 16:44:20.000000000","message":"ditto","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"e99cda76c59d2a90340728d9556a5289ca3d4a33","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        LOG.debug(\"Deleting ODL DHCP port with id %s\", port_id)"},{"line_number":52,"context_line":"        plugin.delete_port(context, port_id)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _make_dhcp_port_dict(self, context):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        port_dict \u003d dict("},{"line_number":57,"context_line":"            name\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_26c2b2ea","line":54,"range":{"start_line":54,"start_character":35,"end_line":54,"end_character":42},"in_reply_to":"ff346bd7_ee67e650","updated":"2017-07-25 19:04:34.000000000","message":"Done","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5e54af561383686ad5a0cd1c4dfd0c1f48e07f9d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return {\u0027port\u0027: port_dict}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @db_api.retry_db_errors"},{"line_number":68,"context_line":"    def get_dhcp_port_if_exists(self, context):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        plugin_context \u003d context._plugin_context"},{"line_number":71,"context_line":"        network_id \u003d context._subnet[\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_ce4f82bb","line":68,"range":{"start_line":68,"start_character":38,"end_line":68,"end_character":45},"updated":"2017-07-25 16:44:20.000000000","message":"ditto","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"e99cda76c59d2a90340728d9556a5289ca3d4a33","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return {\u0027port\u0027: port_dict}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @db_api.retry_db_errors"},{"line_number":68,"context_line":"    def get_dhcp_port_if_exists(self, context):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        plugin_context \u003d context._plugin_context"},{"line_number":71,"context_line":"        network_id \u003d context._subnet[\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_06b9ee78","line":68,"range":{"start_line":68,"start_character":38,"end_line":68,"end_character":45},"in_reply_to":"ff346bd7_ce4f82bb","updated":"2017-07-25 19:04:34.000000000","message":"Done","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5e54af561383686ad5a0cd1c4dfd0c1f48e07f9d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        subnet_id \u003d context.current[\u0027id\u0027]"},{"line_number":73,"context_line":"        device_id \u003d OPENDAYLIGHT_DEVICE_ID + \u0027-\u0027 + subnet_id"},{"line_number":74,"context_line":"        LOG.debug(\"Retrieving ODL DHCP port for subnet %s\", subnet_id)"},{"line_number":75,"context_line":"        port \u003d plugin_context.session.query("},{"line_number":76,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":77,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":78,"context_line":"        if port:"},{"line_number":79,"context_line":"            return port[0]"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_ae8d5ed4","line":77,"range":{"start_line":75,"start_character":15,"end_line":77,"end_character":56},"updated":"2017-07-25 16:44:20.000000000","message":"This is intrusive to db schema definition.\nuse plugin.get_ports()(or its variant) and pass filters\u003d{...}\nand check the length of the return.","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"e99cda76c59d2a90340728d9556a5289ca3d4a33","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        subnet_id \u003d context.current[\u0027id\u0027]"},{"line_number":73,"context_line":"        device_id \u003d OPENDAYLIGHT_DEVICE_ID + \u0027-\u0027 + subnet_id"},{"line_number":74,"context_line":"        LOG.debug(\"Retrieving ODL DHCP port for subnet %s\", subnet_id)"},{"line_number":75,"context_line":"        port \u003d plugin_context.session.query("},{"line_number":76,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":77,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":78,"context_line":"        if port:"},{"line_number":79,"context_line":"            return port[0]"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff346bd7_6fe2cd31","line":77,"range":{"start_line":75,"start_character":15,"end_line":77,"end_character":56},"in_reply_to":"ff346bd7_ae8d5ed4","updated":"2017-07-25 19:04:34.000000000","message":"Done","commit_id":"478c656b30d1b789fbf62b9f8f64db5997a1771e"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9481f7a601aabaeaec3485770692f9a79910bc84","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            self._delete_port(plugin, subnet_context._plugin_context, port_id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @db_api.retry_db_errors"},{"line_number":48,"context_line":"    def _delete_port(self, plugin, context, port_id):"},{"line_number":49,"context_line":"        LOG.debug(\"Deleting ODL DHCP port with id %s\", port_id)"},{"line_number":50,"context_line":"        plugin.delete_port(context, port_id)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _make_dhcp_port_dict(self, subnet_context):"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_9592a29d","line":50,"range":{"start_line":48,"start_character":4,"end_line":50,"end_character":44},"updated":"2017-07-25 20:44:12.000000000","message":"this can be added to create_or_delete_dhcp_port as well, it make less sense to write helpers for liners","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"cf89343de57bd63cd24b9cb322df59af82da338a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            self._delete_port(plugin, subnet_context._plugin_context, port_id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @db_api.retry_db_errors"},{"line_number":48,"context_line":"    def _delete_port(self, plugin, context, port_id):"},{"line_number":49,"context_line":"        LOG.debug(\"Deleting ODL DHCP port with id %s\", port_id)"},{"line_number":50,"context_line":"        plugin.delete_port(context, port_id)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _make_dhcp_port_dict(self, subnet_context):"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_bb091732","line":50,"range":{"start_line":48,"start_character":4,"end_line":50,"end_character":44},"in_reply_to":"ff346bd7_1b102301","updated":"2017-07-25 21:43:40.000000000","message":"would L33 won\u0027t work for both ?","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c73c33b2237c5459ae1184d83993aee65c24d8c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            self._delete_port(plugin, subnet_context._plugin_context, port_id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @db_api.retry_db_errors"},{"line_number":48,"context_line":"    def _delete_port(self, plugin, context, port_id):"},{"line_number":49,"context_line":"        LOG.debug(\"Deleting ODL DHCP port with id %s\", port_id)"},{"line_number":50,"context_line":"        plugin.delete_port(context, port_id)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _make_dhcp_port_dict(self, subnet_context):"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_1b102301","line":50,"range":{"start_line":48,"start_character":4,"end_line":50,"end_character":44},"in_reply_to":"ff346bd7_9592a29d","updated":"2017-07-25 21:36:33.000000000","message":"I suppose the author want line 47, @db_api.retry_db_errors","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            self._delete_port(plugin, subnet_context._plugin_context, port_id)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @db_api.retry_db_errors"},{"line_number":48,"context_line":"    def _delete_port(self, plugin, context, port_id):"},{"line_number":49,"context_line":"        LOG.debug(\"Deleting ODL DHCP port with id %s\", port_id)"},{"line_number":50,"context_line":"        plugin.delete_port(context, port_id)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _make_dhcp_port_dict(self, subnet_context):"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_a0ac4234","line":50,"range":{"start_line":48,"start_character":4,"end_line":50,"end_character":44},"in_reply_to":"ff346bd7_9592a29d","updated":"2017-07-25 21:20:12.000000000","message":"Its also called from other class. OdlDhcpDriver","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c73c33b2237c5459ae1184d83993aee65c24d8c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        ports \u003d plugin.get_ports(plugin_context, filters\u003dfilters)"},{"line_number":81,"context_line":"        if ports:"},{"line_number":82,"context_line":"            port \u003d ports[0]"},{"line_number":83,"context_line":"            LOG.info(\"Retrieved ODL owned port %s for subnet %s\","},{"line_number":84,"context_line":"                     port[\u0027id\u0027], subnet_id)"},{"line_number":85,"context_line":"            return port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_7b172fef","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":20},"updated":"2017-07-25 21:36:33.000000000","message":"this should be debug?","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"63013d9adbbd631390e1c311b7f3ce74c0d052ed","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        ports \u003d plugin.get_ports(plugin_context, filters\u003dfilters)"},{"line_number":81,"context_line":"        if ports:"},{"line_number":82,"context_line":"            port \u003d ports[0]"},{"line_number":83,"context_line":"            LOG.info(\"Retrieved ODL owned port %s for subnet %s\","},{"line_number":84,"context_line":"                     port[\u0027id\u0027], subnet_id)"},{"line_number":85,"context_line":"            return port[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_7b8e0fd1","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":20},"in_reply_to":"ff346bd7_7b172fef","updated":"2017-07-25 21:40:25.000000000","message":"Oops","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a0e5370ad678152638a99f6db7a26ab44e9721ff","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.db import api as db_api"},{"line_number":18,"context_line":"from neutron.plugins.common import utils as p_utils"},{"line_number":19,"context_line":"from neutron_lib import constants as n_const"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff346bd7_b7a10a49","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":35},"updated":"2017-07-26 16:34:53.000000000","message":"no line space required all 3rd party imports can be grouped together","commit_id":"c467e9879d777c71e0c39bc557b3852de351e982"}],"networking_odl/dhcp/odl_dhcp_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"94247edeaa1b148417b7226a144d594033268165","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def create(cls):"},{"line_number":38,"context_line":"        return OdlDhcpDriverV2()"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_a54fec68","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":16},"updated":"2017-07-10 22:10:18.000000000","message":"why class method? not static?\nargument cls isn\u0027t used.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1099206faa0e6390b84e43a49b008023f1043bc6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @classmethod"},{"line_number":37,"context_line":"    def create(cls):"},{"line_number":38,"context_line":"        return OdlDhcpDriverV2()"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_371c2769","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":16},"in_reply_to":"3f1d235d_a54fec68","updated":"2017-07-11 08:53:46.000000000","message":"OK, sure","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"94247edeaa1b148417b7226a144d594033268165","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            if event \u003d\u003d constants.ODL_UPDATE:"},{"line_number":54,"context_line":"                self.__update_port(session, row)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def __create_subnet(self, session, row):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            with db_api.autonested_transaction(session):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_c575489a","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":10},"updated":"2017-07-10 22:10:18.000000000","message":"please use single underscore unless you have special reason.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1099206faa0e6390b84e43a49b008023f1043bc6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            if event \u003d\u003d constants.ODL_UPDATE:"},{"line_number":54,"context_line":"                self.__update_port(session, row)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def __create_subnet(self, session, row):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        try:"},{"line_number":59,"context_line":"            with db_api.autonested_transaction(session):"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_f727cfb5","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":10},"in_reply_to":"3f1d235d_c575489a","updated":"2017-07-11 08:53:46.000000000","message":"Yeah, already changed for part of UT, will push it in next patch","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"94247edeaa1b148417b7226a144d594033268165","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                LOG.error(\"Error while creating DHCP Port %s\", e)"},{"line_number":121,"context_line":"        return False"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        with db_api.context_manager.reader.using(context):"},{"line_number":126,"context_line":"            port_id \u003d self._get_port_id(context._plugin,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_857d1070","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":26},"updated":"2017-07-10 22:10:18.000000000","message":"I don\u0027t see the caller of this method.\nsomethig weird.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1099206faa0e6390b84e43a49b008023f1043bc6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                LOG.error(\"Error while creating DHCP Port %s\", e)"},{"line_number":121,"context_line":"        return False"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        with db_api.context_manager.reader.using(context):"},{"line_number":126,"context_line":"            port_id \u003d self._get_port_id(context._plugin,"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_97241bb1","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":26},"in_reply_to":"3f1d235d_857d1070","updated":"2017-07-11 08:53:46.000000000","message":"We are retaining for V1 Drvier","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8df3abfd881a52bfe15f55c16abac0a3279b70e4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def create():"},{"line_number":38,"context_line":"        return OdlDhcpDriverV2()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def handle_event(self, resource, event, state, session, row):"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_3aa2039c","line":38,"range":{"start_line":36,"start_character":3,"end_line":38,"end_character":32},"updated":"2017-07-12 18:43:42.000000000","message":"why do you need a empty create method ?","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8df3abfd881a52bfe15f55c16abac0a3279b70e4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                self._create_subnet(session, row)"},{"line_number":45,"context_line":"            if event \u003d\u003d constants.ODL_UPDATE:"},{"line_number":46,"context_line":"                self._update_subnet(session, row)"},{"line_number":47,"context_line":"# Subnet Context will not be available for delete cases, when subnet delete"},{"line_number":48,"context_line":"# is triggered, port will be deallocated from the subnet resulting fixed_ips"},{"line_number":49,"context_line":"# being null"},{"line_number":50,"context_line":"#            if event \u003d\u003d constants.ODL_DELETE:"},{"line_number":51,"context_line":"#                self.__delete_subnet(session, row)"},{"line_number":52,"context_line":"        if resource \u003d\u003d constants.ODL_PORT:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_dac1cf30","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":12},"updated":"2017-07-12 18:43:42.000000000","message":"this comment need some formatting align it with indentation.","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                self._create_subnet(session, row)"},{"line_number":45,"context_line":"            if event \u003d\u003d constants.ODL_UPDATE:"},{"line_number":46,"context_line":"                self._update_subnet(session, row)"},{"line_number":47,"context_line":"# Subnet Context will not be available for delete cases, when subnet delete"},{"line_number":48,"context_line":"# is triggered, port will be deallocated from the subnet resulting fixed_ips"},{"line_number":49,"context_line":"# being null"},{"line_number":50,"context_line":"#            if event \u003d\u003d constants.ODL_DELETE:"},{"line_number":51,"context_line":"#                self.__delete_subnet(session, row)"},{"line_number":52,"context_line":"        if resource \u003d\u003d constants.ODL_PORT:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_ee75f099","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":12},"in_reply_to":"1f1a1f67_dac1cf30","updated":"2017-07-13 07:17:54.000000000","message":"Will remove","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8df3abfd881a52bfe15f55c16abac0a3279b70e4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# Subnet Context will not be available for delete cases, when subnet delete"},{"line_number":48,"context_line":"# is triggered, port will be deallocated from the subnet resulting fixed_ips"},{"line_number":49,"context_line":"# being null"},{"line_number":50,"context_line":"#            if event \u003d\u003d constants.ODL_DELETE:"},{"line_number":51,"context_line":"#                self.__delete_subnet(session, row)"},{"line_number":52,"context_line":"        if resource \u003d\u003d constants.ODL_PORT:"},{"line_number":53,"context_line":"            if event \u003d\u003d constants.ODL_UPDATE:"},{"line_number":54,"context_line":"                self._update_port(session, row)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_dad66ff2","line":51,"range":{"start_line":50,"start_character":13,"end_line":51,"end_character":51},"updated":"2017-07-12 18:43:42.000000000","message":"either this should be deleted, or un commented","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# Subnet Context will not be available for delete cases, when subnet delete"},{"line_number":48,"context_line":"# is triggered, port will be deallocated from the subnet resulting fixed_ips"},{"line_number":49,"context_line":"# being null"},{"line_number":50,"context_line":"#            if event \u003d\u003d constants.ODL_DELETE:"},{"line_number":51,"context_line":"#                self.__delete_subnet(session, row)"},{"line_number":52,"context_line":"        if resource \u003d\u003d constants.ODL_PORT:"},{"line_number":53,"context_line":"            if event \u003d\u003d constants.ODL_UPDATE:"},{"line_number":54,"context_line":"                self._update_port(session, row)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_ae6ff8c3","line":51,"range":{"start_line":50,"start_character":13,"end_line":51,"end_character":51},"in_reply_to":"1f1a1f67_dad66ff2","updated":"2017-07-13 07:17:54.000000000","message":"Will remove","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c7588798951039a22af89e8f38e3ce4384898ca6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _get_subnet_context(self, network_id, subnet_id):"},{"line_number":69,"context_line":"            context \u003d neutron_context.get_admin_context()"},{"line_number":70,"context_line":"            plugin \u003d directory.get_plugin()"},{"line_number":71,"context_line":"            network \u003d plugin.get_network(context, network_id)"},{"line_number":72,"context_line":"            subnet \u003d plugin.get_subnet(context, subnet_id)"},{"line_number":73,"context_line":"            return driver_context.SubnetContext(plugin, context,"},{"line_number":74,"context_line":"                                                subnet, network)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _update_subnet(self, session, row):"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_e4bd1169","line":74,"range":{"start_line":69,"start_character":8,"end_line":74,"end_character":64},"updated":"2017-07-12 20:47:25.000000000","message":"it needs indentation fixed","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        return False"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _get_subnet_context(self, network_id, subnet_id):"},{"line_number":69,"context_line":"            context \u003d neutron_context.get_admin_context()"},{"line_number":70,"context_line":"            plugin \u003d directory.get_plugin()"},{"line_number":71,"context_line":"            network \u003d plugin.get_network(context, network_id)"},{"line_number":72,"context_line":"            subnet \u003d plugin.get_subnet(context, subnet_id)"},{"line_number":73,"context_line":"            return driver_context.SubnetContext(plugin, context,"},{"line_number":74,"context_line":"                                                subnet, network)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def _update_subnet(self, session, row):"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_237d31b1","line":74,"range":{"start_line":69,"start_character":8,"end_line":74,"end_character":64},"in_reply_to":"1f1a1f67_e4bd1169","updated":"2017-07-13 07:17:54.000000000","message":"Sure","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"1f1a1f67_ffaf46e0","updated":"2017-07-18 04:46:18.000000000","message":"why do we have odl_dhcp_driver and odh_dhcp_driver_v2?\nIt\u0027s not v2, right? it\u0027s used with odl mech v2 driver, though.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"78a0a3b7c20438652784433336c24ff96ad575e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"1f1a1f67_0652953b","in_reply_to":"1f1a1f67_990bcd7b","updated":"2017-07-19 04:49:13.000000000","message":"Since this patch is for master branch, please clean up it and don\u0027t bring backport debt into master branch.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"1f1a1f67_990bcd7b","in_reply_to":"1f1a1f67_ffaf46e0","updated":"2017-07-18 15:46:56.000000000","message":"Yeah, since we needed support for mitaka as well, odl_dhcp_driver.py primarily used for mitaka with odl mech v1 driver. odl mech v2 driver we are wrapping odl_dhcp_driver_v2 with journal callback.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@registry.has_registry_receivers"},{"line_number":32,"context_line":"class OdlDhcpDriverV2(dhcp_driver.OdlDhcpDriver):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @registry.receives(constants.ODL_SUBNET, [constants.BEFORE_COMPLETE])"},{"line_number":35,"context_line":"    def handle_subnet_event(self, resource, event, trigger, operation\u003dNone,"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_dfac8aee","line":32,"range":{"start_line":32,"start_character":19,"end_line":32,"end_character":21},"updated":"2017-07-18 04:46:18.000000000","message":"This is confusing.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"@registry.has_registry_receivers"},{"line_number":32,"context_line":"class OdlDhcpDriverV2(dhcp_driver.OdlDhcpDriver):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @registry.receives(constants.ODL_SUBNET, [constants.BEFORE_COMPLETE])"},{"line_number":35,"context_line":"    def handle_subnet_event(self, resource, event, trigger, operation\u003dNone,"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_f91be1c6","line":32,"range":{"start_line":32,"start_character":19,"end_line":32,"end_character":21},"in_reply_to":"1f1a1f67_dfac8aee","updated":"2017-07-18 15:46:56.000000000","message":"Shall I rename it OdlDhcpDriver","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        except Exception as e:"},{"line_number":58,"context_line":"            LOG.error(\"Error while processing create subnet %s\", e)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _get_subnet_context(self, network_id, subnet_id):"},{"line_number":61,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":62,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":63,"context_line":"        network \u003d plugin.get_network(context, network_id)"},{"line_number":64,"context_line":"        subnet \u003d plugin.get_subnet(context, subnet_id)"},{"line_number":65,"context_line":"        return driver_context.SubnetContext(plugin, context,"},{"line_number":66,"context_line":"                                            subnet, network)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _update_subnet(self, session, row):"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_7fea160f","line":66,"range":{"start_line":60,"start_character":0,"end_line":66,"end_character":60},"updated":"2017-07-18 04:46:18.000000000","message":"It seems weird to place this method between _create_subnet and _update_subnet.\nPlease place before both or after both.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"}],"networking_odl/dhcp/odl_dhcp_driver_v3.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c3a7a333cc9f64b3977acc072af2b380f117347","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@registry.has_registry_receivers"},{"line_number":31,"context_line":"class OdlDhcpDriverV2(dhcp_driver.OdlDhcpDriver):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_f4e5c439","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":49},"updated":"2017-07-12 17:19:55.000000000","message":"this naming is very confusing.\nYou\u0027d like to implement this with inheritance for clarity, right?","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@registry.has_registry_receivers"},{"line_number":31,"context_line":"class OdlDhcpDriverV2(dhcp_driver.OdlDhcpDriver):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_0e4cacc5","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":49},"in_reply_to":"1f1a1f67_74277466","updated":"2017-07-13 07:17:54.000000000","message":"We might need this PS along with ODL changes for ML2 V1 driver, Created altogether a different file that is specific to V2 Driver. so that for V1 we can use odl_dhcp_driver.py directly","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5b7be9f79a88a9ffb1c4f913b0326ceee82a5901","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@registry.has_registry_receivers"},{"line_number":31,"context_line":"class OdlDhcpDriverV2(dhcp_driver.OdlDhcpDriver):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_74277466","line":31,"range":{"start_line":31,"start_character":6,"end_line":31,"end_character":49},"in_reply_to":"1f1a1f67_f4e5c439","updated":"2017-07-12 17:20:36.000000000","message":"Probably we can put this class into odl_dhcp_driver.py.","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c3a7a333cc9f64b3977acc072af2b380f117347","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class OdlDhcpDriverV2(dhcp_driver.OdlDhcpDriver):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def create():"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_943b309b","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":12},"updated":"2017-07-12 17:19:55.000000000","message":"use super.__init__ or remove __init__ because this does nothing.","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class OdlDhcpDriverV2(dhcp_driver.OdlDhcpDriver):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __init__(self):"},{"line_number":34,"context_line":"        pass"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def create():"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_faab6b72","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":12},"in_reply_to":"1f1a1f67_943b309b","updated":"2017-07-13 07:17:54.000000000","message":"Will Remove","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c7588798951039a22af89e8f38e3ce4384898ca6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            self._update_subnet(session, row)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.COMPLETED])"},{"line_number":49,"context_line":"    def handle_update_event(self, resource, event, trigger, operation\u003dNone,"},{"line_number":50,"context_line":"                            session\u003dNone, row\u003dNone, **kwargs):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if operation \u003d\u003d constants.ODL_UPDATE:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_84ebfdae","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":27},"updated":"2017-07-12 20:47:25.000000000","message":"as its not generic, could it be just named like handle_port_event or so ?","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            self._update_subnet(session, row)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.COMPLETED])"},{"line_number":49,"context_line":"    def handle_update_event(self, resource, event, trigger, operation\u003dNone,"},{"line_number":50,"context_line":"                            session\u003dNone, row\u003dNone, **kwargs):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if operation \u003d\u003d constants.ODL_UPDATE:"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_43594d58","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":27},"in_reply_to":"1f1a1f67_84ebfdae","updated":"2017-07-13 07:17:54.000000000","message":"Oops CPD mistake","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"}],"networking_odl/journal/callback.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"94247edeaa1b148417b7226a144d594033268165","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import inspect"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.common import exceptions"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":"registry \u003d []"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def notify(resource, event, state, session, row):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    for obj in registry:"},{"line_number":28,"context_line":"        if not obj.handle_event(resource, event, state, session, row):"},{"line_number":29,"context_line":"            break"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register(func):"},{"line_number":33,"context_line":"    def _decorator(self, *args, **kwargs):"},{"line_number":34,"context_line":"        verify_obj_has_notify_method(self)"},{"line_number":35,"context_line":"        registry.append(self)"},{"line_number":36,"context_line":"        return func(self, *args, **kwargs)"},{"line_number":37,"context_line":"    return _decorator"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def verify_obj_has_notify_method(obj):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if not inspect.ismethod(obj.handle_event):"},{"line_number":43,"context_line":"        raise exceptions.ObjectActionError("},{"line_number":44,"context_line":"            action\u003d_(\u0027creation\u0027),"},{"line_number":45,"context_line":"            reason\u003d_(\u0027missing handle_event method in class\u0027))"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_650b1424","line":45,"range":{"start_line":1,"start_character":0,"end_line":45,"end_character":61},"updated":"2017-07-10 22:10:18.000000000","message":"Can\u0027t we simply use neutron_lib.callback.registry?\nDo you have any special reason to invent our own version?","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f218097e7eb13b3c530744ae7bfe7dc5dad1ec07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import inspect"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.common import exceptions"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":"registry \u003d []"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def notify(resource, event, state, session, row):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    for obj in registry:"},{"line_number":28,"context_line":"        if not obj.handle_event(resource, event, state, session, row):"},{"line_number":29,"context_line":"            break"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register(func):"},{"line_number":33,"context_line":"    def _decorator(self, *args, **kwargs):"},{"line_number":34,"context_line":"        verify_obj_has_notify_method(self)"},{"line_number":35,"context_line":"        registry.append(self)"},{"line_number":36,"context_line":"        return func(self, *args, **kwargs)"},{"line_number":37,"context_line":"    return _decorator"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def verify_obj_has_notify_method(obj):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if not inspect.ismethod(obj.handle_event):"},{"line_number":43,"context_line":"        raise exceptions.ObjectActionError("},{"line_number":44,"context_line":"            action\u003d_(\u0027creation\u0027),"},{"line_number":45,"context_line":"            reason\u003d_(\u0027missing handle_event method in class\u0027))"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_74f04468","line":45,"range":{"start_line":1,"start_character":0,"end_line":45,"end_character":61},"in_reply_to":"3f1d235d_374ae754","updated":"2017-07-11 17:52:43.000000000","message":"we can introduce a new resource like ODL_JOURNAL and a new event like COMPLETE.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1099206faa0e6390b84e43a49b008023f1043bc6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import inspect"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.common import exceptions"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":"registry \u003d []"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def notify(resource, event, state, session, row):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    for obj in registry:"},{"line_number":28,"context_line":"        if not obj.handle_event(resource, event, state, session, row):"},{"line_number":29,"context_line":"            break"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register(func):"},{"line_number":33,"context_line":"    def _decorator(self, *args, **kwargs):"},{"line_number":34,"context_line":"        verify_obj_has_notify_method(self)"},{"line_number":35,"context_line":"        registry.append(self)"},{"line_number":36,"context_line":"        return func(self, *args, **kwargs)"},{"line_number":37,"context_line":"    return _decorator"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def verify_obj_has_notify_method(obj):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if not inspect.ismethod(obj.handle_event):"},{"line_number":43,"context_line":"        raise exceptions.ObjectActionError("},{"line_number":44,"context_line":"            action\u003d_(\u0027creation\u0027),"},{"line_number":45,"context_line":"            reason\u003d_(\u0027missing handle_event method in class\u0027))"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_374ae754","line":45,"range":{"start_line":1,"start_character":0,"end_line":45,"end_character":61},"in_reply_to":"3f1d235d_650b1424","updated":"2017-07-11 08:53:46.000000000","message":"Nope, neutron_lib.callback.registry is used for registering for neutron resource precommit and postcommit notification.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"0e62714fbcd471b0ce92007ce318e23eb26ac5be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import inspect"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.common import exceptions"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":"registry \u003d []"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def notify(resource, event, state, session, row):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    for obj in registry:"},{"line_number":28,"context_line":"        if not obj.handle_event(resource, event, state, session, row):"},{"line_number":29,"context_line":"            break"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register(func):"},{"line_number":33,"context_line":"    def _decorator(self, *args, **kwargs):"},{"line_number":34,"context_line":"        verify_obj_has_notify_method(self)"},{"line_number":35,"context_line":"        registry.append(self)"},{"line_number":36,"context_line":"        return func(self, *args, **kwargs)"},{"line_number":37,"context_line":"    return _decorator"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def verify_obj_has_notify_method(obj):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if not inspect.ismethod(obj.handle_event):"},{"line_number":43,"context_line":"        raise exceptions.ObjectActionError("},{"line_number":44,"context_line":"            action\u003d_(\u0027creation\u0027),"},{"line_number":45,"context_line":"            reason\u003d_(\u0027missing handle_event method in class\u0027))"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_bae485ad","line":45,"range":{"start_line":1,"start_character":0,"end_line":45,"end_character":61},"in_reply_to":"3f1d235d_74f04468","updated":"2017-07-11 19:05:02.000000000","message":"Can we add odl specific stuffs to neutron? it would be nice if we can subscribe any events from one place.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"7abd2c62e2162328a04233bc4153254420c01144","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#         http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import inspect"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.common import exceptions"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log as logging"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":22,"context_line":"registry \u003d []"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def notify(resource, event, state, session, row):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    for obj in registry:"},{"line_number":28,"context_line":"        if not obj.handle_event(resource, event, state, session, row):"},{"line_number":29,"context_line":"            break"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def register(func):"},{"line_number":33,"context_line":"    def _decorator(self, *args, **kwargs):"},{"line_number":34,"context_line":"        verify_obj_has_notify_method(self)"},{"line_number":35,"context_line":"        registry.append(self)"},{"line_number":36,"context_line":"        return func(self, *args, **kwargs)"},{"line_number":37,"context_line":"    return _decorator"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def verify_obj_has_notify_method(obj):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    if not inspect.ismethod(obj.handle_event):"},{"line_number":43,"context_line":"        raise exceptions.ObjectActionError("},{"line_number":44,"context_line":"            action\u003d_(\u0027creation\u0027),"},{"line_number":45,"context_line":"            reason\u003d_(\u0027missing handle_event method in class\u0027))"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_7df024ca","line":45,"range":{"start_line":1,"start_character":0,"end_line":45,"end_character":61},"in_reply_to":"3f1d235d_bae485ad","updated":"2017-07-11 20:54:32.000000000","message":"We can define ODL specific constatns in networking-odl and use them.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"}],"networking_odl/journal/journal.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"94247edeaa1b148417b7226a144d594033268165","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                self.client.sendjson(method, urlpath, to_send)"},{"line_number":181,"context_line":"                db.update_db_row_state(session, entry, odl_const.COMPLETED)"},{"line_number":182,"context_line":"                journal_callback.notify(entry.object_type, entry.operation,"},{"line_number":183,"context_line":"                                        odl_const.COMPLETED, session, entry)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            except exceptions.ConnectionError:"},{"line_number":186,"context_line":"                # Don\u0027t raise the retry count, just log an error \u0026 break"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_4512585a","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":74},"updated":"2017-07-10 22:10:18.000000000","message":"This needs to be before line 181.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f218097e7eb13b3c530744ae7bfe7dc5dad1ec07","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                self.client.sendjson(method, urlpath, to_send)"},{"line_number":181,"context_line":"                db.update_db_row_state(session, entry, odl_const.COMPLETED)"},{"line_number":182,"context_line":"                journal_callback.notify(entry.object_type, entry.operation,"},{"line_number":183,"context_line":"                                        odl_const.COMPLETED, session, entry)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            except exceptions.ConnectionError:"},{"line_number":186,"context_line":"                # Don\u0027t raise the retry count, just log an error \u0026 break"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_54c1c8e3","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":74},"in_reply_to":"3f1d235d_3159d034","updated":"2017-07-11 17:52:43.000000000","message":"it doesn\u0027t work before 165.\nIt must be after line 175.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1099206faa0e6390b84e43a49b008023f1043bc6","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                self.client.sendjson(method, urlpath, to_send)"},{"line_number":181,"context_line":"                db.update_db_row_state(session, entry, odl_const.COMPLETED)"},{"line_number":182,"context_line":"                journal_callback.notify(entry.object_type, entry.operation,"},{"line_number":183,"context_line":"                                        odl_const.COMPLETED, session, entry)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            except exceptions.ConnectionError:"},{"line_number":186,"context_line":"                # Don\u0027t raise the retry count, just log an error \u0026 break"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_3159d034","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":74},"in_reply_to":"3f1d235d_4512585a","updated":"2017-07-11 08:53:46.000000000","message":"what about moving it to 165, we can avoid port creation delay or can we add postcommit for normal operation scenario and on neutron crash as fallback mechanism perform CRUD operations on complete event","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"0e62714fbcd471b0ce92007ce318e23eb26ac5be","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                self.client.sendjson(method, urlpath, to_send)"},{"line_number":181,"context_line":"                db.update_db_row_state(session, entry, odl_const.COMPLETED)"},{"line_number":182,"context_line":"                journal_callback.notify(entry.object_type, entry.operation,"},{"line_number":183,"context_line":"                                        odl_const.COMPLETED, session, entry)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            except exceptions.ConnectionError:"},{"line_number":186,"context_line":"                # Don\u0027t raise the retry count, just log an error \u0026 break"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_7a95cde3","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":74},"in_reply_to":"3f1d235d_54c1c8e3","updated":"2017-07-11 19:05:02.000000000","message":"Any reason, I did validate and worked","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"7abd2c62e2162328a04233bc4153254420c01144","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            try:"},{"line_number":180,"context_line":"                self.client.sendjson(method, urlpath, to_send)"},{"line_number":181,"context_line":"                db.update_db_row_state(session, entry, odl_const.COMPLETED)"},{"line_number":182,"context_line":"                journal_callback.notify(entry.object_type, entry.operation,"},{"line_number":183,"context_line":"                                        odl_const.COMPLETED, session, entry)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            except exceptions.ConnectionError:"},{"line_number":186,"context_line":"                # Don\u0027t raise the retry count, just log an error \u0026 break"}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_5dc4485f","line":183,"range":{"start_line":182,"start_character":0,"end_line":183,"end_character":74},"in_reply_to":"3f1d235d_7a95cde3","updated":"2017-07-11 20:54:32.000000000","message":"Really?\nDid you test the case of neutron crash before line 182 after line 181?\nIn that case, does this implementation work as expected?","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c3a7a333cc9f64b3977acc072af2b380f117347","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            self.client.sendjson(method, urlpath, to_send)"},{"line_number":205,"context_line":"            registry.notify(entry.object_type, odl_const.COMPLETED, self,"},{"line_number":206,"context_line":"                            operation \u003d entry.operation,"},{"line_number":207,"context_line":"                            session\u003dsession, row \u003d entry)"},{"line_number":208,"context_line":"            db.update_db_row_state(session, entry, odl_const.COMPLETED)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_545eb8e6","line":205,"range":{"start_line":205,"start_character":57,"end_line":205,"end_character":66},"updated":"2017-07-12 17:19:55.000000000","message":"the entry ins\u0027t completed yet.\nmaybe BEFORE_COMPLETE?","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            self.client.sendjson(method, urlpath, to_send)"},{"line_number":205,"context_line":"            registry.notify(entry.object_type, odl_const.COMPLETED, self,"},{"line_number":206,"context_line":"                            operation \u003d entry.operation,"},{"line_number":207,"context_line":"                            session\u003dsession, row \u003d entry)"},{"line_number":208,"context_line":"            db.update_db_row_state(session, entry, odl_const.COMPLETED)"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_3acb2354","line":205,"range":{"start_line":205,"start_character":57,"end_line":205,"end_character":66},"in_reply_to":"1f1a1f67_545eb8e6","updated":"2017-07-13 07:17:54.000000000","message":"OK","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        try:"},{"line_number":216,"context_line":"            self.client.sendjson(method, urlpath, to_send)"},{"line_number":217,"context_line":"            with session.begin():"},{"line_number":218,"context_line":"                registry.notify(entry.object_type, odl_const.BEFORE_COMPLETE,"},{"line_number":219,"context_line":"                                self, operation\u003dentry.operation,"},{"line_number":220,"context_line":"                                session\u003dsession, row\u003dentry)"},{"line_number":221,"context_line":"                db.update_db_row_state(session, entry, odl_const.COMPLETED)"},{"line_number":222,"context_line":"                db.delete_dependency(session, entry)"},{"line_number":223,"context_line":"                self._retry_reset()"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_707d3eb0","line":220,"range":{"start_line":218,"start_character":0,"end_line":220,"end_character":59},"updated":"2017-07-24 17:39:45.000000000","message":"This should be called outside of the session.\ni.e. after line 216 before line 217(session.begin())","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9481f7a601aabaeaec3485770692f9a79910bc84","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from networking_odl.common import utils"},{"line_number":21,"context_line":"from networking_odl.db import db"},{"line_number":22,"context_line":"from networking_odl.journal import dependency_validations"},{"line_number":23,"context_line":"from neutron_lib import context as nl_context"},{"line_number":24,"context_line":"from neutron_lib.callbacks import registry"},{"line_number":25,"context_line":"from neutron_lib.plugins import directory"},{"line_number":26,"context_line":"from oslo_config import cfg"},{"line_number":27,"context_line":"from oslo_log import log as logging"},{"line_number":28,"context_line":"from requests import exceptions"},{"line_number":29,"context_line":"import threading"},{"line_number":30,"context_line":"import time"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_1510f200","line":30,"range":{"start_line":23,"start_character":0,"end_line":30,"end_character":11},"updated":"2017-07-25 20:44:12.000000000","message":"3rd party imports should be done before networking_odl ones this seems like a rebase blotch","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from networking_odl.common import utils"},{"line_number":21,"context_line":"from networking_odl.db import db"},{"line_number":22,"context_line":"from networking_odl.journal import dependency_validations"},{"line_number":23,"context_line":"from neutron_lib import context as nl_context"},{"line_number":24,"context_line":"from neutron_lib.callbacks import registry"},{"line_number":25,"context_line":"from neutron_lib.plugins import directory"},{"line_number":26,"context_line":"from oslo_config import cfg"},{"line_number":27,"context_line":"from oslo_log import log as logging"},{"line_number":28,"context_line":"from requests import exceptions"},{"line_number":29,"context_line":"import threading"},{"line_number":30,"context_line":"import time"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_e0d00a22","line":30,"range":{"start_line":23,"start_character":0,"end_line":30,"end_character":11},"in_reply_to":"ff346bd7_1510f200","updated":"2017-07-25 21:20:12.000000000","message":"Oops reverting back.","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"}],"networking_odl/ml2/dhcp_proxy_jc.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"67827f276978858680096c0b4c332cc1d7ac50e7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            subnet \u003d plugin.get_subnet(dbcontext, row.data[\u0027id\u0027])"},{"line_number":41,"context_line":"            context \u003d driver_context.SubnetContext(plugin, dbcontext,"},{"line_number":42,"context_line":"                                                   subnet, network)"},{"line_number":43,"context_line":"            port_id \u003d super(DhcpProxyJc, self)._get_port_id("},{"line_number":44,"context_line":"                context._plugin,"},{"line_number":45,"context_line":"                context._plugin_context,"},{"line_number":46,"context_line":"                context.current[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_827c8283","line":43,"range":{"start_line":43,"start_character":22,"end_line":43,"end_character":27},"updated":"2017-07-05 12:03:31.000000000","message":"this super doesn\u0027t seem necessary.","commit_id":"10464192da363561727c9261ffd4d34ca2530bd5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"67827f276978858680096c0b4c332cc1d7ac50e7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                context.current[\u0027network_id\u0027],"},{"line_number":47,"context_line":"                context.current[\u0027id\u0027])"},{"line_number":48,"context_line":"            if not port_id:"},{"line_number":49,"context_line":"                super(DhcpProxyJc, self).create_dhcp_port(context)"},{"line_number":50,"context_line":"            return True"},{"line_number":51,"context_line":"        except Exception as e:"},{"line_number":52,"context_line":"            LOG.error(\"Error while creating DHCP Port\", e)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_4272eaae","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":21},"updated":"2017-07-05 12:03:31.000000000","message":"ditto","commit_id":"10464192da363561727c9261ffd4d34ca2530bd5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"67827f276978858680096c0b4c332cc1d7ac50e7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            subnet \u003d plugin.get_subnet(dbcontext, row.data[\u0027id\u0027])"},{"line_number":62,"context_line":"            context \u003d driver_context.SubnetContext(plugin, dbcontext, subnet,"},{"line_number":63,"context_line":"                                                   network)"},{"line_number":64,"context_line":"            super(DhcpProxyJc, self).update_dhcp_port(context)"},{"line_number":65,"context_line":"            return True"},{"line_number":66,"context_line":"        except Exception as e:"},{"line_number":67,"context_line":"            LOG.error(\"Error while creating DHCP Port\", e)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_f722d6b8","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":17},"updated":"2017-07-05 12:03:31.000000000","message":"ditto","commit_id":"10464192da363561727c9261ffd4d34ca2530bd5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"67827f276978858680096c0b4c332cc1d7ac50e7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            subnet \u003d plugin.get_subnet(dbcontext, row.data[\u0027id\u0027])"},{"line_number":77,"context_line":"            context \u003d driver_context.SubnetContext(plugin, dbcontext, subnet,"},{"line_number":78,"context_line":"                                                   network)"},{"line_number":79,"context_line":"            super(DhcpProxyJc, self).release_dhcp_port(context)"},{"line_number":80,"context_line":"            return True"},{"line_number":81,"context_line":"        except Exception as e:"},{"line_number":82,"context_line":"            LOG.error(\"Error while creating DHCP Port\", e)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_b728de96","line":79,"range":{"start_line":79,"start_character":12,"end_line":79,"end_character":17},"updated":"2017-07-05 12:03:31.000000000","message":"ditto","commit_id":"10464192da363561727c9261ffd4d34ca2530bd5"}],"networking_odl/ml2/dhcp_proxy_service.py":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from networking_odl.common import config as odl_conf"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from urlparse import urlparse"},{"line_number":25,"context_line":"import collections"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_8927aac7","line":24,"updated":"2017-06-06 17:09:42.000000000","message":"believe we should use\nimport six.moves.urllib.parse as urlparse","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from networking_odl.common import config as odl_conf"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from urlparse import urlparse"},{"line_number":25,"context_line":"import collections"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_9945bb46","line":25,"updated":"2017-06-06 17:09:42.000000000","message":"place built-in imports first, followed by neutron_lib, neutron.objects, oslo_log, oslo_utils, six and then lastly networking_odl.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class OdlDhcpAgent(object):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    hostname\u003d\u0027\u0027"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_ae74b4fe","line":29,"updated":"2017-06-06 17:09:42.000000000","message":"This is not an agent.\n\nPlease name this class as DhcpProxyService.\n\nAlso please push in unit tests for this file.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, url, enable_port):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.setHostFrmUrl(url)"},{"line_number":37,"context_line":"        if enable_port is None:"},{"line_number":38,"context_line":"            self.is_dhcp_enabled \u003d false"},{"line_number":39,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_39822f02","line":36,"updated":"2017-06-06 17:09:42.000000000","message":"an intermix of class variable and object variable.  Would be advisable to use object variables evenly everywhere.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.setHostFrmUrl(url)"},{"line_number":37,"context_line":"        if enable_port is None:"},{"line_number":38,"context_line":"            self.is_dhcp_enabled \u003d false"},{"line_number":39,"context_line":"        else:"},{"line_number":40,"context_line":"            self.is_dhcp_enabled \u003d enable_port"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_d91fb36e","line":38,"updated":"2017-06-06 17:09:42.000000000","message":"this variable is superfluous to be maintained here.\n\nIf you use a journal callback, we have to get the current flag value and based on that invoke create_port / update_port (or) delete_port.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        else:"},{"line_number":40,"context_line":"            self.is_dhcp_enabled \u003d enable_port"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def setHostFrmUrl(self, url):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        if(url is not None):"},{"line_number":45,"context_line":"            OdlDhcpAgent.hostname \u003d urlparse(url).hostname"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_2939bef0","line":42,"updated":"2017-06-06 17:09:42.000000000","message":"no camel cases please.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def setHostFrmUrl(self, url):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        if(url is not None):"},{"line_number":45,"context_line":"            OdlDhcpAgent.hostname \u003d urlparse(url).hostname"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def create_dhcp_port(self, context):"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_0e15e048","line":45,"updated":"2017-06-06 17:09:42.000000000","message":"how can this hostname be a class parameter?   \n\nIt has to be an object parameter such as self.hostname.  If a hostname is not supplied in the URL and only an IPAddress is available, does it create any problems.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def create_dhcp_port(self, context):"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and self.is_dhcp_enabled:"},{"line_number":50,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":51,"context_line":"            plugin \u003d context._plugin"},{"line_number":52,"context_line":"            port \u003d self.get_port_dict(context)"},{"line_number":53,"context_line":"            self.create_port(plugin,context._plugin_context, port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_8e00d003","line":50,"updated":"2017-06-06 17:09:42.000000000","message":"print the subnet id and subnet name here.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and self.is_dhcp_enabled:"},{"line_number":50,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":51,"context_line":"            plugin \u003d context._plugin"},{"line_number":52,"context_line":"            port \u003d self.get_port_dict(context)"},{"line_number":53,"context_line":"            self.create_port(plugin,context._plugin_context, port)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def update_dhcp_port(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_090a7a1e","line":52,"updated":"2017-06-06 17:09:42.000000000","message":"frame_new_dhcp_port()","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def update_dhcp_port(self, context):"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if not context.current[\u0027enable_dhcp\u0027] and context.original[\u0027enable_dhcp\u0027] :"},{"line_number":58,"context_line":"                self.delete_port(context._plugin, context._plugin_context, context.current[\u0027network_id\u0027])"},{"line_number":59,"context_line":"        if context.current[\u0027enable_dhcp\u0027] and not context.original[\u0027enable_dhcp\u0027]  and  self.is_dhcp_enabled:"},{"line_number":60,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled creating port for subnet\")"},{"line_number":61,"context_line":"            plugin \u003d context._plugin"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_a94dcec4","line":58,"updated":"2017-06-06 17:09:42.000000000","message":"the DHCP agent does not delete the dhcp ports until last dhcp-enabled-subnet on a network is removed.\n\nHowever, that case is because of dnsMasQ process driven per network instead of per subnet.\n\nHere, we can go about this differently, but still this call tries to remove all the dhcp ports on all the subnets of the network which seems to be incorrect!","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        if not context.current[\u0027enable_dhcp\u0027] and context.original[\u0027enable_dhcp\u0027] :"},{"line_number":58,"context_line":"                self.delete_port(context._plugin, context._plugin_context, context.current[\u0027network_id\u0027])"},{"line_number":59,"context_line":"        if context.current[\u0027enable_dhcp\u0027] and not context.original[\u0027enable_dhcp\u0027]  and  self.is_dhcp_enabled:"},{"line_number":60,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled creating port for subnet\")"},{"line_number":61,"context_line":"            plugin \u003d context._plugin"},{"line_number":62,"context_line":"            port \u003d self.get_port_dict(context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_69333615","line":59,"updated":"2017-06-06 17:09:42.000000000","message":"how do we handle back-to-back subnet update actions of enable-dhcp and disable-dhcp. When such updates land onto different openstack controllers, our design should be such that the dhcp port must still end up being created.\n\nPlease take care of that case.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.delete_port(context._plugin, context._plugin_context, context._subnet[\u0027network_id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_port_dict(self, context):"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        port_dict \u003d dict("},{"line_number":72,"context_line":"                name\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_0e6e00ff","line":69,"updated":"2017-06-06 17:09:42.000000000","message":"frame_dhcp_port()","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        port_dict \u003d dict("},{"line_number":72,"context_line":"                name\u003d\u0027\u0027,"},{"line_number":73,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":74,"context_line":"                status\u003d\u0027ACTIVE\u0027,"},{"line_number":75,"context_line":"                device_id\u003d\u0027odl:\u0027+OdlDhcpAgent.hostname,"},{"line_number":76,"context_line":"                device_owner\u003d\u0027network:dhcp\u0027,"},{"line_number":77,"context_line":"                network_id\u003dcontext.current[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_ee786cc4","line":74,"updated":"2017-06-06 17:09:42.000000000","message":"Never set the status attribute at all.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                name\u003d\u0027\u0027,"},{"line_number":73,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":74,"context_line":"                status\u003d\u0027ACTIVE\u0027,"},{"line_number":75,"context_line":"                device_id\u003d\u0027odl:\u0027+OdlDhcpAgent.hostname,"},{"line_number":76,"context_line":"                device_owner\u003d\u0027network:dhcp\u0027,"},{"line_number":77,"context_line":"                network_id\u003dcontext.current[\u0027network_id\u0027],"},{"line_number":78,"context_line":"                fixed_ips\u003d[dict(subnet_id\u003dcontext.current[\u0027id\u0027])],"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_2e442473","line":75,"updated":"2017-06-06 17:09:42.000000000","message":"does this kind of a device_id create problems with IPAddresses that may contain a . (for ipv4) and :: (for ipv6)?","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def create_port(self, plugin, context, port):"},{"line_number":83,"context_line":"        \"\"\"Perform port operations taking care of concurrency issues.\"\"\""},{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"             return plugin.create_port(context, port)"},{"line_number":86,"context_line":"        except (db_exc.DBReferenceError,"},{"line_number":87,"context_line":"                exceptions.NetworkNotFound,"},{"line_number":88,"context_line":"                exceptions.SubnetNotFound,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_593a8398","line":85,"updated":"2017-06-06 17:09:42.000000000","message":"instead of directly calling core_plugin. create_port here , we should be using:\nfrom neutron.plugins.common import utils as p_utils\np_utils.create_port(plugin, context, port)\n\nThat does not require special exception handling too!","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def delete_port(self, plugin, context, network_id):"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        deviceId \u003d \u0027odl:\u0027 + OdlDhcpAgent.hostname"},{"line_number":116,"context_line":"        plugin.delete_ports_by_device_id(context, deviceId, network_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_492d1293","line":116,"updated":"2017-06-06 17:09:42.000000000","message":"this will delete all the dhcp ports on all the subnets of this network right?\n\nThis looks to be incorrect behaviour !","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2bf25b3bf335fe1a7bc05c085605e91f93ec17e8","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                exceptions.NetworkNotFound,"},{"line_number":104,"context_line":"                exceptions.SubnetNotFound,"},{"line_number":105,"context_line":"                exceptions.InvalidInput,"},{"line_number":106,"context_line":"                exceptions.IpAddressGenerationFailure) as e:"},{"line_number":107,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctxt:"},{"line_number":108,"context_line":"                if isinstance(e, exceptions.IpAddressGenerationFailure):"},{"line_number":109,"context_line":"                    # Check if the subnet still exists and if it does not,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_00dc8c72","line":106,"updated":"2017-06-09 09:00:19.000000000","message":"is this exception handling necessary?","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"cae60f15ed6edbe77265c44896c5b708576e41de","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                exceptions.NetworkNotFound,"},{"line_number":104,"context_line":"                exceptions.SubnetNotFound,"},{"line_number":105,"context_line":"                exceptions.InvalidInput,"},{"line_number":106,"context_line":"                exceptions.IpAddressGenerationFailure) as e:"},{"line_number":107,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctxt:"},{"line_number":108,"context_line":"                if isinstance(e, exceptions.IpAddressGenerationFailure):"},{"line_number":109,"context_line":"                    # Check if the subnet still exists and if it does not,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_409e0408","line":106,"in_reply_to":"9f0e0f27_00dc8c72","updated":"2017-06-09 09:25:35.000000000","message":"In the is link https://github.com/openstack/neutron/blob/master/neutron/api/rpc/handlers/dhcp_rpc.py line 98 still they handle exceptions","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"c59c0b340aa349645a3671b9dd486b0ea6ee46b0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                exceptions.NetworkNotFound,"},{"line_number":104,"context_line":"                exceptions.SubnetNotFound,"},{"line_number":105,"context_line":"                exceptions.InvalidInput,"},{"line_number":106,"context_line":"                exceptions.IpAddressGenerationFailure) as e:"},{"line_number":107,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctxt:"},{"line_number":108,"context_line":"                if isinstance(e, exceptions.IpAddressGenerationFailure):"},{"line_number":109,"context_line":"                    # Check if the subnet still exists and if it does not,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_836421bb","line":106,"in_reply_to":"9f0e0f27_409e0408","updated":"2017-06-09 12:35:39.000000000","message":"Ok thanks !","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0bea87de4c284095e0ec518ae698018eaa700567","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, url, enable_port):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if(url is not None):"},{"line_number":39,"context_line":"            url_parsed \u003d urlparse(url, scheme\u003d\"http\")"},{"line_number":40,"context_line":"            if url_parsed.hostname:"},{"line_number":41,"context_line":"                self.__hostname \u003d url_parsed.hostname"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_6470b6dd","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":28},"updated":"2017-06-12 23:44:21.000000000","message":"if url is not none: will work too, no need of parenthesis.","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"0947c66221df4d3cb7c647e45721e6afb224aa1a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def __init__(self, url, enable_port):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        if(url is not None):"},{"line_number":39,"context_line":"            url_parsed \u003d urlparse(url, scheme\u003d\"http\")"},{"line_number":40,"context_line":"            if url_parsed.hostname:"},{"line_number":41,"context_line":"                self.__hostname \u003d url_parsed.hostname"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_4a37f8e4","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":28},"in_reply_to":"7f231b9d_6470b6dd","updated":"2017-06-13 11:58:40.000000000","message":"url was primarily used to extract ODL host which was used to set device_id, removing it now as we set DEVICE_ID to OpenDaylight","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0bea87de4c284095e0ec518ae698018eaa700567","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        if enable_port is None:"},{"line_number":48,"context_line":"            self.__is_dhcp_enabled \u003d False"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            self.__is_dhcp_enabled \u003d enable_port"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def create_dhcp_port(self, context):"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_8446327c","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":48},"updated":"2017-06-12 23:44:21.000000000","message":"so what is the difference when enable_port\u003dFalse ?","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"0947c66221df4d3cb7c647e45721e6afb224aa1a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        if enable_port is None:"},{"line_number":48,"context_line":"            self.__is_dhcp_enabled \u003d False"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            self.__is_dhcp_enabled \u003d enable_port"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def create_dhcp_port(self, context):"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_ea848460","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":48},"in_reply_to":"7f231b9d_8446327c","updated":"2017-06-13 11:58:40.000000000","message":"If enable_port is false we will not create dhcp_port when subnet create is called","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0bea87de4c284095e0ec518ae698018eaa700567","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        LOG.debug(\"Deleting DCHP proxy port for sunbet %s\", subnet_id)"},{"line_number":130,"context_line":"        deviceId \u003d \u0027odl:\u0027 + self.__hostname"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        query \u003d context.session.query("},{"line_number":133,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":134,"context_line":"            n_port.device_id \u003d\u003d deviceId).filter("},{"line_number":135,"context_line":"            n_port.fixed_ips.any(models_v2.IPAllocation.subnet_id.in_("},{"line_number":136,"context_line":"                [subnet_id])))"},{"line_number":137,"context_line":"        port_ids \u003d [p[0] for p in query]"},{"line_number":138,"context_line":"        for port in port_ids:"},{"line_number":139,"context_line":"            plugin.delete_port(context, port)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_a79ed0b5","line":139,"range":{"start_line":132,"start_character":7,"end_line":139,"end_character":45},"updated":"2017-06-12 23:44:21.000000000","message":"AFAIU, acc to spec there should be one dhcp port per subnet, this needs to be simplified via using .one_or_none() from sqlalchemy in fetching port (which will make sure there is only or one and it will return exception for multiple ports)\ndeleting ports makes less sense to me here.","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"0947c66221df4d3cb7c647e45721e6afb224aa1a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        LOG.debug(\"Deleting DCHP proxy port for sunbet %s\", subnet_id)"},{"line_number":130,"context_line":"        deviceId \u003d \u0027odl:\u0027 + self.__hostname"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        query \u003d context.session.query("},{"line_number":133,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":134,"context_line":"            n_port.device_id \u003d\u003d deviceId).filter("},{"line_number":135,"context_line":"            n_port.fixed_ips.any(models_v2.IPAllocation.subnet_id.in_("},{"line_number":136,"context_line":"                [subnet_id])))"},{"line_number":137,"context_line":"        port_ids \u003d [p[0] for p in query]"},{"line_number":138,"context_line":"        for port in port_ids:"},{"line_number":139,"context_line":"            plugin.delete_port(context, port)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f231b9d_72662a2c","line":139,"range":{"start_line":132,"start_character":7,"end_line":139,"end_character":45},"in_reply_to":"7f231b9d_a79ed0b5","updated":"2017-06-13 11:58:40.000000000","message":"There can be multiple dhcp port, both neutron dhcp(q-dhcp) and the dhcp proxy port created by us can coexist, in this case both the ports will have device_owner network:dhcp and we need to query for port and apply filter on device_id and fixed_ips having sunbet_id, otherwise we could\u0027ve directly applied filter_by on IPAllocation for subnet_id","commit_id":"73a2d1a8c71d0d60652cf35c7859639a702788ab"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class DhcpProxyService(object):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, enable_port):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if enable_port is None:"},{"line_number":37,"context_line":"            self.__is_dhcp_enabled \u003d False"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_8371f378","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":34},"updated":"2017-06-16 23:51:40.000000000","message":"please invent more meaningful name.\nenable_dhcp_proxy?","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def __init__(self, enable_port):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if enable_port is None:"},{"line_number":37,"context_line":"            self.__is_dhcp_enabled \u003d False"},{"line_number":38,"context_line":"        else:"},{"line_number":39,"context_line":"            self.__is_dhcp_enabled \u003d enable_port"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_036603c2","line":37,"range":{"start_line":37,"start_character":17,"end_line":37,"end_character":20},"updated":"2017-06-16 23:51:40.000000000","message":"_(single under score)","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def __init__(self, enable_port):"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if enable_port is None:"},{"line_number":37,"context_line":"            self.__is_dhcp_enabled \u003d False"},{"line_number":38,"context_line":"        else:"},{"line_number":39,"context_line":"            self.__is_dhcp_enabled \u003d enable_port"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_c35b6bf3","line":37,"range":{"start_line":37,"start_character":37,"end_line":37,"end_character":42},"updated":"2017-06-16 23:51:40.000000000","message":"bool(enable_port)","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            self._create_port(plugin, context._plugin_context, port)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def update_dhcp_port(self, context):"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if (not context.current[\u0027enable_dhcp\u0027] and"},{"line_number":53,"context_line":"                context.original[\u0027enable_dhcp\u0027]):"},{"line_number":54,"context_line":"            port_id \u003d self._get_port_id("}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_a3fbcfbe","line":51,"updated":"2017-06-16 23:51:40.000000000","message":"isn\u0027t is_dhcp_enabled check needed?","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    context._plugin,"},{"line_number":62,"context_line":"                    context._plugin_context,"},{"line_number":63,"context_line":"                    port_id)"},{"line_number":64,"context_line":"        if (context.current[\u0027enable_dhcp\u0027] and not"},{"line_number":65,"context_line":"                context.original[\u0027enable_dhcp\u0027] and"},{"line_number":66,"context_line":"                self.__is_dhcp_enabled):"},{"line_number":67,"context_line":"            LOG.debug(\"Creating DHCP Proxy port for subnet %s of network %s\","},{"line_number":68,"context_line":"                      context.current[\u0027network_id\u0027], context.current[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_03d96355","line":65,"range":{"start_line":64,"start_character":47,"end_line":65,"end_character":47},"updated":"2017-06-16 23:51:40.000000000","message":"This indent seems unusual because it contradicts with operator priority.","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            self._create_port(plugin, context._plugin_context, port)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        port_id \u003d self._get_port_id("},{"line_number":76,"context_line":"            context._plugin,"},{"line_number":77,"context_line":"            context._plugin_context,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_43fcfbb3","line":74,"updated":"2017-06-16 23:51:40.000000000","message":"isn\u0027t is_dhcp_enabled check needed?","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def _make_dhcp_port_dict(self, context):"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        port_dict \u003d dict("},{"line_number":89,"context_line":"            name\u003d\u0027\u0027,"},{"line_number":90,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":91,"context_line":"            device_id\u003dDEVICE_ID + \u0027-\u0027 + context.current[\u0027id\u0027],"},{"line_number":92,"context_line":"            device_owner\u003dn_const.DEVICE_OWNER_DHCP,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_c3292b37","line":89,"range":{"start_line":89,"start_character":17,"end_line":89,"end_character":19},"updated":"2017-06-16 23:51:40.000000000","message":"Let\u0027s put something useful.","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"319330939826b6d22e32db84f443234b18254534","unresolved":false,"context_lines":[{"line_number":29,"context_line":"DEVICE_ID \u003d \u0027OpenDaylight\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class DhcpProxyService(object):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, enable_port):"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_6a3c662e","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":22},"updated":"2017-07-06 16:25:09.000000000","message":"Shall I rename to OdlDhcp(Manager/Handler/Provider)?","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"d36197f36a5f81a0421e9f926898414002b29682","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and self.__is_dhcp_enabled:"},{"line_number":44,"context_line":"            LOG.debug(\"Creating DHCP Proxy port for subnet %s of network %s\","},{"line_number":45,"context_line":"                      context.current[\u0027network_id\u0027], context.current[\u0027id\u0027])"},{"line_number":46,"context_line":"            port \u003d self._make_dhcp_port_dict(context)"},{"line_number":47,"context_line":"            plugin \u003d context._plugin"},{"line_number":48,"context_line":"            self._create_port(plugin, context._plugin_context, port)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# NOTE: validating  based on value change of enable_dhcp instead"},{"line_number":51,"context_line":"# validating on port_id presence of port by locking the session, this"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_2601fb38","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":68},"updated":"2017-07-07 00:46:21.000000000","message":"we need to check if dhcp port exists or not.\nIn case of neutron crash, this method can be called multiple times.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and self.__is_dhcp_enabled:"},{"line_number":44,"context_line":"            LOG.debug(\"Creating DHCP Proxy port for subnet %s of network %s\","},{"line_number":45,"context_line":"                      context.current[\u0027network_id\u0027], context.current[\u0027id\u0027])"},{"line_number":46,"context_line":"            port \u003d self._make_dhcp_port_dict(context)"},{"line_number":47,"context_line":"            plugin \u003d context._plugin"},{"line_number":48,"context_line":"            self._create_port(plugin, context._plugin_context, port)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# NOTE: validating  based on value change of enable_dhcp instead"},{"line_number":51,"context_line":"# validating on port_id presence of port by locking the session, this"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_5c55dff8","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":68},"in_reply_to":"3f1d235d_2601fb38","updated":"2017-07-08 19:55:00.000000000","message":"OK.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                  context._plugin_context,"},{"line_number":68,"context_line":"                                  port_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        port_id \u003d self._get_port_id(context._plugin,"},{"line_number":73,"context_line":"                                    context._plugin_context,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_101f5508","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":15},"updated":"2017-07-06 23:02:10.000000000","message":"delete is commonly used in Neutron.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                  context._plugin_context,"},{"line_number":68,"context_line":"                                  port_id)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def release_dhcp_port(self, context):"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        port_id \u003d self._get_port_id(context._plugin,"},{"line_number":73,"context_line":"                                    context._plugin_context,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_5c7cbf70","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":15},"in_reply_to":"3f1d235d_101f5508","updated":"2017-07-08 19:55:00.000000000","message":"Neutron DHCP uses release_dhcp_port hence used the same ,https://github.com/openstack/neutron/blob/master/neutron/agent/dhcp/agent.py","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        except (db_exc.DBReferenceError,"},{"line_number":100,"context_line":"                exceptions.NetworkNotFound,"},{"line_number":101,"context_line":"                exceptions.SubnetNotFound,"},{"line_number":102,"context_line":"                exceptions.InvalidInput,"},{"line_number":103,"context_line":"                exceptions.IpAddressGenerationFailure) as e:"},{"line_number":104,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctxt:"},{"line_number":105,"context_line":"                if isinstance(e, exceptions.IpAddressGenerationFailure):"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_7026896a","line":102,"range":{"start_line":102,"start_character":16,"end_line":102,"end_character":40},"updated":"2017-07-06 23:02:10.000000000","message":"When does this case happen?","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        except (db_exc.DBReferenceError,"},{"line_number":100,"context_line":"                exceptions.NetworkNotFound,"},{"line_number":101,"context_line":"                exceptions.SubnetNotFound,"},{"line_number":102,"context_line":"                exceptions.InvalidInput,"},{"line_number":103,"context_line":"                exceptions.IpAddressGenerationFailure) as e:"},{"line_number":104,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse) as ctxt:"},{"line_number":105,"context_line":"                if isinstance(e, exceptions.IpAddressGenerationFailure):"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_7cee5b22","line":102,"range":{"start_line":102,"start_character":16,"end_line":102,"end_character":40},"in_reply_to":"3f1d235d_7026896a","updated":"2017-07-08 19:55:00.000000000","message":"Neutron DHCP Agent uses same syntax while creating port.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                    try:"},{"line_number":110,"context_line":"                        subnet_id \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027]"},{"line_number":111,"context_line":"                        plugin.get_subnet(context, subnet_id)"},{"line_number":112,"context_line":"                    except exceptions.SubnetNotFound:"},{"line_number":113,"context_line":"                        pass"},{"line_number":114,"context_line":"                    else:"},{"line_number":115,"context_line":"                        ctxt.reraise \u003d True"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_d0fb1dbb","line":112,"range":{"start_line":112,"start_character":38,"end_line":112,"end_character":52},"updated":"2017-07-06 23:02:10.000000000","message":"What about NetworkNotFound case?","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                        subnet_id \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027]"},{"line_number":111,"context_line":"                        plugin.get_subnet(context, subnet_id)"},{"line_number":112,"context_line":"                    except exceptions.SubnetNotFound:"},{"line_number":113,"context_line":"                        pass"},{"line_number":114,"context_line":"                    else:"},{"line_number":115,"context_line":"                        ctxt.reraise \u003d True"},{"line_number":116,"context_line":"                if ctxt.reraise:"},{"line_number":117,"context_line":"                    # net_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":118,"context_line":"                    LOG.warning(\"DHCP Proxy Port creation failed %s\", e)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_b00781ca","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":43},"updated":"2017-07-06 23:02:10.000000000","message":"at line 104, we can set reraise\u003dTrue. Then we can eliminate line 113-115 into one line.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                        subnet_id \u003d port[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027]"},{"line_number":111,"context_line":"                        plugin.get_subnet(context, subnet_id)"},{"line_number":112,"context_line":"                    except exceptions.SubnetNotFound:"},{"line_number":113,"context_line":"                        pass"},{"line_number":114,"context_line":"                    else:"},{"line_number":115,"context_line":"                        ctxt.reraise \u003d True"},{"line_number":116,"context_line":"                if ctxt.reraise:"},{"line_number":117,"context_line":"                    # net_id \u003d port[\u0027port\u0027][\u0027network_id\u0027]"},{"line_number":118,"context_line":"                    LOG.warning(\"DHCP Proxy Port creation failed %s\", e)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_fcd94b82","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":43},"in_reply_to":"3f1d235d_b00781ca","updated":"2017-07-08 19:55:00.000000000","message":"OK","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"}],"networking_odl/ml2/dhcp_proxy_service_v2.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"1e39ffd3e79c10a4b71872f16d27ec5bd65cb2d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3f1d235d_dd76b470","updated":"2017-07-06 09:37:34.000000000","message":"Why is this class split to 2? You don\u0027t use DhcpProxyService anywhere else but here..","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class DhcpProxyServiceV2(dhcp_proxy_service.DhcpProxyService):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @journal_callback.register_for_journal_callback(journal_state\u003d\u0027completed\u0027)"},{"line_number":32,"context_line":"    def __init__(self, enable_port):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        super(DhcpProxyServiceV2, self).__init__(enable_port)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_b078a18f","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":78},"updated":"2017-07-06 23:02:10.000000000","message":"If we use callback registry, we can simply register callback when option is set.\nif option is set to disable, just return it without doing anything.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class DhcpProxyServiceV2(dhcp_proxy_service.DhcpProxyService):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @journal_callback.register_for_journal_callback(journal_state\u003d\u0027completed\u0027)"},{"line_number":32,"context_line":"    def __init__(self, enable_port):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        super(DhcpProxyServiceV2, self).__init__(enable_port)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_bc6633ba","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":78},"in_reply_to":"3f1d235d_b078a18f","updated":"2017-07-08 19:55:00.000000000","message":"OK","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def create_subnet(self, session, row):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        dbcontext \u003d neutron_context.get_admin_context()"},{"line_number":39,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            network \u003d plugin.get_network(dbcontext, row.data[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_306c91cc","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":55},"updated":"2017-07-06 23:02:10.000000000","message":"session needs to be used.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"07b0d977593d9de32e6f38f398e6cedef81ff6be","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def create_subnet(self, session, row):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        dbcontext \u003d neutron_context.get_admin_context()"},{"line_number":39,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            network \u003d plugin.get_network(dbcontext, row.data[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_bf7e22ac","line":38,"range":{"start_line":38,"start_character":8,"end_line":38,"end_character":55},"in_reply_to":"3f1d235d_306c91cc","updated":"2017-07-08 19:55:00.000000000","message":"OK","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fac7ae45a8d27a0d6a9fe45b08bc280973b75322","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def update_subnet(self, session, row):"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        dbcontext \u003d neutron_context.get_admin_context()"},{"line_number":60,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            network \u003d plugin.get_network(dbcontext, row.data[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_10dab576","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":55},"updated":"2017-07-06 23:02:10.000000000","message":"ditto","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"}],"networking_odl/ml2/mech_driver_v2.py":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab3cde2c76e55471679df5494121d6aab2930cfe","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        self._postcommit(context)"},{"line_number":302,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and cfg.CONF.ml2_odl.enable_netvirt_port:"},{"line_number":303,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":304,"context_line":"            plugin \u003d context._plugin"},{"line_number":305,"context_line":"            port_dict \u003d dict("}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_3a66d8c2","line":302,"updated":"2017-06-05 06:41:21.000000000","message":"Having a separate journal callback (or) inline coding in subnet-postcommit are both ok approaches.\n\nHowever, having a journal callback approach gives us the advantage that we will be creating the DHCP Port only when the subnet information is delivered to ODL.  \n\nIsaku also quoted that a single pending journal record will be processed by only one neutron-server at a time and not all the neutron servers at the same time.  \n\nSo creating a DHCP Port as part of the journal callback between processing and completed states of journal would look to be a better approach.  \n\nWhat is unclear is how will the journal callback work for the deletion lifecycle and it needs to be looked in further?\n\nSo for now we will continue with using postcommit itself.","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1c4430b700ce6dbc3dc5001345f501c52daac21e","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        self._postcommit(context)"},{"line_number":302,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and cfg.CONF.ml2_odl.enable_netvirt_port:"},{"line_number":303,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":304,"context_line":"            plugin \u003d context._plugin"},{"line_number":305,"context_line":"            port_dict \u003d dict("}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_7a98d073","line":302,"in_reply_to":"df140735_3a66d8c2","updated":"2017-06-05 16:32:49.000000000","message":"OK, what about neutron server crash handling, if server crashes between subnet commit(once data is in db for subnet) and port commit to db?","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"c2bf8c6c1edb34d415e4a6d44564ac636011f5d8","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        self._postcommit(context)"},{"line_number":302,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and cfg.CONF.ml2_odl.enable_netvirt_port:"},{"line_number":303,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":304,"context_line":"            plugin \u003d context._plugin"},{"line_number":305,"context_line":"            port_dict \u003d dict("}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_767c4d71","line":302,"in_reply_to":"df140735_7a98d073","updated":"2017-06-06 03:50:29.000000000","message":"I am not sure of this question.. \n\nDid you mean how do we handle Neutron Server Crash if its lands up such that subnet_postcommit never got invoked, but subnet went successfully into Neutron DB?\n\nIf that\u0027s the question, then journal callback approach would be the best answer for the same.","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab3cde2c76e55471679df5494121d6aab2930cfe","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        self._postcommit(context)"},{"line_number":302,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and cfg.CONF.ml2_odl.enable_netvirt_port:"},{"line_number":303,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":304,"context_line":"            plugin \u003d context._plugin"},{"line_number":305,"context_line":"            port_dict \u003d dict("},{"line_number":306,"context_line":"                name\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_5a874c63","line":303,"updated":"2017-06-05 06:41:21.000000000","message":"better to have a new file with new class created dhcp_proxy_service.py.  Instantiate a singleton of that one and use that object to invoke methods within the same.","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1c4430b700ce6dbc3dc5001345f501c52daac21e","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        self._postcommit(context)"},{"line_number":302,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and cfg.CONF.ml2_odl.enable_netvirt_port:"},{"line_number":303,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":304,"context_line":"            plugin \u003d context._plugin"},{"line_number":305,"context_line":"            port_dict \u003d dict("},{"line_number":306,"context_line":"                name\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_fa850008","line":303,"in_reply_to":"df140735_5a874c63","updated":"2017-06-05 16:32:49.000000000","message":"Already we\u0027ve create new file, with nme odl_agents.py with class OdlDHCPAgent will rename to dhcp_proxy_service.py","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"c2bf8c6c1edb34d415e4a6d44564ac636011f5d8","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        self._postcommit(context)"},{"line_number":302,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and cfg.CONF.ml2_odl.enable_netvirt_port:"},{"line_number":303,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":304,"context_line":"            plugin \u003d context._plugin"},{"line_number":305,"context_line":"            port_dict \u003d dict("},{"line_number":306,"context_line":"                name\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_f6617dd4","line":303,"in_reply_to":"df140735_fa850008","updated":"2017-06-06 03:50:29.000000000","message":"where is that file in this review?","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab3cde2c76e55471679df5494121d6aab2930cfe","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and cfg.CONF.ml2_odl.enable_netvirt_port:"},{"line_number":303,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":304,"context_line":"            plugin \u003d context._plugin"},{"line_number":305,"context_line":"            port_dict \u003d dict("},{"line_number":306,"context_line":"                name\u003d\u0027\u0027,"},{"line_number":307,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":308,"context_line":"                status\u003d\u0027ACTIVE\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_fade203c","line":305,"updated":"2017-06-05 06:41:21.000000000","message":"move all port-dict creation stuff inside the dhcp-proxy-service class, method create_dhcp_port().","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1c4430b700ce6dbc3dc5001345f501c52daac21e","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        if context._subnet[\u0027enable_dhcp\u0027] and cfg.CONF.ml2_odl.enable_netvirt_port:"},{"line_number":303,"context_line":"            LOG.debug(\"Netvirt Port creation is enabled, creating port for subnet\")"},{"line_number":304,"context_line":"            plugin \u003d context._plugin"},{"line_number":305,"context_line":"            port_dict \u003d dict("},{"line_number":306,"context_line":"                name\u003d\u0027\u0027,"},{"line_number":307,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":308,"context_line":"                status\u003d\u0027ACTIVE\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_ba7b0826","line":305,"in_reply_to":"df140735_fade203c","updated":"2017-06-05 16:32:49.000000000","message":"sure","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab3cde2c76e55471679df5494121d6aab2930cfe","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            port_dict \u003d dict("},{"line_number":306,"context_line":"                name\u003d\u0027\u0027,"},{"line_number":307,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":308,"context_line":"                status\u003d\u0027ACTIVE\u0027,"},{"line_number":309,"context_line":"                device_id\u003d\u0027odl:\u0027+OpenDaylightMechanismDriver.hostname,"},{"line_number":310,"context_line":"                device_owner\u003d\u0027network:dhcp\u0027,"},{"line_number":311,"context_line":"                network_id\u003dcontext._subnet[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_ba6788e9","line":308,"updated":"2017-06-05 06:41:21.000000000","message":"we should not be driving status here..","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"c2bf8c6c1edb34d415e4a6d44564ac636011f5d8","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            port_dict \u003d dict("},{"line_number":306,"context_line":"                name\u003d\u0027\u0027,"},{"line_number":307,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":308,"context_line":"                status\u003d\u0027ACTIVE\u0027,"},{"line_number":309,"context_line":"                device_id\u003d\u0027odl:\u0027+OpenDaylightMechanismDriver.hostname,"},{"line_number":310,"context_line":"                device_owner\u003d\u0027network:dhcp\u0027,"},{"line_number":311,"context_line":"                network_id\u003dcontext._subnet[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_b69d45bd","line":308,"in_reply_to":"df140735_5a92ac4d","updated":"2017-06-06 03:50:29.000000000","message":"Status cannot be driven by an entity that is creating the port!","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1c4430b700ce6dbc3dc5001345f501c52daac21e","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            port_dict \u003d dict("},{"line_number":306,"context_line":"                name\u003d\u0027\u0027,"},{"line_number":307,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":308,"context_line":"                status\u003d\u0027ACTIVE\u0027,"},{"line_number":309,"context_line":"                device_id\u003d\u0027odl:\u0027+OpenDaylightMechanismDriver.hostname,"},{"line_number":310,"context_line":"                device_owner\u003d\u0027network:dhcp\u0027,"},{"line_number":311,"context_line":"                network_id\u003dcontext._subnet[\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_5a92ac4d","line":308,"in_reply_to":"df140735_ba6788e9","updated":"2017-06-05 16:32:49.000000000","message":"OK, there is no significance for status, can we remove?","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"ab3cde2c76e55471679df5494121d6aab2930cfe","unresolved":false,"context_lines":[{"line_number":307,"context_line":"                admin_state_up\u003dTrue,"},{"line_number":308,"context_line":"                status\u003d\u0027ACTIVE\u0027,"},{"line_number":309,"context_line":"                device_id\u003d\u0027odl:\u0027+OpenDaylightMechanismDriver.hostname,"},{"line_number":310,"context_line":"                device_owner\u003d\u0027network:dhcp\u0027,"},{"line_number":311,"context_line":"                network_id\u003dcontext._subnet[\u0027network_id\u0027],"},{"line_number":312,"context_line":"                fixed_ips\u003d[dict(subnet_id\u003dcontext._subnet[\u0027id\u0027])],"},{"line_number":313,"context_line":"                tenant_id\u003dcontext.network.current[\u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_9a904497","line":310,"updated":"2017-06-05 06:41:21.000000000","message":"are we sure that DHCP agent doesn\u0027t misassume and work on ODL created dhcp ports when we use the device_owner value as \u0027network:dhcp\u0027.","commit_id":"d1108a680d834859bd682b3713675f10d87666b2"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":287,"context_line":"        self._postcommit(context)"},{"line_number":288,"context_line":"        self.odl_dhcp_agent.create_dhcp_port(context)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":291,"context_line":"        self._postcommit(context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_f9f7178c","line":288,"updated":"2017-06-06 17:09:42.000000000","message":"as i said in an earlier comment, to cover the case where a neutron server crashes before invoking postcommit, its better to use journal callback mechanisms.\n\nDirectly using postcommit in such circumstances will gape a hole on dhcp-enabled subnets that can\u0027t complete its lifecycle becasue of neutron crash.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":291,"context_line":"        self._postcommit(context)"},{"line_number":292,"context_line":"        self.odl_dhcp_agent.update_dhcp_port(context)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":295,"context_line":"        self._postcommit(context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_dc0d6136","line":292,"updated":"2017-06-06 17:09:42.000000000","message":"better to check the flag here before invoking update_dhcp_port.. within update_dhcp_port remove references to the flag checks.\n\nSame commen applies to create_dhcp_port and delete_dhcp_port invocations in this file.","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2168f0203cc8b3f27199bed06a5979ea579ca53e","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":295,"context_line":"        self._postcommit(context)"},{"line_number":296,"context_line":"        self.odl_dhcp_agent.release_dhcp_port(context)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    @log_helpers.log_method_call"},{"line_number":299,"context_line":"    def bind_port(self, port_context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_99a6db53","line":296,"updated":"2017-06-06 17:09:42.000000000","message":"we need to provide new functional test cases to cover the dhcp port creation (by setting enable_netvirt to True in the test) and make sure those tests succeed after adding so here:\n\n https://github.com/openstack/networking-odl/blob/master/networking_odl/tests/functional/test_ml2_drivers.py","commit_id":"926f9ca32c8d477fccb6dcd73cc7dbc7080285d5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2bf25b3bf335fe1a7bc05c085605e91f93ec17e8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@postcommit.add_postcommit(\u0027network\u0027, \u0027subnet\u0027, \u0027port\u0027)"},{"line_number":46,"context_line":"class OpenDaylightMechanismDriver(api.MechanismDriver):"},{"line_number":47,"context_line":"    \"\"\"OpenDaylight Python Driver for Neutron."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_802d3c48","line":45,"updated":"2017-06-09 09:00:19.000000000","message":"this annotation adds the postcommit hooks dynamically.  Since you want to do special processing for subnet, you should remove subnet from this list and manually put action_subnet_postcommit() methods.","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"cae60f15ed6edbe77265c44896c5b708576e41de","unresolved":false,"context_lines":[{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@postcommit.add_postcommit(\u0027network\u0027, \u0027subnet\u0027, \u0027port\u0027)"},{"line_number":46,"context_line":"class OpenDaylightMechanismDriver(api.MechanismDriver):"},{"line_number":47,"context_line":"    \"\"\"OpenDaylight Python Driver for Neutron."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_804bfc85","line":45,"in_reply_to":"9f0e0f27_802d3c48","updated":"2017-06-09 09:25:35.000000000","message":"Yeah, I see in that code, methods getting added incase methods are missing in the class. Anyway its temporary code as we are moving to callback","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2bf25b3bf335fe1a7bc05c085605e91f93ec17e8","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":281,"context_line":"        self._postcommit(context)"},{"line_number":282,"context_line":"        self.__dhcp_proxy.create_dhcp_port(context)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":285,"context_line":"        self._postcommit(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_40272466","line":282,"updated":"2017-06-09 09:00:19.000000000","message":"am expecting the move to journal callbacks in the next PS as you have recommended Alternative 2 in the Openstack Spec.","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"cae60f15ed6edbe77265c44896c5b708576e41de","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":281,"context_line":"        self._postcommit(context)"},{"line_number":282,"context_line":"        self.__dhcp_proxy.create_dhcp_port(context)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":285,"context_line":"        self._postcommit(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_005fec41","line":282,"in_reply_to":"9f0e0f27_40272466","updated":"2017-06-09 09:25:35.000000000","message":"Sure","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"2bf25b3bf335fe1a7bc05c085605e91f93ec17e8","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":285,"context_line":"        self._postcommit(context)"},{"line_number":286,"context_line":"        self.__dhcp_proxy.update_dhcp_port(context)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":289,"context_line":"        self._postcommit(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_00e6cc17","line":286,"updated":"2017-06-09 09:00:19.000000000","message":"what if the hostname in ODL URL is changed in a deployed cloud?  \n\nHow will you clean up the dhcp ports for the old subnet?\n\nBTW, what is the reason for appending hostname to the device_id?","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"cae60f15ed6edbe77265c44896c5b708576e41de","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":285,"context_line":"        self._postcommit(context)"},{"line_number":286,"context_line":"        self.__dhcp_proxy.update_dhcp_port(context)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":289,"context_line":"        self._postcommit(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_6b03290f","line":286,"in_reply_to":"9f0e0f27_00e6cc17","updated":"2017-06-09 09:25:35.000000000","message":"Hmm...... we might end up with port never getting removed. It was agreed to set device_id as odl+ip address of the Target ODL","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"c59c0b340aa349645a3671b9dd486b0ea6ee46b0","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":285,"context_line":"        self._postcommit(context)"},{"line_number":286,"context_line":"        self.__dhcp_proxy.update_dhcp_port(context)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":289,"context_line":"        self._postcommit(context)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f0e0f27_234af526","line":286,"in_reply_to":"9f0e0f27_6b03290f","updated":"2017-06-09 12:35:39.000000000","message":"We cannot afford that failure.. \n\nCan\u0027t we just use keyword \u0027OpenDaylight\u0027 in the device_id instead of unnecessarily appending the hostname to it?\n\nIf you want to keep the hostname appended like how stock dhcp implementation behaves, just append it for namesake.\n\nWhen you try to delete ODL DHCP ports, donot use hostname match to delete the port.  More specifically, get all DHCP ports first by filtering for network:dhcp and then filter out that result by subnet-id and then again filter out by which one has device_id starting with \u0027OpenDaylight\u0027 and just remove that blindly.","commit_id":"bcba6cc9130634d32a0d15f3f72ec6cd91b54920"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"250da229a328ef171d69d811f5d80a19559f0c47","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def initialize(self):"},{"line_number":54,"context_line":"        LOG.debug(\"Initializing OpenDaylight ML2 driver\")"},{"line_number":55,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":56,"context_line":"        self.__dhcp_proxy \u003d dhcp_proxy_service.DhcpProxyService("},{"line_number":57,"context_line":"            cfg.CONF.ml2_odl.enable_dhcp_proxy)"},{"line_number":58,"context_line":"        self.sg_handler \u003d callback.OdlSecurityGroupsHandler("},{"line_number":59,"context_line":"            self.sync_from_callback_precommit,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7f231b9d_23633fb4","line":56,"range":{"start_line":56,"start_character":13,"end_line":56,"end_character":15},"updated":"2017-06-16 23:51:40.000000000","message":"_(single under score).\nAs double underscore has special meaning in python, please use single under score unless you have really such intention.","commit_id":"b8d9e3d10dc6581c396bc12b85d4c22770a7164b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"67827f276978858680096c0b4c332cc1d7ac50e7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from networking_odl.journal import maintenance"},{"line_number":34,"context_line":"from networking_odl.journal import recovery"},{"line_number":35,"context_line":"from networking_odl.ml2 import dhcp_proxy_jc as dhcp_jc"},{"line_number":36,"context_line":"\u0027\u0027\u0027from networking_odl.ml2 import dhcp_proxy_service \u0027\u0027\u0027"},{"line_number":37,"context_line":"from networking_odl.ml2 import port_binding"},{"line_number":38,"context_line":"from networking_odl.ml2 import port_status_update"},{"line_number":39,"context_line":"from networking_odl.qos import qos_driver_v2 as qos_driver"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_62c966aa","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":56},"updated":"2017-07-05 12:03:31.000000000","message":"WIP?","commit_id":"10464192da363561727c9261ffd4d34ca2530bd5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"67827f276978858680096c0b4c332cc1d7ac50e7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@postcommit.add_postcommit(\u0027network\u0027, \u0027subnet\u0027, \u0027port\u0027)"},{"line_number":46,"context_line":"class OpenDaylightMechanismDriver(api.MechanismDriver):"},{"line_number":47,"context_line":"    \"\"\"OpenDaylight Python Driver for Neutron."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_22dece6c","line":45,"range":{"start_line":45,"start_character":39,"end_line":45,"end_character":45},"updated":"2017-07-05 12:03:31.000000000","message":"is this necessary?","commit_id":"10464192da363561727c9261ffd4d34ca2530bd5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"67827f276978858680096c0b4c332cc1d7ac50e7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def initialize(self):"},{"line_number":54,"context_line":"        LOG.debug(\"Initializing OpenDaylight ML2 driver\")"},{"line_number":55,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":56,"context_line":"#        self.__dhcp_proxy \u003d dhcp_proxy_service.DhcpProxyService("},{"line_number":57,"context_line":"#            cfg.CONF.ml2_odl.enable_dhcp_proxy)"},{"line_number":58,"context_line":"        self.__dhcp_proxy \u003d dhcp_jc.DhcpProxyJc("},{"line_number":59,"context_line":"            cfg.CONF.ml2_odl.create_opendaylight_dhcp_port)"},{"line_number":60,"context_line":"        self.sg_handler \u003d callback.OdlSecurityGroupsHandler("}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_42ce6ab4","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":48},"updated":"2017-07-05 12:03:31.000000000","message":"WIP?","commit_id":"10464192da363561727c9261ffd4d34ca2530bd5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"67827f276978858680096c0b4c332cc1d7ac50e7","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":212,"context_line":"        self._postcommit(context)"},{"line_number":213,"context_line":"        self.__dhcp_proxy.release_dhcp_port(context)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    @log_helpers.log_method_call"},{"line_number":216,"context_line":"    def bind_port(self, port_context):"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_42ad4a99","line":213,"updated":"2017-07-05 12:03:31.000000000","message":"why do you need both of journal callback stuff and these postcommit methods?","commit_id":"10464192da363561727c9261ffd4d34ca2530bd5"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"1e39ffd3e79c10a4b71872f16d27ec5bd65cb2d5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from networking_odl.journal import maintenance"},{"line_number":34,"context_line":"from networking_odl.journal import recovery"},{"line_number":35,"context_line":"from networking_odl.ml2 import dhcp_proxy_service_v2"},{"line_number":36,"context_line":"\u0027\u0027\u0027from networking_odl.ml2 import dhcp_proxy_service \u0027\u0027\u0027"},{"line_number":37,"context_line":"from networking_odl.ml2 import port_binding"},{"line_number":38,"context_line":"from networking_odl.ml2 import port_status_update"},{"line_number":39,"context_line":"from networking_odl.qos import qos_driver_v2 as qos_driver"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_bd953889","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":56},"updated":"2017-07-06 09:37:34.000000000","message":"Huh?","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"319330939826b6d22e32db84f443234b18254534","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from networking_odl.journal import maintenance"},{"line_number":34,"context_line":"from networking_odl.journal import recovery"},{"line_number":35,"context_line":"from networking_odl.ml2 import dhcp_proxy_service_v2"},{"line_number":36,"context_line":"\u0027\u0027\u0027from networking_odl.ml2 import dhcp_proxy_service \u0027\u0027\u0027"},{"line_number":37,"context_line":"from networking_odl.ml2 import port_binding"},{"line_number":38,"context_line":"from networking_odl.ml2 import port_status_update"},{"line_number":39,"context_line":"from networking_odl.qos import qos_driver_v2 as qos_driver"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_4a6c0a9b","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":56},"in_reply_to":"3f1d235d_bd953889","updated":"2017-07-06 16:25:09.000000000","message":"Still WIP","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"1e39ffd3e79c10a4b71872f16d27ec5bd65cb2d5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def initialize(self):"},{"line_number":54,"context_line":"        LOG.debug(\"Initializing OpenDaylight ML2 driver\")"},{"line_number":55,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":56,"context_line":"#        self.__dhcp_proxy \u003d dhcp_proxy_service.DhcpProxyService("},{"line_number":57,"context_line":"#            cfg.CONF.ml2_odl.enable_dhcp_proxy)"},{"line_number":58,"context_line":"        self.__dhcp_proxy \u003d dhcp_proxy_service_v2.DhcpProxyServiceV2("},{"line_number":59,"context_line":"            cfg.CONF.ml2_odl.create_opendaylight_dhcp_port)"},{"line_number":60,"context_line":"        self.sg_handler \u003d callback.OdlSecurityGroupsHandler("}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_bddad874","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":48},"updated":"2017-07-06 09:37:34.000000000","message":"Remove this","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"4db1bd70b09de69768889374dbec908a8abebbbe","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":56,"context_line":"#        self.__dhcp_proxy \u003d dhcp_proxy_service.DhcpProxyService("},{"line_number":57,"context_line":"#            cfg.CONF.ml2_odl.enable_dhcp_proxy)"},{"line_number":58,"context_line":"        self.__dhcp_proxy \u003d dhcp_proxy_service_v2.DhcpProxyServiceV2("},{"line_number":59,"context_line":"            cfg.CONF.ml2_odl.create_opendaylight_dhcp_port)"},{"line_number":60,"context_line":"        self.sg_handler \u003d callback.OdlSecurityGroupsHandler("},{"line_number":61,"context_line":"            self.sync_from_callback_precommit,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_9823a3a7","line":58,"updated":"2017-07-06 12:58:37.000000000","message":"why do we have V2 suffix? Is this because we are tinkering with v2 mech driver :) ?\n\nWould be great to avoid it.","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"319330939826b6d22e32db84f443234b18254534","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":56,"context_line":"#        self.__dhcp_proxy \u003d dhcp_proxy_service.DhcpProxyService("},{"line_number":57,"context_line":"#            cfg.CONF.ml2_odl.enable_dhcp_proxy)"},{"line_number":58,"context_line":"        self.__dhcp_proxy \u003d dhcp_proxy_service_v2.DhcpProxyServiceV2("},{"line_number":59,"context_line":"            cfg.CONF.ml2_odl.create_opendaylight_dhcp_port)"},{"line_number":60,"context_line":"        self.sg_handler \u003d callback.OdlSecurityGroupsHandler("},{"line_number":61,"context_line":"            self.sync_from_callback_precommit,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_6a7b4627","line":58,"in_reply_to":"3f1d235d_9823a3a7","updated":"2017-07-06 16:25:09.000000000","message":"We want to keep common code in dhcp_proxy_service and v2 specific in dhcp_proxy_service_v2, for seamless porting to v1","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"1e39ffd3e79c10a4b71872f16d27ec5bd65cb2d5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":56,"context_line":"#        self.__dhcp_proxy \u003d dhcp_proxy_service.DhcpProxyService("},{"line_number":57,"context_line":"#            cfg.CONF.ml2_odl.enable_dhcp_proxy)"},{"line_number":58,"context_line":"        self.__dhcp_proxy \u003d dhcp_proxy_service_v2.DhcpProxyServiceV2("},{"line_number":59,"context_line":"            cfg.CONF.ml2_odl.create_opendaylight_dhcp_port)"},{"line_number":60,"context_line":"        self.sg_handler \u003d callback.OdlSecurityGroupsHandler("},{"line_number":61,"context_line":"            self.sync_from_callback_precommit,"},{"line_number":62,"context_line":"            self.sync_from_callback_postcommit)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_5d92a44d","line":59,"range":{"start_line":58,"start_character":8,"end_line":59,"end_character":59},"updated":"2017-07-06 09:37:34.000000000","message":"This is flawed logic, the driver should only be loaded and registered for callbacks in case the config value is true (since it can\u0027t change in run time).","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"4db1bd70b09de69768889374dbec908a8abebbbe","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":56,"context_line":"#        self.__dhcp_proxy \u003d dhcp_proxy_service.DhcpProxyService("},{"line_number":57,"context_line":"#            cfg.CONF.ml2_odl.enable_dhcp_proxy)"},{"line_number":58,"context_line":"        self.__dhcp_proxy \u003d dhcp_proxy_service_v2.DhcpProxyServiceV2("},{"line_number":59,"context_line":"            cfg.CONF.ml2_odl.create_opendaylight_dhcp_port)"},{"line_number":60,"context_line":"        self.sg_handler \u003d callback.OdlSecurityGroupsHandler("},{"line_number":61,"context_line":"            self.sync_from_callback_precommit,"},{"line_number":62,"context_line":"            self.sync_from_callback_postcommit)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_783e87c1","line":59,"range":{"start_line":58,"start_character":8,"end_line":59,"end_character":59},"in_reply_to":"3f1d235d_5d92a44d","updated":"2017-07-06 12:58:37.000000000","message":"+1","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"319330939826b6d22e32db84f443234b18254534","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":56,"context_line":"#        self.__dhcp_proxy \u003d dhcp_proxy_service.DhcpProxyService("},{"line_number":57,"context_line":"#            cfg.CONF.ml2_odl.enable_dhcp_proxy)"},{"line_number":58,"context_line":"        self.__dhcp_proxy \u003d dhcp_proxy_service_v2.DhcpProxyServiceV2("},{"line_number":59,"context_line":"            cfg.CONF.ml2_odl.create_opendaylight_dhcp_port)"},{"line_number":60,"context_line":"        self.sg_handler \u003d callback.OdlSecurityGroupsHandler("},{"line_number":61,"context_line":"            self.sync_from_callback_precommit,"},{"line_number":62,"context_line":"            self.sync_from_callback_postcommit)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_4a01aaae","line":59,"range":{"start_line":58,"start_character":8,"end_line":59,"end_character":59},"in_reply_to":"3f1d235d_5d92a44d","updated":"2017-07-06 16:25:09.000000000","message":"Yeah sure","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"319330939826b6d22e32db84f443234b18254534","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        cfg.CONF.register_opts(odl_conf.odl_opts, \"ml2_odl\")"},{"line_number":56,"context_line":"#        self.__dhcp_proxy \u003d dhcp_proxy_service.DhcpProxyService("},{"line_number":57,"context_line":"#            cfg.CONF.ml2_odl.enable_dhcp_proxy)"},{"line_number":58,"context_line":"        self.__dhcp_proxy \u003d dhcp_proxy_service_v2.DhcpProxyServiceV2("},{"line_number":59,"context_line":"            cfg.CONF.ml2_odl.create_opendaylight_dhcp_port)"},{"line_number":60,"context_line":"        self.sg_handler \u003d callback.OdlSecurityGroupsHandler("},{"line_number":61,"context_line":"            self.sync_from_callback_precommit,"},{"line_number":62,"context_line":"            self.sync_from_callback_postcommit)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_2abf8eaa","line":59,"range":{"start_line":58,"start_character":8,"end_line":59,"end_character":59},"in_reply_to":"3f1d235d_783e87c1","updated":"2017-07-06 16:25:09.000000000","message":"what about renaming the field to enble_odl_dhcp or enable_dhcp_port?","commit_id":"1811586b2c61627d8973fa2f8a9a790b761b2400"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"94247edeaa1b148417b7226a144d594033268165","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if odl_const.ODL_QOS in cfg.CONF.ml2.extension_drivers:"},{"line_number":62,"context_line":"            qos_driver.OpenDaylightQosDriver.create()"},{"line_number":63,"context_line":"        if cfg.CONF.ml2_odl.enable_dhcp_port:"},{"line_number":64,"context_line":"            self.__dhcp_driver \u003d dhcp_driver.OdlDhcpDriverV2.create()"},{"line_number":65,"context_line":"        self._start_maintenance_thread()"},{"line_number":66,"context_line":"        odl_features.init()"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_c52788b6","line":64,"range":{"start_line":64,"start_character":17,"end_line":64,"end_character":19},"updated":"2017-07-10 22:10:18.000000000","message":"double underbar has special meaning in python.\nIf you don\u0027t special reason, just one underline is enough.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1099206faa0e6390b84e43a49b008023f1043bc6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if odl_const.ODL_QOS in cfg.CONF.ml2.extension_drivers:"},{"line_number":62,"context_line":"            qos_driver.OpenDaylightQosDriver.create()"},{"line_number":63,"context_line":"        if cfg.CONF.ml2_odl.enable_dhcp_port:"},{"line_number":64,"context_line":"            self.__dhcp_driver \u003d dhcp_driver.OdlDhcpDriverV2.create()"},{"line_number":65,"context_line":"        self._start_maintenance_thread()"},{"line_number":66,"context_line":"        odl_features.init()"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"3f1d235d_57d7a350","line":64,"range":{"start_line":64,"start_character":17,"end_line":64,"end_character":19},"in_reply_to":"3f1d235d_c52788b6","updated":"2017-07-11 08:53:46.000000000","message":"Yeah, already done","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if odl_const.ODL_QOS in cfg.CONF.ml2.extension_drivers:"},{"line_number":62,"context_line":"            qos_driver.OpenDaylightQosDriver.create()"},{"line_number":63,"context_line":"        if cfg.CONF.ml2_odl.enable_dhcp_port:"},{"line_number":64,"context_line":"            self.dhcp_driver \u003d dhcp_driver.OdlDhcpDriver()"},{"line_number":65,"context_line":"            self.odl_dhcp_enbled \u003d True"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            self.odl_dhcp_enbled \u003d False"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_9d4e95bf","line":64,"updated":"2017-07-21 09:09:45.000000000","message":"do we need self.dhcp_driver at all?\n\nwe just need to retain dhcp_driver.OdlDhcpDriver() as that will subscribe the class to journal registry, which is sufficient.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            self.dhcp_driver \u003d dhcp_driver.OdlDhcpDriver()"},{"line_number":65,"context_line":"            self.odl_dhcp_enbled \u003d True"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            self.odl_dhcp_enbled \u003d False"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self._start_maintenance_thread()"},{"line_number":70,"context_line":"        odl_features.init()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_dd6bed1c","line":67,"updated":"2017-07-21 09:09:45.000000000","message":"is this flag required ?","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            self.dhcp_driver \u003d dhcp_driver.OdlDhcpDriver()"},{"line_number":65,"context_line":"            self.odl_dhcp_enbled \u003d True"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            self.odl_dhcp_enbled \u003d False"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self._start_maintenance_thread()"},{"line_number":70,"context_line":"        odl_features.init()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_a3bed4fc","line":67,"in_reply_to":"1f1a1f67_dd6bed1c","updated":"2017-07-21 09:52:28.000000000","message":"If we need to handle below mentioned scenario. else not required","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def _postcommit(self, context):"},{"line_number":202,"context_line":"        self.journal.set_sync_event()"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":205,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":206,"context_line":"            self.dhcp_driver.create_dhcp_port(context)"},{"line_number":207,"context_line":"        self._postcommit(context)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":210,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":211,"context_line":"            self.dhcp_driver.update_dhcp_port(context)"},{"line_number":212,"context_line":"        self._postcommit(context)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":215,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":216,"context_line":"            self.dhcp_driver.release_dhcp_port(context)"},{"line_number":217,"context_line":"        self._postcommit(context)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @log_helpers.log_method_call"},{"line_number":220,"context_line":"    def bind_port(self, port_context):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_96c0ea2c","line":217,"range":{"start_line":204,"start_character":0,"end_line":217,"end_character":33},"updated":"2017-07-20 04:44:00.000000000","message":"Why are these needed?\nI suspect you\u0027ve mixed versions of patch.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"3cbc08c6a81ac69fe319996d6de6480e4ee16d09","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def _postcommit(self, context):"},{"line_number":202,"context_line":"        self.journal.set_sync_event()"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":205,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":206,"context_line":"            self.dhcp_driver.create_dhcp_port(context)"},{"line_number":207,"context_line":"        self._postcommit(context)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":210,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":211,"context_line":"            self.dhcp_driver.update_dhcp_port(context)"},{"line_number":212,"context_line":"        self._postcommit(context)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":215,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":216,"context_line":"            self.dhcp_driver.release_dhcp_port(context)"},{"line_number":217,"context_line":"        self._postcommit(context)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @log_helpers.log_method_call"},{"line_number":220,"context_line":"    def bind_port(self, port_context):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_a32db4a9","line":217,"range":{"start_line":204,"start_character":0,"end_line":217,"end_character":33},"in_reply_to":"1f1a1f67_0388e81c","updated":"2017-07-21 10:21:33.000000000","message":"Neutron server crashes won\u0027t happen often, so please let us not burden the code to attempt process every subnet twice.\n\nOther than this reason, is there a corner case why this snip is required?","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"82f2b40f9936cfa8e023d9fbaa67a21150768be1","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def _postcommit(self, context):"},{"line_number":202,"context_line":"        self.journal.set_sync_event()"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":205,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":206,"context_line":"            self.dhcp_driver.create_dhcp_port(context)"},{"line_number":207,"context_line":"        self._postcommit(context)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":210,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":211,"context_line":"            self.dhcp_driver.update_dhcp_port(context)"},{"line_number":212,"context_line":"        self._postcommit(context)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":215,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":216,"context_line":"            self.dhcp_driver.release_dhcp_port(context)"},{"line_number":217,"context_line":"        self._postcommit(context)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @log_helpers.log_method_call"},{"line_number":220,"context_line":"    def bind_port(self, port_context):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_0388e81c","line":217,"range":{"start_line":204,"start_character":0,"end_line":217,"end_character":33},"in_reply_to":"1f1a1f67_3d2f81f7","updated":"2017-07-21 09:52:28.000000000","message":"Thought, We will use this for normal scenario and as fallback mechanism we will use journal callback, that is when neutron server crashes only. In case of ODL crash scenario port creation will be unnecessarily delayed.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def _postcommit(self, context):"},{"line_number":202,"context_line":"        self.journal.set_sync_event()"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":205,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":206,"context_line":"            self.dhcp_driver.create_dhcp_port(context)"},{"line_number":207,"context_line":"        self._postcommit(context)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":210,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":211,"context_line":"            self.dhcp_driver.update_dhcp_port(context)"},{"line_number":212,"context_line":"        self._postcommit(context)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":215,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":216,"context_line":"            self.dhcp_driver.release_dhcp_port(context)"},{"line_number":217,"context_line":"        self._postcommit(context)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @log_helpers.log_method_call"},{"line_number":220,"context_line":"    def bind_port(self, port_context):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_3d2f81f7","line":217,"range":{"start_line":204,"start_character":0,"end_line":217,"end_character":33},"in_reply_to":"1f1a1f67_96c0ea2c","updated":"2017-07-21 09:09:45.000000000","message":"Good catch.. Karthik, please remove this.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"603b41926f03828f1236630c13383d3222171cf3","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    def _postcommit(self, context):"},{"line_number":202,"context_line":"        self.journal.set_sync_event()"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":205,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":206,"context_line":"            self.dhcp_driver.create_dhcp_port(context)"},{"line_number":207,"context_line":"        self._postcommit(context)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def update_subnet_postcommit(self, context):"},{"line_number":210,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":211,"context_line":"            self.dhcp_driver.update_dhcp_port(context)"},{"line_number":212,"context_line":"        self._postcommit(context)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":215,"context_line":"        if self.odl_dhcp_enbled:"},{"line_number":216,"context_line":"            self.dhcp_driver.release_dhcp_port(context)"},{"line_number":217,"context_line":"        self._postcommit(context)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @log_helpers.log_method_call"},{"line_number":220,"context_line":"    def bind_port(self, port_context):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_f2ea53aa","line":217,"range":{"start_line":204,"start_character":0,"end_line":217,"end_character":33},"in_reply_to":"1f1a1f67_a32db4a9","updated":"2017-07-21 12:30:04.000000000","message":"Nope, may be error handling. where user can be directly notified, say in case of IpAddressGenerationFailure, when user gives a range due to which we cannot create dhcp port, we can directly throw a error to user, in case of journal, we could max log an error message.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"}],"networking_odl/tests/unit/dhcp/dhcp_test_utils.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"1f1a1f67_768d4e29","updated":"2017-07-20 04:44:00.000000000","message":"common practice is to introduce base class.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"}],"networking_odl/tests/unit/dhcp/test_odl_dhcp_driver.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c7588798951039a22af89e8f38e3ce4384898ca6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_c41e956f","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":20},"updated":"2017-07-12 20:47:25.000000000","message":"2017","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_c33afde5","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":20},"in_reply_to":"1f1a1f67_c41e956f","updated":"2017-07-13 07:17:54.000000000","message":"OK","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c7588798951039a22af89e8f38e3ce4384898ca6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertTrue(exception_occured)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_dhcp_port_create(self):"},{"line_number":58,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver.create()"},{"line_number":59,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":60,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_07f00f90","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":60},"updated":"2017-07-12 20:47:25.000000000","message":"just instantiate it in the setup as self.dhcp_driver and  use everywhere else","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce33d259fb63954aaf934c1b0408174356157160","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertTrue(exception_occured)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_dhcp_port_create(self):"},{"line_number":58,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver.create()"},{"line_number":59,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":60,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_031a357c","line":58,"range":{"start_line":58,"start_character":8,"end_line":58,"end_character":60},"in_reply_to":"1f1a1f67_07f00f90","updated":"2017-07-13 07:17:54.000000000","message":"Ok","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c7588798951039a22af89e8f38e3ce4384898ca6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assertIsNotNone(port)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_dhcp_create_without_dhcp_flag(self):"},{"line_number":83,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver.create()"},{"line_number":84,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":85,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_8739bf42","line":83,"range":{"start_line":83,"start_character":8,"end_line":83,"end_character":60},"updated":"2017-07-12 20:47:25.000000000","message":"comment on L58","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c7588798951039a22af89e8f38e3ce4384898ca6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.assertIsNone(port)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_dhcp_update_with_dhcp_enable(self):"},{"line_number":108,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver.create()"},{"line_number":109,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":110,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_473ba737","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":60},"updated":"2017-07-12 20:47:25.000000000","message":"same as L58","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c7588798951039a22af89e8f38e3ce4384898ca6","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.assertIsNotNone(port)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_dhcp_update_with_disable_dhcp(self):"},{"line_number":133,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver.create()"},{"line_number":134,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":135,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"1f1a1f67_2748abca","line":133,"range":{"start_line":133,"start_character":7,"end_line":133,"end_character":60},"updated":"2017-07-12 20:47:25.000000000","message":"same as L58","commit_id":"496e5ec4702b06bdbf61fd26c19c757dd173e096"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(OdlDhcpDriverTestCase, self).setUp()"},{"line_number":43,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":44,"context_line":"        self.db_session \u003d neutron_db_api.get_writer_session()"},{"line_number":45,"context_line":"        self.mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"},{"line_number":46,"context_line":"        self.mech.initialize()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_9ffcd2b5","line":43,"updated":"2017-07-18 04:46:18.000000000","message":"Please mock journal thread not to run thread.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def setUp(self):"},{"line_number":42,"context_line":"        super(OdlDhcpDriverTestCase, self).setUp()"},{"line_number":43,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":44,"context_line":"        self.db_session \u003d neutron_db_api.get_writer_session()"},{"line_number":45,"context_line":"        self.mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"},{"line_number":46,"context_line":"        self.mech.initialize()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_5961b504","line":43,"in_reply_to":"1f1a1f67_9ffcd2b5","updated":"2017-07-18 15:46:56.000000000","message":"Done","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_dhcp_driver_load_without_flag(self):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        exception_occured \u003d False"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            getattr(self.mech, \u0027dhcp_driver\u0027)"},{"line_number":53,"context_line":"        except AttributeError:"},{"line_number":54,"context_line":"            exception_occured \u003d True"},{"line_number":55,"context_line":"        self.assertTrue(exception_occured)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_dhcp_port_create(self):"},{"line_number":58,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_7fd45620","line":55,"range":{"start_line":50,"start_character":0,"end_line":55,"end_character":42},"updated":"2017-07-18 04:46:18.000000000","message":"assertRaises()","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_dhcp_driver_load_without_flag(self):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        exception_occured \u003d False"},{"line_number":51,"context_line":"        try:"},{"line_number":52,"context_line":"            getattr(self.mech, \u0027dhcp_driver\u0027)"},{"line_number":53,"context_line":"        except AttributeError:"},{"line_number":54,"context_line":"            exception_occured \u003d True"},{"line_number":55,"context_line":"        self.assertTrue(exception_occured)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_dhcp_port_create(self):"},{"line_number":58,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_7948f185","line":55,"range":{"start_line":50,"start_character":0,"end_line":55,"end_character":42},"in_reply_to":"1f1a1f67_7fd45620","updated":"2017-07-18 15:46:56.000000000","message":"Done","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":63,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        network \u003d OdlDhcpDriverTestCase._get_network_context(network_id)"},{"line_number":66,"context_line":"        plugin.create_network(context, network)"},{"line_number":67,"context_line":"        network_context \u003d plugin.get_network(context, network_id)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_3fb37e0c","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":40},"updated":"2017-07-18 04:46:18.000000000","message":"self.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":63,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        network \u003d OdlDhcpDriverTestCase._get_network_context(network_id)"},{"line_number":66,"context_line":"        plugin.create_network(context, network)"},{"line_number":67,"context_line":"        network_context \u003d plugin.get_network(context, network_id)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_b937a9ff","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":40},"in_reply_to":"1f1a1f67_3fb37e0c","updated":"2017-07-18 15:46:56.000000000","message":"static method, anyways will move those method to helper class","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            context, network_id, subnet_id)"},{"line_number":130,"context_line":"        self.assertIsNotNone(port)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_dhcp_update_with_disable_dhcp(self):"},{"line_number":133,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver()"},{"line_number":134,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":135,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_bf742e37","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":42},"updated":"2017-07-18 04:46:18.000000000","message":"What\u0027s the difference from the previous method?\nIf only enable_dhcp, introduce common method that take the argument.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            context, network_id, subnet_id)"},{"line_number":130,"context_line":"        self.assertIsNotNone(port)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_dhcp_update_with_disable_dhcp(self):"},{"line_number":133,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver()"},{"line_number":134,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":135,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_fcb2af48","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":42},"in_reply_to":"1f1a1f67_bf742e37","updated":"2017-07-18 15:46:56.000000000","message":"In Previous method subnet is created initially without dhcp and in subnet update we are enabling dhcp.\nIn this method we\u0027ve create subnet with dhcp flag but disabling it later on.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            context, network_id, subnet_id)"},{"line_number":183,"context_line":"        self.assertIsNone(port)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_dhcp_delete_without_dhcp_flag(self):"},{"line_number":186,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver()"},{"line_number":187,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":188,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_7f90d643","line":185,"range":{"start_line":185,"start_character":8,"end_line":185,"end_character":42},"updated":"2017-07-18 04:46:18.000000000","message":"ditto.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            context, network_id, subnet_id)"},{"line_number":183,"context_line":"        self.assertIsNone(port)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_dhcp_delete_without_dhcp_flag(self):"},{"line_number":186,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver()"},{"line_number":187,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":188,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_dcd3735f","line":185,"range":{"start_line":185,"start_character":8,"end_line":185,"end_character":42},"in_reply_to":"1f1a1f67_7f90d643","updated":"2017-07-18 15:46:56.000000000","message":"Previous method: Subnet has dhcp flag set true which means will have dhcp port. And we are deleting the subnet.\nIn this method. Subnet create with dhcp flag false which means will not have dhcp port. And we are deleting the subnet.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertIsNone(port)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_dhcp_delete_without_dhcp_flag(self):"},{"line_number":186,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver()"},{"line_number":187,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":188,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":191,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        network \u003d OdlDhcpDriverTestCase._get_network_context(network_id)"},{"line_number":194,"context_line":"        plugin.create_network(context, network)"},{"line_number":195,"context_line":"        network_context \u003d plugin.get_network(context, network_id)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        subnet \u003d OdlDhcpDriverTestCase._get_subnet_context("},{"line_number":198,"context_line":"            network_id, subnet_id, \u002710.0.50.0/24\u0027, False)"},{"line_number":199,"context_line":"        plugin.create_subnet(context, subnet)"},{"line_number":200,"context_line":"        subnet_context \u003d driver_context.SubnetContext(plugin, context,"},{"line_number":201,"context_line":"                                                      subnet[\u0027subnet\u0027],"},{"line_number":202,"context_line":"                                                      network_context)"},{"line_number":203,"context_line":"        dhcp_driver.create_dhcp_port(subnet_context)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        port \u003d OdlDhcpDriverTestCase._get_port_id("}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_5fbe3ab4","line":202,"range":{"start_line":186,"start_character":0,"end_line":202,"end_character":70},"updated":"2017-07-18 04:46:18.000000000","message":"Are those clauses common?\nPlease introduce helper method. don\u0027t duplicate same logic.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        self.assertIsNone(port)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_dhcp_delete_without_dhcp_flag(self):"},{"line_number":186,"context_line":"        dhcp_driver \u003d odl_dhcp_driver.OdlDhcpDriver()"},{"line_number":187,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":188,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":191,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        network \u003d OdlDhcpDriverTestCase._get_network_context(network_id)"},{"line_number":194,"context_line":"        plugin.create_network(context, network)"},{"line_number":195,"context_line":"        network_context \u003d plugin.get_network(context, network_id)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        subnet \u003d OdlDhcpDriverTestCase._get_subnet_context("},{"line_number":198,"context_line":"            network_id, subnet_id, \u002710.0.50.0/24\u0027, False)"},{"line_number":199,"context_line":"        plugin.create_subnet(context, subnet)"},{"line_number":200,"context_line":"        subnet_context \u003d driver_context.SubnetContext(plugin, context,"},{"line_number":201,"context_line":"                                                      subnet[\u0027subnet\u0027],"},{"line_number":202,"context_line":"                                                      network_context)"},{"line_number":203,"context_line":"        dhcp_driver.create_dhcp_port(subnet_context)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        port \u003d OdlDhcpDriverTestCase._get_port_id("}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_1cbd6b01","line":202,"range":{"start_line":186,"start_character":0,"end_line":202,"end_character":70},"in_reply_to":"1f1a1f67_5fbe3ab4","updated":"2017-07-18 15:46:56.000000000","message":"Done","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            context, network_id, subnet_id)"},{"line_number":211,"context_line":"        self.assertIsNone(port)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @staticmethod"},{"line_number":214,"context_line":"    def _get_port_id(plugin_context, network_id, subnet_id):"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        device_id \u003d odl_dhcp_driver.DEVICE_ID + \u0027-\u0027 + subnet_id"},{"line_number":217,"context_line":"        port \u003d plugin_context.session.query("},{"line_number":218,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":219,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":220,"context_line":"        if port:"},{"line_number":221,"context_line":"            return port[0]"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    @staticmethod"},{"line_number":224,"context_line":"    def _get_network_context(network_id):"},{"line_number":225,"context_line":"        current \u003d {\u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":226,"context_line":"                   \u0027subnets\u0027: [],"},{"line_number":227,"context_line":"                   \u0027name\u0027: \u0027net1\u0027,"},{"line_number":228,"context_line":"                   \u0027provider:physical_network\u0027: None,"},{"line_number":229,"context_line":"                   \u0027admin_state_up\u0027: True,"},{"line_number":230,"context_line":"                   \u0027tenant_id\u0027: ODL_TENANT_ID,"},{"line_number":231,"context_line":"                   \u0027project_id\u0027: ODL_TENANT_ID,"},{"line_number":232,"context_line":"                   \u0027provider:network_type\u0027: \u0027local\u0027,"},{"line_number":233,"context_line":"                   \u0027router:external\u0027: False,"},{"line_number":234,"context_line":"                   \u0027shared\u0027: False,"},{"line_number":235,"context_line":"                   \u0027id\u0027: network_id,"},{"line_number":236,"context_line":"                   \u0027provider:segmentation_id\u0027: None}"},{"line_number":237,"context_line":"        network \u003d {\u0027network\u0027: AttributeDict(current)}"},{"line_number":238,"context_line":"        return network"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @staticmethod"},{"line_number":241,"context_line":"    def _get_subnet_context(network_id, subnet_id, cidr, dhcp_flag):"},{"line_number":242,"context_line":"        index \u003d cidr.rfind(\u0027.\u0027) + 1"},{"line_number":243,"context_line":"        ip_range \u003d cidr[:index]"},{"line_number":244,"context_line":"        current \u003d {\u0027ipv6_ra_mode\u0027: None,"},{"line_number":245,"context_line":"                   \u0027allocation_pools\u0027: [{\u0027start\u0027: ip_range + str(2),"},{"line_number":246,"context_line":"                                         \u0027end\u0027: ip_range + str(254)}],"},{"line_number":247,"context_line":"                   \u0027host_routes\u0027: [],"},{"line_number":248,"context_line":"                   \u0027ipv6_address_mode\u0027: None,"},{"line_number":249,"context_line":"                   \u0027cidr\u0027: cidr,"},{"line_number":250,"context_line":"                   \u0027id\u0027: subnet_id,"},{"line_number":251,"context_line":"                   \u0027name\u0027: \u0027\u0027,"},{"line_number":252,"context_line":"                   \u0027enable_dhcp\u0027: dhcp_flag,"},{"line_number":253,"context_line":"                   \u0027network_id\u0027: network_id,"},{"line_number":254,"context_line":"                   \u0027tenant_id\u0027: ODL_TENANT_ID,"},{"line_number":255,"context_line":"                   \u0027project_id\u0027: ODL_TENANT_ID,"},{"line_number":256,"context_line":"                   \u0027dns_nameservers\u0027: [],"},{"line_number":257,"context_line":"                   \u0027gateway_ip\u0027: ip_range + str(1),"},{"line_number":258,"context_line":"                   \u0027ip_version\u0027: 4,"},{"line_number":259,"context_line":"                   \u0027shared\u0027: False}"},{"line_number":260,"context_line":"        subnet \u003d {\u0027subnet\u0027: AttributeDict(current)}"},{"line_number":261,"context_line":"        return subnet"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"class AttributeDict(dict):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_7f8b361e","line":261,"range":{"start_line":213,"start_character":0,"end_line":261,"end_character":21},"updated":"2017-07-18 04:46:18.000000000","message":"For the consistency with other code, please place those methods after setUp before test methods.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            context, network_id, subnet_id)"},{"line_number":211,"context_line":"        self.assertIsNone(port)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @staticmethod"},{"line_number":214,"context_line":"    def _get_port_id(plugin_context, network_id, subnet_id):"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        device_id \u003d odl_dhcp_driver.DEVICE_ID + \u0027-\u0027 + subnet_id"},{"line_number":217,"context_line":"        port \u003d plugin_context.session.query("},{"line_number":218,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":219,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":220,"context_line":"        if port:"},{"line_number":221,"context_line":"            return port[0]"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    @staticmethod"},{"line_number":224,"context_line":"    def _get_network_context(network_id):"},{"line_number":225,"context_line":"        current \u003d {\u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":226,"context_line":"                   \u0027subnets\u0027: [],"},{"line_number":227,"context_line":"                   \u0027name\u0027: \u0027net1\u0027,"},{"line_number":228,"context_line":"                   \u0027provider:physical_network\u0027: None,"},{"line_number":229,"context_line":"                   \u0027admin_state_up\u0027: True,"},{"line_number":230,"context_line":"                   \u0027tenant_id\u0027: ODL_TENANT_ID,"},{"line_number":231,"context_line":"                   \u0027project_id\u0027: ODL_TENANT_ID,"},{"line_number":232,"context_line":"                   \u0027provider:network_type\u0027: \u0027local\u0027,"},{"line_number":233,"context_line":"                   \u0027router:external\u0027: False,"},{"line_number":234,"context_line":"                   \u0027shared\u0027: False,"},{"line_number":235,"context_line":"                   \u0027id\u0027: network_id,"},{"line_number":236,"context_line":"                   \u0027provider:segmentation_id\u0027: None}"},{"line_number":237,"context_line":"        network \u003d {\u0027network\u0027: AttributeDict(current)}"},{"line_number":238,"context_line":"        return network"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @staticmethod"},{"line_number":241,"context_line":"    def _get_subnet_context(network_id, subnet_id, cidr, dhcp_flag):"},{"line_number":242,"context_line":"        index \u003d cidr.rfind(\u0027.\u0027) + 1"},{"line_number":243,"context_line":"        ip_range \u003d cidr[:index]"},{"line_number":244,"context_line":"        current \u003d {\u0027ipv6_ra_mode\u0027: None,"},{"line_number":245,"context_line":"                   \u0027allocation_pools\u0027: [{\u0027start\u0027: ip_range + str(2),"},{"line_number":246,"context_line":"                                         \u0027end\u0027: ip_range + str(254)}],"},{"line_number":247,"context_line":"                   \u0027host_routes\u0027: [],"},{"line_number":248,"context_line":"                   \u0027ipv6_address_mode\u0027: None,"},{"line_number":249,"context_line":"                   \u0027cidr\u0027: cidr,"},{"line_number":250,"context_line":"                   \u0027id\u0027: subnet_id,"},{"line_number":251,"context_line":"                   \u0027name\u0027: \u0027\u0027,"},{"line_number":252,"context_line":"                   \u0027enable_dhcp\u0027: dhcp_flag,"},{"line_number":253,"context_line":"                   \u0027network_id\u0027: network_id,"},{"line_number":254,"context_line":"                   \u0027tenant_id\u0027: ODL_TENANT_ID,"},{"line_number":255,"context_line":"                   \u0027project_id\u0027: ODL_TENANT_ID,"},{"line_number":256,"context_line":"                   \u0027dns_nameservers\u0027: [],"},{"line_number":257,"context_line":"                   \u0027gateway_ip\u0027: ip_range + str(1),"},{"line_number":258,"context_line":"                   \u0027ip_version\u0027: 4,"},{"line_number":259,"context_line":"                   \u0027shared\u0027: False}"},{"line_number":260,"context_line":"        subnet \u003d {\u0027subnet\u0027: AttributeDict(current)}"},{"line_number":261,"context_line":"        return subnet"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"class AttributeDict(dict):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_bc3d5790","line":261,"range":{"start_line":213,"start_character":0,"end_line":261,"end_character":21},"in_reply_to":"1f1a1f67_7f8b361e","updated":"2017-07-18 15:46:56.000000000","message":"Done","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        return subnet"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"class AttributeDict(dict):"},{"line_number":265,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":266,"context_line":"        super(AttributeDict, self).__init__(*args, **kwargs)"},{"line_number":267,"context_line":"        self.__dict__ \u003d self"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_3f813efc","line":267,"range":{"start_line":264,"start_character":0,"end_line":267,"end_character":28},"updated":"2017-07-18 04:46:18.000000000","message":"Please place before test class for consistency with other codes.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        return subnet"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"class AttributeDict(dict):"},{"line_number":265,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":266,"context_line":"        super(AttributeDict, self).__init__(*args, **kwargs)"},{"line_number":267,"context_line":"        self.__dict__ \u003d self"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_7c433f14","line":267,"range":{"start_line":264,"start_character":0,"end_line":267,"end_character":28},"in_reply_to":"1f1a1f67_3f813efc","updated":"2017-07-18 15:46:56.000000000","message":"Done","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(OdlDhcpDriverTestCase, self).setUp()"},{"line_number":40,"context_line":"        cfg.CONF.set_override(\u0027enable_dhcp_port\u0027, True, \u0027ml2_odl\u0027)"},{"line_number":41,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":42,"context_line":"        self.mock_sync_thread \u003d mock.patch.object("},{"line_number":43,"context_line":"            journal.OpenDaylightJournalThread, \u0027start_odl_sync_thread\u0027).start()"},{"line_number":44,"context_line":"        self.mock_mt_thread \u003d mock.patch.object("},{"line_number":45,"context_line":"            maintenance.MaintenanceThread, \u0027start\u0027).start()"},{"line_number":46,"context_line":"        self.db_session \u003d neutron_db_api.get_writer_session()"},{"line_number":47,"context_line":"        self.mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"},{"line_number":48,"context_line":"        self.mech.initialize()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_d6cb0248","line":45,"range":{"start_line":41,"start_character":0,"end_line":45,"end_character":59},"updated":"2017-07-20 04:44:00.000000000","message":"mock before super.setUp().\nPlease see https://review.openstack.org/#/c/485270/","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                            test_odl_dhcp_driver_base.OdlDhcpDriverTests):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def setUp(self):"},{"line_number":40,"context_line":"        self.mock_sync_thread \u003d mock.patch.object("},{"line_number":41,"context_line":"            journal.OpenDaylightJournalThread, \u0027start_odl_sync_thread\u0027).start()"},{"line_number":42,"context_line":"        self.mock_mt_thread \u003d mock.patch.object("},{"line_number":43,"context_line":"            maintenance.MaintenanceThread, \u0027start\u0027).start()"},{"line_number":44,"context_line":"        super(OdlDhcpDriverTestCase, self).setUp()"},{"line_number":45,"context_line":"        cfg.CONF.set_override(\u0027enable_dhcp_service\u0027, True, \u0027ml2_odl\u0027)"},{"line_number":46,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":47,"context_line":"        self.db_session \u003d neutron_db_api.get_writer_session()"},{"line_number":48,"context_line":"        self.mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"},{"line_number":49,"context_line":"        self.mech.initialize()"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_8b54f3cb","line":47,"range":{"start_line":40,"start_character":0,"end_line":47,"end_character":61},"updated":"2017-07-24 17:39:45.000000000","message":"Some of them are common to OdlDhcpDriverBaseTestCase.\nPlease move it to the base class.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"92d20db64afb3a20f215fb207b32e0978e8943a2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                            test_odl_dhcp_driver_base.OdlDhcpDriverTests):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def setUp(self):"},{"line_number":40,"context_line":"        self.mock_sync_thread \u003d mock.patch.object("},{"line_number":41,"context_line":"            journal.OpenDaylightJournalThread, \u0027start_odl_sync_thread\u0027).start()"},{"line_number":42,"context_line":"        self.mock_mt_thread \u003d mock.patch.object("},{"line_number":43,"context_line":"            maintenance.MaintenanceThread, \u0027start\u0027).start()"},{"line_number":44,"context_line":"        super(OdlDhcpDriverTestCase, self).setUp()"},{"line_number":45,"context_line":"        cfg.CONF.set_override(\u0027enable_dhcp_service\u0027, True, \u0027ml2_odl\u0027)"},{"line_number":46,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":47,"context_line":"        self.db_session \u003d neutron_db_api.get_writer_session()"},{"line_number":48,"context_line":"        self.mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"},{"line_number":49,"context_line":"        self.mech.initialize()"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_9bbae907","line":47,"range":{"start_line":40,"start_character":0,"end_line":47,"end_character":61},"in_reply_to":"ff346bd7_8b54f3cb","updated":"2017-07-25 13:51:51.000000000","message":"OK","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9481f7a601aabaeaec3485770692f9a79910bc84","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_dhcp_driver_load(self):"},{"line_number":44,"context_line":"        dhcp_driver \u003d getattr(self.mech, \u0027dhcp_driver\u0027)"},{"line_number":45,"context_line":"        self.assertIsNotNone(dhcp_driver)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_dhcp_port_create_on_subnet_event(self):"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_3593f651","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":41},"updated":"2017-07-25 20:44:12.000000000","message":"and you can also assert if this is an instance dhcpdriver\n       self.assertTrue(isinstance(dhcp_driver, dhcpdriver.dhcp_driver.OdlDhcpDriver)","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_dhcp_driver_load(self):"},{"line_number":44,"context_line":"        dhcp_driver \u003d getattr(self.mech, \u0027dhcp_driver\u0027)"},{"line_number":45,"context_line":"        self.assertIsNotNone(dhcp_driver)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_dhcp_port_create_on_subnet_event(self):"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_807c9eb5","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":41},"in_reply_to":"ff346bd7_3593f651","updated":"2017-07-25 21:20:12.000000000","message":"OK","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9481f7a601aabaeaec3485770692f9a79910bc84","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        subnet, subnet_context \u003d self.get_subnet_context("},{"line_number":53,"context_line":"            net_id, subnet_id, \u002710.0.10.0/24\u0027, True, True)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        mech_driver_v2.OpenDaylightMechanismDriver._record_in_journal("},{"line_number":56,"context_line":"            subnet_context, odl_const.ODL_SUBNET, odl_const.ODL_CREATE)"},{"line_number":57,"context_line":"        self.mech.journal.sync_pending_entries()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        port \u003d self.get_port_id(ctxt, net_id, subnet_id)"},{"line_number":60,"context_line":"        self.assertIsNotNone(port)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_dhcp_delete_on_port_update_event(self):"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_352f76f7","line":60,"range":{"start_line":55,"start_character":6,"end_line":60,"end_character":34},"updated":"2017-07-25 20:44:12.000000000","message":"journal can also be asserted if it has any operation corresponding to that subnet.","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        subnet, subnet_context \u003d self.get_subnet_context("},{"line_number":53,"context_line":"            net_id, subnet_id, \u002710.0.10.0/24\u0027, True, True)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        mech_driver_v2.OpenDaylightMechanismDriver._record_in_journal("},{"line_number":56,"context_line":"            subnet_context, odl_const.ODL_SUBNET, odl_const.ODL_CREATE)"},{"line_number":57,"context_line":"        self.mech.journal.sync_pending_entries()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        port \u003d self.get_port_id(ctxt, net_id, subnet_id)"},{"line_number":60,"context_line":"        self.assertIsNotNone(port)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_dhcp_delete_on_port_update_event(self):"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_c0098631","line":60,"range":{"start_line":55,"start_character":6,"end_line":60,"end_character":34},"in_reply_to":"ff346bd7_352f76f7","updated":"2017-07-25 21:20:12.000000000","message":"Here we are checking if dhcp port is created due to journal callback triggered from subnet create event","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5c92cac60cc1d838d0e1b87394d0b599a8820316","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(OdlDhcpDriverTestCase, self).setUp()"},{"line_number":36,"context_line":"        cfg.CONF.set_override(\u0027enable_dhcp_service\u0027, True, \u0027ml2_odl\u0027)"},{"line_number":37,"context_line":"        self.db_session \u003d neutron_db_api.get_writer_session()"},{"line_number":38,"context_line":"        self.mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"},{"line_number":39,"context_line":"        self.mech.initialize()"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"ff346bd7_ddb4acd3","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":61},"updated":"2017-07-26 18:23:32.000000000","message":"This isn\u0027t used.","commit_id":"c467e9879d777c71e0c39bc557b3852de351e982"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"5c92cac60cc1d838d0e1b87394d0b599a8820316","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.assertTrue(cfg.CONF.ml2_odl.enable_dhcp_service)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_dhcp_driver_load(self):"},{"line_number":45,"context_line":"        dhcp_driver \u003d getattr(self.mech, \u0027dhcp_driver\u0027)"},{"line_number":46,"context_line":"        self.assertTrue(isinstance(dhcp_driver, odl_dhcp_driver.OdlDhcpDriver))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_dhcp_port_create_on_subnet_event(self):"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff346bd7_1de474e0","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":55},"updated":"2017-07-26 18:23:32.000000000","message":"There is no point to use getattr.\njust self.mech.dhcp_driver works.","commit_id":"c467e9879d777c71e0c39bc557b3852de351e982"}],"networking_odl/tests/unit/dhcp/test_odl_dhcp_driver_base.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import testscenarios"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from networking_odl.dhcp import odl_dhcp_driver_base "},{"line_number":20,"context_line":"from networking_odl.journal import journal"},{"line_number":21,"context_line":"from networking_odl.journal import maintenance"},{"line_number":22,"context_line":"from networking_odl.ml2 import mech_driver_v2"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_56093293","line":19,"range":{"start_line":19,"start_character":52,"end_line":19,"end_character":53},"updated":"2017-07-20 04:44:00.000000000","message":"nit: trailing white space.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class OdlDhcpDriverBaseTestCase(base_v2.OpenDaylightConfigBase):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(OdlDhcpDriverBaseTestCase, self).setUp()"},{"line_number":39,"context_line":"        self.mock_sync_thread \u003d mock.patch.object("},{"line_number":40,"context_line":"            journal.OpenDaylightJournalThread, \u0027start_odl_sync_thread\u0027).start()"},{"line_number":41,"context_line":"        self.mock_mt_thread \u003d mock.patch.object("},{"line_number":42,"context_line":"            maintenance.MaintenanceThread, \u0027start\u0027).start()"},{"line_number":43,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_dhcp_driver_not_loaded_without_flag(self):"},{"line_number":46,"context_line":"        mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_1603ba75","line":43,"range":{"start_line":37,"start_character":0,"end_line":43,"end_character":63},"updated":"2017-07-20 04:44:00.000000000","message":"Are these same to OdlDhcpDriverTestCase?\nPlease introduce base class.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"},{"line_number":47,"context_line":"        mech.initialize()"},{"line_number":48,"context_line":"        args \u003d [mech, \u0027dhcp_driver\u0027]"},{"line_number":49,"context_line":"        self.assertRaises(AttributeError, getattr, *args)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_dhcp_port_create(self):"},{"line_number":52,"context_line":"        dhcp_driver \u003d odl_dhcp_driver_base.OdlDhcpDriverBase()"}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_d6f4228a","line":49,"range":{"start_line":49,"start_character":51,"end_line":49,"end_character":56},"updated":"2017-07-20 04:44:00.000000000","message":"mech, \u0027dhcp_driver\u0027\nargs isn\u0027t needed.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"29bd1961a2fd60e76ff1e6f0bf225d187b0265e0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        network, network_context \u003d dhcp_test_utils.get_network_context("},{"line_number":70,"context_line":"            net_id, True)"},{"line_number":71,"context_line":"        subnet, subnet_context \u003d dhcp_test_utils.get_subnet_context("},{"line_number":72,"context_line":"            net_id, subnet_id, \u002710.0.20.0/24\u0027, False, True)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        dhcp_driver.create_dhcp_port(subnet_context)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"1f1a1f67_b64646c0","line":72,"range":{"start_line":72,"start_character":47,"end_line":72,"end_character":52},"updated":"2017-07-20 04:44:00.000000000","message":"Is this method same to the previous one except this parameter?\nintroduce a method which takes argument.\n\nsame to other methods.\nDon\u0027t duplicate logics.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                OdlDhcpDriverTests):"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def setUp(self):"},{"line_number":117,"context_line":"        self.mock_sync_thread \u003d mock.patch.object("},{"line_number":118,"context_line":"            journal.OpenDaylightJournalThread, \u0027start_odl_sync_thread\u0027).start()"},{"line_number":119,"context_line":"        self.mock_mt_thread \u003d mock.patch.object("},{"line_number":120,"context_line":"            maintenance.MaintenanceThread, \u0027start\u0027).start()"},{"line_number":121,"context_line":"        super(OdlDhcpDriverBaseTestCase, self).setUp()"},{"line_number":122,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_6bbc2f05","line":120,"range":{"start_line":117,"start_character":0,"end_line":120,"end_character":59},"updated":"2017-07-24 17:39:45.000000000","message":"Please use fixture.","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"aeffe61c52e31e626214db879adb2a7db662594b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.mock_mt_thread \u003d mock.patch.object("},{"line_number":120,"context_line":"            maintenance.MaintenanceThread, \u0027start\u0027).start()"},{"line_number":121,"context_line":"        super(OdlDhcpDriverBaseTestCase, self).setUp()"},{"line_number":122,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_dhcp_driver_not_loaded_without_flag(self):"},{"line_number":125,"context_line":"        mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"}],"source_content_type":"text/x-python","patch_set":36,"id":"ff346bd7_abc21784","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":63},"updated":"2017-07-24 17:39:45.000000000","message":"Please call before super.setUp()","commit_id":"617b5998aca08d5b4c557b0964686cf04597c8d5"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"5263e0d3fe3c9c5d2b20be642720f50de21e6fb4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"cfg.CONF.import_group(\u0027ml2_odl\u0027, \u0027networking_odl.common.config\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class OdlDhcpDriverTests(base_v2.OpenDaylightConfigBase):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_80bb7e0c","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":24},"updated":"2017-07-25 20:51:31.000000000","message":"there are no tests in it, so rename it to OdlDhcpDriverBase ?","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"cfg.CONF.import_group(\u0027ml2_odl\u0027, \u0027networking_odl.common.config\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class OdlDhcpDriverTests(base_v2.OpenDaylightConfigBase):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_3b03e70f","line":36,"range":{"start_line":36,"start_character":6,"end_line":36,"end_character":24},"in_reply_to":"ff346bd7_80bb7e0c","updated":"2017-07-25 21:20:12.000000000","message":"Ok","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c73c33b2237c5459ae1184d83993aee65c24d8c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def get_port_id(self, plugin_context, network_id, subnet_id):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        device_id \u003d driver_base.OPENDAYLIGHT_DEVICE_ID + \u0027-\u0027 + subnet_id"},{"line_number":108,"context_line":"        port \u003d plugin_context.session.query("},{"line_number":109,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":110,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":111,"context_line":"        if port:"},{"line_number":112,"context_line":"            return port[0]"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_fb879f0e","line":110,"range":{"start_line":108,"start_character":0,"end_line":110,"end_character":56},"updated":"2017-07-25 21:36:33.000000000","message":"Please use plugin.get_ports with filters","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"63013d9adbbd631390e1c311b7f3ce74c0d052ed","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def get_port_id(self, plugin_context, network_id, subnet_id):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        device_id \u003d driver_base.OPENDAYLIGHT_DEVICE_ID + \u0027-\u0027 + subnet_id"},{"line_number":108,"context_line":"        port \u003d plugin_context.session.query("},{"line_number":109,"context_line":"            n_port.id).filter(n_port.network_id \u003d\u003d network_id).filter("},{"line_number":110,"context_line":"            n_port.device_id \u003d\u003d device_id).one_or_none()"},{"line_number":111,"context_line":"        if port:"},{"line_number":112,"context_line":"            return port[0]"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_3bc2c7ea","line":110,"range":{"start_line":108,"start_character":0,"end_line":110,"end_character":56},"in_reply_to":"ff346bd7_fb879f0e","updated":"2017-07-25 21:40:25.000000000","message":"OK","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"5263e0d3fe3c9c5d2b20be642720f50de21e6fb4","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self.assertIsNotNone(port)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_dhcp_create_without_dhcp_flag(self):"},{"line_number":141,"context_line":"        dhcp_driver \u003d driver_base.OdlDhcpDriverBase()"},{"line_number":142,"context_line":"        plugin, ctxt, net_id, subnet_id \u003d self.get_test_parameters()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        network, network_context \u003d self.get_network_context("},{"line_number":145,"context_line":"            net_id, True)"},{"line_number":146,"context_line":"        subnet, subnet_context \u003d self.get_subnet_context("},{"line_number":147,"context_line":"            net_id, subnet_id, \u002710.0.20.0/24\u0027, False, True)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        dhcp_driver.create_or_delete_dhcp_port(subnet_context)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_80fedeab","line":147,"range":{"start_line":141,"start_character":7,"end_line":147,"end_character":59},"updated":"2017-07-25 20:51:31.000000000","message":"these can be wrapped to an helper as it is being repeated in almost all the tests","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"63013d9adbbd631390e1c311b7f3ce74c0d052ed","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self.assertIsNotNone(port)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_dhcp_create_without_dhcp_flag(self):"},{"line_number":141,"context_line":"        dhcp_driver \u003d driver_base.OdlDhcpDriverBase()"},{"line_number":142,"context_line":"        plugin, ctxt, net_id, subnet_id \u003d self.get_test_parameters()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        network, network_context \u003d self.get_network_context("},{"line_number":145,"context_line":"            net_id, True)"},{"line_number":146,"context_line":"        subnet, subnet_context \u003d self.get_subnet_context("},{"line_number":147,"context_line":"            net_id, subnet_id, \u002710.0.20.0/24\u0027, False, True)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        dhcp_driver.create_or_delete_dhcp_port(subnet_context)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_9bac1335","line":147,"range":{"start_line":141,"start_character":7,"end_line":147,"end_character":59},"in_reply_to":"ff346bd7_3be1a7d1","updated":"2017-07-25 21:40:25.000000000","message":"OK","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"0c73c33b2237c5459ae1184d83993aee65c24d8c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self.assertIsNotNone(port)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_dhcp_create_without_dhcp_flag(self):"},{"line_number":141,"context_line":"        dhcp_driver \u003d driver_base.OdlDhcpDriverBase()"},{"line_number":142,"context_line":"        plugin, ctxt, net_id, subnet_id \u003d self.get_test_parameters()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        network, network_context \u003d self.get_network_context("},{"line_number":145,"context_line":"            net_id, True)"},{"line_number":146,"context_line":"        subnet, subnet_context \u003d self.get_subnet_context("},{"line_number":147,"context_line":"            net_id, subnet_id, \u002710.0.20.0/24\u0027, False, True)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        dhcp_driver.create_or_delete_dhcp_port(subnet_context)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_3be1a7d1","line":147,"range":{"start_line":141,"start_character":7,"end_line":147,"end_character":59},"in_reply_to":"ff346bd7_80fedeab","updated":"2017-07-25 21:36:33.000000000","message":"+1 for helper function.\nIt\u0027s also same to OdlDhcpDriverTestCase. the hellper method can be an attribute of base class.","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        self.assertIsNotNone(port)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_dhcp_create_without_dhcp_flag(self):"},{"line_number":141,"context_line":"        dhcp_driver \u003d driver_base.OdlDhcpDriverBase()"},{"line_number":142,"context_line":"        plugin, ctxt, net_id, subnet_id \u003d self.get_test_parameters()"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        network, network_context \u003d self.get_network_context("},{"line_number":145,"context_line":"            net_id, True)"},{"line_number":146,"context_line":"        subnet, subnet_context \u003d self.get_subnet_context("},{"line_number":147,"context_line":"            net_id, subnet_id, \u002710.0.20.0/24\u0027, False, True)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        dhcp_driver.create_or_delete_dhcp_port(subnet_context)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ff346bd7_7b184f74","line":147,"range":{"start_line":141,"start_character":7,"end_line":147,"end_character":59},"in_reply_to":"ff346bd7_80fedeab","updated":"2017-07-25 21:20:12.000000000","message":"OK","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"5b785b5fb26cadebce980fca30d16d424c329f9d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"cfg.CONF.import_group(\u0027ml2_odl\u0027, \u0027networking_odl.common.config\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class OdlDhcpDriverBase(base_v2.OpenDaylightConfigBase):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"}],"source_content_type":"text/x-python","patch_set":41,"id":"ff346bd7_6f7754d6","line":35,"updated":"2017-07-26 11:51:50.000000000","message":"can we name this as OdlDhcpDriverTestBase as I see the other source file uses this same class name.","commit_id":"b3a0e6cec45a5269eeda90f783fbfcb6d2d65e2a"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"70e2f0a25f5852f5e4b6e4a010581531c4e4b5c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"cfg.CONF.import_group(\u0027ml2_odl\u0027, \u0027networking_odl.common.config\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class OdlDhcpDriverBase(base_v2.OpenDaylightConfigBase):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"}],"source_content_type":"text/x-python","patch_set":41,"id":"ff346bd7_c296123f","line":35,"in_reply_to":"ff346bd7_6f7754d6","updated":"2017-07-26 13:32:45.000000000","message":"Done","commit_id":"b3a0e6cec45a5269eeda90f783fbfcb6d2d65e2a"}],"networking_odl/tests/unit/dhcp/test_odl_dhcp_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":39,"context_line":"ODL_TENANT_ID \u003d uuidutils.generate_uuid()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class OdlDhcpDriverConfigTests(testlib_api.SqlTestCase):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(OdlDhcpDriverConfigTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_5f1abacb","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":56},"updated":"2017-07-18 04:46:18.000000000","message":"Is this class mostly same to test_odl_dhcp_v2.\ndon\u0027t duplicate codes. please consolidate somehow.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":39,"context_line":"ODL_TENANT_ID \u003d uuidutils.generate_uuid()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class OdlDhcpDriverConfigTests(testlib_api.SqlTestCase):"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(OdlDhcpDriverConfigTests, self).setUp()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_910b9428","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":56},"in_reply_to":"1f1a1f67_5f1abacb","updated":"2017-07-18 15:46:56.000000000","message":"Will add these test case to other one.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(OdlDhcpDriverConfigTests, self).setUp()"},{"line_number":46,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":47,"context_line":"        cfg.CONF.set_override(\u0027mechanism_drivers\u0027,"},{"line_number":48,"context_line":"                              [\u0027logger\u0027, \u0027opendaylight_v2\u0027], \u0027ml2\u0027)"},{"line_number":49,"context_line":"        cfg.CONF.set_override(\u0027port_binding_controller\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_9fbf32a9","line":46,"range":{"start_line":46,"start_character":1,"end_line":46,"end_character":63},"updated":"2017-07-18 04:46:18.000000000","message":"Please mock journal thread to prevent thread from running.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def setUp(self):"},{"line_number":45,"context_line":"        super(OdlDhcpDriverConfigTests, self).setUp()"},{"line_number":46,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":47,"context_line":"        cfg.CONF.set_override(\u0027mechanism_drivers\u0027,"},{"line_number":48,"context_line":"                              [\u0027logger\u0027, \u0027opendaylight_v2\u0027], \u0027ml2\u0027)"},{"line_number":49,"context_line":"        cfg.CONF.set_override(\u0027port_binding_controller\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_9c573bcb","line":46,"range":{"start_line":46,"start_character":1,"end_line":46,"end_character":63},"in_reply_to":"1f1a1f67_9fbf32a9","updated":"2017-07-18 15:46:56.000000000","message":"Done","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        super(OdlDhcpDriverV2TestCase, self).setUp()"},{"line_number":72,"context_line":"        cfg.CONF.set_override(\u0027enable_dhcp_port\u0027, True, \u0027ml2_odl\u0027)"},{"line_number":73,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":74,"context_line":"        self.journal \u003d journal.OpenDaylightJournalThread()"},{"line_number":75,"context_line":"        self.db_session \u003d neutron_db_api.get_writer_session()"},{"line_number":76,"context_line":"        self.mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"},{"line_number":77,"context_line":"        self.mech.initialize()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_9fd4d2ea","line":74,"range":{"start_line":74,"start_character":0,"end_line":74,"end_character":58},"updated":"2017-07-18 04:46:18.000000000","message":"Please prevent journal thread from running by mock.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        super(OdlDhcpDriverV2TestCase, self).setUp()"},{"line_number":72,"context_line":"        cfg.CONF.set_override(\u0027enable_dhcp_port\u0027, True, \u0027ml2_odl\u0027)"},{"line_number":73,"context_line":"        self.useFixture(odl_base.OpenDaylightFeaturesFixture())"},{"line_number":74,"context_line":"        self.journal \u003d journal.OpenDaylightJournalThread()"},{"line_number":75,"context_line":"        self.db_session \u003d neutron_db_api.get_writer_session()"},{"line_number":76,"context_line":"        self.mech \u003d mech_driver_v2.OpenDaylightMechanismDriver()"},{"line_number":77,"context_line":"        self.mech.initialize()"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_3ffdbe6d","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":21},"updated":"2017-07-18 04:46:18.000000000","message":"This isn\u0027t used as mech.journal is used.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"672aa66523152c4fa4c32a5b27031f11dc946c81","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertIsNotNone(dhcp_driver)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_dhcp_port_create(self):"},{"line_number":84,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":85,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":88,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        network \u003d OdlDhcpDriverV2TestCase._get_network_context(network_id)"},{"line_number":91,"context_line":"        plugin.create_network(context, network)"},{"line_number":92,"context_line":"        network_context \u003d plugin.get_network(context, network_id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        subnet \u003d OdlDhcpDriverV2TestCase._get_subnet_context("},{"line_number":95,"context_line":"            network_id, subnet_id, \u002710.0.0.0/24\u0027, True)"},{"line_number":96,"context_line":"        plugin.create_subnet(context, subnet)"},{"line_number":97,"context_line":"        subnet_context \u003d driver_context.SubnetContext(plugin, context,"},{"line_number":98,"context_line":"                                                      subnet[\u0027subnet\u0027],"},{"line_number":99,"context_line":"                                                      network_context)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        mech_driver_v2.OpenDaylightMechanismDriver._record_in_journal("},{"line_number":102,"context_line":"            subnet_context, odl_const.ODL_SUBNET, odl_const.ODL_CREATE)"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_5f319a59","line":99,"range":{"start_line":84,"start_character":0,"end_line":99,"end_character":70},"updated":"2017-07-18 04:46:18.000000000","message":"Are those clauses common?\nPlease introduce helper method.","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a767fa5ad13eebc95307d111a82068be3b58937","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertIsNotNone(dhcp_driver)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_dhcp_port_create(self):"},{"line_number":84,"context_line":"        network_id \u003d uuidutils.generate_uuid()"},{"line_number":85,"context_line":"        subnet_id \u003d uuidutils.generate_uuid()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":88,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        network \u003d OdlDhcpDriverV2TestCase._get_network_context(network_id)"},{"line_number":91,"context_line":"        plugin.create_network(context, network)"},{"line_number":92,"context_line":"        network_context \u003d plugin.get_network(context, network_id)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        subnet \u003d OdlDhcpDriverV2TestCase._get_subnet_context("},{"line_number":95,"context_line":"            network_id, subnet_id, \u002710.0.0.0/24\u0027, True)"},{"line_number":96,"context_line":"        plugin.create_subnet(context, subnet)"},{"line_number":97,"context_line":"        subnet_context \u003d driver_context.SubnetContext(plugin, context,"},{"line_number":98,"context_line":"                                                      subnet[\u0027subnet\u0027],"},{"line_number":99,"context_line":"                                                      network_context)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        mech_driver_v2.OpenDaylightMechanismDriver._record_in_journal("},{"line_number":102,"context_line":"            subnet_context, odl_const.ODL_SUBNET, odl_const.ODL_CREATE)"}],"source_content_type":"text/x-python","patch_set":32,"id":"1f1a1f67_bcd9d757","line":99,"range":{"start_line":84,"start_character":0,"end_line":99,"end_character":70},"in_reply_to":"1f1a1f67_5f319a59","updated":"2017-07-18 15:46:56.000000000","message":"Done","commit_id":"48561ff6af2225bf08f31fffa0495dc541695ff9"}],"releasenotes/notes/neutron-dhcp-port-dcbc3a1008f45cc2.yaml":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"94247edeaa1b148417b7226a144d594033268165","unresolved":false,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The feature is to be enabled only when config parameter enable_dhcp_port is set"},{"line_number":8,"context_line":"    to True in ml2_conf.ini. "},{"line_number":9,"context_line":"    Create a new Neutron port when a Subnet is created or when it is updated with"},{"line_number":10,"context_line":"    enable-dhcp parameter."},{"line_number":11,"context_line":"    The allocated port is to be removed when the Subnet is deleted or when it is"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f1d235d_852190a2","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":29},"updated":"2017-07-10 22:10:18.000000000","message":"tailing white space.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"94247edeaa1b148417b7226a144d594033268165","unresolved":false,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The feature is to be enabled only when config parameter enable_dhcp_port is set"},{"line_number":8,"context_line":"    to True in ml2_conf.ini. "},{"line_number":9,"context_line":"    Create a new Neutron port when a Subnet is created or when it is updated with"},{"line_number":10,"context_line":"    enable-dhcp parameter."},{"line_number":11,"context_line":"    The allocated port is to be removed when the Subnet is deleted or when it is"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f1d235d_c219be88","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":29},"updated":"2017-07-10 22:10:18.000000000","message":"trailing white space.","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1099206faa0e6390b84e43a49b008023f1043bc6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The feature is to be enabled only when config parameter enable_dhcp_port is set"},{"line_number":8,"context_line":"    to True in ml2_conf.ini. "},{"line_number":9,"context_line":"    Create a new Neutron port when a Subnet is created or when it is updated with"},{"line_number":10,"context_line":"    enable-dhcp parameter."},{"line_number":11,"context_line":"    The allocated port is to be removed when the Subnet is deleted or when it is"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f1d235d_97ec1b90","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":29},"in_reply_to":"3f1d235d_852190a2","updated":"2017-07-11 08:53:46.000000000","message":"Done","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"1099206faa0e6390b84e43a49b008023f1043bc6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The feature is to be enabled only when config parameter enable_dhcp_port is set"},{"line_number":8,"context_line":"    to True in ml2_conf.ini. "},{"line_number":9,"context_line":"    Create a new Neutron port when a Subnet is created or when it is updated with"},{"line_number":10,"context_line":"    enable-dhcp parameter."},{"line_number":11,"context_line":"    The allocated port is to be removed when the Subnet is deleted or when it is"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f1d235d_7703bf43","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":29},"in_reply_to":"3f1d235d_c219be88","updated":"2017-07-11 08:53:46.000000000","message":"Done","commit_id":"6794e653952cd843d6e4c0ec0b776c9a665507e5"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e6a5b8780db216578f86716e2afe6db12f2ece76","unresolved":false,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The feature is to be enabled only when config parameter enable_dhcp_port is set"},{"line_number":8,"context_line":"    to True in ml2_conf.ini."},{"line_number":9,"context_line":"    Create a new Neutron port when a Subnet is created or when it is updated with"},{"line_number":10,"context_line":"    enable-dhcp parameter."},{"line_number":11,"context_line":"    The allocated port is to be removed when the Subnet is deleted or when it is"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"1f1a1f67_fde0e9fc","line":8,"updated":"2017-07-21 09:09:45.000000000","message":"please fix this content accordingly based on inputs in config.py and commit message.","commit_id":"4ee2d3b470526fe41e4e94c11b2613372660cca6"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"9481f7a601aabaeaec3485770692f9a79910bc84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    OpenDaylight controller DHCP service."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The feature is to be enabled only when config parameter enable_dhcp_port is set"},{"line_number":8,"context_line":"    to True in ml2_conf.ini."},{"line_number":9,"context_line":"    Create a new Neutron port when a Subnet is created or when it is updated with"},{"line_number":10,"context_line":"    enable-dhcp parameter."},{"line_number":11,"context_line":"    The allocated port is to be removed when the Subnet is deleted or when it is"},{"line_number":12,"context_line":"    updated with disbale-dhcp parameter."},{"line_number":13,"context_line":"    The port is identifed with device-id as OpenDaylight-\u003csubnet-id\u003e and device-owner"},{"line_number":14,"context_line":"    as network:dhcp."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff346bd7_558b1a1e","line":14,"range":{"start_line":7,"start_character":3,"end_line":14,"end_character":20},"updated":"2017-07-25 20:44:12.000000000","message":"align this in a paragraph, and also mention this is just enabling it for mechanism_v2.","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"a8a651cf0f29175f3262becaa395bab5880d0d7c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    OpenDaylight controller DHCP service."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    The feature is to be enabled only when config parameter enable_dhcp_port is set"},{"line_number":8,"context_line":"    to True in ml2_conf.ini."},{"line_number":9,"context_line":"    Create a new Neutron port when a Subnet is created or when it is updated with"},{"line_number":10,"context_line":"    enable-dhcp parameter."},{"line_number":11,"context_line":"    The allocated port is to be removed when the Subnet is deleted or when it is"},{"line_number":12,"context_line":"    updated with disbale-dhcp parameter."},{"line_number":13,"context_line":"    The port is identifed with device-id as OpenDaylight-\u003csubnet-id\u003e and device-owner"},{"line_number":14,"context_line":"    as network:dhcp."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"ff346bd7_5b4eab6f","line":14,"range":{"start_line":7,"start_character":3,"end_line":14,"end_character":20},"in_reply_to":"ff346bd7_558b1a1e","updated":"2017-07-25 21:20:12.000000000","message":"OK","commit_id":"ec528e6df4ae32c470b7b4ed6e99e7c04ae3d34f"}]}
