)]}'
{"networking_odl/ml2/mech_driver_v2.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4f2630f55c35d20ca7799ec683bb95c77da0a7a8","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        sg \u003d resource_dict[\u0027security_group\u0027]"},{"line_number":175,"context_line":"        sg_id \u003d resource_dict[\u0027id\u0027]"},{"line_number":176,"context_line":"        res \u003d {"},{"line_number":177,"context_line":"            \u0027id\u0027: sg_id,"},{"line_number":178,"context_line":"            \u0027name\u0027: sg[\u0027name\u0027],"},{"line_number":179,"context_line":"            \u0027tenant_id\u0027: sg[\u0027tenant_id\u0027],"},{"line_number":180,"context_line":"            \u0027description\u0027: sg[\u0027description\u0027],"},{"line_number":181,"context_line":"            \u0027is_default\u0027: resource_dict[\u0027is_default\u0027]"},{"line_number":182,"context_line":"        }"},{"line_number":183,"context_line":"        journal.record(context, object_type, sg_id, operation, res)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_d1f551cc","line":181,"range":{"start_line":176,"start_character":12,"end_line":181,"end_character":53},"updated":"2017-06-19 17:08:21.000000000","message":"I guess project_id should also be added ? as neutron has both tenant_id and project_id in the fields at some point tenant_id will be deprecated.","commit_id":"e3bdf4b940bd5d22a7c33a51ffb709c70766e501"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d13cc2fa2e9912be254c6b9f47d655ed46d56060","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # NOTE(yamahata): when security group is created, default rules"},{"line_number":186,"context_line":"        # are also created."},{"line_number":187,"context_line":"        for direction in (\u0027egress_rule\u0027, \u0027ingress_rule\u0027):"},{"line_number":188,"context_line":"            rule \u003d resource_dict.get(direction)"},{"line_number":189,"context_line":"            if rule is None:"},{"line_number":190,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_890c90a5","line":187,"updated":"2017-06-16 06:02:00.000000000","message":"there should be rules for each sg_supported_ethertypes i guess.","commit_id":"e3bdf4b940bd5d22a7c33a51ffb709c70766e501"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4f2630f55c35d20ca7799ec683bb95c77da0a7a8","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # NOTE(yamahata): when security group is created, default rules"},{"line_number":186,"context_line":"        # are also created."},{"line_number":187,"context_line":"        for direction in (\u0027egress_rule\u0027, \u0027ingress_rule\u0027):"},{"line_number":188,"context_line":"            rule \u003d resource_dict.get(direction)"},{"line_number":189,"context_line":"            if rule is None:"},{"line_number":190,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_91c23952","line":187,"in_reply_to":"7f231b9d_890c90a5","updated":"2017-06-19 17:08:21.000000000","message":"+1 ingress and egress for supported ethertypes(ipv4 and ipv6).","commit_id":"e3bdf4b940bd5d22a7c33a51ffb709c70766e501"}]}