)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e4fea9efe8ff8061f7aa0b51ce8a275bdbe695ec","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"journal: sleep when error\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This was pushed without proper review, let\u0027s review this like we should."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This reverts commit 473477441a62b401ad9edd997e9442ae7638be14."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_dd4abc7e","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":37},"updated":"2017-07-31 23:31:39.000000000","message":"i\u0027m not sure what made you think it was not proper.\nit seems self-approving is rather common in networking-odl.\ncan you explain?","commit_id":"50bac4e66cc1f6d7f7fb68f4b99a77bea456b6f3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"94055610452d3d0a08bc710efd06e9e496636653","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"journal: sleep when error\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This was pushed without proper review, let\u0027s review this like we should."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This reverts commit 473477441a62b401ad9edd997e9442ae7638be14."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_56cf5455","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":37},"in_reply_to":"9f436f4f_2ffb6579","updated":"2017-08-14 23:24:59.000000000","message":"ok, it was not clear to me if networking-odl folks considered it a problem, given the number of patches being self-approved right now.  thank you for explanation. i fully agree the current situation is not ideal.","commit_id":"50bac4e66cc1f6d7f7fb68f4b99a77bea456b6f3"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"aa6d38029b513d0a508e42372aa4bf5803c7b22e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"journal: sleep when error\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This was pushed without proper review, let\u0027s review this like we should."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This reverts commit 473477441a62b401ad9edd997e9442ae7638be14."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f436f4f_2ffb6579","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":37},"in_reply_to":"df3967d1_dd4abc7e","updated":"2017-08-14 15:35:53.000000000","message":"Self-approving is a problem when there aren\u0027t enough reviewers so it\u0027s not a good solution.\n\nIn this case there are two active reviewers (Isaku \u0026 myself) so it\u0027s not appropriate in this case to self approve after two days, perhaps we can set a policy that after two weeks its ok for small changes, or that you can self approve quickly if it\u0027s something urgent (gate break for example).\n\nIn case of just adding functionality, I don\u0027t see it as appropriate conduct in an open source project.","commit_id":"50bac4e66cc1f6d7f7fb68f4b99a77bea456b6f3"}]}