)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b3ac389d0f151353933014bf5b1fc17f55e9476a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Functional Test for OpenDaylight DHCP Service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set adds Functional Test for OpenDaylight DHCP Service."},{"line_number":10,"context_line":" "},{"line_number":11,"context_line":"Change-Id: I69b5a320aa04a901abebad41df1165a137ab9d28"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_a04336af","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":1},"updated":"2017-08-01 20:11:49.000000000","message":"nit : trailing whitespace","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce0fc20a2191f4d329bff1c5bd771c9bf1d858f6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Functional Test for OpenDaylight DHCP Service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set adds Functional Test for OpenDaylight DHCP Service."},{"line_number":10,"context_line":" "},{"line_number":11,"context_line":"Change-Id: I69b5a320aa04a901abebad41df1165a137ab9d28"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df3967d1_c403d772","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":1},"in_reply_to":"df3967d1_a04336af","updated":"2017-08-02 07:31:06.000000000","message":"Done","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"}],"networking_odl/tests/functional/test_odl_dhcp_driver.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b3ac389d0f151353933014bf5b1fc17f55e9476a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"from neutron_lib import constants as n_const"},{"line_number":16,"context_line":"from neutron_lib import context as neutron_context"},{"line_number":17,"context_line":"from neutron_lib.plugins import directory"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.plugins.ml2 import config"},{"line_number":20,"context_line":"from neutron.tests.unit.plugins.ml2 import test_plugin"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":23,"context_line":"from networking_odl.dhcp import odl_dhcp_driver_base as driver_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_b4eb73da","line":20,"range":{"start_line":15,"start_character":1,"end_line":20,"end_character":53},"updated":"2017-08-01 20:11:49.000000000","message":"all third party import can be grouped together","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce0fc20a2191f4d329bff1c5bd771c9bf1d858f6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"from neutron_lib import constants as n_const"},{"line_number":16,"context_line":"from neutron_lib import context as neutron_context"},{"line_number":17,"context_line":"from neutron_lib.plugins import directory"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.plugins.ml2 import config"},{"line_number":20,"context_line":"from neutron.tests.unit.plugins.ml2 import test_plugin"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from networking_odl.common import constants as odl_const"},{"line_number":23,"context_line":"from networking_odl.dhcp import odl_dhcp_driver_base as driver_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_042f9ff6","line":20,"range":{"start_line":15,"start_character":1,"end_line":20,"end_character":53},"in_reply_to":"df3967d1_b4eb73da","updated":"2017-08-02 07:31:06.000000000","message":"Done","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b3ac389d0f151353933014bf5b1fc17f55e9476a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            port \u003d ports[0]"},{"line_number":47,"context_line":"            return port[\u0027id\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def port(self, network, subnet):"},{"line_number":50,"context_line":"        port_id \u003d self.get_port_id("},{"line_number":51,"context_line":"            network[odl_const.ODL_NETWORK][\u0027id\u0027],"},{"line_number":52,"context_line":"            subnet[odl_const.ODL_SUBNET][\u0027id\u0027])"},{"line_number":53,"context_line":"        return {odl_const.ODL_PORT: {\u0027id\u0027: port_id}}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_plugin_and_context(self):"},{"line_number":56,"context_line":"        context \u003d neutron_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_948aaf18","line":53,"range":{"start_line":49,"start_character":4,"end_line":53,"end_character":52},"updated":"2017-08-01 20:11:49.000000000","message":"this helper can be avoided it isn\u0027t of much help or can be consolidated to get_port_id and renamed to get_port_data or something ?","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce0fc20a2191f4d329bff1c5bd771c9bf1d858f6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            port \u003d ports[0]"},{"line_number":47,"context_line":"            return port[\u0027id\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def port(self, network, subnet):"},{"line_number":50,"context_line":"        port_id \u003d self.get_port_id("},{"line_number":51,"context_line":"            network[odl_const.ODL_NETWORK][\u0027id\u0027],"},{"line_number":52,"context_line":"            subnet[odl_const.ODL_SUBNET][\u0027id\u0027])"},{"line_number":53,"context_line":"        return {odl_const.ODL_PORT: {\u0027id\u0027: port_id}}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_plugin_and_context(self):"},{"line_number":56,"context_line":"        context \u003d neutron_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_c41197ae","line":53,"range":{"start_line":49,"start_character":4,"end_line":53,"end_character":52},"in_reply_to":"df3967d1_948aaf18","updated":"2017-08-02 07:31:06.000000000","message":"Renamed to get_port_data, get_port_id is required for second test case, hence retaining as is.","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c9a3d55f4aacc2734c0c92558fa48149f0f1ad74","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        with self.network() as network:"},{"line_number":69,"context_line":"            with self.subnet(network\u003dnetwork, enable_dhcp\u003dFalse) as subnet:"},{"line_number":70,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"},{"line_number":71,"context_line":"                plugin, context \u003d self.get_plugin_and_context()"},{"line_number":72,"context_line":"                subnet[odl_const.ODL_SUBNET][\u0027enable_dhcp\u0027] \u003d True"},{"line_number":73,"context_line":"                plugin.update_subnet("},{"line_number":74,"context_line":"                    context, subnet[odl_const.ODL_SUBNET][\u0027id\u0027], subnet)"},{"line_number":75,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_669566e4","line":72,"range":{"start_line":71,"start_character":63,"end_line":72,"end_character":16},"updated":"2017-08-01 16:41:01.000000000","message":"Here, we\u0027d like to test if dhcp port isn\u0027t created.\nThis is symetric to the following test.","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce0fc20a2191f4d329bff1c5bd771c9bf1d858f6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        with self.network() as network:"},{"line_number":69,"context_line":"            with self.subnet(network\u003dnetwork, enable_dhcp\u003dFalse) as subnet:"},{"line_number":70,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"},{"line_number":71,"context_line":"                plugin, context \u003d self.get_plugin_and_context()"},{"line_number":72,"context_line":"                subnet[odl_const.ODL_SUBNET][\u0027enable_dhcp\u0027] \u003d True"},{"line_number":73,"context_line":"                plugin.update_subnet("},{"line_number":74,"context_line":"                    context, subnet[odl_const.ODL_SUBNET][\u0027id\u0027], subnet)"},{"line_number":75,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_44d6c7f3","line":72,"range":{"start_line":71,"start_character":63,"end_line":72,"end_character":16},"in_reply_to":"df3967d1_39b53cce","updated":"2017-08-02 07:31:06.000000000","message":"Done","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"7a9311e9b4f7b1720de53281f6cb3e7d831e02fd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        with self.network() as network:"},{"line_number":69,"context_line":"            with self.subnet(network\u003dnetwork, enable_dhcp\u003dFalse) as subnet:"},{"line_number":70,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"},{"line_number":71,"context_line":"                plugin, context \u003d self.get_plugin_and_context()"},{"line_number":72,"context_line":"                subnet[odl_const.ODL_SUBNET][\u0027enable_dhcp\u0027] \u003d True"},{"line_number":73,"context_line":"                plugin.update_subnet("},{"line_number":74,"context_line":"                    context, subnet[odl_const.ODL_SUBNET][\u0027id\u0027], subnet)"},{"line_number":75,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_3949bc8a","line":72,"range":{"start_line":71,"start_character":63,"end_line":72,"end_character":16},"in_reply_to":"df3967d1_39b53cce","updated":"2017-08-01 19:48:15.000000000","message":"Ok, Will not be able get port_id like the other case, will query on neutron db and assert for not present.","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f0315dc93032bb7fc82ddd1e575bcbbe673ff569","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        with self.network() as network:"},{"line_number":69,"context_line":"            with self.subnet(network\u003dnetwork, enable_dhcp\u003dFalse) as subnet:"},{"line_number":70,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"},{"line_number":71,"context_line":"                plugin, context \u003d self.get_plugin_and_context()"},{"line_number":72,"context_line":"                subnet[odl_const.ODL_SUBNET][\u0027enable_dhcp\u0027] \u003d True"},{"line_number":73,"context_line":"                plugin.update_subnet("},{"line_number":74,"context_line":"                    context, subnet[odl_const.ODL_SUBNET][\u0027id\u0027], subnet)"},{"line_number":75,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_39b53cce","line":72,"range":{"start_line":71,"start_character":63,"end_line":72,"end_character":16},"in_reply_to":"df3967d1_51021e0b","updated":"2017-08-01 19:33:08.000000000","message":"Yes, exactly.","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b3ac389d0f151353933014bf5b1fc17f55e9476a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        with self.network() as network:"},{"line_number":69,"context_line":"            with self.subnet(network\u003dnetwork, enable_dhcp\u003dFalse) as subnet:"},{"line_number":70,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"},{"line_number":71,"context_line":"                plugin, context \u003d self.get_plugin_and_context()"},{"line_number":72,"context_line":"                subnet[odl_const.ODL_SUBNET][\u0027enable_dhcp\u0027] \u003d True"},{"line_number":73,"context_line":"                plugin.update_subnet("},{"line_number":74,"context_line":"                    context, subnet[odl_const.ODL_SUBNET][\u0027id\u0027], subnet)"},{"line_number":75,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_b4eed3b1","line":72,"range":{"start_line":71,"start_character":63,"end_line":72,"end_character":16},"in_reply_to":"df3967d1_669566e4","updated":"2017-08-01 20:11:49.000000000","message":"+1 to assert if port doesn\u0027t exist","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"dff0e3a643398d044d208ec6e1ebf17d3d9dabc9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        with self.network() as network:"},{"line_number":69,"context_line":"            with self.subnet(network\u003dnetwork, enable_dhcp\u003dFalse) as subnet:"},{"line_number":70,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"},{"line_number":71,"context_line":"                plugin, context \u003d self.get_plugin_and_context()"},{"line_number":72,"context_line":"                subnet[odl_const.ODL_SUBNET][\u0027enable_dhcp\u0027] \u003d True"},{"line_number":73,"context_line":"                plugin.update_subnet("},{"line_number":74,"context_line":"                    context, subnet[odl_const.ODL_SUBNET][\u0027id\u0027], subnet)"},{"line_number":75,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_51021e0b","line":72,"range":{"start_line":71,"start_character":63,"end_line":72,"end_character":16},"in_reply_to":"df3967d1_669566e4","updated":"2017-08-01 16:45:23.000000000","message":"OK, you want me to add assert to check if port is not created?","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"ce0fc20a2191f4d329bff1c5bd771c9bf1d858f6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        with self.network() as network:"},{"line_number":69,"context_line":"            with self.subnet(network\u003dnetwork, enable_dhcp\u003dFalse) as subnet:"},{"line_number":70,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"},{"line_number":71,"context_line":"                plugin, context \u003d self.get_plugin_and_context()"},{"line_number":72,"context_line":"                subnet[odl_const.ODL_SUBNET][\u0027enable_dhcp\u0027] \u003d True"},{"line_number":73,"context_line":"                plugin.update_subnet("},{"line_number":74,"context_line":"                    context, subnet[odl_const.ODL_SUBNET][\u0027id\u0027], subnet)"},{"line_number":75,"context_line":"                self.get_odl_resource(odl_const.ODL_SUBNET, subnet)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_64db0b1b","line":72,"range":{"start_line":71,"start_character":63,"end_line":72,"end_character":16},"in_reply_to":"df3967d1_b4eed3b1","updated":"2017-08-02 07:31:06.000000000","message":"Done","commit_id":"079873d0d2fc424aba3efbf9d312d5f7cbdac66b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1e64979d4c445b83a389dd4f140146d5308484cf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            port \u003d ports[0]"},{"line_number":46,"context_line":"            return port[\u0027id\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get_port_data(self, network, subnet):"},{"line_number":49,"context_line":"        port_id \u003d self.get_port_id("},{"line_number":50,"context_line":"            network[odl_const.ODL_NETWORK][\u0027id\u0027],"},{"line_number":51,"context_line":"            subnet[odl_const.ODL_SUBNET][\u0027id\u0027])"},{"line_number":52,"context_line":"        return {odl_const.ODL_PORT: {\u0027id\u0027: port_id}}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_plugin_and_context(self):"},{"line_number":55,"context_line":"        context \u003d neutron_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_525b1b53","line":52,"range":{"start_line":48,"start_character":5,"end_line":52,"end_character":52},"updated":"2017-08-02 15:44:36.000000000","message":"as I said earlier, this can be consolidated to get_port_id, can also be called in second test case you can extract id from port data withing the test case, one liner helpers isn\u0027t a good idea","commit_id":"d6ee9d3a9abd0c5bef0e4fe4083aad18fff11721"},{"author":{"_account_id":25544,"name":"Karthik Prasad","email":"adkp.mlr@gmail.com","username":"karthik.prasad"},"change_message_id":"36ae769398d791f6b548516c6c4fdf219e18f0c3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            port \u003d ports[0]"},{"line_number":46,"context_line":"            return port[\u0027id\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get_port_data(self, network, subnet):"},{"line_number":49,"context_line":"        port_id \u003d self.get_port_id("},{"line_number":50,"context_line":"            network[odl_const.ODL_NETWORK][\u0027id\u0027],"},{"line_number":51,"context_line":"            subnet[odl_const.ODL_SUBNET][\u0027id\u0027])"},{"line_number":52,"context_line":"        return {odl_const.ODL_PORT: {\u0027id\u0027: port_id}}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_plugin_and_context(self):"},{"line_number":55,"context_line":"        context \u003d neutron_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_068e71cf","line":52,"range":{"start_line":48,"start_character":5,"end_line":52,"end_character":52},"in_reply_to":"df3967d1_525b1b53","updated":"2017-08-02 17:34:51.000000000","message":"Done","commit_id":"d6ee9d3a9abd0c5bef0e4fe4083aad18fff11721"}]}
