)]}'
{"networking_odl/journal/full_sync.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"42385e1a4e9dafa13de20808953e5b2845c9b410","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    db.delete_pending_rows(context.session, _OPS_TO_DELETE_ON_SYNC)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    for resource_type in _ORDERED_ODL_RESOURCES:"},{"line_number":82,"context_line":"        for plugin_alias, resource in ALL_RESOURCES.items():"},{"line_number":83,"context_line":"            collection_name \u003d resource.get(resource_type)"},{"line_number":84,"context_line":"            if collection_name is not None:"},{"line_number":85,"context_line":"                plugin \u003d directory.get_plugin(plugin_alias)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_ef03a20e","line":82,"range":{"start_line":82,"start_character":38,"end_line":82,"end_character":51},"updated":"2017-08-08 23:07:36.000000000","message":"how can ALL_RESOURCES have an unloaded plugin?","commit_id":"3b8117df7ab87f4092820e3b974ab9ee6625dc7a"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c5b7b899b36ee4f7e67f21c6e4206af8fbd3ec82","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    db.delete_pending_rows(context.session, _OPS_TO_DELETE_ON_SYNC)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    for resource_type in _ORDERED_ODL_RESOURCES:"},{"line_number":82,"context_line":"        for plugin_alias, resource in ALL_RESOURCES.items():"},{"line_number":83,"context_line":"            collection_name \u003d resource.get(resource_type)"},{"line_number":84,"context_line":"            if collection_name is not None:"},{"line_number":85,"context_line":"                plugin \u003d directory.get_plugin(plugin_alias)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_02cc455f","line":82,"range":{"start_line":82,"start_character":38,"end_line":82,"end_character":51},"in_reply_to":"9f436f4f_80918055","updated":"2017-08-10 15:30:50.000000000","message":"+1.\nThe issue is qos driver wrongly uses \"QOS\" instead of \"qos\"","commit_id":"3b8117df7ab87f4092820e3b974ab9ee6625dc7a"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c3fc23a8a516be821ab06a79fadf7a235b00a1db","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    db.delete_pending_rows(context.session, _OPS_TO_DELETE_ON_SYNC)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    for resource_type in _ORDERED_ODL_RESOURCES:"},{"line_number":82,"context_line":"        for plugin_alias, resource in ALL_RESOURCES.items():"},{"line_number":83,"context_line":"            collection_name \u003d resource.get(resource_type)"},{"line_number":84,"context_line":"            if collection_name is not None:"},{"line_number":85,"context_line":"                plugin \u003d directory.get_plugin(plugin_alias)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_80918055","line":82,"range":{"start_line":82,"start_character":38,"end_line":82,"end_character":51},"in_reply_to":"9f436f4f_ef03a20e","updated":"2017-08-09 05:54:46.000000000","message":"yeah, when a plugins gets loaded then it should register at ALL_RESOURCES, if they were not loaded then it won\u0027t get registered.","commit_id":"3b8117df7ab87f4092820e3b974ab9ee6625dc7a"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c3fc23a8a516be821ab06a79fadf7a235b00a1db","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        for plugin_alias, resource in ALL_RESOURCES.items():"},{"line_number":83,"context_line":"            collection_name \u003d resource.get(resource_type)"},{"line_number":84,"context_line":"            if collection_name is not None:"},{"line_number":85,"context_line":"                plugin \u003d directory.get_plugin(plugin_alias)"},{"line_number":86,"context_line":"                if plugin is None:"},{"line_number":87,"context_line":"                    LOG.debug(\"Skipping %s in full sync because of missing \""},{"line_number":88,"context_line":"                              \"plugin %s\", collection_name, plugin_alias)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_8024e00e","line":85,"range":{"start_line":85,"start_character":46,"end_line":85,"end_character":58},"updated":"2017-08-09 05:54:46.000000000","message":"May be the alias being registered and used in this code is different therefore get_plugin method returns None.\n\nBTW what are the plugins you have enabled in the setup?","commit_id":"3b8117df7ab87f4092820e3b974ab9ee6625dc7a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"42385e1a4e9dafa13de20808953e5b2845c9b410","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            if collection_name is not None:"},{"line_number":85,"context_line":"                plugin \u003d directory.get_plugin(plugin_alias)"},{"line_number":86,"context_line":"                if plugin is None:"},{"line_number":87,"context_line":"                    LOG.debug(\"Skipping %s in full sync because of missing \""},{"line_number":88,"context_line":"                              \"plugin %s\", collection_name, plugin_alias)"},{"line_number":89,"context_line":"                else:"},{"line_number":90,"context_line":"                    _sync_resources(plugin, context, resource_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_0bfff901","line":87,"range":{"start_line":87,"start_character":24,"end_line":87,"end_character":29},"updated":"2017-08-08 23:07:36.000000000","message":"i suppose it should be higher than debug.","commit_id":"3b8117df7ab87f4092820e3b974ab9ee6625dc7a"}],"networking_odl/qos/qos_driver_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"15f9179d1545ed18d9064a01d04b2ee6f70c0f4c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            requires_rpc_notifications)"},{"line_number":70,"context_line":"        LOG.debug(\"Initializing OpenDaylight Qos driver\")"},{"line_number":71,"context_line":"        self.journal \u003d journal.OpenDaylightJournalThread()"},{"line_number":72,"context_line":"        full_sync.register(odl_const.ODL_QOS, QOS_RESOURCES)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _record_in_journal(self, context, op_const, qos_policy):"},{"line_number":75,"context_line":"        data \u003d qos_utils.convert_rules_format(qos_policy.to_dict())"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_bd934ba3","line":72,"range":{"start_line":72,"start_character":27,"end_line":72,"end_character":44},"updated":"2017-08-11 00:10:03.000000000","message":"odl_const includes constants for ODL Neutron Northbound.\nIn this case, neutron.extensions.qos.ALIAS is the value.","commit_id":"068589b13f9d9ecb441541f14c504868042eb013"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"e4dad872e17c41347b9a6a241e8fbd41f5cc4bd2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            requires_rpc_notifications)"},{"line_number":70,"context_line":"        LOG.debug(\"Initializing OpenDaylight Qos driver\")"},{"line_number":71,"context_line":"        self.journal \u003d journal.OpenDaylightJournalThread()"},{"line_number":72,"context_line":"        full_sync.register(odl_const.ODL_QOS, QOS_RESOURCES)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _record_in_journal(self, context, op_const, qos_policy):"},{"line_number":75,"context_line":"        data \u003d qos_utils.convert_rules_format(qos_policy.to_dict())"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_9edbd3eb","line":72,"range":{"start_line":72,"start_character":27,"end_line":72,"end_character":44},"in_reply_to":"9f436f4f_bd934ba3","updated":"2017-08-11 10:35:29.000000000","message":"I checked https://github.com/openstack/neutron/blob/af308ca0da8d74f807b1e54d6ee195fc36ed761a/neutron/manager.py#L211 it seems neutron expect a method get_plugin_type from each plugin and uses it to register to directory. I checked code of each plugin and seems constants are alright.\n\nhttps://github.com/openstack/neutron/blob/af308ca0da8d74f807b1e54d6ee195fc36ed761a/neutron/manager.py#L176 will lead to \"QOS\" as plugin type.\n\nMike,\nCan you please share the details like plugins enabled etc.","commit_id":"068589b13f9d9ecb441541f14c504868042eb013"}]}
