)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"cdde033aed24ff7d02506cf64e2a126af66ad2c6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes to PEP8 checks when running test with tox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The tools that are required for tox to run the PEP8 checks do not work"},{"line_number":10,"context_line":"with python3. This change forces the use of python2 for those tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icc8cb50328c209a41b560411bf8c6db9a4829168"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f436f4f_f33eb627","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":59},"updated":"2017-08-10 14:35:30.000000000","message":"which tools requires python2?\nIs it difficult to fix it?","commit_id":"531d189fbb33273b0f92a8371c886930e84a946f"}],"networking_odl/lbaas/lbaasv2_driver_v2.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b09bec3a17a64431f70408eec8c67c4ec2b0ec65","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # TODO(rajivk): implement this method"},{"line_number":113,"context_line":"        pass"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @log_helpers.log_method_call"},{"line_number":116,"context_line":"    @driver_base.driver_op"},{"line_number":117,"context_line":"    def db_delete_method(self):"},{"line_number":118,"context_line":"        # TODO(mpeterson): implement this method"},{"line_number":119,"context_line":"        pass"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class ODLListenerManager(OpenDaylightManager,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_676991f7","line":119,"range":{"start_line":115,"start_character":2,"end_line":119,"end_character":12},"updated":"2017-08-14 16:30:48.000000000","message":"from commit message, I\u0027d suggest to do this in a separate patch or update commit message.","commit_id":"615dcd6089645d9c38508f79b67b22e7a8234355"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"3f5b17373b6fbe79b62c0c836826e1d5ebbd8721","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        # TODO(rajivk): implement this method"},{"line_number":113,"context_line":"        pass"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @log_helpers.log_method_call"},{"line_number":116,"context_line":"    @driver_base.driver_op"},{"line_number":117,"context_line":"    def db_delete_method(self):"},{"line_number":118,"context_line":"        # TODO(mpeterson): implement this method"},{"line_number":119,"context_line":"        pass"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class ODLListenerManager(OpenDaylightManager,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f436f4f_98005003","line":119,"range":{"start_line":115,"start_character":2,"end_line":119,"end_character":12},"in_reply_to":"9f436f4f_676991f7","updated":"2017-08-14 17:49:31.000000000","message":"Please refer to\nhttps://review.openstack.org/gitweb?p\u003dopenstack/neutron-lbaas.git;a\u003dblob;f\u003dneutron_lbaas/drivers/driver_base.py;h\u003dd4d963032d0bc3f14f698f55019c1fb0ab5fce4f;hb\u003dHEAD#l161\n\nthis method should be driver_base.BaseLoadBalancerManager.db_delete_method.\nAnd also refer to https://review.openstack.org/#/c/471974/7/networking_odl/lbaas/driver_v2.py\n\nIt looks like that pylint doesn\u0027t handle @property with abstractclass well.","commit_id":"615dcd6089645d9c38508f79b67b22e7a8234355"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"aacba4fe2c490122499471586ac6d18e1507dd8f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    # pylint raises false positive of abstract-class-instantiated"},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def db_delete_method(self):"},{"line_number":119,"context_line":"        return driver_base.BaseLoadBalancerManager.db_delete_method"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class ODLListenerManager(OpenDaylightManager,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_2cad9ce8","line":119,"updated":"2017-08-15 06:43:43.000000000","message":"That no test caught my mistake is worrisome. We need to implement a basic test that at least checks that this property returns the value of the property of the parent class that implements the method.","commit_id":"972f354cbe14f60b8af58bc6ad5f123efa449ced"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a8d5a741778ef70ef97c9ada7738dfa02cdf22c1","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    # pylint raises false positive of abstract-class-instantiated"},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def db_delete_method(self):"},{"line_number":119,"context_line":"        return driver_base.BaseLoadBalancerManager.db_delete_method"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class ODLListenerManager(OpenDaylightManager,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_4f20bbf7","line":119,"in_reply_to":"9f436f4f_2cad9ce8","updated":"2017-08-15 22:28:49.000000000","message":"volunteer to write some tests?","commit_id":"972f354cbe14f60b8af58bc6ad5f123efa449ced"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"f7273fe60218131971f80ba5b08cab4335bf404d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    # pylint raises false positive of abstract-class-instantiated"},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def db_delete_method(self):"},{"line_number":119,"context_line":"        return driver_base.BaseLoadBalancerManager.db_delete_method"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class ODLListenerManager(OpenDaylightManager,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_98159e3f","line":119,"in_reply_to":"9f436f4f_4f20bbf7","updated":"2017-08-17 10:42:06.000000000","message":"Done","commit_id":"972f354cbe14f60b8af58bc6ad5f123efa449ced"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"a53a3da8ca9e3c04b19b07963bf636a96f2ee441","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    # pylint raises false positive of abstract-class-instantiated"},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def db_delete_method(self):"},{"line_number":119,"context_line":"        return driver_base.BaseLoadBalancerManager.db_delete_method"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"class ODLListenerManager(OpenDaylightManager,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_ce9008f0","line":119,"in_reply_to":"9f436f4f_4f20bbf7","updated":"2017-08-17 07:23:58.000000000","message":"Sure, I\u0027ll take a look at it asap. At least I will add a simple test with a TODO note.\n\nCan move to workflow +2?","commit_id":"972f354cbe14f60b8af58bc6ad5f123efa449ced"}],"test-requirements.txt":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"8ee84a0c6ebbf24ea126e1854695cc6b84f3ebfe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"doc8 # Apache-2.0"},{"line_number":9,"context_line":"flake8-import-order\u003d\u003d0.13 # LGPLv3"},{"line_number":10,"context_line":"python-subunit\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":11,"context_line":"sphinx\u003e\u003d1.6.2 # BSD"},{"line_number":12,"context_line":"openstackdocstheme\u003e\u003d1.16.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"9f436f4f_df0fec34","line":9,"updated":"2017-08-14 10:15:19.000000000","message":"do we want \u003e\u003d instead of \u003d\u003d?","commit_id":"50c6c7fd27ee5ac078441ef6a5fe69f9741bff3b"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"8ee84a0c6ebbf24ea126e1854695cc6b84f3ebfe","unresolved":false,"context_lines":[{"line_number":12,"context_line":"openstackdocstheme\u003e\u003d1.16.0 # Apache-2.0"},{"line_number":13,"context_line":"oslotest\u003e\u003d1.10.0 # Apache-2.0"},{"line_number":14,"context_line":"os-testr\u003e\u003d0.8.0 # Apache-2.0"},{"line_number":15,"context_line":"pylint\u003d\u003d1.7.2 # GPLv2"},{"line_number":16,"context_line":"testrepository\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":17,"context_line":"testresources\u003e\u003d0.2.4 # Apache-2.0/BSD"},{"line_number":18,"context_line":"testscenarios\u003e\u003d0.4 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":2,"id":"9f436f4f_bf0c2841","line":15,"updated":"2017-08-14 10:15:19.000000000","message":"do we want \u003e\u003d instead of \u003d\u003d?","commit_id":"50c6c7fd27ee5ac078441ef6a5fe69f9741bff3b"}]}